Re: [lldb-dev] [PATCH] Fix boolean typo

2017-12-24 Thread Zachary Turner via lldb-dev
A couple of things: 1) This bug is copy-pasted in 3 locations. That suggests to me that this should be raised into a function that can be fixed once. Something like: static void printNewLineIfNecessary(Stream &S, StringRef Format); 2) I don't think the new check does what you expect either. T

[lldb-dev] [PATCH] Fix boolean typo

2017-12-24 Thread Michael McConville via lldb-dev
In its current form, the below condition always evaluates to true. It seems like the author meant to use "&&" rather than "||". Someone more familiar with the code should verify this. Thanks for your time, Michael McConville University of Utah Index: Module.cpp ===