[Lldb-commits] [lldb] Revert "Read and store gnu build id from loaded core file" (PR #92181)

2024-05-14 Thread via lldb-commits
https://github.com/GeorgeHuyubo created https://github.com/llvm/llvm-project/pull/92181 Reverts llvm/llvm-project#92078 >From 38c358868dfb6d22c7e27032ad910c9f4e61092f Mon Sep 17 00:00:00 2001 From: GeorgeHuyubo <113479859+georgehuy...@users.noreply.github.com> Date: Tue, 14 May 2024 14:35:56 -0

[Lldb-commits] [lldb] 5bf653c - Revert "Read and store gnu build id from loaded core file" (#92181)

2024-05-14 Thread via lldb-commits
Author: GeorgeHuyubo Date: 2024-05-14T14:36:17-07:00 New Revision: 5bf653ca42dceb8266a0ff70634292ccd2ad4c43 URL: https://github.com/llvm/llvm-project/commit/5bf653ca42dceb8266a0ff70634292ccd2ad4c43 DIFF: https://github.com/llvm/llvm-project/commit/5bf653ca42dceb8266a0ff70634292ccd2ad4c43.diff

[Lldb-commits] [lldb] Revert "Read and store gnu build id from loaded core file" (PR #92181)

2024-05-14 Thread via lldb-commits
https://github.com/GeorgeHuyubo closed https://github.com/llvm/llvm-project/pull/92181 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "Read and store gnu build id from loaded core file" (PR #92181)

2024-05-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (GeorgeHuyubo) Changes Reverts llvm/llvm-project#92078 --- Full diff: https://github.com/llvm/llvm-project/pull/92181.diff 5 Files Affected: - (modified) lldb/include/lldb/Target/Process.h (-50) - (modified) lldb/source/Commands/Co

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92187)

2024-05-14 Thread via lldb-commits
https://github.com/GeorgeHuyubo created https://github.com/llvm/llvm-project/pull/92187 As we have debuginfod as symbol locator available in lldb now, we want to make full use of it. In case of post mortem debugging, we don't always have the main executable available. However, the .note.gnu.bu

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92187)

2024-05-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (GeorgeHuyubo) Changes As we have debuginfod as symbol locator available in lldb now, we want to make full use of it. In case of post mortem debugging, we don't always have the main executable available. However, the .note.gnu.build-i

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92187)

2024-05-14 Thread via lldb-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92187)

2024-05-14 Thread via lldb-commits
https://github.com/GeorgeHuyubo closed https://github.com/llvm/llvm-project/pull/92187 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92078)

2024-05-14 Thread via lldb-commits
GeorgeHuyubo wrote: Gonna re-open this in a new PR https://github.com/llvm/llvm-project/pull/92078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d12c48c - [lldb/aarch64] Allow unaligned PC addresses below a trap handler (#92093)

2024-05-15 Thread via lldb-commits
Author: Pavel Labath Date: 2024-05-15T10:02:24+02:00 New Revision: d12c48cad52798f4846dd8ef882af0f854118d16 URL: https://github.com/llvm/llvm-project/commit/d12c48cad52798f4846dd8ef882af0f854118d16 DIFF: https://github.com/llvm/llvm-project/commit/d12c48cad52798f4846dd8ef882af0f854118d16.diff

[Lldb-commits] [lldb] b6f050f - [lldb] Document some more packets (#92124)

2024-05-15 Thread via lldb-commits
Author: David Spickett Date: 2024-05-15T11:20:58+01:00 New Revision: b6f050fa129b08b6bc35168f0b8010742cd1ed9d URL: https://github.com/llvm/llvm-project/commit/b6f050fa129b08b6bc35168f0b8010742cd1ed9d DIFF: https://github.com/llvm/llvm-project/commit/b6f050fa129b08b6bc35168f0b8010742cd1ed9d.diff

[Lldb-commits] [lldb] 03bdfb6 - [lldb][test][FreeBSD] Fix some concurrent event tests (#84155)

2024-05-15 Thread via lldb-commits
Author: David Spickett Date: 2024-05-15T11:25:15+01:00 New Revision: 03bdfb65617e3cf714a106fdf7a6ae7551d17bce URL: https://github.com/llvm/llvm-project/commit/03bdfb65617e3cf714a106fdf7a6ae7551d17bce DIFF: https://github.com/llvm/llvm-project/commit/03bdfb65617e3cf714a106fdf7a6ae7551d17bce.diff

[Lldb-commits] [lldb] eacefba - [lldb][Windows] Fixed tests TestPty and TestPtyServer (#92090)

2024-05-15 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-15T14:44:24+04:00 New Revision: eacefba9aa3d1a5181d3d49823df24aca0d2b344 URL: https://github.com/llvm/llvm-project/commit/eacefba9aa3d1a5181d3d49823df24aca0d2b344 DIFF: https://github.com/llvm/llvm-project/commit/eacefba9aa3d1a5181d3d49823df24aca0d2b344.dif

[Lldb-commits] [lldb] [lldb] Move TestBase.runCmd() to the Base class (PR #92252)

2024-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes runCmd() is called from Base.getCPUInfo() but implemented only in TestBase(Base). Usually it works if TestBase is used. But call getCPUInfo() from a class based on Base will cause something like ``` File

[Lldb-commits] [lldb] [lldb] Fixed the TestGdbRemoteCompletion test (PR #92268)

2024-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Do not try to run lldb-server on localhost in case of the remote target. --- Full diff: https://github.com/llvm/llvm-project/pull/92268.diff 1 Files Affected: - (modified) lldb/test/API/tools/lldb-serve

[Lldb-commits] [lldb] [lldb] Fixed the TestFdLeak test (PR #92273)

2024-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Use `NUL` instead of `/dev/null` in case of the Windows host. --- Full diff: https://github.com/llvm/llvm-project/pull/92273.diff 1 Files Affected: - (modified) lldb/test/API/functionalities/avoids-fd-l

[Lldb-commits] [lldb] [lldb] Fixed the TestCompletion test running on a remote target (PR #92281)

2024-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Install the image to the remote target if necessary. Platform::LoadImage() uses the following logic before DoLoadImage() ``` if (IsRemote() || local_file != remote_file) { error = Install(local_file, rem

[Lldb-commits] [lldb] [lldb] Fixed the TestNetBSDCore test (PR #92285)

2024-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes TestNetBSDCore.py contains 3 classes with the same test names test_aarch64 and test_amd64. It causes conflicts because the same build dir. Add suffixes to avoid conflicts. The error message on the Window

[Lldb-commits] [lldb] [lldb][Windows] Fixed the TestIOHandlerResizeNoEditline test (PR #92286)

2024-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This test caused python crash on Windows x86_64 host with the exit code 0xC409 (STATUS_STACK_BUFFER_OVERRUN). Close the input stream before exit to avoid this crash. --- Full diff: https://github.com

[Lldb-commits] [lldb] 34f33ba - [lldb] Fixed the TestGdbRemoteCompletion test (#92268)

2024-05-15 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-15T20:48:16+04:00 New Revision: 34f33babc28d240d4ceee69f9afe7d6f5e8ac29b URL: https://github.com/llvm/llvm-project/commit/34f33babc28d240d4ceee69f9afe7d6f5e8ac29b DIFF: https://github.com/llvm/llvm-project/commit/34f33babc28d240d4ceee69f9afe7d6f5e8ac29b.dif

[Lldb-commits] [lldb] fc1df55 - [lldb][Windows] Fixed the test gdb_remote_client/TestGDBRemotePlatformFile (#92088)

2024-05-15 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-15T20:50:58+04:00 New Revision: fc1df55bcf9b6cc2dec157bcd188b471bc91b945 URL: https://github.com/llvm/llvm-project/commit/fc1df55bcf9b6cc2dec157bcd188b471bc91b945 DIFF: https://github.com/llvm/llvm-project/commit/fc1df55bcf9b6cc2dec157bcd188b471bc91b945.dif

[Lldb-commits] [lldb] eb822dc - [lldb] Fixed the TestCompletion test running on a remote target (#92281)

2024-05-15 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-15T21:03:15+04:00 New Revision: eb822dc25853299ea81166f9bb8a43436ab8b0c8 URL: https://github.com/llvm/llvm-project/commit/eb822dc25853299ea81166f9bb8a43436ab8b0c8 DIFF: https://github.com/llvm/llvm-project/commit/eb822dc25853299ea81166f9bb8a43436ab8b0c8.dif

[Lldb-commits] [lldb] 7645269 - [lldb] Fixed the TestNetBSDCore test (#92285)

2024-05-15 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-15T21:06:30+04:00 New Revision: 7645269710493c188d1d270b9e4e085b3e92b9b0 URL: https://github.com/llvm/llvm-project/commit/7645269710493c188d1d270b9e4e085b3e92b9b0 DIFF: https://github.com/llvm/llvm-project/commit/7645269710493c188d1d270b9e4e085b3e92b9b0.dif

[Lldb-commits] [lldb] d92c677 - [lldb][Windows] Fixed the TestIOHandlerResizeNoEditline test (#92286)

2024-05-15 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-15T21:08:35+04:00 New Revision: d92c67784f21063d6334a009dbf4f9e0f8217b41 URL: https://github.com/llvm/llvm-project/commit/d92c67784f21063d6334a009dbf4f9e0f8217b41 DIFF: https://github.com/llvm/llvm-project/commit/d92c67784f21063d6334a009dbf4f9e0f8217b41.dif

[Lldb-commits] [lldb] 411bf38 - [lldb-dap] Include npm install in the extension installation steps (#92028)

2024-05-15 Thread via lldb-commits
Author: Walter Erquinigo Date: 2024-05-15T14:44:12-04:00 New Revision: 411bf385ba27f15145c635c7d8ff2701fe8de5b9 URL: https://github.com/llvm/llvm-project/commit/411bf385ba27f15145c635c7d8ff2701fe8de5b9 DIFF: https://github.com/llvm/llvm-project/commit/411bf385ba27f15145c635c7d8ff2701fe8de5b9.di

[Lldb-commits] [lldb] 8530b1c - [lldb] Support custom LLVM formatting for variables (#91868)

2024-05-15 Thread via lldb-commits
Author: Dave Lee Date: 2024-05-15T14:44:42-07:00 New Revision: 8530b1c464ae9af4a5c8be145a8db043798634f6 URL: https://github.com/llvm/llvm-project/commit/8530b1c464ae9af4a5c8be145a8db043798634f6 DIFF: https://github.com/llvm/llvm-project/commit/8530b1c464ae9af4a5c8be145a8db043798634f6.diff LOG:

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-15 Thread via lldb-commits
@@ -743,9 +743,28 @@ DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, } void Debugger::HandleDestroyCallback() { - if (m_destroy_callback) { -m_destroy_callback(GetID(), m_destroy_callback_baton); -m_destroy_callback = nullptr; + std::lock_g

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r e3ca558ffb1441cb16da7aba021e12c6f11f...25ff389fd2b1ca5caccfe239d8ab1bd166ee75cb lldb

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e3ca558ffb1441cb16da7aba021e12c6f11f 25ff389fd2b1ca5caccfe239d8ab1bd166ee75cb --

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-15 Thread via lldb-commits
https://github.com/jeffreytan81 commented: Added another inline comment. https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-15 Thread via lldb-commits
@@ -1689,12 +1689,32 @@ void SBDebugger::SetLoggingCallback(lldb::LogOutputCallback log_callback, void SBDebugger::SetDestroyCallback( lldb::SBDebuggerDestroyCallback destroy_callback, void *baton) { LLDB_INSTRUMENT_VA(this, destroy_callback, baton); + if (m_opaque_sp

[Lldb-commits] [lldb] 0585eed - [lldb-dap] Support publishing to the VSCode market place (#92320)

2024-05-15 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-15T15:44:05-07:00 New Revision: 0585eed9409c1362f7deaabc42c1d3c3f55c4b6c URL: https://github.com/llvm/llvm-project/commit/0585eed9409c1362f7deaabc42c1d3c3f55c4b6c DIFF: https://github.com/llvm/llvm-project/commit/0585eed9409c1362f7deaabc42c1d3c3f55c4b6c.d

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Zequan Wu (ZequanWu) Changes This reapplies https://github.com/llvm/llvm-project/commit/9a7262c2601874e5aa64c5db19746770212d4b44 and https://github.com/llvm/llvm-project/commit/a7eff59f78f08f8ef0487dfe2a136fb311af4fd0 with a fix. It was

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-15 Thread via lldb-commits
@@ -6410,12 +6410,20 @@ GetCoreFileSaveRangesStackOnly(Process &process, if (!reg_ctx_sp) continue; const addr_t sp = reg_ctx_sp->GetSP(); +const size_t red_zone = process.GetABI()->GetRedZoneSize(); lldb_private::MemoryRegionInfo sp_region; if (proc

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-15 Thread via lldb-commits
@@ -1312,11 +1312,13 @@ class Process : public std::enable_shared_from_this, size_t GetThreadStatus(Stream &ostrm, bool only_threads_with_stop_reason, uint32_t start_frame, uint32_t num_frames, - uint32_t num_frames_with_sour

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-15 Thread via lldb-commits
@@ -590,6 +591,7 @@ class ThreadPlanNull : public ThreadPlan { const Status &GetStatus() { return m_status; } protected: + friend class ThreadPlanSingleThreadTimeout; jimingham wrote: What is this needed for? It's a little odd having a derived class frien

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-15 Thread via lldb-commits
@@ -0,0 +1,93 @@ +//===-- ThreadPlanSingleThreadTimeout.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-15 Thread via lldb-commits
@@ -0,0 +1,93 @@ +//===-- ThreadPlanSingleThreadTimeout.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-15 Thread via lldb-commits
@@ -0,0 +1,93 @@ +//===-- ThreadPlanSingleThreadTimeout.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-15 Thread via lldb-commits
@@ -743,9 +743,28 @@ DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, } void Debugger::HandleDestroyCallback() { - if (m_destroy_callback) { -m_destroy_callback(GetID(), m_destroy_callback_baton); -m_destroy_callback = nullptr; + std::lock_g

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-15 Thread via lldb-commits
@@ -247,13 +247,13 @@ class SBCommandInterpreter { lldb::SBStringList &matches, lldb::SBStringList &descriptions); - /// Returns whether an interrupt flag was raised either by the SBDebugger - + /

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-15 Thread via lldb-commits
@@ -576,7 +577,7 @@ class CommandInterpreter : public Broadcaster, void SetEchoCommentCommands(bool enable); bool GetRepeatPreviousCommand() const; - + jeffreytan81 wrote: Similar, undo the unnecessary change https://github.com/llvm/llvm-project/pull/9

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-15 Thread via lldb-commits
@@ -135,7 +136,8 @@ CommandInterpreter::CommandInterpreter(Debugger &debugger, m_skip_lldbinit_files(false), m_skip_app_init_files(false), m_comment_char('#'), m_batch_command_mode(false), m_truncation_warning(eNoOmission), m_max_depth_warning(eNoOmission), -

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-15 Thread via lldb-commits
@@ -150,7 +150,7 @@ bool SBCommandInterpreter::WasInterrupted() const { bool SBCommandInterpreter::InterruptCommand() { LLDB_INSTRUMENT_VA(this); - + jeffreytan81 wrote: Similar, undo the unnecessary change https://github.com/llvm/llvm-project/pull/90703

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-15 Thread via lldb-commits
@@ -1891,6 +1893,12 @@ bool CommandInterpreter::HandleCommand(const char *command_line, m_transcript_stream << "(lldb) " << command_line << '\n'; + // The same `transcript_item` will be used below to add output and error of + // the command. + auto transcript_item = std

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-15 Thread via lldb-commits
https://github.com/jeffreytan81 commented: General looks good to me. I do agree that we should hide this behind a setting to avoid memory leak in long running lldb sessions. https://github.com/llvm/llvm-project/pull/90703 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] [lldb][Windows] Disable the TestGdbRemoteLibrariesSvr4Support test for Windows host (PR #92341)

2024-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Windows does not allow quotes in file names. So it is impossible to build `libsvr4lib_b".so` on Windows. --- Full diff: https://github.com/llvm/llvm-project/pull/92341.diff 1 Files Affected: - (modifie

[Lldb-commits] [lldb] ce961c5 - [lldb] Fixed the TestFdLeak test (#92273)

2024-05-15 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-16T07:44:08+04:00 New Revision: ce961c5607dd5c2d181117938720e410b406a49f URL: https://github.com/llvm/llvm-project/commit/ce961c5607dd5c2d181117938720e410b406a49f DIFF: https://github.com/llvm/llvm-project/commit/ce961c5607dd5c2d181117938720e410b406a49f.dif

[Lldb-commits] [lldb] [lldb] Fixed an invalid error message in the DAP disconnect response (PR #92345)

2024-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The `disconnect` response contains the `error` message with invalid characters (a junk data). To reproduce this issue it is enough to run the `TestDAP_commands` test on Windows host and Linux target. The

[Lldb-commits] [lldb] 2bc9af9 - [lldb][Windows] Disable the TestGdbRemoteLibrariesSvr4Support test for Windows host (#92341)

2024-05-16 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-16T16:49:56+04:00 New Revision: 2bc9af96567eeda1effdf0cb7662511d896fb386 URL: https://github.com/llvm/llvm-project/commit/2bc9af96567eeda1effdf0cb7662511d896fb386 DIFF: https://github.com/llvm/llvm-project/commit/2bc9af96567eeda1effdf0cb7662511d896fb386.dif

[Lldb-commits] [lldb] 44eded3 - [lldb] Move TestBase.runCmd() to the Base class (#92252)

2024-05-16 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-16T16:55:06+04:00 New Revision: 44eded31e0bd5739391298497affe3412e4091aa URL: https://github.com/llvm/llvm-project/commit/44eded31e0bd5739391298497affe3412e4091aa DIFF: https://github.com/llvm/llvm-project/commit/44eded31e0bd5739391298497affe3412e4091aa.dif

[Lldb-commits] [lldb] [lldb] Fixed the DAP tests in case of a remote target (PR #92398)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes These tests failed in case of Windows host and Linux target, because dap_server tried to run ELF file on Windows. --- Full diff: https://github.com/llvm/llvm-project/pull/92398.diff 2 Files Affected: -

[Lldb-commits] [lldb] f579dcf - [lldb] Fixed an invalid error message in the DAP disconnect response (#92345)

2024-05-16 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-16T18:34:22+04:00 New Revision: f579dcf816b5626724e9eae5feea594008b5c863 URL: https://github.com/llvm/llvm-project/commit/f579dcf816b5626724e9eae5feea594008b5c863 DIFF: https://github.com/llvm/llvm-project/commit/f579dcf816b5626724e9eae5feea594008b5c863.dif

[Lldb-commits] [lldb] d665d51 - [lldb] Fixed the DAP tests in case of a remote target (#92398)

2024-05-16 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-16T18:34:58+04:00 New Revision: d665d51c9296fc0b57945bb67e06040e26cd03c5 URL: https://github.com/llvm/llvm-project/commit/d665d51c9296fc0b57945bb67e06040e26cd03c5 DIFF: https://github.com/llvm/llvm-project/commit/d665d51c9296fc0b57945bb67e06040e26cd03c5.dif

[Lldb-commits] [lldb] d665d51 - [lldb] Fixed the DAP tests in case of a remote target (#92398)

2024-05-16 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-16T18:34:58+04:00 New Revision: d665d51c9296fc0b57945bb67e06040e26cd03c5 URL: https://github.com/llvm/llvm-project/commit/d665d51c9296fc0b57945bb67e06040e26cd03c5 DIFF: https://github.com/llvm/llvm-project/commit/d665d51c9296fc0b57945bb67e06040e26cd03c5.dif

[Lldb-commits] [lldb] [lldb] Fixed the test TestGdbRemoteAttachWait running on a remote target (PR #92413)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Install `_exe_to_attach` to a remote target if necessary. --- Full diff: https://github.com/llvm/llvm-project/pull/92413.diff 1 Files Affected: - (modified) lldb/test/API/tools/lldb-server/attach-wait/

[Lldb-commits] [lldb] [lldb] Fixed the DAP tests in case of a remote target (PR #92416)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes These tests are based on dap_server which runs locally. These tests failed in case of Windows host and Linux target. --- Full diff: https://github.com/llvm/llvm-project/pull/92416.diff 2 Files Affected:

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread via lldb-commits
@@ -247,13 +247,13 @@ class SBCommandInterpreter { lldb::SBStringList &matches, lldb::SBStringList &descriptions); - /// Returns whether an interrupt flag was raised either by the SBDebugger - + /

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread via lldb-commits
@@ -135,7 +136,8 @@ CommandInterpreter::CommandInterpreter(Debugger &debugger, m_skip_lldbinit_files(false), m_skip_app_init_files(false), m_comment_char('#'), m_batch_command_mode(false), m_truncation_warning(eNoOmission), m_max_depth_warning(eNoOmission), -

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread via lldb-commits
@@ -1891,6 +1893,12 @@ bool CommandInterpreter::HandleCommand(const char *command_line, m_transcript_stream << "(lldb) " << command_line << '\n'; + // The same `transcript_item` will be used below to add output and error of + // the command. + auto transcript_item = std

[Lldb-commits] [lldb] [lldb-dap] Separate user and developer documentation (PR #92428)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The README.md is what users see when they look for the extension in the Marketplace [1]. Right now, it's a mix of developer documentation (for us) and user documentation. This commit moves the devel

[Lldb-commits] [lldb] c7ae8c6 - [lldb] Fixed the DAP tests in case of a remote target (#92416)

2024-05-16 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-16T21:30:31+04:00 New Revision: c7ae8c6639370ccbc583dca019bbb78761ce423d URL: https://github.com/llvm/llvm-project/commit/c7ae8c6639370ccbc583dca019bbb78761ce423d DIFF: https://github.com/llvm/llvm-project/commit/c7ae8c6639370ccbc583dca019bbb78761ce423d.dif

[Lldb-commits] [lldb] 525bd66 - [lldb-dap] Separate user and developer documentation (#92428)

2024-05-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-16T10:41:06-07:00 New Revision: 525bd66fc29fd056ef18118dfff3c9cc05fdd5e3 URL: https://github.com/llvm/llvm-project/commit/525bd66fc29fd056ef18118dfff3c9cc05fdd5e3 DIFF: https://github.com/llvm/llvm-project/commit/525bd66fc29fd056ef18118dfff3c9cc05fdd5e3.d

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
@@ -0,0 +1,93 @@ +//===-- ThreadPlanSingleThreadTimeout.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] 47d80ec - [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (#92002)

2024-05-16 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-05-16T14:17:19-07:00 New Revision: 47d80ec1802d70082c8fd32b4396c98db2c4dba2 URL: https://github.com/llvm/llvm-project/commit/47d80ec1802d70082c8fd32b4396c98db2c4dba2 DIFF: https://github.com/llvm/llvm-project/commit/47d80ec1802d70082c8fd32b4396c98db2c4dba2.diff

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

2024-05-16 Thread via lldb-commits
github-actions[bot] wrote: @Jlalond Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-16 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Include SBLanguages in the SWIG bindings (PR #92470)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/92470.diff 3 Files Affected: - (modified) lldb/bindings/CMakeLists.txt (+2) - (modified) lldb/bindings/headers.swig (+1) - (modified) ll

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
@@ -0,0 +1,93 @@ +//===-- ThreadPlanSingleThreadTimeout.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-16 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/89868 >From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 23 Apr 2024 18:10:21 -0700 Subject: [PATCH 01/18] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCall

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes Note that StringRef::equals has been deprecated in favor of operator==(StringRef, StringRef). --- Patch is 40.84 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/90930 >From b72df8cf2a047ed731913609b58bdb4a3601e111 Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Thu, 2 May 2024 18:12:04 -0700 Subject: [PATCH 1/4] Single thread timeout feature --- lldb/include/lldb/Targ

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
@@ -1312,11 +1312,13 @@ class Process : public std::enable_shared_from_this, size_t GetThreadStatus(Stream &ostrm, bool only_threads_with_stop_reason, uint32_t start_frame, uint32_t num_frames, - uint32_t num_frames_with_sour

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
@@ -590,6 +591,7 @@ class ThreadPlanNull : public ThreadPlan { const Status &GetStatus() { return m_status; } protected: + friend class ThreadPlanSingleThreadTimeout; jeffreytan81 wrote: Hmm, I thought there is a reason I can't remember, apparently not. Re

[Lldb-commits] [lldb] ebf2831 - [lldb] Include SBLanguages in the SWIG bindings (#92470)

2024-05-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-16T19:31:43-07:00 New Revision: ebf283162f5a0e7e9392c3a825e060856eee0991 URL: https://github.com/llvm/llvm-project/commit/ebf283162f5a0e7e9392c3a825e060856eee0991 DIFF: https://github.com/llvm/llvm-project/commit/ebf283162f5a0e7e9392c3a825e060856eee0991.d

[Lldb-commits] [lldb] 5529278 - Revert "[lldb] Include SBLanguages in the SWIG bindings" (#92490)

2024-05-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-16T19:58:58-07:00 New Revision: 552927840319572a649cdec2d8bf2e688a5df490 URL: https://github.com/llvm/llvm-project/commit/552927840319572a649cdec2d8bf2e688a5df490 DIFF: https://github.com/llvm/llvm-project/commit/552927840319572a649cdec2d8bf2e688a5df490.d

[Lldb-commits] [lldb] Revert "[lldb] Include SBLanguages in the SWIG bindings" (PR #92490)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Reverts llvm/llvm-project#92470 --- Full diff: https://github.com/llvm/llvm-project/pull/92490.diff 3 Files Affected: - (modified) lldb/bindings/CMakeLists.txt (-2) - (modified) lldb/bindings/hea

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-16 Thread via lldb-commits
https://github.com/GeorgeHuyubo created https://github.com/llvm/llvm-project/pull/92492 As we have debuginfod as symbol locator available in lldb now, we want to make full use of it. In case of post mortem debugging, we don't always have the main executable available. However, the .note.gnu.bu

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (GeorgeHuyubo) Changes As we have debuginfod as symbol locator available in lldb now, we want to make full use of it. In case of post mortem debugging, we don't always have the main executable available. However, the .note.gnu.build-i

[Lldb-commits] [lldb] c339226 - [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (#92476)

2024-05-16 Thread via lldb-commits
Author: Kazu Hirata Date: 2024-05-16T20:47:12-07:00 New Revision: c33922666ce219fd6cb3341c3394f72050599552 URL: https://github.com/llvm/llvm-project/commit/c33922666ce219fd6cb3341c3394f72050599552 DIFF: https://github.com/llvm/llvm-project/commit/c33922666ce219fd6cb3341c3394f72050599552.diff L

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/90703 >From 0fd67e2de7e702ce6f7353845454ea7ff9f980d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 30 Apr 2024 21:35:49 -0700 Subject: [PATCH 01/17] Add SBCommandInterpreter::GetTranscript() --- lldb/include/lld

[Lldb-commits] [lldb] Reapply "[lldb/aarch64] Fix unwinding when signal interrupts a leaf f… (PR #92503)

2024-05-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes …unction (#91321)" This reapplies fd1bd53ba5a06f344698a55578f6a5d79c457e30, which was reverted due to a test failure on aarch64/windows. The failure was caused by a combination of several factors: - clang tar

[Lldb-commits] [lldb] 33bf08e - [lldb-dap] Correctly detect alias commands with arguments in repl (#92137)

2024-05-17 Thread via lldb-commits
Author: Pavel Labath Date: 2024-05-17T11:24:20+02:00 New Revision: 33bf08ec36efc2fc2df8217eddd751cef9bc6be6 URL: https://github.com/llvm/llvm-project/commit/33bf08ec36efc2fc2df8217eddd751cef9bc6be6 DIFF: https://github.com/llvm/llvm-project/commit/33bf08ec36efc2fc2df8217eddd751cef9bc6be6.diff

[Lldb-commits] [lldb] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #92565)

2024-05-17 Thread via lldb-commits
https://github.com/aabhinavg created https://github.com/llvm/llvm-project/pull/92565 Summary of Changes: Replaced the ineffective call to `substr` with a more efficient use of `resize` to truncate the string. Adjusted the code to use 'resize' instead of 'substr' for better performance and rea

[Lldb-commits] [lldb] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #92565)

2024-05-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (aabhinavg) Changes Summary of Changes: Replaced the ineffective call to `substr` with a more efficient use of `resize` to truncate the string. Adjusted the code to use 'resize' instead of 'substr' for better performance and readabil

[Lldb-commits] [lldb] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #92565)

2024-05-17 Thread via lldb-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[Lldb-commits] [lldb] d38ea8c - [lldb] Fixed the test TestGdbRemoteAttachWait running on a remote target (#92413)

2024-05-17 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-05-17T20:14:09+04:00 New Revision: d38ea8c4c84be9496249098053599c24b87f1376 URL: https://github.com/llvm/llvm-project/commit/d38ea8c4c84be9496249098053599c24b87f1376 DIFF: https://github.com/llvm/llvm-project/commit/d38ea8c4c84be9496249098053599c24b87f1376.dif

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-17 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/90703 >From 0fd67e2de7e702ce6f7353845454ea7ff9f980d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 30 Apr 2024 21:35:49 -0700 Subject: [PATCH 01/18] Add SBCommandInterpreter::GetTranscript() --- lldb/include/lld

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/90703 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Windows] Skip the TestDataFormatterLibcxxChrono test to avoid python crash (PR #92575)

2024-05-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The python crashed with the exit code 0xC409 (STATUS_STACK_BUFFER_OVERRUN) on the command `frame variable ss_neg_seconds` running on Windows x86_64. See this issue for details https://github.com/llvm/

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-17 Thread via lldb-commits
@@ -571,6 +571,15 @@ SBStructuredData SBCommandInterpreter::GetStatistics() { return data; } +SBStructuredData SBCommandInterpreter::GetTranscript() { + LLDB_INSTRUMENT_VA(this); + + SBStructuredData data; + if (IsValid()) +data.m_impl_up->SetObjectSP(m_opaque_ptr->Ge

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-17 Thread via lldb-commits
@@ -766,6 +768,12 @@ class CommandInterpreter : public Broadcaster, CommandUsageMap m_command_usages; StreamString m_transcript_stream; + + /// Contains a list of handled commands, output and error. Each element in + /// the list is a dictionary with three keys: "command

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-17 Thread via lldb-commits
@@ -135,7 +136,8 @@ CommandInterpreter::CommandInterpreter(Debugger &debugger, m_skip_lldbinit_files(false), m_skip_app_init_files(false), m_comment_char('#'), m_batch_command_mode(false), m_truncation_warning(eNoOmission), m_max_depth_warning(eNoOmission), -

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-17 Thread via lldb-commits
@@ -731,8 +746,11 @@ class Debugger : public std::enable_shared_from_this, lldb::TargetSP m_dummy_target_sp; Diagnostics::CallbackID m_diagnostics_callback_id; - lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr; - void *m_destroy_callback_baton = nullp

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-17 Thread via lldb-commits
@@ -731,8 +747,11 @@ class Debugger : public std::enable_shared_from_this, lldb::TargetSP m_dummy_target_sp; Diagnostics::CallbackID m_diagnostics_callback_id; - lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr; - void *m_destroy_callback_baton = nullp

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r c675a58edec6d1a876a0d0e7d261f74764855b38...939d42eba9f88d90ac72782415640bbab360645c lldb/

[Lldb-commits] [lldb] [lldb] Add the word "backtrace" to bt help string (PR #92618)

2024-05-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/92618.diff 2 Files Affected: - (modified) lldb/source/Commands/CommandObjectThread.cpp (+2-2) - (modified) lldb/source/Interpreter/CommandInterpret

[Lldb-commits] [lldb] [lldb] Add the word "backtrace" to bt help string (PR #92618)

2024-05-17 Thread via lldb-commits
jimingham wrote: In simple aliases, apropos could get this right itself by resolving the command the alias points to and if THAT help string had the searched term, list the alias. But bt is an alias to a regex command. Again, you could look through all the branches of the regex command findi

[Lldb-commits] [lldb] [lldb] Add the word "backtrace" to bt help string (PR #92618)

2024-05-17 Thread via lldb-commits
jimingham wrote: I'm fine with adding the to be searched for term to the alias help. https://github.com/llvm/llvm-project/pull/92618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #92565)

2024-05-17 Thread via lldb-commits
https://github.com/aabhinavg updated https://github.com/llvm/llvm-project/pull/92565 >From 13fefb6846b6641900843c37746b03140063a955 Mon Sep 17 00:00:00 2001 From: aabhinavg Date: Fri, 17 May 2024 21:17:51 +0530 Subject: [PATCH 1/2] removed unwanted file --- lldb/source/Core/Debugger.cpp | 2 +

<    5   6   7   8   9   10   11   12   13   14   >