[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 35.05 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91857.diff 50 Files Affected: - (modified) clang-tools-extra/docs/clang-tidy/checks/gen-

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

llvmbot wrote: @llvm/pr-subscribers-pgo @llvm/pr-subscribers-compiler-rt-sanitizer Author: Eisuke Kawashima (e-kwsm) Changes --- Patch is 35.05 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/91857.diff 50 Files Affected: - (modified) clan

[Lldb-commits] [clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Eisuke Kawashima (e-kwsm) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/91858.diff 18 Files Affected: - (modified) clang/tools/scan-build/bin/set-xcode-analyzer (+1-1) - (modified) clang/utils/check_cfc/check_cfc.py

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes - **[lldb] Support custom LLVM formatting for variables (#81196)** - **[lldb] Handle non-existent llvm_format** --- Full diff: https://github.com/llvm/llvm-project/pull/91868.diff 5 Files Affected: - (modi

[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

https://github.com/aabhinavg created https://github.com/llvm/llvm-project/pull/91880 Author: aabhinavg Date: Sun May 12 12:46:54 2024 +0800 Reviewers: @JOE1994, @chelcassanova, @dcb314 Fixes: #91209 Summary of Changes: - Replaced the ineffective call to 'substr' with a more efficient use of

[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: None (aabhinavg) Changes Author: aabhinavg Date: Sun May 12 12:46:54 2024 +0800 Reviewers: @JOE1994, @chelcassanova, @dcb314 Fixes: #91209 Summary of Changes: - Replaced the ineffective call to 'substr' w

[Lldb-commits] [lldb] [lldb] Fix redundant condition in Target.cpp (PR #91882)

https://github.com/aabhinavg created https://github.com/llvm/llvm-project/pull/91882 This commit addresses issue #87244, where a redundant condition was found in the Target.cpp file. Static analyzer cppcheck flagged the issue in the Target.cpp file fix #87244 >From 9b4160975efe059f39a842689b

[Lldb-commits] [lldb] [lldb] Fix redundant condition in Target.cpp (PR #91882)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (aabhinavg) Changes This commit addresses issue #87244, where a redundant condition was found in the Target.cpp file. Static analyzer cppcheck flagged the issue in the Target.cpp file fix #87244 --- Full diff: https://github.com/llv

[Lldb-commits] [lldb] [lldb] Fix redundant condition in Target.cpp (PR #91882)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 63224d717108d927e998da8a67050a6cc5dd74a2 9b4160975efe059f39a842689b1f750a10453203 --

[Lldb-commits] [lldb] [lldb] Fixed the test TestQuoting (PR #91886)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes os.path.join() uses the path separator of the host OS by default. outfile_arg will be incorrect in case of Windows host and Linux target. Use lldbutil.append_to_process_working_directory() instead. --- F

[Lldb-commits] [lldb] [lldb] Fixed the test TestQuoting (PR #91886)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 1d6bf0ca29322b08e8b50681d440e7182441b025...f6135c1b825afd9fe733b845dfd12ffe3c162840 lldb/

[Lldb-commits] [lldb] [lldb][Windows] Enforce exec permission using Platform::Install() from Windows host (PR #91887)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Target::Install() set 0700 permissions for the main executable file. Platform::Install() just copies permissions from the source. But the permission eFilePermissionsUserExecute is missing on the Windows h

[Lldb-commits] [lldb] [lldb] Fixed the test TestSettings (PR #91915)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The setting `platform.module-cache-directory` is a local path on the host. It cannot be set to a working directory from the remote target. This test failed in case of Windows host and Linux target. Use th

[Lldb-commits] [lldb] [lldb] Fix the test TestGdbRemotePlatformFile (PR #91918)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes It is necessary to transfer the test file to/from the really remote target (for example Windows host and Linux target). Also ignore chmod check in case of the Windows host. --- Full diff: https://github.

[Lldb-commits] [lldb] [lldb] Fixed the test TestPlatformProcessLaunch (PR #91923)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Transfer `stdio.log` from the remote target if necessary. --- Full diff: https://github.com/llvm/llvm-project/pull/91923.diff 1 Files Affected: - (modified) lldb/test/API/commands/platform/process/laun

[Lldb-commits] [lldb] [lldb] Fixed the test TestGdbRemoteLaunch (PR #91931)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Install `a.out` to the remote target (after handshake) if necessary and use the remote path to call `vRun`. --- Full diff: https://github.com/llvm/llvm-project/pull/91931.diff 1 Files Affected: - (modi

[Lldb-commits] [lldb] [lldb][Windows] Disable macOS specific test for Windows host instead of Windows target (PR #91942)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This test failed in case of Windows host and Linux target. --- Full diff: https://github.com/llvm/llvm-project/pull/91942.diff 1 Files Affected: - (modified) lldb/test/API/macosx/duplicate-archive-memb

[Lldb-commits] [lldb] [lldb] Add lldbutil.target_install() helper (PR #91944)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes It can be used in tests #91918, #91931 and such. --- Full diff: https://github.com/llvm/llvm-project/pull/91944.diff 1 Files Affected: - (modified) lldb/packages/Python/lldbsuite/test/lldbutil.py (+16)

[Lldb-commits] [lldb] 710d95d - [lldb] Fixed the test TestSettings when run with a remote target (#91915)

Author: Dmitry Vasilyev Date: 2024-05-13T15:55:20+04:00 New Revision: 710d95d1ecb4b6d69507cb910274ef3077ddc9c9 URL: https://github.com/llvm/llvm-project/commit/710d95d1ecb4b6d69507cb910274ef3077ddc9c9 DIFF: https://github.com/llvm/llvm-project/commit/710d95d1ecb4b6d69507cb910274ef3077ddc9c9.dif

[Lldb-commits] [lldb] 7ce3dd4 - [lldb] Fixed the test TestQuoting (#91886)

Author: Dmitry Vasilyev Date: 2024-05-13T15:58:39+04:00 New Revision: 7ce3dd49eb80816e3af52022ba2521b28a068c7b URL: https://github.com/llvm/llvm-project/commit/7ce3dd49eb80816e3af52022ba2521b28a068c7b DIFF: https://github.com/llvm/llvm-project/commit/7ce3dd49eb80816e3af52022ba2521b28a068c7b.dif

[Lldb-commits] [lldb] 1a25b72 - [lldb] Fixed the test TestPlatformProcessLaunch running on a remote target (#91923)

Author: Dmitry Vasilyev Date: 2024-05-13T17:47:03+04:00 New Revision: 1a25b723628e439d62dfb28ca5fa52e4b2a78e5a URL: https://github.com/llvm/llvm-project/commit/1a25b723628e439d62dfb28ca5fa52e4b2a78e5a DIFF: https://github.com/llvm/llvm-project/commit/1a25b723628e439d62dfb28ca5fa52e4b2a78e5a.dif

[Lldb-commits] [lldb] [lldb] Fix redundant condition in Target.cpp (PR #91882)

https://github.com/aabhinavg updated https://github.com/llvm/llvm-project/pull/91882 >From 9b4160975efe059f39a842689b1f750a10453203 Mon Sep 17 00:00:00 2001 From: aabhinavg Date: Sun, 12 May 2024 12:42:59 +0530 Subject: [PATCH] Fix redundant condition in Target.cpp This commit addresses issue

[Lldb-commits] [lldb] [lldb] Fix redundant condition in Target.cpp (PR #91882)

https://github.com/aabhinavg updated https://github.com/llvm/llvm-project/pull/91882 >From 9b4160975efe059f39a842689b1f750a10453203 Mon Sep 17 00:00:00 2001 From: aabhinavg Date: Sun, 12 May 2024 12:42:59 +0530 Subject: [PATCH 1/2] Fix redundant condition in Target.cpp This commit addresses is

[Lldb-commits] [lldb] [lldb][TypeSystem][NFCI] Log creation of new TypeSystem instances to expression log (PR #91985)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes We emit `ASTContext` and `TypeSystem` pointers into the `expr` log but there is no easy way (that I know of) to correlate the pointer value back to an easily readible form. This patch simply logs the name

[Lldb-commits] [lldb] [lldb][ExpressionParser][NFCI] Log pointers as hex (PR #91989)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This ensures that we log pointers as lower-case hex. E.g., instead of: ``` LayoutRecordType on (ASTContext*)0x00010E78D600 'scratch ASTContext' for (RecordDecl*)0x00010E797 ``` we now log: ``` Lay

[Lldb-commits] [lldb] [lldb][ExpressionParser][NFCI] Log pointers as hex (PR #91989)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff abd314938dda1b117f289be5e630e43e68533929 1fba045db76f51a2dbd9a2a3cb9879858b5b653e --

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

@@ -731,8 +747,11 @@ class Debugger : public std::enable_shared_from_this, lldb::TargetSP m_dummy_target_sp; Diagnostics::CallbackID m_diagnostics_callback_id; - lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr; - void *m_destroy_callback_baton = nullp

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from start start to the stackpointer + red_zone (PR #92002)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from start start to the stackpointer + red_zone (PR #92002)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Currently in Core dumps, the entire pthread is copied, including the unused space beyond the stack pointer. This causes large amounts of core dump inflation when the number of threads is high, but the stack

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

https://github.com/jeffreytan81 requested changes to this pull request. https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

@@ -1689,35 +1689,56 @@ void SBDebugger::SetLoggingCallback(lldb::LogOutputCallback log_callback, void SBDebugger::SetDestroyCallback( lldb::SBDebuggerDestroyCallback destroy_callback, void *baton) { LLDB_INSTRUMENT_VA(this, destroy_callback, baton); + if (m_opaque_sp

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

@@ -743,9 +743,28 @@ DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, } void Debugger::HandleDestroyCallback() { - if (m_destroy_callback) { -m_destroy_callback(GetID(), m_destroy_callback_baton); -m_destroy_callback = nullptr; + std::lock_g

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

@@ -743,9 +743,28 @@ DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, } void Debugger::HandleDestroyCallback() { - if (m_destroy_callback) { -m_destroy_callback(GetID(), m_destroy_callback_baton); -m_destroy_callback = nullptr; + std::lock_g

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

@@ -743,9 +743,28 @@ DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, } void Debugger::HandleDestroyCallback() { - if (m_destroy_callback) { -m_destroy_callback(GetID(), m_destroy_callback_baton); -m_destroy_callback = nullptr; + std::lock_g

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

@@ -161,3 +161,122 @@ def foo(dbg_id): original_dbg_id = self.dbg.GetID() self.dbg.Destroy(self.dbg) self.assertEqual(destroy_dbg_id, original_dbg_id) + +def test_AddDestroyCallback(self): +original_dbg_id = self.dbg.GetID() +called =

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

@@ -194,7 +194,7 @@ class LLDB_API SBDebugger { lldb::SBCommandInterpreter GetCommandInterpreter(); void HandleCommand(const char *command); - + jeffreytan81 wrote: Remove unnecessary format change https://github.com/llvm/llvm-project/pull/89868 __

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

@@ -13,6 +13,7 @@ #include #include +#include jeffreytan81 wrote: This is not used. https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] 276c0bd - [lldb][ExpressionParser][NFCI] Log pointers as hex (#91989)

Author: Michael Buch Date: 2024-05-13T18:47:39+01:00 New Revision: 276c0bd4b386cc6b9d91e5e44ca7b053c11f13b5 URL: https://github.com/llvm/llvm-project/commit/276c0bd4b386cc6b9d91e5e44ca7b053c11f13b5 DIFF: https://github.com/llvm/llvm-project/commit/276c0bd4b386cc6b9d91e5e44ca7b053c11f13b5.diff

[Lldb-commits] [lldb] dc7ce3b - [lldb][TypeSystem][NFCI] Log creation of new TypeSystem instances to expression log (#91985)

Author: Michael Buch Date: 2024-05-13T19:12:49+01:00 New Revision: dc7ce3b41c936c4cc189b4bbf6a2e3b5475d9fc5 URL: https://github.com/llvm/llvm-project/commit/dc7ce3b41c936c4cc189b4bbf6a2e3b5475d9fc5 DIFF: https://github.com/llvm/llvm-project/commit/dc7ce3b41c936c4cc189b4bbf6a2e3b5475d9fc5.diff

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes Summary: This adds new SB API calls and classes to allow a user of the SB API to obtain an address range from SBFunction and SBBlock. Test Plan: Reviewers: clayborg Subscribers: lldb-commits Tasks: Tags: --

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a037d88929460ff9571927c56d6db215be086149 309050cf7cecab87b851e5d70f5f7437577a828f --

[Lldb-commits] [lldb] fd4b5f4 - [lldb] Add CMake dependency tracking for SBLanguages generation script (#91686)

Author: Alex Langford Date: 2024-05-13T12:32:16-07:00 New Revision: fd4b5f4b52e414bb6fee7c906a22867891fb46b5 URL: https://github.com/llvm/llvm-project/commit/fd4b5f4b52e414bb6fee7c906a22867891fb46b5 DIFF: https://github.com/llvm/llvm-project/commit/fd4b5f4b52e414bb6fee7c906a22867891fb46b5.diff

[Lldb-commits] [lldb] [lldb-dap] Include npm install in the extension installation steps (PR #92028)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes Otherwise the build step fails due to missing dependencies. --- Full diff: https://github.com/llvm/llvm-project/pull/92028.diff 1 Files Affected: - (modified) lldb/tools/lldb-dap/README.md (+2

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

@@ -743,9 +743,28 @@ DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, } void Debugger::HandleDestroyCallback() { - if (m_destroy_callback) { -m_destroy_callback(GetID(), m_destroy_callback_baton); -m_destroy_callback = nullptr; + std::lock_g

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

@@ -743,9 +743,28 @@ DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, } void Debugger::HandleDestroyCallback() { - if (m_destroy_callback) { -m_destroy_callback(GetID(), m_destroy_callback_baton); -m_destroy_callback = nullptr; + std::lock_g

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

@@ -743,9 +743,28 @@ DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, } void Debugger::HandleDestroyCallback() { - if (m_destroy_callback) { -m_destroy_callback(GetID(), m_destroy_callback_baton); -m_destroy_callback = nullptr; + std::lock_g

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/89868 >From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 23 Apr 2024 18:10:21 -0700 Subject: [PATCH 01/15] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCall

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/89868 >From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 23 Apr 2024 18:10:21 -0700 Subject: [PATCH 01/16] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCall

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

@@ -1689,35 +1689,56 @@ void SBDebugger::SetLoggingCallback(lldb::LogOutputCallback log_callback, void SBDebugger::SetDestroyCallback( lldb::SBDebuggerDestroyCallback destroy_callback, void *baton) { LLDB_INSTRUMENT_VA(this, destroy_callback, baton); + if (m_opaque_sp

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/90703 >From 0fd67e2de7e702ce6f7353845454ea7ff9f980d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 30 Apr 2024 21:35:49 -0700 Subject: [PATCH 01/14] Add SBCommandInterpreter::GetTranscript() --- lldb/include/lld

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

jimingham wrote: I'm trying to reproduce locally as well. It's pretty clear that this patch is implicated in the failure. The first failure we saw both on the incremental bots and the first failure on the sanitized bots both had this patch, and no other really relevant ones, in the commit li

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

jimingham wrote: I was able to reproduce the failure of these three: lldb-api :: lang/c/forward/TestForwardDeclaration.py lldb-api :: lang/cpp/unique-types3/TestUniqueTypes3.py lldb-api :: types/TestRecursiveTypes.py locally. Reverting this patch and a7eff59f78f08f8ef0487dfe2a136fb311af4

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

jimingham wrote: > On May 13, 2024, at 6:04 PM, Zequan Wu ***@***.***> wrote: > > > I was able to reproduce the failure of these three: > > lldb-api :: lang/c/forward/TestForwardDeclaration.py > lldb-api :: lang/cpp/unique-types3/TestUniqueTypes3.py > lldb-api :: types/TestRecursiveTypes.py

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

jimingham wrote: BTW, do you know what's up with this test: SymbolFile/DWARF/delayed-definition-die-searching.test your commit deleted that file I think, I added it back when I did the revert (possibly a mistake)... It passes on my macOS system but is failing on Ubuntu after the revert. I t

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

jimingham wrote: Reverting those two commits seems to have caused this build failure on Ubuntu: Step 4 (build) warnings: build (warnings) ../llvm-project/clang/lib/Lex/PPDirectives.cpp:548:28: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare] 1 warnin

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

jimingham wrote: Can you take care of cleaning this up, this seems like a slightly complex patch and not in an area I'm familiar with. Thanks! Jim > On May 13, 2024, at 6:35 PM, Zequan Wu ***@***.***> wrote: > > > Reverting those two commits seems to have caused this build failure on Ubunt

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

https://github.com/jeffreytan81 commented: The changes looks good but the title and description should make it clear that we are only optimizing this for stack-only option. https://github.com/llvm/llvm-project/pull/92002 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

@@ -36,17 +35,37 @@ def verify_core_file( self.assertEqual(module_file_name, expected_file_name) self.assertEqual(module.GetUUIDString(), expected.GetUUIDString()) +red_zone = process.GetTarget().GetStackRedZoneSize() jeffreytan

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

@@ -6410,12 +6410,20 @@ GetCoreFileSaveRangesStackOnly(Process &process, if (!reg_ctx_sp) continue; const addr_t sp = reg_ctx_sp->GetSP(); +const size_t red_zone = process.GetABI()->GetRedZoneSize(); lldb_private::MemoryRegionInfo sp_region; if (proc

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

@@ -6410,12 +6410,20 @@ GetCoreFileSaveRangesStackOnly(Process &process, if (!reg_ctx_sp) continue; const addr_t sp = reg_ctx_sp->GetSP(); +const size_t red_zone = process.GetABI()->GetRedZoneSize(); lldb_private::MemoryRegionInfo sp_region; if (proc

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

@@ -36,17 +35,37 @@ def verify_core_file( self.assertEqual(module_file_name, expected_file_name) self.assertEqual(module.GetUUIDString(), expected.GetUUIDString()) +red_zone = process.GetTarget().GetStackRedZoneSize() for thread_idx in

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

@@ -36,17 +35,37 @@ def verify_core_file( self.assertEqual(module_file_name, expected_file_name) self.assertEqual(module.GetUUIDString(), expected.GetUUIDString()) +red_zone = process.GetTarget().GetStackRedZoneSize() for thread_idx in

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/92002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB/Coredump] Only take the Pthread from stack start to the stackpointer + red_zone (PR #92002)

@@ -3857,8 +3857,8 @@ thread_result_t Process::RunPrivateStateThread(bool is_secondary_thread) { // case we should tell it to stop doing that. Normally, we don't NEED // to do that because we will next close the communication to the stub // and that wi

[Lldb-commits] [lldb] c441aa5 - [lldb] Add lldbutil.install_to_target() helper (#91944)

Author: Dmitry Vasilyev Date: 2024-05-14T10:59:16+04:00 New Revision: c441aa51e16e2fa5f407191287f48d2b7c302ceb URL: https://github.com/llvm/llvm-project/commit/c441aa51e16e2fa5f407191287f48d2b7c302ceb DIFF: https://github.com/llvm/llvm-project/commit/c441aa51e16e2fa5f407191287f48d2b7c302ceb.dif

[Lldb-commits] [lldb] e2f079c - [lldb] Fixed the test TestGdbRemoteLaunch (#91931)

Author: Dmitry Vasilyev Date: 2024-05-14T11:26:14+04:00 New Revision: e2f079cc6c3689fa5a6f64550b2d4fdc628dad6f URL: https://github.com/llvm/llvm-project/commit/e2f079cc6c3689fa5a6f64550b2d4fdc628dad6f DIFF: https://github.com/llvm/llvm-project/commit/e2f079cc6c3689fa5a6f64550b2d4fdc628dad6f.dif

[Lldb-commits] [lldb] [lldb][Windows] Fixed the test TestGdbRemoteMemoryTagging (PR #92077)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Windows path is case insensitive. Tests `test_QMemTags_packets` and `test_qMemTags_packets` will use the same build dir and conflict. Added a suffix to resolve conflicts. --- Full diff: https://github.co

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92078)

https://github.com/GeorgeHuyubo created https://github.com/llvm/llvm-project/pull/92078 As we have debuginfod as symbol locator available in lldb now, we want to make full use of it. In case of post mortem debugging, we don't always have the main executable available. However, the .note.gnu.b

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92078)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (GeorgeHuyubo) Changes As we have debuginfod as symbol locator available in lldb now, we want to make full use of it. In case of post mortem debugging, we don't always have the main executable available. However, the .note.gnu.build-

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92078)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f8063ffe73a3a1d704b9738169bb76ebb0f8a5e0 6a84c484070d53515c7cc473b4a0c1d566342b0f --

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92078)

https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/92078 >From 4a360988cd7242736a9557463fe529c0eaf44dc2 Mon Sep 17 00:00:00 2001 From: George Hu Date: Mon, 13 May 2024 17:03:30 -0700 Subject: [PATCH] Read and store gnu build id from loaded core file --- lldb/inc

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92078)

https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/92078 >From fa962b461d949cc26f09f8b4bdbd533d7b73131d Mon Sep 17 00:00:00 2001 From: George Hu Date: Mon, 13 May 2024 17:03:30 -0700 Subject: [PATCH] Read and store gnu build id from loaded core file --- lldb/inc

[Lldb-commits] [lldb] [lldb] Fixed the test TestDyldLaunchLinux (PR #92080)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Install a.out and libsignal_file.so to the remote target if necessary. --- Full diff: https://github.com/llvm/llvm-project/pull/92080.diff 1 Files Affected: - (modified) lldb/test/API/functionalities/d

[Lldb-commits] [lldb] c285297 - [lldb] Fix redundant condition in Target.cpp (#91882)

Author: aabhinavg Date: 2024-05-14T09:14:17+01:00 New Revision: c28529788955dbfada9f8a5092432f09eec2c3ab URL: https://github.com/llvm/llvm-project/commit/c28529788955dbfada9f8a5092432f09eec2c3ab DIFF: https://github.com/llvm/llvm-project/commit/c28529788955dbfada9f8a5092432f09eec2c3ab.diff LOG

[Lldb-commits] [lldb] [lldb] Fixed the test TestDyldLaunchLinux (PR #92080)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r c441aa51e16e2fa5f407191287f48d2b7c302ceb...a5b005cbbfd25c9fb3e59f2cb0f98c2f6a3e405d lldb/

[Lldb-commits] [lldb] [lldb] Fixed the test TestThreadStates when run with a remote target (PR #92086)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes self.wait_for_running_event(process) is always called after self.runCmd("continue"). It is strange to expect eStateConnected here. This test failed in case of a remote target. The correct state is eStateR

[Lldb-commits] [lldb] [lldb][Windows] Fixed the test gdb_remote_client/TestGDBRemotePlatformFile (PR #92088)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The tests `test_file_permissions` and `test_file_permissions_fallback` are disabled for Windows target. These tests use MockGDBServerResponder and do not depend on the real target. These tests failed in c

[Lldb-commits] [lldb] 429ce59 - [lldb][Windows] Fixed the test TestGdbRemoteMemoryTagging (#92077)

Author: Dmitry Vasilyev Date: 2024-05-14T10:15:03+01:00 New Revision: 429ce59bd0a7d93ef833939d4a92b56aae103a5a URL: https://github.com/llvm/llvm-project/commit/429ce59bd0a7d93ef833939d4a92b56aae103a5a DIFF: https://github.com/llvm/llvm-project/commit/429ce59bd0a7d93ef833939d4a92b56aae103a5a.dif

[Lldb-commits] [lldb] [lldb][Windows] Fixed tests TestPty and TestPtyServer (PR #92090)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The tests TestPty and TestPtyServer use the Unix specific python builtin module termios. They are failed in case of Windows host and Linux target. Disable them for Windows host too. --- Full diff: https:

[Lldb-commits] [lldb] 7b1b127 - [lldb][Windows] Enforce exec permission using Platform::Install() from Windows host (#91887)

Author: Dmitry Vasilyev Date: 2024-05-14T13:57:37+04:00 New Revision: 7b1b1279414217ea7f2402a03dfb5a18ea5a5367 URL: https://github.com/llvm/llvm-project/commit/7b1b1279414217ea7f2402a03dfb5a18ea5a5367 DIFF: https://github.com/llvm/llvm-project/commit/7b1b1279414217ea7f2402a03dfb5a18ea5a5367.dif

[Lldb-commits] [lldb] ac42f76 - [lldb] Fixed the test TestDyldLaunchLinux (#92080)

Author: Dmitry Vasilyev Date: 2024-05-14T14:00:16+04:00 New Revision: ac42f7689d741feda2badc438101e7952db048f3 URL: https://github.com/llvm/llvm-project/commit/ac42f7689d741feda2badc438101e7952db048f3 DIFF: https://github.com/llvm/llvm-project/commit/ac42f7689d741feda2badc438101e7952db048f3.dif

[Lldb-commits] [lldb] f658d84 - [lldb] Fixed the test TestExec (#92082)

Author: Dmitry Vasilyev Date: 2024-05-14T14:02:31+04:00 New Revision: f658d84e01bcdd49e27dc9ef80e1a6cc5f9417fe URL: https://github.com/llvm/llvm-project/commit/f658d84e01bcdd49e27dc9ef80e1a6cc5f9417fe DIFF: https://github.com/llvm/llvm-project/commit/f658d84e01bcdd49e27dc9ef80e1a6cc5f9417fe.dif

[Lldb-commits] [lldb] [lldb/aarch64] Allow unaligned PC addresses below a trap handler (PR #92093)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The stack validation heuristic is counter-productive in this case, as the unaligned address is most likely the thing that caused the signal in the first place. --- Full diff: https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb] Document some more packets (PR #92124)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Comparing a bit of the mock GDB server code to what was in the document I found these: * QLaunchArch * qSpeedTest * qSymbol qSymbol is the most mysterious but it did have some examples in a comment so

[Lldb-commits] [lldb] [lldb-dap] Correctly detect alias commands with arguments in repl (PR #92137)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes ResolveCommand will not succeed for an alias command with arguments, and the code wasn't providing any. Replace that with explicit query(ies) for the existence of a command with the given name. --- Full diff:

[Lldb-commits] [lldb] [lldb-dap] Correctly detect alias commands with arguments in repl (PR #92137)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 2b15c4a62be6ceab124cb2505ae8dc6a98ba6e7d...6d4df820e84e84a871a6d24a196608047470d7d7 lldb/

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

jimingham wrote: Thanks! Jim > On May 13, 2024, at 6:39 PM, Zequan Wu ***@***.***> wrote: > > > Can you take care of cleaning this up, this seems like a slightly complex > patch and not in an area I'm familiar with. > > Yes, will do. Sorry for the mess without reverting it earlier. > > — >

[Lldb-commits] [lldb] 0f17d9a - [lldb] Fixed the test TestThreadStates when run with a remote target (#92086)

Author: Dmitry Vasilyev Date: 2024-05-14T20:05:22+04:00 New Revision: 0f17d9a28c40eebd42c83956e2a7b5186c1814d7 URL: https://github.com/llvm/llvm-project/commit/0f17d9a28c40eebd42c83956e2a7b5186c1814d7 DIFF: https://github.com/llvm/llvm-project/commit/0f17d9a28c40eebd42c83956e2a7b5186c1814d7.dif

[Lldb-commits] [lldb] f918c05 - [lldb] Allow env override for LLDB_ARGDUMPER_PATH (#91688)

Author: Keith Smiley Date: 2024-05-14T13:43:04-07:00 New Revision: f918c056f06968763870bc3e6b9f9d7074e1f867 URL: https://github.com/llvm/llvm-project/commit/f918c056f06968763870bc3e6b9f9d7074e1f867 DIFF: https://github.com/llvm/llvm-project/commit/f918c056f06968763870bc3e6b9f9d7074e1f867.diff

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92078)

GeorgeHuyubo wrote: > Can we make this less brute force? I believe searching for the Build ID Note > should be a completely deterministic process, without the need for > heuristics. You start with the elf header, find the program headers, iterate > to find the PT_NOTE segment (there could be m

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92078)

GeorgeHuyubo wrote: > Can we make this less brute force? I believe searching for the Build ID Note > should be a completely deterministic process, without the need for > heuristics. You start with the elf header, find the program headers, iterate > to find the PT_NOTE segment (there could be m

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92078)

https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/92078 >From 6073a22e4da334ac744e1662e8f43abfee4be4f2 Mon Sep 17 00:00:00 2001 From: George Hu Date: Mon, 13 May 2024 17:03:30 -0700 Subject: [PATCH] Read and store gnu build id from loaded core file --- lldb/inc

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92078)

https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/92078 >From 740683faf4a711f8d7c169cb73492657ffb47b39 Mon Sep 17 00:00:00 2001 From: George Hu Date: Mon, 13 May 2024 17:03:30 -0700 Subject: [PATCH] Read and store gnu build id from loaded core file --- lldb/inc

[Lldb-commits] [lldb] 536abf8 - Read and store gnu build id from loaded core file (#92078)

Author: GeorgeHuyubo Date: 2024-05-14T14:35:35-07:00 New Revision: 536abf827b481f78a0879b02202fb9a3ffe3a908 URL: https://github.com/llvm/llvm-project/commit/536abf827b481f78a0879b02202fb9a3ffe3a908 DIFF: https://github.com/llvm/llvm-project/commit/536abf827b481f78a0879b02202fb9a3ffe3a908.diff

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92078)

https://github.com/GeorgeHuyubo closed https://github.com/llvm/llvm-project/pull/92078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    4   5   6   7   8   9   10   11   12   13   >