[Lldb-commits] [lldb] lldb/FreeBSD: Fix NativeRegisterContextFreeBSD_x86_64() declaration (PR #97796)

2024-07-05 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] lldb/FreeBSD: Fix NativeRegisterContextFreeBSD_x86_64() declaration (PR #97796)

2024-07-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kelvin Lee (kiyolee) Changes Supposingly this is a typo. --- Full diff: https://github.com/llvm/llvm-project/pull/97796.diff 1 Files Affected: - (modified) lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_x86_64.h (+1-1

[Lldb-commits] [lldb] b3fa2a6 - [lldb][FreeBSD] Fix NativeRegisterContextFreeBSD_x86_64() declaration (#97796)

2024-07-05 Thread via lldb-commits
Author: Kelvin Lee Date: 2024-07-05T09:05:05+01:00 New Revision: b3fa2a691ff7d5a85bc31fb428cd58d68bfecd10 URL: https://github.com/llvm/llvm-project/commit/b3fa2a691ff7d5a85bc31fb428cd58d68bfecd10 DIFF: https://github.com/llvm/llvm-project/commit/b3fa2a691ff7d5a85bc31fb428cd58d68bfecd10.diff LO

[Lldb-commits] [lldb] [lldb][FreeBSD] Fix NativeRegisterContextFreeBSD_x86_64() declaration (PR #97796)

2024-07-05 Thread via lldb-commits
github-actions[bot] wrote: @kiyolee Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [clang] [lldb] [llvm] [llvm][TargetParser] Return optional from getHostCPUFeatures (PR #97824)

2024-07-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-clang-driver Author: David Spickett (DavidSpickett) Changes Previously this took a reference to a map and returned a bool to say whether it succeeded. This is an optional but with more steps. The only reason to keep it

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-05 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/97470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-05 Thread via lldb-commits
@@ -209,7 +208,20 @@ Status ProcessMinidump::DoLoadCore() { GetTarget().SetArchitecture(arch, true /*set_platform*/); m_thread_list = m_minidump_parser->GetThreads(); - m_active_exception = m_minidump_parser->GetExceptionStream(); + std::vector exception_streams = --

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-05 Thread via lldb-commits
@@ -82,15 +82,24 @@ class MinidumpFile : public Binary { return getListStream(minidump::StreamType::ThreadList); } - /// Returns the contents of the Exception stream. An error is returned if the - /// file does not contain this stream, or the stream is smaller than t

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-05 Thread via lldb-commits
@@ -109,7 +109,7 @@ class ProcessMinidump : public PostMortemProcess { private: lldb::DataBufferSP m_core_data; llvm::ArrayRef m_thread_list; - const minidump::ExceptionStream *m_active_exception; + std::unordered_map m_exceptions_by_tid; jeffreytan81 wro

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-05 Thread via lldb-commits
@@ -9,6 +9,7 @@ #include "llvm/Object/Minidump.h" #include "llvm/Object/Error.h" #include "llvm/Support/ConvertUTF.h" +#include jeffreytan81 wrote: Is this needed? https://github.com/llvm/llvm-project/pull/97470 _

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-05 Thread via lldb-commits
@@ -53,6 +54,31 @@ Expected MinidumpFile::getString(size_t Offset) const { return Result; } +Expected> +MinidumpFile::getExceptionStreams() const { + // Scan the directories for exceptions first + std::vector exceptionStreams; + for (const auto &directory : Streams) { +

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-05 Thread via lldb-commits
https://github.com/jeffreytan81 requested changes to this pull request. One concern is that, whether minidump format specification supports multiple exception streams. If this is not supported by spec, we may generate minidump that only lldb can read/parse but can fail other consumers. It wou

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-05 Thread via lldb-commits
@@ -82,15 +82,24 @@ class MinidumpFile : public Binary { return getListStream(minidump::StreamType::ThreadList); } - /// Returns the contents of the Exception stream. An error is returned if the - /// file does not contain this stream, or the stream is smaller than t

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-05 Thread via lldb-commits
@@ -464,8 +464,8 @@ Stream::create(const Directory &StreamDesc, const object::MinidumpFile &File) { StreamKind Kind = getKind(StreamDesc.Type); switch (Kind) { case StreamKind::Exception: { -Expected ExpectedExceptionStream = -File.getExceptionStream(); +

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-05 Thread via lldb-commits
@@ -53,6 +54,31 @@ Expected MinidumpFile::getString(size_t Offset) const { return Result; } +Expected> +MinidumpFile::getExceptionStreams() const { + // Scan the directories for exceptions first + std::vector exceptionStreams; + for (const auto &directory : Streams) { +

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

2024-07-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes …lly registered languages First of all, this is done to support exceptions for the Mojo language, but it's done in a way that will benefit any other plugin language. 1. I added a new lldb-dap CL

[Lldb-commits] [lldb] 5e136b7 - [lldb] Make Listener::m_broadcasters_mutex non-recursive (#97552)

2024-07-08 Thread via lldb-commits
Author: Pavel Labath Date: 2024-07-08T09:21:38+02:00 New Revision: 5e136b7e0d310b368ce5025d55bfd7a376391199 URL: https://github.com/llvm/llvm-project/commit/5e136b7e0d310b368ce5025d55bfd7a376391199 DIFF: https://github.com/llvm/llvm-project/commit/5e136b7e0d310b368ce5025d55bfd7a376391199.diff

[Lldb-commits] [lldb] 5ce9a86 - [lldb] Make variant formatter work with libstdc++-14 (#97568)

2024-07-08 Thread via lldb-commits
Author: Pavel Labath Date: 2024-07-08T12:06:10+02:00 New Revision: 5ce9a86110df0592d036688dc5b3ae2fbdbf99db URL: https://github.com/llvm/llvm-project/commit/5ce9a86110df0592d036688dc5b3ae2fbdbf99db DIFF: https://github.com/llvm/llvm-project/commit/5ce9a86110df0592d036688dc5b3ae2fbdbf99db.diff

[Lldb-commits] [lldb] b590e9a - [lldb] Remove Listener::SetShadow (#97555)

2024-07-08 Thread via lldb-commits
Author: Pavel Labath Date: 2024-07-08T12:06:32+02:00 New Revision: b590e9a5aedabeceb00d81d49897abbf02ab3b87 URL: https://github.com/llvm/llvm-project/commit/b590e9a5aedabeceb00d81d49897abbf02ab3b87 DIFF: https://github.com/llvm/llvm-project/commit/b590e9a5aedabeceb00d81d49897abbf02ab3b87.diff

[Lldb-commits] [lldb] 4c23625 - Fix flake in TestZerothFrame.py (#96685)

2024-07-08 Thread via lldb-commits
Author: Kendal Harland Date: 2024-07-08T12:20:45+02:00 New Revision: 4c23625357b0b6091bc97478a79d522a832c2b21 URL: https://github.com/llvm/llvm-project/commit/4c23625357b0b6091bc97478a79d522a832c2b21 DIFF: https://github.com/llvm/llvm-project/commit/4c23625357b0b6091bc97478a79d522a832c2b21.diff

[Lldb-commits] [lldb] Fix flake in TestZerothFrame.py (PR #96685)

2024-07-08 Thread via lldb-commits
github-actions[bot] wrote: @kendalharland Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[Lldb-commits] [lldb] 857700f - [lldb][test] Fix type error when calling random.randrange with 'float' arg (#97328)

2024-07-08 Thread via lldb-commits
Author: Kendal Harland Date: 2024-07-08T12:22:03+02:00 New Revision: 857700ff6fb9f9f653c3788445df06db07e7bb59 URL: https://github.com/llvm/llvm-project/commit/857700ff6fb9f9f653c3788445df06db07e7bb59 DIFF: https://github.com/llvm/llvm-project/commit/857700ff6fb9f9f653c3788445df06db07e7bb59.diff

[Lldb-commits] [lldb] [lldb][test] Fix type error when calling random.randrange with 'float' arg (PR #97328)

2024-07-08 Thread via lldb-commits
github-actions[bot] wrote: @kendalharland Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[Lldb-commits] [lldb] [lldb][test] Set target OS for API tests in case of remote testing (PR #96654)

2024-07-08 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 857700ff6fb9f9f653c3788445df06db07e7bb59...c107d5d43ed4f696bb2095b2a7d32ca59696f220 lldb/

[Lldb-commits] [lldb] 1e6dfc6 - [lldb][DataFormatter] Remove support for old std::map layout (#97549)

2024-07-08 Thread via lldb-commits
Author: Michael Buch Date: 2024-07-08T13:47:44+01:00 New Revision: 1e6dfc624867fbfc6cd6e5dd534bd11f0616e7fc URL: https://github.com/llvm/llvm-project/commit/1e6dfc624867fbfc6cd6e5dd534bd11f0616e7fc DIFF: https://github.com/llvm/llvm-project/commit/1e6dfc624867fbfc6cd6e5dd534bd11f0616e7fc.diff

[Lldb-commits] [lldb] cb72aec - [lldb][DataFormatter] Move std::unordered_map::iterator formatter into LibCxxUnorderedMap.cpp (#97752)

2024-07-08 Thread via lldb-commits
Author: Michael Buch Date: 2024-07-08T13:48:06+01:00 New Revision: cb72aecea6e7da49c7a7fbeb1bde4e401324b9ba URL: https://github.com/llvm/llvm-project/commit/cb72aecea6e7da49c7a7fbeb1bde4e401324b9ba DIFF: https://github.com/llvm/llvm-project/commit/cb72aecea6e7da49c7a7fbeb1bde4e401324b9ba.diff

[Lldb-commits] [lldb] da827d0 - [lldb][DataFormatter] Simplify std::unordered_map::iterator formatter (#97754)

2024-07-08 Thread via lldb-commits
Author: Michael Buch Date: 2024-07-08T14:38:58+01:00 New Revision: da827d0896e5e66fe9130f8f4479537d3bbee1da URL: https://github.com/llvm/llvm-project/commit/da827d0896e5e66fe9130f8f4479537d3bbee1da DIFF: https://github.com/llvm/llvm-project/commit/da827d0896e5e66fe9130f8f4479537d3bbee1da.diff

[Lldb-commits] [lldb] 9dca3ac - [lldb][DataFormatter] Simplify libc++ std::map::iterator formatter (#97713)

2024-07-08 Thread via lldb-commits
Author: Michael Buch Date: 2024-07-08T15:56:05+01:00 New Revision: 9dca3ac2efb180398ef8e84bfa9f0ef283d0e6fd URL: https://github.com/llvm/llvm-project/commit/9dca3ac2efb180398ef8e84bfa9f0ef283d0e6fd DIFF: https://github.com/llvm/llvm-project/commit/9dca3ac2efb180398ef8e84bfa9f0ef283d0e6fd.diff

[Lldb-commits] [lldb] [lldb] Put the new debugger in synchronous mode in TestGlobalModuleCache (PR #98041)

2024-07-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes In async mode, the test terminates sooner that it should (`run_to_source_breakpoint` does not work in this mode), and then the test crashes due to #98038. Most of the time, the test does not fail because its

[Lldb-commits] [lldb] fe8933b - [lldb][DataFormatter] Simplify std::map formatter (#97579)

2024-07-08 Thread via lldb-commits
Author: Michael Buch Date: 2024-07-08T17:19:25+01:00 New Revision: fe8933ba211da094dc866b2bde64928c8121131b URL: https://github.com/llvm/llvm-project/commit/fe8933ba211da094dc866b2bde64928c8121131b DIFF: https://github.com/llvm/llvm-project/commit/fe8933ba211da094dc866b2bde64928c8121131b.diff

[Lldb-commits] [lldb] ed7e468 - [lldb] Improve error message for unrecognized executables (#97490)

2024-07-08 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-07-08T09:29:01-07:00 New Revision: ed7e46877dc7f09b5d194f87c87bfc2bebfcf27a URL: https://github.com/llvm/llvm-project/commit/ed7e46877dc7f09b5d194f87c87bfc2bebfcf27a DIFF: https://github.com/llvm/llvm-project/commit/ed7e46877dc7f09b5d194f87c87bfc2bebfcf27a.d

[Lldb-commits] [lldb] [LLDB] Support exception breakpoints for plugin-provided languages (PR #97675)

2024-07-08 Thread via lldb-commits
jimingham wrote: > CommandObjectBreakpoint has a harcoded list of languages for which exception > breakpoints can be enabled. I'm making this a bit more generic so that my > Mojo plugin can get this feature. Basically, I'm adding a new overridable > method `Language::SupportsExceptionBreakpoin

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-08 Thread via lldb-commits
jeffreytan81 wrote: > @jeffreytan81 I think the callout for multiple exception is a good question. > I made a C# testbed to see what would happen if I had multiple simultaneous > exceptions. [Gist > here](https://gist.github.com/Jlalond/467bc990f10fbb75cc9ca7db897a7beb). When > manually colle

[Lldb-commits] [lldb] [lldb][NFC] Add maybe_unused to err used in asserts (PR #98055)

2024-07-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Keith Smiley (keith) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/98055.diff 1 Files Affected: - (modified) lldb/tools/debugserver/source/PThreadMutex.h (+3-3) ``diff diff --git a/lldb/tools/debugserver/so

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-07-08 Thread via lldb-commits
jeffreytan81 wrote: @jimingham, thanks for the comment. When I try to add a new testcase for stepping over a function with a user set breakpoint, there is a bug found -- the user set breakpoint did not stop with `ThreadPlanSingleThreadTimeout` present (which is `c` case in your RFC comment) I

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-07-08 Thread via lldb-commits
jimingham wrote: > On Jul 8, 2024, at 12:55 PM, jeffreytan81 ***@***.***> wrote: > > > @jimingham , thanks for the comment. > > When I try to add a new testcase for stepping over a function with a user set > breakpoint, there is a bug found -- the user set brea

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-07-08 Thread via lldb-commits
jeffreytan81 wrote: > Why does the ThreadPlanSingleThreadTimeout have to claim to explain stops > (like a random breakpoint hit) that on the face of it it's not responsible for We are doing so to ensure `ThreadPlanSingleThreadTimeout` can stay in the leaf thread plan. And it comes from your su

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

2024-07-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes Fixes https://github.com/llvm/llvm-project/issues/97511 --- Full diff: https://github.com/llvm/llvm-project/pull/98089.diff 1 Files Affected: - (modified) lldb/source/Target/StackFrameList.cpp (+3-3)

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-07-08 Thread via lldb-commits
jimingham wrote: > > Why does the ThreadPlanSingleThreadTimeout have to claim to explain stops > > (like a random breakpoint hit) that on the face of it it's not responsible > > for > > Just a quick comment to add the context for this question: we are doing so to > ensure `ThreadPlanSingleThr

[Lldb-commits] [lldb] 2a7abb0 - [LLDB] DebugInfoD tests: attempt to fix Fuchsia build (#96802)

2024-07-08 Thread via lldb-commits
Author: Kevin Frei Date: 2024-07-08T16:44:16-07:00 New Revision: 2a7abb04e258542679476fa6527418c34412283c URL: https://github.com/llvm/llvm-project/commit/2a7abb04e258542679476fa6527418c34412283c DIFF: https://github.com/llvm/llvm-project/commit/2a7abb04e258542679476fa6527418c34412283c.diff LO

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

2024-07-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kevin Frei (kevinfrei) Changes Reverts llvm/llvm-project#96802 Attempt #5 fails. It's been 6 months. I despise Makefile.rules and have no ability to even *detect* these failures without _landing_ a diff. In the mean time, we have no testi

[Lldb-commits] [lldb] Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (PR #98101)

2024-07-08 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f6eda6fb7a335861d8a8ce32ea805830685f218d 76f102112c8a8a1292929b65ebb7db8b033ee344 --

[Lldb-commits] [lldb] b2fd1eb - Revert "[LLDB] DebugInfoD tests: attempt to fix Fuchsia build" (#98101)

2024-07-08 Thread via lldb-commits
Author: Kevin Frei Date: 2024-07-08T17:59:00-07:00 New Revision: b2fd1ebc3523d225956120052bcc0698adf4579f URL: https://github.com/llvm/llvm-project/commit/b2fd1ebc3523d225956120052bcc0698adf4579f DIFF: https://github.com/llvm/llvm-project/commit/b2fd1ebc3523d225956120052bcc0698adf4579f.diff LO

[Lldb-commits] [lldb] 58e750b - [lldb] Put the new debugger in synchronous mode in TestGlobalModuleCache (#98041)

2024-07-09 Thread via lldb-commits
Author: Pavel Labath Date: 2024-07-09T09:59:49+02:00 New Revision: 58e750bfd621ac7ef8647eb1170b254e05ffc10d URL: https://github.com/llvm/llvm-project/commit/58e750bfd621ac7ef8647eb1170b254e05ffc10d DIFF: https://github.com/llvm/llvm-project/commit/58e750bfd621ac7ef8647eb1170b254e05ffc10d.diff

[Lldb-commits] [lldb] cd89d92 - [lldb] Correct invalid format style (#98089)

2024-07-09 Thread via lldb-commits
Author: Alex Langford Date: 2024-07-09T09:34:06+01:00 New Revision: cd89d926aed1de3d1255043eba39801b54393040 URL: https://github.com/llvm/llvm-project/commit/cd89d926aed1de3d1255043eba39801b54393040 DIFF: https://github.com/llvm/llvm-project/commit/cd89d926aed1de3d1255043eba39801b54393040.diff

[Lldb-commits] [lldb] ae5aebd - [lldb][NFC] Add maybe_unused to err used in asserts (#98055)

2024-07-09 Thread via lldb-commits
Author: Keith Smiley Date: 2024-07-09T10:35:56+01:00 New Revision: ae5aebd48df8d15f06a7a9aa7a9e193d32cd5c85 URL: https://github.com/llvm/llvm-project/commit/ae5aebd48df8d15f06a7a9aa7a9e193d32cd5c85 DIFF: https://github.com/llvm/llvm-project/commit/ae5aebd48df8d15f06a7a9aa7a9e193d32cd5c85.diff

[Lldb-commits] [lldb] [lldb] Use correct path separator for C++ library files lookup (PR #98144)

2024-07-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes Use POSIX-style path separators when checking for libcpp library path. This is necessary to run API tests from 'std-module' group compiled on Windows host for Linux target. --- Full diff: https://g

[Lldb-commits] [lldb] afee09c - [lldb] Use correct path separator for C++ library files lookup (#98144)

2024-07-09 Thread via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-07-09T14:22:33+02:00 New Revision: afee09c50c11da1ea6ba0b341a1c10dedeaf5be6 URL: https://github.com/llvm/llvm-project/commit/afee09c50c11da1ea6ba0b341a1c10dedeaf5be6 DIFF: https://github.com/llvm/llvm-project/commit/afee09c50c11da1ea6ba0b341a1c10dedeaf5be

[Lldb-commits] [lldb] [lldb] Small cleanup of ProcessEventData::ShouldStop (PR #98154)

2024-07-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes While looking at a TSAN report (patch coming soon) in the ThreadList class, I noticed that this code would be simpler if it did not use the ThreadList class. --- Full diff: https://github.com/llvm/llvm-project

[Lldb-commits] [lldb] [lldb] Small cleanup of ProcessEventData::ShouldStop (PR #98154)

2024-07-09 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9856af634db8bf550893606ba42c56d4dff3f320 2e74468a99015645f1abbfdf42f6e5c9893e7cf3 --

[Lldb-commits] [lldb] [lldb] Small cleanup of ProcessEventData::ShouldStop (PR #98154)

2024-07-09 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/98154 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve summary string handling of dollar chars (PR #98190)

2024-07-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/98190.diff 4 Files Affected: - (modified) lldb/source/Core/FormatEntity.cpp (+126-132) - (added) lldb/test/API/functionalities/data-formatter/speci

[Lldb-commits] [lldb] [lldb] Improve summary string handling of dollar chars (PR #98190)

2024-07-09 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 822a818786ccd726e20e2b12cbcccbf9a8f23d4c...24f2c8ee442b67bae4b78543f54cae4b026f3862 lldb

[Lldb-commits] [lldb] [lldb] Improve summary string handling of dollar chars (PR #98190)

2024-07-09 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/98190 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 10f3f06 - [lldb] Improve summary string handling of dollar chars (#98190)

2024-07-09 Thread via lldb-commits
Author: Dave Lee Date: 2024-07-09T13:35:34-07:00 New Revision: 10f3f06d865fe5ec434fbaf78009301e95b59ea5 URL: https://github.com/llvm/llvm-project/commit/10f3f06d865fe5ec434fbaf78009301e95b59ea5 DIFF: https://github.com/llvm/llvm-project/commit/10f3f06d865fe5ec434fbaf78009301e95b59ea5.diff LOG:

[Lldb-commits] [lldb] 7021e44 - [lldb][test] Set target and host OS for API tests in case of remote testing

2024-07-09 Thread via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-07-10T00:25:50+02:00 New Revision: 7021e44b2f0e11717c0d82456bad0fed4a0b48f9 URL: https://github.com/llvm/llvm-project/commit/7021e44b2f0e11717c0d82456bad0fed4a0b48f9 DIFF: https://github.com/llvm/llvm-project/commit/7021e44b2f0e11717c0d82456bad0fed4a0b48f

[Lldb-commits] [lldb] [lldb] Fix the flaky test dwp-foreign-type-units.cpp. (PR #98237)

2024-07-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Zequan Wu (ZequanWu) Changes Use `--match-full-lines` with FileCheck. Otherwise, the checks for `int` and `unsigned int` will match to the fields inside two `CustomType`s and FileCheck will start scanning from there, causing string not fou

[Lldb-commits] [lldb] 12239d2 - [lldb] Small cleanup of ProcessEventData::ShouldStop (#98154)

2024-07-09 Thread via lldb-commits
Author: Pavel Labath Date: 2024-07-10T04:05:43+02:00 New Revision: 12239d253d555d6cbd65588b72e9da7acf482c2f URL: https://github.com/llvm/llvm-project/commit/12239d253d555d6cbd65588b72e9da7acf482c2f DIFF: https://github.com/llvm/llvm-project/commit/12239d253d555d6cbd65588b72e9da7acf482c2f.diff

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-09 Thread via lldb-commits
@@ -0,0 +1,446 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-09 Thread via lldb-commits
@@ -0,0 +1,446 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-09 Thread via lldb-commits
@@ -0,0 +1,446 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Fix ThreadList assignment race (PR #98293)

2024-07-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes ThreadList uses the Process mutex to guard its state. This means its not possible to safely modify its process member, as the member is required to lock the mutex. Fortunately for us, we never actually need t

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

2024-07-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This is currently just a prototype. This is motivated by the upcoming refactor of libc++'s `__compressed_pair` in https://github.com/llvm/llvm-project/pull/76756 As this will require changes to numerous L

[Lldb-commits] [lldb] [WIP][lldb][test] Add a layout simulator test for std::unique_ptr (PR #98330)

2024-07-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 918ac62916d48649f224f8c54837d25baff97a08...a25b3c8a6a36326730d00d1060ff84181bece26e lldb

[Lldb-commits] [lldb] b9496a7 - [lldb] DebugInfoD tests & fixes (but with dwp testing disabled) (#98344)

2024-07-10 Thread via lldb-commits
Author: Kevin Frei Date: 2024-07-10T09:28:22-07:00 New Revision: b9496a74eb4029629ca2e440c5441614e766f773 URL: https://github.com/llvm/llvm-project/commit/b9496a74eb4029629ca2e440c5441614e766f773 DIFF: https://github.com/llvm/llvm-project/commit/b9496a74eb4029629ca2e440c5441614e766f773.diff LO

[Lldb-commits] [lldb] [lldb] Support new libc++ __compressed_pair layout (PR #96538)

2024-07-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch is in preparation for the `__compressed_pair` refactor in https://github.com/llvm/llvm-project/pull/76756. This is mostly reviewable now. With the new layout we no longer need to unwrap the `__

[Lldb-commits] [lldb] Missed disabling the baseline test for DWP stuff (PR #98351)

2024-07-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kevin Frei (kevinfrei) Changes This should disable the failing test on the ubuntu build bots @JDevlieghere (I forgot to disable the 'baseline' test, as it tests the debugger's basic handling of DWP files, but again, the API infrastructure

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #98361)

2024-07-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Zequan Wu (ZequanWu) Changes This is a reapply of https://github.com/llvm/llvm-project/pull/92328 and https://github.com/llvm/llvm-project/pull/93839. It now passes the [test](https://github.com/llvm/llvm-project/commit/de3f1b6d68ab8a0e82

[Lldb-commits] [lldb] 2fa1220 - Missed disabling the baseline test for DWP stuff (#98351)

2024-07-10 Thread via lldb-commits
Author: Kevin Frei Date: 2024-07-10T11:07:01-07:00 New Revision: 2fa1220a37a3f55b76a29803d8333b3a3937d53a URL: https://github.com/llvm/llvm-project/commit/2fa1220a37a3f55b76a29803d8333b3a3937d53a DIFF: https://github.com/llvm/llvm-project/commit/2fa1220a37a3f55b76a29803d8333b3a3937d53a.diff LO

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-10 Thread via lldb-commits
https://github.com/beetrees created https://github.com/llvm/llvm-project/pull/98369 Adds support to LLDB for displaying 128-bit IEEE 754 floats (`__float128` in Clang, `_Float128` in GCC, `f128` in Rust). As DWARF does not currently provide a systemic way to distinguish between a 128-bit IEEE

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (beetrees) Changes Adds support to LLDB for displaying 128-bit IEEE 754 floats (`__float128` in Clang, `_Float128` in GCC, `f128` in Rust). As DWARF does not currently provide a systemic way to distinguish between a 128-bit IEEE 754 f

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-07-10 Thread via lldb-commits
@@ -58,8 +58,13 @@ class ThreadPlanStepRange : public ThreadPlan { // run' plan, then just single step. bool SetNextBranchBreakpoint(); + // Whether the input stop info is caused by the next branch breakpoint. jeffreytan81 wrote: This function only check

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-07-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r b81fcd01bde51eb8976b81a2c0c19fc0645cd2ff...aa85d4ce6981670d9e652a57caa8c73324099533 lldb/

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-10 Thread via lldb-commits
https://github.com/beetrees updated https://github.com/llvm/llvm-project/pull/98369 >From 1fa7e9025310f244633dd70566f63885ec5d3314 Mon Sep 17 00:00:00 2001 From: beetrees Date: Wed, 10 Jul 2024 18:49:45 +0100 Subject: [PATCH] [lldb] Add support for displaying `__float128` variables --- lldb/b

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 33af4bd7a4c42f55646fa7d2826cd41384ecdece 1fa7e9025310f244633dd70566f63885ec5d3314 --e

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-10 Thread via lldb-commits
https://github.com/beetrees updated https://github.com/llvm/llvm-project/pull/98369 >From 42df2ac904995b02c0f9abcf1aacf54d17dd219e Mon Sep 17 00:00:00 2001 From: beetrees Date: Wed, 10 Jul 2024 18:49:45 +0100 Subject: [PATCH] [lldb] Add support for displaying `__float128` variables --- lldb/b

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-10 Thread via lldb-commits
@@ -195,10 +199,10 @@ enum Format { ///< character arrays that can contain non printable ///< characters eFormatAddressInfo,///< Describe what an address points to (func + offset - ///< with file/line,

[Lldb-commits] [lldb] [lldb] Don't crash on malformed filesets (PR #98388)

2024-07-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The memory read can fail for a malformed fileset. Handle it gracefully instead of passing a nullptr to the std::string constructor. rdar://131477833 --- Full diff: https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] 919caa8 - [lldb] Don't crash on malformed filesets (#98388)

2024-07-10 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-07-10T14:16:56-07:00 New Revision: 919caa89ee3323228ccb1dd065d86805b34b9b6a URL: https://github.com/llvm/llvm-project/commit/919caa89ee3323228ccb1dd065d86805b34b9b6a DIFF: https://github.com/llvm/llvm-project/commit/919caa89ee3323228ccb1dd065d86805b34b9b6a.d

[Lldb-commits] [lldb] 541f22e - [lldb-dap] Support throw and catch exception breakpoints for dynamica… (#97871)

2024-07-10 Thread via lldb-commits
Author: Walter Erquinigo Date: 2024-07-10T19:05:38-04:00 New Revision: 541f22ee361a8b3029ac898db29d3e9184fb1671 URL: https://github.com/llvm/llvm-project/commit/541f22ee361a8b3029ac898db29d3e9184fb1671 DIFF: https://github.com/llvm/llvm-project/commit/541f22ee361a8b3029ac898db29d3e9184fb1671.di

[Lldb-commits] [lldb] [LLDB][SaveCore] Add SBCoreDumpOptions Object, and SBProcess::SaveCore() overload (PR #98403)

2024-07-10 Thread via lldb-commits
jimingham wrote: I prefer CoreDumpOptions, because CoreOptions could mean "options for reading in core files" or "options for writing core files", but CoreDumpOptions - reading the Dump as a verb - resolves the ambiguity. Or you could use CoreFileWritingOptions if you want to be really explic

[Lldb-commits] [lldb] [lldb][man][nfc] Don't register a markdown parser when building man packages (PR #98420)

2024-07-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alan Zhao (alanzhao1) Changes This reduces Sphinx dependencies for building lldb man pages as lldb man pages don't use markdown. --- Full diff: https://github.com/llvm/llvm-project/pull/98420.diff 1 Files Affected: - (modified) lldb/d

[Lldb-commits] [lldb] [lldb][man][nfc] Don't register a markdown parser when building man packages (PR #98420)

2024-07-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 131eb30584333b61888735b4fefe53dd25b741e0...fab10fb2efe8265d1b403a650dbd2d3348f29b73 lldb/

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-10 Thread via lldb-commits
cmtice wrote: > > BTW, I have verified that this stripped down version passes all the frame > > variable tests in LLDB. > > That's cool. Just to confirm, have you looked at replacing `target variable` > as well? It uses the same language as "frame var" under the hood, which but > it has a som

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-10 Thread via lldb-commits
@@ -0,0 +1,446 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-10 Thread via lldb-commits
@@ -0,0 +1,446 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-10 Thread via lldb-commits
@@ -0,0 +1,446 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Fix a bug for PT_TLS segments getting loaded when they shouldn't. (PR #98432)

2024-07-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes PT_LOAD and PT_TLS segments are top level sections in the ObjectFileELF section list. The two segments can often have the same program header p_vaddr and p_paddr values and this can cause section load list i

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-10 Thread via lldb-commits
@@ -0,0 +1,468 @@ +//===-- DILAST.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] a18f45f - [lldb] Fix string truncation method when substring is the prefix of string (NFC) (#94785)

2024-07-11 Thread via lldb-commits
Author: Shivam Gupta Date: 2024-07-11T12:57:50+05:30 New Revision: a18f45f556c781d711f82043bf451fcce8324163 URL: https://github.com/llvm/llvm-project/commit/a18f45f556c781d711f82043bf451fcce8324163 DIFF: https://github.com/llvm/llvm-project/commit/a18f45f556c781d711f82043bf451fcce8324163.diff

[Lldb-commits] [lldb] 18e70a4 - [llvm][TargetParser] Return StringMap from getHostCPUFeatures (#97824)

2024-07-11 Thread via lldb-commits
Author: David Spickett Date: 2024-07-11T10:32:43+01:00 New Revision: 18e70a4d5042299054dae7d3995f6ccd8f4112b3 URL: https://github.com/llvm/llvm-project/commit/18e70a4d5042299054dae7d3995f6ccd8f4112b3 DIFF: https://github.com/llvm/llvm-project/commit/18e70a4d5042299054dae7d3995f6ccd8f4112b3.diff

[Lldb-commits] [lldb] [lldb][test] Fix ComputeClangResourceDirectory test when CLANG_RESOURCE_DIR is set (PR #98464)

2024-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This was found during testing of llvm snapshots for Fedora. This test was looking for an exact string match of the path calculated by starting with lib/liblldb and with bin/lldb. However when CLANG_RE

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-07-11 Thread via lldb-commits
ita-sc wrote: Gentle ping https://github.com/llvm/llvm-project/pull/90075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e1bd337 - [lldb] Fix ThreadList assignment race (#98293)

2024-07-11 Thread via lldb-commits
Author: Pavel Labath Date: 2024-07-11T14:04:19+02:00 New Revision: e1bd337865fca9f455225ba37b76595d37bad213 URL: https://github.com/llvm/llvm-project/commit/e1bd337865fca9f455225ba37b76595d37bad213 DIFF: https://github.com/llvm/llvm-project/commit/e1bd337865fca9f455225ba37b76595d37bad213.diff

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

2024-07-11 Thread via lldb-commits
@@ -55,14 +55,23 @@ def test_basic(self): self.assertEqual(len(step_in_targets), 3, "expect 3 step in targets") # Verify the target names are correct. -self.assertEqual(step_in_targets[0]["label"], "bar()", "expect bar()") -self.assertEqual(step

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

2024-07-11 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/96687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 55b1410 - [lldb] Fix a bug for PT_TLS segments getting loaded when they shouldn't. (#98432)

2024-07-11 Thread via lldb-commits
Author: Greg Clayton Date: 2024-07-11T09:18:43-07:00 New Revision: 55b1410895b69d8e4517f6a2a2978b414b4ecac3 URL: https://github.com/llvm/llvm-project/commit/55b1410895b69d8e4517f6a2a2978b414b4ecac3 DIFF: https://github.com/llvm/llvm-project/commit/55b1410895b69d8e4517f6a2a2978b414b4ecac3.diff

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-07-11 Thread via lldb-commits
jimingham wrote: > On Jul 10, 2024, at 9:22 PM, cmtice ***@***.***> wrote: > > > @cmtice commented on this pull request. > > In lldb/include/lldb/Core/DILAST.h > : > > > +/// Checks to see if the CompilerType is a Smar

[Lldb-commits] [lldb] [lldb] Fix section printing to always align. (PR #98521)

2024-07-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes Section IDs are 64 bit and if a section ID was over 4GB, then the tabular output of the "target modules dump sections" command would not align to the column headers. Also if the section type's name was too l

[Lldb-commits] [lldb] 43024a4 - [lldb][man][nfc] Don't register a markdown parser when building man packages (#98420)

2024-07-11 Thread via lldb-commits
Author: Alan Zhao Date: 2024-07-11T12:54:26-07:00 New Revision: 43024a465120315464490ca9c6074553cd968089 URL: https://github.com/llvm/llvm-project/commit/43024a465120315464490ca9c6074553cd968089 DIFF: https://github.com/llvm/llvm-project/commit/43024a465120315464490ca9c6074553cd968089.diff LOG

<    1   2   3   4   5   6   7   8   9   10   >