bryant added inline comments.
Comment at: CMakeLists.txt:46
+COMMAND
+ ${PYTHON_EXECUTABLE}
${CMAKE_CURRENT_SOURCE_DIR}/scripts/finishSwigWrapperClasses.py
+ --srcRoot=${LLDB_SOURCE_DIR}
You can reduce diff noise by leaving format
bryant added inline comments.
Comment at: scripts/Python/prepare_binding_Python.py:222
+)
+logging.info("running swig with: %r", command)
ldrumm wrote:
> bryant wrote:
> > You can reduce diff noise by limiting your changes to removing the %s. So,
> >
>
bryant added inline comments.
Comment at: CMakeLists.txt:53
+ --lldbLibDir=lib${LLVM_LIBDIR_SUFFIX}
+ ${FINISH_EXTRA_ARGS}
+VERBATIM
The indentation here could match the above.
https://reviews.llvm.org/D26757
_
