[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-10-31 Thread Zequan Wu via lldb-commits
@@ -1810,7 +1813,27 @@ SymbolFileNativePDB::ParseVariablesForCompileUnit(CompileUnit &comp_unit, VariableList &variables) { PdbSymUid sym_uid(comp_unit.GetID()); lldbassert(sym_uid.kind() == PdbSymUidKind::Compiland); - re

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-10-31 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/114303 >From 215c36a380946a0c8cab63605bd0a9da13e642cd Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Tue, 29 Oct 2024 13:19:50 -0700 Subject: [PATCH 1/2] [lldb][NativePDB] Parse global variables. --- .../NativePDB/S

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-11-01 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/114303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-11-01 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/114303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-10-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/112811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-10-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu ready_for_review https://github.com/llvm/llvm-project/pull/112811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-10-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/114303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-10-30 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/114303 This doesn't parse S_CONSTANT case yet, because I found that `std::strong_ordering::equal` being a S_CONSTANT and has type of LF_STRUCTURE which is not currently handled when creating dwarf expression for the

[Lldb-commits] [lldb] 19c0a74 - [lldb] Fix lldb windows build breakage from https://github.com/llvm/llvm-project/pull/113839.

2024-10-28 Thread Zequan Wu via lldb-commits
Author: Zequan Wu Date: 2024-10-28T11:13:00-07:00 New Revision: 19c0a74ad6baa9eb38dbe0a20af7c67999c41821 URL: https://github.com/llvm/llvm-project/commit/19c0a74ad6baa9eb38dbe0a20af7c67999c41821 DIFF: https://github.com/llvm/llvm-project/commit/19c0a74ad6baa9eb38dbe0a20af7c67999c41821.diff LOG

[Lldb-commits] [lldb] [NFC][lldb-dap] Clean-up includes (PR #113839)

2024-10-28 Thread Zequan Wu via lldb-commits
@@ -6,25 +6,21 @@ // //===--===// -#include #include #include #include #include #include "llvm/ADT/StringRef.h" -#include "llvm/Support/FormatAdapters.h" #include "llvm/Support/FormatVariadic.h"

[Lldb-commits] [lldb] [lldb] Infer MSInheritanceAttr for CXXRecordDecl with DWARF on Windows (PR #115177)

2024-11-11 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/115177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-10-31 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/114303 >From 215c36a380946a0c8cab63605bd0a9da13e642cd Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Tue, 29 Oct 2024 13:19:50 -0700 Subject: [PATCH 1/3] [lldb][NativePDB] Parse global variables. --- .../NativePDB/S

[Lldb-commits] [lldb] [lldb] Set LLDB_USE_NATIVE_PDB_READER at the directory level (PR #114455)

2024-10-31 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu approved this pull request. Thanks, this makes testing nativepdb/pdb much easier. https://github.com/llvm/llvm-project/pull/114455 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [lldb][NativePDB] Parse global variables. (PR #114303)

2024-10-31 Thread Zequan Wu via lldb-commits
@@ -1810,7 +1813,27 @@ SymbolFileNativePDB::ParseVariablesForCompileUnit(CompileUnit &comp_unit, VariableList &variables) { PdbSymUid sym_uid(comp_unit.GetID()); lldbassert(sym_uid.kind() == PdbSymUidKind::Compiland); - re

[Lldb-commits] [lldb] [lldb][NFC] Replace lldb's DWARFFormValue::ValueType with llvm's (PR #109853)

2024-09-24 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/109853 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Replace lldb's DWARFFormValue::ValueType with llvm's (PR #109853)

2024-09-24 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/109853 None >From 93754d527df5e1336f63999fded1c7c906891f7f Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Tue, 24 Sep 2024 12:51:33 -0700 Subject: [PATCH] [lldb][NFC] Replace lldb's ValueType with llvm's --- .../Sy

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-25 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/110058 They are close enough to swap lldb's `DWARFDebugArangeSet` with the llvm one. The difference is that llvm's `DWARFDebugArangeSet` add empty ranges when extracting. To accommodate this, `DWARFDebugAranges` in l

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-25 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/110058 >From 8e1c59729905fb89a8764ace3dfa0d04119d273e Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 25 Sep 2024 15:59:29 -0700 Subject: [PATCH 1/2] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-26 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/110058 >From 8e1c59729905fb89a8764ace3dfa0d04119d273e Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 25 Sep 2024 15:59:29 -0700 Subject: [PATCH 1/3] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-26 Thread Zequan Wu via lldb-commits
@@ -7,65 +7,45 @@ //===--===// #include "DWARFDebugAranges.h" -#include "DWARFDebugArangeSet.h" #include "DWARFUnit.h" #include "LogChannelDWARF.h" #include "lldb/Utility/Log.h" #include "lldb/Utility/Tim

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-27 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/110058 >From 8e1c59729905fb89a8764ace3dfa0d04119d273e Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 25 Sep 2024 15:59:29 -0700 Subject: [PATCH 1/4] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-27 Thread Zequan Wu via lldb-commits
@@ -73,6 +73,12 @@ class DWARFDebugArangeSet { return desc_iterator_range(ArangeDescriptors.begin(), ArangeDescriptors.end()); } + + size_t getDescriptorsSize() const { return ArangeDescriptors.size(); } + + const Descriptor &getDescriptio

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-27 Thread Zequan Wu via lldb-commits
@@ -132,34 +134,33 @@ TEST_F(SymbolFileDWARFTests, ParseArangesWithMultipleTerminators) { // Set the big endian length correctly. const offset_t binary_data_size = sizeof(binary_data); binary_data[3] = (uint8_t)binary_data_size - 4; - DWARFDataExtractor data; - data.Se

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-10-01 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/110058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-10-01 Thread Zequan Wu via lldb-commits
@@ -132,34 +134,33 @@ TEST_F(SymbolFileDWARFTests, ParseArangesWithMultipleTerminators) { // Set the big endian length correctly. const offset_t binary_data_size = sizeof(binary_data); binary_data[3] = (uint8_t)binary_data_size - 4; - DWARFDataExtractor data; - data.Se

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-10-01 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/110058 >From 8e1c59729905fb89a8764ace3dfa0d04119d273e Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 25 Sep 2024 15:59:29 -0700 Subject: [PATCH 1/5] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-10-01 Thread Zequan Wu via lldb-commits
@@ -132,34 +134,33 @@ TEST_F(SymbolFileDWARFTests, ParseArangesWithMultipleTerminators) { // Set the big endian length correctly. const offset_t binary_data_size = sizeof(binary_data); binary_data[3] = (uint8_t)binary_data_size - 4; - DWARFDataExtractor data; - data.Se

[Lldb-commits] [lldb] e379b4b - [lldb] Fix compile failure on SymbolFileDWARFTests.cpp with gcc

2024-10-02 Thread Zequan Wu via lldb-commits
Author: Zequan Wu Date: 2024-10-02T14:11:04-07:00 New Revision: e379b4b67f760e743d8bc826cc6de00a27109dbd URL: https://github.com/llvm/llvm-project/commit/e379b4b67f760e743d8bc826cc6de00a27109dbd DIFF: https://github.com/llvm/llvm-project/commit/e379b4b67f760e743d8bc826cc6de00a27109dbd.diff LOG

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-10-02 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > On Ubuntu 22.04 with the latest official supported GCC 12.3.0, this commit > breaks the `check-lldb` due to a failed compilation: > > ``` > llvm-project/lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp:95:33: > error: class template placeholder 'llvm::ArrayRef' not pe

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-07 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/112811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-07 Thread Zequan Wu via lldb-commits
@@ -0,0 +1,31 @@ +// Test lldb is able to compute the fully qualified names on templates with +// -gsimple-template-names and -fdebug-types-section. + +// REQUIRES: lld + +// Test against logging to see if we print the fully qualified names correctly. +// RUN: %clangxx --target=x8

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-07 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/112811 >From 3fc0675398547617731d0501e3d4b98e2ffc480e Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 9 Oct 2024 22:35:46 -0700 Subject: [PATCH 1/3] [lldb][dwarf] Compute fully qualified names on simplified templ

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-07 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/112811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-07 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/112811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-07 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/112811 >From 3fc0675398547617731d0501e3d4b98e2ffc480e Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 9 Oct 2024 22:35:46 -0700 Subject: [PATCH 1/4] [lldb][dwarf] Compute fully qualified names on simplified templ

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-06 Thread Zequan Wu via lldb-commits
@@ -0,0 +1,31 @@ +// Test lldb is able to compute the fully qualified names on templates with +// -gsimple-template-names and -fdebug-types-section. + +// REQUIRES: lld + +// Test against logging to see if we print the fully qualified names correctly. +// RUN: %clangxx --target=x8

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-06 Thread Zequan Wu via lldb-commits
@@ -95,6 +100,8 @@ class DWARFBaseDIE { const char *GetName() const; + const char *getShortName() const { return GetName(); } ZequanWu wrote: Grouped those new APIs for each lldb class and added a comment for it. https://github.com/llvm/llvm-project/pull

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-06 Thread Zequan Wu via lldb-commits
@@ -0,0 +1,31 @@ +// Test lldb is able to compute the fully qualified names on templates with +// -gsimple-template-names and -fdebug-types-section. + +// REQUIRES: lld + +// Test against logging to see if we print the fully qualified names correctly. +// RUN: %clangxx --target=x8

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-06 Thread Zequan Wu via lldb-commits
@@ -46,6 +48,7 @@ class DWARFBaseDIE { explicit operator bool() const { return IsValid(); } bool IsValid() const { return m_cu && m_die; } + bool isValid() const { return IsValid(); } ZequanWu wrote: Removed both `IsValid()` and `IsValid()` and switched

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-06 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/112811 >From 3fc0675398547617731d0501e3d4b98e2ffc480e Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 9 Oct 2024 22:35:46 -0700 Subject: [PATCH 1/2] [lldb][dwarf] Compute fully qualified names on simplified templ

[Lldb-commits] [lldb] [lldb/NativePDB] Don't create parentless blocks (PR #117581)

2024-11-25 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/117581 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #117071)

2024-11-20 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/117071 This is a reland of https://github.com/llvm/llvm-project/pull/112811. Fixed the bot breakage by running ld.lld explicitly. >From 88aac9780b33410b0fb119c07eec6b4005149cf4 Mon Sep 17 00:00:00 2001 From: Zequan W

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-20 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > This patch broke the lldb incremental bot on greendragon > > https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/15486/ > > TEST 'lldb-shell :: > SymbolFile/DWARF/x86/simplified-template-names.cpp' FAILED > Exit Code:

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #117071)

2024-11-20 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/117071 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #112811)

2024-11-18 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/112811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2e425bf - Reapply "[lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (#117071)"

2024-12-04 Thread Zequan Wu via lldb-commits
Author: Zequan Wu Date: 2024-12-04T13:05:36-08:00 New Revision: 2e425bf629f80c8f8582c266d25a384e7549198d URL: https://github.com/llvm/llvm-project/commit/2e425bf629f80c8f8582c266d25a384e7549198d DIFF: https://github.com/llvm/llvm-project/commit/2e425bf629f80c8f8582c266d25a384e7549198d.diff LOG

[Lldb-commits] [lldb] [lldb] Show value for libcxx and libstdcxx summary and remove pointer value in libcxx container summary (PR #125294)

2025-02-03 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/125294 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show value for libcxx and libstdcxx summary and remove pointer value in libcxx container summary (PR #125294)

2025-02-03 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/125294 >From bbecf2f990c1fdf8ed993c3bba4c68212ebb299c Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Fri, 31 Jan 2025 13:05:14 -0800 Subject: [PATCH 1/4] [lldb] Show value for libcxx and libstdcxx summary and remove

[Lldb-commits] [lldb] Add SBDebugger:: AddNotificationCallback API (PR #111206)

2025-01-30 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Is there any update on this PR? I'm interested in working on a similar callback that can be triggered when target is created, but I want to wait for this one to get landed first as they will share some common code. https://github.com/llvm/llvm-project/pull/111206 __

[Lldb-commits] [lldb] [lldb] Show value for libcxx and libstdcxx summary and remove pointer value in libcxx container summary (PR #125294)

2025-01-31 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/125294 This has two changes: 1. Set show value for libcxx and libstdcxx summary provider. This will print the pointer value for both pointer type and reference type. 2. Remove pointer value printing in libcxx containe

[Lldb-commits] [lldb] [lldb] Show value for libcxx and libstdcxx summary and remove pointer value in libcxx container summary (PR #125294)

2025-01-31 Thread Zequan Wu via lldb-commits
@@ -172,7 +172,4 @@ def test_ref_and_ptr(self): # The pointer should just show the right number of elements: -ptrAddr = self.findVariable("ptr").GetValue() -self.expect_expr( -"ptr", result_type="std::span *", result_summary=f"{ptrAddr} si

[Lldb-commits] [lldb] [lldb] Show value for libcxx and libstdcxx summary and remove pointer value in libcxx container summary (PR #125294)

2025-01-31 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/125294 >From bbecf2f990c1fdf8ed993c3bba4c68212ebb299c Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Fri, 31 Jan 2025 13:05:14 -0800 Subject: [PATCH 1/2] [lldb] Show value for libcxx and libstdcxx summary and remove

[Lldb-commits] [lldb] [lldb] Show value for libcxx and libstdcxx summary and remove pointer value in libcxx container summary (PR #125294)

2025-01-31 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/125294 >From bbecf2f990c1fdf8ed993c3bba4c68212ebb299c Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Fri, 31 Jan 2025 13:05:14 -0800 Subject: [PATCH 1/3] [lldb] Show value for libcxx and libstdcxx summary and remove

[Lldb-commits] [lldb] [WIP][lldb][DWARFASTParserClang] Eagerly search definitions for Objective-C classes (PR #119860)

2024-12-17 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > I think the way it's currently written doesn't handle the case where we call > ParseStructureLikeDIE with a forward declaration, and then later on with a > definition DIE. For C++ structures we handle that by updating the > UniqueTypeMap with the definition DIE, etc. We'll pr

[Lldb-commits] [lldb] [WIP][lldb][DWARFASTParserClang] Eagerly search definitions for Objective-C classes (PR #119860)

2024-12-13 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > Since there's no good way to tell whether a forward declaration is an > Objective-C type, the only solution I can really see here is to eagerly fetch > the definition for Objective-C types. That makes sense. https://github.com/llvm/llvm-project/pull/119860 __

[Lldb-commits] [lldb] [WIP][lldb][DWARFASTParserClang] Eagerly search definitions for Objective-C classes (PR #119860)

2024-12-13 Thread Zequan Wu via lldb-commits
@@ -1671,43 +1671,84 @@ DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc, attrs.is_forward_declaration = true; } + DWARFDIE def_die; + if (attrs.is_forward_declaration && cu_language == eLanguageTypeObjC) { +def_die = dwarf->FindDefinitionDIE(die

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] CompleteType: Lookup type in the declaration DIE's SymbolFile (PR #120569)

2024-12-19 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > > > In which case, GetDIEToType().lookup(decl_die) will return a nullptr. > > > This is already a bit iffy because some of the surrounding code assumes > > > we don't call CompleteTypeFromDWARF with a nullptr Type*. E.g., > > > CompleteEnumType blindly dereferences it (though

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] CompleteType: Lookup type in the declaration DIE's SymbolFile (PR #120569)

2024-12-19 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > In which case, GetDIEToType().lookup(decl_die) will return a nullptr. This is > already a bit iffy because some of the surrounding code assumes we don't call > CompleteTypeFromDWARF with a nullptr Type*. E.g., CompleteEnumType blindly > dereferences it (though enums will neve

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] CompleteType: Lookup type in the declaration DIE's SymbolFile (PR #120569)

2024-12-19 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > CompleteRecordType will call UpdateToDefDIE, which will update the > Declaration stored in the map to something non-zero (we get it from the > ParsedDWARFTypeAttributes(def_die)). Ah, I missed this part. Thanks for the explanation. Also thanks for fixing those bugs introduce

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] Ignore Declaration when searching through UniqueDWARFASTTypeList in C++ (PR #120809)

2024-12-20 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > This particular example was fixed by > https://github.com/llvm/llvm-project/pull/120569 but this still feels a > little inconsistent. I'm not entirely sure we can get into that situation > after that patch anymore. So the only test-case I could come up with was the > unit-te

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] Ignore Declaration when searching through UniqueDWARFASTTypeList in C++ (PR #120809)

2024-12-20 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu approved this pull request. LGTM, thanks for fixing it. https://github.com/llvm/llvm-project/pull/120809 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] Share GetDIEToType between SymbolFiles of a SymbolFileDWARFDebugMap (PR #120569)

2024-12-20 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > Just tried this. Unfortunately [we remove the CompilerType from the > `GetForwardDeclCompilerTypeToDIE`](https://github.com/llvm/llvm-project/blob/d7ddc976d544528fe7f16882f5bec66c3b2a7884/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp#L1577) > map inside of `Complete

[Lldb-commits] [lldb] [lldb][SymbolFileDWARF] Share GetDIEToType between SymbolFiles of a SymbolFileDWARFDebugMap (PR #120569)

2024-12-20 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > > > As an alternative, we might be able to make the die-to-type map shared > > > between all symbol files in a debug map (similar to how "unique dwarf ast > > > type map" is shared). > > > > > > Yea I considered that, but I was concerned with the unforeseen > > complication

[Lldb-commits] [lldb] [llvm] [DWARF] Fix DWARTTypePrinter unable to print qualified name for DW_TAG_typedef DIE (PR #117239)

2024-11-22 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > Where those names go from "const string" to "const std::__1::string" (and > from "string" to "std::__1::string")? or something like that. Yes. In some cases, it's getting super verbose, e.g: `std::__1::basic_string, std::__1::allocator >::value_type`. > Probably the most co

[Lldb-commits] [lldb] [llvm] [DWARF] Fix DWARTTypePrinter unable to print qualified name for DW_TAG_typedef DIE (PR #117239)

2024-11-21 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Just noticed that this breaks `llvm/test/tools/dsymutil/X86/DWARFLinkerParallel/odr-string.test` because for `DW_TAG_typedef`, llvm-dwarfdump will print the fully qualified name instead of the base name in DW_AT_type that refers to it. Do you think we should keep the original

[Lldb-commits] [lldb] [llvm] [DWARF] Fix DWARTTypePrinter unable to print qualified name for DW_TAG_typedef DIE (PR #117239)

2024-11-21 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/117239 Fix a bug introduced in https://github.com/llvm/llvm-project/pull/117071. Ideally the DWARTTypePrinter test should go to `llvm/unittests/DebugInfo/DWARF/DWARTTypePrinterTest.cpp`. >From 5ecdcda44c179d32e64fae

[Lldb-commits] [lldb] [llvm] [lldb][dwarf] Compute fully qualified names on simplified template names with DWARFTypePrinter (PR #117071)

2024-11-21 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > if you're sending things for presubmit checks, but not for precommit review, > please include the `skip-precommit-approval` label Good to know that. > - but in this case it looks like you requested review, but then submitted > without waiting for that review? Please don't do

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-22 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/124048 Currently, the type `T`'s formatter will be matched for `T`, `T*`, `T**` and so on. This is inconsistent with the behaviour of `SBValue::GetChildMemberWithName` which can only dereference the pointer type at

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > How does this patch fit with the: > > ``` >-p ( --skip-pointers ) > Don't use this format for pointers-to-type objects. > >-r ( --skip-references ) > Don't use this format for references-to-type objects. > ``` > > settings in `type add`? It seems like

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/124048 >From 1948805894e006d84fbb78299574b3c7618959d8 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 22 Jan 2025 18:32:11 -0800 Subject: [PATCH 1/2] [lldb][Formatters] Do not recursively dereference pointer type

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Zequan Wu via lldb-commits
@@ -222,14 +223,15 @@ void FormatManager::GetPossibleMatches( if (compiler_type.IsPointerType()) { CompilerType non_ptr_type = compiler_type.GetPointeeType(); -GetPossibleMatches(valobj, non_ptr_type, use_dynamic, entries, - current_flags.WithSt

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > If the objection is that's a pain to do for every formatter, we could have > the type matcher do the dereferencing and always pass the formatter the > ValueObject that is the type they registered the formatter for. Do you mean pass the formatter the ValueObject with type `T`

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Zequan Wu via lldb-commits
ZequanWu wrote: @labath What do you think? The solution above will still use the formatters for `T` when `T**` is printed. https://github.com/llvm/llvm-project/pull/124048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-23 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > > > How does this patch fit with the: > > > ``` > > >-p ( --skip-pointers ) > > > Don't use this format for pointers-to-type objects. > > > > > >-r ( --skip-references ) > > > Don't use this format for references-to-type objects. > > > ``` > > > > > >

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-01-28 Thread Zequan Wu via lldb-commits
ZequanWu wrote: > > > I'd rather keep the flexibility, if you don't mind doing the work to add > > > that. For now, it seems okay for the current libc++/libstdc++ ones to > > > declare what they support (which is 1 pointer depth). If someone has a > > > reason to come back and extend these one

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-02 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/138209 >From dcb5b2596267d908dea1474164a1fadf1cd23aef Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 1 May 2025 14:51:24 -0700 Subject: [PATCH 1/2] [lldb][Formatters] Add --pointer-match-depth option to "type su

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-02 Thread Zequan Wu via lldb-commits
@@ -96,6 +97,8 @@ class FormattersMatchCandidate { bool DidStripTypedef() const { return m_flags.stripped_typedef; } + uint32_t GetPtrStrippedDepth() const { return m_ptr_stripped_depth; } ZequanWu wrote: I meant this `FormattersMatchCandidate` has been s

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-02 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/138209 >From dcb5b2596267d908dea1474164a1fadf1cd23aef Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 1 May 2025 14:51:24 -0700 Subject: [PATCH 1/3] [lldb][Formatters] Add --pointer-match-depth option to "type su

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-01 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/138209 Currently, the type `T`'s summary formatter will be matched for `T`, `T*`, `T**` and so on. This is unexpected in many data formatters. Such unhandled cases could cause the data formatter to crash. An example

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-02 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/138209 >From dcb5b2596267d908dea1474164a1fadf1cd23aef Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 1 May 2025 14:51:24 -0700 Subject: [PATCH 1/4] [lldb][Formatters] Add --pointer-match-depth option to "type su

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Adjust language type for conflicting Objective-C++ forward declarations (PR #130768)

2025-03-11 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Since this makes lldb to do type searching more aggressively, I want to get a sense of performance impact on simplified template names from this PR. When I running the a test program with LLDB (with this PR), LLDB crashes. I don't have a reduced test case yet, will probably wor

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-16 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/138209 >From dcb5b2596267d908dea1474164a1fadf1cd23aef Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 1 May 2025 14:51:24 -0700 Subject: [PATCH 1/5] [lldb][Formatters] Add --pointer-match-depth option to "type su

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-14 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Ping. https://github.com/llvm/llvm-project/pull/138209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2   3   4