[Lldb-commits] [lldb] [lldb-vscode] Show a fake child with the raw value of synthetic types (PR #65552)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/65552 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0762b2e - [lldb-vscode] Fix variable test

Author: walter erquinigo Date: 2023-09-06T22:52:01-04:00 New Revision: 0762b2e6cacf9a1aa8b5e832206f4c94744d0150 URL: https://github.com/llvm/llvm-project/commit/0762b2e6cacf9a1aa8b5e832206f4c94744d0150 DIFF: https://github.com/llvm/llvm-project/commit/0762b2e6cacf9a1aa8b5e832206f4c94744d0150.di

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/65687: "descriptive summaries" should only be used for small to medium binaries because of the performance penalty the cause when completing types. I'm defaulting it to false. Besides that, the "raw child" fo

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo review_requested https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo review_requested https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo review_requested https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

@@ -240,6 +240,16 @@ "timeout": { "type": "string", "description": "The time in seconds to wait

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/65687: >From fc0700e761db9761675c42826e8f5bfa5b510840 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 7 Sep 2023 18:35:10 -0400 Subject: [PATCH] [lldb-vscode] Make descriptive summaries and raw chil

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo resolved https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo resolved https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo resolved https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo resolved https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo resolved https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/65687: >From 4d563d5542291c4b386caaad1f6f4c18f4c7bfd1 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 7 Sep 2023 18:35:10 -0400 Subject: [PATCH] [lldb-vscode] Make descriptive summaries and raw chil

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

walter-erquinigo wrote: @clayborg , do you get notifications when I update the PR? :) I'm still getting used to github for llvm. In any case, this is ready for review. https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] c154ba8 - [LLDB][NFC] Add the mojo language to Language::GetPrimaryLanguage

Author: walter erquinigo Date: 2023-09-11T15:25:05-04:00 New Revision: c154ba8abeb6f59f85a9bb6fdf7bd79ad0d8c05c URL: https://github.com/llvm/llvm-project/commit/c154ba8abeb6f59f85a9bb6fdf7bd79ad0d8c05c DIFF: https://github.com/llvm/llvm-project/commit/c154ba8abeb6f59f85a9bb6fdf7bd79ad0d8c05c.di

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/65687: >From 6415738e5c359553212d4a04780694587a536a82 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 7 Sep 2023 18:35:10 -0400 Subject: [PATCH] [lldb-vscode] Make descriptive summaries and raw chil

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/65687: >From 6415738e5c359553212d4a04780694587a536a82 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 7 Sep 2023 18:35:10 -0400 Subject: [PATCH 1/2] [lldb-vscode] Make descriptive summaries and raw

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4a030f5 - [lldb-vscode][NFC] Access a pointee type in a simpler way

Author: walter erquinigo Date: 2023-09-15T12:26:04-04:00 New Revision: 4a030f5b245b63fe09c29686c50d40796c987d96 URL: https://github.com/llvm/llvm-project/commit/4a030f5b245b63fe09c29686c50d40796c987d96 DIFF: https://github.com/llvm/llvm-project/commit/4a030f5b245b63fe09c29686c50d40796c987d96.di

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

@@ -0,0 +1,436 @@ +Data Formatters +=== + +This page is an introduction to the design of the LLDB data formatters +subsystem. The intended target audience are people interested in understanding +or modifying the formatters themselves rather than writing a specific data

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

@@ -0,0 +1,436 @@ +Data Formatters +=== + +This page is an introduction to the design of the LLDB data formatters +subsystem. The intended target audience are people interested in understanding +or modifying the formatters themselves rather than writing a specific data

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66527 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

@@ -0,0 +1,436 @@ +Data Formatters +=== + +This page is an introduction to the design of the LLDB data formatters +subsystem. The intended target audience are people interested in understanding +or modifying the formatters themselves rather than writing a specific data

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

@@ -0,0 +1,436 @@ +Data Formatters +=== + +This page is an introduction to the design of the LLDB data formatters +subsystem. The intended target audience are people interested in understanding +or modifying the formatters themselves rather than writing a specific data

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

@@ -0,0 +1,436 @@ +Data Formatters +=== + +This page is an introduction to the design of the LLDB data formatters +subsystem. The intended target audience are people interested in understanding +or modifying the formatters themselves rather than writing a specific data

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

https://github.com/walter-erquinigo commented: Awesome doc! https://github.com/llvm/llvm-project/pull/66527 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

@@ -0,0 +1,436 @@ +Data Formatters +=== + +This page is an introduction to the design of the LLDB data formatters +subsystem. The intended target audience are people interested in understanding +or modifying the formatters themselves rather than writing a specific data

[Lldb-commits] [lldb] [lldb-vscode] Show value addresses in a short format (PR #66534)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/66534 The variables pane on VSCode is very narrow by default, and lldb-vscode has been using the default formatter for addresses, which uses 18 characters for each address. That's a bit too much because it pr

[Lldb-commits] [lldb] [lldb-vscode] Show value addresses in a short format (PR #66534)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66534 >From d8060f818b18b3fe64641d9683fa49ffca0b3736 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 12:40:33 -0400 Subject: [PATCH] [lldb-vscode] Show value addresses in a short format

[Lldb-commits] [lldb] [lldb-vscode] Show value addresses in a short format (PR #66534)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66534 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Show value addresses in a short format (PR #66534)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/66534 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Show value addresses in a short format (PR #66534)

walter-erquinigo wrote: I initially didn't want to mess with global configurations, but after a second thought, I think your solution is better. I'll try that out https://github.com/llvm/llvm-project/pull/66534 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] [lldb-vscode] Show value addresses in a short format (PR #66534)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/66534 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for print hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/66548 As suggested by Greg in https://github.com/llvm/llvm-project/pull/66534, I'm adding a setting at the Target level that controls whether to show leading zeroes in hex ValueObject values. This has the be

[Lldb-commits] [lldb] [LLDB] Add a setting for print hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for print hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66548 >From 99b2a5e3663263fd1a92e350a3254fafbe9724c5 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 16:41:23 -0400 Subject: [PATCH] [LLDB] Add a setting for print hex values without lea

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: @jimingham , that's a good catch. Probably I should rename this because I want this setting to affect only SBValueObject::GetValue(), which is want ends up being sent to IDEs as a common interface. Trying to control all places that print as hex value is a bit too much a

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: I like Greg's proposal of naming it `show-hex-variable-values-with-leading-zeroes`. Seems very clear. I also like the idea of making it a global target config, which would simplify the code. https://github.com/llvm/llvm-project/pull/66548 ___

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/66551 enableAutoVariableSummaries is a setting that enhances the summaries of variables in the IDE. A shortcoming of this feature is that it wasn't showing the addresses of pointers, which is valuable informa

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66551 >From 31236a70c8d1736563a253dc3a2582366220cb8f Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 16:50:35 -0400 Subject: [PATCH] [lldb-vscode] Show addresses next to dereferenced sum

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66548 >From 3bddb5d5f813d5eac165be1a73b9058f5ee0510d Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 16:41:23 -0400 Subject: [PATCH] [LLDB] Add a setting for print hex variable values wi

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: I've updated the PR following Greg's suggestions. https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: Thanks Jim and Greg! https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9389b05 - [lldb] Fix the TestValueAPI test

Author: walter erquinigo Date: 2023-09-18T13:57:25-04:00 New Revision: 9389b056a604b7da9478bb40125d6a1ad379823a URL: https://github.com/llvm/llvm-project/commit/9389b056a604b7da9478bb40125d6a1ad379823a DIFF: https://github.com/llvm/llvm-project/commit/9389b056a604b7da9478bb40125d6a1ad379823a.di

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

walter-erquinigo wrote: > if it doesn't have a summary and we auto generate one, then we can append the > generated summary string That makes a ton of sense. I'll try that approach. Thanks https://github.com/llvm/llvm-project/pull/66551 ___ lldb-comm

[Lldb-commits] [lldb] 014c41d - [LLDB] Attempt to fix DumpDataExtractorTest

Author: Walter Erquinigo Date: 2023-09-18T21:30:42Z New Revision: 014c41d688f961cdb81cf92e6ba97100a49766a6 URL: https://github.com/llvm/llvm-project/commit/014c41d688f961cdb81cf92e6ba97100a49766a6 DIFF: https://github.com/llvm/llvm-project/commit/014c41d688f961cdb81cf92e6ba97100a49766a6.diff L

[Lldb-commits] [lldb] 266630c - [LLDB] Attempt to fix DumpDataExtractorTest

Author: Walter Erquinigo Date: 2023-09-18T22:02:05Z New Revision: 266630cffceefbe3b00f34ba8efcfba62259335e URL: https://github.com/llvm/llvm-project/commit/266630cffceefbe3b00f34ba8efcfba62259335e DIFF: https://github.com/llvm/llvm-project/commit/266630cffceefbe3b00f34ba8efcfba62259335e.diff L

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: Thanks, man! On Tue, Sep 19, 2023, 4:53 AM David Spickett ***@***.***> wrote: > 9568601 > > > — > Reply to this email directly, view it on GitHub >

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66551 >From 4c9d8d3f5be34d5ffec502a8fa891b603549b2cc Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 16:50:35 -0400 Subject: [PATCH] [lldb-vscode] Use auto summaries when variables have

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

https://github.com/walter-erquinigo approved this pull request. Good catch! I think I have suffered because of this at some point. https://github.com/llvm/llvm-project/pull/66949 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

walter-erquinigo wrote: @jimingham , IIRC from old experiments regarding the synthetic formatter code, `true` is returned when you want to avoid caching the results of the `Update`, which means that if you want to persist the success or the failure, you just return `false`. I might be wrong bu

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

@@ -659,3 +659,16 @@ def test_fs_gs_base(self): pthread_self_val.GetValueAsUnsigned(0), "fs_base does not equal to pthread_self() value.", ) + +def test_process_must_be_stopped(self): +"""Check that all register commands error when th

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

walter-erquinigo wrote: Do you think it would be a good idea to provide aliases for the return values of the Update method with better names that match the behavior you just discovered? I'm not a fan of true/false in this case, because it confuses synthetic type developers, but I'm just trying

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

@@ -659,3 +659,16 @@ def test_fs_gs_base(self): pthread_self_val.GetValueAsUnsigned(0), "fs_base does not equal to pthread_self() value.", ) + +def test_process_must_be_stopped(self): +"""Check that all register commands error when th

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: walter-erquinigo wrote: Btw, I'm building support for the mojo language, and very likely the `main` method will not have the symbol `main`, so building an abstraction around this, for every language, would be very convenient. https://githu

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/67165 This prevents undefined vtable errors when linking these libraries from out-of-tree. I'm facing this issue as I work on my new language plugin. >From 68818ce0376ba717157edaffd5ae2101cf26d4e2 Mon Sep 17

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/67165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/67165 >From 0f7b275c5fa608dce8b345c81794514abda017f3 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 22 Sep 2023 12:29:46 -0400 Subject: [PATCH] [lldb][NFC] Move some ctors and tors to cpp files Th

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/67165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: walter-erquinigo wrote: That's file. You can have multiple commits in the same PR, because when it gets approved and merged, github will squash all your commits into a single one. https://github.com/llvm/llvm-project/pull/67019

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

https://github.com/walter-erquinigo approved this pull request. Other than a few nits, this is awesome! https://github.com/llvm/llvm-project/pull/67628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/67628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

@@ -0,0 +1,100 @@ +"""A tool for extracting a list of private lldb symbols to export for MSVC. + +When exporting symbols from a dll or exe we either need to mark the symbols in +the source code as __declspec(dllexport) or supply a list of symbols to the +linker. Private symbols in

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

@@ -0,0 +1,100 @@ +"""A tool for extracting a list of private lldb symbols to export for MSVC. + +When exporting symbols from a dll or exe we either need to mark the symbols in +the source code as __declspec(dllexport) or supply a list of symbols to the +linker. Private symbols in

[Lldb-commits] [lldb] [lldb][dap] Avoid concurrent `HandleCommand` calls (PR #83162)

https://github.com/walter-erquinigo approved this pull request. This is amazing! That finally explains some flakes I've seen https://github.com/llvm/llvm-project/pull/83162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [LLDB] Fix completion of space-only lines in the REPL on Linux (PR #83203)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/83203 https://github.com/modularml/mojo/issues/1796 discovered that if you try to complete a space-only line in the REPL on Linux, LLDB crashes. I suspect that editline doesn't behave the same way on linux an

[Lldb-commits] [lldb] [LLDB] Fix completion of space-only lines in the REPL on Linux (PR #83203)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/83203 >From 3410fc7e0e9d73763e3edee6e008012ba571ad80 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Tue, 27 Feb 2024 17:59:20 -0500 Subject: [PATCH] [LLDB] Fix completion of space-only lines in the REPL

[Lldb-commits] [lldb] [LLDB] Fix completion of space-only lines in the REPL on Linux (PR #83203)

walter-erquinigo wrote: @DavidSpickett I was able to write a test for this. PTAL :) https://github.com/llvm/llvm-project/pull/83203 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix completion of space-only lines in the REPL on Linux (PR #83203)

@@ -54,3 +55,16 @@ def test_basic_completion(self): self.expect_repl("$persistent + 10", substrs=["(long) $2 = 17"]) self.quit() + +# PExpect uses many timeouts internally and doesn't play well +# under ASAN on a loaded machine.. +@skipIfAsan +@

[Lldb-commits] [lldb] [LLDB] Fix completion of space-only lines in the REPL on Linux (PR #83203)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/83203 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

https://github.com/walter-erquinigo requested changes to this pull request. could you create instead a variable at the base test class level that can be used by other DAP tests when setting timeouts? I'm pretty sure at least one other test file uses timeouts. https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/83312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/83312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

https://github.com/walter-erquinigo approved this pull request. Other than a missing comment, this LGTM. Thanks! https://github.com/llvm/llvm-project/pull/83312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] Increase timeout to reduce test failure rate. (PR #83312)

@@ -6,6 +6,7 @@ class DAPTestCaseBase(TestBase): +timeoutval = 10 * (10 if ('ASAN_OPTIONS' in os.environ) else 1) walter-erquinigo wrote: Please add a comment here mentioning what the purpose of this variable is https://github.com/llvm/llvm-project/pull

[Lldb-commits] [lldb] Change GetNumChildren()/CalculateNumChildren() methods return llvm::Expected (PR #84219)

@@ -451,8 +451,13 @@ bool FormatManager::ShouldPrintAsOneLiner(ValueObject &valobj) { if (valobj.GetSummaryFormat().get() != nullptr) return valobj.GetSummaryFormat()->IsOneLiner(); + auto num_children = valobj.GetNumChildren(); + if (!num_children) { +llvm::consu

[Lldb-commits] [lldb] Change GetNumChildren()/CalculateNumChildren() methods return llvm::Expected (PR #84219)

@@ -1397,7 +1398,9 @@ ValueObjectSP GetValueForOffset(StackFrame &frame, ValueObjectSP &parent, return parent; } - for (int ci = 0, ce = parent->GetNumChildren(); ci != ce; ++ci) { + for (int ci = 0, ce = llvm::expectedToStdOptional(parent->GetNumChildren()) -

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

@@ -0,0 +1,66 @@ +""" +Test lldb-dap stepInTargets request +""" + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +import lldbdap_testcase +from lldbsuite.test import lldbutil + + +class TestDAP_stepInTargets(lldbdap_testcase.DAPT

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

@@ -3180,14 +3180,159 @@ void request_stepIn(const llvm::json::Object &request) { llvm::json::Object response; FillResponse(request, response); auto arguments = request.getObject("arguments"); + + std::string step_in_target; + uint64_t target_id = GetUnsigned(arguments

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

@@ -3180,14 +3180,159 @@ void request_stepIn(const llvm::json::Object &request) { llvm::json::Object response; FillResponse(request, response); auto arguments = request.getObject("arguments"); + + std::string step_in_target; + uint64_t target_id = GetUnsigned(arguments

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

@@ -3180,14 +3180,159 @@ void request_stepIn(const llvm::json::Object &request) { llvm::json::Object response; FillResponse(request, response); auto arguments = request.getObject("arguments"); + + std::string step_in_target; + uint64_t target_id = GetUnsigned(arguments

[Lldb-commits] [lldb] [lldb][lldb-dap] Cleanup breakpoint filters. (PR #87550)

@@ -36,9 +36,7 @@ DAP::DAP() {{"cpp_catch", "C++ Catch", lldb::eLanguageTypeC_plus_plus}, {"cpp_throw", "C++ Throw", lldb::eLanguageTypeC_plus_plus}, {"objc_catch", "Objective-C Catch", lldb::eLanguageTypeObjC}, - {"objc_throw", "Object

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

walter-erquinigo wrote: Yep, please write a python test. A possible idea is to have a target that does nothing for 10 seconds, during which you kill the debug server (lldb-server or debugserver) and then you assert on the final message sent by lldb-vscode. https://github.com/llvm/llvm-project/

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/89405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

https://github.com/walter-erquinigo requested changes to this pull request. https://github.com/llvm/llvm-project/pull/89405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

@@ -104,3 +127,27 @@ def test_empty_escape_prefix(self): "Help can be invoked", command_escape_prefix="", ) + +@skipIfWindows +@skipIfRemote +def test_exit_status_message(self): +source = "main.cpp" +program = self.get

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

@@ -4,10 +4,30 @@ import dap_server import lldbdap_testcase +import psutil +from collections import deque from lldbsuite.test import lldbutil from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * +def get_subprocess_pid(process_name): +queue =

<    1   2   3   4   5   6   7   8   9   10   >