tberghammer created this revision.
tberghammer added reviewers: labath, granata.enrico.
tberghammer added a subscriber: lldb-commits.
Add data formatter for libstdc++ shared_ptr and weak_ptr
http://reviews.llvm.org/D21984
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/da
tberghammer updated this revision to Diff 62730.
tberghammer added a comment.
Apply clang-format
http://reviews.llvm.org/D21984
Files:
include/lldb/DataFormatters/VectorIterator.h
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/Makefile
tberghammer added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:665
@@ +664,3 @@
+
+stl_summary_flags.SetDontShowChildren(true);
+AddCXXSummary(cpp_category_sp,
lldb_private::formatters::LibStdcppSmartPointerSummaryProvider,
tberghammer added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:665
@@ +664,3 @@
+
+stl_summary_flags.SetDontShowChildren(true);
+AddCXXSummary(cpp_category_sp,
lldb_private::formatters::LibStdcppSmartPointerSummaryProvider,
Author: tberghammer
Date: Wed Jul 6 04:50:00 2016
New Revision: 274617
URL: http://llvm.org/viewvc/llvm-project?rev=274617&view=rev
Log:
Add data formatter for libstdc++ shared_ptr and weak_ptr
Differential revision: http://reviews.llvm.org/D21984
Added:
lldb/trunk/packages/Python/lldbsuit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274617: Add data formatter for libstdc++ shared_ptr and
weak_ptr (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D21984?vs=62730&id=62838#toc
Repository:
rL LLVM
http://r
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good. You might want to print the errno a bit better but I am fine with
the current implementation as well.
http://reviews.llvm.org/D22039
_
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D22029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
tberghammer created this revision.
tberghammer added reviewers: labath, ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Add oat symbolization support for odex files
http://reviews.llvm.org/D22040
Files:
source/Plugins/ObjectFile
Author: tberghammer
Date: Wed Jul 6 11:40:09 2016
New Revision: 274635
URL: http://llvm.org/viewvc/llvm-project?rev=274635&view=rev
Log:
Add oat symbolization support for odex files
Differential revision: http://reviews.llvm.org/D22040
Modified:
lldb/trunk/source/Plugins/ObjectFile/ELF/Obje
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274635: Add oat symbolization support for odex files
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D22040?vs=62851&id=62895#toc
Repository:
rL LLVM
http://reviews.llvm.
Author: tberghammer
Date: Thu Jul 7 05:38:05 2016
New Revision: 274743
URL: http://llvm.org/viewvc/llvm-project?rev=274743&view=rev
Log:
Try to fix the OSX build with old SDK after r274725
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm
Modified: lldb/trunk/tools/debugse
Hi Jason,
This CL caused a build failure on our OSX build bot:
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/11405/steps/ninja%20build%20local/logs/stdio
I committed in a possible fix at http://reviews.llvm.org/rL274743 but
please take a look as I don't know too much about this
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Change the /proc//maps to not assert on incorrect input
If LLDB reads some incorrect input form /proc//maps then it
should report an error instead of assert-ing as we don't want
Author: tberghammer
Date: Mon Jul 11 08:43:27 2016
New Revision: 275060
URL: http://llvm.org/viewvc/llvm-project?rev=275060&view=rev
Log:
Change the /proc//maps to not assert on incorrect input
If LLDB reads some incorrect input form /proc//maps then it
should report an error instead of assert-in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275060: Change the /proc//maps to not assert on
incorrect input (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D22211?vs=63485&id=63503#toc
Repository:
rL LLVM
http://re
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Support loading files even when incorrect file name specified by the linker
"Incorrect" file name seen on Android whene
tberghammer updated this revision to Diff 63664.
tberghammer added a comment.
Add SBMemoryRegionInfo::GetName
http://reviews.llvm.org/D22219
Files:
docs/lldb-gdb-remote.txt
include/lldb/API/SBMemoryRegionInfo.h
include/lldb/Target/MemoryRegionInfo.h
packages/Python/lldbsuite/test/tools/
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
https://reviews.llvm.org/D22357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with 2 minor comments
Comment at: source/Host/linux/ProcessLauncherLinux.cpp:28-29
@@ +27,4 @@
+
+// If there is no PATH variable specified inside the env
Author: tberghammer
Date: Fri Jul 22 05:43:03 2016
New Revision: 276403
URL: http://llvm.org/viewvc/llvm-project?rev=276403&view=rev
Log:
Fix a crash when an ELF section symbol have no name
Modified:
lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
Modified: lldb/trunk/source/Plugi
Author: tberghammer
Date: Fri Jul 22 07:55:35 2016
New Revision: 276411
URL: http://llvm.org/viewvc/llvm-project?rev=276411&view=rev
Log:
Support loading files even when incorrect file name specified by the linker
"Incorrect" file name seen on Android whene the main executable is
called "app_proc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276411: Support loading files even when incorrect file name
specified by the linker (authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D22219?vs=63664&id=65064#toc
Repository:
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
I think it is a bad idea to duplicate the CheckAtomic.cmake file from LLVM as
the 2 copy will diverge over time and cause extra maintenance cost. What do you
think about trying to change LLVM to install this file instead o
tberghammer added a comment.
Pavel is OOO this week but the change looks good.
One request: Can you move the following part out of the android specific part
as well?
ifdef PIE
LDFLAGS += -pie
endif
It will make no difference at the moment but will make the code more generic
and also
tberghammer added a subscriber: tberghammer.
tberghammer accepted this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
Do you want me to commit it in for you?
https://reviews.llvm.org/D22132
___
lldb-commits mailing
Author: tberghammer
Date: Tue Aug 2 06:15:55 2016
New Revision: 277443
URL: http://llvm.org/viewvc/llvm-project?rev=277443&view=rev
Log:
Support for OCaml native debugging
This introduces basic support for debugging OCaml binaries.
Use of the native compiler with DWARF emission support (see
http
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277443: Support for OCaml native debugging (authored by
tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D22132?vs=64473&id=66456#toc
Repository:
rL LLVM
https://reviews.llvm.org/D221
Author: tberghammer
Date: Fri Aug 12 09:17:05 2016
New Revision: 278510
URL: http://llvm.org/viewvc/llvm-project?rev=278510&view=rev
Log:
Skip 2 android test what is broken because of debuggerd
debuggerd is a crash reporting system on android what installs some
signal handler for SEGV to print a
tberghammer created this revision.
tberghammer added reviewers: jingham, zturner.
tberghammer added a subscriber: lldb-commits.
Remove mention of autoconf from the build instructions
autoconf+make have been removed from LLVM and LLDB ~6month ago. We shouldn't
advertise it on the website as a val
Author: tberghammer
Date: Tue Aug 30 10:32:52 2016
New Revision: 280102
URL: http://llvm.org/viewvc/llvm-project?rev=280102&view=rev
Log:
Remove mention of autoconf from the build instructions
autoconf+make have been removed from LLVM and LLDB ~6month ago. We
shouldn't advertise it on the website
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280102: Remove mention of autoconf from the build
instructions (authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D24025?vs=69668&id=69701#toc
Repository:
rL LLVM
https://r
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
Comment at:
source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:13-14
@@ +12,4 @@
+
+// Project includes
+#include "AuxVector.h"
+
---
Author: tberghammer
Date: Fri Sep 2 10:52:19 2016
New Revision: 280490
URL: http://llvm.org/viewvc/llvm-project?rev=280490&view=rev
Log:
Fix 2 waring in the OCaml AST context
Modified:
lldb/trunk/include/lldb/Symbol/OCamlASTContext.h
lldb/trunk/source/Symbol/OCamlASTContext.cpp
Modified
Author: tberghammer
Date: Fri Sep 2 10:56:33 2016
New Revision: 280492
URL: http://llvm.org/viewvc/llvm-project?rev=280492&view=rev
Log:
Fix build breakage caused by r280490
Modified:
lldb/trunk/source/Symbol/OCamlASTContext.cpp
Modified: lldb/trunk/source/Symbol/OCamlASTContext.cpp
URL:
h
Author: tberghammer
Date: Tue Sep 13 04:27:21 2016
New Revision: 281309
URL: http://llvm.org/viewvc/llvm-project?rev=281309&view=rev
Log:
Fix linux build after rL281273
Modified:
lldb/trunk/source/Core/StructuredData.cpp
Modified: lldb/trunk/source/Core/StructuredData.cpp
URL:
http://llvm.o
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Add support for DW_AT_ranges_base attribute
It is a new attribute emitted by clang as a GNU extension and will
be part of Dwarf5. The purpose of the attribute is to spec
tberghammer updated this revision to Diff 71316.
tberghammer added a comment.
Adding a new test case
https://reviews.llvm.org/D24514
Files:
packages/Python/lldbsuite/test/python_api/symbol-context/two-files/TestSymbolContextTwoFiles.py
packages/Python/lldbsuite/test/python_api/symbol-conte
Author: tberghammer
Date: Thu Sep 15 03:47:59 2016
New Revision: 281594
URL: http://llvm.org/viewvc/llvm-project?rev=281594&view=rev
Log:
Try to fix windows build after rL281569
Modified:
lldb/trunk/include/lldb/Breakpoint/BreakpointOptions.h
lldb/trunk/include/lldb/Breakpoint/BreakpointR
Author: tberghammer
Date: Thu Sep 15 03:53:33 2016
New Revision: 281595
URL: http://llvm.org/viewvc/llvm-project?rev=281595&view=rev
Log:
Add support for DW_AT_ranges_base attribute
It is a new attribute emitted by clang as a GNU extension and will
be part of Dwarf5. The purpose of the attribute
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281595: Add support for DW_AT_ranges_base attribute
(authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D24514?vs=71316&id=71484#toc
Repository:
rL LLVM
https://reviews.llvm
Author: tberghammer
Date: Thu Sep 15 05:49:55 2016
New Revision: 281601
URL: http://llvm.org/viewvc/llvm-project?rev=281601&view=rev
Log:
Fix TestSymbolContextTwoFiles on Android after rL281595
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api/symbol-context/two-files/TestSymbol
Author: tberghammer
Date: Tue Oct 4 13:35:39 2016
New Revision: 283237
URL: http://llvm.org/viewvc/llvm-project?rev=283237&view=rev
Log:
Fix FixupEnvironment on Android after the Args refactor
Modified:
lldb/trunk/source/Host/linux/ProcessLauncherLinux.cpp
Modified: lldb/trunk/source/Host/l
Author: tberghammer
Date: Tue Oct 4 16:32:46 2016
New Revision: 283262
URL: http://llvm.org/viewvc/llvm-project?rev=283262&view=rev
Log:
Fix the decorator of TestBreakpointCaseSensitivity
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitiv
tberghammer added a comment.
I don't know what correction you are referring to as I haven't made any change
in JSON.{h,cpp} since you created this patch but I am happy with the current
situation (no warning on clang)
http://reviews.llvm.org/D15355
___
tberghammer added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:518
@@ +517,3 @@
+if hasattr(func, "categories"):
+cat.extend(func.categories)
+func.categories = cat
tfiala wrote:
> This code could potentially
tberghammer added inline comments.
Comment at:
packages/Python/lldbsuite/test/lang/cpp/limit-debug-info/TestWithLimitDebugInfo.py:9
@@ -8,4 +8,3 @@
-@dwarf_test
-def test_with_dwarf(self):
-self.buildDwarf()
+@skipIf(debug_info=not_in(["dwarf"]))
+def te
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.cpp:38-41
@@ +37,6 @@
+
+if (flags & OPCODE_OPERANDS_TABLE_MASK)
+{
+OperandTable::ReadOperandTable(debug_macro_data, offset,
&header.m_operand_table);
+}
+
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: include/lldb/Utility/JSON.h:148
@@ -147,3 +147,3 @@
-uint64_t
+int64_t
GetAsSigned() const;
Nice catch!
tberghammer added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:518
@@ +517,3 @@
+if hasattr(func, "categories"):
+cat.extend(func.categories)
+func.categories = cat
labath wrote:
> tberghammer wrote:
> > tfial
tberghammer created this revision.
tberghammer added reviewers: labath, zturner.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Merge ENABLE_THREADS and ENABLE_STD_THREADS markers
Both of these markers are used in the test suit for annotating when
Hi Zachary,
This change broke TestLimitDebugInfo with the following error
message(copied from the Linux buildbot):
==
ERROR: test_limit_debug_info_dwarf
(TestWithLimitDebugInfo.TestWithLimitDebugInfo)
-
I think the problem is that you don't make a copy of the category variable
manually. The function you are creating capture category by reference and
when you update the value of category in the next loop iteration you also
update the value captured by the previous function. As a result all of your
tberghammer accepted this revision.
tberghammer added a comment.
LGTM
http://reviews.llvm.org/D15437
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255641: Merge ENABLE_THREADS and ENABLE_STD_THREADS markers
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15498?vs=42725&id=42832#toc
Repository:
rL LLVM
http://review
Author: tberghammer
Date: Tue Dec 15 06:11:00 2015
New Revision: 255641
URL: http://llvm.org/viewvc/llvm-project?rev=255641&view=rev
Log:
Merge ENABLE_THREADS and ENABLE_STD_THREADS markers
Both of these markers are used in the test suit for annotating when a
test needs multi threaded support. Pr
tberghammer created this revision.
tberghammer added reviewers: omjavaid, ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
Make the aarch64 lldb-server capable of debugging arm32 applications
After this change an
tberghammer updated this revision to Diff 42986.
tberghammer marked 2 inline comments as done.
http://reviews.llvm.org/D15533
Files:
source/Host/common/HostInfoBase.cpp
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
source/Plugins/Process/Linux/NativeRegisterContextLinux_ar
tberghammer added a comment.
Note: This change is blocked by http://reviews.llvm.org/D15529. If that one
will get rejected then we have to move some of the 32 <-> 64 architecture
matching code into LLDB.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.c
tberghammer updated this revision to Diff 42987.
tberghammer added a comment.
Fix type
http://reviews.llvm.org/D15533
Files:
source/Host/common/HostInfoBase.cpp
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h
tberghammer marked an inline comment as done.
tberghammer added a comment.
http://reviews.llvm.org/D15533
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tberghammer
Date: Thu Dec 17 04:58:35 2015
New Revision: 255885
URL: http://llvm.org/viewvc/llvm-project?rev=255885&view=rev
Log:
XFAIL some tests failing for Windows -> Android
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/macros/TestMacros.py
lldb/trun
tberghammer accepted this revision.
tberghammer added a comment.
LGTM (next time please upload the diff with full context)
Repository:
rL LLVM
http://reviews.llvm.org/D15576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
tberghammer added a comment.
I don't fully understand how the ptrace API works in the aarch64 Linux kernel
but based on my experiments the arm specific ptrace calls aren't working
(returning -EIO for a reason unknown to me at the moment). Because of this, the
current watchpoint implementation i
Author: tberghammer
Date: Fri Dec 18 09:35:08 2015
New Revision: 256000
URL: http://llvm.org/viewvc/llvm-project?rev=256000&view=rev
Log:
Fix the emulation of arm strd instruction
The incorrect instruction emulation caused issues in the stack unwinding
code when strd was used to push 2 register t
Author: tberghammer
Date: Mon Dec 21 06:06:36 2015
New Revision: 256147
URL: http://llvm.org/viewvc/llvm-project?rev=256147&view=rev
Log:
Fix emulation of the thumb str instruction
Modified:
lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
Modified: lldb/trunk/source/Plugi
tberghammer created this revision.
tberghammer added reviewers: tfiala, endlessroad, loladiro.
tberghammer added a subscriber: lldb-commits.
Don't pack the structs of the jit debug interface
None of the documentation mentions that the entries are packed structs and also
none of the other impleme
tberghammer added a comment.
I hit the problem when debugging an arm32 target from an x86_64 host and this
CL fixes that issue. It will break if a 32bit target use the same "pragma pack"
attribute I just removed.
The change have no effect for 64bit targets because symfile_size will be 8 byte
a
Author: tberghammer
Date: Tue Dec 22 09:23:33 2015
New Revision: 256244
URL: http://llvm.org/viewvc/llvm-project?rev=256244&view=rev
Log:
Don't pack the structs of the jit debug interface
None of the documentation mentions that the entries are packed structs
and also none of the other implementat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256244: Don't pack the structs of the jit debug interface
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15715?vs=43444&id=43445#toc
Repository:
rL LLVM
http://reviews.
tberghammer added a subscriber: tberghammer.
tberghammer requested changes to this revision.
tberghammer added a reviewer: tberghammer.
This revision now requires changes to proceed.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2549-2550
@@ -2548,6 +2548,4 @@
tberghammer added a comment.
LGTM
I can't accept it on the UI because of some bug, but you can commit it without
waiting for Greg.
Repository:
rL LLVM
http://reviews.llvm.org/D15738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
tberghammer accepted this revision.
tberghammer added a comment.
Looks good but please fix the indentation to match with the LLDB style (4 space)
http://reviews.llvm.org/D15877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1391
@@ -1390,3 +1390,3 @@
if (m_thread.GetProcess()->GetArchitec
tberghammer added a comment.
@omjavaid: What is your opinion about submitting this patch in its current form
with knowing that setting watchpoints from a 64bit lldb-server into 32bit
inferior will fail?
I think this patch is a step in the good direction to make a 64bit lldb-server
capable of d
Author: tberghammer
Date: Mon Jan 11 04:39:09 2016
New Revision: 257322
URL: http://llvm.org/viewvc/llvm-project?rev=257322&view=rev
Log:
Make the aarch64 lldb-server capable of debugging arm32 applications
Differential revision: http://reviews.llvm.org/D15533
Modified:
lldb/trunk/source/Hos
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257322: Make the aarch64 lldb-server capable of debugging
arm32 applications (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15533?vs=42987&id=44454#toc
Repository:
rL LL
Author: tberghammer
Date: Mon Jan 11 08:56:05 2016
New Revision: 257335
URL: http://llvm.org/viewvc/llvm-project?rev=257335&view=rev
Log:
Don't try to parse the line table when it isn't specified
Previously we tried to parse the line table even if a compile unit
had no DW_AT_stmt_list atribute. T
Author: tberghammer
Date: Tue Jan 12 04:41:43 2016
New Revision: 257469
URL: http://llvm.org/viewvc/llvm-project?rev=257469&view=rev
Log:
Try to fix the mips64 build after rL257447
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
Modified:
lldb/trunk/
tberghammer added a comment.
Can we calculate the size of the object file based on elf headers and the
section headers instead of using the /proc file system?
I think a good algorithm would be to take the maximum of the following 2
expression:
Start of section header + Number of section head
tberghammer added a comment.
Based on your description the vdso file itself looks like a valid elf file to
me. If the ObjectFileELF plugin is buggy (it is certainly is as it can't handle
the vdso) then I think we should fix that instead of building up a new approach
just to work around one of o
Author: tberghammer
Date: Wed Jan 13 08:58:48 2016
New Revision: 257603
URL: http://llvm.org/viewvc/llvm-project?rev=257603&view=rev
Log:
Silence an incorrect dwarf parsing warning
We have a check what warns if the offset of a class member is greater
then or equal to the size of the class. The wa
Author: tberghammer
Date: Thu Jan 14 04:56:56 2016
New Revision: 257755
URL: http://llvm.org/viewvc/llvm-project?rev=257755&view=rev
Log:
XFAIL TestCommandScriptImmediateOutput on Linux
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCo
I XFAIL-ed the test for Linux to get the build bot green again and filed a
bug at https://llvm.org/bugs/show_bug.cgi?id=26139
On Thu, Jan 14, 2016 at 2:18 AM Ying Chen via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Please see attached log file.
>
> Thanks,
> Ying
>
> On Wed, Jan 13, 201
Author: tberghammer
Date: Thu Jan 14 06:49:48 2016
New Revision: 257761
URL: http://llvm.org/viewvc/llvm-project?rev=257761&view=rev
Log:
Update some XFAILs after the 3.8->3.9 version change
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_locations/T
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Unconditionally accept symbol sizes from .dynsym
If an elf object file have no .symtab section then we create our symtab
representation based on the .dynsym section. The symtab
tberghammer added a comment.
Yes it will prevent the artificial size calculation for symbols with 0 size in
.dynsym. I think all function and data symbols should have a valid size so I am
not sure why we have this symbol size calculation in the first place but I
assume it is to work around some
tberghammer added a comment.
I looked through the sections we have in a striped elf file and non of them
have any information what would tell us the start address of the functions (it
isn't needed in runtime so it is removed to decrease the size).
Relocations won't really help because they will
tberghammer retitled this revision from "Unconditionally accept symbol sizes
from .dynsym" to "Unconditionally accept symbol sizes from elf".
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 44981.
tberghammer added a comment.
I disabled the symbol size
tberghammer added inline comments.
Comment at: source/Symbol/Symtab.cpp:974-978
@@ -973,5 +973,7 @@
Symbol &symbol = m_symbols[entry.data];
-
-symbol.SetByteSize(end_section_file_addr -
symbol_file_addr);
-s
Author: tberghammer
Date: Mon Jan 18 04:38:34 2016
New Revision: 258040
URL: http://llvm.org/viewvc/llvm-project?rev=258040&view=rev
Log:
Unconditionally accept symbol sizes from elf
The ELF symbol table always contain the size of the symbols so we
don't have to try to guess them based on the add
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258040: Unconditionally accept symbol sizes from elf
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16186?vs=44981&id=45160#toc
Repository:
rL LLVM
http://reviews.llvm.
Author: tberghammer
Date: Mon Jan 18 05:49:18 2016
New Revision: 258043
URL: http://llvm.org/viewvc/llvm-project?rev=258043&view=rev
Log:
Revert "Unconditionally accept symbol sizes from elf"
It causes issues for i386 when compiling with gcc-4.9.2
This reverts commit e248214a3eab8e244095f97d1996
Author: tberghammer
Date: Tue Jan 19 04:24:51 2016
New Revision: 258113
URL: http://llvm.org/viewvc/llvm-project?rev=258113&view=rev
Log:
Unconditionally accept symbol sizes from elf
The ELF symbol table always contain the size of the symbols so we
don't have to try to guess them based on the add
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D16107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
In http://reviews.llvm.org/D16334#331318, @zturner wrote:
> FWIW, I think Adrian's original point is that testing the behavior of signed
> types shouldn't depend on step over functionality. It's good practice in
> genera
I think to get a very good coverage for the basic functionalities we need
some sort of stress testing or fuzzing infrastructure because the most
issues I hit come from compilers generating something a bit different then
we are expecting. For stack unwinding I added a stress test
(TestStandardUnwind
tberghammer added a comment.
I think to get a very good coverage for the basic functionalities we need
some sort of stress testing or fuzzing infrastructure because the most
issues I hit come from compilers generating something a bit different then
we are expecting. For stack unwinding I added a s
tberghammer added a comment.
In http://reviews.llvm.org/D16334#331368, @zturner wrote:
> I don't know, I still disagree. If something in step-over breaks, I dont'
> want to dig through a list of 30 other tests that have nothing to do with the
> problem, only to find out 2 days later that the p
the_signed_long_long = 99"])
>> File
>> "D:\src\llvm\tools\lldb\packages\Python\lldbsuite\test\lldbtest.py", line
>> 2701, in expect
>> msg if msg else EXP_MSG(str, exe))
>> AssertionError: False is not True : Variable(s) displayed correctly
>> C
301 - 400 of 725 matches
Mail list logo
