[Lldb-commits] [PATCH] D131795: [LLDB] Fix the 'default' switch case in GetCompatibleArchs()

fixathon planned changes to this revision. fixathon added inline comments. Comment at: lldb/test/API/functionalities/gdb_remote_client/TestPlatformMacOSX.py:22 def qHostInfo(self): -return "cputype:16777223;cpusubtype:2;ostype:%s;vendor:apple;os_version:10.

[Lldb-commits] [PATCH] D131850: [LLDB][NFC] Reliability Fixes for FormatEntity

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa5124327a01: [LLDB][NFC] Reliability Fixes for FormatEntity (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131850/new/ https://revie

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon planned changes to this revision. fixathon marked 2 inline comments as done. fixathon added a comment. I am going to clean up the code in the entire file where **raw pointers** should be **shared_ptr** (because they get cast to shared_ptr anyways). Also planning to convert the **naked n

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon updated this revision to Diff 452809. fixathon marked an inline comment as done. fixathon added a comment. Convert raw pointers to shared_ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/ https://reviews.llvm.org/D131900 Files

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon updated this revision to Diff 452884. fixathon added a comment. Address the style issue by removing "using", and specifying std:: namespace explicitly. Note, lldb style guide does not appear to prohibit the import of individual members from another namespace in a non-header file. Never

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon marked an inline comment as done. fixathon added a comment. All pending suggestions have been resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/ https://reviews.llvm.org/D131900

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon published this revision for review. fixathon added inline comments. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. =

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon updated this revision to Diff 453109. fixathon added a comment. Address comments about passing-by-ref for perf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/ https://reviews.llvm.org/D131900 Files: lldb/source/Plugins/Instrum

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fe72001e8d6: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

This revision was automatically updated to reflect the committed changes. fixathon marked 3 inline comments as done. Closed by commit rG461b41015942: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

fixathon created this revision. fixathon added a reviewer: clayborg. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, a

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

fixathon added a comment. In D131998#3727664 , @clayborg wrote: > Can we use C++ comments instead of C comments? We can, and I'll make the change. Do you think it would be a good idea to keep the coverity annotations only as C-style comments (comments f

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

fixathon reopened this revision. fixathon marked an inline comment as done. fixathon added a comment. This revision is now accepted and ready to land. Thank you, @stella.stamenova , will investigate. Added comments with the initial findings Comment at: lldb/source/Commands/Com

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

fixathon updated this revision to Diff 453348. fixathon added a comment. Change to C++ style comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131998/new/ https://reviews.llvm.org/D131998 Files: lldb/include/lldb/Core/ThreadSafeValue.h ll

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

fixathon planned changes to this revision. fixathon marked 2 inline comments as done. fixathon added a comment. Planning to undo checking the return value of FindLineEntryByAddress() since it's causing an issue on some platform, and re-evaluate the underlying issue. Comment at

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

fixathon updated this revision to Diff 453392. fixathon marked an inline comment as done. fixathon added a comment. This revision is now accepted and ready to land. Back out changes for checking the return val of the function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG163319070947: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread (authored by fixathon). Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a197772ee30: [LLDB][NFC] Suppress spurious static inspection warnings (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131998/new/ htt

[Lldb-commits] [PATCH] D149224: Fix an off-by-one error with armv7 mach-o corefile register contexts (LC_THREADs)

fixathon accepted this revision. fixathon added a comment. This revision is now accepted and ready to land. Great catch. Thank you for finding and fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149224/new/ https://reviews.llvm.org/D1492

[Lldb-commits] [PATCH] D132841: [lldb] Use the NativeSock type instead of plain 'int'

fixathon accepted this revision. fixathon added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132841/new/ https://reviews.llvm.org/D132841 __

<    1   2