[Lldb-commits] [PATCH] D102811: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c0b0de904a5: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from… (authored by xiaobai). Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

sven added a comment. @luismarques I have tried the patch with llvm12, test case is provide by jade(https://gist.github.com/e2efac2f780ed820277dbaf608805f4e), but it didn't worked for me. After execute 'gdb-remote 1234', the terminal shows: Process 1 stopped * Thread #1, stop reason = sign

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

sven added a comment. In D62732#2790087 , @luismarques wrote: > In D62732#2790028 , @luismarques > wrote: > >> That's surprising. I'll see if I can figure out what the issue might be. >> Thanks. > > Confirmed. Som

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

jade added a comment. In D62732#2789409 , @sven wrote: > It seems that the unwind didn't succeed, can you figure out the problem? > my qemu vesion: 4.2.1 > Thanks. Unfortunately, from my last adventures through the lldb codebase in debugging that (see bu

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Abpostelnicu added a comment. I think there is a false positive with this @george.burgess.iv: In [this)(https://searchfox.org/mozilla-central/source/mozglue/baseprofiler/core/platform-linux-android.cpp#222-227) we have the warning triggered: mozglue/baseprofiler/core/platform-linux-android.cpp:

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Abpostelnicu added a comment. In D100581#2798079 , @raj.khem wrote: > http://sprunge.us/FJzZXL is a file from harfbuzz and it warns > > a.cc:28670:32: error: variable 'supp_size' set but not used > [-Werror,-Wunused-but-set-variable] > unsigned i

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm created this revision. asm added reviewers: clayborg, wallace. Herald added subscribers: pengfei, JDevlieghere. asm requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Rust's v0 name mangling scheme [1] is easy to disambiguate from other na

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm added inline comments. Comment at: lldb/unittests/Core/MangledTest.cpp:72 + + EXPECT_STREQ("", TheDemangled.GetCString()); +} teemperor wrote: > Could you do me a favour and change your test functions to LLDB's code style, > so `mangled_name` as a variable

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm updated this revision to Diff 351481. asm marked an inline comment as done. asm added a comment. code style fixes, use modern log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 Files: lldb/include/

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm added a comment. And thank you for the quick review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid created this revision. nealsid added a reviewer: LLDB. nealsid requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This small patch adds a test for functions & lldb commands with unicode characters in them. Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid updated this revision to Diff 352612. nealsid added a comment. Herald added a subscriber: JDevlieghere. Add newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104437/new/ https://reviews.llvm.org/D104437 Files: lldb/test/Shell/Breakp

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid added a comment. Ah, my grep/find skills clearly failed me :) Yeah, those tests are exactly the same scenarios. However, if I understand correctly, don't they use the API? I wanted to add some coverage for the shell because I'm making changes to the Editline wrapper, and the existing t

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm added a comment. @teemperor @clayborg Is this good to go? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid added a comment. Thanks to both of you for this! I’m traveling for a few days but will be able to take a look towards the end of the week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104437/new/ https://reviews.llvm.org/D104437

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

serge-sans-paille created this revision. serge-sans-paille requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. According to the manpage The gethostbyname*() and gethostbyaddr*() functions are obsolete. Applications should use getaddrinfo(3

[Lldb-commits] [PATCH] D104856: [NFC] Remove unreferenced function ResolveIPV4HostName

serge-sans-paille updated this revision to Diff 354443. serge-sans-paille retitled this revision from "[lldb] replace gethostbyname call by getaddrinfo" to "[NFC] Remove unreferenced function ResolveIPV4HostName". serge-sans-paille edited the summary of this revision. serge-sans-paille added a co

[Lldb-commits] [PATCH] D104856: [NFC] Remove unreferenced function ResolveIPV4HostName

serge-sans-paille added a comment. What a simpler patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104856/new/ https://reviews.llvm.org/D104856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [PATCH] D104856: [NFC] Remove unreferenced function ResolveIPV4HostName

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7b1fa6f5ebe: [NFC] remove unreferenced function ResolveIPV4HostName (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104856/ne

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid added a comment. Agreed, it looks like there's plenty of test coverage for this scenario, so I'll revert this patch - sorry about that. I'm working on removing the wchar/char preprocessor logic in Editline.cpp so I'll verify the existing coverage before sending that for review. Thanks

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid abandoned this revision. nealsid added a comment. Not needed with existing test coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104437/new/ https://reviews.llvm.org/D104437 ___ lldb-commi

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

kasper81 added a comment. Hi, I have my fingers crossed since this request was opened in 2019. It seems like it compiles and usable to certain degree. Can this patch be merged and included in llvm 13 as initial riscv64 support? We can then improve it subsequently if bugs show up. Otherwise it w

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

kasper81 added a comment. > I think the main blocker for merging was testing. If it helps, I now have the > RISC-V server in my hands and I should be able to set up a buildbot soon. It certainly will help. Thank you! :) On July 27, 13.x will be branched out. If we can squeeze it in that would b

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid created this revision. nealsid added a reviewer: LLDB. nealsid added a project: LLDB. Herald added subscribers: JDevlieghere, mgorny. nealsid requested review of this revision. Herald added a subscriber: lldb-commits. This change moves to using narrow character types and libedit APIs, beca

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid added a comment. In D106035#2879939 , @teemperor wrote: > I actually expected after the RFC that we would remove all the non-wchar > code, but this seems also fine. I think this LGTM in general, but I feel a > bit nervous about touching stuff th

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid updated this revision to Diff 359533. nealsid added a comment. Reran clang-format and removed extra braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106035/new/ https://reviews.llvm.org/D106035 Files: lldb/cmake/modules/LLDBConfig.c

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid added a comment. In D106035#2885292 , @teemperor wrote: > In D106035#2885174 , @nealsid wrote: > >> In D106035#2879939 , @teemperor >> wrote: >> >>> I actually ex

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid updated this revision to Diff 363358. nealsid added a comment. Update against HEAD (I still need to do a bit more testing but wanted to get the buildbot results in the meantime) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106035/new/ htt

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid updated this revision to Diff 364362. nealsid added a comment. Update against HEAD; tested on Debian Buster and Monterey Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106035/new/ https://reviews.llvm.org/D106035 Files: lldb/cmake/modules

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid added a comment. In D106035#2927660 , @teemperor wrote: > The release branch was recently made, so we can land this right now. Just > give me a ping when I should merge this :) Thanks - I recently got commit access so I figured I'd try it out wi

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid added a comment. :) Shoot. I definitely want to revert ASAP rather than keep the tree in a bad state. Just curious, since there are timeout messages in the log, would you be able to try rerunning just that one? I see this, too: 0: b"error: '\xe1\x88\xb4' is not a valid command. So I'm

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid added a comment. Yikes - issue count starting to slowly increase :) I've reverted the patch, and sorry again about that. I have to travel for a couple days but when I get my dev machine back up later this week I will investigate these issues in detail. I focussed my testing more on Un

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

gAlfonso-bit created this revision. gAlfonso-bit requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is especially important at the end of the function, where originally there was a strange cast from optional to bool Repository: rG LL

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

gAlfonso-bit updated this revision to Diff 365217. gAlfonso-bit added a comment. Simplify function even further CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/IOHandler.cpp ===

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

gAlfonso-bit updated this revision to Diff 365218. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/IOHandler.cpp ==

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

gAlfonso-bit updated this revision to Diff 365220. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/IOHandler.cpp ==

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

gAlfonso-bit updated this revision to Diff 365267. gAlfonso-bit added a comment. clang-tidy workaround CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/include/lldb/Core/IOHandler.h lldb/source/Core/IOHandler.cpp Index: lldb/so

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

gAlfonso-bit updated this revision to Diff 365497. gAlfonso-bit added a comment. Remove goto CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/include/lldb/Core/IOHandler.h lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

gAlfonso-bit marked an inline comment as done. gAlfonso-bit added a comment. Addressed all issues! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

gAlfonso-bit added a comment. Only clang-tidy is upset and it is falsely flagging "missing" files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid added a comment. Sorry, I haven't forgotten about this. Haven't had time to sit down for a proper debugging session this or last week. I definitely still plan to update and resend for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D107717: [NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit created this revision. gAlfonso-bit added a project: LLVM. Herald added subscribers: libcxx-commits, tstellar, mgorny. Herald added a reviewer: MaskRay. Herald added a project: libunwind. Herald added a reviewer: libunwind. gAlfonso-bit requested review of this revision. Herald added p

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. Alright. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D107717: [NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365039. Herald added a subscriber: JDevlieghere. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMock

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365275. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake compiler-rt/cmake

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. So does that mean this is ready to land? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365507. gAlfonso-bit added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLL

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne is this ok? any other changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365802. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockL

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366014. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockL

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366497. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/Compile

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne can we land this please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366671. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake compiler-rt/cmake

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. I don't think there are any other outstanding issues. Are we good to accept and merge? @ldionne CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne update? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

aykevl created this revision. aykevl added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, Jim, dylanmckay. Herald added a project: LLDB. I believe the actual opcode does not matter because the AVR architecture is a Harvard architecture that does not support writing to progra

[Lldb-commits] [PATCH] D74266: [lldb-vscode] remove deprecated trace option

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd62c9cecf34: [lldb-vscode] remove deprecated trace option (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D74264: [lldb-vscode] disable completions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc832e82cd9d8: [lldb-vscode] disable completions (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74264/new/

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl updated this revision to Diff 246443. aykevl added a comment. Rebase on master (after `GetPointer` was removed). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73969/new/ https://reviews.llvm.org/D73969 Files: lldb/source/Utility/DataExtractor.cpp lldb/unittests/Utility/DataE

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl added a comment. In D73969#1860696 , @labath wrote: > I agree only one of those two places should be enough. My idea was to make > the constructors delegate to one another (if necessary by creating a private > uber-constructor that everybody can d

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rGec1efe71130f: [LLDB] Let DataExtractor deal with two-byte addresses (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73969/new/ https://r

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

aykevl abandoned this revision. aykevl added a comment. Closing this one. Maybe there is something useful in this patch but if there is, I'll submit that in a standalone (more focused) patch. The majority of it has been merged in D73969 . Repository: rG LLVM

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73969/new/ https://reviews.llvm.org/D73969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

aykevl added a comment. In D74255#1871958 , @labath wrote: > However, if we look at this locally, if the AVR architecture has a trap > opcode (maybe to implement `__builtin_debugbreak()` -- I am assuming that's > what 0x98 0x95 is), then I don't see a pr

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate added a comment. Thanks for pointing out my misunderstanding on the Unix signals, and fetching the list of valid signals from backend is always a better way indeed. However, getting the current process from the current context `m_exe_ctx` which is got from `m_interpreter` will cause an is

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate updated this revision to Diff 247785. MrHate added a comment. Update the current execution context, then get signals from the current process. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 Files: lldb/source/Commands/CommandObjectProc

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate updated this revision to Diff 247786. MrHate added a comment. removed unnecessary assignment in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 Files: lldb/source/Commands/CommandObjectProcess.cpp lldb/test/API/functionalities/co

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate updated this revision to Diff 248088. MrHate edited the summary of this revision. MrHate added a comment. Removed individual execution context updating. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 Files: lldb/source/Commands/Command

[Lldb-commits] [PATCH] D75418: tab completion for process signal

MrHate updated this revision to Diff 248784. MrHate added a comment. Added a test case where test "process signal" without a running process. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 Files: lldb/source/Commands/CommandObjectProcess.cpp

[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rG0818e6cf1d30: [LLDB] Add support for AVR breakpoints (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74255/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2dec82652e4b: Create basic SBEnvironment class (authored by Walter Erquinigo ). Repository: rG LLVM

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

This revision was automatically updated to reflect the committed changes. Closed by commit rG576105c322b6: [lldb-vscode] stop read loop after termination (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D76529: [lldb-vscode] Add missing launchCommands entry in the package.json

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGa8c22ba41629: [lldb-vscode] Add missing launchCommands entry in the package.json (authored by Walter Erquinigo

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4ec6ebabfc3e: [lldb-vscode] Add inheritEnvironment option (authored by Hector Diaz , committed by Walter Erq

[Lldb-commits] [PATCH] D76891: [lldb-vscode] fix breakpoint result ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rGa515fd01a4f2: [lldb-vscode] fix breakpoint result ordering (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D76872: [intel-pt] Fix existing support in LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rG128c0d037d32: [intel-pt] Fix existing support in LLDB (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76872/ne

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

This revision was automatically updated to reflect the committed changes. Closed by commit rG30350c254106: [source maps] Ensure all valid source maps are added instead of failing with… (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1242ec54306: [intel-pt] Implement a basic test case (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new

[Lldb-commits] [PATCH] D77328: [intel-mpx] Delete an unnecessary license header

This revision was automatically updated to reflect the committed changes. Closed by commit rG725579379dee: [intel-mpx] Delete an unnecessary license header (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D77324: [source maps] Fix remove, insert-after and replace

This revision was automatically updated to reflect the committed changes. Closed by commit rGca47ac3d5f6f: [source maps] Fix remove, insert-after and replace (authored by Walter Erquinigo , committed by Walter Erquinigo ). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D77450: Fix LLDB debug builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG966122524b56: Fix LLDB debug builds (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77450/new/ https://review

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

This revision was automatically updated to reflect the committed changes. Closed by commit rGe796c77b26ac: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints… (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe3f8a8e1b95: [commands] Support autorepeat in SBCommands (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7744

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu abandoned this revision. Abpostelnicu added a comment. This has landed and trunk is already fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 __

[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

nealsid updated this revision to Diff 326553. nealsid added a comment. Herald added a project: LLDB. I'm updating this very old patch that I forgot about in 2018. This one removes the use of batons in the edit line callbacks, replaces typedefs with using declarations, and uses unique_function i

[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

nealsid added a comment. In D50299#2589289 , @JDevlieghere wrote: > Thanks Neal. Can you run clang-format again and upload the diff with context > (`git diff -U`). Overall this looks pretty good. Thanks for the review. I have run clang-format and a

[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

nealsid updated this revision to Diff 326954. nealsid removed a project: LLDB. nealsid added a comment. Updated diff with run of clang-format and added a check for function pointer validity. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50299/new/ https://reviews.llvm.org/D502

[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

nealsid updated this revision to Diff 327317. nealsid added a comment. Removed comment on #include line and organized the #includes to match coding guidelines better (I wasn't sure about whether the project uses blank lines in between #includes from different subproject like lldb/clang/llvm so I

[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

nealsid added a comment. In D50299#2596141 , @JDevlieghere wrote: > In D50299#2596008 , @nealsid wrote: > >> Removed comment on #include line and organized the #includes to match coding >> guidelines better (I was

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 328917. nealsid added a comment. Herald added a subscriber: JDevlieghere. Reuploading patch after I incorrectly set project repo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98153/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid added a comment. Thanks - all the comments sound good. I'll upload a new patch. It seems like the pre-merge check failures are because I incorrectly set the project repo when I first created the revision. I noticed in the build commands here: https://buildkite.com/llvm-project/premer

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 329266. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98153/new/ https://reviews.llvm.org/D98153 Files: lldb/include/lldb/Core/FormatEntity.h lldb/source/Core/FormatEntity.cpp lldb/unittests/Core/CMakeList

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid marked 3 inline comments as done. nealsid added inline comments. Comment at: lldb/include/lldb/Core/FormatEntity.h:144 +num_children(num_children), children(children), +keep_separator(keep_separator) {} }; teemperor wrote: > I

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid marked 2 inline comments as done. nealsid added a comment. In D98153#2610953 , @teemperor wrote: > Thanks for cleaning this up! Are the `if (!sc) ...` stuff are missing nullptr > checks that affect a normal LLDB session (not sure if we can ever ha

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid planned changes to this revision. nealsid added inline comments. Comment at: lldb/source/Core/FormatEntity.cpp:1560 } -return true; } Sorry, just caught this. Am uploading a new diff shortly. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 329834. nealsid added a comment. Fix regression introduced by removing return statement in case where we were able to format a function name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98153/new/ https://re

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 330884. nealsid added a comment. Rebased on HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98153/new/ https://reviews.llvm.org/D98153 Files: lldb/include/lldb/Core/FormatEntity.h lldb/source/Core/Forma

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid added a comment. In D98153#2610953 , @teemperor wrote: > Thanks for cleaning this up! Are the `if (!sc) ...` stuff are missing nullptr > checks that affect a normal LLDB session (not sure if we can ever have no > SymbolContext) or is this just fo

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 333507. nealsid added a comment. Thanks for the review - addressed your comments here (I had to rely on Doxygen picking up the type reference automatically because I couldn't get the \see syntax to work correctly, though) Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 337329. nealsid added a comment. CR feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98153/new/ https://reviews.llvm.org/D98153 Files: lldb/include/lldb/Core/FormatEntity.h lldb/source/Core/FormatEnt

<    2   3   4   5   6   7   8   9   10   11   >