clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good!
https://reviews.llvm.org/D52403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
grimar added a comment.
Thanks for the review! It still depends on -gsingle-file-split-dwarf
(https://reviews.llvm.org/D52403), I'll wait for it some time.
It should be possible to rewrite the comment in the test case to avoid
mentioning the flag, but I would prefer to use it.
https://reviews.
zturner added a comment.
I think it’s fine. Eventually when you are ready to support remote
debugging hopefully we can convert it over to using lldb-server
https://reviews.llvm.org/D52618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
jingham added a comment.
I agree with Zachary, converting to NativeProcess is enough of a project that
we should not block useful fixes to the current ProcessWindows plugin on it.
OTOH, it is a good project - somebody should add it to the Projects page.
https://reviews.llvm.org/D52618
sgraenitz updated this revision to Diff 167593.
sgraenitz marked 8 inline comments as done.
sgraenitz added a comment.
Address feedback from Adrian and Duncan
https://reviews.llvm.org/D52375
Files:
include/lldb/Symbol/Symtab.h
packages/Python/lldbsuite/test/macosx/debug_map/Makefile
packa
sgraenitz added inline comments.
Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:13
+# Set inputs empty, if not passed from the Python script.
+CFLAGS ?=
+LDFLAGS ?=
aprantl wrote:
> This is a noop. You can remove it without affecting anythin
grimar created this revision.
grimar added reviewers: LLDB, clayborg.
Herald added subscribers: JDevlieghere, aprantl.
LLDB does not support this DWARF5 form atm.
At least gcc emits it in some cases when doing optimization
for abbreviations.
As far I can tell, clang does not support it yet, thoug
aprantl added inline comments.
Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:30
+main.o: main.c
+ $(CC) -c -g $(CFLAGS) $(CFLAGS_MAIN) -o main.o $(SRCDIR)/main.c
+
sgraenitz wrote:
> aprantl wrote:
> > ` $(CC) -c $(CFLAGS) $(CFLAGS_M
labath added a comment.
In https://reviews.llvm.org/D52532#1246173, @krytarowski wrote:
> I was wondering whether we want to normalize this inside the kernel and
> always advance the Program Counter.. but it's easier to manage it in userland.
I am generally in favour of keeping the kernel simp
Hui added a comment.
In https://reviews.llvm.org/D52461#1249259, @aleksandr.urakov wrote:
> In https://reviews.llvm.org/D52461#1245058, @clayborg wrote:
>
> > Try to use and extend CPlusPlusLanguage::MethodName as needed. I believe it
> > was recently backed by a new clang parser that knows how
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343409: Pull GetSoftwareBreakpointPCOffset into base class
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52532
Files:
ll
krytarowski added a comment.
In https://reviews.llvm.org/D52532#1250404, @labath wrote:
> In https://reviews.llvm.org/D52532#1246173, @krytarowski wrote:
>
> > I was wondering whether we want to normalize this inside the kernel and
> > always advance the Program Counter.. but it's easier to mana
aleksandr.urakov added a comment.
Ok, I'll look at this, thank you!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added inline comments.
Herald added a subscriber: arphaman.
Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:179
+ if (!m_die_array.empty()) {
+lldbassert(!m_first_die || m_first_die == m_die_array.front());
+m_first_die = m_die_array.front();
labath added a comment.
In https://reviews.llvm.org/D52461#1249259, @aleksandr.urakov wrote:
> It seems that `CPlusPlusLanguage::MethodName` is backed by LLDB
> `CPlusPlusNameParser`, which can't parse demangled names...
What makes you say that? If you look at the MethodName unit tests
(`unit
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Any idea why the module isn't set correctly in certain dwarf expressions? Any
variable that is created from debug info that pertains to a module should have
its DWARFExpression c
clayborg added a comment.
See SymbolFileDWARF::ParseVariableDIE. It has code that links up the DW_OP_addr:
if (is_static_lifetime) {
if (is_external)
scope = eValueTypeVariableGlobal;
else
scope = eValueTypeVariableStatic;
if (debug_map_symfile) {
// When leavin
clayborg added a comment.
If this isn't fixing up cases where the global does have an address (not just
set to zero), we need to fix the code so it relinks the global address
correctly.
https://reviews.llvm.org/D52678
___
lldb-commits mailing list
asmith updated this revision to Diff 167670.
https://reviews.llvm.org/D52627
Files:
source/Symbol/Symtab.cpp
Index: source/Symbol/Symtab.cpp
===
--- source/Symbol/Symtab.cpp
+++ source/Symbol/Symtab.cpp
@@ -139,6 +139,8 @@
aleksandr.urakov added a comment.
I've tried to parse with it a name like
N0::`unnamed namespase'::Name
and it can't parse it correctly. May be it just can't parse MSVC demangled
names?
Unfortunately, I can't look at the tests right now, I have a vacation. I'll
look at these a week later, o
labath created this revision.
labath added a reviewer: krytarowski.
This function existed (with identical code) in both NativeProcessLinux
and NativeProcessNetBSD, and it is likely that it would be useful to any
future implementation of NativeProcessProtocol.
Therefore I move it to the base class
labath added inline comments.
Comment at: lit/Expr/TestIRMemoryMapWindows.test:1-12
+# REQUIRES: windows
+
+# RUN: clang-cl /Zi %p/Inputs/call-function.cpp -o %t
+
+# RUN: lldb-test ir-memory-map %t %S/Inputs/ir-memory-map-basic
+# RUN: lldb-test ir-memory-map -host-only %t %S/In
labath added a comment.
In https://reviews.llvm.org/D52461#1250555, @aleksandr.urakov wrote:
> I've tried to parse with it a name like
>
> N0::`unnamed namespase'::Name
>
>
> and it can't parse it correctly. May be it just can't parse MSVC demangled
> names?
I expect the backqoutes are confu
zturner added a comment.
One idea would be to define some lit substitutions like %debuginfo. It’s
true you can produce a gcc style command line that will be equivalent to a
clang-cl invocation but it won’t be easy. eg you’ll needing to pass
-fms-compatibility as well as various -I for includes.
I
JDevlieghere updated this revision to Diff 167722.
JDevlieghere edited the summary of this revision.
JDevlieghere added a comment.
- Rebase
https://reviews.llvm.org/D52651
Files:
include/lldb/Interpreter/OptionValue.h
lit/Settings/TestExport.test
source/Commands/CommandObjectSettings.cpp
stella.stamenova added a comment.
In https://reviews.llvm.org/D52618#1250909, @zturner wrote:
> One idea would be to define some lit substitutions like %debuginfo. It’s
> true you can produce a gcc style command line that will be equivalent to a
> clang-cl invocation but it won’t be easy. eg yo
zturner added a comment.
In https://reviews.llvm.org/D52618#1251076, @stella.stamenova wrote:
> In https://reviews.llvm.org/D52618#1250909, @zturner wrote:
>
> > One idea would be to define some lit substitutions like %debuginfo. It’s
> > true you can produce a gcc style command line that will b
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343497: [lldb] Start a new line for the next output if there
are no symbols in the… (authored by asmith, committed by ).
H
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Runnings `settings export` crashes LLDB:
(lldb) down
❲ 8❳ CommandObjectSettingsExport::DoExecute(this=0x55652a80,
args=0x7fffd6b8, result=0x7fffdd80
teemperor added a comment.
- Running `settings export /home/teemperor/foobar1 /home/teemperor/foobar2`
will actually just create foobar1, but will not report any error that foobar2
is silently ignored.
- Do we actually have a way to have file completion for the argument? (This
doesn't have to
aprantl updated this revision to Diff 167827.
aprantl added a comment.
Thanks, that was excellent feedback! Updated the patch to set the expression's
module instead.
https://reviews.llvm.org/D52678
Files:
include/lldb/Expression/DWARFExpression.h
packages/Python/lldbsuite/test/functionalit
jingham added a comment.
To Raphael's points:
Argument completion handlers are set by the command object implementing
HandleArgumentCompletion and dispatching to the
CommandCompletions::eDiskFileCompletion. An example of this is in
CommandObjectProcessLaunch. Note, arguments currently have a
jingham added a comment.
The only thing that worries me about this fix is that it's addressing a problem
that's a pretty easy mistake to make. Is there ever a case that you would want
to resolve a DWARF expression in the context of a .o file module? If not, is
there some way we can make this
JDevlieghere updated this revision to Diff 167889.
JDevlieghere added a comment.
Thanks a lot for the feedback! I clearly overlooked some stuff when inspiring
myself on the other CommandObject code.
I've updated the diff:
- Rename functionality to read and write for consistency with breakpoints
JDevlieghere created this revision.
JDevlieghere added a reviewer: LLDB.
I want to make providing no value to `setting set ` equivalent to
clearing that setting: `settings clear `. The motivation is
https://reviews.llvm.org/D52651 that allows settings to be written to and read
from a file. Not
JDevlieghere updated this revision to Diff 167892.
JDevlieghere marked 2 inline comments as done.
JDevlieghere added a comment.
Split off `settings set` change into separate review:
https://reviews.llvm.org/D52772
https://reviews.llvm.org/D52651
Files:
include/lldb/Interpreter/OptionValue.h
labath added a comment.
In https://reviews.llvm.org/D52618#1250909, @zturner wrote:
> One idea would be to define some lit substitutions like %debuginfo. It’s
> true you can produce a gcc style command line that will be equivalent to a
> clang-cl invocation but it won’t be easy. eg you’ll needi
aprantl added a comment.
I could move it further up in the same function if that is what you mean? Then
it would also apply to (hypothetical local variables that refer to a
DW_OP_addr). I could imagine that this might be useful in some languages that
want to refer to some static type metadata.
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Jim: we are already linking the address for the DW_OP_addr using the debug map
and no .o files are currently expected to be able to link an unlinked address
into a file address as nothing
jingham added a comment.
Would it be possible for the exporter to notice empty settings and write
"settings clear" instead? I'm worried that if you have a complicated setting,
and the you do:
(lldb) settings set target.some-complex-setting
and decide you are wrong, you don't want to change th
jingham added a comment.
I was thinking more like if it's possible to figure out that a given module has
a debug_map parent, "SetModule" could automatically redirect to the that
module. Then all clients have to do is SetModule with the module they have to
hand and it would get the right thing.
sgraenitz created this revision.
sgraenitz added reviewers: aprantl, jasonmolenda, JDevlieghere.
sgraenitz added a subscriber: LLDB.
Add settings to control command echoing:
(lldb) settings set interpreter.echo-commands true
(lldb) settings set interpreter.echo-comment-commands true
Both set
sgraenitz updated this revision to Diff 167976.
sgraenitz added a comment.
Fix CommandInterpreterRunOptions::GetStopOnError()
https://reviews.llvm.org/D52788
Files:
include/lldb/API/SBCommandInterpreter.h
include/lldb/Interpreter/CommandInterpreter.h
source/API/SBCommandInterpreter.cpp
sgraenitz added inline comments.
Comment at: include/lldb/Interpreter/CommandInterpreter.h:105
- bool GetStopOnError() const { return DefaultToNo(m_stop_on_continue); }
+ bool GetStopOnError() const { return DefaultToNo(m_stop_on_error); }
Unrelated fix
=
jingham added a comment.
The StopOnCrash logic is slightly different. Because the outer if is
"GetStopOnCrash()" you will only set stop on crash if it is set at this level
and was set in the previously pushed flag set. That forces StopOnCrash to be
set from the top all the way down.
For Stop
shafik added inline comments.
Comment at: source/Interpreter/CommandInterpreter.cpp:2733
+
+ const char *k_space_characters = "\t\n\v\f\r ";
+ size_t first_non_space = line.find_first_not_of(k_space_characters);
This looks like duplicate code from from `HandleC
shafik added inline comments.
Comment at: source/Interpreter/CommandInterpreter.cpp:96
+{"echo-comment-commands", OptionValue::eTypeBoolean, true, true, nullptr,
+ {}, "If true, LLDB will print a command even if it is a pure comment "
+ "line."}};
---
sgraenitz updated this revision to Diff 167995.
sgraenitz added a comment.
Add tests, address some of the feedback from Jim and Shafik
https://reviews.llvm.org/D52788
Files:
include/lldb/API/SBCommandInterpreter.h
include/lldb/Interpreter/CommandInterpreter.h
lit/Settings/Inputs/EchoComma
zturner added a comment.
In https://reviews.llvm.org/D52618#1252372, @labath wrote:
> In https://reviews.llvm.org/D52618#1250909, @zturner wrote:
>
> > One idea would be to define some lit substitutions like %debuginfo. It’s
> > true you can produce a gcc style command line that will be equivale
vsk added a comment.
Friendly ping.
https://reviews.llvm.org/D50478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sgraenitz marked an inline comment as done.
sgraenitz added inline comments.
Comment at: source/Interpreter/CommandInterpreter.cpp:2733
+
+ const char *k_space_characters = "\t\n\v\f\r ";
+ size_t first_non_space = line.find_first_not_of(k_space_characters);
sh
sgraenitz added a comment.
Is it ok to have so many TestEchoXY.test files? I tried to get them all in one,
but so far it didn't work out.
Comment at: source/Interpreter/CommandInterpreter.cpp:2733
+
+ const char *k_space_characters = "\t\n\v\f\r ";
+ size_t first_non_space =
vsk added a comment.
Could you describe how the test exercises DW_FORM_implicit_const support? It's
not immediately clear to me.
https://reviews.llvm.org/D52689
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
grimar added a comment.
In https://reviews.llvm.org/D52689#1253175, @vsk wrote:
> Could you describe how the test exercises DW_FORM_implicit_const support?
> It's not immediately clear to me.
The abbreviation for `foo1` and `foo2` subprograms use it for `DW_AT_decl_file`
and `DW_AT_decl_colum
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343683: Pull FixupBreakpointPCAsNeeded into base class
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52719
Files:
lldb/t
JDevlieghere added a comment.
In https://reviews.llvm.org/D52772#1252656, @jingham wrote:
> Would it be possible for the exporter to notice empty settings and write
> "settings clear" instead?
I don't think we can if we want to re-use the existing dump infrastructure,
unless there's a way to
JDevlieghere added a comment.
Thanks for working on this Stefan, I'm really excited about this feature!
Regarding the code, I don't have comments that weren't already brought up by
the other reviewers.
https://reviews.llvm.org/D52788
___
lldb-comm
jingham added a comment.
I'm thinking of the scenario where you type:
(lldb) settings set target.run-args
and then decide you didn't want to change the run-args after all. Before this
change hitting return used to be a way to dismiss the settings operation, and
that actually seems a pretty na
jingham added a comment.
And more, I just like operations to be explicit and not have overloads like
"settings set property" == "settings clear property".
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52772
___
lldb-commits mailing list
lldb-
aprantl added a comment.
This looks pretty good! I have one last question about CallEdge inside.
Comment at: lldb/include/lldb/Symbol/Function.h:304
+public:
+ CallEdge(const char *mangled_name, lldb::addr_t return_pc);
+
Does this also work for C functions? I
aprantl added inline comments.
Comment at: source/Interpreter/CommandInterpreter.cpp:2733
+
+ const char *k_space_characters = "\t\n\v\f\r ";
+ size_t first_non_space = line.find_first_not_of(k_space_characters);
sgraenitz wrote:
> sgraenitz wrote:
> > shafik w
vsk updated this revision to Diff 168155.
vsk marked an inline comment as done.
vsk added a comment.
- Address feedback from Adrian.
https://reviews.llvm.org/D50478
Files:
lldb/include/lldb/API/SBFrame.h
lldb/include/lldb/Core/FormatEntity.h
lldb/include/lldb/Symbol/Block.h
lldb/include
vsk added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:304
+public:
+ CallEdge(const char *mangled_name, lldb::addr_t return_pc);
+
aprantl wrote:
> Does this also work for C functions? If yes, would `symbol_name` be a more
> accurate descri
aprantl added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:304
+public:
+ CallEdge(const char *mangled_name, lldb::addr_t return_pc);
+
vsk wrote:
> vsk wrote:
> > aprantl wrote:
> > > Does this also work for C functions? If yes, would `symbo
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
I think this looks fine. Vedant, thoughts?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51874
___
lldb-commits mailing list
lldb-commits@l
vsk added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:304
+public:
+ CallEdge(const char *mangled_name, lldb::addr_t return_pc);
+
aprantl wrote:
> vsk wrote:
> > vsk wrote:
> > > aprantl wrote:
> > > > Does this also work for C functions? I
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Thanks!
https://reviews.llvm.org/D50478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
vsk added inline comments.
Comment at: packages/Python/lldbsuite/test/dosep.py:1693
for core in cores:
dst = core.replace(test_directory, "")[1:]
dst = dst.replace(os.path.sep, "-")
Instead of redefining test_directory, please use 'test_sub
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB343726: Fix buildbot regression by rL339929: NameError:
global name 'test_directory' is… (authored by jankratochvil,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51874?vs=16470
vsk added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/target_var/globals.ll:1
+source_filename = "globals.c"
+target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
Should we check in bitcode instead? That might make it easie
shafik created this revision.
shafik added reviewers: jingham, davide, aprantl.
Herald added a reviewer: EricWF.
- Adding support to step into the callable wrapped by libc++ std::function
- Adding test to validate that functionality
https://reviews.llvm.org/D52851
Files:
include/lldb/Target/C
davide added a comment.
Some basic comments. Haven't looked at the implementation very closely, I'll do
that probably tomorrow. Thanks for working on this!
Comment at: include/lldb/Target/CPPLanguageRuntime.h:59-60
+ lldb::ThreadPlanSP GetStepThroughTrampolinePlan(Thread &t
davide added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/target_var/globals.ll:1
+source_filename = "globals.c"
+target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
vsk wrote:
> Should we check in bitcode instead? That mig
vsk added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/target_var/globals.ll:1
+source_filename = "globals.c"
+target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
davide wrote:
> vsk wrote:
> > Should we check in bitcode in
davide added a comment.
I'll commit this for you, but I might ask if you can try adding a test first?
https://reviews.llvm.org/D50304
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
brucem created this revision.
brucem added a reviewer: lldb-commits.
Herald added subscribers: ki.stfu, srhines.
https://reviews.llvm.org/D52884
Files:
include/lldb/Utility/ConstString.h
packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
source/Host/common/MainLoop.cpp
source/Host
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
This looks all good to me. I'm a bit worried about the changes to
AppleObjCTrampolineHandler.cpp, but from what I can see we don't actually rely
on this specific field name anywhere in o
shafik updated this revision to Diff 168389.
shafik marked 6 inline comments as done.
shafik added a comment.
Addressing comments and fixing a bug in ThreadPlanStepThrough.cpp where I would
overwrite the result of objc_runtime.
https://reviews.llvm.org/D52851
Files:
include/lldb/Target/CPPL
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB343825: Fix typos. (authored by brucem, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52884?vs=168279&id=168398#toc
Repository:
rL LLVM
https://reviews.llvm.org/D52884
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343825: Fix typos. (authored by brucem, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52884
Files:
lldb/trunk/include/lldb/Utility/ConstString
vsk added a comment.
Ping?
https://reviews.llvm.org/D50155
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sgraenitz updated this revision to Diff 168450.
sgraenitz added a comment.
Minor fixes
https://reviews.llvm.org/D52788
Files:
include/lldb/API/SBCommandInterpreter.h
include/lldb/Interpreter/CommandInterpreter.h
lit/Settings/Resources/EchoCommandsAll.out
lit/Settings/Resources/EchoComma
sgraenitz updated this revision to Diff 168453.
sgraenitz added a comment.
Enable interpreter.echo-comment-commands in lit-lldb-init. All tests still
passing.
https://reviews.llvm.org/D52788
Files:
include/lldb/API/SBCommandInterpreter.h
include/lldb/Interpreter/CommandInterpreter.h
lit/
sgraenitz marked an inline comment as done.
sgraenitz added a comment.
IMO Ready now.
Comment at: source/Interpreter/CommandInterpreter.cpp:2417
flags |= eHandleCommandFlagPrintResult;
}
sgraenitz wrote:
> Could reduce boilerplate in the code
sgraenitz updated this revision to Diff 168466.
sgraenitz added a comment.
Simplify test as proposed in review
https://reviews.llvm.org/D52270
Files:
lit/Expr/TestMultilineExpr.test
packages/Python/lldbsuite/test/expression_command/multiline/Makefile
packages/Python/lldbsuite/test/expres
sgraenitz marked an inline comment as done.
sgraenitz added a comment.
Requires: https://reviews.llvm.org/D52788 (Add EchoCommentCommands to
CommandInterpreterRunOptions in addition to the existing EchoCommands and
expose both as interpreter settings)
https://reviews.llvm.org/D52270
___
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
One final inline comment but otherwise I think this is good to go. Thanks!
Comment at: lit/Settings/Resources/EchoCommandsAll.out:1
+# CHECK: (lldb) command source -s {{.*\
sgraenitz updated this revision to Diff 168478.
sgraenitz marked an inline comment as done.
sgraenitz added a comment.
Rename folder lit/Settings/Resources to lit/Settings/Inputs
https://reviews.llvm.org/D52788
Files:
include/lldb/API/SBCommandInterpreter.h
include/lldb/Interpreter/CommandI
labath created this revision.
labath added reviewers: krytarowski, zturner, clayborg.
Herald added a subscriber: mgorny.
A fairly simple operation as setting a breakpoint (writing a breakpoint
opcode) at a given address was going through three classes:
NativeProcessProtocol which called NativeBrea
vadimcn added a comment.
Changing title as it looks like this is not a Windows-only problem:
https://github.com/rust-lang/rust/issues/54126.
The above illustrates why I think this needs to be fixed: Right now LLDB cannot
be installed correctly unless the installer can preserve symlinks. Merely
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Sorry for the delay. I *think* this should be fine, but with these things its
hard to tell whether it won't break someone's build/release setup. However, it
does solve a real problem (I've hit
vadimcn added a comment.
Thanks,
What changed in SWIG 3.0.11?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
In https://reviews.llvm.org/D52404#1257347, @vadimcn wrote:
> Thanks,
> What changed in SWIG 3.0.11?
That's the version which added support for the `moduleimport` attribute. Before
that, the modules were imported using a fixed algorithm (I am not sure whether
that alg
krytarowski accepted this revision.
krytarowski added a comment.
This revision is now accepted and ready to land.
The NetBSD part looks fine. I will be out of the office soon as I will visit
California for GSoC Mentor Summit and MeetBSDCa (until October 23rd).
https://reviews.llvm.org/D52941
grimar created this revision.
grimar added reviewers: LLDB, clayborg.
Herald added subscribers: JDevlieghere, arichardson, emaste.
Herald added a reviewer: espindola.
This adds a basic support of the .debug_rnglists section.
Only the DW_RLE_start_length and DW_RLE_end_of_list entries are supported
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just add a switch statement when handling the encodings and a lldbassert as
mentioned in inlined comments and this will be good to go.
Comment at: source/Plugi
clayborg added a comment.
For space savings it seems like we would want to support the
DW_RLE_base_address and DW_RLE_offset_pair pretty soon.
https://reviews.llvm.org/D52981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
jingham added a comment.
Just a couple of trivial requests, mostly about comments...
Comment at:
packages/Python/lldbsuite/test/lang/cpp/std-function-step-into-callable/TestStdFunctionStepIntoCallable.py:27-28
+
+@add_test_categories(["libc++"])
+def test(self):
+
jingham created this revision.
Herald added subscribers: lldb-commits, abidh.
"expression" is a hugely inefficient way to get the value of a local variable.
There are a few cases where "frame variable" and "expression" will produce
different results on the same expression (e.g. "foo->bar" when
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LG. If you can add a line to an existing inline test, I think it would be
excellent.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53010
_
1001 - 1100 of 48440 matches
Mail list logo
