[Lldb-commits] [lldb] r353429 - Fix headers for files added in r353047

Author: labath Date: Thu Feb 7 09:16:25 2019 New Revision: 353429 URL: http://llvm.org/viewvc/llvm-project?rev=353429&view=rev Log: Fix headers for files added in r353047 I started working on that patch before the headers were updated. Since they were new files, I didn't get any conflicts during

[Lldb-commits] [lldb] r353677 - minidump: Add ability to attach (breakpad) symbol files to placeholder modules

Author: labath Date: Mon Feb 11 01:32:08 2019 New Revision: 353677 URL: http://llvm.org/viewvc/llvm-project?rev=353677&view=rev Log: minidump: Add ability to attach (breakpad) symbol files to placeholder modules Summary: The reason this wasn't working was that ProcessMinidump was creating odd obj

[Lldb-commits] [lldb] r353686 - Revert "minidump: Add ability to attach (breakpad) symbol files to placeholder modules"

Author: labath Date: Mon Feb 11 02:30:24 2019 New Revision: 353686 URL: http://llvm.org/viewvc/llvm-project?rev=353686&view=rev Log: Revert "minidump: Add ability to attach (breakpad) symbol files to placeholder modules" The commit has broken TestMiniDump.py on windows. Reverting while I investi

[Lldb-commits] [lldb] r353702 - Breakpad: auto-detect path style of file entries

Author: labath Date: Mon Feb 11 06:11:00 2019 New Revision: 353702 URL: http://llvm.org/viewvc/llvm-project?rev=353702&view=rev Log: Breakpad: auto-detect path style of file entries Summary: This adds support for auto-detection of path style to SymbolFileBreakpad (similar to how r351328 did the s

[Lldb-commits] [lldb] r353714 - Simplify ObjectFile::GetUUID

Author: labath Date: Mon Feb 11 08:14:02 2019 New Revision: 353714 URL: http://llvm.org/viewvc/llvm-project?rev=353714&view=rev Log: Simplify ObjectFile::GetUUID instead of returning the UUID through by-ref argument and a boolean value indicating success, we can just return it directly. Since the

Re: [Lldb-commits] [lldb] r353778 - Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows.

On 12/02/2019 01:30, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Mon Feb 11 16:30:21 2019 New Revision: 353778 URL: http://llvm.org/viewvc/llvm-project?rev=353778&view=rev Log: Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows. Apparently there are multiple places wher

[Lldb-commits] [lldb] r353812 - Extract common PlatformPOSIX/Windows code into a separate class

Author: labath Date: Tue Feb 12 01:27:24 2019 New Revision: 353812 URL: http://llvm.org/viewvc/llvm-project?rev=353812&view=rev Log: Extract common PlatformPOSIX/Windows code into a separate class Summary: The two classes contained a lot of duplicated code, but there wasn't a good place to factor

[Lldb-commits] [lldb] r353841 - Have Stream::PutCStringAsRawHex8 take llvm::StringRef

Author: labath Date: Tue Feb 12 06:28:55 2019 New Revision: 353841 URL: http://llvm.org/viewvc/llvm-project?rev=353841&view=rev Log: Have Stream::PutCStringAsRawHex8 take llvm::StringRef This enables the function to be called with a StringRef without jumping through any hoops. I rename the functi

[Lldb-commits] [lldb] r353916 - ObjectFilePECOFF: Create a "container" section spanning the entire module image

Author: labath Date: Tue Feb 12 23:17:24 2019 New Revision: 353916 URL: http://llvm.org/viewvc/llvm-project?rev=353916&view=rev Log: ObjectFilePECOFF: Create a "container" section spanning the entire module image Summary: This is coming from the discussion in D55356 (the most interesting part hap

[Lldb-commits] [lldb] r353944 - Fix one more string/bytes issue in lldb-server tests

Author: labath Date: Wed Feb 13 04:54:59 2019 New Revision: 353944 URL: http://llvm.org/viewvc/llvm-project?rev=353944&view=rev Log: Fix one more string/bytes issue in lldb-server tests This fixes about a dozen tests with python3. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/ll

[Lldb-commits] [lldb] r353945 - Revert "Fix one more string/bytes issue in lldb-server tests"

Author: labath Date: Wed Feb 13 05:06:37 2019 New Revision: 353945 URL: http://llvm.org/viewvc/llvm-project?rev=353945&view=rev Log: Revert "Fix one more string/bytes issue in lldb-server tests" It looks like I was too hasty to submit the previous patch. It does fix some tests on python3, but it

[Lldb-commits] [lldb] r354033 - Move UnwindTable from ObjectFile to Module

Author: labath Date: Thu Feb 14 06:40:10 2019 New Revision: 354033 URL: http://llvm.org/viewvc/llvm-project?rev=354033&view=rev Log: Move UnwindTable from ObjectFile to Module Summary: This is a preparatory step to enable adding extra unwind strategies by symbol file plugins. This has been discus

[Lldb-commits] [lldb] r354103 - Remove redundant semicolon after namespace-closing '}'

Author: labath Date: Thu Feb 14 23:33:37 2019 New Revision: 354103 URL: http://llvm.org/viewvc/llvm-project?rev=354103&view=rev Log: Remove redundant semicolon after namespace-closing '}' Modified: lldb/trunk/include/lldb/Symbol/SourceModule.h Modified: lldb/trunk/include/lldb/Symbol/SourceM

[Lldb-commits] [lldb] r354104 - Embed swig version into lldb.py in a different way

Author: labath Date: Thu Feb 14 23:41:12 2019 New Revision: 354104 URL: http://llvm.org/viewvc/llvm-project?rev=354104&view=rev Log: Embed swig version into lldb.py in a different way Summary: Instead of doing string chopping on the resulting python file, get swig to output the version for us. Th

[Lldb-commits] [lldb] r354105 - Use sys.executable in lldb-dotest

Author: labath Date: Thu Feb 14 23:41:17 2019 New Revision: 354105 URL: http://llvm.org/viewvc/llvm-project?rev=354105&view=rev Log: Use sys.executable in lldb-dotest Without that, dotest.py would be executed with the default python interpreter, which may not be the same one that lldb is built wi

[Lldb-commits] [lldb] r354106 - Fix lldb-server test suite for python3

Author: labath Date: Thu Feb 14 23:47:06 2019 New Revision: 354106 URL: http://llvm.org/viewvc/llvm-project?rev=354106&view=rev Log: Fix lldb-server test suite for python3 Summary: This patch finishes the python3-ification of the lldb-server test suite. It reverts the partial attempt in r352709 t

[Lldb-commits] [lldb] r354112 - Sort files in source/Host/CMakeLists.txt

Author: labath Date: Fri Feb 15 02:06:21 2019 New Revision: 354112 URL: http://llvm.org/viewvc/llvm-project?rev=354112&view=rev Log: Sort files in source/Host/CMakeLists.txt Modified: lldb/trunk/source/Host/CMakeLists.txt Modified: lldb/trunk/source/Host/CMakeLists.txt URL: http://llvm.org/

[Lldb-commits] [lldb] r354114 - Fix the gdb-client test suite for python3

Author: labath Date: Fri Feb 15 02:47:34 2019 New Revision: 354114 URL: http://llvm.org/viewvc/llvm-project?rev=354114&view=rev Log: Fix the gdb-client test suite for python3 This applies the same fix that was done in r354106 to the lldb-server test: bitcasting the string to a bytes object before

[Lldb-commits] [lldb] r354125 - Remove alignment from struct XSAVE altogether

Author: labath Date: Fri Feb 15 04:20:23 2019 New Revision: 354125 URL: http://llvm.org/viewvc/llvm-project?rev=354125&view=rev Log: Remove alignment from struct XSAVE altogether I reduced the alignment of this struct in r342029 to avoid compiler warnings about under-aligned allocations, but it t

Re: [Lldb-commits] [lldb] r353778 - Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows.

Ah, it's our struct XSAVE friend again. Yeah, I think I have a pretty good idea of what this is doing, and I believe we don't need any special alignment there, so I just went ahead and removed it. Assuming this doesn't cause any issues, you should be able to revert this patch. On 13/02/2019 18

[Lldb-commits] [lldb] r354251 - Set cmake policy CMP0075 to NEW

Author: labath Date: Mon Feb 18 02:09:29 2019 New Revision: 354251 URL: http://llvm.org/viewvc/llvm-project?rev=354251&view=rev Log: Set cmake policy CMP0075 to NEW Summary: The policy is about cmake_include_files ignoring CMAKE_REQUIRED_LIBRARIES in the OLD behavior. Llvm already sets this polic

[Lldb-commits] [lldb] r354256 - Return better error message from GDBRemoteCommunication::ConnectLocally

Author: labath Date: Mon Feb 18 02:36:23 2019 New Revision: 354256 URL: http://llvm.org/viewvc/llvm-project?rev=354256&view=rev Log: Return better error message from GDBRemoteCommunication::ConnectLocally Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Modif

[Lldb-commits] [lldb] r354258 - PECOFF: Implement GetBaseAddress

Author: labath Date: Mon Feb 18 03:06:57 2019 New Revision: 354258 URL: http://llvm.org/viewvc/llvm-project?rev=354258&view=rev Log: PECOFF: Implement GetBaseAddress COFF files are modelled in lldb as having one big container section spanning the entire module image, with the actual sections bein

[Lldb-commits] [lldb] r354263 - minidump: Add ability to attach (breakpad) symbol files to placeholder modules

Author: labath Date: Mon Feb 18 03:55:01 2019 New Revision: 354263 URL: http://llvm.org/viewvc/llvm-project?rev=354263&view=rev Log: minidump: Add ability to attach (breakpad) symbol files to placeholder modules This re-commits r353677, which was reverted due to test failures on the windows bot.

[Lldb-commits] [lldb] r354273 - Fix TestLinuxCore for python3

Author: labath Date: Mon Feb 18 07:04:33 2019 New Revision: 354273 URL: http://llvm.org/viewvc/llvm-project?rev=354273&view=rev Log: Fix TestLinuxCore for python3 - dictionaries don't have iteritems() - division returns floats Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalit

[Lldb-commits] [lldb] r354278 - Un-XFAIL TestLinuxCore for windows

Author: labath Date: Mon Feb 18 08:05:26 2019 New Revision: 354278 URL: http://llvm.org/viewvc/llvm-project?rev=354278&view=rev Log: Un-XFAIL TestLinuxCore for windows It turns out all that was needed to get this test passing was to fix the python3 incompatibility. Modified: lldb/trunk/pack

[Lldb-commits] [lldb] r354307 - [gui] Simplify SourceFileWindowDelegate::WindowDelegateDraw

Author: labath Date: Tue Feb 19 00:12:41 2019 New Revision: 354307 URL: http://llvm.org/viewvc/llvm-project?rev=354307&view=rev Log: [gui] Simplify SourceFileWindowDelegate::WindowDelegateDraw instead of printf-ing into a buffer, and them using that buffer as a format string, simply use the appro

[Lldb-commits] [lldb] r354308 - Fix vscode tests for python3

Author: labath Date: Tue Feb 19 00:25:25 2019 New Revision: 354308 URL: http://llvm.org/viewvc/llvm-project?rev=354308&view=rev Log: Fix vscode tests for python3 encode/decode the data before sending it over the socket. Since (AFAICT) the vscode protocol (unlike the gdb-remote one) is fully textu

[Lldb-commits] [lldb] r354324 - Revert "minidump: Add ability to attach (breakpad) symbol files to placeholder modules"

Author: labath Date: Tue Feb 19 05:52:31 2019 New Revision: 354324 URL: http://llvm.org/viewvc/llvm-project?rev=354324&view=rev Log: Revert "minidump: Add ability to attach (breakpad) symbol files to placeholder modules" This reverts r354263, because it uncovered a problem in handling of the min

Re: [Lldb-commits] [lldb] r354424 - [Instrumentation] Make API logging unconditional

On 20/02/2019 02:49, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Tue Feb 19 17:49:13 2019 New Revision: 354424 URL: http://llvm.org/viewvc/llvm-project?rev=354424&view=rev Log: [Instrumentation] Make API logging unconditional We should always log API calls in addition t

[Lldb-commits] [lldb] r354662 - Split up minidump register context tests

Author: labath Date: Fri Feb 22 00:51:08 2019 New Revision: 354662 URL: http://llvm.org/viewvc/llvm-project?rev=354662&view=rev Log: Split up minidump register context tests The tests were doing two somewhat independent things: - checking that the registers can be retrieved from the minidump file

[Lldb-commits] [lldb] r354668 - Avoid two-stage initialization of MinidumpParser

Author: labath Date: Fri Feb 22 05:36:01 2019 New Revision: 354668 URL: http://llvm.org/viewvc/llvm-project?rev=354668&view=rev Log: Avoid two-stage initialization of MinidumpParser remove the Initialize function, move the things that can fail into the static factory function. The factory functio

[Lldb-commits] [lldb] r354766 - Finish revert of r354706

Author: labath Date: Mon Feb 25 01:30:41 2019 New Revision: 354766 URL: http://llvm.org/viewvc/llvm-project?rev=354766&view=rev Log: Finish revert of r354706 The revert in r354711 wasn't complete. Finish the job. Modified: lldb/trunk/lit/ExecControl/StopHook/stop-hook.test Modified: lldb/tr

Re: [Lldb-commits] [PATCH] D58653: [Utility] Remove Triple{Environment, OS, Vendor}IsUnspecifiedUnknown from ArchSpec

On 26/02/2019 23:27, Greg Clayton via Phabricator wrote: clayborg added a comment. In D58653#1411285 , @aprantl wrote: @clayborg I recently ran into a similar issue and I think that perhaps adding explicit `llvm::Triple::Any{Vendor|OS|...}` enumerators

[Lldb-commits] [lldb] r354975 - Insert blocks of python code with swig instead of modify-python-lldb.py

Author: labath Date: Wed Feb 27 06:16:48 2019 New Revision: 354975 URL: http://llvm.org/viewvc/llvm-project?rev=354975&view=rev Log: Insert blocks of python code with swig instead of modify-python-lldb.py Summary: Swig is perfectly capable of inserting blocks of python code into its output (and w

[Lldb-commits] [lldb] r354976 - Remove XFAIL-Linux from two asan tests

Author: labath Date: Wed Feb 27 06:26:48 2019 New Revision: 354976 URL: http://llvm.org/viewvc/llvm-project?rev=354976&view=rev Log: Remove XFAIL-Linux from two asan tests It turns out these tests actually succeed, if one has a clang with address sanitizer support enabled (i.e., has enabled the c

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

On 28/02/2019 02:37, Davide Italiano via Phabricator wrote: davide added a comment. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. Pavel, this broke unicode handling for lldb on MacOS. If you type something in the lldb cmdline, it won't print the right character but a serie

[Lldb-commits] [lldb] r355103 - [cmake] Move LLDB_DISABLE_LIBEDIT handling code into a central place

Author: labath Date: Thu Feb 28 08:04:54 2019 New Revision: 355103 URL: http://llvm.org/viewvc/llvm-project?rev=355103&view=rev Log: [cmake] Move LLDB_DISABLE_LIBEDIT handling code into a central place This was previously scattered between the main CMakeLists.txt file and LLDBGenerateConfig.cmake

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

On 28/02/2019 16:18, Pavel Labath via lldb-commits wrote: On 28/02/2019 02:37, Davide Italiano via Phabricator wrote: davide added a comment. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. Pavel, this broke unicode handling for lldb on MacOS. If you type something in the

Re: [Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

On 28/02/2019 20:29, Davide Italiano wrote: On Thu, Feb 28, 2019 at 11:21 AM Davide Italiano wrote: On Thu, Feb 28, 2019 at 11:19 AM Davide Italiano wrote: If I add: diff --git a/lldb/source/Host/common/MainLoop.cpp b/lldb/source/Host/common/MainLoop.cpp index a4803936196..4fee76865ee 1006

[Lldb-commits] [lldb] r355270 - Fix gcc build for r355249

Author: labath Date: Sat Mar 2 08:23:07 2019 New Revision: 355270 URL: http://llvm.org/viewvc/llvm-project?rev=355270&view=rev Log: Fix gcc build for r355249 automatic move should not fire when returning type T in a function with result type Expected. Some compilers seem to allow that nonetheles

[Lldb-commits] [lldb] r355276 - Reinstate UNSUPPORTED: linux on stop-hook-threads.test

Author: labath Date: Sat Mar 2 11:58:10 2019 New Revision: 355276 URL: http://llvm.org/viewvc/llvm-project?rev=355276&view=rev Log: Reinstate UNSUPPORTED: linux on stop-hook-threads.test This stanza was removed in r355213, but it seems that patch did not fully fix the problem, as the test still

[Lldb-commits] [lldb] r355323 - Refactor user/group name resolving code

Author: labath Date: Mon Mar 4 10:48:00 2019 New Revision: 355323 URL: http://llvm.org/viewvc/llvm-project?rev=355323&view=rev Log: Refactor user/group name resolving code Summary: This creates an abstract base class called "UserIDResolver", which can be implemented to provide user/group ID reso

[Lldb-commits] [lldb] r355398 - One more UserIDResolver fix

Author: labath Date: Tue Mar 5 04:51:20 2019 New Revision: 355398 URL: http://llvm.org/viewvc/llvm-project?rev=355398&view=rev Log: One more UserIDResolver fix The intention in r355323 has been to implement a no-op resolver in the HostInfoBase class, which will then be shadowed a an implementati

Re: [Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

On 05/03/2019 17:19, Jonas Devlieghere wrote: Sounds good, I’ll make this change before landing, unless you have further comments? On Tue, Mar 5, 2019 at 4:29 AM Pavel Labath via Phabricator mailto:revi...@reviews.llvm.org>> wrote: labath added a comment. The copy constructors and a

Re: [Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

On 05/03/2019 17:58, Jonas Devlieghere wrote: On Tue, Mar 5, 2019 at 8:41 AM Pavel Labath > wrote: On 05/03/2019 17:19, Jonas Devlieghere wrote: > Sounds good, I’ll make this change before landing, unless you have > further comments? > > On Tue,

Re: [Lldb-commits] [lldb] r355469 - [Reproducers] Don't intercept SBDebugger::SetInputFileHandle

On 06/03/2019 02:49, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Tue Mar 5 17:49:54 2019 New Revision: 355469 URL: http://llvm.org/viewvc/llvm-project?rev=355469&view=rev Log: [Reproducers] Don't intercept SBDebugger::SetInputFileHandle With the reproducer logic in pla

[Lldb-commits] [lldb] r355509 - Move RangeMap.h into Utility

Author: labath Date: Wed Mar 6 06:41:43 2019 New Revision: 355509 URL: http://llvm.org/viewvc/llvm-project?rev=355509&view=rev Log: Move RangeMap.h into Utility Summary: This file implements some general purpose data structures, and so it belongs to the Utility module. Reviewers: zturner, jingh

[Lldb-commits] [lldb] r355817 - Fix invalid use of StringRef::data in Socket::DecodeHostAndPort

Author: labath Date: Mon Mar 11 03:34:57 2019 New Revision: 355817 URL: http://llvm.org/viewvc/llvm-project?rev=355817&view=rev Log: Fix invalid use of StringRef::data in Socket::DecodeHostAndPort the input StringRef is not guaranteed to be null-terminated, so using data to get the c string is wr

[Lldb-commits] [lldb] r355827 - Attempt to fix MSVC build error after r355824

Author: labath Date: Mon Mar 11 08:00:11 2019 New Revision: 355827 URL: http://llvm.org/viewvc/llvm-project?rev=355827&view=rev Log: Attempt to fix MSVC build error after r355824 Adding parens should be enough to fix the "'operator bool': is ambiguous or is not a member of 'lldb::SBFoo'" errors.

Re: [Lldb-commits] [lldb] r355998 - [Python] Fix another batch of python 2/python 3 portability issues.

On 13/03/2019 01:48, Davide Italiano via lldb-commits wrote: Author: davide Date: Tue Mar 12 17:48:29 2019 New Revision: 355998 URL: http://llvm.org/viewvc/llvm-project?rev=355998&view=rev Log: [Python] Fix another batch of python 2/python 3 portability issues. Modified: lldb/trunk/example

[Lldb-commits] [lldb] r356048 - Fix/unify SBType comparison

Author: labath Date: Wed Mar 13 06:45:14 2019 New Revision: 356048 URL: http://llvm.org/viewvc/llvm-project?rev=356048&view=rev Log: Fix/unify SBType comparison Summary: In my next step at cleaning up modify-python-lldb.py, I started focusing on equality comparison. To my surprise, I found out th

[Lldb-commits] [lldb] r356262 - Delete type_sp member from TypePair

Author: labath Date: Fri Mar 15 07:02:35 2019 New Revision: 356262 URL: http://llvm.org/viewvc/llvm-project?rev=356262&view=rev Log: Delete type_sp member from TypePair Summary: As discussed in the review of D59217, this member is unnecessary since always the first thing we do is convert it to a

[Lldb-commits] [lldb] r356263 - Fix a typo in FindLibEdit.cmake

Author: labath Date: Fri Mar 15 07:03:52 2019 New Revision: 356263 URL: http://llvm.org/viewvc/llvm-project?rev=356263&view=rev Log: Fix a typo in FindLibEdit.cmake The package name is LibEdit, so we should use that name in the call to find_package_handle_standard_args. Failing to do so results i

Re: [Lldb-commits] [lldb] r355103 - [cmake] Move LLDB_DISABLE_LIBEDIT handling code into a central place

On 14/03/2019 21:45, Nico Weber wrote: I tried LLVM_ENABLE_PROJECTS=all today, and it fails with CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: libedit_INCLUDE_DIRS

[Lldb-commits] [lldb] r356361 - Reinitialize UnwindTable when the SymbolFile changes

Author: labath Date: Mon Mar 18 03:45:02 2019 New Revision: 356361 URL: http://llvm.org/viewvc/llvm-project?rev=356361&view=rev Log: Reinitialize UnwindTable when the SymbolFile changes Summary: This is a preparatory step to enable adding of unwind plans by symbol file plugins. Although at the s

[Lldb-commits] [lldb] r356362 - Fix "type qualifiers ignored on cast result type" warnings

Author: labath Date: Mon Mar 18 03:50:46 2019 New Revision: 356362 URL: http://llvm.org/viewvc/llvm-project?rev=356362&view=rev Log: Fix "type qualifiers ignored on cast result type" warnings These warnings start to get emitted with gcc-8. Modified: lldb/trunk/source/Plugins/Process/minidump

[Lldb-commits] [lldb] r356370 - Fix TestCommandScriptImmediateOutput for python3

Author: labath Date: Mon Mar 18 07:13:12 2019 New Revision: 356370 URL: http://llvm.org/viewvc/llvm-project?rev=356370&view=rev Log: Fix TestCommandScriptImmediateOutput for python3 s/iteritems/items Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/command_script_immediat

[Lldb-commits] [lldb] r356377 - Fix libstdc++ data formatters for python3

Author: labath Date: Mon Mar 18 08:42:08 2019 New Revision: 356377 URL: http://llvm.org/viewvc/llvm-project?rev=356377&view=rev Log: Fix libstdc++ data formatters for python3 Use floor-division for consistentcy across python versions. This fixes a couple of libstdc++ data formatter tests. Modifi

[Lldb-commits] [lldb] r356378 - Fix some "variable 'foo' set but not used" warnings

Author: labath Date: Mon Mar 18 09:04:46 2019 New Revision: 356378 URL: http://llvm.org/viewvc/llvm-project?rev=356378&view=rev Log: Fix some "variable 'foo' set but not used" warnings gcc-8 diagnoses these. Modified: lldb/trunk/source/API/SBFrame.cpp lldb/trunk/source/API/SBTarget.cpp

[Lldb-commits] [lldb] r356379 - Skip TestVSCode_setFunctionBreakpoints on linux

Author: labath Date: Mon Mar 18 09:04:53 2019 New Revision: 356379 URL: http://llvm.org/viewvc/llvm-project?rev=356379&view=rev Log: Skip TestVSCode_setFunctionBreakpoints on linux Test hangs under heavy load. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/

[Lldb-commits] [lldb] r356459 - Fix a "memset clearing an object of non-trivial type" warning in EmulateInstruction

Author: labath Date: Tue Mar 19 08:05:55 2019 New Revision: 356459 URL: http://llvm.org/viewvc/llvm-project?rev=356459&view=rev Log: Fix a "memset clearing an object of non-trivial type" warning in EmulateInstruction This is a new warning which started appearing as of gcc-8. The Opcode class has

Re: [Lldb-commits] [lldb] r356643 - [Reproducers] Properly handle QEnvironment packets

On 21/03/2019 05:08, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Wed Mar 20 21:08:31 2019 New Revision: 356643 URL: http://llvm.org/viewvc/llvm-project?rev=356643&view=rev Log: [Reproducers] Properly handle QEnvironment packets On Linux, a QEnvironment packet is sent fo

[Lldb-commits] [lldb] r356751 - Extend r356573 (minidump UUID handling) to cover elf build-ids too

Author: labath Date: Fri Mar 22 07:03:59 2019 New Revision: 356751 URL: http://llvm.org/viewvc/llvm-project?rev=356751&view=rev Log: Extend r356573 (minidump UUID handling) to cover elf build-ids too Breakpad (but not crashpad) will insert an empty (all-zero) build-id record for modules which do

[Lldb-commits] [lldb] r356773 - Revert "Move the rest of the sections over to DWARFContext."

Author: labath Date: Fri Mar 22 09:07:58 2019 New Revision: 356773 URL: http://llvm.org/viewvc/llvm-project?rev=356773&view=rev Log: Revert "Move the rest of the sections over to DWARFContext." This reverts commit r356682 because it breaks the DWO flavours of some tests: lldb-Suite :: lang/c/

[Lldb-commits] [lldb] r356896 - Reapply minidump changes reverted in r356806

Author: labath Date: Mon Mar 25 07:02:16 2019 New Revision: 356896 URL: http://llvm.org/viewvc/llvm-project?rev=356896&view=rev Log: Reapply minidump changes reverted in r356806 The changes were reverted due to ubsan errors (unaligned accesses). Here I fix those errors by first copying the data i

[Lldb-commits] [lldb] r356898 - Minidump: Use minidump constants defined in llvm

Author: labath Date: Mon Mar 25 07:09:27 2019 New Revision: 356898 URL: http://llvm.org/viewvc/llvm-project?rev=356898&view=rev Log: Minidump: Use minidump constants defined in llvm This patch begins the process of migrating the "minidump" plugin to the minidump parser in llvm. The llvm parser is

[Lldb-commits] [lldb] r356992 - Minidump: Use minidump types defined in llvm

Author: labath Date: Tue Mar 26 06:23:01 2019 New Revision: 356992 URL: http://llvm.org/viewvc/llvm-project?rev=356992&view=rev Log: Minidump: Use minidump types defined in llvm This is the next step in moving the minidump parsing into llvm. I remove the minidump structures already defined in the

[Lldb-commits] [lldb] r356993 - Remove the TypePair class

Author: labath Date: Tue Mar 26 06:35:54 2019 New Revision: 356993 URL: http://llvm.org/viewvc/llvm-project?rev=356993&view=rev Log: Remove the TypePair class Summary: After D59297, the TypePair class kind of lost its purpose as it was no longer a "pair". This finishes the job started in that pat

Re: [Lldb-commits] [lldb] r357034 - [Python] Remove dynamic indirection

Wohoo. On 26/03/2019 23:51, Davide Italiano via lldb-commits wrote: This is great! On Tue, Mar 26, 2019 at 2:55 PM Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Tue Mar 26 14:57:02 2019 New Revision: 357034 URL: http://llvm.org/viewvc/llvm-project?rev=357034&view=rev

[Lldb-commits] [lldb] r357055 - Fix an out-of-bounds error in RegisterContextDarwin_arm64

Author: labath Date: Wed Mar 27 02:39:46 2019 New Revision: 357055 URL: http://llvm.org/viewvc/llvm-project?rev=357055&view=rev Log: Fix an out-of-bounds error in RegisterContextDarwin_arm64 Summary: gcc diagnoses this as "array subscript 63 is above array bounds of 'RegisterContextDarwin_arm64::

[Lldb-commits] [lldb] r357056 - Fix a "memset clearing an object of non-trivial type" warning in DWARFFormValue

Author: labath Date: Wed Mar 27 03:02:36 2019 New Revision: 357056 URL: http://llvm.org/viewvc/llvm-project?rev=357056&view=rev Log: Fix a "memset clearing an object of non-trivial type" warning in DWARFFormValue This is diagnosed by gcc-8. The ValueType struct already has a default constructor w

[Lldb-commits] [lldb] r357060 - minidump: Add ability to attach (breakpad) symbol files to placeholder modules

Author: labath Date: Wed Mar 27 03:54:10 2019 New Revision: 357060 URL: http://llvm.org/viewvc/llvm-project?rev=357060&view=rev Log: minidump: Add ability to attach (breakpad) symbol files to placeholder modules This re-commits r354263, which was because it uncovered with handling of modules with

[Lldb-commits] [lldb] r357080 - Rename some variables in the std-module tests

Author: labath Date: Wed Mar 27 08:52:11 2019 New Revision: 357080 URL: http://llvm.org/viewvc/llvm-project?rev=357080&view=rev Log: Rename some variables in the std-module tests They cause failures on some systems due to an unrelated bug (pr35043). This works around that. Modified: lldb/tr

Re: [Lldb-commits] [lldb] r357141 - Copy the breakpoint site owner's collection so we can drop

On 28/03/2019 02:54, Davide Italiano via lldb-commits wrote: On Wed, Mar 27, 2019 at 6:49 PM Jim Ingham via lldb-commits wrote: Author: jingham Date: Wed Mar 27 18:51:33 2019 New Revision: 357141 URL: http://llvm.org/viewvc/llvm-project?rev=357141&view=rev Log: Copy the breakpoint site owner'

[Lldb-commits] [lldb] r357376 - [Linux/x86] Fix writing of non-gpr registers on newer processors

Author: labath Date: Mon Apr 1 01:11:46 2019 New Revision: 357376 URL: http://llvm.org/viewvc/llvm-project?rev=357376&view=rev Log: [Linux/x86] Fix writing of non-gpr registers on newer processors Summary: We're using ptrace(PTRACE_SETREGSET, NT_X86_XSTATE) to write all non-gpt registers on x86

[Lldb-commits] [lldb] r357451 - Simplify TestGdbRemoteRegisterState

Author: labath Date: Tue Apr 2 00:47:38 2019 New Revision: 357451 URL: http://llvm.org/viewvc/llvm-project?rev=357451&view=rev Log: Simplify TestGdbRemoteRegisterState While reviewing D56233 it became clear to me that this test can be simplified. There's no need for a start-stop cycle in the inf

[Lldb-commits] [lldb] r357455 - PDBFPO: Refactor register reference resolution

Author: labath Date: Tue Apr 2 01:44:24 2019 New Revision: 357455 URL: http://llvm.org/viewvc/llvm-project?rev=357455&view=rev Log: PDBFPO: Refactor register reference resolution Summary: This refactors moves the register name->number resolution out of the FPOProgramNodeRegisterRef class. Instea

[Lldb-commits] [lldb] r357456 - Fix llvm_unreachable in TestWriteMemory

Author: labath Date: Tue Apr 2 01:56:22 2019 New Revision: 357456 URL: http://llvm.org/viewvc/llvm-project?rev=357456&view=rev Log: Fix llvm_unreachable in TestWriteMemory The test was hitting llvm_unreachable in Platform::GetSoftwareBreakpointTrapOpcode because it could not figure out the archi

[Lldb-commits] [lldb] r357459 - Fix flakyness in TestCommandScriptImmediateOutput

Author: labath Date: Tue Apr 2 02:45:40 2019 New Revision: 357459 URL: http://llvm.org/viewvc/llvm-project?rev=357459&view=rev Log: Fix flakyness in TestCommandScriptImmediateOutput I'm not sure why this surfaced at this particular point, but TestCommandScriptImmediateOutput (a pexpect test) had

[Lldb-commits] [lldb] r357463 - Make operator==s consistent between c++ and python APIs

Author: labath Date: Tue Apr 2 03:18:46 2019 New Revision: 357463 URL: http://llvm.org/viewvc/llvm-project?rev=357463&view=rev Log: Make operator==s consistent between c++ and python APIs Summary: modify-python-lldb.py had code to insert python equality operators to some classes. Some of those c

[Lldb-commits] [lldb] r357572 - modify-python-lldb.py: clean up __iter__ and __len__ support

Author: labath Date: Wed Apr 3 04:48:38 2019 New Revision: 357572 URL: http://llvm.org/viewvc/llvm-project?rev=357572&view=rev Log: modify-python-lldb.py: clean up __iter__ and __len__ support Summary: Instead of modifying the swig-generated code, just add the appropriate methods to the interfac

[Lldb-commits] [lldb] r357680 - modify-python-lldb.py: (Re)move __len__ and __iter__ support

Author: labath Date: Thu Apr 4 03:13:59 2019 New Revision: 357680 URL: http://llvm.org/viewvc/llvm-project?rev=357680&view=rev Log: modify-python-lldb.py: (Re)move __len__ and __iter__ support Summary: This patch moves the modify-python-lldb code for adding new functions to the SBModule class in

[Lldb-commits] [lldb] r357691 - Breakpad: Refine record classification code

Author: labath Date: Thu Apr 4 06:23:25 2019 New Revision: 357691 URL: http://llvm.org/viewvc/llvm-project?rev=357691&view=rev Log: Breakpad: Refine record classification code Previously we would classify all STACK records into a single bucket. This is not really helpful, because there are three

[Lldb-commits] [lldb] r357744 - PDBFPO: Use references instead of pointers, where possible

Author: labath Date: Fri Apr 5 00:28:52 2019 New Revision: 357744 URL: http://llvm.org/viewvc/llvm-project?rev=357744&view=rev Log: PDBFPO: Use references instead of pointers, where possible Summary: The code was passing pointers around, expecting they would be not null. In c++ it is possible to

[Lldb-commits] [lldb] r357747 - TestVCCode_step: replace assertTrue with more specific assertions

Author: labath Date: Fri Apr 5 00:56:26 2019 New Revision: 357747 URL: http://llvm.org/viewvc/llvm-project?rev=357747&view=rev Log: TestVCCode_step: replace assertTrue with more specific assertions When this test fails (flakes) all we get is an error message like "False is not True". This replac

[Lldb-commits] [lldb] r357748 - MinidumpParser: use minidump parser in llvm/Object

Author: labath Date: Fri Apr 5 00:56:39 2019 New Revision: 357748 URL: http://llvm.org/viewvc/llvm-project?rev=357748&view=rev Log: MinidumpParser: use minidump parser in llvm/Object This patch removes the lower layers of the minidump parsing code from the MinidumpParser class, and replaces it w

[Lldb-commits] [lldb] r357755 - modify-python-lldb.py: Insert initialization code with swig instead

Author: labath Date: Fri Apr 5 02:56:55 2019 New Revision: 357755 URL: http://llvm.org/viewvc/llvm-project?rev=357755&view=rev Log: modify-python-lldb.py: Insert initialization code with swig instead This is the last functional change to the generated python module being done by modify-python-ll

[Lldb-commits] [lldb] r357890 - modify-python-lldb.py: Remove ifdef SWIG-removing code

Author: labath Date: Mon Apr 8 01:43:07 2019 New Revision: 357890 URL: http://llvm.org/viewvc/llvm-project?rev=357890&view=rev Log: modify-python-lldb.py: Remove ifdef SWIG-removing code There are no patterns like that in the generated swig files (there probably were some back in the days when w

[Lldb-commits] [lldb] r357893 - Fix signed-unsigned comparison warning in Driver.cpp

Author: labath Date: Mon Apr 8 02:17:56 2019 New Revision: 357893 URL: http://llvm.org/viewvc/llvm-project?rev=357893&view=rev Log: Fix signed-unsigned comparison warning in Driver.cpp Modified: lldb/trunk/tools/driver/Driver.cpp Modified: lldb/trunk/tools/driver/Driver.cpp URL: http://llv

[Lldb-commits] [lldb] r357895 - PDBFPO: add dyn_cast support

Author: labath Date: Mon Apr 8 02:52:57 2019 New Revision: 357895 URL: http://llvm.org/viewvc/llvm-project?rev=357895&view=rev Log: PDBFPO: add dyn_cast support This adds the necessary glue so we can use llvm::dyn_cast, instead of doing a manual type-check followed by a cast. NFC. Modified:

[Lldb-commits] [lldb] r357896 - MinidumpParser: parse SystemInfo stream via llvm

Author: labath Date: Mon Apr 8 02:53:03 2019 New Revision: 357896 URL: http://llvm.org/viewvc/llvm-project?rev=357896&view=rev Log: MinidumpParser: parse SystemInfo stream via llvm I also update the tests for SystemInfo parsing to use the yaml2minidump capabilities in llvm instead of relying on

[Lldb-commits] [lldb] r357975 - Breakpad: Parse Stack CFI records

Author: labath Date: Tue Apr 9 01:05:11 2019 New Revision: 357975 URL: http://llvm.org/viewvc/llvm-project?rev=357975&view=rev Log: Breakpad: Parse Stack CFI records Summary: This patch adds support for parsing STACK CFI records from breakpad files. The expressions specifying the values of regis

[Lldb-commits] [lldb] r357977 - Minidump: use string parsing functionality from llvm

Author: labath Date: Tue Apr 9 01:28:27 2019 New Revision: 357977 URL: http://llvm.org/viewvc/llvm-project?rev=357977&view=rev Log: Minidump: use string parsing functionality from llvm Modified: lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp lldb/trunk/source/Plugins/Proce

[Lldb-commits] [lldb] r357984 - Remove unneeded #ifdef SWIGs

Author: labath Date: Tue Apr 9 02:03:43 2019 New Revision: 357984 URL: http://llvm.org/viewvc/llvm-project?rev=357984&view=rev Log: Remove unneeded #ifdef SWIGs Summary: Some of these were present in files which should never be read by swig (and we also had one in the interface file, which is on

[Lldb-commits] [lldb] r358055 - Docstringify some comments in the swig interface files

Author: labath Date: Wed Apr 10 00:55:04 2019 New Revision: 358055 URL: http://llvm.org/viewvc/llvm-project?rev=358055&view=rev Log: Docstringify some comments in the swig interface files Without these, the comments don't end up in the generated python code. Modified: lldb/trunk/scripts/inte

[Lldb-commits] [lldb] r358070 - Minidump: Use llvm parser for reading the ModuleList stream

Author: labath Date: Wed Apr 10 04:07:28 2019 New Revision: 358070 URL: http://llvm.org/viewvc/llvm-project?rev=358070&view=rev Log: Minidump: Use llvm parser for reading the ModuleList stream In this patch, I just remove the structure definitions for the ModuleList stream and the associated pars

[Lldb-commits] [lldb] r358169 - Minidump: extend UUID byte-swapping to windows platform

Author: labath Date: Thu Apr 11 07:14:07 2019 New Revision: 358169 URL: http://llvm.org/viewvc/llvm-project?rev=358169&view=rev Log: Minidump: extend UUID byte-swapping to windows platform Summary: D59433 added code to swap bytes UUIDs coming from minidump files, but only enabled it for apple pla

[Lldb-commits] [lldb] r358261 - PDBFPO: Improvements to the AST visitor

Author: labath Date: Fri Apr 12 00:19:00 2019 New Revision: 358261 URL: http://llvm.org/viewvc/llvm-project?rev=358261&view=rev Log: PDBFPO: Improvements to the AST visitor Summary: This patch attempts to solve two issues made this code hard to follow for me. The first issue was that a lot of wh

[Lldb-commits] [lldb] r358266 - Make TestPrintStackTraces deterministic

Author: labath Date: Fri Apr 12 01:02:28 2019 New Revision: 358266 URL: http://llvm.org/viewvc/llvm-project?rev=358266&view=rev Log: Make TestPrintStackTraces deterministic This test contained an incredibly complicated inferior, but in reality, all it was testing was that we can backtrace up to m

<    3   4   5   6   7   8   9   10   11   12   >