[Lldb-commits] [lldb] r332255 - Fix macosx build broken by r332250

Author: labath Date: Mon May 14 09:01:49 2018 New Revision: 332255 URL: http://llvm.org/viewvc/llvm-project?rev=332255&view=rev Log: Fix macosx build broken by r332250 Modified: lldb/trunk/source/Host/macosx/Host.mm Modified: lldb/trunk/source/Host/macosx/Host.mm URL: http://llvm.org/viewvc

[Lldb-commits] [lldb] r332261 - Revert "Remove Process references from the Host module"

Author: labath Date: Mon May 14 09:54:53 2018 New Revision: 332261 URL: http://llvm.org/viewvc/llvm-project?rev=332261&view=rev Log: Revert "Remove Process references from the Host module" The first fix wasn't enough, there is still a missing ProcessInstanceInfo include in Host.mm. I won't be abl

[Lldb-commits] [lldb] r332353 - Reapply "Remove Process references from the Host module"

Author: labath Date: Tue May 15 06:42:26 2018 New Revision: 332353 URL: http://llvm.org/viewvc/llvm-project?rev=332353&view=rev Log: Reapply "Remove Process references from the Host module" This re-lands r332250/D46395, after fixing Mac build errors. Modified: lldb/trunk/include/lldb/Host/Ho

[Lldb-commits] [lldb] r332596 - [DWARF] Have HashedNameToDIE store a DataExtractor by value

Author: labath Date: Thu May 17 04:36:08 2018 New Revision: 332596 URL: http://llvm.org/viewvc/llvm-project?rev=332596&view=rev Log: [DWARF] Have HashedNameToDIE store a DataExtractor by value Summary: The DataExtractors are cheap to copy so there is no reason to store them by reference. Also, in

Re: [Lldb-commits] [PATCH] D46783: FileSpec objects that resolve to "." should have "." in m_filename and m_directory empty.

This has broken the unit tests. Looks like a bad merge that did not take into account the refactoring in r332088. On Thu, 17 May 2018 at 17:16, Phabricator via Phabricator < revi...@reviews.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by com

[Lldb-commits] [lldb] r332702 - Make ObjectFileMachO work on non-darwin platforms

Author: labath Date: Fri May 18 04:35:46 2018 New Revision: 332702 URL: http://llvm.org/viewvc/llvm-project?rev=332702&view=rev Log: Make ObjectFileMachO work on non-darwin platforms Summary: Before this patch we were unable to write cross-platform MachO tests because the parsing code did not com

[Lldb-commits] [lldb] r332710 - Add back #ifdef __APPLE__ to RegisterContextDarwin_xxx::NumSupportedHardwareWatchpoints

Author: labath Date: Fri May 18 05:54:21 2018 New Revision: 332710 URL: http://llvm.org/viewvc/llvm-project?rev=332710&view=rev Log: Add back #ifdef __APPLE__ to RegisterContextDarwin_xxx::NumSupportedHardwareWatchpoints It turns out these class still contained some os-specific functionality, bu

[Lldb-commits] [lldb] r332719 - [DWARF] Extract indexing code into a separate class hierarchy

Author: labath Date: Fri May 18 07:15:46 2018 New Revision: 332719 URL: http://llvm.org/viewvc/llvm-project?rev=332719&view=rev Log: [DWARF] Extract indexing code into a separate class hierarchy Summary: This places the `if(m_using_apple_tables)` branches inside the SymbolFileDWARF class behind a

[Lldb-commits] [lldb] r332831 - Add some apple-tables lookup tests

Author: labath Date: Mon May 21 02:27:16 2018 New Revision: 332831 URL: http://llvm.org/viewvc/llvm-project?rev=332831&view=rev Log: Add some apple-tables lookup tests Summary: Now that we are able to parse MachO files everywhere, we can write some cross-platform tests for handling of apple accel

[Lldb-commits] [lldb] r332833 - Improve coverage of the apple-tables test

Author: labath Date: Mon May 21 03:09:22 2018 New Revision: 332833 URL: http://llvm.org/viewvc/llvm-project?rev=332833&view=rev Log: Improve coverage of the apple-tables test After closer examination, it turns out we mis-classify one of the methods only if two of the structs have the same name. S

[Lldb-commits] [lldb] r332841 - Reland "[DWARF] Extract indexing code into a separate class hierarchy"

Author: labath Date: Mon May 21 07:12:52 2018 New Revision: 332841 URL: http://llvm.org/viewvc/llvm-project?rev=332841&view=rev Log: Reland "[DWARF] Extract indexing code into a separate class hierarchy" After this commit, the xcode project will need to be updated to include the new files added h

Re: [Lldb-commits] [lldb] r332922 - Work around some odd instruction single-step behavior on macOS.

This probably isn't what was happening here because you would have seen the extra stops in the logs, but one way I can think of we can end up at the same PC is if the process gets a signal while we're about to single-step it, in which case we need to execute the signal handler first and then get ba

[Lldb-commits] [lldb] r332997 - Enable ProcessMachCore plugin on non-apple platforms

Author: labath Date: Tue May 22 09:33:43 2018 New Revision: 332997 URL: http://llvm.org/viewvc/llvm-project?rev=332997&view=rev Log: Enable ProcessMachCore plugin on non-apple platforms Summary: The plugin already builds fine on other platforms (linux, at least). All that was necessary was to rev

Re: [Lldb-commits] [lldb] r332922 - Work around some odd instruction single-step behavior on macOS.

> > On May 22, 2018, at 9:37 AM, Jim Ingham wrote: > > > > I haven't played around with this yet. Can it also provide enough memory to pretend a stack trace? Most of the thread plan stuff will fall over pretty early if it doesn't have at least a couple of frames? You can do anything, but there

Re: [Lldb-commits] [lldb] r332111 - HostInfoMacOSX: Share the clang resource directory with Swift.

Btw, r333032 gave me an idea. We already have unittests/Host/linux/*** to contain linux-specific host tests (although one of them maybe shouldn't be there). What would you say to moving this test to unittests/Host/macosx so we can avoid the #ifdefs? On Fri, 11 May 2018 at 18:57, Adrian Prantl via l

[Lldb-commits] [lldb] r333073 - ProcessLauncherPosixFork: move setgid call into the if(debug) branch

Author: labath Date: Wed May 23 03:10:36 2018 New Revision: 333073 URL: http://llvm.org/viewvc/llvm-project?rev=333073&view=rev Log: ProcessLauncherPosixFork: move setgid call into the if(debug) branch This call was originally being only made when launching for debug (as an attempt to make sure w

[Lldb-commits] [lldb] r333074 - Fix PathMappingList tests on windows

Author: labath Date: Wed May 23 03:32:05 2018 New Revision: 333074 URL: http://llvm.org/viewvc/llvm-project?rev=333074&view=rev Log: Fix PathMappingList tests on windows The tests added in r332842 don't work on windows, because they do path comparisons on strings, and on windows, the paths coming

[Lldb-commits] [lldb] r333173 - Add PPC64le support information

Author: labath Date: Thu May 24 04:17:02 2018 New Revision: 333173 URL: http://llvm.org/viewvc/llvm-project?rev=333173&view=rev Log: Add PPC64le support information Summary: Add PPC64le support information on LLDB site Reviewers: clayborg Reviewed By: clayborg Subscribers: labath, lldb-commits

[Lldb-commits] [lldb] r333178 - DWARF: Move indexing code from DWARFUnit to ManualDWARFIndex

Author: labath Date: Thu May 24 05:12:49 2018 New Revision: 333178 URL: http://llvm.org/viewvc/llvm-project?rev=333178&view=rev Log: DWARF: Move indexing code from DWARFUnit to ManualDWARFIndex Summary: I think this makes sense for several reasons: - better separation of concerns: DWARFUnit's job

[Lldb-commits] [lldb] r333182 - Move ObjectFile initialization out of SystemInitializerCommon

Author: labath Date: Thu May 24 05:44:18 2018 New Revision: 333182 URL: http://llvm.org/viewvc/llvm-project?rev=333182&view=rev Log: Move ObjectFile initialization out of SystemInitializerCommon Summary: For lldb-server, it is sufficient to parse only the native object file format for its target

[Lldb-commits] [lldb] r333183 - Fix windows/mac builds broken by r333182.

Author: labath Date: Thu May 24 06:12:07 2018 New Revision: 333183 URL: http://llvm.org/viewvc/llvm-project?rev=333183&view=rev Log: Fix windows/mac builds broken by r333182. I should've known that something was wrong when only one of my plugins was prefixed by the lldb_private namespace. Modifi

[Lldb-commits] [lldb] r333264 - ManualDWARFIndex: reduce long parameter lists

Author: labath Date: Fri May 25 02:55:51 2018 New Revision: 333264 URL: http://llvm.org/viewvc/llvm-project?rev=333264&view=rev Log: ManualDWARFIndex: reduce long parameter lists Several functions were passing a list of 8 NameToDIE arguments around. This puts those variables in a struct and passe

[Lldb-commits] [lldb] r333266 - ManualDWARFIndex: Fix misclassification of methods in unions

Author: labath Date: Fri May 25 03:49:11 2018 New Revision: 333266 URL: http://llvm.org/viewvc/llvm-project?rev=333266&view=rev Log: ManualDWARFIndex: Fix misclassification of methods in unions Apple index was already treating them as methods. Not doing the same seems like an omission. Added:

[Lldb-commits] [lldb] r333398 - ManualDWARFIndex: Treat DW_TAG_subprogram and DW_TAG_inlined_subroutine the same way

Author: labath Date: Tue May 29 01:16:22 2018 New Revision: 98 URL: http://llvm.org/viewvc/llvm-project?rev=98&view=rev Log: ManualDWARFIndex: Treat DW_TAG_subprogram and DW_TAG_inlined_subroutine the same way Summary: We were treating subprograms and inlined subroutines differently when

[Lldb-commits] [lldb] r333401 - XFAIL TestMachCore for windows hosts

Author: labath Date: Tue May 29 02:22:58 2018 New Revision: 333401 URL: http://llvm.org/viewvc/llvm-project?rev=333401&view=rev Log: XFAIL TestMachCore for windows hosts It's been failing since I enabled the test for non-darwin targets. I made it reference the same bug as the linux core, as it's

[Lldb-commits] [lldb] r333526 - @skipUnlessDarwin TestOrderedSet

Author: labath Date: Wed May 30 03:04:32 2018 New Revision: 333526 URL: http://llvm.org/viewvc/llvm-project?rev=333526&view=rev Log: @skipUnlessDarwin TestOrderedSet Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/orderedset/TestOrderedSet.py Modified: lldb/trunk/packages/Pyt

Re: [Lldb-commits] [lldb] r333465 - [ObjC] Fix the formatter for NSOrderedSet.

I've added a @skipUnlessDarwin to the new test. Right now we don't have the ability to build or run ObjC tests on other platforms. On Tue, 29 May 2018 at 23:57, Davide Italiano via lldb-commits wrote: > > I would like to apologize, I forgot to `git add `the Makefile and this > broke the bots. It s

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

I hate to resurrect an old thread, but there has been a new spurt of this discussion about this patch here . I think I have an idea on how to improve things slightly for us here, but as I know very little about this issue, I'd like someone to take a look at this

[Lldb-commits] [lldb] r333639 - Remove append parameter to FindGlobalVariables

Author: labath Date: Thu May 31 02:46:26 2018 New Revision: 333639 URL: http://llvm.org/viewvc/llvm-project?rev=333639&view=rev Log: Remove append parameter to FindGlobalVariables Summary: As discussed in https://bugs.llvm.org/show_bug.cgi?id=37317, FindGlobalVariables does not properly handle th

[Lldb-commits] [lldb] r333640 - Remove the TestSequenceFunctions "example" test

Author: labath Date: Thu May 31 02:56:38 2018 New Revision: 333640 URL: http://llvm.org/viewvc/llvm-project?rev=333640&view=rev Log: Remove the TestSequenceFunctions "example" test This test was using unittest (not unittest2) as the test framework, and it worked with dotest only by accident. Remo

Re: [Lldb-commits] [lldb] r333700 - [IRMemoryMap] Test interleaved Mallocs and Frees

On Thu, 31 May 2018 at 23:13, Vedant Kumar via lldb-commits wrote: > > Author: vedantk > Date: Thu May 31 15:09:01 2018 > New Revision: 333700 > > URL: http://llvm.org/viewvc/llvm-project?rev=333700&view=rev > Log: > [IRMemoryMap] Test interleaved Mallocs and Frees > > This adds a new command to t

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

Thanks for confirming that. I have created which tries to implement this. Could you take quick look at that? There is one particular question about EL_CLIENTDATA that I would like to hear your thoughts on. On Thu, 31 May 2018 at 12:47, Christos Zoulas wrote: > > O

[Lldb-commits] [lldb] r333743 - Add .debug_names section glue code

Author: labath Date: Fri Jun 1 05:06:45 2018 New Revision: 333743 URL: http://llvm.org/viewvc/llvm-project?rev=333743&view=rev Log: Add .debug_names section glue code Modified: lldb/trunk/include/lldb/lldb-enumerations.h lldb/trunk/lit/Modules/elf-section-types.yaml lldb/trunk/source

[Lldb-commits] [lldb] r333878 - AppleDWARFIndex: Get function method-ness directly from debug info

Author: labath Date: Mon Jun 4 02:05:27 2018 New Revision: 333878 URL: http://llvm.org/viewvc/llvm-project?rev=333878&view=rev Log: AppleDWARFIndex: Get function method-ness directly from debug info Summary: When searching for methods only, we need to do extra work to make sure the functions we

[Lldb-commits] [lldb] r333992 - Fix ClangParserTest.cpp

Author: labath Date: Tue Jun 5 02:33:26 2018 New Revision: 333992 URL: http://llvm.org/viewvc/llvm-project?rev=333992&view=rev Log: Fix ClangParserTest.cpp The test does not use a test fixture, so it needs to be declared with the TEST macro. Modified: lldb/trunk/unittests/Expression/ClangPa

[Lldb-commits] [lldb] r333996 - Fixup r333987

Author: labath Date: Tue Jun 5 02:56:14 2018 New Revision: 333996 URL: http://llvm.org/viewvc/llvm-project?rev=333996&view=rev Log: Fixup r333987 - add #include (fixes windows build) - remove std::move (fixes "using move prevents copy ellision" warnings) Modified: lldb/trunk/source/Plugins

[Lldb-commits] [lldb] r334003 - Really fix ClangParserTest

Author: labath Date: Tue Jun 5 03:29:48 2018 New Revision: 334003 URL: http://llvm.org/viewvc/llvm-project?rev=334003&view=rev Log: Really fix ClangParserTest It turns out the test needs a fixture after all (to initialize HostInfo), so provide one that does that. Modified: lldb/trunk/unitte

[Lldb-commits] [lldb] r334004 - DWARFIndex: simplify GetFunctions methods

Author: labath Date: Tue Jun 5 03:33:56 2018 New Revision: 334004 URL: http://llvm.org/viewvc/llvm-project?rev=334004&view=rev Log: DWARFIndex: simplify GetFunctions methods Now that Apple index determines method-ness straight from the debug info, we don't need to resolve the functions into Symb

[Lldb-commits] [lldb] r334006 - Fix windows build broken by r334004

Author: labath Date: Tue Jun 5 03:49:56 2018 New Revision: 334006 URL: http://llvm.org/viewvc/llvm-project?rev=334006&view=rev Log: Fix windows build broken by r334004 The problem was a link error due to a missing =0 on an abstract method. Interestingly, this was not a problem for clang/linux.

[Lldb-commits] [lldb] r334009 - dotest: make inline tests compatible with -f

Author: labath Date: Tue Jun 5 03:58:44 2018 New Revision: 334009 URL: http://llvm.org/viewvc/llvm-project?rev=334009&view=rev Log: dotest: make inline tests compatible with -f Summary: This is split off from D47265 where I needed to be able to invoke every test with -f. That patch is kinda dead

[Lldb-commits] [lldb] r334012 - DWARFIndex: more GetFunctions cleanup

Author: labath Date: Tue Jun 5 05:13:22 2018 New Revision: 334012 URL: http://llvm.org/viewvc/llvm-project?rev=334012&view=rev Log: DWARFIndex: more GetFunctions cleanup This applies similar simplification as r334004, only it touches the regex version of the method. Modified: lldb/trunk/sou

[Lldb-commits] [lldb] r334076 - Revert "PDB support of function-level linking and splitted functions"

Author: labath Date: Wed Jun 6 02:16:00 2018 New Revision: 334076 URL: http://llvm.org/viewvc/llvm-project?rev=334076&view=rev Log: Revert "PDB support of function-level linking and splitted functions" This reverts commit r334030 because it adds a broken test. Removed: lldb/trunk/unittests

[Lldb-commits] [lldb] r334088 - [DWARF] Add (empty) DebugNamesDWARFIndex class and a setting to control its use

Author: labath Date: Wed Jun 6 04:35:23 2018 New Revision: 334088 URL: http://llvm.org/viewvc/llvm-project?rev=334088&view=rev Log: [DWARF] Add (empty) DebugNamesDWARFIndex class and a setting to control its use Summary: This patch adds the skeleton for implementing the DWARF v5 name index class

[Lldb-commits] [lldb] r334181 - DebugNamesDWARFIndex: Add ability to lookup variables

Author: labath Date: Thu Jun 7 03:04:44 2018 New Revision: 334181 URL: http://llvm.org/viewvc/llvm-project?rev=334181&view=rev Log: DebugNamesDWARFIndex: Add ability to lookup variables Summary: This patch adds the ability to lookup variables to the DWARF v5 index class. During review we discov

[Lldb-commits] [lldb] r334185 - DebugNamesDWARFIndex: Add support for partial indexes

Author: labath Date: Thu Jun 7 03:35:28 2018 New Revision: 334185 URL: http://llvm.org/viewvc/llvm-project?rev=334185&view=rev Log: DebugNamesDWARFIndex: Add support for partial indexes Summary: It possible that a single module has indexed and non-indexed compile units. In this case, we can use

[Lldb-commits] [lldb] r334186 - DebugNamesDWARFIndex: add namespace lookup support

Author: labath Date: Thu Jun 7 03:56:16 2018 New Revision: 334186 URL: http://llvm.org/viewvc/llvm-project?rev=334186&view=rev Log: DebugNamesDWARFIndex: add namespace lookup support Modified: lldb/trunk/lit/SymbolFile/DWARF/find-basic-namespace.cpp lldb/trunk/source/Plugins/SymbolFile/D

[Lldb-commits] [lldb] r334190 - DebugNamesDWARFIndex: Add type lookup suport

Author: labath Date: Thu Jun 7 05:26:18 2018 New Revision: 334190 URL: http://llvm.org/viewvc/llvm-project?rev=334190&view=rev Log: DebugNamesDWARFIndex: Add type lookup suport This implements just one of the GetTypes overloads. The other is not testable from lldb-test so I'm leaving it unimplem

[Lldb-commits] [lldb] r334198 - DIERef: move trivial constructors into the header

Author: labath Date: Thu Jun 7 07:03:30 2018 New Revision: 334198 URL: http://llvm.org/viewvc/llvm-project?rev=334198&view=rev Log: DIERef: move trivial constructors into the header This enables more inlining/optimization opportunities for a fairly critical class. NFCI Modified: lldb/trunk

[Lldb-commits] [lldb] r334273 - DebugNamesDWARFIndex: Implement GetFunctions method

Author: labath Date: Fri Jun 8 02:10:31 2018 New Revision: 334273 URL: http://llvm.org/viewvc/llvm-project?rev=334273&view=rev Log: DebugNamesDWARFIndex: Implement GetFunctions method Summary: This patch implements the non-regex variant of GetFunctions. To share more code with the Apple implemen

[Lldb-commits] [lldb] r334277 - DebugNamesDWARFIndex: Implement regex version of the GetFunctions method

Author: labath Date: Fri Jun 8 03:31:55 2018 New Revision: 334277 URL: http://llvm.org/viewvc/llvm-project?rev=334277&view=rev Log: DebugNamesDWARFIndex: Implement regex version of the GetFunctions method This also fixes a bug where SymbolFileDWARF was returning the same function multiple times

[Lldb-commits] [lldb] r334279 - Fix TestMiExec.py

Author: labath Date: Fri Jun 8 03:39:55 2018 New Revision: 334279 URL: http://llvm.org/viewvc/llvm-project?rev=334279&view=rev Log: Fix TestMiExec.py r334215 changed the error message the tool prints for invalid thread arguments to -exec-next command. This adjust the test to match that. Modifie

Re: [Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

On Fri, 8 Jun 2018 at 18:48, Leonard Mosescu wrote: > > So what's your take on this particular case? As far as I can see (please > correct me if I'm wrong), the LIT-only tests: > > 1. Don't cover the case where a function is split into disjoint regions, > right? For this particular case, I don'

Re: [Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

On Fri, 8 Jun 2018 at 19:58, Zachary Turner wrote: > > > > On Fri, Jun 8, 2018 at 11:52 AM Pavel Labath wrote: >> >> On Fri, 8 Jun 2018 at 18:48, Leonard Mosescu wrote: >> > >> > To me, a linker order file (of any linker) sounds like a good >> abstraction level for generating that kind of input

[Lldb-commits] [lldb] r334393 - [cmake] Detect presence of wide-char libedit at build time

Author: labath Date: Mon Jun 11 02:14:26 2018 New Revision: 334393 URL: http://llvm.org/viewvc/llvm-project?rev=334393&view=rev Log: [cmake] Detect presence of wide-char libedit at build time Summary: Instead of hardcoding a list of platforms where libedit is known to have wide char support we de

[Lldb-commits] [lldb] r334397 - Editline: make #include conditional

Author: labath Date: Mon Jun 11 02:32:58 2018 New Revision: 334397 URL: http://llvm.org/viewvc/llvm-project?rev=334397&view=rev Log: Editline: make #include conditional My previous patch made this include unconditional. However, it seems it is not available everywhere. This patch makes us includ

[Lldb-commits] [lldb] r334399 - Move VersionTuple from clang/Basic to llvm/Support

Author: labath Date: Mon Jun 11 03:28:04 2018 New Revision: 334399 URL: http://llvm.org/viewvc/llvm-project?rev=334399&view=rev Log: Move VersionTuple from clang/Basic to llvm/Support Summary: This kind of functionality is useful to other project apart from clang. LLDB works with version numbers

[Lldb-commits] [lldb] r334402 - DWARFDebugNames: Fix lookup in dwo files

Author: labath Date: Mon Jun 11 06:22:31 2018 New Revision: 334402 URL: http://llvm.org/viewvc/llvm-project?rev=334402&view=rev Log: DWARFDebugNames: Fix lookup in dwo files The getDIESectionOffset function is not correct for split dwarf files (and will probably be removed in D48009). This patch

[Lldb-commits] [lldb] r334411 - Fix tuple getter in std unique pointer pretty-printer

Author: labath Date: Mon Jun 11 07:52:52 2018 New Revision: 334411 URL: http://llvm.org/viewvc/llvm-project?rev=334411&view=rev Log: Fix tuple getter in std unique pointer pretty-printer Summary: Check case when _M_t child member is not present. Reviewers: labath, tberghammer Reviewed By: labat

Re: [Lldb-commits] [PATCH] D48049: Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails

On Mon, 11 Jun 2018 at 22:00, Leonard Mosescu via lldb-commits wrote: >> >> remove space before ( > > > I'd be happy to make the change, but looking at the rest of the file it seems > that almost everything uses the opposite convention: Foo (...). > I guess that's because the .i files escaped th

[Lldb-commits] [lldb] r334496 - lit/SymbolFile/DWARF: Simplify test RUN lines

Author: labath Date: Tue Jun 12 05:43:55 2018 New Revision: 334496 URL: http://llvm.org/viewvc/llvm-project?rev=334496&view=rev Log: lit/SymbolFile/DWARF: Simplify test RUN lines Use -mllvm compiler argument to enable DWARF v5 accelerator tables instead of piping the IR through llc. Modified:

[Lldb-commits] [lldb] r334498 - lldb-test symbols: Add -file argument and the ability to dump global variables in a file

Author: labath Date: Tue Jun 12 05:57:36 2018 New Revision: 334498 URL: http://llvm.org/viewvc/llvm-project?rev=334498&view=rev Log: lldb-test symbols: Add -file argument and the ability to dump global variables in a file The motivation for this is to be able to Dwarf index ability to look up va

[Lldb-commits] [lldb] r334500 - DWARFDebugNames: Implement last GetGlobalVariables overload

Author: labath Date: Tue Jun 12 06:11:25 2018 New Revision: 334500 URL: http://llvm.org/viewvc/llvm-project?rev=334500&view=rev Log: DWARFDebugNames: Implement last GetGlobalVariables overload This function implements the search for all global variables within a given compilation unit. Modified:

[Lldb-commits] [lldb] r334501 - Fix build error introduced in r334498

Author: labath Date: Tue Jun 12 06:26:43 2018 New Revision: 334501 URL: http://llvm.org/viewvc/llvm-project?rev=334501&view=rev Log: Fix build error introduced in r334498 Some gcc versions (circa 4.9) do not accept initializing Expected objects containing a reference to a function from a function

[Lldb-commits] [lldb] r334516 - DebugNamesDWARFIndex: Implement DWARFDeclContext variant of GetTypes method

Author: labath Date: Tue Jun 12 09:50:01 2018 New Revision: 334516 URL: http://llvm.org/viewvc/llvm-project?rev=334516&view=rev Log: DebugNamesDWARFIndex: Implement DWARFDeclContext variant of GetTypes method This method is used to find complete definitions of a type when one parses a compile uni

Re: [Lldb-commits] [lldb] r334615 - [FileSpec] Delegate common operations to llvm::sys::path

On Wed, 13 Jun 2018 at 17:27, Jonas Devlieghere via lldb-commits wrote: > > Author: jdevlieghere > Date: Wed Jun 13 09:23:21 2018 > New Revision: 334615 > > URL: http://llvm.org/viewvc/llvm-project?rev=334615&view=rev > Log: > [FileSpec] Delegate common operations to llvm::sys::path > > With the r

[Lldb-commits] [lldb] r334697 - Fix includes in PlatformAppleSimulator.h

Author: labath Date: Thu Jun 14 02:08:54 2018 New Revision: 334697 URL: http://llvm.org/viewvc/llvm-project?rev=334697&view=rev Log: Fix includes in PlatformAppleSimulator.h This unbreaks the cmake build. Other plugins also use the include paths starting with Plugins/..., so I am hoping this will

[Lldb-commits] [lldb] r334702 - Fix PathMappingListTest on windows

Author: labath Date: Thu Jun 14 03:31:06 2018 New Revision: 334702 URL: http://llvm.org/viewvc/llvm-project?rev=334702&view=rev Log: Fix PathMappingListTest on windows r334615 changed the the value of FileSpec.IsRelative("/") for windows path syntax. We previously considered it absolute but now i

[Lldb-commits] [lldb] r334717 - DebugNamesDWARFIndex: fix handling of compressed sections

Author: labath Date: Thu Jun 14 07:41:30 2018 New Revision: 334717 URL: http://llvm.org/viewvc/llvm-project?rev=334717&view=rev Log: DebugNamesDWARFIndex: fix handling of compressed sections This fixes a silly bug where we were accidentally freeing the memory used to store the decompressed .debug

[Lldb-commits] [lldb] r334950 - Use llvm::VersionTuple instead of manual version marshalling

Author: labath Date: Mon Jun 18 08:02:23 2018 New Revision: 334950 URL: http://llvm.org/viewvc/llvm-project?rev=334950&view=rev Log: Use llvm::VersionTuple instead of manual version marshalling Summary: This has multiple advantages: - we need only one function argument/instance variable instead o

[Lldb-commits] [lldb] r334952 - Attempt to fix windows&freebsd builds broken by r334950

Author: labath Date: Mon Jun 18 08:29:42 2018 New Revision: 334952 URL: http://llvm.org/viewvc/llvm-project?rev=334952&view=rev Log: Attempt to fix windows&freebsd builds broken by r334950 Modified: lldb/trunk/source/Host/freebsd/HostInfoFreeBSD.cpp lldb/trunk/source/Host/windows/HostInfo

[Lldb-commits] [lldb] r334953 - Fix netbsd build broken by r334950

Author: labath Date: Mon Jun 18 08:44:36 2018 New Revision: 334953 URL: http://llvm.org/viewvc/llvm-project?rev=334953&view=rev Log: Fix netbsd build broken by r334950 This also includes one more build fix for windows. Modified: lldb/trunk/source/Host/netbsd/HostInfoNetBSD.cpp lldb/trunk

[Lldb-commits] [lldb] r334955 - Fix macosx build broken by the VersionTuple refactor

Author: labath Date: Mon Jun 18 09:10:20 2018 New Revision: 334955 URL: http://llvm.org/viewvc/llvm-project?rev=334955&view=rev Log: Fix macosx build broken by the VersionTuple refactor I actually did check that macos builds before committing, but this error was in conditionally compiled code tha

[Lldb-commits] [lldb] r335047 - Attempt to fix windows build broken by r334968

Author: labath Date: Tue Jun 19 07:23:31 2018 New Revision: 335047 URL: http://llvm.org/viewvc/llvm-project?rev=335047&view=rev Log: Attempt to fix windows build broken by r334968 The issue was that there was no dependency from lldb-suite target to liblldb in the no-framework scenario. This cause

Re: [Lldb-commits] [lldb] r334978 - Fixed file completion for paths that start with '~'.

A test? It looks like it should be possible to test this in a similar way to other CommandCompletion tests (unittests/Interpreter/TestCompletion.cpp). On Mon, 18 Jun 2018 at 21:16, Raphael Isemann via lldb-commits wrote: > > Author: teemperor > Date: Mon Jun 18 13:11:38 2018 > New Revision: 33497

[Lldb-commits] [lldb] r335051 - Make TestCommandScript.py NO_DEBUG_INFO_TESTCASE

Author: labath Date: Tue Jun 19 08:07:22 2018 New Revision: 335051 URL: http://llvm.org/viewvc/llvm-project?rev=335051&view=rev Log: Make TestCommandScript.py NO_DEBUG_INFO_TESTCASE Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/command_script/TestCommandScript.py Modif

[Lldb-commits] [lldb] r335052 - Replace HostInfo::GetLLDBPath with specific functions

Author: labath Date: Tue Jun 19 08:09:07 2018 New Revision: 335052 URL: http://llvm.org/viewvc/llvm-project?rev=335052&view=rev Log: Replace HostInfo::GetLLDBPath with specific functions Summary: Instead of a function taking an enum value determining which path to return, we now have a suite of f

[Lldb-commits] [lldb] r335060 - Scalar: Use llvm integer conversion functions

Author: labath Date: Tue Jun 19 10:24:03 2018 New Revision: 335060 URL: http://llvm.org/viewvc/llvm-project?rev=335060&view=rev Log: Scalar: Use llvm integer conversion functions StringConvert was the only non-Utility dependency of this class. Getting rid of it means it will be easy to move this

[Lldb-commits] [lldb] r335102 - BreakpointIDList: Use llvm::ArrayRef instead of pointer+length pair

Author: labath Date: Wed Jun 20 01:12:50 2018 New Revision: 335102 URL: http://llvm.org/viewvc/llvm-project?rev=335102&view=rev Log: BreakpointIDList: Use llvm::ArrayRef instead of pointer+length pair NFC Modified: lldb/trunk/include/lldb/Breakpoint/BreakpointIDList.h lldb/trunk/source/B

[Lldb-commits] [lldb] r335104 - Remove dependency from Host to python

Author: labath Date: Wed Jun 20 01:35:45 2018 New Revision: 335104 URL: http://llvm.org/viewvc/llvm-project?rev=335104&view=rev Log: Remove dependency from Host to python Summary: The only reason python was used in the Host module was to compute the python path. I resolve this the same way as D47

[Lldb-commits] [lldb] r335106 - Fix windows build broken by r335104

Author: labath Date: Wed Jun 20 02:00:30 2018 New Revision: 335106 URL: http://llvm.org/viewvc/llvm-project?rev=335106&view=rev Log: Fix windows build broken by r335104 lldb-python.h needs to be included first to work around some incompatibilities between windows and python headers. Modified:

[Lldb-commits] [lldb] r335112 - Fix compilation with mingw-w64 (pr37873)

Author: labath Date: Wed Jun 20 02:53:30 2018 New Revision: 335112 URL: http://llvm.org/viewvc/llvm-project?rev=335112&view=rev Log: Fix compilation with mingw-w64 (pr37873) Modified: lldb/trunk/include/lldb/lldb-defines.h Modified: lldb/trunk/include/lldb/lldb-defines.h URL: http://llvm.or

[Lldb-commits] [lldb] r335114 - IRInterpreter: fix sign extension of small types (pr37840)

Author: labath Date: Wed Jun 20 03:45:29 2018 New Revision: 335114 URL: http://llvm.org/viewvc/llvm-project?rev=335114&view=rev Log: IRInterpreter: fix sign extension of small types (pr37840) Sign-extension of small types (e.g. short) was not handled correctly. The reason for that was that when w

[Lldb-commits] [lldb] r335132 - Make sure TestNumThreads works with libc++

Author: labath Date: Wed Jun 20 07:54:34 2018 New Revision: 335132 URL: http://llvm.org/viewvc/llvm-project?rev=335132&view=rev Log: Make sure TestNumThreads works with libc++ The problem was that with libc++ the std::unique_lock declaration was completely inlined, so there was no line table entr

[Lldb-commits] [lldb] r335149 - Make test sources compatible with android+libcxx+modules

Author: labath Date: Wed Jun 20 10:32:48 2018 New Revision: 335149 URL: http://llvm.org/viewvc/llvm-project?rev=335149&view=rev Log: Make test sources compatible with android+libcxx+modules In a modules build, android is very picky about which symbols are visible after including libc++ headers (e

[Lldb-commits] [lldb] r335163 - Remove some instances of manual UUID pretty-printing

Author: labath Date: Wed Jun 20 13:13:04 2018 New Revision: 335163 URL: http://llvm.org/viewvc/llvm-project?rev=335163&view=rev Log: Remove some instances of manual UUID pretty-printing Identical functionality is already offered by the UUID::getAsString method. Modified: lldb/trunk/source/P

[Lldb-commits] [lldb] r335235 - Disable gmodules tests on linux

Author: labath Date: Thu Jun 21 06:55:19 2018 New Revision: 335235 URL: http://llvm.org/viewvc/llvm-project?rev=335235&view=rev Log: Disable gmodules tests on linux These tests are extremely environment-dependent. if the environment is not module-enabled (which is the likely scenario), they won't

[Lldb-commits] [lldb] r335236 - ScriptInterpreterPython cleanup

Author: labath Date: Thu Jun 21 07:09:15 2018 New Revision: 335236 URL: http://llvm.org/viewvc/llvm-project?rev=335236&view=rev Log: ScriptInterpreterPython cleanup Instead of #ifdef-ing the contents of all files in the plugin for all non-python builds, just disable the plugin at the cmake level.

[Lldb-commits] [lldb] r335244 - Modernize UUID class

Author: labath Date: Thu Jun 21 08:07:43 2018 New Revision: 335244 URL: http://llvm.org/viewvc/llvm-project?rev=335244&view=rev Log: Modernize UUID class Instead of a separate GetBytes + GetByteSize methods I introduce a single GetBytes method returning an ArrayRef. This is NFC cleanup now, but

[Lldb-commits] [lldb] r335246 - Remove UUID::SetFromCString

Author: labath Date: Thu Jun 21 08:24:39 2018 New Revision: 335246 URL: http://llvm.org/viewvc/llvm-project?rev=335246&view=rev Log: Remove UUID::SetFromCString Replace uses with SetFromStringRef. NFC. Modified: lldb/trunk/include/lldb/Utility/UUID.h lldb/trunk/source/API/SBTarget.cpp

[Lldb-commits] [lldb] r335247 - Fix macos build for r335244

Author: labath Date: Thu Jun 21 08:40:33 2018 New Revision: 335247 URL: http://llvm.org/viewvc/llvm-project?rev=335247&view=rev Log: Fix macos build for r335244 I've made the code accept only 16 byte UUIDs, which is technically not NFC (previously it would also accept 20 byte ones, but use only t

Re: [Lldb-commits] [lldb] r335236 - ScriptInterpreterPython cleanup

d the relevant files, but can you leave > the #ifdef's in place so you don't break the Xcode build? They don't seem to > add enough value to warrant the breakage. > > Thanks, > > Jim > > > On Jun 21, 2018, at 7:09 AM, Pavel Labath via lldb-commits > &g

[Lldb-commits] [lldb] r335260 - Partially revert r335236

Author: labath Date: Thu Jun 21 10:36:32 2018 New Revision: 335260 URL: http://llvm.org/viewvc/llvm-project?rev=335260&view=rev Log: Partially revert r335236 Jim pointed out that XCode has build configurations that build without python and removing the ifdefs around the python code breaks them.

Re: [Lldb-commits] [lldb] r335236 - ScriptInterpreterPython cleanup

Thanks for the explanation. The ifdef parts should be reverted by r335236. On Thu, 21 Jun 2018 at 18:39, Greg Clayton wrote: > > > > > On Jun 21, 2018, at 10:30 AM, Pavel Labath via lldb-commits > > wrote: > > > > Sure, I can do that. The though of xcode co

Re: [Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

On Wed, 20 Jun 2018 at 23:21, Jim Ingham wrote: > > It is not uncommon that you would be parsing the DWARF for module A and find > a type that is only known as a forward declaration. In that case, lldb will > look through the other Modules' debug info for a real definition, parse that > and im

[Lldb-commits] [lldb] r335344 - Android.rules: Use libc++ by default

Author: labath Date: Fri Jun 22 06:13:29 2018 New Revision: 335344 URL: http://llvm.org/viewvc/llvm-project?rev=335344&view=rev Log: Android.rules: Use libc++ by default libstdc++ will soon be dropped from the android NDK. This patch makes sure we are prepared for that by using libc++ in tests by

Re: [Lldb-commits] [lldb] r335431 - Make testcase classnames unique

BTW, the format of the test trace file names is configurable with a command line option (--session-file-format). Since we already have code which enforces that every test file name is unique, we might want to swap the default format to use the file name instead of the class name. On Sun, 24 Jun 201

Re: [Lldb-commits] [lldb] r335432 - [FileSpec] Always normalize

I believe the raison d'être of the needsNormalization function was the normalization process is not exactly cheap (it constructs a vector of StringRefs and whatnot), and measurements showed that this actually is important for performance of lldb . On Sun, 24

[Lldb-commits] [lldb] r335476 - Fix TestThreadExit for gcc&libc++ combo

Author: labath Date: Mon Jun 25 07:28:38 2018 New Revision: 335476 URL: http://llvm.org/viewvc/llvm-project?rev=335476&view=rev Log: Fix TestThreadExit for gcc&libc++ combo pseudo_barrier_wait() begins by decrementing an atomic variable. Since these are always_inline in libc++, there is no line t

Re: [Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

On Fri, 22 Jun 2018 at 18:42, Jim Ingham wrote: > > > > > On Jun 22, 2018, at 4:05 AM, Pavel Labath wrote: > > > > On Wed, 20 Jun 2018 at 23:21, Jim Ingham wrote: > >> > >> It is not uncommon that you would be parsing the DWARF for module A and > >> find a type that is only known as a forward d

[Lldb-commits] [lldb] r335612 - Represent invalid UUIDs as UUIDs with length zero

Author: labath Date: Tue Jun 26 08:12:20 2018 New Revision: 335612 URL: http://llvm.org/viewvc/llvm-project?rev=335612&view=rev Log: Represent invalid UUIDs as UUIDs with length zero Summary: During the previous attempt to generalize the UUID class, it was suggested that we represent invalid UUID

<    1   2   3   4   5   6   7   8   9   10   >