labath updated this revision to Diff 96514.
labath added a comment.
Address Tamas's comments.
https://reviews.llvm.org/D32441
Files:
cmake/platforms/Android.cmake
www/build.html
Index: www/build.html
===
--- www/build.html
+++
labath updated this revision to Diff 96540.
labath added a comment.
Use yaml2obj to avoid checking in a binary.
https://reviews.llvm.org/D32434
Files:
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
unittests/ObjectFile/ELF/CMakeLists.txt
unittests/ObjectFile/ELF/Inputs/sections-resolve-c
labath updated this revision to Diff 96541.
labath added a comment.
Use yaml2obj to avoid checking in a binary.
https://reviews.llvm.org/D32434
Files:
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
unittests/ObjectFile/ELF/CMakeLists.txt
unittests/ObjectFile/ELF/Inputs/sections-resolve-c
labath added a reviewer: beanz.
labath added a subscriber: beanz.
labath added a comment.
Ok, wiring yaml2obj up was easier than I expected (for cmake, we'll still need
to figure out what to do with the xcode build). Let me know what you make of
this.
Also adding @beanz, in case he has any thou
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301306: Remove the home-grown android toolchain file and all
references to it (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32441?vs=96514&id=96542#toc
Repository:
rL LLVM
labath added inline comments.
Comment at: source/Utility/ConstString.cpp:49
+ // pointer, we don't need the lock.
const StringPoolEntryType &entry = GetStringMapEntryFromKeyData(ccstr);
return entry.getKey().size();
zturner wrote:
> Why do we e
labath added a comment.
In https://reviews.llvm.org/D32306#736115, @scott.smith wrote:
> 10.2% reduction in # of instructions executed, 9.1% reduction in # of cycles,
> as measured by 'perf stat' in single threaded mode (I disabled TaskPool in
> order to get more repeatable results).
That is
labath added a comment.
Thanks for the patch Alex.
After looking around the code a bit (I'm quite new to that area as well), I
think a better approach would be to fix MoveCursor to handle this situation
gracefully. If you look at what this code does in the "normal" case, you'll see
that it del
labath added inline comments.
Comment at: include/lldb/Interpreter/Property.h:43
+ ConstString GetName() const { return m_name; }
+ ConstString GetDescription() const { return m_description; }
scott.smith wrote:
> clayborg wrote:
> > This shouldn't be const-i
labath planned changes to this revision.
labath added a comment.
In https://reviews.llvm.org/D32434#737179, @zturner wrote:
> If you look at the source code of yaml2obj, all this boils down to a single
> call to `ELFState::writeELF`. If you just link against that, we could
> avoid even shellin
labath added a comment.
Thank you for taking the time to add the test.
I'd like to avoid modifying the test framework for the sake of this test, if
that is possible.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1487
'EXE': exe_name}
+if not os.
labath requested review of this revision.
labath added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D32434#737205, @labath wrote:
> In https://reviews.llvm.org/D32434#737179, @zturner wrote:
>
> > If you look at the source code of yaml2obj, all this boil
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
This is not necessary. NativeProcess classes are only used in lldb-server,
which is completely single threaded. If you want to change that, then we should
start with a discussion of
labath accepted this revision.
labath added inline comments.
Comment at: source/Utility/ConstString.cpp:49
+ // pointer, we don't need the lock.
const StringPoolEntryType &entry = GetStringMapEntryFromKeyData(ccstr);
return entry.getKey().size();
--
labath closed this revision.
labath added a comment.
I already submitted a fix of my own before seeing this. Thanks for the patch
though. :)
https://reviews.llvm.org/D32584
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Cool. Thank you.
https://reviews.llvm.org/D32522
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
labath created this revision.
Herald added a subscriber: srhines.
It turns out that even though ppoll is available on all the android
devices we support, it does not seem to be working properly on all of
them -- MainLoop just does a busy loop with ppoll returning EINTR and
not making any progress.
labath added a comment.
In https://reviews.llvm.org/D32568#739607, @scott.smith wrote:
> In https://reviews.llvm.org/D32568#739190, @labath wrote:
>
> > This is not necessary. NativeProcess classes are only used in lldb-server,
> > which is completely single threaded. If you want to change that,
labath added a comment.
In https://reviews.llvm.org/D32149#738250, @krytarowski wrote:
> ping?
Sorry, I wasn't responding partially because I was waiting to see how the
discussion on https://reviews.llvm.org/D32434 settles, as I think it may have
effect on the test strategy. I'll write more t
labath added inline comments.
Comment at: source/Host/common/MainLoop.cpp:82
+ int queue_id;
+ std::vector events;
+ struct kevent event_list[4];
eugene wrote:
> here and below struct seems to be redundant
One of them holds the input events, and the other the
labath added a comment.
Cool, glad that's sorted. I've had some ideas about introducing limited amount
of paralellism to the server side, but that's probably is not interesting to
you if you're not doing remote debugging.
Repository:
rL LLVM
https://reviews.llvm.org/D32568
__
labath added a comment.
If you're going to be making drastic changes here, could you please look at the
possibility of making a more targeted test, rather than relying on the "run the
whole debugger and set a breakpoint" type of tests to verify the finer details
of the implementation. I was abl
labath updated this revision to Diff 97074.
labath added a comment.
Address review feedback.
https://reviews.llvm.org/D32600
Files:
include/lldb/Host/MainLoop.h
source/Host/common/MainLoop.cpp
Index: source/Host/common/MainLoop.cpp
==
labath added a comment.
I am going to check this in to unbork the android bots. I'm happy to address
any additional feedback in a followup.
I'm also planning to come some unit tests for this class next week.
https://reviews.llvm.org/D32600
___
lld
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301636: Resurrect pselect MainLoop implementation (authored
by labath).
Changed prior to commit:
https://reviews.llvm.org/D32600?vs=97074&id=97075#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
labath added a reviewer: zturner.
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I am adding Zachary, as he usually has good ideas about APIs.
All in all, it's not a very controversal change, but I have a bunch of inline
comments
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301642: Remove lock from ConstString::GetLength (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D32306?vs=96841&id=97083#toc
Repository:
rL LLVM
https://reviews.llvm.org/D323
labath added inline comments.
Comment at: source/Utility/ConstString.cpp:49
+ // pointer, we don't need the lock.
const StringPoolEntryType &entry = GetStringMapEntryFromKeyData(ccstr);
return entry.getKey().size();
scott.smith wrote:
> labath
labath added a comment.
Couldn't we just update the cpp file to do
#ifndef PR_MPX_ENABLE_MANAGEMENT
return -1;
#endif
?
https://reviews.llvm.org/D32719
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301903: Remove unused code related to
CPlusPlusLanguage::FindEquivalentNames (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32503?vs=96623&id=97408#toc
Repository:
rL LLVM
labath added subscribers: jingham, labath.
labath added a comment.
Thanks for the patch. Could you also write a test case for the bug? It sounds
like all that is necessary is to move the commands from your commit message
into a test.
Jim, who would be a good reviewer for this?
Repository:
r
labath added a comment.
I am having trouble applying this. Do you need to rebase or something?
Repository:
rL LLVM
https://reviews.llvm.org/D32708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301908: Change UniqueCStringMap to use ConstString as the
key (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32316?vs=96629&id=97417#toc
Repository:
rL LLVM
https://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301917: ObjectFileELF: Fix symbol lookup in bss section
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32434?vs=96541&id=97435#toc
Repository:
rL LLVM
https://reviews.llvm.
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I don't like either of the solutions too much, but this one is at least less
code. :)
https://reviews.llvm.org/D32719
___
lldb-commits mailing l
labath created this revision.
Herald added a subscriber: mgorny.
This adds a couple of unit tests to the MainLoop class. To get the
kqueue based version of the signal handling passing, I needed to
modify the implementation a bit to make the queue object persistent.
Otherwise, only the signals whic
labath added a comment.
It's definitely still a bug worth fixing, we cannot rely on undefined behavior
like that.
Thank you very much for adding the test case. Looking at the test suite again,
I think I've found a better place for the test. Could you put the test in
test/testcases/expression_c
labath requested changes to this revision.
labath added a subscriber: probinson.
labath added a comment.
This revision now requires changes to proceed.
This will not compile on windows, which really is the only branch we expected
to have `SIGNAL_POLLING_UNSUPPORTED` set. In this sense Pauls (cc'e
labath added a comment.
In https://reviews.llvm.org/D32787#744379, @xiangzhai wrote:
> Hi Pavel,
>
> > Could one of you guys check whether you really don't have the ppoll syscall
> > (for example, are able to compile a simple program using ppoll (*))
>
> It has! clang is able to compile the simp
labath created this revision.
Herald added subscribers: srhines, rengolin, aemerson.
Arm64 Procedure Call Standard specifies than only vectors up to 16 bytes
are stored in v0 (which makes sense, as that's the size of the
register). 32-byte vector types are passed as regular structs via x8
pointer.
labath added a comment.
In https://reviews.llvm.org/D32787#744974, @probinson wrote:
> Looking at CMakeError.log, the test program does `#include ` but does
> not `#define _GNU_SOURCE`. The define has to be there for your example to
> compile on my Ubuntu.
We do that in LLDBGenerateConfig.cm
labath added a comment.
In https://reviews.llvm.org/D32787#745139, @probinson wrote:
> In https://reviews.llvm.org/D32787#745099, @labath wrote:
>
> > Could it be that you just have stale cmake cache?
>
>
> That could easily be true. Rerunning cmake didn't fix it; short of deleting
> the entire
labath added a comment.
Don't forget to update the usages in unit tests (and make sure the
check-lldb-unit target passes).
Seems reasonable, however: I am not sure who actually uses these timers. I'd be
tempted to just remove the timers that are causing the contention.
Comme
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Perfect, thank you.
Do you have commit access?
https://reviews.llvm.org/D32421
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
labath added a comment.
I have feeling you gave up on the llvm change too quickly. My interpretation of
that thread was that there was general support for the hash function switch,
and people only wanted some confirmation it will not regress.
However, I do believe that this can be made faster t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302133: MainLoop: Add unit tests (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32753?vs=97464&id=97802#toc
Repository:
rL LLVM
https://reviews.llvm.org/D32753
Files:
lld
labath added a comment.
In https://reviews.llvm.org/D32813#746012, @tberghammer wrote:
> I am a bit confused by the correlation between your change and commit
> message. In the commit message you say that 32 byte structs
I mean 32-byte vectors. I.e. variables declared as `float foo
__attribut
labath added a comment.
Ok, then let's keep them. I don't mind changing all call sites -- having a
separate category object is the cleanest solution with least magic. However see
my comments about category naming and merging.
Comment at: unittests/Core/TimerTest.cpp:39
s
labath created this revision.
Herald added a subscriber: aprantl.
Debug info sections, (or non-SHF_ALLOC sections in general) should be
linked as if their load address was zero to emulate the behavior of the
static linker.
I've made two tests for this: One checks that we are able to properly
proc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302220: ABISysV_arm64: compute return value for large
vectors correctly (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32813?vs=97676&id=97927#toc
Repository:
rL LLVM
https
labath added inline comments.
Comment at: source/Symbol/Symtab.cpp:257
-// The "const char *" in "class_contexts" must come from a
-// ConstString::GetCString()
-std::set class_contexts;
-UniqueCStringMap mangled_name_to_index;
-std::vector symbol_contexts(n
labath accepted this revision.
labath added a comment.
I can do the pushing. :)
Thanks for the patch.
Comment at: include/lldb/Utility/TaskPool.h:89
+void TaskMapOverInt(size_t begin, size_t end,
+std::function const &func);
Making this a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302223: Add TaskMap for iterating a function over a set of
integers (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32757?vs=97907&id=97931#toc
Repository:
rL LLVM
https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302225: Fix segfault resulting from empty print prompt
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32421?vs=97717&id=97937#toc
Repository:
rL LLVM
https://reviews.llvm.o
labath added a comment.
Committed as 302225. I've fixed the indentation in your test, and added a
couple of decorators to match other pexpect tests. Thanks for the patch!
Repository:
rL LLVM
https://reviews.llvm.org/D32421
___
lldb-commits maili
labath added a comment.
Jason, any thoughts on my comments above?
https://reviews.llvm.org/D32022
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm, thank you.
Comment at: unittests/Core/TimerTest.cpp:39
std::this_thread::sleep_for(std::chrono::milliseconds(10));
-Timer t2("CAT1", "");
+// Explicitly te
labath added a comment.
The largest issue I see here is the use of exceptions, which are banned in
llvm. We'll need to get rid of those before we start discussing anything else.
This means we'll need to propagate errors manually, and we should design it in
a way that it is easy to ASSERT on the
labath added a comment.
I'm out of office this week. Could you hold until I get back? Hopefully we
will see some development on the llvm/lld front in the meanwhile.
Repository:
rL LLVM
https://reviews.llvm.org/D32597
___
lldb-commits mailing li
labath added a comment.
next batch of comments from me (I expect to have more on monday). :)
In https://reviews.llvm.org/D32930#752843, @krytarowski wrote:
> I can build locally with `make thread_inferior`, how to run it?
run the `check-lldb-unit` target.
Comment at: unitte
labath added inline comments.
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:21
+
+ LLVM_BUILTIN_DEBUGTRAP;
+ delay = false;
krytarowski wrote:
> labath wrote:
> > krytarowski wrote:
> > > jmajors wrote:
> > > > krytarowski wrote:
> > > >
labath added a comment.
I don't really like that we are adding a public shared library for every tiny
intel feature. Could we at least merge this "plugin" with the existing
"intel-mpx plugin" to create one "intel support" library?
Also, adding an external dependency probably deserves a discussi
labath added a comment.
As this is an objective C feature, wouldn't a better place for it be in
testcases/lang/objc ?
Comment at:
packages/Python/lldbsuite/test/functionalities/ptr_refs-objc/Makefile:10
+
+include $(LEVEL)/Makefile.rules
This looks like a cop
labath updated this revision to Diff 98967.
labath added a comment.
Herald added a subscriber: krytarowski.
Add llvm-rtdyld test case
https://reviews.llvm.org/D32899
Files:
lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp
test/ExecutionEngine/RuntimeDyld/X86/ELF_x86-64_debug_frame.s
Index:
labath added a comment.
Thanks for the help, this definitely looks much better. :)
Since I already have it written, would you still be interested in the
ProcessAllSections MCJIT test by any chance? I noticed that you none of the
MCJIT tests set ProcessAllSections=true, or use Modules with debug
labath abandoned this revision.
labath added a comment.
Fix is in https://reviews.llvm.org/D32899.
https://reviews.llvm.org/D32295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
In https://reviews.llvm.org/D32585#752115, @ravitheja wrote:
> In https://reviews.llvm.org/D32585#740632, @labath wrote:
>
> > I quite like that you have added just the packet plumbing code without an
> > concrete implementation. However, that is still a significant amoun
labath added a comment.
Is this feature really darwin specific? Isn't the `__private_extern__` thingy
equivalent to `__attribute__(visibility("hidden")))`, which is supported by gcc
and clang alike?
Comment at: packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Makefile
labath added a comment.
A bunch more pedantic comments from me.
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:26
+ for (int i = 0; i < thread_count; i++) {
+threads.push_back(std::thread([&delay]{while(delay);}));
+ }
Could you add
labath added a comment.
I think this is a step in the right direction. Besides reducing boilerplate,
this will also help us ensure correctness, as we get a constant trickle of bug
reports for commands which forgot to set the result status.
The name is not ideal, but it's probably the best we ca
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303058: Remove an expensive lock from Timer (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D32823?vs=97973&id=98994#toc
Repository:
rL LLVM
https://reviews.llvm.org/D32823
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/lang/c/conflicting-symbol/One.mk:1
+LEVEL := ../../../make
+
Thanks for the effort. It almost works for me :), except for the part where you
clear out the CFLAGS. We cannot do that, as CFLA
labath created this revision.
I tried convert a function to llvm::Error/Expected but I quickly ran into the
issue of interfacing with code that still expects the Status objects.
This is my proposal for conversion functions between the two. I use
constructors and conversion operators on the Status
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303239: [RuntimeDyld] Fix debug section relocation (pr20457)
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32899?vs=98967&id=99257#toc
Repository:
rL LLVM
https://reviews.
labath added a comment.
In https://reviews.llvm.org/D33241#756921, @zturner wrote:
> Mostly just that implicit conversion operators are a very subtle source of
> bugs, and you can't even find where they're being used because it's
> impossible to grep for it.
I agree, and that's why I made the
labath updated this revision to Diff 99283.
labath added a comment.
use a separate function instead of a conversion operator
https://reviews.llvm.org/D33241
Files:
include/lldb/Utility/Status.h
source/Utility/Status.cpp
unittests/Utility/StatusTest.cpp
Index: unittests/Utility/StatusTest
labath created this revision.
The function had logic to handle the case when the expression terminated
while we were trying to halt the process, but it failed to take into
account the possibility that the expression stopped because it hit a
breakpoint. This was caused by the fact that the handling
labath added a comment.
I'm not sure I understand what you're saying. Did you mean to say that I should
add the "thread plan didn't successfully complete." (line 5281) block to the
"Halt" branch as well ? (possibly by including it into the factored out
function)
https://reviews.llvm.org/D3328
labath added a comment.
llvm policy is to commit tests alongside the code under test. I also think it's
easier to review as you have the code and the test on the same screen.
What's the reason that prevents you from doing that?
https://reviews.llvm.org/D32585
___
labath added a comment.
In https://reviews.llvm.org/D32585#758391, @ravitheja wrote:
> Well nothings preventing me from doing so, I have the changes for that were
> suggested to me for this revision. I thought I would first upload them, so
> that people can look at the parallel while I upload t
labath added a comment.
I think we're getting close, but I see a couple more issues here.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:24
+ if (elements["pid"].getAsInteger(16, process_info->pid))
+return make_parsing_error("ProcessInfo: pid");
+ if (e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303348: Add Status -- llvm::Error glue (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D33241?vs=99283&id=99429#toc
Repository:
rL LLVM
https://reviews.llvm.org/D33241
Files:
labath added a comment.
Ok, I've missed the distinction between plan completing (aka being "done") and
completing **sucessfully**. Things make a bit more sense after that.
With that in mind, let me try to explain how I understand it the code now, and
then you can tell me if it's correct :)
For
labath updated this revision to Diff 99435.
labath added a comment.
New version
https://reviews.llvm.org/D33283
Files:
packages/Python/lldbsuite/test/expression_command/unwind_expression/TestUnwindExpression.py
source/Target/Process.cpp
Index: source/Target/Process.cpp
===
labath added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.h:10
+
+#include
+#include
jmajors wrote:
> labath wrote:
> > This still looks wrong. Did you run clang-format on the full patch (`git
> > clang-format origin/master` sh
labath added a comment.
Ok, so the comments below are basically a collection of nits. The only two
major issues that still need addressing are:
- getting rid of the sleep in the startup code
- deciding on the naming of members
Comment at: unittests/tools/lldb-server/tests/Mes
labath added a comment.
Thank you for taking the time to write the test. Just a couple of more comments
on things I noticed when going through this again:
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3172
+ if (custom_params)
+json_packe
labath created this revision.
A change in swig 3.0.9 has caused it to generate modules incompatible
with us using them as __init__.py (bug #769). Swig 3.0.11 adds a setting to help
fix this problem, so use that. Support for older versions of swig remains
unaffected.
https://reviews.llvm.org/D334
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:47
+exe = os.path.join('.','newdir','proc_attach')
+self.addTearDownHook(lambda: shutil.rmtree(os.path.join(os.getcwd(
+
-
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Committed as r303553. Thanks for the patch.
https://reviews.llvm.org/D33347
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
labath added a comment.
Sounds like an awesome feature.
Could you please add a test for it as well?
https://reviews.llvm.org/D33426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
labath added inline comments.
Comment at:
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:400
+
+ HandlePacket(server, "jTraceStart:{\"buffersize\" : 8192,\"jparams\" :
{\"psb\" : 1,\"tracetech\" : \"intel-pt\"},\"metabuffersize\" :
8192,\"threadid\" : 35,\"
labath added inline comments.
Comment at:
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:400
+
+ HandlePacket(server, "jTraceStart:{\"buffersize\" : 8192,\"jparams\" :
{\"psb\" : 1,\"tracetech\" : \"intel-pt\"},\"metabuffersize\" :
8192,\"threadid\" : 35,\"
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303627: Add support for new (3.0.11+) swigs (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D33409?vs=99755&id=99878#toc
Repository:
rL LLVM
https://reviews.llvm.org/D33409
labath added a comment.
thank you
https://reviews.llvm.org/D33283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
What was your decision on the core files? I was under the impression you were
gonna add the zip files as well. If so, then they should go in at the same time.
Repository:
rL LLVM
https://reviews.llvm.org/D32149
___
lldb-c
labath added a comment.
Thanks for writing the test. We just need to make sure it runs in a stable
manner.
Comment at:
packages/Python/lldbsuite/test/functionalities/thread/num_threads/TestNumThreads.py:91
+# thread3 function. All of these threads should show as one s
labath accepted this revision.
labath added a comment.
Looks good as far as I am concerned (please wait for greg's ok though)
https://reviews.llvm.org/D32585
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303732: RunThreadPlan: Fix halting logic in
IgnoreBreakpoints = false (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D33283?vs=99435&id=100058#toc
Repository:
rL LLVM
https:
labath added a comment.
that sounds like an excellent idea, as it will check all executed commands, and
not the ones we've remembered checking. It should probably be an `lldbassert`
though. (And we'd need to check that the existing tests still pass after that.)
Repository:
rL LLVM
https://r
1101 - 1200 of 6408 matches
Mail list logo
