[Lldb-commits] [clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/137580 >From 0129e28643f667febb23dba1521134a6151c2f7d Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Sun, 27 Apr 2025 22:33:44 -0700 Subject: [PATCH] [clang] Add `__ptrauth_restricted_intptr` qualifier __ptrauth_rest

[Lldb-commits] [clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

https://github.com/ojhunt created https://github.com/llvm/llvm-project/pull/137580 __ptrauth_restricted_intptr provides a mechanism to apply pointer authentication to pointer sized integer types. >From 7af378bbec4c7cf3896f6f7bc95d816e398930f2 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: S

[Lldb-commits] [clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

ojhunt wrote: > Perhaps silly initial question: why do we need a whole different qualifier > for this? Why can you not write `__ptrauth uintptr_t foo`? Not a silly question, back when first implemented we spent time thinking about this. The concern was basically `T* __ptrauth(...)` can repres

[Lldb-commits] [clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

ojhunt wrote: > I realize you've got downstream users making use of this additional > qualifier. Can you mention how prevalent the use is? it's used a bunch in libcxx, libcxxabi, libunwind, compiler-rt and a few other places. We can obviously use a macro to wrap this, but we need to have a wa

[Lldb-commits] [clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

ojhunt wrote: @AaronBallman have you made a decision? (if the keyword has to go away I need to replace all the tests and work out how to integrate with other libraries downstream in a way that works in both modes) https://github.com/llvm/llvm-project/pull/137580 ___

[Lldb-commits] [clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/137580 >From 9c29520abea852086f8f4c555e2ad1ea7c711800 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Sun, 27 Apr 2025 22:33:44 -0700 Subject: [PATCH] [clang] Add `__ptrauth_restricted_intptr` qualifier __ptrauth_rest

[Lldb-commits] [clang] [lldb] [clang] Add support for `__ptrauth` being applied to integer types (PR #137580)

https://github.com/ojhunt edited https://github.com/llvm/llvm-project/pull/137580 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] Fix objective-c ptrauth tests (PR #149218)

https://github.com/ojhunt closed https://github.com/llvm/llvm-project/pull/149218 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/137580 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

@@ -2032,6 +2032,7 @@ class SourceManagerForFile { // as they are created in `createSourceManagerForFile` so that they can be // deleted in the reverse order as they are created. std::unique_ptr FileMgr; + std::unique_ptr DiagOpts; ojhunt wrote: I don't

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Remove intrusive reference count from `DiagnosticOptions` (PR #139584)

@@ -2032,6 +2032,7 @@ class SourceManagerForFile { // as they are created in `createSourceManagerForFile` so that they can be // deleted in the reverse order as they are created. std::unique_ptr FileMgr; + std::unique_ptr DiagOpts; ojhunt wrote: @jansvo

[Lldb-commits] [lld] [lldb] [llvm] [NFC] Address more bit-field storage sizes (PR #140493)

https://github.com/ojhunt created https://github.com/llvm/llvm-project/pull/140493 Follow on work from #139825 >From 6234ea2b59e49a9da1248875a9fc6ecf294483b4 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Sun, 18 May 2025 20:31:43 -0700 Subject: [PATCH] [NFC] Address more bit-field storage s

[Lldb-commits] [lld] [lldb] [NFC] Address more bit-field storage sizes (PR #140493)

https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/140493 >From 90e4c9d97eb84decea39cf28fbd22b99fcbccbda Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Sun, 18 May 2025 20:31:43 -0700 Subject: [PATCH] [NFC] Address more bit-field storage sizes Follow on work from #13

[Lldb-commits] [lld] [lldb] [NFC] Address more bit-field storage sizes (PR #140493)

@@ -99,15 +99,15 @@ class InputChunk { // the beginning of the output section this chunk was assigned to. int32_t outSecOff = 0; - uint8_t sectionKind : 3; + uint32_t sectionKind : 3; ojhunt wrote: Unfortunately I can :( The MS ABI only packs bit-field

[Lldb-commits] [lld] [lldb] [NFC] Address more bit-field storage sizes (PR #140493)

https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/140493 >From 7bf3ebaa15bdabdef20a2b15933fbb66fa0aaa2c Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Sun, 18 May 2025 20:31:43 -0700 Subject: [PATCH] [NFC] Address more bit-field storage sizes Follow on work from #13

[Lldb-commits] [lld] [lldb] [NFC] Address more bit-field storage sizes (PR #140493)

https://github.com/ojhunt edited https://github.com/llvm/llvm-project/pull/140493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [lldb] [NFC] Address more bit-field storage sizes (PR #140493)

ojhunt wrote: Force push with no PR changes other than attaching more information to the commit message. https://github.com/llvm/llvm-project/pull/140493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lld] [lldb] [NFC] Address more bit-field storage sizes (PR #140493)

@@ -99,15 +99,15 @@ class InputChunk { // the beginning of the output section this chunk was assigned to. int32_t outSecOff = 0; - uint8_t sectionKind : 3; + uint32_t sectionKind : 3; ojhunt wrote: Yes, let me check whether I'm meant to be using Microso

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [openmp] [Clang] unrecognized html tag causing undesirable comment lexing (PR #152944)

Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Zhaoxuan Jiang ,Bill Wendling ,Morris Hafner ,David Green , Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Alex Bradbury ,DeanSturtevant1 ,Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Craig Topper ,DeanSturtevant1 , Valentin Clement =?utf-8?b?KOODk

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [openmp] [Clang] unrecognized html tag causing undesirable comment lexing (PR #152944)

Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Zhaoxuan Jiang ,Bill Wendling ,Morris Hafner ,David Green , Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Alex Bradbury ,DeanSturtevant1 ,Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Craig Topper ,DeanSturtevant1 , Valentin Clement =?utf-8?b?KOODkOOD

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

@@ -9744,6 +9744,16 @@ static void DiagnoseNarrowingInInitList(Sema &S, case NK_Constant_Narrowing: { // A constant value was narrowed. + +// Overflow behavior destination types with a 'wrap' kind can elide ojhunt wrote: Why is that a reasonable ass

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

ojhunt wrote: This comment became quite long, so I just want to add a preamble. First off, I'm sorry that I missed the RFC for this or I would have raised these objections then - If I did see it I would have blindly assumed that it was solely removing the UB nature of overflow, with no other s

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

@@ -359,6 +366,16 @@ class DeclSpec { LLVM_PREFERRED_TYPE(TQ) unsigned TypeQualifiers : 5; // Bitwise OR of TQ. + // overflow behavior qualifiers + LLVM_PREFERRED_TYPE(bool) ojhunt wrote: @mizvekov so would I but there are so many non-enum classes I'm

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

ojhunt wrote: > ...Now, back to reading another wall of text 😉 It's a skill whether it's a _good_ skill is an entirely different question :D https://github.com/llvm/llvm-project/pull/148914 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

@@ -2845,6 +2866,41 @@ bool Sema::IsComplexPromotion(QualType FromType, QualType ToType) { ToComplex->getElementType()); } +bool Sema::IsOverflowBehaviorTypePromotion(QualType FromType, QualType ToType) { ojhunt wrote: Wait, are you

[Lldb-commits] [clang] [lldb] [Clang] Introduce OverflowBehaviorType for fine-grained overflow control (PR #148914)

@@ -339,6 +389,8 @@ ConvertTypeToDiagnosticString(ASTContext &Context, QualType Ty, << "' " << Values << ")"; return DecoratedString; } + +TryConvertOverflowBehaviorTypeToDiagnosticString(Context, Ty, S); ojhunt wrote: Assuming the exis