[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid marked 10 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp:167 assert(target_arch.GetTriple().getOS() == llvm::Triple::FreeBSD); switch (target_arch.GetMachine()) { case llvm::Triple

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid updated this revision to Diff 275869. omjavaid added a comment. This new revision incorporates all suggestions on previous version. @labath What do you think? I have skipped merging switch statements and have picked all other suggestions you highlighted. If this is LGTM then i can rebas

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid marked 3 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp:46 +: lldb_private::RegisterContext(thread, 0) { + m_register_info_up = std::move(register_info); lab

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid updated this revision to Diff 276015. omjavaid added a comment. This revision fixed issues highlighted in last review. LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80105/new/ https://reviews.llvm.org/D80105 Files: lldb/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fa7b81bcbd0: Combine multiple defs of arm64 register sets (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7fa7b81bcbd0: Combine multiple defs of arm64 register sets (authored by omjavaid). Herald added a project: LLDB. Changed

[Lldb-commits] [PATCH] D77045: Minor fixups to LLDB AArch64 register infos macros for SVE register infos

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bf6c50c7fe2: Minor fixups to LLDB AArch64 register infos macros for SVE register infos (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D77045: Minor fixups to LLDB AArch64 register infos macros for SVE register infos

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bf6c50c7fe2: Minor fixups to LLDB AArch64 register infos macros for SVE register infos (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D83541: Remove Linux sysroot dependencies of SVE PT macros

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: kristof.beyls, tschuett. Herald added a reviewer: rengolin. SVE elf note data requires SVE PT macros for reading writing data. Same macros are used by Linux ptrace SVE register access. This patch makes n

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 276963. omjavaid added a comment. This update incorporates suggestion from last iteration and also rebases after merger to registersets and register infos in RegisterInfosPOSIX_arm64. Also I have posted a separate patch D83541

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 276964. omjavaid added a comment. This update incorporates suggestion from last iteration and also rebases after merger of register sets and register infos in RegisterInfosPOSIX_arm64. Also I have posted a separate patch D83541

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 277701. omjavaid added a comment. This update addresses issues raised in last iteration. Also have removed dependence on lldb-arm64-register-enums.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files:

[Lldb-commits] [PATCH] D83541: Remove Linux sysroot dependencies of SVE PT macros

omjavaid updated this revision to Diff 277702. omjavaid added a comment. This update addresses concerns raised in last iteration. LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83541/new/ https://reviews.llvm.org/D83541 Files: lldb/source/Plugins/Process/Linux/LinuxPTraceDefine

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 277703. omjavaid added a comment. This update makes changes to avoid dependence on lldb-arm64-register-enums.h. Also provides rebased version after update of parent patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.

[Lldb-commits] [PATCH] D83753: Remove use of multiple reg index enums by RegisterContextPOSIX_arm64

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: danielkiss, arphaman, kristof.beyls, emaste. This patch removes dependence of RegisterContextPOSIX_arm64 on register number enums defined in lldb-arm64-register-enums.h. RegisterContextPOSIX_arm64 makes u

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked 6 inline comments as done. omjavaid added a comment. In D77047#2125220 , @labath wrote: > There's always a chance for ODR violations, particularly with header files > defining static objects. This looks better though what I really wanted w

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:82-106 +uint32_t +RegisterContextCorePOSIX_arm64::CalculateSVEOffset(uint32_t reg_num) const { + uint32_t sve_offset =

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:82-106 +uint32_t +RegisterContextCorePOSIX_arm64::CalculateSVEOffset(uint32_t reg_num) const { + uint32_t sve_offset =

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:82-106 +uint32_t +RegisterContextCorePOSIX_arm64::CalculateSVEOffset(uint32_t reg_num) const { + uint32_t sve_offset =

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 278113. omjavaid added a comment. This update address issues highlighted in last iteration and also minimizes the use of SVE_PT macros by using RegisterInfo.byte_size and byte_offset where possible. @labath What do you think ? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 278124. omjavaid added a comment. Minor fix removing GetRegNumP0 which is no longer needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 278127. omjavaid added a comment. Updated and re-based after changes in core file patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.llvm.org/D79699 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid updated this revision to Diff 278128. omjavaid added a comment. Updated after incorporating review comments. @rovka I gave your idea a thought about moving included scripts to lldb/utils. IMO these scripts have no relationship with LLDB and no such precedent exist where we uploaded suc

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked 9 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.cpp:289 + +lldb_private::RegisterInfo *new_reg_info_p = reg_info_ref.data(); + labath wrote: > I think all uses

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 278435. omjavaid added a comment. In this update I have addressed issues highlighted in last review iteration. @labath Does this now look LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files: lldb

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 278617. omjavaid added a comment. This update plugs the holes susceptible to bugs by endianity variations. I have used DataExtractor GetU16 to read flags and vl from user_sve_header. Also removed the memset and replaced it with SetFromMemoryData function.

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:63-66 +m_sve_note_payload.resize(m_sveregset.GetByteSize()); +::memcpy(GetSVEBuffer(), m_sveregset.GetDataStart(

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 278718. omjavaid added a comment. This revision updates SVE ptrace support to reflect changes we made in SVE core file support specially around handling of FPSR and FPCR. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.llv

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 279151. omjavaid added a comment. This update makes minor adjustments before merge in light of final comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files: lldb/source/Plugins/Process/Utility/Re

[Lldb-commits] [PATCH] D83541: Remove Linux sysroot dependencies of SVE PT macros

omjavaid updated this revision to Diff 279152. omjavaid added a comment. One minor last minute change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83541/new/ https://reviews.llvm.org/D83541 Files: lldb/source/Plugins/Process/Linux/LinuxPTraceDefines_arm64sve.h lldb/source/Plugins

[Lldb-commits] [PATCH] D83541: Remove Linux sysroot dependencies of SVE PT macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ca9b589c453: Remove Linux sysroot dependencies of SVE PT macros (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D83753: Remove use of multiple reg index enums by RegisterContextPOSIX_arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rG4923dca9bd8f: Remove use of multiple reg index enums by RegisterContextPOSIX_arm64 (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e017de0ad62: AArch64 SVE register infos and core file support (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

omjavaid updated this revision to Diff 231408. omjavaid added a comment. Sorry for late response on this. I got side tracked into other issues and wanted performance testing before writing an update. I agree with @labath about making caching for limited to reads only and register writes are wri

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

omjavaid added a comment. Hi Jan, I have done further investigation on this with new ampere arm server. This problem manifests itself on all kind of Debian flavors and is not related to underlying libraries. I have tested LLDB on Arm 32bit host with Ubuntu Xenial, Bionic and Debian Buster all

[Lldb-commits] [PATCH] D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples

omjavaid added a comment. Ping @jasonmolenda Any comments or LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70155/new/ https://reviews.llvm.org/D70155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b8185bb1b45: Avoid triple corruption while merging core info (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70155/new/ https://revie

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

omjavaid updated this revision to Diff 232501. omjavaid added a comment. Hi I have updated this patch after incorporating previous suggestions like moving InvalidateAllRegisters declaration to NativeRegisterContextLinux and also relocated calls to InvalidateAllRegisters from NativeProcessLinux

[Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6f9d7b8fb2e: Cleanup and speedup NativeRegisterContextLinux_arm64 (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D69371?vs=232501&id=232586#toc

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

omjavaid added a comment. @jankratochvil I have verified both D71498 and D71514 . They **do not fix** the issues introduced by D63540 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

omjavaid added a comment. I still seem to get the same issue after applying this patch and D63540 . echo -e '#include \nint main(void){\nsync();return 0;}'|./bin/clang -g -x c -;./bin/lldb -o 'file ./a.out' -o 'b main' -o r -o 'p (void)sync()' (lldb) file ./a.ou

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

omjavaid added a comment. This issue is being caused by wrong address being written to memory somewhere while single stepping though i have reached the exact problem but the logs seem to suggest it. LLDB Log without D63540 https://paste.ubuntu.com/p/zdXFrfN4M

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

omjavaid added a comment. Symbols sizes are being zeroed out Correct without D63540 : https://pastebin.ubuntu.com/p/fKGxFfwyxV/ Incorrect with D63540 : https://pastebin.ubuntu.com/p/XBTScYYkhq/ Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

omjavaid added a comment. In D71498#1786341 , @clayborg wrote: > As I am reading this, I just wanted to send out a note of something else that > can cause crashes in ARM/Thumb code. For anyone working with ARM/Thumb on > systems that don't use the ARM an

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

omjavaid added a comment. @jankratochvil @labath Some new information below: ProcessGDBRemote::DoAllocateMemory fails when it is called for expression evaluation preparation. This happens when both lldb and lldb-server are running on 32-bit arm host (various distros verified). If we debug usi

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

omjavaid added a comment. Some new observations: With this approach of not setting size of a non-last zero-sized symbol we somehow mange to zero out size of init (_init symbol) and .text (_start symbol). To build and evaluate a.out echo -e '#include \nint main(void){\nsync();return 0;}'|./bi

[Lldb-commits] [PATCH] D72251: [RFC] Support SVE registers access on AArch64 Linux

omjavaid created this revision. omjavaid added reviewers: labath, clayborg, jankratochvil, jasonmolenda. omjavaid added a project: LLDB. Herald added subscribers: kristof.beyls, tschuett. Herald added a reviewer: rengolin. This is an RFC patch for the on going effort to support SVE registers acces

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This doesnt cause any regressions on 32-bit arm testsuite. Tested on Ubuntu Xenial and Bionic 32bit arm host docker container. I hope this fixes all the redhat issues as well. Thank you so

<    1   2   3   4   5   6