[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2391245 , @labath wrote: > In D91241#2391156 , @omjavaid wrote: > >> I guess GDB standard does enforce ascending order, here is what it says >> about regnum: >> >> "The register’

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid updated this revision to Diff 305680. omjavaid added a comment. This update tries to fix concerns raised by removing AArch64 specific code and makes offset assignment more generic. We now have a new flag which is set to true if offset field was present and on basis of that we assign of

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2397083 , @labath wrote: > I disagree, and my main reason for that is that this approach requires > hardcoding the "supported architectures" for which we do this fixup in the > DynamicRegisterInfo class. Besides being

[Lldb-commits] [PATCH] D91422: [lldb] [Process/FreeBSDRemote] Check for regset support early [WIP]

omjavaid added a comment. In D91422#2396697 , @labath wrote: > My guess is that this is because of the extra debug registers that you're > exposing. You'll notice that Get(User)RegisterSetCount returns just a number, > and this means that it is not reall

[Lldb-commits] [PATCH] D91057: [LLDB] Update SVE Z reg info to remove invalidate regs

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcca6fe93f04: [LLDB] Update SVE Z reg info to remove invalidate regs (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D90741: [LLDB] Fix SVE reginfo for sequential offset in g packet

This revision was automatically updated to reflect the committed changes. Closed by commit rG661e4040ac60: [LLDB] Fix SVE reginfo for sequential offset in g packet (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2402491 , @labath wrote: > Yes, this is pretty much what I hoped for. Thanks. > > Besides relaxing existing tests, it would be nice to have a positive test > that checks for the behavior that we want. Maybe a gdb-client

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

omjavaid added a comment. In D91497#2404813 , @labath wrote: > Looks good to me. @omjavaid, could you take a quick look at the > invalidate/contained register lists? These list look good. Also I like the approach of using single invalidate list for fise

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: kristof.beyls, emaste. omjavaid requested review of this revision. This came up while putting together our new strategy to create g/G packets where register offsets are calculated in increasing order of r

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

omjavaid added a comment. In D92063#2416162 , @labath wrote: > +@mgorny, as he's been navigating these waters lately... > > So... I presume we can't just slap `__attribute__((packed))` on the > structure, because the kernel actually expects that the data

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

omjavaid updated this revision to Diff 307769. omjavaid added a comment. Update as per my last comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92063/new/ https://reviews.llvm.org/D92063 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

omjavaid added a comment. In D92063#2417815 , @mgorny wrote: > In D92063#2416162 , @labath wrote: > >> +@mgorny, as he's been navigating these waters lately... >> >> So... I presume we can't just slap `__attribute__

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

omjavaid added a comment. In D92063#2417948 , @mgorny wrote: > I disagree. Since we're repeating gdb protocol, it would be nice to use > offsets consistent with the gdb protocol, even if it means some extra > padding. I do realize that this is broken rig

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid updated this revision to Diff 307954. omjavaid added a comment. This update improves on last patch by adding support for register ordering in increasing order of register number even if register numbers are used randomly in target xml. Also we set offset to LLDB_INVALID_INDEX32 while in

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2422100 , @labath wrote: > Looks great. One question about the member variable... m_remote_to_local_regnum_map is used by AddRegister where we add a (key,value) pair for each of registers. We are doing this to maintain

[Lldb-commits] [PATCH] D82853: [LLDB] Support custom expedited register set in gdb-remote

This revision was automatically updated to reflect the committed changes. Closed by commit rGb69c09bf4352: Support custom expedited register set in gdb-remote (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D82855: [LLDB] Send SVE vg register in custom expedited registerset

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e8aeb97ca41: Send SVE vg register in custom expedited registerset (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2422517 , @labath wrote: > In D91241#2422403 , @omjavaid wrote: > >> In D91241#2422100 , @labath wrote: >> >>> Looks great. One question a

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

omjavaid updated this revision to Diff 308338. omjavaid added a comment. Updated incorporating suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92063/new/ https://reviews.llvm.org/D92063 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp l

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid updated this revision to Diff 308339. omjavaid added a comment. Updated after incorporating suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91241/new/ https://reviews.llvm.org/D91241 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h lldb/package

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 308340. omjavaid added a comment. Updated after re-base over D91241 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicReg

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 308341. omjavaid added a comment. Updated after re-base over D91241 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 Files: lldb/source/Plugins/Process/Linux/NativeRegiste

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

omjavaid updated this revision to Diff 308343. omjavaid added a comment. Updated after rebase over D91241 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82866/new/ https://reviews.llvm.org/D82866 Files: lldb/test/API/commands/register/register/aarch6

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

This revision was automatically updated to reflect the committed changes. Closed by commit rG26b8ea2e3782: RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rG78cb4562faa7: Make offset field optional in RegisterInfo packet for Arm64 (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 308863. omjavaid added a comment. Updated after incorporating suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/s

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 308932. omjavaid added a comment. Added copy constructor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/source/Plugins/Process/U

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 309860. omjavaid added a comment. This update resolves review comments from @rovka and @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInf

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid added a comment. @labath Is this ok for commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

omjavaid added a comment. Herald added a subscriber: NickHung. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82866/new/ https://reviews.llvm.org/D82866 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. Herald added a subscriber: NickHung. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 314325. omjavaid added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/source/Plugins/Process/Utility/DynamicRe

[Lldb-commits] [PATCH] D94008: [LLDB] DynamicRegisterInfo calculate offsets in separate function

omjavaid created this revision. omjavaid added a reviewer: labath. omjavaid requested review of this revision. This patch pull offset calculation logic out of DynamicRegisterInfo::Finalize into a separate function. We are going to call this function whenever we update SVE register sizes. https

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 314327. omjavaid added a comment. @labath I have incorporated your suggestions in this update. Invalidate all registers as SVE size update is not a high frequency occurrence. Also using same logic for offset calculation as we did DynamicRegisterInfo::Final

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

omjavaid updated this revision to Diff 314328. omjavaid added a comment. Added separate thread functions for both threads. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82866/new/ https://reviews.llvm.org/D82866 Files: lldb/test/API/commands/register/register/aarch64_sve_registers/r

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid updated this revision to Diff 316354. omjavaid added a comment. Herald added a subscriber: pengfei. This update adds a new test case that checks for register number mismatch between lldb and gdb stub. LLDB client assigns register numbers to target xml registers in increasing order start

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fd77668b2cc: [LLDB] Add per-thread register infos shared pointer in gdb-remote (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D94008: [LLDB] DynamicRegisterInfo calculate offsets in separate function

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9993fcbf53a: DynamicRegisterInfo calculate offsets in separate function (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D94008?vs=314326&id=31689

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 317036. omjavaid added a comment. @labath incorporated your suggestion. Good for commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinu

[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

omjavaid updated this revision to Diff 317049. omjavaid added a comment. @labath addresses your review comments in current diff. Any further changes or this is ok ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77043/new/ https://reviews.llvm.org/D77043 Files: lldb/source/Plugins/Pr

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

This revision was automatically updated to reflect the committed changes. Closed by commit rGe448ad787e16: [LLDB] Add support to resize SVE registers at run-time (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d3081331ad8: [LLDB] Test SVE dynamic resize with multiple threads (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

omjavaid added a comment. In D77043#2515233 , @labath wrote: > There's still one "opportunistic" snippet in `GDBRemoteRegisterContext.cpp`, > around line 404. Did you forget about that, or is there something special > about that case? (if so, then what?)

[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

omjavaid updated this revision to Diff 320373. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77043/new/ https://reviews.llvm.org/D77043 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.h lldb/source/Plugins/P

[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

omjavaid marked an inline comment as done. omjavaid added a comment. @labath I have made suggested adjustment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77043/new/ https://reviews.llvm.org/D77043 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

This revision was automatically updated to reflect the committed changes. Closed by commit rG8561ad9296b7: Use remote regnums in expedited list, value regs and invalidate regs (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. This is the first patch in series for supporting Arm64 dynamic features in LLDB. Arm64 has dynamic features like SVE, Pointer Authentication and

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. This patch builds on D96458 and add ability to pull in Aux Vector HWCAP information into NativeRegisterContext

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. This patch adds two new register sets for MTE and Pointer Authentication feature registers. These register sets are dynamic and will only be ava

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. This patch adds a test case to test dynamic register sets. This tests for the availability of certain register sets and query their registers ac

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid marked 2 inline comments as done. omjavaid added a comment. In D77043#1971486 , @labath wrote: > Register infos in lldb are a mess. However lldb seems to be able to > communicate (more or less successfully) with stub which know nothing about > l

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid added a comment. In D77047#1971454 , @labath wrote: > In D77047#1966539 , @omjavaid wrote: > > > @labath Core file FP register access is not supported on AArch64. I am > > working on a follow up patch to f

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid added a comment. @labath I have considered alternatives which can be used to avoid this patch altogether. We are creating dynamic register infos vector for SVE in D77047 . This is needed because we have update register size and offset of SVE registers.

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid marked 4 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1191 + size_t vq = sve_vq_from_vl(m_sve_header.vl); + SetRegisterInfoMode(vq); + m_sve_ptrace_

[Lldb-commits] [PATCH] D77793: Fix LLDB elf core dump register access for ARM/AArch64

omjavaid updated this revision to Diff 259182. omjavaid added a comment. Updated diff after implementing core file using assembly code. Also removed the redundant register info is null condition. LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77793/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid added a comment. Also about licensing issues of included macros I am in contact with original authors from ARM and I hope they will be able to help sign off this patch for LLVM submission. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D7704

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This causes multiple test failures on LLDB AArch64 Linux buildbot. http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/3695 Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

omjavaid requested changes to this revision. omjavaid added a comment. This revision now requires changes to proceed. I have temporarily reverted this change to turn buildbot green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://r

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG478619cf9a24: Revert "get rid of PythonInteger::GetInteger()" (authored by omjavaid). Changed prior to commit: https:

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid added a comment. In D77043#1996983 , @labath wrote: > Where does the option which I proposed fit in? It sounds like it would be > something like 1a), where we don't actually modify the "invalidate" numbers > stored within lldb-server, but we jus

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Thanks for getting this fixed. Looks good now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462

[Lldb-commits] [PATCH] D75607: [lldb] Use llvm::MC for register numbers in AArch64 ABIs

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Looks good to me. Tested on AArch64/Linux with no regressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75607/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D77044: Extend max register size to accommodate AArch64 SVE vector regs

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f8b4472fb60: Extend max register size to accommodate AArch64 SVE vector regs (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D77793: Fix LLDB elf core dump register access for ARM/AArch64

This revision was automatically updated to reflect the committed changes. omjavaid marked an inline comment as done. Closed by commit rGe35dbb3c8878: Fix LLDB elf core dump register access for ARM/AArch64 (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://rev

[Lldb-commits] [PATCH] D75607: [lldb] Use llvm::MC for register numbers in AArch64 ABIs

omjavaid added a subscriber: clayborg. omjavaid added a comment. In D75607#2020365 , @labath wrote: > Thanks for trying this out. Do you by any chance have any ideas why would > lldb assign a dwarf number to the pc register when neither llvm nor the arm64

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid updated this revision to Diff 263107. omjavaid added a comment. @labath as per your suggestion I have implemented a solution where we fixup register index before sending them to the host in xml or registerinfos packet. Also two new helper functions are added which can be overriden by re

[Lldb-commits] [PATCH] D77045: Minor fixups to LLDB AArch64 register infos macros for SVE register infos

omjavaid added a comment. In D77045#1966540 , @omjavaid wrote: > In D77045#1963896 , @labath wrote: > > > In D77045#1956879 , @omjavaid > > wrote: > > > > > Adding a testcas

[Lldb-commits] [PATCH] D77045: Minor fixups to LLDB AArch64 register infos macros for SVE register infos

omjavaid updated this revision to Diff 263105. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77045/new/ https://reviews.llvm.org/D77045 Files: lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h Index: lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h ==

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid created this revision. omjavaid added reviewers: labath, jasonmolenda, clayborg. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. This patch adds NativeRegisterContext_arm64 ptrace routines to access AArch64 SVE registers. This patch also

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid updated this revision to Diff 263106. omjavaid added a comment. This patch now contains AArch64 SVE register infos description and support for core dump SVE register access. Linux ptrace support will be submitted in a follow up patch while linux ptrace headers are being submitted by Arm

[Lldb-commits] [PATCH] D79491: [lldb] Revive TestBasicEntryValuesX86_64

omjavaid added a comment. This breaks on arm-linux. I am going remove arm temporarily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79491/new/ https://reviews.llvm.org/D79491 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D79777: Fix error in TestNumThreads.py when frame.GetFunctionName returns none

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. This patch fixes an error happening in TestNumThreads.py when it encounters frame.GetFunctionName none for address only locations in stripped libc. This error was showing up on arm-linux

[Lldb-commits] [PATCH] D79777: Fix error in TestNumThreads.py when frame.GetFunctionName returns none

This revision was automatically updated to reflect the committed changes. Closed by commit rG0796b170fb3b: Fix error in TestNumThreads.py when frame.GetFunctionName returns none (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid marked 2 inline comments as done. omjavaid added a comment. In D77043#2031339 , @labath wrote: > The invalidate_regs part looks as I would expect. I think it ought to be > implemented a bit differently, but that can wait until the bigger issue is

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 263935. omjavaid added a comment. This new updated patch overrides GetRegisterInfoAtIndex in NativeRegisterContextLinux_arm64 to reduce the impacts of register numbering conversion on the generic LLGS code. CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid updated this revision to Diff 263937. omjavaid added a comment. This updated diff reduces impact of register numbering correction on LLGS code by removing UserRegIndexToRegInfosIndex out of the code and instead overriding GetRegisterInfoAtIndex in NativeRegisterContextLinux_arm64. CHA

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 263934. omjavaid added a comment. New update contains minor update needed to accommodate SVE PTrace macros header from ARM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files: lldb/include/lldb/Target

[Lldb-commits] [PATCH] D80104: [LLDB] Remove code duplication from RegisterContextPOSIX_*

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: atanasyan, kbarton, kristof.beyls, nemanjai. This patch aims to remove multiple copies of GetByteOrder() and ConvertRegisterKindToRegisterNumber used in various versions of RegisterContextPOSIX_*. Both

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: danielkiss, atanasyan, kristof.beyls, emaste. This patch aims to combine similar arm64 register set definitions defined in NativeRegisterContextLinux_arm64 and RegisterContextPOSIX_arm64. I have implement

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid added a comment. In D77043#2041844 , @labath wrote: > Sorry, about the delay. I had to find some time to dig into the code again, > to understand all of the interactions. > > It seems that we (lldb) have painted ourselves in the corner somewhat.

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This patch breaks lldb unit tests on lldb-arm-ubuntu buildbot. http://lab.llvm.org:8014/builders/lldb-arm-ubuntu/builds/1697 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D80104: [LLDB] Remove code duplication from RegisterContextPOSIX_*

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c45532908ba: Remove code duplication from RegisterContextPOSIX_* (authored by omjavaid). Herald added a subscriber: jrtc27. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 271532. omjavaid added a comment. This update remove skipping over register infos requirement by overlapping sve register numbers with debug register numbers which are not required by Linux register context. CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 271528. omjavaid added a comment. This update remove skipping over register infos requirement by overlapping sve register numbers with debug register numbers which are not required by Linux register context. CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D77045: Minor fixups to LLDB AArch64 register infos macros for SVE register infos

omjavaid updated this revision to Diff 271533. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77045/new/ https://reviews.llvm.org/D77045 Files: lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h Index: lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h ==

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid created this revision. omjavaid added a reviewer: labath. omjavaid added a project: LLDB. Herald added subscribers: aaron.ballman, danielkiss, kristof.beyls, tschuett. This patch adds a HowTo document to lldb docs which gives instruction on how to setup QEMU environment for modern Arm64

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid updated this revision to Diff 271534. omjavaid added a comment. This patch is now independent of SVE register support and is only a requirement for the case of where remote stub utilizes xml register description and sends register nos which are not consecutively placed. This patch ensu

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid added a comment. In D82064#2113851 , @rovka wrote: > Hi Omair, > > If this is intended to be more generally useful, I wonder if we should rename > it to something else (e.g. lldb-qemu-howto.txt) and only use AArch64 SVE as a > case study. > > In

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid updated this revision to Diff 274382. omjavaid added a comment. In this updated I have segregated RegisterInfoInterface and RegisterInfoAndSetInterface as two mutually exclusive interfaces. RegisterInfoPosix_arm64 is currently the only class making use of set interface but I am going t

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 274390. omjavaid added a comment. In this updated I have removed overlapping parts of RegisterInfos_arm64.h and RegisterInfos_arm64_sve.h which in turn removes any possibility of duplicate definitions. Both register infos define separate static register in

[Lldb-commits] [PATCH] D82853: [LLDB] Support custom expedited register set in gdb-remote

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. Herald added a reviewer: rengolin. omjavaid added parent revisions: D79699: Add ptrace register access for AArch64 SVE registers, D77047: AArch64 SVE register infos and core file support.

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. Herald added a reviewer: rengolin. In gdb-remote process we have register infos defind GDBRemoteDynamicRegisterInfo reference. In past register infos have remained constant througout the

[Lldb-commits] [PATCH] D82855: [LLDB] Send SVE vg register in custom expedited registerset

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: kristof.beyls, tschuett. Herald added a reviewer: rengolin. omjavaid added parent revisions: D79699: Add ptrace register access for AArch64 SVE registers, D77047: AArch64 SVE register infos and core file s

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. omjavaid added parent revisions: D82853: [LLDB] Support custom expedited register set in gdb-remote, D82855: [LLDB] Send SVE vg register in custom expedited r

[Lldb-commits] [PATCH] D82865: [LLDB] Add GetByteOffset to SBValue interface for reading register offset

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. Herald added a reviewer: rengolin. omjavaid added a child revision: D82866: [LLDB] Test SVE dynamic resize with multiple threads. This patch adds GetByteOffset to SBValue interface for ac

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: kristof.beyls, tschuett. Herald added a reviewer: rengolin. omjavaid added a parent revision: D82863: [LLDB] Add support to resize SVE registers at run-time. omjavaid added a parent revision: D82865: [LLDB

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid marked 6 inline comments as done. omjavaid added a comment. In D77047#2125220 , @labath wrote: > There's always a chance for ODR violations, particularly with header files > defining static objects. This looks better though what I really wanted w

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 275038. omjavaid added a comment. This update remove dependence over generic interfaces by calling ConfigureRegisterContext on every call to ReadRegister/WriteRegister. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 275037. omjavaid added a comment. @labath I have updated diff after resolving issues highlighted. Also I have removed dependence on generic interfaces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files

<    1   2   3   4   5   6   >