[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

2022-06-28 Thread Michael Daniels via Phabricator via lldb-commits
mdaniels added a comment. I do not have commit access, so I would need someone to commit for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

2022-06-16 Thread Michael Daniels via Phabricator via lldb-commits
mdaniels created this revision. mdaniels added reviewers: jingham, clayborg, labath. Herald added a project: All. mdaniels requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The DynamicLoaderPOSIXDYLD::GetStepThroughTrampolinePlan() function w

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

2022-06-16 Thread Michael Daniels via Phabricator via lldb-commits
mdaniels updated this revision to Diff 437741. mdaniels added a comment. Added a simple test case that reproduces the issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOS

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

2022-06-17 Thread Michael Daniels via Phabricator via lldb-commits
mdaniels added a comment. @JDevlieghere could you confirm my understanding of the issue here is correct? It looks like https://github.com/llvm/llvm-project/issues/54250 is the same issue, and should be fix with this as well. Comment at: lldb/test/API/lang/cpp/step-into-names

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

2022-06-20 Thread Michael Daniels via Phabricator via lldb-commits
mdaniels updated this revision to Diff 438347. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp lldb/test/API/lang/cpp/step-through-trampoline/Makefile lldb/test

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

2022-06-20 Thread Michael Daniels via Phabricator via lldb-commits
mdaniels added inline comments. Comment at: lldb/test/API/lang/cpp/step-into-namespace/TestStepIntoNamespace.py:5 + +class StepIntoNamespace(TestBase): +mydir = TestBase.compute_mydir(__file__) labath wrote: > Am I correct in assuming that the "namespace" pa