[Lldb-commits] [lldb] [lldb][test] Add tests for evaluating local variables whose name clashes with Objective-C types (PR #87807)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/87807 >From 734e127b758b00210aa508c84d0222165c036ac4 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 5 Apr 2024 12:10:09 +0100 Subject: [PATCH] [lldb][test] Add tests for evaluating local variables whose nam

[Lldb-commits] [lldb] [lldb][libc++] Adds local_t clock data formatters. (PR #88178)

@@ -1068,6 +1068,29 @@ static void LoadLibCxxFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { eTypeOptionCascade, true); + AddCXXSummary( + cpp_category_sp, + lldb_private::formatters::LibcxxChronoLocalSecondsSummaryProvide

[Lldb-commits] [lldb] [lldb][libc++] Adds local_t clock data formatters. (PR #88178)

https://github.com/Michael137 approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/88178 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add tests for evaluating local variables whose name clashes with Objective-C types (PR #87807)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/87807 >From 734e127b758b00210aa508c84d0222165c036ac4 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 5 Apr 2024 12:10:09 +0100 Subject: [PATCH 1/2] [lldb][test] Add tests for evaluating local variables whose

[Lldb-commits] [lldb] [lldb][test] Add tests for evaluating local variables whose name clashes with Objective-C types (PR #87807)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/87807 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [libc++][CI] Tests LLDB libc++ data formatters. (PR #88312)

Michael137 wrote: Awesome, thanks for doing this!! https://github.com/llvm/llvm-project/pull/88312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][libc++] Adds valarray proxy data formatters. (PR #88613)

@@ -0,0 +1,194 @@ +//===-- LibCxxProxyArray.cpp---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB][libc++] Adds valarray proxy data formatters. (PR #88613)

https://github.com/Michael137 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/88613 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Turn ChildCacheState into an unscoped enum (PR #88703)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/88703 Done for consistency with the rest of the enums in `lldb-enumerations.h`. See https://github.com/llvm/llvm-project/pull/80167#issuecomment-2043721298 >From ba9d7105b334e3969e7f9f172cae37ea4f2f553e Mon Sep 17 0

[Lldb-commits] [lldb] [lldb][NFC] Turn ChildCacheState into an unscoped enum (PR #88703)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/88703 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFCI] Use LangOptions::setLangDefaults when creating new LangOptions (PR #88721)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/88721 This logic was originally copied from `CompilerInstance::parseLangArgs`. Since then, the `CompilerInstance` uses `LangOptions::setLangDefaults` to set up new `LangOptions` instances. In our case, we only ever

[Lldb-commits] [lldb] [lldb][ClangExpressionDeclMap][NFC] Remove unused NameSearchContext::m_found_function (PR #88724)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/88724 This member was never actually used, ever since its introduction in `ca4e0fd7e63b90e6f68044af47248c64f250ee8f`. >From e85bf75077dec2d6aa7d6983bbde222d1c2b3f29 Mon Sep 17 00:00:00 2001 From: Michael Buch Date

[Lldb-commits] [lldb] [lldb][NFC] Turn ChildCacheState into an unscoped enum (PR #88703)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/88703 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFCI] Use LangOptions::setLangDefaults when creating new LangOptions (PR #88721)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/88721 >From f0b309c52a7f497aa021f38f3ce272a1bb3e66ea Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 15 Apr 2024 13:16:58 +0100 Subject: [PATCH] [lldb][TypeSystemClang][NFCI] Use LangOptions::setLangDefaults

[Lldb-commits] [lldb] [lldb][ClangExpressionDeclMap][NFC] Remove unused NameSearchContext::m_found_function (PR #88724)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/88724 >From e85bf75077dec2d6aa7d6983bbde222d1c2b3f29 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 15 Apr 2024 10:37:05 +0100 Subject: [PATCH 1/2] [lldb][ClangExpressionDeclMap][NFC] Remove unused NameSear

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFCI] Use LangOptions::setLangDefaults when creating new LangOptions (PR #88721)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/88721 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionDeclMap][NFC] Remove unused NameSearchContext::m_found_function (PR #88724)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/88724 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make SBType::FindDirectNestedType work with expression ASTs (PR #89183)

Michael137 wrote: > > One thing I'd like to get feedback on is whether this should be looking > > into base classes. The discussion on the original PR focuses on lexically > > nested types, but going through base classes (following usual language > > rules) is another form of nesting. Both the

[Lldb-commits] [lldb] [lldb] Make SBType::FindDirectNestedType work with expression ASTs (PR #89183)

https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/89183 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Remove m_forward_decl_die_to_compiler_type as it never actually being used. (PR #89427)

Michael137 wrote: LGTM thanks for the cleanup! https://github.com/llvm/llvm-project/pull/89427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Remove m_forward_decl_die_to_compiler_type as it never actually being used. (PR #89427)

https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/89427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SB API to access static constexpr member values (PR #89730)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/89730 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SB API to access static constexpr member values (PR #89730)

https://github.com/Michael137 approved this pull request. LGTM with some minor clarification questions/style comments https://github.com/llvm/llvm-project/pull/89730 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb] Add SB API to access static constexpr member values (PR #89730)

@@ -9074,6 +9111,21 @@ CompilerType TypeSystemClang::DeclGetFunctionArgumentType(void *opaque_decl, return CompilerType(); } +Scalar TypeSystemClang::DeclGetConstantValue(void *opaque_decl) { + clang::Decl *decl = static_cast(opaque_decl); + if (clang::VarDecl *var_decl =

[Lldb-commits] [lldb] [lldb] Add SB API to access static constexpr member values (PR #89730)

@@ -1156,6 +1159,10 @@ CompilerType TypeSystemClang::GetTypeForDecl(ObjCInterfaceDecl *decl) { return GetType(getASTContext().getObjCInterfaceType(decl)); } +CompilerType TypeSystemClang::GetTypeForDecl(clang::ValueDecl *value_decl) { Michael137 wrote: Cou

[Lldb-commits] [lldb] [lldb] Add SB API to access static constexpr member values (PR #89730)

@@ -27,6 +27,7 @@ class Task { enum E : unsigned char {} e; union U { } u; +static constexpr long static_constexpr_field = 47; Michael137 wrote: Should we have an XFAIL test for the non-constant case? https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb] Add SB API to access static constexpr member values (PR #89730)

@@ -107,6 +107,35 @@ class SBTypeMemberFunction { lldb::TypeMemberFunctionImplSP m_opaque_sp; }; +class LLDB_API SBTypeStaticField { +public: + SBTypeStaticField(); + + SBTypeStaticField(const lldb::SBTypeStaticField &rhs); + lldb::SBTypeStaticField &operator=(const lldb:

[Lldb-commits] [lldb] [lldb] Add SB API to access static constexpr member values (PR #89730)

@@ -1156,6 +1159,10 @@ CompilerType TypeSystemClang::GetTypeForDecl(ObjCInterfaceDecl *decl) { return GetType(getASTContext().getObjCInterfaceType(decl)); } +CompilerType TypeSystemClang::GetTypeForDecl(clang::ValueDecl *value_decl) { Michael137 wrote: Ahh

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

@@ -1203,26 +1203,23 @@ bool StackFrame::IsArtificial() const { return m_stack_frame_kind == StackFrame::Kind::Artificial; } -lldb::LanguageType StackFrame::GetLanguage() { +SourceLanguage StackFrame::GetLanguage() { CompileUnit *cu = GetSymbolContext(eSymbolContextCompUn

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

https://github.com/Michael137 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/89981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/89981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Unify DW_TAG -> string conversions (PR #90657)

https://github.com/Michael137 approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/90657 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Teach LocateExecutableSymbolFile to look into LOCALBASE on FreeBSD (PR #81355)

https://github.com/Michael137 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/81355 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

@@ -1664,13 +1793,40 @@ DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc, } if (dwarf->GetUniqueDWARFASTTypeMap().Find( -unique_typename, die, unique_decl, attrs.byte_size.value_or(-1), -*unique_ast_entry_up)) { +u

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/90663 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

https://github.com/Michael137 commented: The idea makes sense and I like that we could factor things out of `ParseStructureLikeDIE`, so generally LGTM (module Pavel's comments). Is any of it testable? https://github.com/llvm/llvm-project/pull/90663 _

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

@@ -16,60 +16,65 @@ using namespace lldb_private::plugin::dwarf; bool UniqueDWARFASTTypeList::Find(const DWARFDIE &die, const lldb_private::Declaration &decl, const int32_t byte_size, +

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/90663 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

Michael137 wrote: > > Is any of it testable? > > Good question. Though this is mostly meant to be "NFC" (with very large > quotes), I can imagine us doing something like forcing the parsing of a > specific type (`type lookup ` ?), and then checking that the > module ast (`image dump ast`) doe

[Lldb-commits] [lldb] [lldb] Add SBType::GetByteAlign (PR #90960)

https://github.com/Michael137 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/90960 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Remove unused DWARF value-to-name functions (PR #91010)

https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/91010 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make SBType::GetDirectNestedType (mostly) work with typedefs (PR #91189)

https://github.com/Michael137 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/91189 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/91452 This is an attempt at displaying the work that's being done by LLDB when waiting on type-completion events, e.g., when running an expression. We add three new progress reports (across three commits): 1. When

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

Michael137 wrote: Example of what the DIE parsing progress looks like: https://github.com/llvm/llvm-project/assets/14071464/bd589ddd-c933-4e14-a380-f4db177e33d4 https://github.com/llvm/llvm-project/pull/91452 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

@@ -1411,3 +1414,35 @@ clang::Decl * ClangASTImporter::ASTImporterDelegate::GetOriginalDecl(clang::Decl *To) { return m_main.GetDeclOrigin(To).decl; } + +void ClangASTImporter::ASTImporterDelegate::UpdateImportProgress( Michael137 wrote: These asserts should

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/91452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

@@ -1411,3 +1414,35 @@ clang::Decl * ClangASTImporter::ASTImporterDelegate::GetOriginalDecl(clang::Decl *To) { return m_main.GetDeclOrigin(To).decl; } + +void ClangASTImporter::ASTImporterDelegate::UpdateImportProgress( +clang::Decl const *From) { + assert(From && +

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/91452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve type name parsing (PR #91586)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/91586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve type name parsing (PR #91586)

@@ -492,12 +494,37 @@ class Type : public std::enable_shared_from_this, public UserID { static int Compare(const Type &a, const Type &b); + // Represents a parsed type name coming out of GetTypeScopeAndBasename. The + // structure holds StringRefs pointing to portions of

[Lldb-commits] [lldb] [lldb] Improve type name parsing (PR #91586)

https://github.com/Michael137 approved this pull request. Looks much cleaner now, thanks! https://github.com/llvm/llvm-project/pull/91586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

Michael137 wrote: > I am somewhat worried about this slowing down the actual operations it is > reporting progress on. I didn't really measure this, but intuitively, I'd > expect that a one of these operations (parsing/importing one type) would be > pretty fast, and that the whole process take

[Lldb-commits] [lldb] d1e9d0b - [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Author: Michael Buch Date: 2022-07-12T10:13:55+01:00 New Revision: d1e9d0b27f3a59f80787bfe5cf10d4373275c477 URL: https://github.com/llvm/llvm-project/commit/d1e9d0b27f3a59f80787bfe5cf10d4373275c477 DIFF: https://github.com/llvm/llvm-project/commit/d1e9d0b27f3a59f80787bfe5cf10d4373275c477.diff

[Lldb-commits] [lldb] 4d26faa - [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

Author: Michael Buch Date: 2022-07-12T10:33:41+01:00 New Revision: 4d26faa5262e7940399df04533a31d9642d23349 URL: https://github.com/llvm/llvm-project/commit/4d26faa5262e7940399df04533a31d9642d23349 DIFF: https://github.com/llvm/llvm-project/commit/4d26faa5262e7940399df04533a31d9642d23349.diff

[Lldb-commits] [lldb] 6703812 - [LLDB][DataFormatter] Add support for std::__map_const_iterator

Author: Michael Buch Date: 2022-07-21T14:21:12+01:00 New Revision: 6703812688b84100a159ec793f677952ea8e3eba URL: https://github.com/llvm/llvm-project/commit/6703812688b84100a159ec793f677952ea8e3eba DIFF: https://github.com/llvm/llvm-project/commit/6703812688b84100a159ec793f677952ea8e3eba.diff

[Lldb-commits] [lldb] 140bcd3 - [LLDB][ClangExpression] Fix initialization of static enum alias members

Author: Michael Buch Date: 2022-07-21T14:23:41+01:00 New Revision: 140bcd369b0fd61f19cdeabf4be2fe68d5f9804b URL: https://github.com/llvm/llvm-project/commit/140bcd369b0fd61f19cdeabf4be2fe68d5f9804b DIFF: https://github.com/llvm/llvm-project/commit/140bcd369b0fd61f19cdeabf4be2fe68d5f9804b.diff

[Lldb-commits] [lldb] fcf4e25 - [LLDB][NFC] Create variable for hardcoded alignment/size constants in materializer

Author: Michael Buch Date: 2022-07-22T08:02:07+01:00 New Revision: fcf4e252f4d992cade4bdfe5aed10ff96fa40202 URL: https://github.com/llvm/llvm-project/commit/fcf4e252f4d992cade4bdfe5aed10ff96fa40202 DIFF: https://github.com/llvm/llvm-project/commit/fcf4e252f4d992cade4bdfe5aed10ff96fa40202.diff

[Lldb-commits] [lldb] 317c8bf - [LLDB][Expression] Allow instantiation of IR Entity from ValueObject

Author: Michael Buch Date: 2022-07-22T08:02:08+01:00 New Revision: 317c8bf84d185c6b4a51a415c0deb7f8af661cb6 URL: https://github.com/llvm/llvm-project/commit/317c8bf84d185c6b4a51a415c0deb7f8af661cb6 DIFF: https://github.com/llvm/llvm-project/commit/317c8bf84d185c6b4a51a415c0deb7f8af661cb6.diff

[Lldb-commits] [lldb] 8184b25 - [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Author: Michael Buch Date: 2022-07-22T08:02:09+01:00 New Revision: 8184b252cdab2fbe44f766d6de28b29ebe4c8753 URL: https://github.com/llvm/llvm-project/commit/8184b252cdab2fbe44f766d6de28b29ebe4c8753 DIFF: https://github.com/llvm/llvm-project/commit/8184b252cdab2fbe44f766d6de28b29ebe4c8753.diff

[Lldb-commits] [lldb] 0a412b3 - [LLDB][ClangExpression] Prevent nullptr namespace map access during logging

Author: Michael Buch Date: 2022-07-26T15:47:35+01:00 New Revision: 0a412b3505f42558573e0d9005d4fe7c6102d8c9 URL: https://github.com/llvm/llvm-project/commit/0a412b3505f42558573e0d9005d4fe7c6102d8c9 DIFF: https://github.com/llvm/llvm-project/commit/0a412b3505f42558573e0d9005d4fe7c6102d8c9.diff

[Lldb-commits] [lldb] af4cdfe - [lldb][unittests] Add more test cases to CPlusPlusNameParser unit-tests

Author: Michael Buch Date: 2022-08-11T15:05:48+01:00 New Revision: af4cdfe136056426eaf63a113067791dad3820c3 URL: https://github.com/llvm/llvm-project/commit/af4cdfe136056426eaf63a113067791dad3820c3 DIFF: https://github.com/llvm/llvm-project/commit/af4cdfe136056426eaf63a113067791dad3820c3.diff

[Lldb-commits] [lldb] ac1bedd - [lldb][debugserver] Revert "Use llvm::all_of (NFC)" for debugserver

Author: Michael Buch Date: 2022-08-15T17:35:39+01:00 New Revision: ac1bedd584359567266b1c41ac26734556031b9f URL: https://github.com/llvm/llvm-project/commit/ac1bedd584359567266b1c41ac26734556031b9f DIFF: https://github.com/llvm/llvm-project/commit/ac1bedd584359567266b1c41ac26734556031b9f.diff

[Lldb-commits] [lldb] 88d3c1d - [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

Author: Michael Buch Date: 2022-08-17T09:02:43+01:00 New Revision: 88d3c1db453189c3c76b5b83e4d47b2c7f4adf1f URL: https://github.com/llvm/llvm-project/commit/88d3c1db453189c3c76b5b83e4d47b2c7f4adf1f DIFF: https://github.com/llvm/llvm-project/commit/88d3c1db453189c3c76b5b83e4d47b2c7f4adf1f.diff

[Lldb-commits] [lldb] 33833c8 - [lldb][Tests] Skip static-only tests in TestConstStaticIntegralMember.py for dsym variant

Author: Michael Buch Date: 2022-08-17T15:39:21+01:00 New Revision: 33833c861172b48f317743cf3813af3139302052 URL: https://github.com/llvm/llvm-project/commit/33833c861172b48f317743cf3813af3139302052 DIFF: https://github.com/llvm/llvm-project/commit/33833c861172b48f317743cf3813af3139302052.diff

[Lldb-commits] [lldb] 5517401 - Revert "[lldb] [gdb-remote] Include PID in vCont packets if multiprocess"

Author: Michael Buch Date: 2022-08-19T18:05:41+01:00 New Revision: 5517401f936ab5cb9db001030f027293d44aac92 URL: https://github.com/llvm/llvm-project/commit/5517401f936ab5cb9db001030f027293d44aac92 DIFF: https://github.com/llvm/llvm-project/commit/5517401f936ab5cb9db001030f027293d44aac92.diff

[Lldb-commits] [lldb] 1dc8fcf - Revert "[lldb] [gdb-remote] Include PID in vCont packets if multiprocess" - Part 2

Author: Michael Buch Date: 2022-08-19T19:31:14+01:00 New Revision: 1dc8fcff0e957ee137f59f94859a983425c1ba83 URL: https://github.com/llvm/llvm-project/commit/1dc8fcff0e957ee137f59f94859a983425c1ba83 DIFF: https://github.com/llvm/llvm-project/commit/1dc8fcff0e957ee137f59f94859a983425c1ba83.diff

[Lldb-commits] [lldb] 6f19f98 - [lldb][Test] Replace expect() with expect_expr() in TestNamespaceLookup.py

Author: Michael Buch Date: 2022-08-22T13:22:19+01:00 New Revision: 6f19f98710f897ecaf148f42da6eec9d14631449 URL: https://github.com/llvm/llvm-project/commit/6f19f98710f897ecaf148f42da6eec9d14631449 DIFF: https://github.com/llvm/llvm-project/commit/6f19f98710f897ecaf148f42da6eec9d14631449.diff

[Lldb-commits] [lldb] 09f608f - [lldb][ClangExpression] Remove storage-class check when creating AsmLabel

Author: Michael Buch Date: 2022-08-22T13:22:20+01:00 New Revision: 09f608fda51ca9dd2d88c2985bad1cfc1e36251e URL: https://github.com/llvm/llvm-project/commit/09f608fda51ca9dd2d88c2985bad1cfc1e36251e DIFF: https://github.com/llvm/llvm-project/commit/09f608fda51ca9dd2d88c2985bad1cfc1e36251e.diff

[Lldb-commits] [lldb] [lldb][ValueObject][NFC] Remove unused parameter to ReadPointedString (PR #77919)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/77919 The need for it was removed in `2206b48d6ddabad61979fa69ba09e6b6fb19b0b2`. >From c1ee450df703a4026923b501e8228c16ff019527 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 12 Jan 2024 12:32:02 + Subj

[Lldb-commits] [lldb] [lldb][ValueObject][NFC] Remove unused parameter to ReadPointedString (PR #77919)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/77919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add tests for target.max-string-summary-length setting (PR #77920)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/77920 This adds API tests for the `target.max-string-summary-length`, which was recently fixed in https://github.com/llvm/llvm-project/pull/72233 >From 4de3716b55a22dc8b7dda621889089f390026739 Mon Sep 17 00:00:00 2

[Lldb-commits] [lldb] [lldb] Fix MaxSummaryLength target property type (PR #72233)

Michael137 wrote: Added tests in: https://github.com/llvm/llvm-project/pull/77920 https://github.com/llvm/llvm-project/pull/72233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add tests for target.max-string-summary-length setting (PR #77920)

@@ -295,6 +295,23 @@ def cleanup(): substrs=["e_2", "n_2", "r_2", "i_2", "k_2", "o_2"], ) +self.runCmd("settings set target.max-string-summary-length 5") +some_string = self.frame().FindVariable('some_string') +some_string_summary =

[Lldb-commits] [lldb] [lldb][test] Add tests for target.max-string-summary-length setting (PR #77920)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/77920 >From 4de3716b55a22dc8b7dda621889089f390026739 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 12 Jan 2024 12:34:16 + Subject: [PATCH 1/2] [lldb][test] Add tests for target.max-string-summary-lengt

[Lldb-commits] [lldb] [lldb][ValueObject][NFC] Remove unused parameter to ReadPointedString (PR #77919)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/77919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang] [clang-tools-extra] [llvm] [lldb][test] Add tests for target.max-string-summary-length setting (PR #77920)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/77920 >From 4de3716b55a22dc8b7dda621889089f390026739 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 12 Jan 2024 12:34:16 + Subject: [PATCH 1/2] [lldb][test] Add tests for target.max-string-summary-lengt

[Lldb-commits] [clang] [llvm] [clang-tools-extra] [lldb] [lldb][test] Add tests for target.max-string-summary-length setting (PR #77920)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/77920 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds missing C++20 calendar data formatters. (PR #77954)

https://github.com/Michael137 approved this pull request. LGTM thanks! https://github.com/llvm/llvm-project/pull/77954 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ValueObject][NFC] Further remove redundant parameters to ReadPointedString (PR #78029)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/78029 We only ever call this function once, without relying on the defaulted `honor_array` parameter, so make it non-defaulted. Also `max_length` is always set to `0`, so remove it entirely. This simplifies some u

[Lldb-commits] [lldb] [lldb][ValueObject][NFC] Further remove redundant parameters to ReadPointedString (PR #78029)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/78029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

@@ -1073,18 +1073,79 @@ bool lldb_private::formatters::LibcxxWStringViewSummaryProvider( bool success; ValueObjectSP dataobj; size_t size; - std::tie( success, dataobj, size ) = LibcxxExtractStringViewData(valobj); + std::tie(success, dataobj, size) = LibcxxExtractStri

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

@@ -32,6 +32,106 @@ def test_with_run_command(self): self.expect("frame variable m", substrs=["m = 4321 months"]) self.expect("frame variable y", substrs=["y = 321 years"]) +self.expect( +"frame variable ss_tp", +substrs=["ss_tp

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

https://github.com/Michael137 approved this pull request. LGTM (with minor questions) https://github.com/llvm/llvm-project/pull/78609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Use GetFirstValueOfLibCXXCompressedPair in std::map formatter (PR #80133)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/80133 This avoids duplicating the logic to get the first element of a libc++ `__compressed_pair`. This will be useful in upcoming refactorings of this formatter. Drive-by changes: * Renamed `m_item` to `size_node`

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Use GetFirstValueOfLibCXXCompressedPair in std::map formatter (PR #80133)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/80133 >From da7c51b254087fc45fab7133e63d44782899d57f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 31 Jan 2024 12:14:20 + Subject: [PATCH] [lldb][DataFormatter][NFC] Use GetFirstValueOfLibCXXCompressed

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Use GetFirstValueOfLibCXXCompressedPair throughout formatters (PR #80133)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/80133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Use GetFirstValueOfLibCXXCompressedPair throughout formatters (PR #80133)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/80133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Use GetFirstValueOfLibCXXCompressedPair throughout formatters (PR #80133)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/80133 >From da7c51b254087fc45fab7133e63d44782899d57f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 31 Jan 2024 12:14:20 + Subject: [PATCH 1/2] [lldb][DataFormatter][NFC] Use GetFirstValueOfLibCXXCompre

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Use GetFirstValueOfLibCXXCompressedPair throughout formatters (PR #80133)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/80133 >From da7c51b254087fc45fab7133e63d44782899d57f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 31 Jan 2024 12:14:20 + Subject: [PATCH 1/4] [lldb][DataFormatter][NFC] Use GetFirstValueOfLibCXXCompre

[Lldb-commits] [lldb] [lldb][TypeSynthetic] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/80167 This patch changes the return value of `SyntheticChildrenFrontend::Update` to a scoped enum that aims to describe what the return value means. >From 921a20776ee76d8e6b0e8f50705f3728643e08b3 Mon Sep 17 00:00:0

[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/80167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Use GetFirstValueOfLibCXXCompressedPair throughout formatters (PR #80133)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/80133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/80167 >From a899377f8d0e0b28f8d87c8ea1770bd233c6616f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 31 Jan 2024 15:51:03 + Subject: [PATCH] [lldb][TypeSynthetic] Make SyntheticChildrenFrontend::Update()

[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

@@ -49,14 +49,17 @@ class SyntheticChildrenFrontEnd { virtual size_t GetIndexOfChildWithName(ConstString name) = 0; - // this function is assumed to always succeed and it if fails, the front-end - // should know to deal with it in the correct way (most probably, by refusi

[Lldb-commits] [lldb] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

Michael137 wrote: > But if it'd require substantial reengineering to clang to get this working - > this seems an unfortunate regression to carry in the interim, and it might be > worth reverting to the previous (differently buggy, but at least > work-around-able) behavior. To clarify, the reg

[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

@@ -49,14 +49,17 @@ class SyntheticChildrenFrontEnd { virtual size_t GetIndexOfChildWithName(ConstString name) = 0; - // this function is assumed to always succeed and it if fails, the front-end - // should know to deal with it in the correct way (most probably, by refusi

[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

@@ -1305,6 +1305,13 @@ enum CompletionType { eTerminatorCompletion = (1ul << 27) }; +/// Specifies if children need to be re-computed +/// after a call to \ref SyntheticChildrenFrontEnd::Update. +enum class ChildCacheState { + eRefetch = 0, ///< Children need to be recomput

[Lldb-commits] [lldb] [lldb] Add frame recognizer for __builtin_verbose_trap (PR #80368)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/80368 This patch adds a frame recognizer for Clang's `__builtin_verbose_trap`, which behaves like a `__builtin_trap`, but emits a failure-reason string into debug-info in order for debuggers to display it to a user.

[Lldb-commits] [lldb] [lldb] Add frame recognizer for __builtin_verbose_trap (PR #80368)

Michael137 wrote: > The patch looks fine to me, but I'm a bit bugged by the fact that it is in > Target. In my mind, this is part of the C LanguageRuntime, except we don't > yet have a C Language Runtime... But in any case, somewhere more specific > than Target. Seems reasonable to me. Should

[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

Michael137 wrote: ping https://github.com/llvm/llvm-project/pull/80167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    4   5   6   7   8   9   10   11   12   13   >