[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:1025-1027 -except Exception as e: -result.PutCString("error: python exception: %s" % e) -return What about printing the exception backtrace and exiting cleaning instead of

[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

mib accepted this revision. mib added inline comments. This revision is now accepted and ready to land. Comment at: lldb/examples/python/crashlog.py:1025-1027 -except Exception as e: -result.PutCString("error: python exception: %s" % e) -return ---

[Lldb-commits] [PATCH] D125594: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC)

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a subscriber: arphaman. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch renames the `SBCompileUnit::GetIndexForLineEntry` a

[Lldb-commits] [PATCH] D125594: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG174cf2f74762: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex… (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D125716: [lldb] Prevent Overflow (Underflow) error in crashlog.py

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125716/new/ https://reviews.llvm.org/D125716 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D125915: [lldb/Test] Add `use_colors` argument to PExpect.launch wrapper

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds a new `use_colors` argument to the PExpect.launch method. As the name suggests, it

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

mib updated this revision to Diff 430465. mib added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124785/new/ https://reviews.llvm.org/D124785 Files: lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/test/API/functionalities/progress_

[Lldb-commits] [PATCH] D125928: [lldb/crashlog] Fix line entries resolution in interactive mode

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch substracts 1 to the pc of any frame about frame 0 to get the previous line entry and dis

[Lldb-commits] [PATCH] D125928: [lldb/crashlog] Fix line entries resolution in interactive mode

mib updated this revision to Diff 430505. mib marked an inline comment as done. mib edited the summary of this revision. mib added a comment. Updated comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125928/new/ https://reviews.llvm.org/D125928 Files: lldb/examples/python/crashlo

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

mib updated this revision to Diff 430548. mib added a comment. Address @JDevlieghere comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124785/new/ https://reviews.llvm.org/D124785 Files: lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/test/API/fun

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py:49-50 +self.do_test(80, ['Locating external symbol file for a.out...', + 'Loading Apple

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

mib updated this revision to Diff 430552. mib marked an inline comment as done. mib added a comment. Only run test on Darwin platforms CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124785/new/ https://reviews.llvm.org/D124785 Files: lldb/include/lldb/Core/DebuggerEvents.h lldb/sour

[Lldb-commits] [PATCH] D125915: [lldb/Test] Add `use_colors` argument to PExpect.launch wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rGd71d1a947bee: [lldb/Test] Add `use_colors` argument to the PExpect.launch wrapper (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125915/new

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

This revision was automatically updated to reflect the committed changes. Closed by commit rG051a5ae99824: [lldb/Core] Fix "sticky" long progress messages (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124785/new/ https://reviews.l

[Lldb-commits] [PATCH] D125928: [lldb/crashlog] Fix line entries resolution in interactive mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e54ea0cfa30: [lldb/crashlog] Fix line entries resolution in interactive mode (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125928/new/ h

[Lldb-commits] [PATCH] D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125995/new/ https://reviews.llvm.org/D125995 ___ lldb-

[Lldb-commits] [PATCH] D126021: [lldb/test] Fix PExpect.launch issue when disabling color support

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. This patch should fix a bug in PExpect.launch that happened when color support is not enabled. In that case, we need to add the `--no-use-c

[Lldb-commits] [PATCH] D126021: [lldb/test] Fix PExpect.launch issue when disabling color support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG027499a82434: [lldb/test] Fix PExpect.launch issue when disabling color support (authored by mib). Herald added a subscriber: lldb-commits. Reposito

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. For an exception crashlog, the thread backtracesaren't usually very helpful and instead, developper

[Lldb-commits] [PATCH] D127016: [lldb] Prevent crash due to reading memory from page zero.

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with some minor feedbacks :) ! Comment at: lldb/source/Commands/CommandObjectMemory.cpp:597 +ABISP abi; +if (Process * proc = m_exe_ctx.GetProcessPtr()) + abi = p

[Lldb-commits] [PATCH] D127038: Add some documentation for the "breakpoint name" feature

mib added a comment. Thanks for writing that! I'm sure many users will find it very useful. Comment at: lldb/source/Commands/CommandObjectBreakpoint.cpp:2088 +The "liveness" of these settings is one way, from name to breakpoint. +If you use break modify to change an option th

[Lldb-commits] [PATCH] D127258: [lldb] Mark API tests as XFAIL if they have expected failures and no passing tests

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Makes more sense. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127258/new/ https://reviews.llvm.org/D127258 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D127258: [lldb] Mark API tests as XFAIL if they have expected failures and no passing tests

mib accepted this revision. mib added a comment. Even better! LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127258/new/ https://reviews.llvm.org/D127258 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D127355: [lldb] Add assertState function

mib added a comment. Pretty cool but it would be nice to have the following formatting: "AssertionError: stopped (5) != exited (10) : message" ... I feel like it's easier to read this way CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127355/new/ https://reviews.llvm.org/D127355 ___

[Lldb-commits] [PATCH] D127355: [lldb] Add assertState function

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Awesome! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127355/new/ https://reviews.llvm.org/D127355 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D127362: [lldb/crashlog] Show help when the command is called without any argument

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the `crashlog` command behavior to print the help message if no argument was pro

[Lldb-commits] [PATCH] D127362: [lldb/crashlog] Show help when the command is called without any argument

mib updated this revision to Diff 435383. mib added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127362/new/ https://reviews.llvm.org/D127362 Files: lldb/examples/python/crashlog.py lldb/test/Shell/ScriptInterpreter/Python/Crashlog/no-args.test Index: lldb/te

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

mib added a comment. What happens if you try to call __str__ after your change ? I have no objection with this change, I think rather it will greatly improve manipulating SBTypes in the interpreter ! Just making sure this passes the test suite and doesn't break the previous behavior Repositor

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

mib accepted this revision. mib added a comment. Thanks for clarifying! LGTM with a test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127458/new/ https://reviews.llvm.org/D127458 ___ lldb-commits maili

[Lldb-commits] [PATCH] D127038: Add some documentation for the "breakpoint name" feature

mib accepted this revision. mib added a comment. Thanks Jim! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127038/new/ https://reviews.llvm.org/D127038 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D127458: [lldb][bindings] Implement __repr__ instead of __str__

mib accepted this revision. mib added a comment. Thanks @kastiglione ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127458/new/ https://reviews.llvm.org/D127458 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D127362: [lldb/crashlog] Show help when the command is called without any argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9fa21ce82f: [lldb/crashlog] Show help when the command is called without any argument (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1273

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

mib added a comment. How is this any different from running `ninja lldb-target-fuzzer` ? I might be missing something ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127882/new/ https://reviews.llvm.org/D127882 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

mib added a comment. In D127882#3586516 , @mib wrote: > How is this any different from running `ninja lldb-target-fuzzer` ? I might > be missing something ... Never mind, I assumed `lldb-target-fuzzer` would not only build the fuzzer but also run it

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127882/new/ https://reviews.llvm.org/D127882 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter

mib added inline comments. Comment at: lldb/source/Interpreter/embedded_interpreter.py:49-52 +if line == 'exit': +raise LLDBExit +if line == 'quit': +raise LLDBExit kastiglione wrote: > could do: > ``` > if line in ('exit', 'quit'): > ```

[Lldb-commits] [PATCH] D127586: [lldb][Interpreter] Add newline terminal to one-line script calls

mib added a comment. A bit late to this ... thanks for your fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127586/new/ https://reviews.llvm.org/D127586 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

mib added inline comments. Comment at: lldb/source/Utility/Log.cpp:325 std::lock_guard guard(g_LogThreadedMutex); -*stream_sp << message; -stream_sp->flush(); +handler_sp->Emit(message); +handler_sp->Flush(); JDevlieghere wrote: > clayborg wr

[Lldb-commits] [PATCH] D128077: [lldb][tests] Automatically call compute_mydir (NFC)

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Great! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128077/new/ https://reviews.llvm.org/D128077 _

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

mib added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:39 + SBCommandReturnObject ro = SBCommandReturnObject(); + SBCommandInterpreter thisinterpreter = debugger.GetCommandInterpreter(); + ---

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

mib added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:39 + SBCommandReturnObject ro = SBCommandReturnObject(); + SBCommandInterpreter thisinterpreter = debugger.GetCommandInterpreter(); + ---

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

mib added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:39 + SBCommandReturnObject ro = SBCommandReturnObject(); + SBCommandInterpreter thisinterpreter = debugger.GetCommandInterpreter(); + ---

[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

mib added a comment. Herald added a subscriber: JDevlieghere. Hi @mgorny ! `TestNonStop.py` is also failing on the macOS bots: https://green.lab.llvm.org/green/job/lldb-cmake/44743/ Let me know if you need help reproducing the issue, otherwise skip the test on Darwin systems `@skipIfDarwin` Th

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128292/new/ https://reviews.llvm.org/D128292 ___ lldb

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

mib added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1409-1411 +static std::shared_ptr +CreateLogHandler(LogHandlerKind log_handler_kind, int fd, bool should_close, + size_t buffer_size) { Many (or most) arguments passed to this fu

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

mib added inline comments. Comment at: lldb/source/Commands/CommandObjectLog.cpp:167 buffer_size.Clear(); + handler = eLogHandlerStream; log_options = 0; clayborg wrote: > Do we want to define a "eLogHandlerDefault" which points to > "eLogHand

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

mib added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:17 + + # This will create a directory specifially for the fuzzer's artifacts, go to that + # directory and run the fuzzer from there. When the fuzzer exits the input --

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

mib accepted this revision. mib added a comment. Ship it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128292/new/ https://reviews.llvm.org/D128292 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

mib added a comment. @cassanova You probably also want to implement this for the `command-interpreter-fuzzer` target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128450/new/ https://reviews.llvm.org/D128450 __

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have fuzzers write artifacts to specific directory

mib accepted this revision. mib added a comment. This looks way better :) ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128450/new/ https://reviews.llvm.org/D128450 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

mib updated this revision to Diff 480230. mib marked an inline comment as done. mib added a comment. Address @JDevlieghere comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139247/new/ https://reviews.llvm.org/D139247 Files: lldb/include/lldb/Interpreter/ScriptedMetadata.h lldb

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib updated this revision to Diff 480249. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139252/new/ https://reviews.llvm.org/D139252 Files: lldb/source/Plugins/Platform/CMakeLists.txt lldb/source/Plugins/Platform/scripted/CMakeLists.txt lldb/source/Plugins/Platform/scripted/Scripte

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:43-46 +Dict: The processes represented as a dictionary, with at least the +process ID, name, architecture. Optionally, the user can also +

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix an undeterministic error in TestStackCoreScriptedProcess. In order

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

mib updated this revision to Diff 480674. mib added a comment. Run `clang-format` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139484/new/ https://reviews.llvm.org/D139484 Files: lldb/test/API/functionalities/scripted_process/Makefile lldb/test/API/functionalities/scripted_process

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

mib updated this revision to Diff 480796. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139484/new/ https://reviews.llvm.org/D139484 Files: lldb/test/API/functionalities/scripted_process/Makefile lldb/test/API/functionalities/scripte

[Lldb-commits] [PATCH] D139684: Switch the "command script add" interactive editor to use the exe_ctx interface

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139684/new/ https://reviews.llvm.org/D139684

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

mib updated this revision to Diff 481842. mib added a reviewer: bulbazord. mib added a comment. Addressed @jingham @bulbazord comments: - Add docstring to swig interface - Add comment on `nullptr` arguments @bulbazord Having a `PlatformSpec` object is a good idea but I don't think it's necessar

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib updated this revision to Diff 481844. mib marked 3 inline comments as done. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139250/new/ https://reviews.llvm.org/D139250 Files: lldb/bindings/python/CMakeLists.txt lldb/bindings/pytho

[Lldb-commits] [PATCH] D139251: [lldb/Interpreter] Introduce ScriptedPlatform{, Python}Interface

mib updated this revision to Diff 481848. mib marked 4 inline comments as done. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139251/new/ https://reviews.llvm.org/D139251 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h lldb/

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + labath wrote: > I am surprised that you want to go down the

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib updated this revision to Diff 482112. mib marked 3 inline comments as done. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139252/new/ https://reviews.llvm.org/D139252 Files: lldb/examples/python/scripted_process/scripted_platform.p

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib updated this revision to Diff 482113. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139252/new/ https://reviews.llvm.org/D139252 Files: lldb/source/Plugins/Platform/CMakeLists.txt lldb/source/Plugins/Platform/scripted/CMakeLists.txt lldb/source/Plugins/Platform/scripted/Scripte

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

mib created this revision. mib added reviewers: jingham, bulbazord. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch enhances queue support in Scripted Process

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

mib added inline comments. Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp:757 + bool is_scripted_process = m_process->GetPluginName() == "ScriptedProcess"; for (ThreadSP thread_sp : m_process->Threads()) { JDevlieghere wrote: >

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added a comment. ping @JDevlieghere Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + mib wrote: > labath wrote: > > I am surprise

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib updated this revision to Diff 482413. mib marked 7 inline comments as done. mib added a comment. Address @JDevlieghere comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139252/new/ https://reviews.llvm.org/D139252 Files: lldb/source/Plugins/Platform/CMakeLists.txt lldb/so

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

mib updated this revision to Diff 482433. mib added a comment. Update test program and test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139484/new/ https://reviews.llvm.org/D139484 Files: lldb/test/API/functionalities/scripted_process/Makefile lldb/test/API/functionalities/script

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

mib added inline comments. Comment at: lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp:757 + bool is_scripted_process = m_process->GetPluginName() == "ScriptedProcess"; for (ThreadSP thread_sp : m_process->Threads()) { labath wrote: > mib w

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

mib updated this revision to Diff 482486. mib marked an inline comment as done. mib added a comment. Make use of the process plugin model to avoid adding a special case on the system runtime plugin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139853/new/ https://reviews.llvm.org/D139

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

mib added a comment. In D139853#3992058 , @labath wrote: > That definitely looks much better. As I understand it, the scripted thread > interface is more high-level that our internal thread interface, and that > means it is computing its queue by itself

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

mib updated this revision to Diff 482495. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139853/new/ https://reviews.llvm.org/D139853 Files: lldb/include/lldb/Target/Process.h lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp lldb/source/Plugins/Process/scripted/ScriptedProce

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

mib created this revision. mib added reviewers: jingham, labath, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch does several things: First, it refactors the `CommandObject{,Platform}P

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + mib wrote: > mib wrote: > > labath wrote: > > > I am surpri

[Lldb-commits] [PATCH] D139951: [lldb/crashlog] Refactor CrashLogParser into a Factory patern

mib created this revision. mib added reviewers: JDevlieghere, kastiglione. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix an undefined behaviour that's happening when parsing a crash repo

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:33 + +processes = { +420: { bulbazord wrote: > JDevlieghere wrote: > > Why is this method implemented and n

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

mib added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:82 Log *m_log; + std::unique_ptr m_current_progress_up; + std::vector m_module_build_stack; `Progress` makes use of RAII to complete the progress re

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:25-28 void ScriptedThread::CheckInterpreterAndScriptObject() const { - lldbassert(m_script_object_sp && "Invalid Script Object."); - lldbassert(

[Lldb-commits] [PATCH] D140113: [lldb] Force override when adding crashlog command

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. When using interactive crashlog from an IDE, it can happen that the user already have the

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module build remarks

mib accepted this revision. mib added a comment. Yep, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140056/new/ https://reviews.llvm.org/D140056 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib marked 3 inline comments as done. mib added a subscriber: jingham. mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + -

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:317 +PythonObject lldb_private::LLDBSwigPythonCreateScriptedPlatform( +const char *python_class_name, const char *session_dictionary_name, JDevlieghere wrote: > This looks prett

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib updated this revision to Diff 483509. mib added a comment. Update comments for `scripted_platform.list_processes` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139250/new/ https://reviews.llvm.org/D139250 Files: lldb/bindings/python/CMakeLists.txt lldb/bindings/python/python-wr

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added a comment. ping @JDevlieghere CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139250/new/ https://reviews.llvm.org/D139250 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h:105 +Status error; +Dispatch(method_name, error, args...); + labath wrote: > `std::forward(args)...` maybe

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

mib added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:73 bool m_include_platform_option; + OptionGroupPythonClassWithDict m_class_options; }; labath wrote: > labath wrote: > > These nested groups are fairly unusual? Could

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/Platform/scripted/ScriptedPlatform.cpp:261 + if (!proc_info_or_error) { +llvm::consumeError(proc_info_or_error.takeError()); +return false; labath wrote: > W

[Lldb-commits] [PATCH] D140293: [lldb] Update custom commands to always be overrriden

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This is a follow-up patch to 6f7835f309b9. As explained previously, when running from an

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + labath wrote: > mib wrote: > > labath wrote: > > > mib wrot

[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod

mib updated this revision to Diff 484527. mib marked an inline comment as done. mib added a comment. Use `std::forward` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139248/new/ https://reviews.llvm.org/D139248 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterfa

[Lldb-commits] [PATCH] D141021: [lldb] Add lldb-framework-cleanup target

mib added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:247-249 + # Create a target to remove the target again before the install phase. We + # intentionally use remove_directory because the target can be a directory + # and it's harmless for files. ---

[Lldb-commits] [PATCH] D141219: Add a .lldbinit file to autoload LLVM/Clang data formatters

mib added a comment. I guess we could even throw MLIR formatters in there for completeness Comment at: .lldbinit:2-3 +# To autoload set `settings set target.load-cwd-lldbinit true` in ~/.lldbinit +command script import ./llvm/utils/lldbDataFormatters.py +command script import .

[Lldb-commits] [PATCH] D141219: Add a .lldbinit file to autoload LLVM/Clang data formatters

mib added a subscriber: mehdi_amini. mib added a comment. In D141219#4038658 , @mib wrote: > I guess we could even throw MLIR formatters in there for completeness I don't know exactly how well those are maintained ... @mehdi_amini do you think it would

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + labath wrote: > mib wrote: > > labath wrote: > > > mib wrot

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

mib updated this revision to Diff 487989. mib added a comment. Herald added a subscriber: Michael137. Update unittests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139249/new/ https://reviews.llvm.org/D139249 Files: lldb/bindings/interface/SBPlatform.i lldb/include/lldb/API/SBDebu

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib updated this revision to Diff 488004. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere comment: - refactor SWIG scripted object create methods into a single one CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139250/new/ https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D139251: [lldb/Interpreter] Introduce ScriptedPlatform{, Python}Interface

mib updated this revision to Diff 488006. mib marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139251/new/ https://reviews.llvm.org/D139251 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h lldb/include/lldb/Interpreter/ScriptedPlatformInterface.

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib updated this revision to Diff 488014. mib added a comment. Log the error message instead of consuming it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139252/new/ https://reviews.llvm.org/D139252 Files: lldb/source/Plugins/Platform/CMakeLists.txt lldb/source/Plugins/Platform/sc

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

mib updated this revision to Diff 488029. mib added a comment. Address comments from @JDevlieghere & @bulbazord CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139484/new/ https://reviews.llvm.org/D139484 Files: lldb/test/API/functionalities/scripted_process/Makefile lldb/test/API/fu

[Lldb-commits] [PATCH] D140293: [lldb] Update custom commands to always be overrriden

mib updated this revision to Diff 488036. mib added a comment. Fix typo in `crashlog.py` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140293/new/ https://reviews.llvm.org/D140293 Files: lldb/examples/darwin/heap_find/heap.py lldb/examples/python/bsd.py lldb/examples/python/cmdte

<    1   2   3   4   5   6   7   8   9   10   >