electriclilies created this revision.
Herald added a project: All.
electriclilies requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D158009
Files:
lldb/include/lldb/Core/Value
electriclilies added a comment.
Hangon reviewers, I forgot to squash my commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158009/new/
https://reviews.llvm.org/D158009
___
lldb-commits mailing list
l
electriclilies created this revision.
Herald added a project: All.
electriclilies requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Allow the definition of synthetic formatters in C++, and fix linking problems
with the CXXSyntheticChildren
electriclilies abandoned this revision.
electriclilies added a comment.
Abandoning this since I messed up when updating, changes are now at
https://reviews.llvm.org/D158010
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158009/new/
https://reviews.
electriclilies added inline comments.
Comment at: lldb/include/lldb/DataFormatters/TypeSynthetic.h:257-262
+ virtual bool IsScripted();
- virtual std::string GetDescription() = 0;
+ virtual std::string GetDescription();
virtual SyntheticChildrenFrontEnd::AutoPointer
+
electriclilies added inline comments.
Comment at: lldb/source/Commands/CommandObjectType.cpp:2174
-#if LLDB_ENABLE_PYTHON
-
jingham wrote:
> electriclilies wrote:
> > rriddle wrote:
> > > Why is this dropped?
> > Walter and I want to use the synthetic types fro
electriclilies updated this revision to Diff 550795.
electriclilies added a comment.
Fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158010/new/
https://reviews.llvm.org/D158010
Files:
lldb/include/lldb/DataFormatters/TypeSynthetic.h
lldb/so
electriclilies added a comment.
@jingham Any other changes I should make? Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158010/new/
https://reviews.llvm.org/D158010
___
lldb-commits mailing list
electriclilies added a comment.
@wallace The type synthetic add command already disables itself if python is
not enabled (the check is at CommandObjectType::1564), so I think there aren't
any changes I need to make
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revi