[Lldb-commits] [PATCH] D158009: [lldb] Enable synthetic providers in C++

2023-08-15 Thread Lily Orth-Smith via Phabricator via lldb-commits
electriclilies created this revision. Herald added a project: All. electriclilies requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158009 Files: lldb/include/lldb/Core/Value

[Lldb-commits] [PATCH] D158009: [lldb] Enable synthetic providers in C++

2023-08-15 Thread Lily Orth-Smith via Phabricator via lldb-commits
electriclilies added a comment. Hangon reviewers, I forgot to squash my commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158009/new/ https://reviews.llvm.org/D158009 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

2023-08-15 Thread Lily Orth-Smith via Phabricator via lldb-commits
electriclilies created this revision. Herald added a project: All. electriclilies requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Allow the definition of synthetic formatters in C++, and fix linking problems with the CXXSyntheticChildren

[Lldb-commits] [PATCH] D158009: [lldb] Enable synthetic providers in C++

2023-08-15 Thread Lily Orth-Smith via Phabricator via lldb-commits
electriclilies abandoned this revision. electriclilies added a comment. Abandoning this since I messed up when updating, changes are now at https://reviews.llvm.org/D158010 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158009/new/ https://reviews.

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

2023-08-15 Thread Lily Orth-Smith via Phabricator via lldb-commits
electriclilies added inline comments. Comment at: lldb/include/lldb/DataFormatters/TypeSynthetic.h:257-262 + virtual bool IsScripted(); - virtual std::string GetDescription() = 0; + virtual std::string GetDescription(); virtual SyntheticChildrenFrontEnd::AutoPointer +

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

2023-08-15 Thread Lily Orth-Smith via Phabricator via lldb-commits
electriclilies added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2174 -#if LLDB_ENABLE_PYTHON - jingham wrote: > electriclilies wrote: > > rriddle wrote: > > > Why is this dropped? > > Walter and I want to use the synthetic types fro

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

2023-08-16 Thread Lily Orth-Smith via Phabricator via lldb-commits
electriclilies updated this revision to Diff 550795. electriclilies added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158010/new/ https://reviews.llvm.org/D158010 Files: lldb/include/lldb/DataFormatters/TypeSynthetic.h lldb/so

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

2023-08-21 Thread Lily Orth-Smith via Phabricator via lldb-commits
electriclilies added a comment. @jingham Any other changes I should make? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158010/new/ https://reviews.llvm.org/D158010 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

2023-08-25 Thread Lily Orth-Smith via Phabricator via lldb-commits
electriclilies added a comment. @wallace The type synthetic add command already disables itself if python is not enabled (the check is at CommandObjectType::1564), so I think there aren't any changes I need to make Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi