[Lldb-commits] [PATCH] D55002: [NativePDB] Fix ast-reconstruction test on x86

leonid.mashinskiy created this revision. leonid.mashinskiy added reviewers: zturner, stella.stamenova. leonid.mashinskiy added a project: LLDB. Herald added a subscriber: lldb-commits. This patch fixes ast-reconstruction.cpp test on x86 platform. Repository: rLLDB LLDB https://reviews.llvm.or

[Lldb-commits] [PATCH] D55002: [NativePDB] Fix ast-reconstruction test on x86

leonid.mashinskiy added a comment. Thank you for the review! Please, commit this for me? I have no commit access. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55002/new/ https://reviews.llvm.org/D55002 ___ lldb-co

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy created this revision. leonid.mashinskiy added reviewers: zturner, asmith, stella.stamenova, aleksandr.urakov. leonid.mashinskiy added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, aprantl, mgorny. This patch makes LLDB able to retrieve proper values for

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy updated this revision to Diff 176411. leonid.mashinskiy added a comment. Added unit tests for translator and fix issues mentioned by review Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://reviews.llvm.org/D55122 Files: lit/

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy added a comment. Seems like we can't move to NativePDB plugin right now, because there are still not implemented some methods like `ParseVariablesForContext` which this code integration based on. But when it will - we can easily do the transition. Repository: rLLDB LLDB CH

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy updated this revision to Diff 176597. leonid.mashinskiy added a comment. - add more tests on dependent programs - handle parsing of cyclically dependent programs properly - remove default cases for fully covered enums as mentioned in conding standart CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy added a comment. > Is this true? Is it not possible for a program to depend on a value of a > register which will be defined later? I am not totally sure about this, but all valid fpo programs that I've seen in existing pdb support this invariant. So I think that we can assume

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy updated this revision to Diff 181792. leonid.mashinskiy set the repository for this revision to rLLDB LLDB. leonid.mashinskiy added a comment. Herald added a subscriber: arphaman. - Ported implementation to NativePDB plugin. - Implemented GetVariableLocationInfo for local variabl

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy added a comment. As D56725 committed, can you please look at latest changes here? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://reviews.llvm.org/D55122 __

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy updated this revision to Diff 184471. leonid.mashinskiy marked an inline comment as done. leonid.mashinskiy added a comment. - made changes related to review Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://reviews.llvm.org/D55

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy added inline comments. Comment at: source/Expression/DWARFExpression.cpp:3253 - return false; + return true; } zturner wrote: > Why do we change the return value here? This function had mixed return value semantics and I changed it to alway

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy added a comment. Thanks for review! Please, commit this for me, because I have no commit access. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55122/new/ https://reviews.llvm.org/D55122 ___ lldb-c

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy created this revision. leonid.mashinskiy added reviewers: asmith, stella.stamenova. leonid.mashinskiy added a project: LLDB. Herald added subscribers: lldb-commits, abidh. Dump more information about "access violation" and "in page error" exceptions to description. Description n

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy added a comment. Thanks for review! Please, commit this for me, because I have no commit access. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60519/new/ https://reviews.llvm.org/D60519 ___ lldb-

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy updated this revision to Diff 194664. leonid.mashinskiy added a comment. Herald added a subscriber: teemperor. - added access violation exception message test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60519/new/ https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy added a comment. In D60519#1461640 , @amccarth wrote: > Does this affect any existing tests? I didn't notice new failures and didn't find any existing tests for windows exceptions. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy updated this revision to Diff 195549. leonid.mashinskiy added a comment. - increased buffer size in GetStopDescription call to fit new message Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60519/new/ https://reviews.llvm.org/D60519 Files: l

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy created this revision. leonid.mashinskiy added a reviewer: asmith. leonid.mashinskiy added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D66655 Files: source/Plugins/Process/Windows/Common/NativeRegisterContextWind

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy updated this revision to Diff 217101. leonid.mashinskiy added a comment. Updated used guarding macros to cut-off ARM and ARM64 architectures as @tatyana-krasnukha mentioned Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://revi

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy updated this revision to Diff 217140. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://reviews.llvm.org/D66655 Files: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp source/Plugins/Process/Window

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy updated this revision to Diff 217359. leonid.mashinskiy added a reviewer: tatyana-krasnukha. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://reviews.llvm.org/D66655 Files: source/Plugins/Process/Windows/Common/NativeRegisterC

[Lldb-commits] [PATCH] D66655: [lldb] Fix x86 compilation

leonid.mashinskiy added a comment. @tatyana-krasnukha Can you commit this please because I have no commit access Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66655/new/ https://reviews.llvm.org/D66655 ___ lldb-com

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

leonid.mashinskiy created this revision. leonid.mashinskiy added reviewers: labath, JDevlieghere. leonid.mashinskiy added a project: LLDB. Herald added subscribers: lldb-commits, mgorny. Visual Studio CMake generator is multi-target and does not define CMAKE_BUILD_TYPE, so Debug build on VS was f

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

leonid.mashinskiy added a comment. Since this patch appeared to be arguable from your point of view I will write some comments before making any further changes. In D66994#1652868 , @amccarth wrote: > - I use the VS project only for code browsing and deb

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

leonid.mashinskiy updated this revision to Diff 218877. leonid.mashinskiy added a comment. Extracted python lookup logic into function Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66994/new/ https://reviews.llvm.org/D66994 Files: cmake/modules/LLDBConfig.cm

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

leonid.mashinskiy added a comment. Thanks for the review! Can somebody commit this please because I don't have commit access? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66994/new/ https://reviews.llvm.org/D66994 __

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy added a comment. Ping! Are these changes accepted ? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60519/new/ https://reviews.llvm.org/D60519 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy added a comment. Thanks! I think I can ask @aleksandr.urakov to land changes. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60519/new/ https://reviews.llvm.org/D60519 ___ lldb-commits mailing list