[Lldb-commits] [lldb] [LLDB] Fix Android debugging (PR #98581)

2024-07-11 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack created https://github.com/llvm/llvm-project/pull/98581 # Goal Fix Android debugging # What This pull request reverts these two commits because it broke Android debugging as explained below. - https://github.com/llvm/llvm-project/commit/bf3e3289d67cb0fe136b0660ca

[Lldb-commits] [lldb] [LLDB] Fix Android debugging (PR #98581)

2024-07-12 Thread Kazuki Sakamoto via lldb-commits
splhack wrote: @dzhidzhoev Yes, https://github.com/llvm/llvm-project/pull/98623 fixed the ResolveExecutableModule issue, thank you! https://github.com/llvm/llvm-project/pull/98581 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [lldb] [LLDB] Fix Android debugging (PR #98581)

2024-07-12 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack closed https://github.com/llvm/llvm-project/pull/98581 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread Kazuki Sakamoto via lldb-commits
splhack wrote: Verified this fixed the ResolveExecutableModule issue with Android target reported in https://github.com/llvm/llvm-project/pull/98581 https://github.com/llvm/llvm-project/pull/98623 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] [LLDB] Fix remote executables load and caching (PR #98623)

2024-07-12 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack approved this pull request. https://github.com/llvm/llvm-project/pull/98623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c4fa6fa - [lldb][LocateModuleCallback] Update SBFileSpec/SBModuleSpec

2023-07-12 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-07-12T11:11:18-07:00 New Revision: c4fa6fafc43ad5374a29d542737c0238b85516e4 URL: https://github.com/llvm/llvm-project/commit/c4fa6fafc43ad5374a29d542737c0238b85516e4 DIFF: https://github.com/llvm/llvm-project/commit/c4fa6fafc43ad5374a29d542737c0238b85516e4.dif

[Lldb-commits] [lldb] 7f1028e - [lldb][LocateModuleCallback] Call locate module callback

2023-07-12 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-07-12T11:19:51-07:00 New Revision: 7f1028e9df52b4e7246f189a24684b1ca8c9bfbe URL: https://github.com/llvm/llvm-project/commit/7f1028e9df52b4e7246f189a24684b1ca8c9bfbe DIFF: https://github.com/llvm/llvm-project/commit/7f1028e9df52b4e7246f189a24684b1ca8c9bfbe.dif

[Lldb-commits] [lldb] f03dbdb - [lldb][LocateModuleCallback] Implement API, Python interface

2023-07-12 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-07-12T11:33:51-07:00 New Revision: f03dbdb70aed74ed64c1a42a85e47e3f86315ae7 URL: https://github.com/llvm/llvm-project/commit/f03dbdb70aed74ed64c1a42a85e47e3f86315ae7 DIFF: https://github.com/llvm/llvm-project/commit/f03dbdb70aed74ed64c1a42a85e47e3f86315ae7.dif

[Lldb-commits] [lldb] fb087c1 - [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

2023-07-12 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-07-12T16:49:45-07:00 New Revision: fb087c17c82309404fe0ebf3505c186642a719f7 URL: https://github.com/llvm/llvm-project/commit/fb087c17c82309404fe0ebf3505c186642a719f7 DIFF: https://github.com/llvm/llvm-project/commit/fb087c17c82309404fe0ebf3505c186642a719f7.dif

[Lldb-commits] [lldb] 43b9d62 - [lldb][Windows] Fix TestLocateModuleCallback

2023-07-14 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-07-14T10:36:57-07:00 New Revision: 43b9d62018fe53278dfcd2c46f4937a1664745bd URL: https://github.com/llvm/llvm-project/commit/43b9d62018fe53278dfcd2c46f4937a1664745bd DIFF: https://github.com/llvm/llvm-project/commit/43b9d62018fe53278dfcd2c46f4937a1664745bd.dif

[Lldb-commits] [lldb] 39299f0 - [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

2023-07-15 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-07-15T11:53:06-07:00 New Revision: 39299f0d367d4ff6b1d1eede80ffb09718614e53 URL: https://github.com/llvm/llvm-project/commit/39299f0d367d4ff6b1d1eede80ffb09718614e53 DIFF: https://github.com/llvm/llvm-project/commit/39299f0d367d4ff6b1d1eede80ffb09718614e53.dif

[Lldb-commits] [lldb] 8c61c9b - [lldb][LocateModuleCallback] Call locate module callback in Platform too

2023-07-25 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-07-25T10:57:50-07:00 New Revision: 8c61c9b02b492b00179e6e2cd95d2c54dac69a0e URL: https://github.com/llvm/llvm-project/commit/8c61c9b02b492b00179e6e2cd95d2c54dac69a0e DIFF: https://github.com/llvm/llvm-project/commit/8c61c9b02b492b00179e6e2cd95d2c54dac69a0e.dif

[Lldb-commits] [lldb] b4d710e - [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

2023-06-15 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-06-15T14:24:14-07:00 New Revision: b4d710e410595905c6c1d40cd5d257dfa9143bbe URL: https://github.com/llvm/llvm-project/commit/b4d710e410595905c6c1d40cd5d257dfa9143bbe DIFF: https://github.com/llvm/llvm-project/commit/b4d710e410595905c6c1d40cd5d257dfa9143bbe.dif

[Lldb-commits] [lldb] 75e93ec - [lldb][TerminalTest] Fix assertion failure

2023-06-15 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-06-15T21:24:40-07:00 New Revision: 75e93ec720739291640005681f062b0e1e8e0f53 URL: https://github.com/llvm/llvm-project/commit/75e93ec720739291640005681f062b0e1e8e0f53 DIFF: https://github.com/llvm/llvm-project/commit/75e93ec720739291640005681f062b0e1e8e0f53.dif

[Lldb-commits] [lldb] b0b9605 - [lldb][ObjectFileELF] Set ModuleSpec file offset and size

2023-06-20 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-06-20T15:00:09-07:00 New Revision: b0b9605a544dbf26940a48777af401a419f4e4f1 URL: https://github.com/llvm/llvm-project/commit/b0b9605a544dbf26940a48777af401a419f4e4f1 DIFF: https://github.com/llvm/llvm-project/commit/b0b9605a544dbf26940a48777af401a419f4e4f1.dif

[Lldb-commits] [lldb] 12dee9d - [lldb][Android] Support zip .so file

2023-06-20 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-06-20T15:21:46-07:00 New Revision: 12dee9d3cd762d9754e2adadffa13c1cce85cf07 URL: https://github.com/llvm/llvm-project/commit/12dee9d3cd762d9754e2adadffa13c1cce85cf07 DIFF: https://github.com/llvm/llvm-project/commit/12dee9d3cd762d9754e2adadffa13c1cce85cf07.dif

[Lldb-commits] [lldb] 49f55b0 - [lldb][Android] Add PlatformAndroidTest

2023-06-20 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-06-20T16:15:02-07:00 New Revision: 49f55b025d81823fa7e2b287c8930a8304483e5a URL: https://github.com/llvm/llvm-project/commit/49f55b025d81823fa7e2b287c8930a8304483e5a DIFF: https://github.com/llvm/llvm-project/commit/49f55b025d81823fa7e2b287c8930a8304483e5a.dif

[Lldb-commits] [lldb] fabd16c - [lldb][Android] Add platform.plugin.remote-android.package-name

2023-06-20 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-06-20T16:17:21-07:00 New Revision: fabd16c7460e6cfae3106155ec79142bfa54db2e URL: https://github.com/llvm/llvm-project/commit/fabd16c7460e6cfae3106155ec79142bfa54db2e DIFF: https://github.com/llvm/llvm-project/commit/fabd16c7460e6cfae3106155ec79142bfa54db2e.dif

[Lldb-commits] [lldb] 5c4071d - [lldb][Windows] Fix ZipFileResolver tests

2023-06-22 Thread Kazuki Sakamoto via lldb-commits
Author: Kazuki Sakamoto Date: 2023-06-22T10:42:40-07:00 New Revision: 5c4071d225169d22387dd27df0f32a4efc8a0caa URL: https://github.com/llvm/llvm-project/commit/5c4071d225169d22387dd27df0f32a4efc8a0caa DIFF: https://github.com/llvm/llvm-project/commit/5c4071d225169d22387dd27df0f32a4efc8a0caa.dif

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-20 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack created https://github.com/llvm/llvm-project/pull/117070 Addressing two issues on ELF core debugging 1. ProcessElfCore::FindBuidIdInCoreMemory reads wrong address for ELF header (fixed by @clayborg) 2. DynamicLoader does not use ProcessElfCore NT_FILE entries to get

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-20 Thread Kazuki Sakamoto via lldb-commits
@@ -157,6 +157,10 @@ DynamicLoader::GetSectionListFromModule(const ModuleSP module) const { ModuleSP DynamicLoader::FindModuleViaTarget(const FileSpec &file) { Target &target = m_process->GetTarget(); ModuleSpec module_spec(file, target.GetArchitecture()); + if (UUID uuid

[Lldb-commits] [lldb] Fix loading UUIDs from ELF headers. (PR #117028)

2024-11-20 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack approved this pull request. https://github.com/llvm/llvm-project/pull/117028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-20 Thread Kazuki Sakamoto via lldb-commits
splhack wrote: > The reading of build IDs is tracked in this PR: #117028 will rebase onto #117028 https://github.com/llvm/llvm-project/pull/117070 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-20 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack updated https://github.com/llvm/llvm-project/pull/117070 >From 6b8f4a824d39ce557230e610a846d316358b4f20 Mon Sep 17 00:00:00 2001 From: Kazuki Sakamoto Date: Wed, 20 Nov 2024 16:20:40 -0800 Subject: [PATCH 1/2] Run clang format. --- lldb/source/Core/DynamicLoader.cpp

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-20 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack edited https://github.com/llvm/llvm-project/pull/117070 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestLoadUnload.py (PR #117416)

2024-11-24 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack closed https://github.com/llvm/llvm-project/pull/117416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-21 Thread Kazuki Sakamoto via lldb-commits
@@ -224,7 +224,7 @@ Status ProcessElfCore::DoLoadCore() { ArchSpec core_arch(m_core_module_sp->GetArchitecture()); target_arch.MergeFrom(core_arch); GetTarget().SetArchitecture(target_arch); - + splhack wrote: This pull request will be rebased onto #117

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-22 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack updated https://github.com/llvm/llvm-project/pull/117070 >From 8d9f061d7b5dfe5966f117f5b2740c8acbd87797 Mon Sep 17 00:00:00 2001 From: Kazuki Sakamoto Date: Wed, 20 Nov 2024 13:49:26 -0800 Subject: [PATCH] [lldb] Fix ELF core debugging DynamicLoader does not use Proc

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-22 Thread Kazuki Sakamoto via lldb-commits
@@ -286,6 +286,22 @@ void ProcessElfCore::UpdateBuildIdForNTFileEntries() { } } +bool ProcessElfCore::GetModuleSpec(const FileSpec &module_file_spec, + const ArchSpec &arch, + ModuleSpec &module_spec) { + m

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-22 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack closed https://github.com/llvm/llvm-project/pull/117070 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-21 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack updated https://github.com/llvm/llvm-project/pull/117070 >From b93478345fbaa747b44d678207b768948db0a7d6 Mon Sep 17 00:00:00 2001 From: Kazuki Sakamoto Date: Wed, 20 Nov 2024 13:49:26 -0800 Subject: [PATCH] [lldb] Fix ELF core debugging DynamicLoader does not use Proc

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-22 Thread Kazuki Sakamoto via lldb-commits
splhack wrote: @clayborg most likely calling GetModuleSpec is the cause of these failures. ProcessGDBRemote fetches modules from remote. FindBuildId does not have the issue. What do you think? > looks like these changes break `lldb-api::TestLoadUnload.py` test on the LLDB > remote-linux builder

[Lldb-commits] [lldb] [lldb] Fix TestLoadUnload.py (PR #117416)

2024-11-22 Thread Kazuki Sakamoto via lldb-commits
https://github.com/splhack created https://github.com/llvm/llvm-project/pull/117416 ELF core debugging fix #117070 broke TestLoadUnload.py tests due to GetModuleSpec call, ProcessGDBRemote fetches modules from remote. Revise the original PR, renamed FindBuildId to FindModuleUUID. >From 8fdc87

[Lldb-commits] [lldb] [lldb] Fix ELF core debugging (PR #117070)

2024-11-22 Thread Kazuki Sakamoto via lldb-commits
splhack wrote: @vvereschaka let me check https://github.com/llvm/llvm-project/pull/117070 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits