[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. This patch adds a new matching method for data formatters, in addition to the existin

[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

jgorbe updated this revision to Diff 467987. jgorbe added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135648/new/ https://reviews.llvm.org/D135648 Files: lldb/bindings/python/python-swigsafecast.swig lldb/bindings/python/python-wrapper.swig l

[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

jgorbe marked 2 inline comments as done. jgorbe added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2306 if (type == eRegularSynth) { -if (category->AnyMatches(type_name, eFormatCategoryItemFilter, false)) { +// TODO: Get a suitable type objec

[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

This revision was automatically updated to reflect the committed changes. jgorbe marked 2 inline comments as done. Closed by commit rGd76566417e59: [lldb] Add matching based on Python callbacks for data formatters. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

jgorbe added a comment. Hi! I've just debugged an issue that brought me to this commit. I'll start preparing a patch tomorrow (not sure how to test it yet) but since it's a recent-ish change I figured I'd ping the commit thread to give you a heads up. `v.GetSummary()` returns a char* that is ba

[Lldb-commits] [PATCH] D136890: [lldb-vscode] Don't call SBValue.GetError after generating a summary.

jgorbe created this revision. jgorbe added reviewers: yinghuitan, clayborg. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. In some occasions, SBValue::GetError can invalidate its cached `m_summary_str` m

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

jgorbe added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:136-156 llvm::StringRef value = v.GetValue(); llvm::StringRef summary = v.GetSummary(); llvm::StringRef type_name = v.GetType().GetDisplayTypeName(); + lldb::SBError error = v.GetError();

[Lldb-commits] [PATCH] D136890: [lldb-vscode] Don't call SBValue.GetError after generating a summary.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d4d25c42a68: [lldb-vscode] Don't call SBValue.GetError after generating a summary. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13689

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. This change adds a `--recognizer-function` (`-R`) to `type summary add` and `type syn

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. > You can't provide the --regex option and this matcher at the same time Thanks for spotting this. I'll get to it. > it is also an error to have both this matcher function and any arguments in > the argument list Not with the code as it is. I've made the new flag have s

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. I'm looking at the option of using a non-printable character for the short flag, and at the same time make `--regex` and `--recognizer-function` mutually exclusive using option groups. One problem I see is that the command help gets pretty confusing. Using a non-printabl

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe updated this revision to Diff 472185. jgorbe added a comment. - Removed `-R` short option to avoid confusion with regex. Updated doc, test case, and example. - Added some logic to make `--recognizer-function` and `--regex` mutually exclusive. Specifying both now results in an error being

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. @jingham any comments on https://reviews.llvm.org/D137000#3897162? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137000/new/ https://reviews.llvm.org/D137000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. In D137000#3915943 , @jingham wrote: > It is a bit odd to follow the what the help summary says is a valid option > set and then get an error. But this is a corner case, and since you say > explicitly that you can't provide bot

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe updated this revision to Diff 474573. jgorbe added a comment. - Clarified help text for `--recognizer-function` as suggested by reviewer. Instead of "Incompatible with --regex (-x)." now it says "Cannot be specified at the same time as --regex (-x)." - Rebased on top of current HEAD. CH

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG868186cf6cb7: [lldb] Make callback-based formatter matching available from the CLI. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

jgorbe added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:808-809 + if (cu_index && (header.m_unit_type == llvm::dwarf::DW_UT_compile || + header.m_unit_type == llvm::dwarf::DW_UT_split_compile)) { +header.m_index_entry

[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

jgorbe updated this revision to Diff 323166. jgorbe added a comment. Moved index handling to DWARFUnit.cpp as suggested by Pavel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96194/new/ https://reviews.llvm.org/D96194 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp

[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

jgorbe updated this revision to Diff 325884. jgorbe added a comment. Changed logic that checked the type of unit to use `header.IsTypeUnit()` as suggested by reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96194/new/ https://reviews.llvm.org/D96194 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

jgorbe added a comment. I'm going to go ahead and commit this given that I have just made the last suggested modification and the patch has already been up for review without further comments for a long while (sorry for the late replies, work keeps getting in the way of work). ==

[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG979ca1c05f83: Defer the decision whether to use the CU or TU index until after reading the… (authored by jgorbe). Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

jgorbe created this revision. jgorbe added reviewers: labath, zturner. Herald added a subscriber: teemperor. Herald added a project: LLDB. All the other paths in the find_toolchain function return a tuple (detected_toolchain_type, compiler_path), but when the parameter to `--compiler` is not one

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

jgorbe updated this revision to Diff 198853. jgorbe added a comment. Added a new test that checks that, when a full path to a compiler is specified: - That compiler is used in build commands - The flag style used in build commands matches the toolchain type autodetected from the compiler executa

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

jgorbe updated this revision to Diff 198858. jgorbe added a comment. Removed trailing blank lines from test case, will commit now. Thanks for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61713/new/ https://reviews.llvm.org/D61713 Files: lldb/lit/BuildScript/compiler-ful

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

This revision was automatically updated to reflect the committed changes. Closed by commit rL360355: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler (authored by jgorbe, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D62334: [lldb] Make sure RegularExpression constructors always initialize member variables

jgorbe created this revision. jgorbe added reviewers: clayborg, zturner. Herald added a subscriber: jdoerfert. The copy constructor of RegularExpression doesn't initialize m_comp_err. This causes an use-of-initialized-value error when a RegularExpression is copied: the copy constructor calls Com

[Lldb-commits] [PATCH] D62334: [lldb] Make sure RegularExpression constructors always initialize member variables

jgorbe updated this revision to Diff 201029. jgorbe added a comment. Fixed indentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62334/new/ https://reviews.llvm.org/D62334 Files: lldb/source/Utility/RegularExpression.cpp Index: lldb/source/Utility/RegularExpression.cpp ===

[Lldb-commits] [PATCH] D62334: [lldb] Make sure RegularExpression constructors always initialize member variables

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361546: [lldb] Make sure RegularExpression constructors always initialize member… (authored by jgorbe, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

jgorbe added a comment. About %T not working for "process launch", what about something like `RUN: %lldb -b --one-line-before-file "process launch --stdout %T/x86-zmm-write.out" -s %s %t` and then FileCheck-ing? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62948/new/ https://reviews.

[Lldb-commits] [PATCH] D62980: [lldb] Replace "127.0.0.1" with "localhost" in GDBRemoteCommunication.cpp

jgorbe created this revision. jgorbe added reviewers: clayborg, labath. 127.0.0.1 doesn't work in machines configured with IPv6-only networking. https://reviews.llvm.org/D62980 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Index: lldb/source/Plugins/Process/gdb-re

[Lldb-commits] [PATCH] D62980: [lldb] Replace "127.0.0.1" with "localhost" in GDBRemoteCommunication.cpp

jgorbe added a comment. Hm, I just realized I'm undoing https://reviews.llvm.org/D58883. I'll withdraw this patch and upload it again once I'm sure I'm taking that into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62980/new/ https://reviews.llvm.org/D62980 ___

[Lldb-commits] [PATCH] D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header.

jgorbe created this revision. jgorbe requested review of this revision. Herald added a project: LLDB. In split DWARF v5 files, the DWO id is no longer in the DW_AT_GNU_dwo_id attribute. It's in the CU header instead. This change makes lldb look in both places. Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header.

jgorbe added a comment. Thanks for accepting the patch! (and sorry for the late reply, I was on vacation). I'll commit this now :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93444/new/ https://reviews.llvm.org/D93444 __

[Lldb-commits] [PATCH] D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa39b19821b6b: Make DWARFUnit use the dwo_id from the DWARF5 CU header. (authored by jgorbe). Changed prior to commit: https://reviews.llvm.org/D93

[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

jgorbe created this revision. jgorbe added reviewers: dblaikie, labath. Herald added a subscriber: arphaman. jgorbe requested review of this revision. Herald added a project: LLDB. In DWARF v4 compile units go in .debug_info and type units go in .debug_types. However, in v5 both kinds of units are

<    1   2