https://github.com/ajordanr-google created
https://github.com/llvm/llvm-project/pull/106433
armv7a and armv8a are common names for the application subarch for arm.
These names in particular are used in ChromeOS, Android, and a few other known
applications. In ChromeOS, we encountered a bug whe
ajordanr-google wrote:
Thanks for the review and merge!
https://github.com/llvm/llvm-project/pull/106433
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/74791
>From 9d4665cf1ddda98129af2f6ff575989cec49af6d Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Fri, 8 Dec 2023 00:09:59 +
Subject: [PATCH 01/13] [libunwind] Replace process_vm_readv w
https://github.com/ajordanr-google created
https://github.com/llvm/llvm-project/pull/126810
For some operating systems, terminfo is a separate package and library from
ncurses. Both are still requirements for curses support in lldb, individually.
This is a rebase of this original spack commit:
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/126810
>From ddd3febff5b77cc7b2101996d49729added00f2b Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Tue, 1 Oct 2024 18:41:28 +
Subject: [PATCH] [lldb] Add terminfo dependency for ncurses
https://github.com/ajordanr-google edited
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ajordanr-google edited
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ajordanr-google wrote:
> This isn't using TINFO_LIBRARIES anywhere. Presumably you'll need to add it
> to LLDB_CURSES_LIBS like the original spack patch.
Hmm. This patch does seem to work locally, so it's not _required_. I would have
thought the logic is entirely in the `find_package` invocati
ajordanr-google wrote:
Thanks, this does clear it up! Yeah I'd rather have it work out of the bod.
I'll see what I can do for doing the autodetection ergonomically, and get back
to you. If not, I'll add a flag.
https://github.com/llvm/llvm-project/pull/126810
__
@@ -2,23 +2,54 @@
# FindCursesAndPanel
# ---
#
-# Find the curses and panel library as a whole.
+# Find the curses, terminfo, and panel library as a whole.
-if(CURSES_INCLUDE_DIRS AND CURSES_LIBRARIES AND PANEL_LIBRARIES)
+include(CMakePushCheckState)
+
+function(lldb
@@ -11,6 +11,9 @@ set(LLDB_LIBEDIT_LIBS)
if (LLDB_ENABLE_CURSES)
list(APPEND LLDB_CURSES_LIBS ${PANEL_LIBRARIES} ${CURSES_LIBRARIES})
+ if(NOT CURSES_HAS_TINFO)
+list(APPEND LLDB_CURSES_LIBS ${TINFO_LIBRARIES})
+ endif()
ajordanr-google wrote:
I think
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/126810
>From ddd3febff5b77cc7b2101996d49729added00f2b Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Tue, 1 Oct 2024 18:41:28 +
Subject: [PATCH 1/3] [lldb] Add terminfo dependency for ncur
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/126810
>From ddd3febff5b77cc7b2101996d49729added00f2b Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Tue, 1 Oct 2024 18:41:28 +
Subject: [PATCH 1/5] [lldb] Add terminfo dependency for ncur
https://github.com/ajordanr-google edited
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/126810
>From ddd3febff5b77cc7b2101996d49729added00f2b Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Tue, 1 Oct 2024 18:41:28 +
Subject: [PATCH 1/4] [lldb] Add terminfo dependency for ncur
ajordanr-google wrote:
Tested with a system that has bundled terminfo in curses and one without
locally!
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/126810
>From ddd3febff5b77cc7b2101996d49729added00f2b Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Tue, 1 Oct 2024 18:41:28 +
Subject: [PATCH 1/2] [lldb] Add terminfo dependency for ncur
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/126810
>From ddd3febff5b77cc7b2101996d49729added00f2b Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Tue, 1 Oct 2024 18:41:28 +
Subject: [PATCH 1/6] [lldb] Add terminfo dependency for ncur
@@ -2,23 +2,54 @@
# FindCursesAndPanel
# ---
#
-# Find the curses and panel library as a whole.
+# Find the curses, terminfo, and panel library as a whole.
-if(CURSES_INCLUDE_DIRS AND CURSES_LIBRARIES AND PANEL_LIBRARIES)
+include(CMakePushCheckState)
+
+function(lldb
https://github.com/ajordanr-google edited
https://github.com/llvm/llvm-project/pull/128245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ajordanr-google created
https://github.com/llvm/llvm-project/pull/128245
At present, we automatically detect terminfo symbols in CURSES_LIBRARIES after
it is found through `find_package`. However, by introducing a check for
TINFO_LIBRARIES, we break systems which pass all of
ajordanr-google wrote:
Turns out `set(CURSES_LIBRARIES "${CURSES_LIBRARIES } ${TINFO_LIBRARIES}")`
definitely does NOT work. I think there's some string quoting which gives:
```
ninja -v -j96 -l999 distribution libclang.so
@@ -6,15 +6,24 @@
include(CMakePushCheckState)
-function(lldb_check_curses_tinfo CURSES_LIBRARIES CURSES_HAS_TINFO)
+function(lldb_check_curses_tinfo CURSES_HEADER CURSES_LIBRARIES
CURSES_HAS_TINFO)
cmake_reset_check_state()
set(CMAKE_REQUIRED_LIBRARIES "${CURSES_LIBRA
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/128245
>From ff5884d252b8359bcec41024f9dc9e3c7bbe3fc2 Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Wed, 19 Feb 2025 19:24:40 +
Subject: [PATCH 1/4] [lldb] Fix manual CURSES_LIBRARIES tin
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/128245
>From ff5884d252b8359bcec41024f9dc9e3c7bbe3fc2 Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Wed, 19 Feb 2025 19:24:40 +
Subject: [PATCH 1/3] [lldb] Fix manual CURSES_LIBRARIES tin
ajordanr-google wrote:
Rebasing to fix merge conflict...
https://github.com/llvm/llvm-project/pull/128245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/128245
>From f0d81ca9124f0e4b0a60f2752c56c4166052813a Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Wed, 19 Feb 2025 19:24:40 +
Subject: [PATCH] [lldb] Fix manual CURSES_LIBRARIES tinfo f
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/128245
>From f0d81ca9124f0e4b0a60f2752c56c4166052813a Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Wed, 19 Feb 2025 19:24:40 +
Subject: [PATCH] [lldb] Fix manual CURSES_LIBRARIES tinfo f
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/128245
>From f0d81ca9124f0e4b0a60f2752c56c4166052813a Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Wed, 19 Feb 2025 19:24:40 +
Subject: [PATCH] [lldb] Fix manual CURSES_LIBRARIES tinfo f
https://github.com/ajordanr-google updated
https://github.com/llvm/llvm-project/pull/128245
>From ff5884d252b8359bcec41024f9dc9e3c7bbe3fc2 Mon Sep 17 00:00:00 2001
From: Jordan R Abrahams-Whitehead
Date: Wed, 19 Feb 2025 19:24:40 +
Subject: [PATCH 1/2] [lldb] Fix manual CURSES_LIBRARIES tin
@@ -6,15 +6,24 @@
include(CMakePushCheckState)
-function(lldb_check_curses_tinfo CURSES_LIBRARIES CURSES_HAS_TINFO)
+function(lldb_check_curses_tinfo CURSES_HEADER CURSES_LIBRARIES
CURSES_HAS_TINFO)
cmake_reset_check_state()
set(CMAKE_REQUIRED_LIBRARIES "${CURSES_LIBRA
ajordanr-google wrote:
This apparently broke a downstream edge case with fuschia:
https://issues.fuchsia.dev/397455029, where they set all but the
`TINFO_LIBRARIES` variable.
I have given them a downstream fix, but wondering if I can rework the patch so
that this isn't an issue. I don't think
ajordanr-google wrote:
> Okay, I think I understand what's going on with fuchsia: they manually set
> CURSES_INCLUDE_DIRS, CURSES_LIBRARIES, and PANEL_LIBRARIES. On line 17 we go
> into the else-case because TINFO_LIBRARIES is not set.
That's correct!
> So next we check if the provided CURSES
https://github.com/ajordanr-google milestoned
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ajordanr-google wrote:
/cherry-pick 8d017e6c0178f2628b246c18b2a634909815e54f
eec242aa97c8d153574923f8237754ca3fa6f0a6
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
ajordanr-google wrote:
/cherry-pick 8fff0c181f26a5e8b2344c061ebf2559118b1160
bb6a273d9ab9ee90dbb957e541f4d810fffb22ee
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
ajordanr-google wrote:
We haven't had any issues since on our end. I'll check with Fuchsia again to be
sure, then will try to backport.
https://github.com/llvm/llvm-project/pull/126810
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
37 matches
Mail list logo
