https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/66447:
>From 1d9a7f7302b57883d316205967904268e0e54e59 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 14 Sep 2023 16:47:49 -0700
Subject: [PATCH] [lldb] Add config and decorator for wide character supp
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/66474
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> Would skip review, but it's here on the off chance @JDevlieghere knows where
> the second link was supposed to go to.
The original HTML had the following links:
```
For a general user-level introduction to data formatters, you can look here.
More details on the architectu
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/66527
This is a (rough) port of architecture/varformats.html page that got lost
during the migration to RST in edb874b. I'm not sure how much of its content is
still relevant today. However, the page is pretty ex
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/66527
>From d67ae6c562f0367df98ce72f866c088cf433b62d Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 15 Sep 2023 09:31:22 -0700
Subject: [PATCH] [lldb] Revive internal data formatter documentation
Thi
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/66527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Thanks for working on this!
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/66721
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/66724
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/67055
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/67384
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-02-19T19:54:53-08:00
New Revision: 0c02329ff375100ddcf2cb104aebe97bb3c9126f
URL:
https://github.com/llvm/llvm-project/commit/0c02329ff375100ddcf2cb104aebe97bb3c9126f
DIFF:
https://github.com/llvm/llvm-project/commit/0c02329ff375100ddcf2cb104aebe97bb3c9126f.d
JDevlieghere wrote:
Thank you!
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
Makes sense to me, but I'll defer to @jimingham as he's the expert.
https://github.com/llvm/llvm-project/pull/82709
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
JDevlieghere wrote:
Awesome, thank you making this happen!
https://github.com/llvm/llvm-project/pull/82670
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Also this is plugin code, it's probably more appropriate to disable the whole
plugin if the necessary backend isn't there?
https://github.com/llvm/llvm-project/pull/82603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/82717
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82736
I noticed that the term-width setting would always report its default value
(80) despite the driver correctly setting the value with
SBDebugger::SetTerminalWidth.
(lldb) settings show term-width
term-w
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82736
>From c6c2edf66adbe72c959925da886043cd77bfe528 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 22 Feb 2024 21:01:06 -0800
Subject: [PATCH] [lldb] Fix term-width setting
I noticed that the term-w
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82736
>From 8df692af718f4fafcad99ef966b230af125199e7 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 22 Feb 2024 21:01:06 -0800
Subject: [PATCH] [lldb] Fix term-width setting
I noticed that the term-w
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/82736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-02-22T23:54:13-08:00
New Revision: 354401f8d3dc08ed41895d03a12a122e9cc0482c
URL:
https://github.com/llvm/llvm-project/commit/354401f8d3dc08ed41895d03a12a122e9cc0482c
DIFF:
https://github.com/llvm/llvm-project/commit/354401f8d3dc08ed41895d03a12a122e9cc0482c.d
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82799
When terminating the debugger, we wait for all background tasks to complete.
Given that there's no way to interrupt those treads, this can take a while.
When that happens, the debugger appears to hang at ex
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,2 @@
+C_SOURCES := main.c
+include Makefile.rules
JDevlieghere wrote:
Did you want to build this test for arm64**e**?
https://github.com/llvm/llvm-project/pull/82804
___
lldb-commits mailing list
lldb-commi
@@ -0,0 +1,25 @@
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TestArm64eAttach(TestBase):
+NO_DEBUG_INFO_TESTCASE = True
+
+# On Darwin systems, arch arm64e means ARMv8.3 with p
@@ -623,8 +630,20 @@ void Debugger::Terminate() {
}
if (g_thread_pool) {
-// The destructor will wait for all the threads to complete.
-delete g_thread_pool;
+// Delete the thread pool in a different thread so we can set a timeout.
JDevlieghere
JDevlieghere wrote:
> Can we not just use a `Progress` object instead of installing a callback?
> Seems like a very specific use case to install a callback for in our public
> API. Do we create `Progress` objects for each background download? If we
> don't, should we? Then this would show up i
JDevlieghere wrote:
Greg and I talked this over offline. We both feel that progress events are the
best way to convey that work is going on in the background. To make that work
for the driver, we'll check if the debugger being destroyed is the very last
one and if it is, we'll delay its destru
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/82804
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82938
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1568,15 +1569,16 @@ bool Target::SetArchitecture(const ArchSpec &arch_spec,
bool set_platform,
if (m_arch.GetSpec().IsCompatibleMatch(other)) {
compatible_local_arch = true;
-bool arch_changed, vendor_changed, os_changed, os_ver_changed,
-
@@ -0,0 +1,7 @@
+C_SOURCES := main.c
+
+# Uncomment this for q&d local debugging.
JDevlieghere wrote:
Q&D?
https://github.com/llvm/llvm-project/pull/82938
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
https://github.com/JDevlieghere commented:
Overall this looks good but we should verify that this doesn't regress running
unmodified iOS binaries on macOS (https://reviews.llvm.org/D117340,
https://reviews.llvm.org/D121444). It was really tricky to get that right and
it's all based on the bina
@@ -1568,15 +1569,16 @@ bool Target::SetArchitecture(const ArchSpec &arch_spec,
bool set_platform,
if (m_arch.GetSpec().IsCompatibleMatch(other)) {
compatible_local_arch = true;
-bool arch_changed, vendor_changed, os_changed, os_ver_changed,
-
@@ -,6 +,23 @@ static bool mach_header_validity_test(uint32_t magic,
uint32_t cputype) {
return FormatDynamicLibrariesIntoJSON(image_infos, report_load_commands);
}
+std::optional>
+MachProcess::GetMainBinaryCPUTypes(nub_process_t pid) {
+ int pointer_size = GetInf
https://github.com/JDevlieghere approved this pull request.
LGTM with Jason's comment as it would help simplify the test.
https://github.com/llvm/llvm-project/pull/82938
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
Author: Jonas Devlieghere
Date: 2024-02-26T11:11:30-08:00
New Revision: 38515580c4c5068e204ff69494ad11bbfacc89b4
URL:
https://github.com/llvm/llvm-project/commit/38515580c4c5068e204ff69494ad11bbfacc89b4
DIFF:
https://github.com/llvm/llvm-project/commit/38515580c4c5068e204ff69494ad11bbfacc89b4.d
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -593,6 +593,7 @@ class Debugger : public
std::enable_shared_from_this,
friend class CommandInterpreter;
friend class REPL;
friend class Progress;
+ friend class ProgressManager;
JDevlieghere wrote:
I don't think you need this (anymore)?
https://git
@@ -626,7 +627,8 @@ class Debugger : public
std::enable_shared_from_this,
static void ReportProgress(uint64_t progress_id, std::string title,
std::string details, uint64_t completed,
uint64_t total,
-
@@ -97,12 +98,32 @@ class Progress {
/// Used to indicate a non-deterministic progress report
static constexpr uint64_t kNonDeterministicTotal = UINT64_MAX;
+ /// Use a struct to send data from a Progress object to
+ /// ProgressManager::ReportProgress. In addition to th
https://github.com/JDevlieghere requested changes to this pull request.
I think this is going in the right direction but I think the interaction
between the ProgressManager and the Debugger needs to change:
At a high level I'm expecting:
1. Progress object is created
2. Progress is added to th
@@ -1433,11 +1434,30 @@ void Debugger::SetDestroyCallback(
static void PrivateReportProgress(Debugger &debugger, uint64_t progress_id,
std::string title, std::string details,
uint64_t completed, uint64_t total,
@@ -97,12 +98,32 @@ class Progress {
/// Used to indicate a non-deterministic progress report
static constexpr uint64_t kNonDeterministicTotal = UINT64_MAX;
+ /// Use a struct to send data from a Progress object to
+ /// ProgressManager::ReportProgress. In addition to th
@@ -97,12 +98,32 @@ class Progress {
/// Used to indicate a non-deterministic progress report
static constexpr uint64_t kNonDeterministicTotal = UINT64_MAX;
+ /// Use a struct to send data from a Progress object to
+ /// ProgressManager::ReportProgress. In addition to th
@@ -1433,11 +1434,30 @@ void Debugger::SetDestroyCallback(
static void PrivateReportProgress(Debugger &debugger, uint64_t progress_id,
std::string title, std::string details,
uint64_t completed, uint64_t total,
https://github.com/JDevlieghere approved this pull request.
LGTM. Let me know if you need someone to land this for you (and if you want to
[set your e-mail address to public](https://github.com/settings/emails) before
that).
https://github.com/llvm/llvm-project/pull/82295
JDevlieghere wrote:
> > LGTM. Let me know if you need someone to land this for you
>
> I do need someone to land this for me. People keep asking me that; Is there a
> way for me to apply for write access or something?
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
> > (and
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/82295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
I'm happy if Jason is happy!
https://github.com/llvm/llvm-project/pull/83099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
@@ -1433,13 +1434,17 @@ void Debugger::SetDestroyCallback(
static void PrivateReportProgress(Debugger &debugger, uint64_t progress_id,
std::string title, std::string details,
uint64_t completed, uint64_t total,
@@ -1929,6 +1938,8 @@ lldb::thread_result_t Debugger::DefaultEventHandler() {
} else if (broadcaster == &m_broadcaster) {
if (event_type & Debugger::eBroadcastBitProgress)
HandleProgressEvent(event_sp);
+else if (event_type & Debu
@@ -29,8 +30,12 @@ Progress::Progress(std::string title, std::string details,
if (debugger)
m_debugger_id = debugger->GetID();
+
+ m_progress_data = {m_title, m_details, m_id,
+ m_completed, m_total, m_debugger_id};
JDevliegher
@@ -1875,7 +1883,8 @@ lldb::thread_result_t Debugger::DefaultEventHandler() {
listener_sp->StartListeningForEvents(
&m_broadcaster, eBroadcastBitProgress | eBroadcastBitWarning |
- eBroadcastBitError | eBroadcastSymbolChange);
+
@@ -97,27 +98,44 @@ class Progress {
/// Used to indicate a non-deterministic progress report
static constexpr uint64_t kNonDeterministicTotal = UINT64_MAX;
+ /// Use a struct to send data from a Progress object to
+ /// the progress manager.
+ struct ProgressData {
+
@@ -82,20 +94,37 @@ ProgressManager &ProgressManager::Instance() {
return *g_progress_manager;
}
-void ProgressManager::Increment(std::string title) {
+void ProgressManager::Increment(Progress::ProgressData progress_data) {
JDevlieghere wrote:
This should t
@@ -97,27 +98,37 @@ class Progress {
/// Used to indicate a non-deterministic progress report
static constexpr uint64_t kNonDeterministicTotal = UINT64_MAX;
+ /// Use a struct to send data from a Progress object to
+ /// the progress manager.
+ struct ProgressData {
+
https://github.com/JDevlieghere approved this pull request.
LGTM with the nit addressed.
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/83330
The -d(ebug) option broke 5 years ago when I migrated the driver to libOption.
Since then, we were never check if the option is set. We were incorrectly
toggling the internal variable (m_debug_mode) based o
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/83317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/83330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM but please fix the formatting before landing.
https://github.com/llvm/llvm-project/pull/83350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
@@ -1255,6 +1255,95 @@ lldb::SBFileSpec SBProcess::GetCoreFile() {
return SBFileSpec(core_file);
}
+addr_t SBProcess::GetAddressMask(AddressMaskType type,
+ AddressMaskRange addr_range) {
+ LLDB_INSTRUMENT_VA(this, type, addr_range);
+ addr_
@@ -1255,6 +1255,95 @@ lldb::SBFileSpec SBProcess::GetCoreFile() {
return SBFileSpec(core_file);
}
+addr_t SBProcess::GetAddressMask(AddressMaskType type,
+ AddressMaskRange addr_range) {
+ LLDB_INSTRUMENT_VA(this, type, addr_range);
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/83366
Currently, calls to Host::SystemLog print to stderr on all host platforms
except Darwin. This severely limits its value on the command line, where we
don't want to overload the user with log messages. Switc
JDevlieghere wrote:
I tried implementing this and waiting on the thread pool when the last debugger
is being destroyed is easy:
```
// Only hold the debugger list lock long enough to check if we're the last
// debugger being destroyed.
bool last_debugger_being_destroyed = false;
if (g_d
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82799
>From 3db25301ed07ed0b44ff0f8cbe8d1657ba899036 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 28 Feb 2024 20:00:43 -0800
Subject: [PATCH] [lldb] Print a message when background tasks take a whil
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/83366
>From c6599a05b5be0cbd279a96e98bed1c89d9de707e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 28 Feb 2024 18:12:45 -0800
Subject: [PATCH 1/2] [lldb] Log to system log instead of stderr from
Hos
@@ -89,8 +89,17 @@ using namespace lldb;
using namespace lldb_private;
#if !defined(__APPLE__)
+#if !defined(_WIN32)
+#include
+void Host::SystemLog(llvm::StringRef message) {
+ openlog("lldb", LOG_CONS | LOG_PID | LOG_NDELAY, LOG_USER);
+ syslog(LOG_INFO, "%s", message.dat
Author: Jonas Devlieghere
Date: 2024-02-28T21:20:40-08:00
New Revision: 793300988b7c723bacadce67879ea8bf71c87e70
URL:
https://github.com/llvm/llvm-project/commit/793300988b7c723bacadce67879ea8bf71c87e70
DIFF:
https://github.com/llvm/llvm-project/commit/793300988b7c723bacadce67879ea8bf71c87e70.d
JDevlieghere wrote:
> @JDevlieghere @adrian-prantl we should consider adding this to the list of
> required python modules on our bots too and enforce it with
> `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS`? Probably not in this PR, but after
> we can get our bots configured correctly.
Added in 793
Author: Jonas Devlieghere
Date: 2024-02-28T21:23:19-08:00
New Revision: 81d94cad6d655d66adb08805a3bbef5a58125999
URL:
https://github.com/llvm/llvm-project/commit/81d94cad6d655d66adb08805a3bbef5a58125999
DIFF:
https://github.com/llvm/llvm-project/commit/81d94cad6d655d66adb08805a3bbef5a58125999.d
Author: Jonas Devlieghere
Date: 2024-02-29T08:08:30-08:00
New Revision: 5a0bd2a36591fe48c24de220a5f8ddef9ce6f0b1
URL:
https://github.com/llvm/llvm-project/commit/5a0bd2a36591fe48c24de220a5f8ddef9ce6f0b1
DIFF:
https://github.com/llvm/llvm-project/commit/5a0bd2a36591fe48c24de220a5f8ddef9ce6f0b1.d
Author: Jonas Devlieghere
Date: 2024-02-29T09:12:20-08:00
New Revision: a6d9b7ba2722953960b83fbacda1757349f00156
URL:
https://github.com/llvm/llvm-project/commit/a6d9b7ba2722953960b83fbacda1757349f00156
DIFF:
https://github.com/llvm/llvm-project/commit/a6d9b7ba2722953960b83fbacda1757349f00156.d
https://github.com/JDevlieghere approved this pull request.
LGTM but please fix the formatting issue before merging.
https://github.com/llvm/llvm-project/pull/83095
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/83502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/83454
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/83454
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGMT, thanks for improving this!
https://github.com/llvm/llvm-project/pull/83504
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -22,38 +23,47 @@ std::atomic Progress::g_id(0);
Progress::Progress(std::string title, std::string details,
std::optional total,
lldb_private::Debugger *debugger)
-: m_title(title), m_details(details), m_id(++g_id), m_completed(0),
-
https://github.com/JDevlieghere deleted
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/83527
This patch adds support to sort the symbol table by size. The command already
supports sorting and it already reports sizes. Sorting by size helps diagnosing
size issues.
rdar://123788375
>From 5e399ab6d0
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/83527
>From 5236e15ad14b5bacd566bcefa329268b8dadd9e8 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 29 Feb 2024 21:36:05 -0800
Subject: [PATCH] [lldb] Add support for sorting by size to `target module
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/83527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/83602
The help output for `thread backtrace` specifies that you can pass -1 to
`--count` to display all the frames.
```
-c ( --count )
How many frames to display (-1 for all)
```
However, that does
JDevlieghere wrote:
@rupprecht @oontvoo How do you feel about the current approach? The other
alternative is to make this function a NOOP on all platforms but Darwin (where
I want to actively use it). It's not currently load bearing (except the log,
which is opt-in).
https://github.com/llvm/l
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/83602
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> > Why not increase TypeSystem::GetNumChildren to return a size_t instead?
>
> We could, but even 2^32 seems like an outrageous amount of children to me.
> What would be a use-case for this? A ValueObject that has the entire address
> space as synthetic children?
>
> Ther
JDevlieghere wrote:
Can you add/modify a test?
https://github.com/llvm/llvm-project/pull/83861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/83889
Use sort-ordering for indexes when sorting by size. This addresses Jason's post
commit review feedback.
>From 13b644f483a349bb853d917e0771e811a1bf9be2 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date:
@@ -138,6 +134,21 @@ void Symtab::Dump(Stream *s, Target *target, SortOrder
sort_order,
}
} break;
+case eSortOrderBySize: {
+ s->PutCString(" (sorted by size):\n");
+ DumpSymbolHeader(s);
+
+ std::multimap> size_map;
+ for (const Symbol &sym
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/83871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
901 - 1000 of 4936 matches
Mail list logo
