Author: Jonas Devlieghere
Date: 2024-09-03T15:40:39-07:00
New Revision: 7d3b81d06f96bc27673f31a7bd7d141ce4a2777b
URL:
https://github.com/llvm/llvm-project/commit/7d3b81d06f96bc27673f31a7bd7d141ce4a2777b
DIFF:
https://github.com/llvm/llvm-project/commit/7d3b81d06f96bc27673f31a7bd7d141ce4a2777b.d
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/107325
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> Thanks! Is this asserting cause something changed in how llvm::formatv
> validates the format string?
Correct: https://github.com/llvm/llvm-project/pull/105745
https://github.com/llvm/llvm-project/pull/107325
___
lldb-commits ma
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/106799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/106799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. I like having both options. That way we don't break existing use cases
while also supporting the more intuitive way of expressing this as a dictionary.
https://github.com/llvm/llvm-project/pull/106919
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/107388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM modulo one nit.
https://github.com/llvm/llvm-project/pull/107388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -943,8 +935,20 @@ Status GDBRemoteCommunication::StartDebugserverProcess(
}
}
}
+ return debugserver_file_spec;
+}
- if (debugserver_exists) {
+Status GDBRemoteCommunication::StartDebugserverProcess(
+const char *url, Platform *platform, ProcessLaunchInfo
Author: Jonas Devlieghere
Date: 2024-09-07T17:03:59-07:00
New Revision: b93457073762bb347b6c7f39c23636dec036a815
URL:
https://github.com/llvm/llvm-project/commit/b93457073762bb347b6c7f39c23636dec036a815
DIFF:
https://github.com/llvm/llvm-project/commit/b93457073762bb347b6c7f39c23636dec036a815.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/107731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/107731
Reverts llvm/llvm-project#107159 as this is still causing
`TestSkinnyCorefile.py` to time out.
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/as-lldb-cmake/11099/
https://ci.swift.org/view/all/j
JDevlieghere wrote:
CC @Jlalond
https://github.com/llvm/llvm-project/pull/107731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/107968
Print a warning when the debugger detects a mismatch between the MD5 checksum
in the DWARF 5 line table and the file on disk. The warning is printed only
once per file.
>From 397e41bfb8516659ec6af7cf98c2d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/71459
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Closing in favor of https://github.com/llvm/llvm-project/pull/107968
https://github.com/llvm/llvm-project/pull/71459
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/107968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/108183
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-09-11T15:29:59-07:00
New Revision: 0909e3027004bb710b1d761569eb15452ce10346
URL:
https://github.com/llvm/llvm-project/commit/0909e3027004bb710b1d761569eb15452ce10346
DIFF:
https://github.com/llvm/llvm-project/commit/0909e3027004bb710b1d761569eb15452ce10346.d
https://github.com/JDevlieghere commented:
The variable name should be `progress_tracker` but really we should just call
it `progress` for consistency with the rest of lldb.
https://github.com/llvm/llvm-project/pull/108309
___
lldb-commits mailing li
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/108309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -972,8 +974,9 @@ GetLargestRangeSize(const std::vector
&ranges) {
return max_size;
}
-Status MinidumpFileBuilder::AddMemoryList_32(
-std::vector &ranges) {
+Status
+MinidumpFileBuilder::AddMemoryList_32(std::vector &ranges,
+ Prog
@@ -837,15 +837,17 @@ Status MinidumpFileBuilder::AddMemoryList() {
error = m_process_sp->CalculateCoreFileSaveRanges(m_save_core_options,
all_core_memory_ranges);
+ if (error.Fail())
+return error;
+
+ lldb_private::
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/108495
Add an "always on" log category and channel. Unlike other, existing log
channels, it is not exposed to users. The channel is meant to be used sparsely
and deliberately for logging high-value information to
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/108498
Emit signpost intervals for progress events so that when users report an
operation takes a long time, we can see investigate the issue with Instruments.
>From 60096062924d8364e953d8479dcbd4b7ea2faaff Mon S
@@ -49,6 +49,7 @@ enum class LLDBLog : Log::MaskType {
Watchpoints = Log::ChannelFlag<30>,
OnDemand = Log::ChannelFlag<31>,
Source = Log::ChannelFlag<32>,
+ AlwaysOn = Log::ChannelFlag<32>,
JDevlieghere wrote:
Yes, definitely. But this code shouldn't ha
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/108495
>From 734088d8ec84d32304b4f78743999fd561fd4fe3 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 12 Sep 2024 22:29:46 -0700
Subject: [PATCH] [lldb] Introduce an always-on system log category/chann
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/108498
>From d15881207001934ff83934fae9cdeb52f61eaf6f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 12 Sep 2024 22:43:40 -0700
Subject: [PATCH] [lldb] Emit signpost intervals for progress events (NFC
Author: Jonas Devlieghere
Date: 2024-09-12T22:52:58-07:00
New Revision: 8f653ca135cb8d4f8d08b97cc32a497091f68cdc
URL:
https://github.com/llvm/llvm-project/commit/8f653ca135cb8d4f8d08b97cc32a497091f68cdc
DIFF:
https://github.com/llvm/llvm-project/commit/8f653ca135cb8d4f8d08b97cc32a497091f68cdc.d
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/108498
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Unless someone steps up to maintain these tests I'm fine with removing them.
https://github.com/llvm/llvm-project/pull/108629
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
JDevlieghere wrote:
It looks like this breaks `Unwind.trap_frame_sym_ctx` on x86_64:
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake/5745/testReport/junit/lldb-shell/Unwind/trap_frame_sym_ctx_test/
I'm going to revert this to get the bots green over the weekend.
https://gi
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/108715
Reverts llvm/llvm-project#106791 because it breaks `trap_frame_sym_ctx.test `
on x86_64.
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake/5745/
>From ba6e663299e1d7b54a3ac4a7c647d44f66
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/108715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/108715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Okay this is safe because after 65b13610a5226b84889b923bae884ba395ad084d,
`raw_string_ostream` is always unbuffered so you (1) don't need to flush and
(2) can use the underlying buffer directly. That makes sense. Please include
that i
https://github.com/JDevlieghere approved this pull request.
Thanks for improving the error message. I left a suggestion inline, but happy
to see this merged regardless of the concrete wording.
https://github.com/llvm/llvm-project/pull/73321
___
lldb-
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/73321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -26,17 +26,19 @@ ScriptInterpreterNone::ScriptInterpreterNone(Debugger
&debugger)
ScriptInterpreterNone::~ScriptInterpreterNone() = default;
+static const char *no_interpreter_err_msg =
+"There is no embedded script interpreter. Check that LLDB was built with a
"
+
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const {
return false;
}
+bool CompilerType::IsSmartPtrType() const {
+ // These regular expressions cover shared, unique and weak pointers both from
+ // stdlibc++ and libc+++.
+
+ static llvm::Regex k_libcxx_std_u
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const {
return false;
}
+bool CompilerType::IsSmartPtrType() const {
+ // These regular expressions cover shared, unique and weak pointers both from
+ // stdlibc++ and libc+++.
+
+ static llvm::Regex k_libcxx_std_u
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const {
return false;
}
+bool CompilerType::IsSmartPtrType() const {
+ // These regular expressions cover shared, unique and weak pointers both from
+ // stdlibc++ and libc+++.
+
+ static llvm::Regex k_libcxx_std_u
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const {
return false;
}
+bool CompilerType::IsSmartPtrType() const {
+ // These regular expressions cover shared, unique and weak pointers both from
+ // stdlibc++ and libc+++.
+
+ static llvm::Regex k_libcxx_std_u
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const {
return false;
}
+bool CompilerType::IsSmartPtrType() const {
+ // These regular expressions cover shared, unique and weak pointers both from
+ // stdlibc++ and libc+++.
+
+ static llvm::Regex k_libcxx_std_u
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const {
return false;
}
+bool CompilerType::IsSmartPtrType() const {
+ // These regular expressions cover shared, unique and weak pointers both from
+ // stdlibc++ and libc+++.
+
+ static llvm::Regex k_libcxx_std_u
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const {
return false;
}
+bool CompilerType::IsSmartPtrType() const {
+ // These regular expressions cover shared, unique and weak pointers both from
+ // stdlibc++ and libc+++.
+
+ static llvm::Regex k_libcxx_std_u
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const {
return false;
}
+bool CompilerType::IsSmartPtrType() const {
+ // These regular expressions cover shared, unique and weak pointers both from
+ // stdlibc++ and libc+++.
+
+ static llvm::Regex k_libcxx_std_u
@@ -0,0 +1,37 @@
+//===-- StopPointSiteList.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/68845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
I was out last week. Thanks, this LGTM!
https://github.com/llvm/llvm-project/pull/70996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/73028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Makes sense to me!
https://github.com/llvm/llvm-project/pull/73736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/74036
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Neat 👍
https://github.com/llvm/llvm-project/pull/74019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/74017
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Github makes this look extremely complicated but in my editor this all looks
pretty obvious. LGTM.
https://github.com/llvm/llvm-project/pull/74119
___
lldb-commits mailing list
lldb-commits@
JDevlieghere wrote:
> > Github makes this look extremely complicated but in my editor this all
> > looks pretty obvious. LGTM.
>
> Yeah, that's part of the reason I tried to break the changes into smaller
> bits, but it still doesn't look as obvious as I wish it did
I noticed that too late, b
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
@@ -1593,6 +1595,7 @@ static uint32_t LookupSymbolInModule(
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
https://github.com/JDevlieghere commented:
This is an awesome feature, than
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRe
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
@@ -246,8 +246,8 @@ class Address {
/// \see Address::Du
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRe
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com
=?utf-8?q?Jos=C3=A9?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
===
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
https://github.com/JDevlieghere commented:
The change itself LGTM, but I'd like to either have an inline comment (e.g.
`Finalize(/*destructing=*/false)) `or use an enum value to convey the meaning
of those values.
https://github.com/llvm/llvm-project/pull/74687
https://github.com/JDevlieghere approved this pull request.
LGTM. Since @Dodzey is a first-time contributor one of us needs to click the
merge button. I'll leave that to @clayborg or @walter-erquinigo as the owners.
https://github.com/llvm/llvm-project/pull/75342
__
https://github.com/JDevlieghere approved this pull request.
🥳
https://github.com/llvm/llvm-project/pull/75840
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/75793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1700,13 +1706,13 @@ ValueObjectSP ValueObject::GetSyntheticChildAtOffset(
return synthetic_child_sp;
if (!can_create)
-return {};
+return ValueObjectSP();
JDevlieghere wrote:
I'm possibly biased as the author of the [modernize-return-braced-
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/76030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -17,13 +17,41 @@
namespace lldb_private {
class Stream;
+/// Represents a source file whose contents is known (for example
JDevlieghere wrote:
- Presumably this class is primarily used for source files but can hold any
file?
- Represents a path to a fil
@@ -17,13 +17,41 @@
namespace lldb_private {
class Stream;
+/// Represents a source file whose contents is known (for example
JDevlieghere wrote:
Let's call this `LazySupportFile` maybe?
https://github.com/llvm/llvm-project/pull/75880
___
@@ -45,13 +48,61 @@ class FileSpecHolder {
}
};
+class SupportFileList {
JDevlieghere wrote:
Let's call this `SupportFile` to match the `SupportFileList`. This is where
I'll add my MD5 checksum to.
https://github.com/llvm/llvm-project/pull/75880
https://github.com/JDevlieghere commented:
This looks awesome. Without the need for copying the SupportFileList, can we
make the UnspooledSupportFile a subclass of SupportFile and store unique
pointers in the support file list?
https://github.com/llvm/llvm-project/pull/75880
_
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/75880
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-01-04T16:47:16-08:00
New Revision: 5fd18bdef9e1f18d6069a542551f046f1a179b38
URL:
https://github.com/llvm/llvm-project/commit/5fd18bdef9e1f18d6069a542551f046f1a179b38
DIFF:
https://github.com/llvm/llvm-project/commit/5fd18bdef9e1f18d6069a542551f046f1a179b38.d
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/77216
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/77216
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -108,13 +108,9 @@ else()
linux/HostInfoLinux.cpp
linux/LibcGlue.cpp
linux/Support.cpp
+ android/HostInfoAndroid.cpp
+ android/LibcGlue.cpp
)
-if (CMAKE_SYSTEM_NAME MATCHES "Android")
JDevlieghere wrote:
While Android m
@@ -85,6 +85,11 @@ double DecodedThread::NanosecondsRange::GetInterpolatedTime(
return interpolate(next_range->nanos);
}
+DecodedThread::TraceItemStorage::TraceItemStorage(
+const TraceItemStorage &other) {
+ std::memcpy(this, &other, sizeof *this);
JDe
@@ -103,12 +103,10 @@ TraceIntelPTBundleLoader::CreateEmptyProcess(lldb::pid_t
pid,
ParsedProcess parsed_process;
parsed_process.target_sp = target_sp;
- // This should instead try to directly create an instance of ProcessTrace.
- // ProcessSP process_sp = target_sp->Cr
@@ -276,6 +276,10 @@ class DecodedThread : public
std::enable_shared_from_this {
/// The string message of this item if it's an error
std::string error;
+
+TraceItemStorage() {}
+~TraceItemStorage() {}
JDevlieghere wrote:
Can this be `= defau
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/73067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/71993
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/71228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/77252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/77252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/77380
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/77538
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2023-07-10T14:50:40-07:00
New Revision: fb10b01cca85306c8a94826e31e8a4dfb8aff502
URL:
https://github.com/llvm/llvm-project/commit/fb10b01cca85306c8a94826e31e8a4dfb8aff502
DIFF:
https://github.com/llvm/llvm-project/commit/fb10b01cca85306c8a94826e31e8a4dfb8aff502.d
Author: Jonas Devlieghere
Date: 2023-07-13T11:30:35-07:00
New Revision: e5aa4cff43239930f87ada9183720d4182daa8fa
URL:
https://github.com/llvm/llvm-project/commit/e5aa4cff43239930f87ada9183720d4182daa8fa
DIFF:
https://github.com/llvm/llvm-project/commit/e5aa4cff43239930f87ada9183720d4182daa8fa.d
Author: Jonas Devlieghere
Date: 2023-07-13T11:30:52-07:00
New Revision: ee44310a48b7d14336de75e170110e2fea90842b
URL:
https://github.com/llvm/llvm-project/commit/ee44310a48b7d14336de75e170110e2fea90842b
DIFF:
https://github.com/llvm/llvm-project/commit/ee44310a48b7d14336de75e170110e2fea90842b.d
Author: Jonas Devlieghere
Date: 2023-07-13T15:10:25-07:00
New Revision: 0e285a13eb7f25d7609d6795fb2f3439c8b1c270
URL:
https://github.com/llvm/llvm-project/commit/0e285a13eb7f25d7609d6795fb2f3439c8b1c270
DIFF:
https://github.com/llvm/llvm-project/commit/0e285a13eb7f25d7609d6795fb2f3439c8b1c270.d
Author: Jonas Devlieghere
Date: 2023-07-13T15:43:59-07:00
New Revision: b716d4e58543396894badd6ea8115c147ed12fae
URL:
https://github.com/llvm/llvm-project/commit/b716d4e58543396894badd6ea8115c147ed12fae
DIFF:
https://github.com/llvm/llvm-project/commit/b716d4e58543396894badd6ea8115c147ed12fae.d
Author: Jonas Devlieghere
Date: 2023-07-20T10:21:33-07:00
New Revision: bbffda645a1cdb5d3426b1d7eca31b0f9a312959
URL:
https://github.com/llvm/llvm-project/commit/bbffda645a1cdb5d3426b1d7eca31b0f9a312959
DIFF:
https://github.com/llvm/llvm-project/commit/bbffda645a1cdb5d3426b1d7eca31b0f9a312959.d
Author: Jonas Devlieghere
Date: 2023-07-25T17:45:19-07:00
New Revision: 94e8fefe385cd3b6a4656bec244ddf9791056f0c
URL:
https://github.com/llvm/llvm-project/commit/94e8fefe385cd3b6a4656bec244ddf9791056f0c
DIFF:
https://github.com/llvm/llvm-project/commit/94e8fefe385cd3b6a4656bec244ddf9791056f0c.d
Author: Jonas Devlieghere
Date: 2023-07-28T09:41:47-07:00
New Revision: 0a5e0d3fad8dfdebc8bb2f51f6008bdd41e27580
URL:
https://github.com/llvm/llvm-project/commit/0a5e0d3fad8dfdebc8bb2f51f6008bdd41e27580
DIFF:
https://github.com/llvm/llvm-project/commit/0a5e0d3fad8dfdebc8bb2f51f6008bdd41e27580.d
701 - 800 of 4310 matches
Mail list logo
