https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/79624
This fixes two issues related to the DebugSymbols symbol locator:
1. Only the default symbol locator plugin reports progress. On Darwin, which
uses the DebugSymbols framework we need to report the same pr
JDevlieghere wrote:
> This is only testing the `Progress` class constructor behavior. Could you
> check that the `Progress::Increment` method works as expected ?
While it would be nice to have full test coverage, the goal was to cover the
existing behavior which we'll modify/extend to coalesce
@@ -776,6 +776,10 @@ std::optional
SymbolLocatorDebugSymbols::LocateExecutableSymbolFile(
exec_fspec ? exec_fspec->GetFilename().AsCString("") : "",
arch ? arch->GetArchitectureName() : "", (const void *)uuid);
+ Progress progress(
+ "Locating external symbo
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/79644
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/79624
>From 7979269a57fc553a7b010a36b9c75bf570adf674 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 26 Jan 2024 09:34:11 -0800
Subject: [PATCH 1/2] [lldb] Fix progress reporting for
SymbolLocatorDebu
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/79649
Make it easier to go from a ConstString to a std::string without having to go
through a C-String or a llvm::StringRef. I made the conversion operator
explicit as this is a relatively expensive operations (c
@@ -776,6 +776,10 @@ std::optional
SymbolLocatorDebugSymbols::LocateExecutableSymbolFile(
exec_fspec ? exec_fspec->GetFilename().AsCString("") : "",
arch ? arch->GetArchitectureName() : "", (const void *)uuid);
+ Progress progress(
+ "Locating external symbo
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/79656
On Darwin, the Makefile already (ad-hoc) signs everything it builds. There's
also no need to use lldb_codesign for this.
>From 80d68ab889989ddae906af3b2042158a12a0ca46 Mon Sep 17 00:00:00 2001
From: Jonas D
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/79649
>From b0abae7ac1208321a4a7033bcc456dba645b47bf Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 26 Jan 2024 14:35:52 -0800
Subject: [PATCH] [lldb] Streamline ConstString -> std::string conversion
@@ -192,6 +198,9 @@ class ConstString {
return llvm::StringRef(m_string, GetLength());
}
+ /// Get the string value as a std::string
+ std::string GetString() const { return std::string(m_string, GetLength()); }
JDevlieghere wrote:
It's not necessary,
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/79649
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/79624
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/79656
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
I ran the test suite locally (macOS on arm64) and `TestRequireHWBreakpoints.py`
is the only regression I found, but that's covered by the other PR. I'm happy
to go ahead with landing both PRs and fixing the bots if there's fallout.
https://github.com/llvm/llvm-project/pull
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/79945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/79962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -448,6 +448,32 @@ enum WatchpointWriteType {
eWatchpointWriteTypeOnModify
};
+/// The hardware and native stub capabilities for a given target,
+/// for translating a user's watchpoint request into hardware
+/// capable watchpoint resources.
+FLAGS_ENUM(WatchpointHardware
@@ -0,0 +1,146 @@
+//===-- WatchpointAlgorithms.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,146 @@
+//===-- WatchpointAlgorithms.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,101 @@
+//===-- WatchpointAlgorithms.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/JDevlieghere approved this pull request.
Great job on documenting the code, it's a pleasure to read through. The
algorithm makes sense to me and it has solid test coverage. I've left some nits
but overall this LGTM.
https://github.com/llvm/llvm-project/pull/79962
___
@@ -0,0 +1,146 @@
+//===-- WatchpointAlgorithms.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,101 @@
+//===-- WatchpointAlgorithms.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/JDevlieghere approved this pull request.
There's a handful of comments that are missing a period. Otherwise this LGTM.
https://github.com/llvm/llvm-project/pull/79533
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
@@ -0,0 +1,109 @@
+//===-- WatchpointAlgorithms.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,142 @@
+//===-- WatchpointAlgorithms.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/80603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM if @DavidSpickett and @bulbazord are happy.
https://github.com/llvm/llvm-project/pull/80376
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/80890
LLDB has a setting (symbols.enable-background-lookup) that calls dsymForUUID on
a background thread for images as they appear in the current backtrace.
Originally, the laziness of only looking up symbols fo
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/80791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked first
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked first
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/80890
>From d0696a22e07678e8b7a0dd78df0c873aa89deacb Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 6 Feb 2024 16:25:37 -0800
Subject: [PATCH] [lldb] Expand background symbol lookup
LLDB has a settin
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked first
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked first
@@ -0,0 +1,76 @@
+//===-- Breakpoint.cpp --*- C++
-*-===//
JDevlieghere wrote:
Nit: you don't need the `*- C++ -*` in source files as emacs can tell it's C++
by the extension, unlike in the header.
https://github.com/ll
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/80368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,98 @@
+#include "lldb/Target/VerboseTrapFrameRecognizer.h"
+
+#include "lldb/Core/Module.h"
+#include "lldb/Symbol/Function.h"
+#include "lldb/Symbol/SymbolContext.h"
+#include "lldb/Target/Process.h"
+#include "lldb/Target/Target.h"
+
+#include "lldb/Utility/LLDBLog.h"
@@ -0,0 +1,98 @@
+#include "lldb/Target/VerboseTrapFrameRecognizer.h"
+
+#include "lldb/Core/Module.h"
+#include "lldb/Symbol/Function.h"
+#include "lldb/Symbol/SymbolContext.h"
+#include "lldb/Target/Process.h"
+#include "lldb/Target/Target.h"
+
+#include "lldb/Utility/LLDBLog.h"
https://github.com/JDevlieghere approved this pull request.
LGTM with comments addressed.
https://github.com/llvm/llvm-project/pull/80368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
@@ -0,0 +1,39 @@
+#ifndef LLDB_TARGET_VERBOSETRAPFRAMERECOGNIZER_H
JDevlieghere wrote:
Missing license header.
https://github.com/llvm/llvm-project/pull/80368
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
@@ -99,6 +105,10 @@ class Progress {
private:
void ReportProgress();
static std::atomic g_id;
+ static std::atomic g_refcount;
+ /// Map that tracks each progress object and if we've seen its start and stop
+ /// events
+ static std::unordered_map g_map;
---
JDevlieghere wrote:
> A few questions I have:
>
> * do we really want each progress to select if it should be coalesced as a
> `Progress` constructor arguments? Or do we want a global setting on how
> progress events should be delivered?
My understanding is that the constructor conveys whethe
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/80918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> > My understanding is that the constructor conveys whether something is an
> > "aggregate" progress event or not and they're broadcast differently so that
> > the listener can decide how they want to receive these "aggregate" events.
>
> My idea is the user decides how to
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/81078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
🥳
https://github.com/llvm/llvm-project/pull/81075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
@clayborg The idea behind the feature is to get symbols for things that are
relevant to the user. Right now, that's only hooked up for images that appear
in the stack trace, but there are certainly other places this would be useful.
So yeah, I absolutely expect this to appl
https://github.com/JDevlieghere approved this pull request.
This doesn't do much by itself but based on the discussion in #81026 we have
consensus on this part. LGTM.
https://github.com/llvm/llvm-project/pull/81169
___
lldb-commits mailing list
lldb-c
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/80890
>From 8846fb6cdb83b0364238bd74a99e97c1dba604a2 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 6 Feb 2024 16:25:37 -0800
Subject: [PATCH] [lldb] Expand background symbol lookup
LLDB has a settin
JDevlieghere wrote:
Rebased & renamed the property to `symbols.auto-download`. I think all the
review comments have been addressed. The only oustanding question is if
@clayborg wants to have an additional setting for
`symbols.auto-download-stack-symbols`.
https://github.com/llvm/llvm-project
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/81182
Reverts llvm/llvm-project#80890
>From 63b2f16bdf812613d368304be453a44c2a1f8fe3 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 8 Feb 2024 11:50:28 -0800
Subject: [PATCH] Revert "[lldb] Expand ba
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/81182
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-02-08T12:39:04-08:00
New Revision: 5f4b40c90a51248b097de7b5bc89c6976d4c3298
URL:
https://github.com/llvm/llvm-project/commit/5f4b40c90a51248b097de7b5bc89c6976d4c3298
DIFF:
https://github.com/llvm/llvm-project/commit/5f4b40c90a51248b097de7b5bc89c6976d4c3298.d
@@ -66,3 +66,47 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+void ProgressManager::Initialize() {
+ lldbassert(!InstanceImpl() && "A progress report manager already exists.");
+ InstanceImpl().emplace();
+}
+
+void ProgressManager
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/81319
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -66,3 +66,47 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+void ProgressManager::Initialize() {
+ lldbassert(!InstanceImpl() && "A progress report manager already exists.");
+ InstanceImpl().emplace();
+}
+
+void ProgressManager
https://github.com/JDevlieghere approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/81565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -141,6 +145,24 @@ std::optional
SymbolLocatorDefault::LocateExecutableSymbolFile(
FileSystem::Instance().Resolve(file_spec);
debug_file_search_paths.AppendIfUnique(file_spec);
}
+#if defined(__FreeBSD__)
+// Add $LOCALBASE/lib/debug directory, where
+
@@ -141,6 +145,24 @@ std::optional
SymbolLocatorDefault::LocateExecutableSymbolFile(
FileSystem::Instance().Resolve(file_spec);
debug_file_search_paths.AppendIfUnique(file_spec);
}
+#if defined(__FreeBSD__)
+// Add $LOCALBASE/lib/debug directory, where
+
https://github.com/JDevlieghere approved this pull request.
LGTM with the Initialize/Terminate removed as they're not needed anymore.
https://github.com/llvm/llvm-project/pull/81319
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
@@ -119,6 +120,32 @@ class Progress {
bool m_complete = false;
};
+/// A class used to group progress reports by category. This is done by using a
+/// map that maintains a refcount of each category of progress reports that
have
+/// come in. Keeping track of progress repor
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/81319
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/81710
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -119,6 +120,32 @@ class Progress {
bool m_complete = false;
};
+/// A class used to group progress reports by category. This is done by using a
+/// map that maintains a refcount of each category of progress reports that
have
+/// come in. Keeping track of progress repor
JDevlieghere wrote:
Yeah given GreenDragon has been red for 20h, I'd like to get this merged sooner
rather than later. @DavidSpickett what's the benefit of waiting for the arm
bots to come back up?
https://github.com/llvm/llvm-project/pull/81703
___
@@ -66,3 +67,41 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+ProgressManager &ProgressManager::InstanceImpl() {
+ static std::once_flag g_once_flag;
+ static ProgressManager *g_progress_manager = nullptr;
+ std::call_once(g_once_
@@ -66,3 +67,41 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+ProgressManager &ProgressManager::InstanceImpl() {
+ static std::once_flag g_once_flag;
+ static ProgressManager *g_progress_manager = nullptr;
+ std::call_once(g_once_
JDevlieghere wrote:
I can't imagine how the unit test framework could have made this flaky. It's
more likely the test was flakey before and it went unnoticed. Can we
(temporarily) disable the DAP test?
https://github.com/llvm/llvm-project/pull/81703
___
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/81319
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-02-15T22:54:00-08:00
New Revision: 096c530ab3ea5c96526451181117f30db17b4b1d
URL:
https://github.com/llvm/llvm-project/commit/096c530ab3ea5c96526451181117f30db17b4b1d
DIFF:
https://github.com/llvm/llvm-project/commit/096c530ab3ea5c96526451181117f30db17b4b1d.d
Author: Jonas Devlieghere
Date: 2024-02-15T22:54:00-08:00
New Revision: 266bbc203da2d0bc880e643560fb48aff4830478
URL:
https://github.com/llvm/llvm-project/commit/266bbc203da2d0bc880e643560fb48aff4830478
DIFF:
https://github.com/llvm/llvm-project/commit/266bbc203da2d0bc880e643560fb48aff4830478.d
Author: Jonas Devlieghere
Date: 2024-02-16T07:59:03-08:00
New Revision: bf93f4b85fd4efbd7a3083935a2ddbbb00f1a35f
URL:
https://github.com/llvm/llvm-project/commit/bf93f4b85fd4efbd7a3083935a2ddbbb00f1a35f
DIFF:
https://github.com/llvm/llvm-project/commit/bf93f4b85fd4efbd7a3083935a2ddbbb00f1a35f.d
Author: Jonas Devlieghere
Date: 2024-02-16T08:47:38-08:00
New Revision: 0da0966da4b813386a85cf70ae0d0efc7cb2eaea
URL:
https://github.com/llvm/llvm-project/commit/0da0966da4b813386a85cf70ae0d0efc7cb2eaea
DIFF:
https://github.com/llvm/llvm-project/commit/0da0966da4b813386a85cf70ae0d0efc7cb2eaea.d
JDevlieghere wrote:
This breaks `TestDataFormatterLibcxxChrono.py` on macOS:
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/66400/
https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/16178/
CC @rastogishubham
https://github.com/llvm/llvm-project/pull/81666
___
JDevlieghere wrote:
This is what the failure looks like:
```
==
FAIL: test_with_run_command_dsym
(TestDataFormatterLibcxxChrono.LibcxxChronoDataFormatterTestCase)
Test that that file and class static variables display correc
JDevlieghere wrote:
Great. Let me know if you need help reproducing stuff on macOS.
https://github.com/llvm/llvm-project/pull/81666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82066
The distutils package has been deprecated and was removed from Python 3.12. The
migration page [1] advises to use the packaging module instead. Since Python
3.6 that's vendored into pkg_resources.
[1] http
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82066
>From dad7c2a49f118d11b213b9691c8b01733040a510 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 16 Feb 2024 14:59:15 -0800
Subject: [PATCH] [lldb] Migrate distutils.version.LooseVersion to packagi
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82066
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82074
assertRegexpMatches is a deprecated alias for assertRegex and has been removed
in Python 3.12. This wasn't an issue previously because we used a vendored
version of the unittest module. Now that we use the
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/82073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82074
>From f78594900fa34cb9c96bfc6b2dedc2e86bce201f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 16 Feb 2024 15:49:11 -0800
Subject: [PATCH] [lldb] Replace assertRegexpMatches with assertRegex (NFC
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/82074
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,33 +1,33 @@
"""
-This is a sanity check that verifies that test can be sklipped based on
settings.
+This is a sanity check that verifies that test can be skipped based on
settings.
"""
-
import lldb
from lldbsuite.test.lldbtest import *
from lldbsuite.test.decorator
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82066
>From 2e663a2e4a056529e2e17908fc39b90ea8c16eb9 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 16 Feb 2024 14:59:15 -0800
Subject: [PATCH] [lldb] Migrate distutils.version.LooseVersion to packagi
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82095
The Python documentation [1] says that `PyImport_AppendInittab` should be
called before `Py_Initialize()`. Starting with Python 3.12, this is enforced
with a fatal error:
Fatal Python error: PyImport_App
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82096
…nittests
The unit tests only test the Python objects and don't actually use anything
from the LLDB module. On the one hand that means that everything we do in
ScriptInterpreterPythonImpl::Initialize is ov
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82095
>From b937713b2733f2da9de4919b3da881ca0ea0aa04 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 16 Feb 2024 22:56:28 -0800
Subject: [PATCH] [lldb] Call Import_AppendInittab exactly once before
Py
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/82096
>From 7a05913528f2d747f4c5b7c0385a38a3c4e27d83 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 16 Feb 2024 22:51:08 -0800
Subject: [PATCH] [lldb] Don't rely on ScriptInterpreterPythonImpl::Initia
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere ready_for_review
https://github.com/llvm/llvm-project/pull/82096
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/82098
Use a Python Bytes and ByteArray object instead of Integers for
TestOwnedReferences and TestBorrowedReferences. These two tests were
failing when building against Python 3.12 because these Integer objects
had
https://github.com/JDevlieghere ready_for_review
https://github.com/llvm/llvm-project/pull/82098
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/82098
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/82095
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1501 - 1600 of 5184 matches
Mail list logo
