Author: Jonas Devlieghere
Date: 2022-07-27T11:48:35-07:00
New Revision: a8c3d9815e0443bacf5315536ad356e4acb184f2
URL:
https://github.com/llvm/llvm-project/commit/a8c3d9815e0443bacf5315536ad356e4acb184f2
DIFF:
https://github.com/llvm/llvm-project/commit/a8c3d9815e0443bacf5315536ad356e4acb184f2.d
Author: Jonas Devlieghere
Date: 2022-07-27T15:26:46-07:00
New Revision: ecda408178fc6486ea568263cdda6624f5bcb8c7
URL:
https://github.com/llvm/llvm-project/commit/ecda408178fc6486ea568263cdda6624f5bcb8c7
DIFF:
https://github.com/llvm/llvm-project/commit/ecda408178fc6486ea568263cdda6624f5bcb8c7.d
Author: Jonas Devlieghere
Date: 2022-08-02T16:14:02-07:00
New Revision: c7bd61d4a79b88dbd97028bb0a73a73b2d6aca89
URL:
https://github.com/llvm/llvm-project/commit/c7bd61d4a79b88dbd97028bb0a73a73b2d6aca89
DIFF:
https://github.com/llvm/llvm-project/commit/c7bd61d4a79b88dbd97028bb0a73a73b2d6aca89.d
Author: Jonas Devlieghere
Date: 2022-08-03T10:51:16-07:00
New Revision: 6a48dc092b0fda65e786021ebf75bda3e1be5c33
URL:
https://github.com/llvm/llvm-project/commit/6a48dc092b0fda65e786021ebf75bda3e1be5c33
DIFF:
https://github.com/llvm/llvm-project/commit/6a48dc092b0fda65e786021ebf75bda3e1be5c33.d
Author: Jonas Devlieghere
Date: 2022-08-03T11:44:13-07:00
New Revision: 0f821339dad1bf45dd71a1cac32b6352ba251ecb
URL:
https://github.com/llvm/llvm-project/commit/0f821339dad1bf45dd71a1cac32b6352ba251ecb
DIFF:
https://github.com/llvm/llvm-project/commit/0f821339dad1bf45dd71a1cac32b6352ba251ecb.d
Author: Jonas Devlieghere
Date: 2022-08-03T14:24:37-07:00
New Revision: 880b2128ef4b884612a59836583a5d3d4108fb43
URL:
https://github.com/llvm/llvm-project/commit/880b2128ef4b884612a59836583a5d3d4108fb43
DIFF:
https://github.com/llvm/llvm-project/commit/880b2128ef4b884612a59836583a5d3d4108fb43.d
Author: Jonas Devlieghere
Date: 2022-08-03T14:24:42-07:00
New Revision: 2b61b770df813539b38b620efcae8fd3d11faad2
URL:
https://github.com/llvm/llvm-project/commit/2b61b770df813539b38b620efcae8fd3d11faad2
DIFF:
https://github.com/llvm/llvm-project/commit/2b61b770df813539b38b620efcae8fd3d11faad2.d
Author: Jonas Devlieghere
Date: 2022-08-03T14:39:45-07:00
New Revision: 9ffcc85fbe52b4480a82749e58b19c3ea5be5e99
URL:
https://github.com/llvm/llvm-project/commit/9ffcc85fbe52b4480a82749e58b19c3ea5be5e99
DIFF:
https://github.com/llvm/llvm-project/commit/9ffcc85fbe52b4480a82749e58b19c3ea5be5e99.d
Author: Jonas Devlieghere
Date: 2022-08-03T15:47:58-07:00
New Revision: 71ebcd3348061de2fde3a13f1adb56059aca5997
URL:
https://github.com/llvm/llvm-project/commit/71ebcd3348061de2fde3a13f1adb56059aca5997
DIFF:
https://github.com/llvm/llvm-project/commit/71ebcd3348061de2fde3a13f1adb56059aca5997.d
Author: Jonas Devlieghere
Date: 2022-08-03T20:50:05-07:00
New Revision: c988c267cf6e302ceda1edc5c7c679ecb64eab75
URL:
https://github.com/llvm/llvm-project/commit/c988c267cf6e302ceda1edc5c7c679ecb64eab75
DIFF:
https://github.com/llvm/llvm-project/commit/c988c267cf6e302ceda1edc5c7c679ecb64eab75.d
Author: Jonas Devlieghere
Date: 2022-08-05T11:19:46-07:00
New Revision: 9c81b743e31a7dca288b37b6cf6cca3213bfd923
URL:
https://github.com/llvm/llvm-project/commit/9c81b743e31a7dca288b37b6cf6cca3213bfd923
DIFF:
https://github.com/llvm/llvm-project/commit/9c81b743e31a7dca288b37b6cf6cca3213bfd923.d
Author: Jonas Devlieghere
Date: 2022-08-07T14:26:08-07:00
New Revision: d446d91aa39da6b616aacb3e036d4ff0d8905337
URL:
https://github.com/llvm/llvm-project/commit/d446d91aa39da6b616aacb3e036d4ff0d8905337
DIFF:
https://github.com/llvm/llvm-project/commit/d446d91aa39da6b616aacb3e036d4ff0d8905337.d
Author: Jonas Devlieghere
Date: 2022-08-08T20:14:07-07:00
New Revision: bd3976fed470343be8df9caf0e35d290455b700c
URL:
https://github.com/llvm/llvm-project/commit/bd3976fed470343be8df9caf0e35d290455b700c
DIFF:
https://github.com/llvm/llvm-project/commit/bd3976fed470343be8df9caf0e35d290455b700c.d
Author: Jonas Devlieghere
Date: 2022-08-11T12:36:54-07:00
New Revision: 181c0373d2832afbb62ca50c6c59d9759d17edf7
URL:
https://github.com/llvm/llvm-project/commit/181c0373d2832afbb62ca50c6c59d9759d17edf7
DIFF:
https://github.com/llvm/llvm-project/commit/181c0373d2832afbb62ca50c6c59d9759d17edf7.d
Author: Jonas Devlieghere
Date: 2022-08-11T12:44:38-07:00
New Revision: a8bc9b627ea143b84253fc911902cf2c8e429630
URL:
https://github.com/llvm/llvm-project/commit/a8bc9b627ea143b84253fc911902cf2c8e429630
DIFF:
https://github.com/llvm/llvm-project/commit/a8bc9b627ea143b84253fc911902cf2c8e429630.d
Author: Jonas Devlieghere
Date: 2022-08-11T16:20:15-07:00
New Revision: ce075dfa190454f6f85920ad4ffe6928980868af
URL:
https://github.com/llvm/llvm-project/commit/ce075dfa190454f6f85920ad4ffe6928980868af
DIFF:
https://github.com/llvm/llvm-project/commit/ce075dfa190454f6f85920ad4ffe6928980868af.d
Author: Jonas Devlieghere
Date: 2022-08-12T10:23:15-07:00
New Revision: abe9599f04f07baae46f4123d4c43d330f34df52
URL:
https://github.com/llvm/llvm-project/commit/abe9599f04f07baae46f4123d4c43d330f34df52
DIFF:
https://github.com/llvm/llvm-project/commit/abe9599f04f07baae46f4123d4c43d330f34df52.d
Author: Jonas Devlieghere
Date: 2022-08-15T11:25:46-07:00
New Revision: 570e10cb9def153812f13ef1945f9ef388ab3e3e
URL:
https://github.com/llvm/llvm-project/commit/570e10cb9def153812f13ef1945f9ef388ab3e3e
DIFF:
https://github.com/llvm/llvm-project/commit/570e10cb9def153812f13ef1945f9ef388ab3e3e.d
Author: Jonas Devlieghere
Date: 2022-08-15T17:57:23-07:00
New Revision: 8d36a82d0a3d118329b9f24b33e58d0a28360891
URL:
https://github.com/llvm/llvm-project/commit/8d36a82d0a3d118329b9f24b33e58d0a28360891
DIFF:
https://github.com/llvm/llvm-project/commit/8d36a82d0a3d118329b9f24b33e58d0a28360891.d
Author: Jonas Devlieghere
Date: 2022-08-15T17:57:24-07:00
New Revision: 11f45f36dcf54b0fe8e54ce5e410e24f3b9b5a1e
URL:
https://github.com/llvm/llvm-project/commit/11f45f36dcf54b0fe8e54ce5e410e24f3b9b5a1e
DIFF:
https://github.com/llvm/llvm-project/commit/11f45f36dcf54b0fe8e54ce5e410e24f3b9b5a1e.d
Author: Jonas Devlieghere
Date: 2022-08-16T18:10:14-07:00
New Revision: b706f56133a77f9d7c55270ac24ff59e6fce3fa4
URL:
https://github.com/llvm/llvm-project/commit/b706f56133a77f9d7c55270ac24ff59e6fce3fa4
DIFF:
https://github.com/llvm/llvm-project/commit/b706f56133a77f9d7c55270ac24ff59e6fce3fa4.d
Author: Jonas Devlieghere
Date: 2022-08-19T15:20:41-07:00
New Revision: cc0b5ebf7fc8beb8fa907730e2d8f52d4c31bdc7
URL:
https://github.com/llvm/llvm-project/commit/cc0b5ebf7fc8beb8fa907730e2d8f52d4c31bdc7
DIFF:
https://github.com/llvm/llvm-project/commit/cc0b5ebf7fc8beb8fa907730e2d8f52d4c31bdc7.d
Author: Jonas Devlieghere
Date: 2022-08-24T14:26:16-07:00
New Revision: f01208781fd72fca2c49c24c651bf0ce3bc0fb3e
URL:
https://github.com/llvm/llvm-project/commit/f01208781fd72fca2c49c24c651bf0ce3bc0fb3e
DIFF:
https://github.com/llvm/llvm-project/commit/f01208781fd72fca2c49c24c651bf0ce3bc0fb3e.d
@@ -2595,6 +2606,37 @@ bool DWARFExpression::Evaluate(
break;
}
+case DW_OP_WASM_location: {
+ uint8_t wasm_op = opcodes.GetU8(&offset);
+ uint32_t index;
+
+ /* LLDB doesn't have an address space to represents WebAssembly Locals,
+ * GLobals
https://github.com/JDevlieghere commented:
Thanks for picking this up again. I was going to ask about testing and I see
that Adrian asked a similar question on Phabricator in the original review. My
recommendation would be to use `GdbRemoteTestCaseBase` style tests for this, as
they'll run on
@@ -0,0 +1,295 @@
+// This file comes from https://reviews.llvm.org/D78978.
+// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/).
+
+//===-- ProcessWasm.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache Licens
@@ -2595,6 +2606,37 @@ bool DWARFExpression::Evaluate(
break;
}
+case DW_OP_WASM_location: {
+ uint8_t wasm_op = opcodes.GetU8(&offset);
+ uint32_t index;
+
+ /* LLDB doesn't have an address space to represents WebAssembly Locals,
@@ -0,0 +1,295 @@
+// This file comes from https://reviews.llvm.org/D78978.
+// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/).
+
+//===-- ProcessWasm.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache Licens
@@ -0,0 +1,295 @@
+// This file comes from https://reviews.llvm.org/D78978.
+// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/).
+
+//===-- ProcessWasm.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache Licens
@@ -0,0 +1,135 @@
+// This file comes from https://reviews.llvm.org/D78978.
+// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/).
+
+//===-- ProcessWasm.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache Licens
@@ -0,0 +1,135 @@
+// This file comes from https://reviews.llvm.org/D78978.
+// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/).
+
+//===-- ProcessWasm.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache Licens
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/76683
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,295 @@
+// This file comes from https://reviews.llvm.org/D78978.
+// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/).
+
JDevlieghere wrote:
Remove this here and everywhere else.
https://github.com/llvm/llvm-project/pull/76683
___
@@ -0,0 +1,295 @@
+// This file comes from https://reviews.llvm.org/D78978.
+// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/).
+
+//===-- ProcessWasm.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache Licens
@@ -0,0 +1,15 @@
+# This file comes from https://reviews.llvm.org/D78978.
+# Author: [@paolosev](https://reviews.llvm.org/p/paolosev/).
+
JDevlieghere wrote:
Remove this
https://github.com/llvm/llvm-project/pull/76683
@@ -0,0 +1,295 @@
+// This file comes from https://reviews.llvm.org/D78978.
+// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/).
+
+//===-- ProcessWasm.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache Licens
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/77919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
This improves layering so LGTM!
https://github.com/llvm/llvm-project/pull/77858
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
@@ -1048,70 +1048,107 @@ DynamicLoaderDarwin::GetThreadLocalData(const
lldb::ModuleSP module_sp,
std::lock_guard guard(m_mutex);
- const uint32_t addr_size = m_process->GetAddressByteSize();
+ lldb_private::Address tls_addr;
+ if (!module_sp->ResolveFileAddress(tls_file
https://github.com/JDevlieghere commented:
Currently this is a little hard to read given a bunch of shared setup followed
by two possible ways to read the TLS data. If those implementations don't
require too many inputs, it might be worth splitting this out into two helper
functions to make th
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/77966
Generally, separate debug info files are not object files. The exception
are dSYMs which are Mach-O and often contain enough information to be
used as a module.
This patch allows users to add dSYM symbol fil
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/77966
>From ca65108fe01931482110bf6dabef1550fd6a307e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 11 Jan 2024 09:19:31 -0800
Subject: [PATCH 1/2] [lldb] Move CanBeTarget logic into the ObjectFile pl
JDevlieghere wrote:
> @JDevlieghere I created a new PR and closed #76683 because I made a mess with
> a git rebase, and since the other PR had just started I thought it made sense
> to start anew. I apologize for the confusion. Here I have already addressed
> most of your comments from 76683.
JDevlieghere wrote:
> @JDevlieghere Thank you!
>
> I will remove the code that handles DW_OP_WASM_location as you suggest.
Given we don't have a good solution for stacked commits, you don't necessarily
need to remove it here, and rebase it once the other PR has been merged.
> For what concer
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/77854
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,21 @@
+import os
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+
+
+@skipUnlessDarwin
+class TargetModuleAddDsymTest(TestBase):
+@no_debug_info_test
+def test_target_module_add(self):
+"""Test that you can add a dSYM as
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/77966
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-01-12T13:08:24-08:00
New Revision: e27561fc7de0231f2efdb750f2092c3ac807c1a3
URL:
https://github.com/llvm/llvm-project/commit/e27561fc7de0231f2efdb750f2092c3ac807c1a3
DIFF:
https://github.com/llvm/llvm-project/commit/e27561fc7de0231f2efdb750f2092c3ac807c1a3.d
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/77999
This is a series of 4 NFC commit to store `SupportFile`s rather than
`FileSpec`s in `LineEntry`. This is work towards having the
`SourceManager`operate on `SupportFile`s so that it can (1) validate the
Che
@@ -20,7 +20,7 @@ LineEntry::LineEntry()
void LineEntry::Clear() {
range.Clear();
file.Clear();
- original_file.Clear();
+ original_file = std::make_shared();
JDevlieghere wrote:
Correct, this ensures I can always assume that the shared pointer is valid.
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/78210
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> > If a module is debug info only, like a dSYM file, and then you try to
> > `target module add` it to a target, it would be nice to add it as the
> > symbol file for an already existing module. The test below, I wouldn't want
> > a target with two things representing a.ou
Author: Jonas Devlieghere
Date: 2024-01-16T14:20:22-08:00
New Revision: 1b5f72c5ece4442ca29ced45f8bcb25ed0d57790
URL:
https://github.com/llvm/llvm-project/commit/1b5f72c5ece4442ca29ced45f8bcb25ed0d57790
DIFF:
https://github.com/llvm/llvm-project/commit/1b5f72c5ece4442ca29ced45f8bcb25ed0d57790.d
Author: Jonas Devlieghere
Date: 2024-01-16T15:40:15-08:00
New Revision: 854aa9112df253bcad4db6f21ea9b2fbca4ed83e
URL:
https://github.com/llvm/llvm-project/commit/854aa9112df253bcad4db6f21ea9b2fbca4ed83e
DIFF:
https://github.com/llvm/llvm-project/commit/854aa9112df253bcad4db6f21ea9b2fbca4ed83e.d
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/78360
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/78370
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-01-16T16:37:27-08:00
New Revision: 32382bb8329a0931456ab0c60e351cf3a18ab6f3
URL:
https://github.com/llvm/llvm-project/commit/32382bb8329a0931456ab0c60e351cf3a18ab6f3
DIFF:
https://github.com/llvm/llvm-project/commit/32382bb8329a0931456ab0c60e351cf3a18ab6f3.d
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/78389
Upstream support for debugging xros applications through LLDB.
>From a326e09e34fd383fe35513c419b4be46558aab69 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 10 Jan 2024 17:35:47 -0800
Subject:
JDevlieghere wrote:
> ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️
>
> You can test this locally with the following command:
> View the diff from clang-format here.
The suggested changes are orthogonal to the changes in this PR: they just
happen to be on the preceding
https://github.com/JDevlieghere approved this pull request.
LGTM with the promise for a test when you land the updated PR for D155905.
https://github.com/llvm/llvm-project/pull/78379
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/77999
>From dcc17c06960845deccfcd0efe78434110c2add9e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 12 Jan 2024 15:20:12 -0800
Subject: [PATCH] [lldb] Store SupportFile in LineEntry (NFC)
Store a Sup
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/77999
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/77999
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/78389
>From 6f6d93b6cc413d54dbdec05f30ede00ffdb4 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 10 Jan 2024 17:35:47 -0800
Subject: [PATCH] [lldb] Upstream xros support in lldb
Upstream support f
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/78389
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/78392
>From 6f6d93b6cc413d54dbdec05f30ede00ffdb4 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 10 Jan 2024 17:35:47 -0800
Subject: [PATCH 1/2] [lldb] Upstream xros support in lldb
Upstream suppo
https://github.com/JDevlieghere approved this pull request.
LGTM. Thanks for breaking this up!
https://github.com/llvm/llvm-project/pull/77988
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/77932
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Before this patch, the DWARFLinker was the one responsible for creating the
streamer, which meant that both the classic and parallel implementation needed
to conform to the same interface. After this patch, the concrete
implementation
@@ -30,6 +30,20 @@ using namespace llvm;
using namespace dwarf_linker;
using namespace dwarf_linker::classic;
+Expected> DwarfStreamer::createStreamer(
+const Triple &TheTriple, DWARFLinkerBase::OutputFileType FileType,
+raw_pwrite_stream &OutFile, DWARFLinkerBase::Tra
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/78494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1093,6 +1093,20 @@ static void PrettyPrintFunctionNameWithArgs(Stream
&out_stream,
out_stream.PutChar(')');
}
+static void FormatInlinedBlock(Stream &out_stream, Block *block) {
+ if (!block)
+return;
+ Block *inline_block = block->GetContainingInlinedBlock();
+
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/78494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -112,31 +142,49 @@ SymbolLocator *SymbolLocatorDebuginfod::CreateInstance() {
return new SymbolLocatorDebuginfod();
}
-static std::optional GetFileForModule(
-const ModuleSpec &module_spec,
-std::function(llvm::object::BuildIDRef)>
-PullFromServer) {
- if
@@ -112,31 +142,49 @@ SymbolLocator *SymbolLocatorDebuginfod::CreateInstance() {
return new SymbolLocatorDebuginfod();
}
-static std::optional GetFileForModule(
-const ModuleSpec &module_spec,
-std::function(llvm::object::BuildIDRef)>
-PullFromServer) {
- if
@@ -112,31 +142,49 @@ SymbolLocator *SymbolLocatorDebuginfod::CreateInstance() {
return new SymbolLocatorDebuginfod();
}
-static std::optional GetFileForModule(
-const ModuleSpec &module_spec,
-std::function(llvm::object::BuildIDRef)>
-PullFromServer) {
- if
@@ -54,6 +55,34 @@ class PluginProperties : public Properties {
return urls;
}
+ llvm::Expected GetCachePath() {
JDevlieghere wrote:
Is it always safe to return a StringRef here? It looks fine at first sight, but
this code also doesn't look particular
@@ -112,31 +142,49 @@ SymbolLocator *SymbolLocatorDebuginfod::CreateInstance() {
return new SymbolLocatorDebuginfod();
}
-static std::optional GetFileForModule(
-const ModuleSpec &module_spec,
-std::function(llvm::object::BuildIDRef)>
-PullFromServer) {
- if
@@ -112,31 +142,49 @@ SymbolLocator *SymbolLocatorDebuginfod::CreateInstance() {
return new SymbolLocatorDebuginfod();
}
-static std::optional GetFileForModule(
-const ModuleSpec &module_spec,
-std::function(llvm::object::BuildIDRef)>
-PullFromServer) {
- if
@@ -112,31 +142,49 @@ SymbolLocator *SymbolLocatorDebuginfod::CreateInstance() {
return new SymbolLocatorDebuginfod();
}
-static std::optional GetFileForModule(
-const ModuleSpec &module_spec,
-std::function(llvm::object::BuildIDRef)>
-PullFromServer) {
- if
@@ -1,7 +1,13 @@
include "../../../../include/lldb/Core/PropertiesBase.td"
let Definition = "symbollocatordebuginfod" in {
- def ServerURLs : Property<"server_urls", "Array">,
+ def ServerURLs : Property<"server-urls", "Array">,
ElementType<"String">,
Desc<"An orde
@@ -112,31 +141,52 @@ SymbolLocator *SymbolLocatorDebuginfod::CreateInstance() {
return new SymbolLocatorDebuginfod();
}
-static std::optional GetFileForModule(
-const ModuleSpec &module_spec,
-std::function(llvm::object::BuildIDRef)>
-PullFromServer) {
- if
@@ -1,7 +1,13 @@
include "../../../../include/lldb/Core/PropertiesBase.td"
let Definition = "symbollocatordebuginfod" in {
- def ServerURLs : Property<"server_urls", "Array">,
+ def ServerURLs : Property<"server-urls", "Array">,
ElementType<"String">,
Desc<"An orde
@@ -112,31 +141,52 @@ SymbolLocator *SymbolLocatorDebuginfod::CreateInstance() {
return new SymbolLocatorDebuginfod();
}
-static std::optional GetFileForModule(
-const ModuleSpec &module_spec,
-std::function(llvm::object::BuildIDRef)>
-PullFromServer) {
- if
https://github.com/JDevlieghere approved this pull request.
Thanks! This LGTM.
https://github.com/llvm/llvm-project/pull/78605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -836,36 +834,18 @@ Status PlatformDarwinKernel::GetSharedModuleKernel(
module_sp.reset(new Module(kern_spec));
if (module_sp && module_sp->GetObjectFile() &&
module_sp->MatchesModuleSpec(kern_spec)) {
-// module_sp is an actual kernel binary we
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/78652
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.l
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/78817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/78773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Is it possible to write a test for this in `DWARFExpressionTest.cpp`?
https://github.com/llvm/llvm-project/pull/78977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
@@ -0,0 +1,105 @@
+#include "Plugins/Platform/MacOSX/PlatformMacOSX.h"
+#include "Plugins/Platform/MacOSX/PlatformRemoteMacOSX.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Progress.h"
+#include "lldb/Host/FileSystem.h"
+#include "lldb/Host/HostInfo.h"
+#include "lldb/U
@@ -0,0 +1,105 @@
+#include "Plugins/Platform/MacOSX/PlatformMacOSX.h"
+#include "Plugins/Platform/MacOSX/PlatformRemoteMacOSX.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Progress.h"
+#include "lldb/Host/FileSystem.h"
+#include "lldb/Host/HostInfo.h"
+#include "lldb/U
@@ -0,0 +1,105 @@
+#include "Plugins/Platform/MacOSX/PlatformMacOSX.h"
+#include "Plugins/Platform/MacOSX/PlatformRemoteMacOSX.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Progress.h"
+#include "lldb/Host/FileSystem.h"
+#include "lldb/Host/HostInfo.h"
+#include "lldb/U
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/79508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,65 @@
+# Tests for basic Debuginfod functionality
+
+Because the Debuginfod protocol is a simple HTTP path-based system, one can
+mimic a Debuginfod server by setting up a directory structure to reflect the
+protocol properly. That's how all these tests operate. We over
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/79181
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
I'm wondering if shell test are really the best way to test this. For more
complex scenarios like are being tested here, we generally prefer [1] API tests
because they're more expressive and allow you to build more complicated test
binaries with our M
@@ -4281,25 +4281,31 @@ void
Process::CalculateExecutionContext(ExecutionContext &exe_ctx) {
//return Host::GetArchSpecForExistingProcess (process_name);
//}
+EventSP Process::CreateEventFromProcessState(uint32_t event_type) {
+ auto event_data_sp =
+ std::make_shar
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/79045
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1401 - 1500 of 5184 matches
Mail list logo
