[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-30 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Thanks for the explanation! What kind of tool reads this file? One such tool is SWIG, which happens to support macro expansion, but we have other tools downstream that don't. > It's still weird to use tblgen to process non-td files imho. We have a bunch > of places that

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-04-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. https://github.com/llvm/llvm-project/pull/90666 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-04-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/90666 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-04-30 Thread Jonas Devlieghere via lldb-commits
@@ -8,6 +8,12 @@ set(LLDB_INCLUDE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/include") set(LLDB_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) set(LLDB_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}) +if (LLDB_BUILT_STANDALONE) + set(LLDB_OBJ_DIR ${CMAKE_CURRENT_BINARY_DIR}) +else() + set(LLDB_OBJ_

[Lldb-commits] [lldb] [LLDB][ELF] Fix section unification to not just use names. (PR #90099)

2024-05-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/90099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use Python script to generate SBLanguages.h (PR #90753)

2024-05-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/90753 Use a Python script to generate SBLanguages.h instead of piggybacking on LLDB TableGen. This addresses Nico Weber's post-commit feedback. >From 5f66f7b0bf2add28eebdfefd2ae9459f8548a1b4 Mon Sep 17 00:00:00 2

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-05-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: https://github.com/llvm/llvm-project/pull/90753 https://github.com/llvm/llvm-project/pull/89981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use Python script to generate SBLanguages.h (PR #90753)

2024-05-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/90753 >From 5f66f7b0bf2add28eebdfefd2ae9459f8548a1b4 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 1 May 2024 10:36:51 -0700 Subject: [PATCH 1/2] [lldb] Use Python script to generate SBLanguages.h U

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-05-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/90666 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-05-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/90666 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Install generated API headers into LLDB.framework (PR #90666)

2024-05-01 Thread Jonas Devlieghere via lldb-commits
@@ -8,6 +8,8 @@ set(LLDB_INCLUDE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/include") set(LLDB_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) set(LLDB_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}) JDevlieghere wrote: Remove the newline. https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb] Use Python script to generate SBLanguages.h (PR #90753)

2024-05-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/90753 >From 5f66f7b0bf2add28eebdfefd2ae9459f8548a1b4 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 1 May 2024 10:36:51 -0700 Subject: [PATCH 1/3] [lldb] Use Python script to generate SBLanguages.h U

[Lldb-commits] [lldb] [lldb][Docs] Remove .txt copy of tutorial (PR #90585)

2024-05-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/90585 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Use proper LLDB/GDB project branding in tutorial (PR #90712)

2024-05-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/90712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use Python script to generate SBLanguages.h (PR #90753)

2024-05-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/90753 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] LLDB Debuginfod tests and a fix or two (PR #90622)

2024-05-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/90622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
@@ -321,9 +321,26 @@ class LLDB_API SBDebugger { void SetLoggingCallback(lldb::LogOutputCallback log_callback, void *baton); + /// DEPRECATED: We used to only support one Destroy callback. Now that we + /// support Add and Remove, you should only remove Destroy callbacks

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
@@ -731,8 +747,11 @@ class Debugger : public std::enable_shared_from_this, lldb::TargetSP m_dummy_target_sp; Diagnostics::CallbackID m_diagnostics_callback_id; - lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr; - void *m_destroy_callback_baton = nullp

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
@@ -743,9 +743,24 @@ DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, } void Debugger::HandleDestroyCallback() { - if (m_destroy_callback) { -m_destroy_callback(GetID(), m_destroy_callback_baton); -m_destroy_callback = nullptr; + std::lock_g

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
@@ -731,8 +747,11 @@ class Debugger : public std::enable_shared_from_this, lldb::TargetSP m_dummy_target_sp; Diagnostics::CallbackID m_diagnostics_callback_id; - lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr; - void *m_destroy_callback_baton = nullp

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
@@ -62,12 +62,15 @@ typedef void *thread_arg_t; // Host thread argument type typedef void *thread_result_t; // Host thread result type typedef void *(*thread_func_t)(void *); // Host thread function type typedef int pipe_t; // Host pipe

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
@@ -1690,11 +1690,28 @@ void SBDebugger::SetDestroyCallback( lldb::SBDebuggerDestroyCallback destroy_callback, void *baton) { LLDB_INSTRUMENT_VA(this, destroy_callback, baton); if (m_opaque_sp) { -return m_opaque_sp->SetDestroyCallback( -destroy_callback, ba

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
@@ -1690,11 +1690,28 @@ void SBDebugger::SetDestroyCallback( lldb::SBDebuggerDestroyCallback destroy_callback, void *baton) { LLDB_INSTRUMENT_VA(this, destroy_callback, baton); if (m_opaque_sp) { -return m_opaque_sp->SetDestroyCallback( -destroy_callback, ba

[Lldb-commits] [lldb] [lldb] Add a log level to Host::SystemLog (PR #90904)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/90904 Add the ability to specify a log level to Host::SystemLog. >From a7b4d7bd7374d0b41cb82fe8c97315006bf7d212 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 2 May 2024 13:20:16 -0700 Subject: [PATC

[Lldb-commits] [lldb] [lldb] Add a log level to Host::SystemLog (PR #90904)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/90904 >From 1109b65209d49046e029b780bf484a810c1bd42e Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 2 May 2024 13:20:16 -0700 Subject: [PATCH] [lldb] Add a log level to Host::SystemLog Add the abilit

[Lldb-commits] [lldb] [lldb] [debugserver] address preprocessor warning, extra arg (PR #90808)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/90808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a log level to Host::SystemLog (PR #90904)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/90904 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Always emit diagnostic events to the system log (PR #90913)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/90913 Always emit diagnostic events to the system log so that they end up in the sysdiagnose on Darwin. >From 458913020dd443c0ca92caa63cf8477035f8c5cc Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu,

[Lldb-commits] [lldb] [lldb] Create a single Severity enum in lldb-enumerations (PR #90917)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/90917 We have 3 different enums all expressing severity (info, warning, error). Remove all uses with a new Severity enum in lldb-enumerations.h. >From 23b16ba8418f03dd11190798ccddf218cbfaf3f1 Mon Sep 17 00:00:00

[Lldb-commits] [lldb] [lldb] Add a log level to Host::SystemLog (PR #90904)

2024-05-02 Thread Jonas Devlieghere via lldb-commits
@@ -87,8 +87,15 @@ class Host { StartMonitoringChildProcess(const MonitorChildProcessCallback &callback, lldb::pid_t pid); + /// System log level. + enum SystemLogLevel { +eSystemLogInfo, +eSystemLogWarning, JDevlieghe

[Lldb-commits] [lldb] [lldb] Unify CalculateMD5 return types (PR #90921)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! LGTM. https://github.com/llvm/llvm-project/pull/90921 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create a single Severity enum in lldb-enumerations (PR #90917)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
@@ -1347,6 +1347,12 @@ enum DebuggerBroadcastBit { eBroadcastBitProgressCategory = (1 << 3), }; +enum Severity { JDevlieghere wrote: It would, but `lldb-enumerations.h` exclusively uses `enum` and I think consistency outweighs the small benefit of using `e

[Lldb-commits] [lldb] [lldb] Create a single Severity enum in lldb-enumerations (PR #90917)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
@@ -1347,6 +1347,12 @@ enum DebuggerBroadcastBit { eBroadcastBitProgressCategory = (1 << 3), }; +enum Severity { + eSeverityError, + eSeverityWarning, + eSeverityInfo, JDevlieghere wrote: I considered the latter, but we use `eSeverityRemark` so infrequen

[Lldb-commits] [lldb] [lldb] Create a single Severity enum in lldb-enumerations (PR #90917)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/90917 >From 23b16ba8418f03dd11190798ccddf218cbfaf3f1 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 2 May 2024 16:44:18 -0700 Subject: [PATCH 1/2] [lldb] Create a single Severity enum in lldb-enumerat

[Lldb-commits] [lldb] [lldb] Create a single Severity enum in lldb-enumerations (PR #90917)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/90917 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Always emit diagnostic events to the system log (PR #90913)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/90913 >From 7ed4008b32d6ec7809a9cea0eb4462d1b90f4e52 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 2 May 2024 15:47:46 -0700 Subject: [PATCH] [lldb] Always emit diagnostic events to the system log A

[Lldb-commits] [lldb] [lldb] Always emit diagnostic events to the system log (PR #90913)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/90913 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Unify DW_TAG -> string conversions (PR #90657)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/90657 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add TeeLogHandler to log to 2 handlers (PR #90984)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/90984 Add a T-style log handler that multiplexes messages to two log handlers. The goal is to use this in combination with the SystemLogHandler to log messages both to the user requested file as well as the syste

[Lldb-commits] [lldb] [lldb] Add TeeLogHandler to log to 2 handlers (PR #90984)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
@@ -438,3 +439,15 @@ void RotatingLogHandler::Dump(llvm::raw_ostream &stream) const { } stream.flush(); } + +TeeLogHandler::TeeLogHandler(std::shared_ptr first_log_handler, + std::shared_ptr second_log_handler) +: m_first_log_handler(first_l

[Lldb-commits] [lldb] [lldb] Add TeeLogHandler to log to 2 handlers (PR #90984)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/90984 >From d1adf630a9981f275f24e4d0c2c613a90ff38290 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 3 May 2024 10:11:40 -0700 Subject: [PATCH 1/2] [lldb] Add TeeLogHandler to log to 2 handlers Add a

[Lldb-commits] [lldb] [lldb] Add TeeLogHandler to log to 2 handlers (PR #90984)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/90984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Unify CalculateMD5 return types (PR #90921)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/90921 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Unify CalculateMD5 return types" (PR #90998)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/90998 Reverts llvm/llvm-project#90921 >From 2beb507e10a6dbe6387bc67143601a66b0168293 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 3 May 2024 12:14:36 -0700 Subject: [PATCH] Revert "[lldb] Unify Cal

[Lldb-commits] [lldb] Revert "[lldb] Unify CalculateMD5 return types" (PR #90998)

2024-05-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/90998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Verify target stop-hooks support with scripted process (PR #91107)

2024-05-06 Thread Jonas Devlieghere via lldb-commits
@@ -100,6 +111,10 @@ def get_register_context(self) -> str: def __lldb_init_module(debugger, dict): if not "SKIP_SCRIPTED_PROCESS_LAUNCH" in os.environ: +debugger.HandleCommand( JDevlieghere wrote: This seems like it would be worth documenting in

[Lldb-commits] [lldb] [lldb/crashlog] Update incorrect help message for `--no-crashed-only` option (PR #91162)

2024-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Since we're already using `argparse`, can we use the `BooleanOptionalAction` to make this work automatically with the affirmative option? https://docs.python.org/3.9/library/argparse.html#action https://github.com/llvm/llvm-project/pull/91162

[Lldb-commits] [lldb] lldb create API folder if it does not exist, before creating SBLangua… (PR #91128)

2024-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/91128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use add_custom_command for SBLanguages.h (PR #91254)

2024-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/91254 Use add_custom_command instead of add_custom_target to generate SBLanguages.h. >From 7fa130d2bb2e45f350ca8c3851d32bbec3332f8c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 6 May 2024 11:48:24

[Lldb-commits] [lldb] [lldb] Use Python script to generate SBLanguages.h (PR #90753)

2024-05-06 Thread Jonas Devlieghere via lldb-commits
@@ -20,9 +20,19 @@ if(LLDB_ENABLE_LUA) set(lldb_lua_wrapper ${lua_bindings_dir}/LLDBWrapLua.cpp) endif() -lldb_tablegen(../../include/lldb/API/SBLanguages.h -gen-lldb-sbapi-dwarf-enum - SOURCE ${LLVM_MAIN_INCLUDE_DIR}/llvm/BinaryFormat/Dwarf.def - TARGET lldb-sbapi-dwarf-e

[Lldb-commits] [lldb] [lldb/crashlog] Update incorrect help message for `--no-crashed-only` option (PR #91162)

2024-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/91162 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed SyntaxWarning: invalid escape sequence \[ \d \s (PR #91146)

2024-05-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The change itself looks fine, but can you please add a bit more info to the commit message, such as the Python version you're seeing this with. https://github.com/llvm/llvm-project/pull/91146 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] [lldb] Use add_custom_command for SBLanguages.h (PR #91254)

2024-05-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Good point. I can't imagine anything needing the SB header that doesn't need the rest of the framework, but if that's the case we go through a custom target. https://github.com/llvm/llvm-project/pull/91254 ___ lldb-commits mailin

[Lldb-commits] [lldb] [lldb] Use add_custom_command for SBLanguages.h (PR #91254)

2024-05-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/91254 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

2024-05-07 Thread Jonas Devlieghere via lldb-commits
@@ -731,8 +747,11 @@ class Debugger : public std::enable_shared_from_this, lldb::TargetSP m_dummy_target_sp; Diagnostics::CallbackID m_diagnostics_callback_id; - lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr; - void *m_destroy_callback_baton = nullp

[Lldb-commits] [lldb] [lldb] Request crash report when prompting for a bug report on Darwin (PR #91371)

2024-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/91371 On Darwin platforms, the system will generate a crash report in ~/Library/Logs/DiagnosticReports/ when a process crashes. These reports are much more useful than the "pretty backtraces" printed by LLVM and

[Lldb-commits] [lldb] [lldb] Request crash report when prompting for a bug report on Darwin (PR #91371)

2024-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/91371 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reinstate lldb-sbapi-dwarf-enums target (NFC) (PR #91390)

2024-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/91390 Alex pointed out in #91254 that we only need the custom target if we had more than one target depending on it. This isn't the case upstream, but on our downstream fork, we have a second dependency. Reintrod

[Lldb-commits] [lldb] [lldb] Reinstate lldb-sbapi-dwarf-enums target (NFC) (PR #91390)

2024-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/91390 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][breakpointoptions] Make disabled keyword red (PR #91404)

2024-05-07 Thread Jonas Devlieghere via lldb-commits
@@ -534,7 +534,8 @@ void BreakpointOptions::GetDescription(Stream *s, if (m_ignore_count > 0) s->Printf("ignore: %d ", m_ignore_count); -s->Printf("%sabled ", m_enabled ? "en" : "dis"); +s->PutCStringColorHighlighted(m_enabled ? "enabled " : "disabled ", +

[Lldb-commits] [lldb] [lldb][DWARF] Sort ranges list in dwarf 5. (PR #91343)

2024-05-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/91343 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a dependency from lldb-sbapi-dwarf-enums as a dependency of libll… (PR #91511)

2024-05-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/91511 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Enforce image loading policy (PR #91109)

2024-05-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/91109 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed SyntaxWarning: invalid escape sequence \[ \d \s (PR #91146)

2024-05-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/91146 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Unify CalculateMD5 return types (PR #91029)

2024-05-08 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > @JDevlieghere , do you know if there's a way to run buildbot on a merge of > this PR and main branch - just to validate the build/tests work before this > merge? Not that I know. When failures are macOS specific I'm happy to apply a PR locally and run the test suite and

[Lldb-commits] [lldb] [lldb] Unify CalculateMD5 return types (PR #91029)

2024-05-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/91029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > My understanding was that the progress increment is designed to be really > cheap (writing two pointers) and that it's up to presentation layer to decide > a t what frequency to update the UI. > > @JDevlieghere — is that perception correct? You're correct about the prese

[Lldb-commits] [lldb] [lldb][enums] Remove broadcast bits from debugger (PR #91618)

2024-05-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM but let's give Alex and Ismail a chance to take a look too. https://github.com/llvm/llvm-project/pull/91618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb][enums] Remove broadcast bits from debugger (PR #91618)

2024-05-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/91618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > If this turns out to be necessary, one way to rate-limit them would be to > have a nesting depth counter. Assuming that these imports happen recursively > we could create only Progress objects for the top n layers. Is the code that emits the progress event recursive too?

[Lldb-commits] [lldb] [lldb/crashlog] Fix module binary resolution (PR #91631)

2024-05-09 Thread Jonas Devlieghere via lldb-commits
@@ -418,9 +418,22 @@ def locate_module_and_debug_symbols(self): with print_lock: print('falling back to binary inside "%s"' % dsym) self.symfile = dsym -for filename in os.listdi

[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

2024-05-09 Thread Jonas Devlieghere via lldb-commits
@@ -848,6 +850,13 @@ void Breakpoint::GetDescription(Stream *s, lldb::DescriptionLevel level, const size_t num_locations = GetNumLocations(); const size_t num_resolved_locations = GetNumResolvedLocations(); + // Grey out any disabled breakpoints in the list of breakpoint

[Lldb-commits] [lldb] [lldb/crashlog] Fix module binary resolution (PR #91631)

2024-05-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/91631 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Fix module binary resolution (PR #91631)

2024-05-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/91631 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Fix module binary resolution (PR #91631)

2024-05-09 Thread Jonas Devlieghere via lldb-commits
@@ -418,9 +418,20 @@ def locate_module_and_debug_symbols(self): with print_lock: print('falling back to binary inside "%s"' % dsym) self.symfile = dsym -for filename in os.listdi

[Lldb-commits] [lldb] [lldb/crashlog] Fix test failure when creating a target using command options (PR #91653)

2024-05-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/91653 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Unify CalculateMD5 return types (PR #91029)

2024-05-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/91029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Put SBSourceLanguageName in lldb namespace (PR #91685)

2024-05-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/91685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ccf1469 - [lldb] Make lldbVersion a full fledged library

2021-12-08 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-12-08T15:14:34-08:00 New Revision: ccf1469a4cdb03cb2bc7868f76164e85d90ebee1 URL: https://github.com/llvm/llvm-project/commit/ccf1469a4cdb03cb2bc7868f76164e85d90ebee1 DIFF: https://github.com/llvm/llvm-project/commit/ccf1469a4cdb03cb2bc7868f76164e85d90ebee1.d

[Lldb-commits] [lldb] 58473d8 - [lldb] Use LLDB_VERSION_STRING instead of CLANG_VERSION_STRING

2021-12-13 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-12-13T16:58:39-08:00 New Revision: 58473d84e0c7796de5dcfd3153e5d5cc8ad034b3 URL: https://github.com/llvm/llvm-project/commit/58473d84e0c7796de5dcfd3153e5d5cc8ad034b3 DIFF: https://github.com/llvm/llvm-project/commit/58473d84e0c7796de5dcfd3153e5d5cc8ad034b3.d

Re: [Lldb-commits] [lldb] 58473d8 - [lldb] Use LLDB_VERSION_STRING instead of CLANG_VERSION_STRING

2021-12-13 Thread Jonas Devlieghere via lldb-commits
This is NFC On Mon, Dec 13, 2021 at 5:00 PM David Blaikie wrote: > Any chance of test coverage? > > On Mon, Dec 13, 2021 at 4:58 PM Jonas Devlieghere via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> >> Author: Jonas Devlieghere >> Date: 20

[Lldb-commits] [lldb] 100863c - [lldb] Check if language is supported before creating a REPL instance

2021-12-14 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-12-14T12:05:35-08:00 New Revision: 100863ccd8d41091f90749ba76d91f6dfafdde57 URL: https://github.com/llvm/llvm-project/commit/100863ccd8d41091f90749ba76d91f6dfafdde57 DIFF: https://github.com/llvm/llvm-project/commit/100863ccd8d41091f90749ba76d91f6dfafdde57.d

[Lldb-commits] [lldb] 67bc243 - [lldb] Remove --reproducer-finalize and associated functionality

2021-12-17 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-12-17T12:19:55-08:00 New Revision: 67bc2435359a8f09f607d6c3fc0a196bd496d31f URL: https://github.com/llvm/llvm-project/commit/67bc2435359a8f09f607d6c3fc0a196bd496d31f DIFF: https://github.com/llvm/llvm-project/commit/67bc2435359a8f09f607d6c3fc0a196bd496d31f.d

[Lldb-commits] [lldb] fa12606 - [lldb] Remove reproducer replay functionality

2021-12-17 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-12-17T17:14:52-08:00 New Revision: fa1260697ec80ac0586d67c0de8758818ca865c0 URL: https://github.com/llvm/llvm-project/commit/fa1260697ec80ac0586d67c0de8758818ca865c0 DIFF: https://github.com/llvm/llvm-project/commit/fa1260697ec80ac0586d67c0de8758818ca865c0.d

[Lldb-commits] [lldb] 46a28a9 - [lldb] Create a property to store the REPL language

2022-01-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-05T15:03:46-08:00 New Revision: 46a28a954e5e813f64ff458891b2d0891963c7d8 URL: https://github.com/llvm/llvm-project/commit/46a28a954e5e813f64ff458891b2d0891963c7d8 DIFF: https://github.com/llvm/llvm-project/commit/46a28a954e5e813f64ff458891b2d0891963c7d8.d

[Lldb-commits] [lldb] 7244e9c - [LLDB] libcxx summary formatters for std::string_view

2022-01-07 Thread Jonas Devlieghere via lldb-commits
Author: Ben Jackson Date: 2022-01-07T11:41:16-08:00 New Revision: 7244e9c2f5f3ea02cc0d7103fa35782f050aacf0 URL: https://github.com/llvm/llvm-project/commit/7244e9c2f5f3ea02cc0d7103fa35782f050aacf0 DIFF: https://github.com/llvm/llvm-project/commit/7244e9c2f5f3ea02cc0d7103fa35782f050aacf0.diff L

[Lldb-commits] [lldb] ab76189 - [lldb] Use lit_config.note to print module cache message

2022-01-07 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-07T13:35:18-08:00 New Revision: ab7618914dec6384f24b30ad2d45b82a51647a33 URL: https://github.com/llvm/llvm-project/commit/ab7618914dec6384f24b30ad2d45b82a51647a33 DIFF: https://github.com/llvm/llvm-project/commit/ab7618914dec6384f24b30ad2d45b82a51647a33.d

[Lldb-commits] [lldb] d13da5f - [lldb] Remove lldbconfig module

2022-01-07 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-07T15:58:43-08:00 New Revision: d13da5f0da1ca39d2130f4ae602184350c3ec968 URL: https://github.com/llvm/llvm-project/commit/d13da5f0da1ca39d2130f4ae602184350c3ec968 DIFF: https://github.com/llvm/llvm-project/commit/d13da5f0da1ca39d2130f4ae602184350c3ec968.d

[Lldb-commits] [lldb] 4609e30 - [lldb] Remove lldb-instr

2022-01-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-10T11:48:16-08:00 New Revision: 4609e30f5001cfcba59d1f2f90ce72ebfda6e61f URL: https://github.com/llvm/llvm-project/commit/4609e30f5001cfcba59d1f2f90ce72ebfda6e61f DIFF: https://github.com/llvm/llvm-project/commit/4609e30f5001cfcba59d1f2f90ce72ebfda6e61f.d

[Lldb-commits] [lldb] 69c55d6 - [lldb] Remove LLDB_RECORD_CHAR_PTR_* macros

2022-01-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-10T11:57:20-08:00 New Revision: 69c55d63620066dfd6714b0b666f7cac5a3407eb URL: https://github.com/llvm/llvm-project/commit/69c55d63620066dfd6714b0b666f7cac5a3407eb DIFF: https://github.com/llvm/llvm-project/commit/69c55d63620066dfd6714b0b666f7cac5a3407eb.d

[Lldb-commits] [lldb] da4b743 - [lldb] Remove LLDB_RECORD_DUMMY_* macros

2022-01-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-10T12:05:54-08:00 New Revision: da4b7437f932570227b9debecc031a40875445fa URL: https://github.com/llvm/llvm-project/commit/da4b7437f932570227b9debecc031a40875445fa DIFF: https://github.com/llvm/llvm-project/commit/da4b7437f932570227b9debecc031a40875445fa.d

[Lldb-commits] [lldb] 1267506 - [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

2022-01-10 Thread Jonas Devlieghere via lldb-commits
Author: Lirong Yuan Date: 2022-01-10T14:33:09-08:00 New Revision: 1267506ea54a62e0c728215c033b256ce856db30 URL: https://github.com/llvm/llvm-project/commit/1267506ea54a62e0c728215c033b256ce856db30 DIFF: https://github.com/llvm/llvm-project/commit/1267506ea54a62e0c728215c033b256ce856db30.diff L

[Lldb-commits] [lldb] 049ae93 - [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

2022-01-13 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-13T15:27:38-08:00 New Revision: 049ae93097c0c6f7cef6294f16c7f6de9138cd6d URL: https://github.com/llvm/llvm-project/commit/049ae93097c0c6f7cef6294f16c7f6de9138cd6d DIFF: https://github.com/llvm/llvm-project/commit/049ae93097c0c6f7cef6294f16c7f6de9138cd6d.d

[Lldb-commits] [lldb] 8faca2e - [lldb] Fix platform selection on Apple Silicon

2022-01-14 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-14T16:03:49-08:00 New Revision: 8faca2ed6adebffa76c6eb506f15dfd38ab512a7 URL: https://github.com/llvm/llvm-project/commit/8faca2ed6adebffa76c6eb506f15dfd38ab512a7 DIFF: https://github.com/llvm/llvm-project/commit/8faca2ed6adebffa76c6eb506f15dfd38ab512a7.d

[Lldb-commits] [lldb] a10692c - [lldb] Only promote -Wignored-attributes to an error

2022-01-14 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-14T16:19:16-08:00 New Revision: a10692c734faff9ef28bc725703a0eacea78eeca URL: https://github.com/llvm/llvm-project/commit/a10692c734faff9ef28bc725703a0eacea78eeca DIFF: https://github.com/llvm/llvm-project/commit/a10692c734faff9ef28bc725703a0eacea78eeca.d

[Lldb-commits] [lldb] ff85dcb - [lldb] Remove PlatformDarwin::GetCompatibleArch helper

2022-01-15 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-15T09:51:16-08:00 New Revision: ff85dcb1c5b01411a6f9f2dc4c0e087467411f50 URL: https://github.com/llvm/llvm-project/commit/ff85dcb1c5b01411a6f9f2dc4c0e087467411f50 DIFF: https://github.com/llvm/llvm-project/commit/ff85dcb1c5b01411a6f9f2dc4c0e087467411f50.d

Re: [Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

2022-01-15 Thread Jonas Devlieghere via lldb-commits
Hey Galina, Seems like this didn't take effect until the buildbots got rebooted, which seems to have happened last night. Apparently my patch broke all the buildbots because the jobs variable was not what I thought it was... Anyway, I've removed the offending code in 4d68a096efc7b5ad0d55cf6422596

[Lldb-commits] [lldb] a6469cd - [lldb] Correctly display the number of types found

2022-01-15 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-15T10:31:49-08:00 New Revision: a6469cdbc426437dcb8442ae398f0a863336de37 URL: https://github.com/llvm/llvm-project/commit/a6469cdbc426437dcb8442ae398f0a863336de37 DIFF: https://github.com/llvm/llvm-project/commit/a6469cdbc426437dcb8442ae398f0a863336de37.d

<    8   9   10   11   12   13   14   15   16   17   >