[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -9,10 +9,12 @@ #ifndef LLDB_API_SBDEBUGGER_H #define LLDB_API_SBDEBUGGER_H +#include #include #include "lldb/API/SBDefines.h" #include "lldb/API/SBPlatform.h" +#include "third_party/llvm/llvm-project/lldb/include/lldb/API/SBStructuredData.h" JDevlie

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -1868,8 +1874,28 @@ bool CommandInterpreter::HandleCommand(const char *command_line, LazyBool lazy_add_to_history, CommandReturnObject &result, bool force_re

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include "llvm/A

[Lldb-commits] [lldb] [llvm] [cmake] Prevent implicitly passing `-no_exported_symbols` (PR #87846)

https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/87846 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

JDevlieghere wrote: @Michael137 I'm a little late to the party but I just noticed that `ChildCacheState` is the only `enum class` in `lldb-enumerations.h`. Is that intentional? Is there a reason this cannot be a old-school enum like everything else in that file? I don't feel super strongly abo

[Lldb-commits] [lldb] [lldb] [NFC] Fix swig docstring annotations (PR #88073)

https://github.com/JDevlieghere approved this pull request. Good catch, that matches the [documentation](https://www.swig.org/Doc4.0/Python.html#Python_nn70). LGTM! https://github.com/llvm/llvm-project/pull/88073 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] [lldb] fix dead lock in TypeCategoryMap.cpp (PR #87540)

https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/87540 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

JDevlieghere wrote: > No particular reason apart from it being scoped, which I thought we might > prefer for new enums. But there's no reason it couldn't be an old-school enum If that's the case I think consistency is more important. Mind putting up a PR? https://github.com/llvm/llvm-project/

[Lldb-commits] [lldb] [lldb][sbdebugger] Match progress category enum bit in Debugger.h (PR #87409)

@@ -42,11 +42,13 @@ class LLDB_API SBInputReader { class LLDB_API SBDebugger { public: + // The enum values here need to match their corresponding values in + // Debugger.h. FLAGS_ANONYMOUS_ENUM(){ eBroadcastBitProgress = (1 << 0), eBroadcastBitWarning = (1

[Lldb-commits] [lldb] [lldb][sbdebugger] Match progress category enum bit in Debugger.h (PR #87409)

@@ -1339,6 +1339,14 @@ enum AddressMaskRange { eAddressMaskRangeAll = eAddressMaskRangeAny, }; +/// Used by the debugger to indicate which events are being broadcasted. +enum DebuggerBroadcast { JDevlieghere wrote: `DebuggerBroadcastBit` maybe? https://git

[Lldb-commits] [lldb] [lldb][lit] Add MallocNanoZone envvar to Darwin ASan builds (PR #88431)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/88431 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lit] Add MallocNanoZone envvar to Darwin ASan builds (PR #88431)

JDevlieghere wrote: > LGTM! It would be nice to may be put a link to a bot that shows those warnings Those logs get recycled pretty quickly so that would only be valuable for a handful of days. https://github.com/llvm/llvm-project/pull/88431 ___ lld

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

https://github.com/JDevlieghere requested changes to this pull request. `dyld_shared_cache_util` doesn't come preinstalled on macOS (you can build it yourself locally from source) so I think we should use lldb to check if the library is loaded. https://github.com/llvm/llvm-project/pull/88349 _

[Lldb-commits] [lldb] Add lldb-dap to Swift distributions (PR #88482)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/88482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add lldb-dap to Swift distributions (PR #88482)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/88482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Turn ChildCacheState into an unscoped enum (PR #88703)

https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/88703 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 071ac0a - [lldb] Skip lldb-server unit tests when building with ASan

Author: Jonas Devlieghere Date: 2024-04-15T13:20:54-07:00 New Revision: 071ac0ae3029594167d2bb4d28859bdc36367034 URL: https://github.com/llvm/llvm-project/commit/071ac0ae3029594167d2bb4d28859bdc36367034 DIFF: https://github.com/llvm/llvm-project/commit/071ac0ae3029594167d2bb4d28859bdc36367034.d

[Lldb-commits] [lldb] a855eea - [lldb] Fix the standalone Xcode build after #88317

Author: Jonas Devlieghere Date: 2024-04-15T14:08:56-07:00 New Revision: a855eea7fe86ef09a87f6251b3b711b821ae32bf URL: https://github.com/llvm/llvm-project/commit/a855eea7fe86ef09a87f6251b3b711b821ae32bf DIFF: https://github.com/llvm/llvm-project/commit/a855eea7fe86ef09a87f6251b3b711b821ae32bf.d

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lit] Guard MallocNanoZone envvar in shell tests (PR #88824)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/88824 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct documentation of LLDB_TEST_USER_ARGS (PR #89042)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/89042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] adds additional information to the ProcessInfo object for elf processes (PR #88995)

JDevlieghere wrote: Can we get (a subset) of this information on Darwin? I understand it's only necessary for ELF core files, and from the discussion that there's no standard POSIX way to get this, but it still feels a bit unfortunate to implement all these methods but only implement this for

[Lldb-commits] [clang] [lldb] [llvm] [lldb][test] Remove LLDB_TEST_USE_VENDOR_PACKAGES (PR #89260)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/89260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] this test is flakey on arm in linux because I got too clever (PR #89267)

JDevlieghere wrote: Can you please put up a follow-up that removes the code instead of commenting it out? https://github.com/llvm/llvm-project/pull/89267 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

@@ -1197,6 +1197,32 @@ Status Platform::PutFile(const FileSpec &source, const FileSpec &destination, if (!source_file) return Status(source_file.takeError()); Status error; + + bool requires_upload = true; + uint64_t dest_md5_low, dest_md5_high; + bool success = Cal

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

@@ -3419,7 +3419,7 @@ bool GDBRemoteCommunicationClient::GetFileExists( } bool GDBRemoteCommunicationClient::CalculateMD5( -const lldb_private::FileSpec &file_spec, uint64_t &high, uint64_t &low) { +const lldb_private::FileSpec &file_spec, uint64_t &low, uint64_t &high

[Lldb-commits] [lldb] [lldb][nfc] Remove unused member Disassembler::m_base_addr (PR #89289)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/89289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Check for null oso SymbolFile in SymbolFileDwarfDebugMap::ResolveSymbolContext (PR #89324)

https://github.com/JDevlieghere approved this pull request. LGTM with Alex' suggestion and the code formatted. https://github.com/llvm/llvm-project/pull/89324 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

JDevlieghere wrote: Is it possible to test this, for example by explicitly killing the debug stub? https://github.com/llvm/llvm-project/pull/89405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

https://github.com/JDevlieghere approved this pull request. LGMT with the formatting fixed. https://github.com/llvm/llvm-project/pull/89433 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

@@ -431,7 +431,9 @@ void IRExecutionUnit::GetRunnableInfo(Status &error, lldb::addr_t &func_addr, } m_failed_lookups.clear(); - +ss.PutCString( +"\nHint: The expression tried to call a function missing from the " +"target, perhaps because it was op

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/89433 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Provide a better error message for missing symbols (PR #89433)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/89433 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [lldb] [llvm] Apply modernize-use-starts-ends-with on llvm-project (PR #89140)

https://github.com/JDevlieghere approved this pull request. LLDB & VFS change LGTM. https://github.com/llvm/llvm-project/pull/89140 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [lldb] [llvm] Apply modernize-use-starts-ends-with on llvm-project (PR #89140)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/89140 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [easy] Fix spacing in help message of 'process save-core' command (PR #89445)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/89445 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

https://github.com/JDevlieghere requested changes to this pull request. +1 on what Cyndy said. The lldb change itself looks fine. https://github.com/llvm/llvm-project/pull/89480 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] [lldb][Docs] Make formatting regular in lldb-gdb-remote.txt (PR #89587)

JDevlieghere wrote: > Subsequent PRs will build on this: > > * Enable Markdown support in the website build. I added markdown support in 8b95bd3310c126e76e0714bea6003a9b1aa739fb but it was subsequently removed again in d03b04f211e73c2f59ba5dc6a6a8c777de001ad6 (I wasn't added as a reviewer, so

[Lldb-commits] [lldb] [lldb][Docs] Make formatting regular in lldb-gdb-remote.txt (PR #89587)

JDevlieghere wrote: +1 on making this available on the website. Unless the goal is to preserve both the textual and the markdown format, I'm not sure there's a whole lot of value in landing this. Maybe we can avoid churn and jump straight ahead to the markdown version? https://github.com/llv

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/89405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

@@ -104,3 +115,49 @@ def test_empty_escape_prefix(self): "Help can be invoked", command_escape_prefix="", ) + +@skipIfWindows +@skipIfRemote +def test_exit_status_message_sigterm(self): +source = "main.cpp" +program =

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

https://github.com/JDevlieghere requested changes to this pull request. https://github.com/llvm/llvm-project/pull/89405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Remove unused pexpect/ptyprocess (PR #89609)

https://github.com/JDevlieghere approved this pull request. Thank you for seeing this all the way through, Jordan! 🥳 https://github.com/llvm/llvm-project/pull/89609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb][Core] Fix pointless if conditon (PR #89650)

https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/89650 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Core] Fix pointless if conditon (PR #89650)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/89650 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

JDevlieghere wrote: This looks like a nice improvement for folks using those generators. Even though most of these changes look straightforward, it would be a lot easier to review if this was broken up per subproject. Is there any reason that's not possible? https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)

https://github.com/JDevlieghere approved this pull request. Even though you link the issue, I would recommend also summarizing the issue in the commit. Something like "The current code is checking the validity of `obj` twice, instead of checking the new `str_obj` pointer." Otherwise this LGTM

[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/89685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix typo in CumulativeSystemTimeIsValid check (PR #89680)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/89680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix typo in CumulativeSystemTimeIsValid check (PR #89680)

JDevlieghere wrote: Can this be tested in `HostTest.cpp`? https://github.com/llvm/llvm-project/pull/89680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove restriction for remote working directory (PR #89768)

https://github.com/JDevlieghere requested changes to this pull request. Based on the description it's not entirely clear to me what exactly you're trying to achieve. You don't have a working directory, but presumably you still have a platform name and a platform URL? In other words, I assume yo

[Lldb-commits] [lldb] [lldb][test] Remove restriction for remote working directory (PR #89768)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/89768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove restriction for remote working directory (PR #89768)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/89768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][tests] Add ability to run API tests with qemu-user simulator (PR #89765)

https://github.com/JDevlieghere approved this pull request. LGTM with the formatting fixed. https://github.com/llvm/llvm-project/pull/89765 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] [lldb] Enable support for Markdown documentation pages (PR #89716)

https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/89716 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Convert GDB protocol extensions doc to Markdown and add to website (PR #89718)

https://github.com/JDevlieghere approved this pull request. The converted markdown looks good to me. I expect this to render very nicely on the new website with the table-of-content on the right hand side. Thanks for doing this! https://github.com/llvm/llvm-project/pull/89718 _

[Lldb-commits] [lldb] [lldb][nfc] Move broadcaster class strings away from ConstString (PR #89690)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/89690 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] I left some commented code in. This test doesn't run reliably in the different build bots (PR #89637)

JDevlieghere wrote: A potential compromise would be to check that the time is great or equal? https://github.com/llvm/llvm-project/pull/89637 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] [lldb] Switch to llvm::DWARFUnitHeader (PR #89808)

https://github.com/JDevlieghere approved this pull request. 🥳 https://github.com/llvm/llvm-project/pull/89808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix crash in SymbolFileCTF::ParseFunctions (PR #89845)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/89845 Make SymbolFileCTF::ParseFunctions resilient against not being able to resolve the argument or return type of a function. ResolveTypeUID can fail for a variety of reasons so we should always check its result.

[Lldb-commits] [lldb] [lldb] Fix crash in SymbolFileCTF::ParseFunctions (PR #89845)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/89845 >From 5a4f813590b0ceb3fb00ed737650e37715019e89 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 23 Apr 2024 15:26:30 -0700 Subject: [PATCH 1/2] [lldb] Fix crash in SymbolFileCTF::ParseFunctions M

[Lldb-commits] [lldb] [lldb] Fix crash in SymbolFileCTF::ParseFunctions (PR #89845)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/89845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

https://github.com/JDevlieghere requested changes to this pull request. Can you elaborate a bit more about why you want to change the behavior? Your motivation touches on the fact that it might be surprising or racy. While I think having the ability to register multiple callbacks makes sense, I

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

https://github.com/JDevlieghere approved this pull request. LGTM. PS: I was looking at the website and I wonder if we should remove all the "Brief" subtitles and put the brief description right under the packet name. I don't think the subtitle adds much. If you agree, this can be done in a s

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/89405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

@@ -67,6 +67,10 @@ class LLDB_API SBExpressionOptions { void SetTrapExceptions(bool trap_exceptions = true); void SetLanguage(lldb::LanguageType language); + /// Set the language using a pair of language code and version as + /// defined by the DWARF 6 specification. +

[Lldb-commits] [lldb] [lldb][Docs] Link from platform doc to extensions doc (PR #90029)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/90029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF] Fix section unification to not just use names. (PR #90099)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/90099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF] Fix section unification to not just use names. (PR #90099)

https://github.com/JDevlieghere commented: Can we add a test for this with obj2yaml? https://github.com/llvm/llvm-project/pull/90099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF] Fix section unification to not just use names. (PR #90099)

@@ -1854,6 +1854,49 @@ class VMAddressProvider { }; } +namespace { + // We have to do this because ELF doesn't have section IDs, and also + // doesn't require section names to be unique. (We use the section index + // for section IDs, but that isn't guaranteed to be the sa

[Lldb-commits] [lldb] [LLDB][ELF] Fix section unification to not just use names. (PR #90099)

@@ -1854,6 +1854,49 @@ class VMAddressProvider { }; } +namespace { + // We have to do this because ELF doesn't have section IDs, and also + // doesn't require section names to be unique. (We use the section index + // for section IDs, but that isn't guaranteed to be the sa

[Lldb-commits] [lldb] [LLDB][ELF] Fix section unification to not just use names. (PR #90099)

@@ -1854,6 +1854,49 @@ class VMAddressProvider { }; } +namespace { JDevlieghere wrote: Nit: LLVM and LLDB prefer static functions over anonymous namespaces. https://github.com/llvm/llvm-project/pull/90099 ___ lldb

[Lldb-commits] [lldb] [LLDB][ELF] Fix section unification to not just use names. (PR #90099)

@@ -2067,10 +2110,8 @@ unsigned ObjectFileELF::ParseSymbols(Symtab *symtab, user_id_t start_id, SectionList *module_section_list = module_sp ? module_sp->GetSectionList() : nullptr; - // Local cache to avoid doing a FindSectionByName for each symbol. The "const - //

[Lldb-commits] [lldb] [lldb] Recognize DW_TAG_LLVM_ptrauth_type as a type qual (PR #90140)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/90140 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SBValue::GetValueAsAddress API (PR #90144)

https://github.com/JDevlieghere approved this pull request. LGTM with the formatting and braces fixed. https://github.com/llvm/llvm-project/pull/90144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [lldb] Add SBValue::GetValueAsAddress API (PR #90144)

@@ -909,6 +909,26 @@ uint64_t SBValue::GetValueAsUnsigned(uint64_t fail_value) { return fail_value; } +lldb::addr_t SBValue::GetValueAsAddress() { + addr_t fail_value = LLDB_INVALID_ADDRESS; + ValueLocker locker; + lldb::ValueObjectSP value_sp(GetSP(locker)); + if (value

[Lldb-commits] [lldb] [lldb] Add SBValue::GetValueAsAddress API (PR #90144)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/90144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb[Docs] Reduce title noise in packets doc (PR #90183)

https://github.com/JDevlieghere approved this pull request. Nice! https://github.com/llvm/llvm-project/pull/90183 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][sbapi] Fix API break in SBDebugger broadcast bits (PR #90261)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/90261 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

@@ -0,0 +1,45 @@ +//===- LLDBPropertyDefEmitter.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

@@ -0,0 +1,45 @@ +//===- LLDBPropertyDefEmitter.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

@@ -10,6 +10,7 @@ config.llvm_build_mode = lit_config.substitute("@LLVM_BUILD_MODE@") config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@" config.lldb_obj_root = "@LLDB_BINARY_DIR@" config.lldb_src_root = "@LLDB_SOURCE_DIR@" +config.lldb_built_include_dir = lit_config.substitute("@L

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

@@ -239,6 +239,9 @@ def delete_module_cache(path): if is_configured("server"): dotest_cmd += ["--server", config.server] +if is_configured("lldb_built_include_dir"): +dotest_cmd += ["--lldb-built-include-dir", config.lldb_built_include_dir] JDevliegher

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

https://github.com/JDevlieghere approved this pull request. Thanks for bearing with me! LGTM. https://github.com/llvm/llvm-project/pull/89981 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] Add ability to specify running LLDB API testsuite by json description (PR #89764)

JDevlieghere wrote: I'm curious to understand the motivation behind this a bit more. Specifically, how are the JSON files different from creating separate `lit.site.cfg.py` for the different test suite? Downstream we generate separate separate `lit.site.cfg.py` for different test runs, and the

[Lldb-commits] [lldb] [lldb][Docs] Remove more subtitles from packets doc (PR #90443)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/90443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Skip various tests under ASAN on green dragon (PR #90531)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/90531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Sort documented packets alphabetically (PR #90584)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/90584 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Various style improvements to the tutorial (PR #90594)

JDevlieghere wrote: > > Always refer to lldb as lldb not LLDB, to match what the user sees on the > > command line. > > If this were any other doc I'd say it should always be LLDB and GDB as that's > the projects' branding. In this doc I think it's better to imagine the user > is looking at s

[Lldb-commits] [lldb] [LLDB][ELF] Fix section unification to not just use names. (PR #90099)

https://github.com/JDevlieghere approved this pull request. Looks good to me as well. https://github.com/llvm/llvm-project/pull/90099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

<    7   8   9   10   11   12   13   14   15   16   >