https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/83889
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Apologies for the delay. LGTM!
https://github.com/llvm/llvm-project/pull/78977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
JDevlieghere wrote:
@amordo I don't know if you have commit access. Let me you need someone to
press the merge button for you.
https://github.com/llvm/llvm-project/pull/83871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/83895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/83871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/83925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/83861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/83366
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/82799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/84246
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/84278
- Factor our common setup code.
- Split the ProgressManager test into separate tests as they test separate
things.
- Fix usage of EXPECT (which continues on failure) and ASSERT (which halts on
failure).
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/84281
Currently, progress events reported by the ProgressManager and broadcast to
eBroadcastBitProgressCategory always specify they're complete. The problem is
that the ProgressManager reports kNonDeterministicTo
JDevlieghere wrote:
> https://green.lab.llvm.org/green/view/LLDB/ is currently giving me
> ERR_CONNECTION_REFUSED.tores that.
Yeah, unfortunately I don't have an ETA for when this will be back online. It's
probably not worth waiting on that. Changing the configuration of these bots is
almost
JDevlieghere wrote:
I was just wondering, is this actually the TLS bug? I looked at the test and I
don't see it doing anything with thread local storage. This might be another
"new ld" bug. Maybe the feature should be called `ld-prime-bug`?
https://github.com/llvm/llvm-project/pull/84246
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/84281
>From 57908c4924fbb339309e2a4c297178b2a3689bef Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 6 Mar 2024 22:28:14 -0800
Subject: [PATCH] [lldb] Don't report all progress event as completed.
Cur
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/84281
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
🚢 it!
https://github.com/llvm/llvm-project/pull/83501
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere requested changes to this pull request.
I'm worried about making it too easy to ignore errors. The whole point of the
llvm::Error class is that you have to check it. There might be a legitimate
reason you don't about the error the call site, but it should very ex
@@ -179,3 +180,14 @@ def calculate_arch_features(arch_string):
if "LD_PRELOAD" in os.environ:
config.available_features.add("ld_preload-present")
+
JDevlieghere wrote:
I think that's obvious to us, but someone not familiar with our platform might
wonder
JDevlieghere wrote:
LGTM with the check behind `if platform.system() == "Darwin"`.
https://github.com/llvm/llvm-project/pull/84246
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/84278
>From 8b85a2dd23e29cd9eca807d70ffb95bc4b1dcc82 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 6 Mar 2024 21:54:45 -0800
Subject: [PATCH] [lldb] Do some gardening in ProgressReportTest (NFC)
-
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/84278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
🚀
https://github.com/llvm/llvm-project/pull/84246
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/84583
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/84607
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/84588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/84265
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Coincidentally, I ran into the same issue a few weeks ago when I was messing
around with a different way of displaying the progress reports. LGTM!
https://github.com/llvm/llvm-project/pull/84154
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/84154
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/84854
This implements coalescing of progress events using a timeout, as discussed in
the RFC on Discourse [1]. This PR consists of two commits which, depending on
the feedback, I may split up into two PRs. For no
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/84854
>From 3aae84b8caaf904c11b1dab620893620a0fa1c85 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 5 Mar 2024 22:57:43 -0800
Subject: [PATCH 1/2] [lldb] Add an Alarm class
Add an Alarm class which a
https://github.com/JDevlieghere approved this pull request.
Makes sense. LGTM.
https://github.com/llvm/llvm-project/pull/84872
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -914,6 +914,25 @@ def checkForkVForkSupport():
configuration.skip_categories.append("fork")
+def checkPexpectSupport():
+from lldbsuite.test import lldbplatformutil
+
+platform = lldbplatformutil.getPlatform()
+
+# llvm.org/pr22274: need a pexpect repla
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/84854
>From aae699eb956d1e235682b34e6407f6a9990028b3 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 5 Mar 2024 22:57:43 -0800
Subject: [PATCH 1/2] [lldb] Add an Alarm class
Add an Alarm class which a
@@ -0,0 +1,164 @@
+//===-- AlarmTest.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -75,45 +81,86 @@ void Progress::ReportProgress() {
}
}
-ProgressManager::ProgressManager() : m_progress_category_map() {}
+ProgressManager::ProgressManager()
+: m_alarm(std::chrono::milliseconds(100)), m_entries() {}
JDevlieghere wrote:
I initially w
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/85080
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
+1
https://github.com/llvm/llvm-project/pull/84860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/85080
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Seems like the alarm part of this patch is pretty uncontroversial so I'm going
to go ahead and split that off into its own PR so we can settle on the
ProgressManager part here.
https://github.com/llvm/llvm-project/pull/84854
___
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/85329
The commit introduces a new, generic, Alarm class. The class lets you to
schedule functions (callbacks) that will execute after a predefined timeout.
Once scheduled, you can cancel and reset a callback, giv
JDevlieghere wrote:
This contains the Alarm changes from #84854.
@chelcassanova and @adrian-prantl please have another look as you had comments
in the other PR (that have since been addressed).
https://github.com/llvm/llvm-project/pull/85329
___
lldb
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/85342
Currently, we always show the argument passed to dsymForUUID in the
corresponding progress update. Most of the time this is a UUID, but it can also
be an absolute path. The former is pretty uninformative an
@@ -1066,11 +1066,21 @@ bool
SymbolLocatorDebugSymbols::DownloadObjectAndSymbolFile(
command << lookup_arg;
// Log and report progress.
+ std::string lookup_desc;
+ if (uuid_ptr && file_spec_ptr)
+lookup_desc =
+llvm::formatv("{0} ({1})", file_spec_ptr->GetF
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/85329
>From 1ee7c2ffb76f13caa2052bef5dbe4f1982c8bade Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 5 Mar 2024 22:57:43 -0800
Subject: [PATCH] [lldb] Add an Alarm class for coalescing progress reports
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/85329
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-03-15T09:55:15-07:00
New Revision: fd09d510d066583c088e4dbcf23ac0b500c5cc7a
URL:
https://github.com/llvm/llvm-project/commit/fd09d510d066583c088e4dbcf23ac0b500c5cc7a
DIFF:
https://github.com/llvm/llvm-project/commit/fd09d510d066583c088e4dbcf23ac0b500c5cc7a.d
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/85342
>From b50eb7442ab8f37659596efad19f8b30b145 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 14 Mar 2024 17:43:02 -0700
Subject: [PATCH 1/2] [lldb] Show module name in progress update for
down
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/85342
>From b50eb7442ab8f37659596efad19f8b30b145 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 14 Mar 2024 17:43:02 -0700
Subject: [PATCH 1/3] [lldb] Show module name in progress update for
down
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/85342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/85468
This is another step towards supporting DWARF5 checksums and inline
source code in LLDB.
>From 0caa7e713711c8211a10d3e6a249213746d41e9e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 15 Mar 202
@@ -130,18 +130,27 @@ struct LineEntry {
/// Shared pointer to the target this LineEntry belongs to.
void ApplyFileMappings(lldb::TargetSP target_sp);
- // Member variables.
- AddressRange range; ///< The section offset address range for this line
entry.
- FileSpec
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/85468
>From 0caa7e713711c8211a10d3e6a249213746d41e9e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 15 Mar 2024 11:42:44 -0700
Subject: [PATCH 1/3] [lldb] Outline Doxygen comments in LineEntry.h (NFC)
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/85468
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-03-15T17:47:04-07:00
New Revision: 113214e15b5ce3f3ec313eb1fa91a7038ecd072f
URL:
https://github.com/llvm/llvm-project/commit/113214e15b5ce3f3ec313eb1fa91a7038ecd072f
DIFF:
https://github.com/llvm/llvm-project/commit/113214e15b5ce3f3ec313eb1fa91a7038ecd072f.d
@@ -44,6 +44,27 @@ llvm::StringRef
SymbolVendorELF::GetPluginDescriptionStatic() {
"executables.";
}
+// If this is needed elsewhere, it can be exported/moved.
+static bool IsDwpSymbolFile(const lldb::ModuleSP &module_sp,
+const FileSpec &
@@ -4377,26 +4377,40 @@ const std::shared_ptr
&SymbolFileDWARF::GetDwpSymbolFile() {
FileSpecList search_paths = Target::GetDefaultDebugFileSearchPaths();
ModuleSpec module_spec;
module_spec.GetFileSpec() = m_objfile_sp->GetFileSpec();
+FileSpec dwp_filespec;
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/85861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/85885
Reverts llvm/llvm-project#85468 because @slackito reports this broke stepping
in one of their tests [1] and this patch was meant to be NFC.
[1]
https://github.com/llvm/llvm-project/commit/d5a277d309e92b1d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/85885
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
I reverted the change as this was meant to be RFC and ostensibly it's not. I'll
read through this to see if I can spot where this might behave differently.
https://github.com/llvm/llvm-project/pull/85468
___
lldb-commits mailing l
JDevlieghere wrote:
@slackito @dwblaikie I'm really puzzled, I've audited every change in this
patch and I can't figure out where things could be going wrong.
My first guess was that we're not updating the FileSpec. There's only 3 places
that explicitly modify the file in the line entry: 2 in
Author: Jonas Devlieghere
Date: 2024-03-19T20:49:56-07:00
New Revision: 92b2b49994eb804253db1deeb7e9f63904cd96d1
URL:
https://github.com/llvm/llvm-project/commit/92b2b49994eb804253db1deeb7e9f63904cd96d1
DIFF:
https://github.com/llvm/llvm-project/commit/92b2b49994eb804253db1deeb7e9f63904cd96d1.d
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/85892
Same change as #85468 but broken down into two commits as discussed in the
original PR.
>From 0914ecdf582831ec4da776e26ae5ebd2cf9f984f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 19 Mar 20
JDevlieghere wrote:
> I tested the two patches separately.
>
> With the first one ([Make LineEntry::file
> private](https://github.com/llvm/llvm-project/pull/85892/commits/0914ecdf582831ec4da776e26ae5ebd2cf9f984f))
> my problematic test case still passes.
>
> When I apply the second one ([Swa
@@ -216,6 +216,16 @@ class TypeSystem : public PluginInterface,
virtual uint32_t GetPointerByteSize() = 0;
+ // TODO: are we allowed to insert virtual functions in the middle of the
class
+ // interface and break ABI?
JDevlieghere wrote:
Answer: Yes, th
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/86002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/85892
>From b4580245ea380c9953e24d8816003ecfcd281155 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 20 Mar 2024 19:31:35 -0700
Subject: [PATCH 1/2] [lldb] Make LineEntry::file private for SupportFile
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/85892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere ready_for_review
https://github.com/llvm/llvm-project/pull/85892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/85892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/85892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-03-21T09:06:06-07:00
New Revision: 81bd799819f498a55e32599bce51fa98b2e73238
URL:
https://github.com/llvm/llvm-project/commit/81bd799819f498a55e32599bce51fa98b2e73238
DIFF:
https://github.com/llvm/llvm-project/commit/81bd799819f498a55e32599bce51fa98b2e73238.d
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/85693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/84854
>From 65d86e85ce27fa4b127bf80fceebf98215b19f64 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 6 Mar 2024 17:22:43 -0800
Subject: [PATCH] [lldb] Implement coalescing of disjoint progress events
JDevlieghere wrote:
Rebased. @clayborg please take a look at my comment about the timeout setting
and let me know if you consider this a blocker or have any other ideas.
https://github.com/llvm/llvm-project/pull/84854
___
lldb-commits mailing list
ll
JDevlieghere wrote:
> > What happens if you have colors disabled in your terminal? Does this do
> > nothing? Or does it start inserting ANSI escape codes in plain text?
>
> Yea good question, was about to try this out. It does whatever clang's
> `ast-dump` would do if colors aren't turned off
JDevlieghere wrote:
Either way, we should add a comment explaining that (and why) this works.
https://github.com/llvm/llvm-project/pull/86159
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
https://github.com/JDevlieghere approved this pull request.
Ship it!
https://github.com/llvm/llvm-project/pull/86359
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/84854
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-03-25T15:25:58-07:00
New Revision: 4dcb1db44f9dbfa09c220703a1b097f51d20a2a5
URL:
https://github.com/llvm/llvm-project/commit/4dcb1db44f9dbfa09c220703a1b097f51d20a2a5
DIFF:
https://github.com/llvm/llvm-project/commit/4dcb1db44f9dbfa09c220703a1b097f51d20a2a5.d
https://github.com/JDevlieghere approved this pull request.
Thanks for fixing this!
https://github.com/llvm/llvm-project/pull/86603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-03-26T09:13:51-07:00
New Revision: 348f9e73d7175f67750dc40b15cf1fc888bf60b5
URL:
https://github.com/llvm/llvm-project/commit/348f9e73d7175f67750dc40b15cf1fc888bf60b5
DIFF:
https://github.com/llvm/llvm-project/commit/348f9e73d7175f67750dc40b15cf1fc888bf60b5.d
Author: Jonas Devlieghere
Date: 2024-03-26T12:35:34-07:00
New Revision: 156c2907462bc5e97d13d3e7d334a32a291bc787
URL:
https://github.com/llvm/llvm-project/commit/156c2907462bc5e97d13d3e7d334a32a291bc787
DIFF:
https://github.com/llvm/llvm-project/commit/156c2907462bc5e97d13d3e7d334a32a291bc787.d
https://github.com/JDevlieghere approved this pull request.
Nice!
https://github.com/llvm/llvm-project/pull/86770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere ready_for_review
https://github.com/llvm/llvm-project/pull/86888
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/86888
Avoid deadlocks in the Alarm class by releasing the lock before invoking
callbacks. This deadlock manifested itself in the ProgressManager:
1. On the main thread, the ProgressManager acquires its lock in
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/86888
>From 793f6332ddf9059d999a7236770363e226ef8dd4 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 27 Mar 2024 16:05:21 -0700
Subject: [PATCH] [lldb] Avoid deadlock by unlocking before invoking callb
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/86888
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Works for us!
https://github.com/llvm/llvm-project/pull/86962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/86862
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Alright, so this happens when `listener` in `TypeCategoryMap` is the
`TypeCategory`. Please update the commit message and add a comment before the
call to `Changed` to say why we're doing it outside the scope of the lock. With
those changes this should be good to go.
http
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_EXPORTED_SYMBOLS
JDevlieghere wrote:
"tools" has a pretty specific meaning for LL
https://github.com/JDevlieghere requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/87540
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/87540
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -25,19 +25,25 @@ TypeCategoryMap::TypeCategoryMap(IFormatChangeListener *lst)
}
void TypeCategoryMap::Add(KeyType name, const TypeCategoryImplSP &entry) {
- std::lock_guard guard(m_map_mutex);
- m_map[name] = entry;
+ {
+std::lock_guard guard(m_map_mutex);
+m_map
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_EXPORTED_SYMBOLS
JDevlieghere wrote:
@delcypher I was referring to the tools in `
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/87815
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
A bunch of time has passed since the original RFC. It would be great, and help
with reviewing the PR, to have an overview of the currently proposed
architecture, the different pieces and how it all fits together. I left some
inline comments, but I'm n
@@ -243,6 +245,8 @@ class LLDB_API SBDebugger {
lldb::SBTarget GetDummyTarget();
+ void SendTelemetry(SBStructuredData *entry);
JDevlieghere wrote:
It seems odd to allow clients to send their own telemetry. I'd expect all
telemetry you'd want to collect
1001 - 1100 of 5184 matches
Mail list logo
