Author: jdevlieghere
Date: Wed Sep 26 03:09:44 2018
New Revision: 343087
URL: http://llvm.org/viewvc/llvm-project?rev=343087&view=rev
Log:
[unittest] Fix NativeProcessProtocolTest.cpp (NFC)
Cast std::min's second argument to size_t to prevent conflicting types
for parameter deduction.
Modified:
Author: jdevlieghere
Date: Wed Sep 26 23:59:15 2018
New Revision: 343180
URL: http://llvm.org/viewvc/llvm-project?rev=343180&view=rev
Log:
[target] Fix typo and give bool a default value
This addresses Stella's review feedback in D51859.
Modified:
lldb/trunk/source/Target/Target.cpp
Modifie
Author: jdevlieghere
Date: Mon Oct 1 06:20:15 2018
New Revision: 343470
URL: http://llvm.org/viewvc/llvm-project?rev=343470&view=rev
Log:
Escape newlines in default disassembly format.
We can safely escape newlines in format strings because they will be
ignored by the format entity parser.
Modi
Author: jdevlieghere
Date: Mon Oct 1 06:22:24 2018
New Revision: 343471
URL: http://llvm.org/viewvc/llvm-project?rev=343471&view=rev
Log:
[Interpreter] Escape backticks when dumping format entities.
Currently we reject our own default disassembly-format string because it
contains two backticks w
Author: jdevlieghere
Date: Mon Oct 1 10:20:57 2018
New Revision: 343502
URL: http://llvm.org/viewvc/llvm-project?rev=343502&view=rev
Log:
Fix tests affected by printing change.
I forgot to update some tests that were affected by the escaping of
backticks in the format string, landed in r343471.
Author: jdevlieghere
Date: Mon Oct 22 13:14:36 2018
New Revision: 344945
URL: http://llvm.org/viewvc/llvm-project?rev=344945&view=rev
Log:
[SymbolFile] Add the module lock where necessary and assert that we own it.
As discussed with Greg at the dev meeting, we need to ensure we have the
module lo
Author: jdevlieghere
Date: Mon Oct 22 17:18:27 2018
New Revision: 344979
URL: http://llvm.org/viewvc/llvm-project?rev=344979&view=rev
Log:
Fix typo in ASSERT_MODULE_LOCK macro definition
Modified:
lldb/trunk/include/lldb/Symbol/SymbolFile.h
Modified: lldb/trunk/include/lldb/Symbol/SymbolFile
Author: jdevlieghere
Date: Tue Oct 23 10:49:51 2018
New Revision: 345061
URL: http://llvm.org/viewvc/llvm-project?rev=345061&view=rev
Log:
Skip test with older versions of clang
This was failing for the bots that build with older clangs:
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-c
Author: jdevlieghere
Date: Wed Oct 24 15:04:20 2018
New Revision: 345207
URL: http://llvm.org/viewvc/llvm-project?rev=345207&view=rev
Log:
[Settings] Add -force flag to "settings set"
The -force option allows you to pass an empty value to settings set to
reset the value to its default. This means
Sent from my iPhone
> On Oct 24, 2018, at 7:05 PM, Zachary Turner wrote:
>
> It seems like FileSpec was moved out of Utility and into Host. I’m not a fan
> of this change, because it took a lot of effort to get it into Utility, which
> helped break a lot of bad dependencies. Can we invert th
Author: jdevlieghere
Date: Thu Oct 25 17:00:17 2018
New Revision: 345346
URL: http://llvm.org/viewvc/llvm-project?rev=345346&view=rev
Log:
Add functionality to export settings
For the reproducer feature I need to be able to export and import the
current LLDB configuration. To realize this I've ex
Author: jdevlieghere
Date: Thu Oct 25 17:39:27 2018
New Revision: 345350
URL: http://llvm.org/viewvc/llvm-project?rev=345350&view=rev
Log:
Remove test that checks auto-completion for settings set.
With the new `-f` option for `settings set`, `-` (dash) no longer
auto-complete to `-g`.
Modified:
Author: jdevlieghere
Date: Thu Oct 25 17:50:54 2018
New Revision: 345351
URL: http://llvm.org/viewvc/llvm-project?rev=345351&view=rev
Log:
Update test that checks auto-completion for settings set.
This reverts r345350 and updates the test rather than removing it. Now
we check that `--g` auto-comp
Author: jdevlieghere
Date: Fri Oct 26 16:01:25 2018
New Revision: 345435
URL: http://llvm.org/viewvc/llvm-project?rev=345435&view=rev
Log:
Fix and rename broken test for `settings write`.
I committed this test without updating the old `settings export` to
settings write. Since the functionality w
Author: jdevlieghere
Date: Wed Oct 31 14:49:27 2018
New Revision: 345783
URL: http://llvm.org/viewvc/llvm-project?rev=345783&view=rev
Log:
[FileSystem] Extend file system and have it use the VFS.
This patch extends the FileSystem class with a bunch of functions that
are currently implemented as m
Author: jdevlieghere
Date: Wed Oct 31 15:09:58 2018
New Revision: 345787
URL: http://llvm.org/viewvc/llvm-project?rev=345787&view=rev
Log:
[FileSystem] Remove EnumerateDirectory
The new implementation of EnumerateDirectory relies on `::no_push()`
being implemented for the VFS recursive directory
Author: jdevlieghere
Date: Wed Oct 31 17:26:09 2018
New Revision: 345799
URL: http://llvm.org/viewvc/llvm-project?rev=345799&view=rev
Log:
[FileSystem] Re-add EnumerateDirectory
Re-enable EnumerateDirectory now that no_push is available in llvm (r345793).
Modified:
lldb/trunk/include/lldb/Ho
Author: jdevlieghere
Date: Wed Oct 31 17:33:27 2018
New Revision: 345800
URL: http://llvm.org/viewvc/llvm-project?rev=345800&view=rev
Log:
[FileSystem] Move EnumerateDirectory from FileSpec to FileSystem.
This patch moves the EnumerateDirectory functionality and related enum
and typedef from File
Author: jdevlieghere
Date: Wed Oct 31 21:45:28 2018
New Revision: 345812
URL: http://llvm.org/viewvc/llvm-project?rev=345812&view=rev
Log:
[FileSystem] Remove GetByteSize() from FileSpec
This patch removes the GetByteSize method from FileSpec and updates its
uses with calls to the FileSystem.
Di
Author: jdevlieghere
Date: Thu Nov 1 08:47:33 2018
New Revision: 345843
URL: http://llvm.org/viewvc/llvm-project?rev=345843&view=rev
Log:
[FileSystem] Remove GetPermissions() and Readable() from FileSpec
This patch removes the GetPermissions and GetReadable methods from
FileSpec and updates its
Author: jdevlieghere
Date: Thu Nov 1 09:43:34 2018
New Revision: 345849
URL: http://llvm.org/viewvc/llvm-project?rev=345849&view=rev
Log:
[FileSystem] Improve assert and add Terminate in unit test.
Speculative fix for the Xcode bots where we were seeing the assertion
being triggered because we w
Author: jdevlieghere
Date: Thu Nov 1 10:09:22 2018
New Revision: 345853
URL: http://llvm.org/viewvc/llvm-project?rev=345853&view=rev
Log:
[FileSystem] Remove ResolveExecutableLocation() from FileSpec
This patch removes the ResolveExecutableLocation method from FileSpec
and updates its uses with
Author: jdevlieghere
Date: Thu Nov 1 10:09:25 2018
New Revision: 345854
URL: http://llvm.org/viewvc/llvm-project?rev=345854&view=rev
Log:
[FileSystem] Remove Exists() from FileSpec
This patch removes the Exists method from FileSpec and updates its uses
with calls to the FileSystem.
Differential
Author: jdevlieghere
Date: Thu Nov 1 10:35:31 2018
New Revision: 345857
URL: http://llvm.org/viewvc/llvm-project?rev=345857&view=rev
Log:
[FileSystem] Fix Exists call sites
There were some calls left to Exists() on non-darwin platforms (Windows,
Linux and FreeBSD) that weren't yet updated to use
Author: jdevlieghere
Date: Thu Nov 1 10:46:31 2018
New Revision: 345860
URL: http://llvm.org/viewvc/llvm-project?rev=345860&view=rev
Log:
[FileSystem] Fix typo in ProcessFreeBSD
Modified:
lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
Modified: lldb/trunk/source/Plugins/Proces
Author: jdevlieghere
Date: Thu Nov 1 14:18:25 2018
New Revision: 345891
URL: http://llvm.org/viewvc/llvm-project?rev=345891&view=rev
Log:
[FileSystem] Change FileSpec constructor signature.
Fix breakage due to the recent FileSpec change that extracts the path
resultion logic into FileSystem for
Author: jdevlieghere
Date: Thu Nov 1 14:26:58 2018
New Revision: 345895
URL: http://llvm.org/viewvc/llvm-project?rev=345895&view=rev
Log:
[FileSystem] Change FileSpec constructor signature (2/2)
Fix breakage due to the recent FileSpec change that extracts the path
resultion logic into FileSystem
Author: jdevlieghere
Date: Thu Nov 1 15:16:34 2018
New Revision: 345898
URL: http://llvm.org/viewvc/llvm-project?rev=345898&view=rev
Log:
[FileSystem] Update SetFile signature.
Modified:
lldb/trunk/source/Host/freebsd/HostInfoFreeBSD.cpp
Modified: lldb/trunk/source/Host/freebsd/HostInfoFree
Author: jdevlieghere
Date: Thu Nov 1 15:46:49 2018
New Revision: 345901
URL: http://llvm.org/viewvc/llvm-project?rev=345901&view=rev
Log:
[File] Remove static method to get permissions.
This patch removes the static accessor in File to get a file's
permissions. Permissions should be checked thro
Author: jdevlieghere
Date: Fri Nov 2 10:34:16 2018
New Revision: 346002
URL: http://llvm.org/viewvc/llvm-project?rev=346002&view=rev
Log:
[FileSystme] Move ::open abstraction into FileSystem.
This moves the abstraction around ::open into the FileSystem, as is
already the case for ::fopen.
Modif
Author: jdevlieghere
Date: Fri Nov 2 10:34:17 2018
New Revision: 346003
URL: http://llvm.org/viewvc/llvm-project?rev=346003&view=rev
Log:
[FileSystem] Remove `SetFileSystem` method.
This is no longer relevant with the new way we initialize the
FileSystem.
Modified:
lldb/trunk/include/lldb/H
Author: jdevlieghere
Date: Fri Nov 2 15:34:51 2018
New Revision: 346049
URL: http://llvm.org/viewvc/llvm-project?rev=346049&view=rev
Log:
[FileSystem] Open File instances through the FileSystem.
This patch modifies how we open File instances in LLDB. Rather than
passing a path or FileSpec to the
Author: jdevlieghere
Date: Mon Nov 5 11:34:03 2018
New Revision: 346159
URL: http://llvm.org/viewvc/llvm-project?rev=346159&view=rev
Log:
Remove OCaml debugger plugin
In January Davide sent an e-mail to the mailing list to suggest removing
unmaintained language plugins such as Go and Java. The p
Author: jdevlieghere
Date: Wed Nov 7 16:14:50 2018
New Revision: 346375
URL: http://llvm.org/viewvc/llvm-project?rev=346375&view=rev
Log:
[FileSystem] Add convenience method to check for directories.
Replace calls to LLVM's is_directory with calls to LLDB's FileSytem
class. For this I introduced
Author: jdevlieghere
Date: Thu Nov 8 15:21:00 2018
New Revision: 346449
URL: http://llvm.org/viewvc/llvm-project?rev=346449&view=rev
Log:
Update FileSpec constructor signature
Modified:
lldb/trunk/source/Host/android/HostInfoAndroid.cpp
Modified: lldb/trunk/source/Host/android/HostInfoAndro
Author: jdevlieghere
Date: Thu Nov 8 16:50:50 2018
New Revision: 346457
URL: http://llvm.org/viewvc/llvm-project?rev=346457&view=rev
Log:
[FileSystem] Make use of FS in TildeExpressionResolver
In order to call real_path from the TildeExpressionResolver we need
access to the FileSystem. Since the
Author: jdevlieghere
Date: Thu Nov 8 17:59:28 2018
New Revision: 346466
URL: http://llvm.org/viewvc/llvm-project?rev=346466&view=rev
Log:
Revert "[FileSystem] Make use of FS in TildeExpressionResolver"
The whole point of this change was making it possible to resolve paths
without depending on th
Author: jdevlieghere
Date: Sat Nov 10 14:44:06 2018
New Revision: 346598
URL: http://llvm.org/viewvc/llvm-project?rev=346598&view=rev
Log:
Extract construction of DataBufferLLVM into FileSystem
This moves construction of data buffers into the FileSystem class. Like
some of the previous refactorin
Author: jdevlieghere
Date: Sat Nov 10 14:54:44 2018
New Revision: 346599
URL: http://llvm.org/viewvc/llvm-project?rev=346599&view=rev
Log:
Add missing include
Modified:
lldb/trunk/source/Host/linux/Host.cpp
Modified: lldb/trunk/source/Host/linux/Host.cpp
URL:
http://llvm.org/viewvc/llvm-pro
Author: jdevlieghere
Date: Mon Nov 12 13:24:50 2018
New Revision: 346707
URL: http://llvm.org/viewvc/llvm-project?rev=346707&view=rev
Log:
Re-land "Extract construction of DataBufferLLVM into FileSystem"
This fixes some UB in isLocal detected by the sanitized bot.
Modified:
lldb/trunk/includ
Author: jdevlieghere
Date: Tue Nov 13 11:18:16 2018
New Revision: 346780
URL: http://llvm.org/viewvc/llvm-project?rev=346780&view=rev
Log:
Add GDB remote packet reproducer.
Added:
lldb/trunk/include/lldb/Utility/Reproducer.h
lldb/trunk/packages/Python/lldbsuite/test/functionalities/reprod
Author: jdevlieghere
Date: Wed Nov 14 17:05:40 2018
New Revision: 346919
URL: http://llvm.org/viewvc/llvm-project?rev=346919&view=rev
Log:
[reproducer] Post-commit cleanup
After committing the initial reproducer feature I noticed a few small
issues which warranted addressing here. It fixes incorr
Author: jdevlieghere
Date: Wed Nov 14 17:18:16 2018
New Revision: 346921
URL: http://llvm.org/viewvc/llvm-project?rev=346921&view=rev
Log:
Fix copy/paste mistake for r346919.
Modified:
lldb/trunk/source/Core/Debugger.cpp
Modified: lldb/trunk/source/Core/Debugger.cpp
URL:
http://llvm.org/vie
Author: jdevlieghere
Date: Wed Nov 14 17:18:15 2018
New Revision: 346920
URL: http://llvm.org/viewvc/llvm-project?rev=346920&view=rev
Log:
Add setting to require hardware breakpoints.
When debugging read-only memory we cannot use software breakpoint. We
already have support for hardware breakpoin
Author: jdevlieghere
Date: Mon Nov 19 17:18:49 2018
New Revision: 347283
URL: http://llvm.org/viewvc/llvm-project?rev=347283&view=rev
Log:
Skip TestTargetCreateDeps
Skip this test because Windows deals differently with shared libraries.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/fu
Author: jdevlieghere
Date: Mon Nov 26 15:40:52 2018
New Revision: 347615
URL: http://llvm.org/viewvc/llvm-project?rev=347615&view=rev
Log:
[FileSystem] Ignore nanoseconds when comparing oso_mod_time
After a recent change in LLVM the TimePoint encoding become more
precise, exceeding the precision
Author: jdevlieghere
Date: Tue Nov 27 07:25:58 2018
New Revision: 347660
URL: http://llvm.org/viewvc/llvm-project?rev=347660&view=rev
Log:
Move time cast to SymbolFileDWARFDebugMap
When trying to fix the bots we expected that the cast would be needed in
different places. Ultimately it turned out
hat was needed).
>
> The extra nanosecond_precision argument looks fairly odd, and diverges
> from how the llvm interfaces for modification times operate.
>
> On 27/11/2018 00:40, Jonas Devlieghere via lldb-commits wrote:
> > Author: jdevlieghere
> > Date: Mon Nov 26 15:40:52
Author: jdevlieghere
Date: Tue Nov 27 13:00:32 2018
New Revision: 347709
URL: http://llvm.org/viewvc/llvm-project?rev=347709&view=rev
Log:
[Driver] Use libOption with tablegen.
This patch modifies the lldb driver to use libOption for option parsing.
It allows us to decouple option parsing from op
Author: jdevlieghere
Date: Tue Nov 27 13:20:35 2018
New Revision: 347712
URL: http://llvm.org/viewvc/llvm-project?rev=347712&view=rev
Log:
[unittest] Fix the FileSystem test on Windows.
On Windows, when using the VFS without going through FileSpec, the
absolute path to `/foo` is `\\foo`. This upd
Author: jdevlieghere
Date: Tue Nov 27 14:11:02 2018
New Revision: 347716
URL: http://llvm.org/viewvc/llvm-project?rev=347716&view=rev
Log:
[Reproducers] Improve reproducer API and add unit tests.
When I landed the initial reproducer framework I knew there were some
things that needed improvement.
Author: jdevlieghere
Date: Tue Nov 27 17:18:10 2018
New Revision: 347725
URL: http://llvm.org/viewvc/llvm-project?rev=347725&view=rev
Log:
[unittest] Fix the FileSystem test on Windows. (Attempt #2)
This fixes the double escaping and compares FileSpecs instead of
strings.
Modified:
lldb/trun
Author: jdevlieghere
Date: Wed Nov 28 14:10:01 2018
New Revision: 347814
URL: http://llvm.org/viewvc/llvm-project?rev=347814&view=rev
Log:
Make standalone build find tabelgen
The standalone build couldn't find tablegen because we didn't include
it. This patch rectifies that.
Modified:
lldb/t
Author: jdevlieghere
Date: Wed Nov 28 14:39:17 2018
New Revision: 347817
URL: http://llvm.org/viewvc/llvm-project?rev=347817&view=rev
Log:
[driver] Some NFC cleanup
This patch includes some small things I noticed while refactoring the
driver but didn't want to include in that patch.
Modified:
Author: jdevlieghere
Date: Wed Nov 28 16:22:28 2018
New Revision: 347821
URL: http://llvm.org/viewvc/llvm-project?rev=347821&view=rev
Log:
[driver] Fix --core/-c and add test
Because the optarg variable was shadowed we didn't notice we weren't
extracting the value from the option. This patch fixe
Thanks, Zachary also pinged me on IRC. This was fixed in r347821.
> On Nov 28, 2018, at 4:09 PM, Leonard Mosescu via Phabricator
> wrote:
>
> lemo added a comment.
>
> I noticed a small problem, this change breaks "lldb -c ". The
> inline comment explains the root cause.
>
> Thanks
>
>
>
Author: jdevlieghere
Date: Thu Nov 29 16:09:04 2018
New Revision: 347936
URL: http://llvm.org/viewvc/llvm-project?rev=347936&view=rev
Log:
Fix the Xcode project
This fixes the driver with the Xcode project. We need to link the driver
against the correct LLVM libraries and make sure we're disablin
Author: jdevlieghere
Date: Thu Nov 29 18:44:16 2018
New Revision: 347952
URL: http://llvm.org/viewvc/llvm-project?rev=347952&view=rev
Log:
Fix the Xcode project (pt. 2)
Apparently LLVM's libSupport depends on libDemangle to print the stack
trace. I'm not sure if this is desired but for now we don
Author: jdevlieghere
Date: Fri Nov 30 09:31:20 2018
New Revision: 348010
URL: http://llvm.org/viewvc/llvm-project?rev=348010&view=rev
Log:
Skip TestRequireHWBreakpoints on Windows
The test assumes that HW breakpoints are not implemented by the debug
server. Windows doesn't use these and might act
Author: jdevlieghere
Date: Mon Dec 3 09:28:29 2018
New Revision: 348152
URL: http://llvm.org/viewvc/llvm-project?rev=348152&view=rev
Log:
[Reproducers] Change how reproducers are initialized.
This patch changes the way the reproducer is initialized. Rather than
making changes at run time we now
Author: jdevlieghere
Date: Mon Dec 3 12:36:21 2018
New Revision: 348186
URL: http://llvm.org/viewvc/llvm-project?rev=348186&view=rev
Log:
Skip TestDriverOptions on Windows
It's not clear to me why this is failing on Windows. Maybe it has
something to do with the path?
Modified:
lldb/trunk/l
/bogus?
>
> On Mon, Dec 3, 2018 at 12:39 PM Jonas Devlieghere via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> Author: jdevlieghere
>> Date: Mon Dec 3 12:36:21 2018
>> New Revision: 348186
>>
>> URL: http://llvm.org/viewvc/llvm-projec
Author: jdevlieghere
Date: Mon Dec 3 14:41:32 2018
New Revision: 348207
URL: http://llvm.org/viewvc/llvm-project?rev=348207&view=rev
Log:
[FileSystem] Migrate MonitoringProcessLauncher
Use the FileSystem helpers instead of using the file system directly.
Modified:
lldb/trunk/source/Host/com
Author: jdevlieghere
Date: Mon Dec 3 18:23:16 2018
New Revision: 348232
URL: http://llvm.org/viewvc/llvm-project?rev=348232&view=rev
Log:
[PlatformDarwin] Simplify logic and use FileSystem
Simplify code path by using the FileSystem.
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/Platfo
Author: jdevlieghere
Date: Tue Dec 4 09:58:21 2018
New Revision: 348287
URL: http://llvm.org/viewvc/llvm-project?rev=348287&view=rev
Log:
[FileSystem] Migrate CommandCompletions
Make use of the convenience helpers from FileSystem.
Differential revision: https://reviews.llvm.org/D55240
Modified
Author: jdevlieghere
Date: Tue Dec 4 10:16:49 2018
New Revision: 348289
URL: http://llvm.org/viewvc/llvm-project?rev=348289&view=rev
Log:
[Reproducers] Only creaate the bottom-most dir
As Pavel noted on the mailing list we should only create the bottom-most
directory if it doesn't exist. This sh
Yeah, that's a good idea. Made the change in r348289.
On Tue, Dec 4, 2018 at 2:55 AM Pavel Labath wrote:
> On 03/12/2018 21:55, Jonas Devlieghere via lldb-commits wrote:
> > That wouldn't work because we try to create the directory which would
> > succeeded in the
Author: jdevlieghere
Date: Mon Dec 10 10:17:39 2018
New Revision: 348779
URL: http://llvm.org/viewvc/llvm-project?rev=348779&view=rev
Log:
[Host] Use FileSystem wrapper
Fixes Host.mm to use the FileSystem class instead of making native calls
to check if a file exists.
Modified:
lldb/trunk/so
Author: jdevlieghere
Date: Tue Dec 11 12:19:53 2018
New Revision: 348894
URL: http://llvm.org/viewvc/llvm-project?rev=348894&view=rev
Log:
[Driver] Simplify OptionData. NFC
Hopefully this makes the option data easier to understand and maintain.
- Group the member variables.
- Do the initializa
Author: jdevlieghere
Date: Tue Dec 11 14:46:56 2018
New Revision: 348901
URL: http://llvm.org/viewvc/llvm-project?rev=348901&view=rev
Log:
Remove unused file
I removed the dotest-style reproducer test but forgot to delete the
source file. Thanks Jim for the heads up!
Removed:
lldb/trunk/pac
Author: jdevlieghere
Date: Wed Dec 12 16:15:17 2018
New Revision: 348996
URL: http://llvm.org/viewvc/llvm-project?rev=348996&view=rev
Log:
[NFC] Small code cleanups in utility.
Fix a few small annoyances in Utility I ran into.
Modified:
lldb/trunk/source/Utility/FileSpec.cpp
lldb/trunk/s
Author: jdevlieghere
Date: Mon Dec 17 10:11:48 2018
New Revision: 349371
URL: http://llvm.org/viewvc/llvm-project?rev=349371&view=rev
Log:
[Driver] Fix --repl argument.
The --repl option was incorrectly defined as "Separate" (option and
value separated by a space). This resulted in the option not
Author: jdevlieghere
Date: Mon Dec 17 13:40:37 2018
New Revision: 349401
URL: http://llvm.org/viewvc/llvm-project?rev=349401&view=rev
Log:
[lit] Detect unexpected passes in lldbtest.
This patch will have lit report unexpected passes when dotest reports at
least one XPASS and no failures.
Modifie
oblem with
lit where this information was not at all available.
I created a patch that changes the dotest behavior to match what lit does.
https://reviews.llvm.org/D55835
On Tue, Dec 18, 2018 at 7:54 AM Pavel Labath wrote:
> On 17/12/2018 22:40, Jonas Devlieghere via lldb-commits wrot
Author: jdevlieghere
Date: Tue Dec 18 12:59:23 2018
New Revision: 349539
URL: http://llvm.org/viewvc/llvm-project?rev=349539&view=rev
Log:
[cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS
As discussed on IRC this morning, when building an in-tree clang for
testing we ha
Author: jdevlieghere
Date: Tue Dec 18 13:40:05 2018
New Revision: 349546
URL: http://llvm.org/viewvc/llvm-project?rev=349546&view=rev
Log:
[CMake] Don't require libcxxabi on darwin
Just libcxx should suffice.
Modified:
lldb/trunk/CMakeLists.txt
Modified: lldb/trunk/CMakeLists.txt
URL:
http
Author: jdevlieghere
Date: Wed Dec 19 09:10:21 2018
New Revision: 349642
URL: http://llvm.org/viewvc/llvm-project?rev=349642&view=rev
Log:
[lit] Make TestConvenienceVariables a cpp file
The build.py script always runs the compiler in C++ mode, regardless of
the file extension. This results in man
Author: jdevlieghere
Date: Thu Dec 20 12:44:23 2018
New Revision: 349818
URL: http://llvm.org/viewvc/llvm-project?rev=349818&view=rev
Log:
[dotest] Consider unexpected passes as failures.
Unexpected successes should be considered failures because they can hide
regressions when not addressed. When
Author: jdevlieghere
Date: Thu Dec 20 13:02:55 2018
New Revision: 349821
URL: http://llvm.org/viewvc/llvm-project?rev=349821&view=rev
Log:
[API] Remove redundants get() from smart pointers. NFC
Removes redundant calls to ::get() from smart pointers in the source/API
directory..
Modified:
lld
Author: jdevlieghere
Date: Thu Dec 20 15:45:26 2018
New Revision: 349858
URL: http://llvm.org/viewvc/llvm-project?rev=349858&view=rev
Log:
Fix stack-buffer-overflow in lldb_private::Host::FindProcesses
Found by the address sanitizer on GreenDragon:
http://green.lab.llvm.org/green/view/LLDB/job/ll
Author: jdevlieghere
Date: Thu Dec 20 17:22:58 2018
New Revision: 349869
URL: http://llvm.org/viewvc/llvm-project?rev=349869&view=rev
Log:
Fix stack-buffer-overflow in lldb_private::Host::FindProcesses (2/2)
This fixes the second call at line 640 that I missed in r349858.
Modified:
lldb/trun
Author: jdevlieghere
Date: Fri Dec 21 14:16:10 2018
New Revision: 349967
URL: http://llvm.org/viewvc/llvm-project?rev=349967&view=rev
Log:
[ExpressionParser] Reserve size before copying over args
We already know the final size here so we might as well reserve it so we
don't have to re-allocate du
Author: jdevlieghere
Date: Fri Dec 21 14:46:10 2018
New Revision: 349972
URL: http://llvm.org/viewvc/llvm-project?rev=349972&view=rev
Log:
[NFC] Replace `compare` with (in)equality operator where applicable.
Using compare is verbose, bug prone and potentially inefficient (because
of early termina
Author: jdevlieghere
Date: Sat Dec 29 22:10:03 2018
New Revision: 350160
URL: http://llvm.org/viewvc/llvm-project?rev=350160&view=rev
Log:
[test] Remove flakiness decorator from TestObjCDynamicSBType
The quoted bug report (llvm.org/PR20270) was closed in 2014.
Modified:
lldb/trunk/packages/
On Sun, Dec 30, 2018 at 05:33 Davide Italiano wrote:
> Nice, thanks!
> There is a typo in the commit message, I assume?
>
Correct, I made a typo in the PR and then mindlessly copied the name of the
test.
>
>
> On Sun, Dec 30, 2018 at 7:13 AM Jonas Devlieghere via lld
Author: jdevlieghere
Date: Sun Dec 30 09:56:30 2018
New Revision: 350166
URL: http://llvm.org/viewvc/llvm-project?rev=350166&view=rev
Log:
[CommandInterpreter] Simplify PreprocessCommand. (NFCI)
Simplify some code in PreprocessCommand. This change improves
consistency, reduces the indentation and
Author: jdevlieghere
Date: Wed Jan 2 14:38:16 2019
New Revision: 350267
URL: http://llvm.org/viewvc/llvm-project?rev=350267&view=rev
Log:
[Driver] Remove unused imports
Removes some unneeded includes from the driver.
Modified:
lldb/trunk/tools/driver/Driver.cpp
Modified: lldb/trunk/tools/d
Author: jdevlieghere
Date: Fri Jan 4 16:01:04 2019
New Revision: 350446
URL: http://llvm.org/viewvc/llvm-project?rev=350446&view=rev
Log:
[Driver] Some more cleanup. NFC
Modified:
lldb/trunk/tools/driver/Driver.cpp
lldb/trunk/tools/driver/Driver.h
Modified: lldb/trunk/tools/driver/Drive
Author: jdevlieghere
Date: Mon Jan 7 17:35:00 2019
New Revision: 350599
URL: http://llvm.org/viewvc/llvm-project?rev=350599&view=rev
Log:
[SymbolContext] Remove dead code
Removes two methods from SymbolContextList that aren't referenced.
Modified:
lldb/trunk/include/lldb/Symbol/SymbolContex
Author: jdevlieghere
Date: Tue Jan 8 12:58:54 2019
New Revision: 350652
URL: http://llvm.org/viewvc/llvm-project?rev=350652&view=rev
Log:
[PdbAstBuilder] Remove unused functions
PdbAstBuilder.cpp:273:20: warning: unused function 'GetParentUniqueName'
[-Wunused-function]
PdbAstBuilder.cpp:267:13
Author: jdevlieghere
Date: Tue Jan 8 14:07:42 2019
New Revision: 350659
URL: http://llvm.org/viewvc/llvm-project?rev=350659&view=rev
Log:
[BreakpointList] Simplify/modernize BreakpointList (NFC)
I was looking at the code in BreakpointList.cpp and found it deserved a
quick cleanup.
- Use std:
Author: jdevlieghere
Date: Tue Jan 8 15:25:06 2019
New Revision: 350679
URL: http://llvm.org/viewvc/llvm-project?rev=350679&view=rev
Log:
Change std::sort to llvm::sort to detect non-determinism.
LLVM added wrappers to std::sort (r327219) that randomly shuffle the
container before sorting. The g
Author: jdevlieghere
Date: Tue Jan 8 16:31:30 2019
New Revision: 350682
URL: http://llvm.org/viewvc/llvm-project?rev=350682&view=rev
Log:
[CMakeLists] Sort tools/CMakeLists.txt
Modified:
lldb/trunk/tools/CMakeLists.txt
Modified: lldb/trunk/tools/CMakeLists.txt
URL:
http://llvm.org/viewvc/l
Author: jdevlieghere
Date: Fri May 18 02:14:45 2018
New Revision: 332700
URL: http://llvm.org/viewvc/llvm-project?rev=332700&view=rev
Log:
Fix _NSCFBoolean data formatter.
In r265181 the test for the NSCFBoolean data formatter was removed.
Later, in r279353 and r279446 a new implementation was pr
Author: jdevlieghere
Date: Tue May 29 05:30:27 2018
New Revision: 333412
URL: http://llvm.org/viewvc/llvm-project?rev=333412&view=rev
Log:
[test] Fix --framework argument passed to dotest.
The framework argument was broken when I removed the generator
expressions upstream. I replaced $ with
${LL
Author: jdevlieghere
Date: Tue May 29 09:49:07 2018
New Revision: 333432
URL: http://llvm.org/viewvc/llvm-project?rev=333432&view=rev
Log:
[lit] Add support for passing arguments to dotest.py via lit.
The lldb test suite is highly configurable. While part of this
configuration takes place at conf
Author: jdevlieghere
Date: Wed May 30 06:03:16 2018
New Revision: 333540
URL: http://llvm.org/viewvc/llvm-project?rev=333540&view=rev
Log:
[FileSpec] Re-implmenet removeLastPathComponent
When reading DBGSourcePathRemapping from a dSYM, we remove the last two
path components to make the source loo
Author: jdevlieghere
Date: Thu May 31 09:28:29 2018
New Revision: 333666
URL: http://llvm.org/viewvc/llvm-project?rev=333666&view=rev
Log:
Remove infinite recursion due to FileSpec change.
Fixes infinite recursion due to change in how FileSpec deals with
removing the last path component.
Fixes t
Author: jdevlieghere
Date: Mon Jun 4 17:32:41 2018
New Revision: 333974
URL: http://llvm.org/viewvc/llvm-project?rev=333974&view=rev
Log:
Fix Expression unittests on Darwin
Fixes the Expression unittests on Darwin after r333933 was landed.
Modified:
lldb/trunk/unittests/Expression/CMakeList
Author: jdevlieghere
Date: Thu Jun 7 09:10:42 2018
New Revision: 334205
URL: http://llvm.org/viewvc/llvm-project?rev=334205&view=rev
Log:
[Platform] Accept arbitrary kext variants
When loading kexts in PlatformDarwinKernel, we use the BundleID as the
filename to to create shared modules. In GetS
1 - 100 of 4308 matches
Mail list logo
