https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/92137
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
I just checked and I'm not seeing the hover's in the same format as they were
when I made the pull request. The expression context should still have the
expanded forms though for example:
https://github.com/llvm/llvm-project/assets/22535/28db4adc-d488-44ff-8d99-78966e0e0e05";>
I
ashgti wrote:
Sounds good to me
https://github.com/llvm/llvm-project/pull/77026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/92726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/105456
Previously, when output like `"hello\nworld\n"` was produced by lldb (or the
process) the message would be sent as a single Output event. By being a single
event this causes VS Code to treat this as a single mes
@@ -311,10 +309,22 @@ void DAP::SendOutput(OutputType o, const llvm::StringRef
output) {
category = "telemetry";
break;
}
- body.try_emplace("category", category);
- EmplaceSafeString(body, "output", output.str());
- event.try_emplace("body", std::move(body));
-
@@ -3091,17 +3093,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105456
>From 9246649c24991127b8f54ae1f21121386cef7254 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 20 Aug 2024 16:33:14 -0700
Subject: [PATCH 1/2] When sending a DAP Output Event break each message into
sepa
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105456
>From 9246649c24991127b8f54ae1f21121386cef7254 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 20 Aug 2024 16:33:14 -0700
Subject: [PATCH 1/3] When sending a DAP Output Event break each message into
sepa
@@ -399,7 +399,7 @@ void SendProcessEvent(LaunchMethod launch_method) {
// Grab any STDOUT and STDERR from the process and send it up to VS Code
// via an "output" event to the "stdout" and "stderr" categories.
void SendStdOutStdErr(lldb::SBProcess &process) {
- char buffer[10
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105456
>From 9246649c24991127b8f54ae1f21121386cef7254 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 20 Aug 2024 16:33:14 -0700
Subject: [PATCH 1/3] When sending a DAP Output Event break each message into
sepa
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105456
>From 9246649c24991127b8f54ae1f21121386cef7254 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 20 Aug 2024 16:33:14 -0700
Subject: [PATCH 1/4] When sending a DAP Output Event break each message into
sepa
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105456
>From 9246649c24991127b8f54ae1f21121386cef7254 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 20 Aug 2024 16:33:14 -0700
Subject: [PATCH 1/5] When sending a DAP Output Event break each message into
sepa
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/105456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/105604
This should fix https://lab.llvm.org/buildbot/#/builders/141/builds/1747
>From 54dcc78eace39c197f1fb762880746b569980955 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 21 Aug 2024 18:22:17 -0700
Subject:
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/105604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105604
>From 54dcc78eace39c197f1fb762880746b569980955 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 21 Aug 2024 18:22:17 -0700
Subject: [PATCH] Skip the lldb-dap output test on windows, it seems all the
lldb-
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/105604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3111,17 +3115,20 @@ void request_stackTrace(const llvm::json::Object
&request) {
// This will always return an invalid thread when
// libBacktraceRecording.dylib is not loaded or if there is no extended
// backtrace.
-lldb::SBThread queue_backtrace_thread =
ashgti wrote:
I'll try to work that into my refactor of the call for
`thread.GetCurrentExceptionBacktrace()`
https://github.com/llvm/llvm-project/pull/104874
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/105905
Refactoring `stackTrace` to perform frame look ups in a more on-demand fashion
to improve overall performance.
Additionally adding additional information to the `exceptionInfo` request to
report exception stack
ashgti wrote:
This was based on the comments in
https://github.com/llvm/llvm-project/pull/104874
LMKWYT
https://github.com/llvm/llvm-project/pull/105905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From 7641ce09208883f205c9a9deb19bae9d01f8cd70 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/2] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From 7641ce09208883f205c9a9deb19bae9d01f8cd70 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/3] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From 7641ce09208883f205c9a9deb19bae9d01f8cd70 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/4] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From ebcf4842c7d6c5ac0da4976c9cffb68bc3b22807 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/4] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
ashgti wrote:
@jeffreytan81 I moved the expensive call into the `exceptionInfo` request, this
is only going to be triggered if a thread has the stop event = 'exception', so
it shouldn't be triggered while stepping. This does remove the option you added
in the prior commit, since I think this i
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From ebcf4842c7d6c5ac0da4976c9cffb68bc3b22807 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/5] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
@@ -3106,80 +3228,105 @@ void request_stackTrace(const llvm::json::Object
&request) {
llvm::json::Array stackFrames;
llvm::json::Object body;
+ // Threads stacks may contain runtime specific extended backtraces, when
+ // constructing a stack trace first report the full
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From ebcf4842c7d6c5ac0da4976c9cffb68bc3b22807 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/6] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From ebcf4842c7d6c5ac0da4976c9cffb68bc3b22807 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/7] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
ashgti wrote:
Reverted the removal of `enableDisplayExtendedBacktrace` and added
`enableDisplayExtendedBacktrace` to the documentation and package.json
description of the lldb-dap debugger.
https://github.com/llvm/llvm-project/pull/105905
___
lldb-co
@@ -1364,6 +1364,13 @@ void request_evaluate(const llvm::json::Object &request)
{
std::string expression = GetString(arguments, "expression").str();
llvm::StringRef context = GetString(arguments, "context");
+ // Remember the last non-empty expression from the user, and
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From ebcf4842c7d6c5ac0da4976c9cffb68bc3b22807 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/8] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
@@ -3106,80 +3235,109 @@ void request_stackTrace(const llvm::json::Object
&request) {
llvm::json::Array stackFrames;
llvm::json::Object body;
+ // Threads stacks may contain runtime specific extended backtraces, when
+ // constructing a stack trace first report the full
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From 6612efb0e51d700eeb545a421a34f7a57aafc509 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/8] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From 6612efb0e51d700eeb545a421a34f7a57aafc509 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/9] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/105905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/77026
When generating a `display_value` for a variable the current approach calls
`SBValue::GetValue()` and `SBValue::GetSummary()` to generate a `display_value`
for the `SBValue`. However, there are cases where both o
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/77026
>From 7656af47e058aa7101504cb31aaa067178110351 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 4 Jan 2024 15:42:35 -0800
Subject: [PATCH 1/2] [lldb-dap] Updating VariableDescription to use
GetDescription(
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/77026
>From 7656af47e058aa7101504cb31aaa067178110351 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 4 Jan 2024 15:42:35 -0800
Subject: [PATCH 1/2] [lldb-dap] Updating VariableDescription to use
GetDescription(
ashgti wrote:
> Looks fine to me. Can we add a test?
Updated the existing tests to check the adjusted format.
One issue I did notice with tests is that the response to an expression will
include a response are automatically persisted by `SBValue::GetDescription()`,
so you will see the value n
ashgti wrote:
cc @walter-erquinigo since this looks like it has similar overlap to the auto
generated summeries.
https://github.com/llvm/llvm-project/pull/77026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
@@ -1,7 +1,7 @@
{
"name": "lldb-dap",
- "displayName": "LLDB VSCode",
- "version": "0.1.0",
+ "displayName": "LLDB DAP",
ashgti wrote:
This file has a mix of tabs and spaces of various sizes, should this be
standardized one way or the
@@ -0,0 +1,57 @@
+import * as vscode from "vscode";
+import { LLDBDapOptions } from "./types";
+import { DisposableContext } from "./disposable-context";
+import { LLDBDapDescriptorFactory } from "./debug-adapter-factory";
+import * as fs from 'fs/promises'
ashgti
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/75515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/75515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,57 @@
+import * as vscode from "vscode";
+import { LLDBDapOptions } from "./types";
+import { DisposableContext } from "./disposable-context";
+import { LLDBDapDescriptorFactory } from "./debug-adapter-factory";
+import * as fs from 'fs/promises'
+
+/**
+ * This creates
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/77026
>From 7656af47e058aa7101504cb31aaa067178110351 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 4 Jan 2024 15:42:35 -0800
Subject: [PATCH 1/3] [lldb-dap] Updating VariableDescription to use
GetDescription(
@@ -242,19 +254,57 @@ def do_test_scopes_variables_setVariable_evaluate(
},
"pt": {
"equals": {"type": "PointType"},
-"startswith": {
-"result": "{x:11, y:22}"
+"equals": {
+
@@ -135,6 +135,18 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+static std::string GetDescriptionTrimmed(lldb::SBValue &value) {
+ lldb::SBStream stream;
+ value.GetDescription(stream);
ashgti wrote:
Updated `bool SBValue::GetD
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/77026
>From 7656af47e058aa7101504cb31aaa067178110351 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 4 Jan 2024 15:42:35 -0800
Subject: [PATCH 1/4] [lldb-dap] Updating VariableDescription to use
GetDescription(
@@ -135,6 +135,21 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+static std::string GetDescriptionTrimmed(lldb::SBValue &value) {
ashgti wrote:
Done.
https://github.com/llvm/llvm-project/pull/77026
___
@@ -135,6 +135,21 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+static std::string GetDescriptionTrimmed(lldb::SBValue &value) {
+ lldb::SBStream stream;
+ if (!value.GetDescription(stream)) {
+return "";
+ }
ashgti wrote:
ashgti wrote:
> Is there a way we can tell that the request is from the console and only
> enable this feature if we are going to dump it to the debug console?
Yea, the DAP has a context we can use to limit this
https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Evaluate
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/77026
>From 7656af47e058aa7101504cb31aaa067178110351 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 4 Jan 2024 15:42:35 -0800
Subject: [PATCH 1/5] [lldb-dap] Updating VariableDescription to use
GetDescription(
ashgti wrote:
Sorry about the spam, I synced my branch and it looks like the pull request
added reviewers from all the patches.
https://github.com/llvm/llvm-project/pull/77026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/77026
>From 7656af47e058aa7101504cb31aaa067178110351 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 4 Jan 2024 15:42:35 -0800
Subject: [PATCH 1/6] [lldb-dap] Updating VariableDescription to use
GetDescription(
ashgti wrote:
> That will work nicely.
Done, the latest revision will only use the description for hovers and repl
contexts.
https://github.com/llvm/llvm-project/pull/77026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
@@ -1210,15 +1210,16 @@ bool SBValue::GetDescription(SBStream &description) {
ValueLocker locker;
lldb::ValueObjectSP value_sp(GetSP(locker));
- if (value_sp) {
-DumpValueObjectOptions options;
-options.SetUseDynamicType(m_opaque_sp->GetUseDynamic());
-options
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/82051
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/77026
>From 52d6dc8f26477b8fba839194ac1485274312a865 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 4 Jan 2024 15:42:35 -0800
Subject: [PATCH] [lldb-dap] Updating VariableDescription to use
GetDescription() fo
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/77026
>From 56d1520f2ce7eb9a9f0c5b5c199deefab15dadfa Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 4 Jan 2024 15:42:35 -0800
Subject: [PATCH] [lldb-dap] Updating VariableDescription to use
GetDescription() fo
@@ -173,21 +173,21 @@ TryCreateAutoSummaryForContainer(lldb::SBValue &v) {
lldb::SBValue child = v.GetChildAtIndex(i);
if (llvm::StringRef name = child.GetName(); !name.empty()) {
- llvm::StringRef value;
+ llvm::StringRef desc;
if (llvm::StringRef sum
@@ -405,6 +405,9 @@ struct VariableDescription {
/// Create a JSON object that represents these extensions to the DAP variable
/// response.
llvm::json::Object GetVariableExtensionsJSON();
+
+ /// Returns a description of the value appropraite for the specified context.
@@ -1210,15 +1210,16 @@ bool SBValue::GetDescription(SBStream &description) {
ValueLocker locker;
lldb::ValueObjectSP value_sp(GetSP(locker));
- if (value_sp) {
-DumpValueObjectOptions options;
-options.SetUseDynamicType(m_opaque_sp->GetUseDynamic());
-options
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/78005
The previous logic for determining if an expression was a command or variable
expression in the repl would incorrectly identify the context in many common
cases where a local variable name partially overlaps with
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/78005
>From 09f1556fd0615f42fe9dd49bf8c2355517f6e0da Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 12 Jan 2024 16:39:47 -0800
Subject: [PATCH] [lldb-dap] Adjusting how repl-mode auto determines commands
vs va
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/78005
>From f01c82be09e28c1eead4d80f4ceea67dee0318d6 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 12 Jan 2024 16:39:47 -0800
Subject: [PATCH] [lldb-dap] Adjusting how repl-mode auto determines commands
vs va
@@ -380,12 +380,19 @@ llvm::json::Value DAP::CreateTopLevelScopes() {
return llvm::json::Value(std::move(scopes));
}
-ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame,
- std::string &text) {
+static std::string
@@ -380,12 +380,19 @@ llvm::json::Value DAP::CreateTopLevelScopes() {
return llvm::json::Value(std::move(scopes));
}
-ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame,
- std::string &text) {
+static std::string
@@ -395,43 +402,56 @@ ExpressionContext
DAP::DetectExpressionContext(lldb::SBFrame &frame,
case ReplMode::Command:
return ExpressionContext::Command;
case ReplMode::Auto:
-// If the frame is invalid then there is no variables to complete, assume
-// this is an
@@ -395,43 +402,56 @@ ExpressionContext
DAP::DetectExpressionContext(lldb::SBFrame &frame,
case ReplMode::Command:
return ExpressionContext::Command;
case ReplMode::Auto:
-// If the frame is invalid then there is no variables to complete, assume
-// this is an
@@ -395,43 +402,56 @@ ExpressionContext
DAP::DetectExpressionContext(lldb::SBFrame &frame,
case ReplMode::Command:
return ExpressionContext::Command;
case ReplMode::Auto:
-// If the frame is invalid then there is no variables to complete, assume
-// this is an
@@ -395,43 +402,56 @@ ExpressionContext
DAP::DetectExpressionContext(lldb::SBFrame &frame,
case ReplMode::Command:
return ExpressionContext::Command;
case ReplMode::Auto:
-// If the frame is invalid then there is no variables to complete, assume
-// this is an
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/78005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/78005
>From c3a4cd38b41e332342aa7042d3a9c2f75416bfc3 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 12 Jan 2024 16:39:47 -0800
Subject: [PATCH] [lldb-dap] Adjusting how repl-mode auto determines commands
vs va
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/78343
The logging callback prevents `lldb> log enable -f lldb api` from
writing to a file and instead redirects all logging to the callback.
Fixes [issues/78334](https://github.com/llvm/llvm-project/issues/78334).
>F
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/78005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/82051
This fixes an issue where the error is lost if a command while executing
`launchCommands` when launching the debugger.
This should fix #82048
>From 5e3787a61c92f002746f2437e2fc8509d787a0ce Mon Sep 17 00:00:00 20
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/82051
>From 300d2959e510f41607ce2487264a98814d0a1700 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 16 Feb 2024 14:11:10 -0800
Subject: [PATCH] [lldb-dap] Do not write over the existing error if
launchCommands
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/82051
>From f76dbe10e30c84aadaf33c597fe81bc0a285c995 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 16 Feb 2024 14:11:10 -0800
Subject: [PATCH] [lldb-dap] Do not write over the existing error if
launchCommands
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/82051
>From 465abea7e445271681f5107ccbd306f63ccd0956 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 16 Feb 2024 14:11:10 -0800
Subject: [PATCH] [lldb-dap] Do not write over the existing error if
launchCommands
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/82051
>From 61224ee2642e7fa2723e48e4a32c90f5ec04759a Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 16 Feb 2024 14:11:10 -0800
Subject: [PATCH] [lldb-dap] Do not write over the existing error if
launchCommands
ashgti wrote:
> Needs a test and this will be good to go.
Done, added tests
https://github.com/llvm/llvm-project/pull/82051
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/72292
Previously the type of the breakpoint id in the Stopped event was a uint64_t,
however thats the wrong type for a breakpoint id, which can cause encoding
issues when internal breakpoints are hit.
>From 5077857569
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/72292
>From ed4b044027e4ccc02bd19af394a076892baeea95 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 14 Nov 2023 10:02:41 -0800
Subject: [PATCH] [lldb-dap] Fixing a type encoding issue with dap Stopped
events.
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id = thread.GetStopReasonD
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id = thread.GetStopReasonD
@@ -953,9 +953,9 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread,
} else {
body.try_emplace("reason", "breakpoint");
char desc_str[64];
- uint64_t bp_id = thread.GetStopReasonDataAtIndex(0);
- uint64_t bp_loc_id = thread.GetStopReasonD
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/112384
Custom DAP events can be detected using
https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent.
This API allows an lldb python script to send custom events to the DAP
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/112384
>From be42193c499f28f8b078f1b443ad09d94e7ba2c5 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 15 Oct 2024 09:13:49 -0700
Subject: [PATCH] [lldb-dap] Creating an API for sending custom dap events from
ll
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/112396
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/112384
>From 61f5407be7fed86428d46e0ea0a6d418a8e25bf7 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 15 Oct 2024 09:13:49 -0700
Subject: [PATCH] [lldb-dap] Creating an API for sending custom dap events from
ll
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/112384
>From 5ec5d350f78d284634ffbc7800d7f34a5017707a Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 15 Oct 2024 09:13:49 -0700
Subject: [PATCH] [lldb-dap] Creating an API for sending custom dap events from
ll
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/112396
Adjusting the name from `lldb-dap startDebugging` to `lldb-dap start-debugging`
to improve consistency with other names for commands in lldb/lldb-dap.
>From 2aa7abfbdeaed07a5c46068ea2533c2d20613c5f Mon Sep 17 00
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/112384
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -962,6 +962,68 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger
debugger,
return true;
}
+// Sends a DAP event with an optional body.
+//
+// See
+//
https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent
+bool SendEv
@@ -962,6 +962,68 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger
debugger,
return true;
}
+// Sends a DAP event with an optional body.
+//
+// See
+//
https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent
+bool SendEv
1 - 100 of 540 matches
Mail list logo
