Re: [Lldb-commits] [PATCH] D13335: [LLDB][MIPS] Skip invalid size watchpoint testcase for MIPS

2015-10-05 Thread Jaydeep Patil via lldb-commits
jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good Repository: rL LLVM http://reviews.llvm.org/D13335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

Re: [Lldb-commits] [Diffusion] rL247773: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

2015-10-07 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. Hi Dawn, Could you please provide more details on this? Thanks, Jaydeep Users: jaydeep (Author) dawn (Auditor) http://reviews.llvm.org/rL247773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

Re: [Lldb-commits] [Diffusion] rL247968: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

2015-10-07 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. Hi Dawn, Could you please provide more details on this? Thanks, Jaydeep Users: jaydeep (Author) dawn (Auditor) http://reviews.llvm.org/rL247968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

Re: [Lldb-commits] [Diffusion] rL247773: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

2015-10-07 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. Hi Dwan, Could you please try http://reviews.llvm.org/rL247968 and let me know if the issue persist? Thanks, Jaydeep Users: jaydeep (Author) dawn (Auditor) http://reviews.llvm.org/rL247773 ___ lldb-commits mailing l

Re: [Lldb-commits] [PATCH] D14860: [LLDB][MIPS] Getting 0 index for h/w watchpoint is not necessarily an error

2015-11-23 Thread Jaydeep Patil via lldb-commits
jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D14860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

[Lldb-commits] [PATCH] D14978: [MIPS] Change ARCHFLAG for MIPS

2015-11-25 Thread Jaydeep Patil via lldb-commits
jaydeep created this revision. jaydeep added a reviewer: clayborg. jaydeep added subscribers: lldb-commits, bhushan, mohit.bhakkad, sagar, nitesh.jain. jaydeep set the repository for this revision to rL LLVM. For MIPS, ARCH is specified without 'm'. Repository: rL LLVM http://reviews.llvm.org

[Lldb-commits] [lldb] r254376 - [LLDB][MIPS] Change ARCHFLAG for MIPS

2015-11-30 Thread Jaydeep Patil via lldb-commits
Author: jaydeep Date: Mon Nov 30 23:24:17 2015 New Revision: 254376 URL: http://llvm.org/viewvc/llvm-project?rev=254376&view=rev Log: [LLDB][MIPS] Change ARCHFLAG for MIPS SUMMARY: For MIPS, ARCH is specified without m. Reviewers: clayborg Subscribers: nitesh.jain, mohit.bhakkad,

Re: [Lldb-commits] [PATCH] D14978: [MIPS] Change ARCHFLAG for MIPS

2015-11-30 Thread Jaydeep Patil via lldb-commits
jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL254376 Repository: rL LLVM http://reviews.llvm.org/D14978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] r254590 - [LLDB][MIPS] Using enum instead of a constant to fetch PC and CAUSE registers.

2015-12-02 Thread Jaydeep Patil via lldb-commits
Author: jaydeep Date: Thu Dec 3 00:41:24 2015 New Revision: 254590 URL: http://llvm.org/viewvc/llvm-project?rev=254590&view=rev Log: [LLDB][MIPS] Using enum instead of a constant to fetch PC and CAUSE registers. SUMMARY: Using enum instead of a constant to fetch PC and CAUSE registers. M

[Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

2015-12-03 Thread Jaydeep Patil via lldb-commits
jaydeep created this revision. jaydeep added a reviewer: clayborg. jaydeep added subscribers: bhushan, sagar, mohit.bhakkad, nitesh.jain, lldb-commits. jaydeep set the repository for this revision to rL LLVM. Single stepping requires setting software breakpoint at address 0x0. This results in in

Re: [Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

2015-12-03 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 41840. jaydeep added a comment. Marked as XFAIL Repository: rL LLVM http://reviews.llvm.org/D15182 Files: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py Index: packages/Python/lldbsuite/test/functional

[Lldb-commits] [lldb] r254710 - [LLDB][MIPS] XFAIL TestCrashDuringStep.py for MIPS

2015-12-04 Thread Jaydeep Patil via lldb-commits
Author: jaydeep Date: Fri Dec 4 03:56:36 2015 New Revision: 254710 URL: http://llvm.org/viewvc/llvm-project?rev=254710&view=rev Log: [LLDB][MIPS] XFAIL TestCrashDuringStep.py for MIPS SUMMARY: Marked TestCrashDuringStep.py as XFAIL for MIPS. The test generates IO error due to breakpoint

Re: [Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

2015-12-04 Thread Jaydeep Patil via lldb-commits
jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL254710 Repository: rL LLVM http://reviews.llvm.org/D15182 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-05-22 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53 @@ -22,2 +52,3 @@ + NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol &native_thread, uint32_t

Re: [Lldb-commits] [PATCH] D21064: [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions

2016-06-08 Thread Jaydeep Patil via lldb-commits
jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D21064 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

Re: [Lldb-commits] [PATCH] D15487: [LLDB][MIPS] Added support for MIPS1, MIPS2, MIPS3, MIPS4 and MIPS5 instruction sets

2015-12-14 Thread Jaydeep Patil via lldb-commits
jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D15487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

Re: [Lldb-commits] [PATCH] D15488: [LLDB][MIPS] Mark TestConcurrentEvents.py expected failure, as MIPS atomic sequences are yet to be supported in LLDB

2015-12-14 Thread Jaydeep Patil via lldb-commits
jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D15488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

2016-02-02 Thread Jaydeep Patil via lldb-commits
jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rL LLVM http://reviews.llvm.org/D16840 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

Re: [Lldb-commits] [PATCH] D17597: [LLDB][MIPS] Fix TestDisassembleBreakpoint

2016-02-29 Thread Jaydeep Patil via lldb-commits
jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D17597 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

Re: [Lldb-commits] [PATCH] D11747: [MIPS] Support standard GDB remote stop reply packet for watchpoint

2015-08-10 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. Could you please find some time to review this? Thanks. Repository: rL LLVM http://reviews.llvm.org/D11747 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

Re: [Lldb-commits] [PATCH] D11672: [MIPS] Handle false positives for MIPS hardware watchpoints

2015-08-10 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. Could you please find some time to review this? Thanks. Repository: rL LLVM http://reviews.llvm.org/D11672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

Re: [Lldb-commits] [PATCH] D11519: [MIPS] Use qfThreadID if qC packet is not supported by target

2015-08-10 Thread Jaydeep Patil via lldb-commits
jaydeep added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1463-1465 @@ +1462,5 @@ + +// If we don't get a response for $qC, check if $qfThreadID gives us a result. +if (m_curr_pid == LLDB_INVALID_PROCESS_ID && o

Re: [Lldb-commits] [PATCH] D11672: [MIPS] Handle false positives for MIPS hardware watchpoints

2015-08-11 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. Hi jingham, Could you please review this? Thanks. Repository: rL LLVM http://reviews.llvm.org/D11672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D11519: [MIPS] Use qfThreadID if qC packet is not supported by target

2015-08-12 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 31908. jaydeep added a comment. Addressed review comments. Repository: rL LLVM http://reviews.llvm.org/D11519 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp Index: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClie

Re: [Lldb-commits] [PATCH] D11747: [MIPS] Support standard GDB remote stop reply packet for watchpoint

2015-08-12 Thread Jaydeep Patil via lldb-commits
jaydeep added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:2498-2500 @@ +2497,5 @@ +reason = "watchpoint"; +std::ostringstream ostr; +ostr << wp_addr << " " << wp_index; +

Re: [Lldb-commits] [PATCH] D11747: [MIPS] Support standard GDB remote stop reply packet for watchpoint

2015-08-12 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 31919. jaydeep added a comment. Addressed review comments. Repository: rL LLVM http://reviews.llvm.org/D11747 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h

[Lldb-commits] [lldb] r244864 - [LLDB][MIPS] Handle false positives for MIPS hardware watchpoints

2015-08-12 Thread Jaydeep Patil via lldb-commits
Author: jaydeep Date: Wed Aug 12 22:44:09 2015 New Revision: 244864 URL: http://llvm.org/viewvc/llvm-project?rev=244864&view=rev Log: [LLDB][MIPS] Handle false positives for MIPS hardware watchpoints SUMMARY: Last 3bits of the watchpoint address are masked by the kernel. For example, n is

[Lldb-commits] [lldb] r244865 - [LLDB][MIPS] Support standard GDB remote stop reply packet for watchpoint

2015-08-12 Thread Jaydeep Patil via lldb-commits
Author: jaydeep Date: Wed Aug 12 22:46:01 2015 New Revision: 244865 URL: http://llvm.org/viewvc/llvm-project?rev=244865&view=rev Log: [LLDB][MIPS] Support standard GDB remote stop reply packet for watchpoint SUMMARY: The patch supports TAAwatch:addr packet. The patch also sets m_watchpoin

[Lldb-commits] [lldb] r244866 - [LLDB][MIPS] Use qfThreadID if qC packet is not supported by target

2015-08-12 Thread Jaydeep Patil via lldb-commits
Author: jaydeep Date: Wed Aug 12 22:46:36 2015 New Revision: 244866 URL: http://llvm.org/viewvc/llvm-project?rev=244866&view=rev Log: [LLDB][MIPS] Use qfThreadID if qC packet is not supported by target SUMMARY: The patch uses qfThreadID to get the thread IDs if qC packet is not supported

Re: [Lldb-commits] [PATCH] D11747: [MIPS] Support standard GDB remote stop reply packet for watchpoint

2015-08-13 Thread Jaydeep Patil via lldb-commits
jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL244865 Repository: rL LLVM http://reviews.llvm.org/D11747 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D11672: [MIPS] Handle false positives for MIPS hardware watchpoints

2015-08-13 Thread Jaydeep Patil via lldb-commits
jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL244864 Repository: rL LLVM http://reviews.llvm.org/D11672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D11519: [MIPS] Use qfThreadID if qC packet is not supported by target

2015-08-13 Thread Jaydeep Patil via lldb-commits
jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL244866 Repository: rL LLVM http://reviews.llvm.org/D11519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D11455: [MIPS] Create Unix Signals based on target architecture

2015-08-13 Thread Jaydeep Patil via lldb-commits
jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL243618 Repository: rL LLVM http://reviews.llvm.org/D11455 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D11133: [MIPS] Detect MIPS application specific extensions like micromips

2015-08-13 Thread Jaydeep Patil via lldb-commits
jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL242381 Repository: rL LLVM http://reviews.llvm.org/D11133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D10596: [MIPS] MIPS32 branch emulation and single-stepping

2015-08-13 Thread Jaydeep Patil via lldb-commits
jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL240373 Repository: rL LLVM http://reviews.llvm.org/D10596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-08-17 Thread Jaydeep Patil via lldb-commits
jaydeep created this revision. jaydeep added a reviewer: clayborg. jaydeep added subscribers: lldb-commits, bhushan, sagar, mohit.bhakkad, nitesh.jain. jaydeep set the repository for this revision to rL LLVM. This patch enables setting of breakpoints and disassembly for microMIPS applications ru

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

2015-08-26 Thread Jaydeep Patil via lldb-commits
jaydeep requested changes to this revision. This revision now requires changes to proceed. Comment at: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp:3117 @@ +3116,3 @@ +else +target = pc + 4; + This should be pc + 8. If branch is not t

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-08-26 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 33301. jaydeep added a comment. Addressed review comments. Address conversions are handled in Address class. This is a reduced version of the original patch where address conversions are handled for breakpoints only. Repository: rL LLVM http://reviews.ll

Re: [Lldb-commits] [PATCH] D12427: [LLDB][MIPS] Aligning code with rL245831

2015-08-28 Thread Jaydeep Patil via lldb-commits
jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D12427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

2015-09-01 Thread Jaydeep Patil via lldb-commits
jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rL LLVM http://reviews.llvm.org/D12356 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-02 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 33793. jaydeep added a comment. Added GetCallableFileAddress for MIPS Repository: rL LLVM http://reviews.llvm.org/D12079 Files: include/lldb/Core/Address.h include/lldb/Symbol/Function.h include/lldb/Target/Target.h source/Breakpoint/BreakpointRe

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-04 Thread Jaydeep Patil via lldb-commits
jaydeep added inline comments. Comment at: source/Target/RegisterContext.cpp:106-116 @@ -105,3 +105,13 @@ uint32_t reg = ConvertRegisterKindToRegisterNumber (eRegisterKindGeneric, LLDB_REGNUM_GENERIC_PC); -return ReadRegisterAsUnsigned (reg, fail_value); +uint64_t pc

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-08 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 34199. jaydeep added a comment. In this patch: The bit #0 has been cleared from addresses in the line tables. However we are relying upon ArchSpec instead of Target while clearing this bit in ParseDWARFLineTableCallback because SymbolContext may not have a

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-08 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 34292. jaydeep added a comment. In this patch: - Removed MIPS comment from generic code - Used Target::GetOpcodeLoadAddress to fixup the PC Regarding change in FormatEntity.cpp: We still need to do this. The bit #0 of ‘addr’ has already been striped and th

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-09 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. In http://reviews.llvm.org/D12079#242751, @clayborg wrote: > Actually not a new format type, but an extra arg will need to be passed to > DumpAddress like "bool addr_is_callable". > > Can you explain something to me? In the following example: > > 0x8020067d <+0>: addi

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-09 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. In http://reviews.llvm.org/D12079#242742, @clayborg wrote: > So DumpAddress() in FormatEntity.cpp is a generic "dump any address by > describing it". You can't just change the code to suit your needs for MIPS. > This address could be any address: code or data. If you wa

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-10 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. In http://reviews.llvm.org/D12079#243390, @clayborg wrote: > In http://reviews.llvm.org/D12079#242998, @jaydeep wrote: > > > In http://reviews.llvm.org/D12079#242742, @clayborg wrote: > > > > > So DumpAddress() in FormatEntity.cpp is a generic "dump any address by > > >

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-10 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. In http://reviews.llvm.org/D12079#244059, @jaydeep wrote: > In http://reviews.llvm.org/D12079#243390, @clayborg wrote: > > > In http://reviews.llvm.org/D12079#242998, @jaydeep wrote: > > > > > In http://reviews.llvm.org/D12079#242742, @clayborg wrote: > > > > > > > So Dum

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-10 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 34532. jaydeep added a comment. In this patch: Modified DumpAddress() to print compressed address for microMIPS. Repository: rL LLVM http://reviews.llvm.org/D12079 Files: source/Core/FormatEntity.cpp source/Plugins/Disassembler/llvm/DisassemblerLLVMC

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-13 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. Hi Greg, Could you please find some time to review this? Thanks Repository: rL LLVM http://reviews.llvm.org/D12079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/l

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-14 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 34782. jaydeep added a comment. Addressed review comments Repository: rL LLVM http://reviews.llvm.org/D12079 Files: source/Core/Address.cpp source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp sou

[Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

2015-09-14 Thread Jaydeep Patil via lldb-commits
jaydeep created this revision. jaydeep added a reviewer: clayborg. jaydeep added subscribers: lldb-commits, bhushan, sagar, mohit.bhakkad, nitesh.jain. jaydeep set the repository for this revision to rL LLVM. Refer to for discuss

[Lldb-commits] [lldb] r247773 - [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

2015-09-15 Thread Jaydeep Patil via lldb-commits
Author: jaydeep Date: Tue Sep 15 23:04:01 2015 New Revision: 247773 URL: http://llvm.org/viewvc/llvm-project?rev=247773&view=rev Log: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo SUMMARY: Refer to http://lists.llvm.org/pipermail/lldb-dev/2015-August/008024.html

Re: [Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

2015-09-15 Thread Jaydeep Patil via lldb-commits
jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL247773 Repository: rL LLVM http://reviews.llvm.org/D12876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-15 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 34873. jaydeep added a comment. Addressed review comments Repository: rL LLVM http://reviews.llvm.org/D12079 Files: source/Core/Address.cpp source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp sou

Re: [Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

2015-09-16 Thread Jaydeep Patil via lldb-commits
jaydeep added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3579 @@ +3578,3 @@ +*/ +if (!response.IsNormalResponse() && thread_ids.size() == 0 && IsConnected()) +{ labath wrote: > labath w

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-17 Thread Jaydeep Patil via lldb-commits
jaydeep updated this revision to Diff 35059. jaydeep added a comment. Addressed review comments. Repository: rL LLVM http://reviews.llvm.org/D12079 Files: source/Core/Address.cpp source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp so

[Lldb-commits] [lldb] r247968 - [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

2015-09-17 Thread Jaydeep Patil via lldb-commits
Author: jaydeep Date: Fri Sep 18 00:32:54 2015 New Revision: 247968 URL: http://llvm.org/viewvc/llvm-project?rev=247968&view=rev Log: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo SUMMARY: Using response.IsUnsupportedResponse instead of !response.IsNormalRespon

Re: [Lldb-commits] [PATCH] D12876: [MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

2015-09-17 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. Changed "!response.IsNormalResponse()" to "response.IsUnsupportedResponse()" by commit http://reviews.llvm.org/rL247968 Repository: rL LLVM http://reviews.llvm.org/D12876 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] r248248 - [LLDB][MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-21 Thread Jaydeep Patil via lldb-commits
Author: jaydeep Date: Tue Sep 22 01:36:56 2015 New Revision: 248248 URL: http://llvm.org/viewvc/llvm-project?rev=248248&view=rev Log: [LLDB][MIPS] microMIPS breakpoints, disassembly and compressed addresses SUMMARY: This patch detects microMIPS symbols, sets breakpoints using un-compressed

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

2015-09-22 Thread Jaydeep Patil via lldb-commits
jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL248248 Repository: rL LLVM http://reviews.llvm.org/D12079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [Diffusion] rL247968: [LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo

2015-09-23 Thread Jaydeep Patil via lldb-commits
jaydeep added a comment. Hi Dawn, Let me check and get back to you. Regards, Jaydeep Users: jaydeep (Author) dawn (Auditor) http://reviews.llvm.org/rL247968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b