Author: jmolenda
Date: Thu Mar 24 21:17:27 2016
New Revision: 264380
URL: http://llvm.org/viewvc/llvm-project?rev=264380&view=rev
Log:
Add the same host logging that I added to PlatformRemoteiOS a few
months back to PlatformRemoteAppleTV and PlatformRemoteAppleWatch
to help understand what's happe
The specific example Jim gave (./->) is a very common complaint of people
coming from gdb.
gdb's hand-rolled parser would realize that when you -> on an object, that
doesn't make sense and silently correct it to . for you. In practice, when
you're examining local variables, you often don't r
Author: jmolenda
Date: Tue Apr 5 00:01:30 2016
New Revision: 265377
URL: http://llvm.org/viewvc/llvm-project?rev=265377&view=rev
Log:
Consolidate the knowledge of what arm cores are always executing
in thumb mode into one method in ArchSpec, replace checks for
specific cores in the disassembler w
jasonmolenda added a comment.
Yes, good idea to add that. ProcessGDBRemote will need to accept "gcc" for at
least a few years while old debugservers etc are floating around.
http://reviews.llvm.org/D18807
___
lldb-commits mailing list
lldb-commits
Author: jmolenda
Date: Thu Apr 7 17:00:55 2016
New Revision: 265732
URL: http://llvm.org/viewvc/llvm-project?rev=265732&view=rev
Log:
In GDBRemoteCommunicationClient::GetHostInfo, don't set the
os to "ios" or "macosx" if it is unspecified. For environments
where there genuinely is no os, we don'
jasonmolenda created this revision.
jasonmolenda added a reviewer: clayborg.
jasonmolenda added a subscriber: lldb-commits.
jasonmolenda set the repository for this revision to rL LLVM.
The Symtab has an array of symbol file addresses and sizes for
address-to-symbol lookups, created in Symtab::In
jasonmolenda added a comment.
Thanks for doing this work Ulrich, the assumption that SP==CFA was mine, I
should have put this in the ABI from the start.
I worry a little about the change to
RegisterContextLLDB::SavedLocationForRegister() where you've moved the ABI
is-volatile check into ABI::G
jasonmolenda added a comment.
Just to be clear, my concern is we get an register location which is
"undefined" (I've never seen it, I don't know what it means) and now
SavedLocationForRegister() will say "this register is volatile, not looking any
further" when it used to say "register not foun
jasonmolenda updated this revision to Diff 53517.
jasonmolenda added a comment.
Updated the patch to address Greg's feedback.
Repository:
rL LLVM
http://reviews.llvm.org/D19004
Files:
include/lldb/Core/RangeMap.h
source/Symbol/Symtab.cpp
Index: source/Symbol/Symtab.cpp
=
Author: jmolenda
Date: Tue Apr 12 23:32:49 2016
New Revision: 266165
URL: http://llvm.org/viewvc/llvm-project?rev=266165&view=rev
Log:
Update Symtab::InitAddressIndexes so that computed symbol sizes
will not exceed the bounds of their Section. This is addressing a
problem where a file had a large
jasonmolenda accepted this revision.
jasonmolenda added a comment.
Hi Tamas & Ulrich. I'm good with this patch, thanks for double checking that
detail for me.
http://reviews.llvm.org/D18977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jasonmolenda closed this revision.
jasonmolenda added a comment.
Committed in r266165.
Repository:
rL LLVM
http://reviews.llvm.org/D19004
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.
These look like good changes to me, especially the SBThread fix - I'm surprised
that hasn't caused a problem. The DynamicLoader change should be unnecessary
but I don't have a problem with that. Tamas might want to sp
jasonmolenda accepted this revision.
jasonmolenda added a comment.
Hi Ulrich, sorry for the delayed reply, I wanted to look at this function again.
This function has gone through some modifications over its lifetime. As you
correctly point out, we're doing this back-up-by-one thing in two place
jasonmolenda added a comment.
This looks good to me. Do you think the ReadRegister decl in
GDBRemoteCommunicationClient.h should have a comment noting that the reg_num is
a number in the remote register numbering scheme (eRegisterKindProcessPlugin)?
When lldb passes around register numbers in
( Resending with correct lldb-commits email address Cc:'ed )
Hi Sagar, I noticed this weekend that given an input program like
int foo (int in) { return in + 5;}
int main (int argc, char**argv) { return foo(argc); }
if I put a breakpoint on foo() on an x86 system (compiled with clang, on a
mac
Author: jmolenda
Date: Mon Aug 10 02:55:25 2015
New Revision: 244436
URL: http://llvm.org/viewvc/llvm-project?rev=244436&view=rev
Log:
Feedback from Jim: Change the "optimized code" warning to be entirely
contained within Process so that we won't be duplicating the warning
message if other parts o
I wouldn't be surprised if most of this is similar to the problem I emailed
yesterday ("TOT svn lldb crashes trying to print argc on TOT lldb, maybe
fallout from r244308 - [LLDB][MIPS] Fix offsets of all register sets and add
MSA regset and FRE=1 mode support") where lldb could hit an llvm APInt
Author: jmolenda
Date: Tue Aug 11 22:27:33 2015
New Revision: 244716
URL: http://llvm.org/viewvc/llvm-project?rev=244716&view=rev
Log:
Have debugserver send the OS version string plus
major, minor, and patchlevel in the qHostInfo reply.
Document that qHostInfo may report major/minor/patch
separa
Author: jmolenda
Date: Fri Aug 14 19:09:23 2015
New Revision: 245130
URL: http://llvm.org/viewvc/llvm-project?rev=245130&view=rev
Log:
There is no such thing as gdb_arm_f8, this register set is f0-f7.
Remove this entry and adjust the numbering for the rest of the arm
register definitions.
Modifi
Author: jmolenda
Date: Fri Aug 14 20:21:01 2015
New Revision: 245141
URL: http://llvm.org/viewvc/llvm-project?rev=245141&view=rev
Log:
A messy bit of cleanup: Move towards more descriptive names
for eh_frame and stabs register numberings. This is not
complete but it's a step in the right directio
Author: jmolenda
Date: Fri Aug 14 21:59:42 2015
New Revision: 245151
URL: http://llvm.org/viewvc/llvm-project?rev=245151&view=rev
Log:
Update DynamicRegisterInfo::SetRegisterInfo to accept eh_frame register
numbers in the key name "ehframe" or "eh_frame" in addition to the deprecated
"gcc" name (e
Author: jmolenda
Date: Mon Aug 17 19:21:24 2015
New Revision: 245261
URL: http://llvm.org/viewvc/llvm-project?rev=245261&view=rev
Log:
Remove unintentional ;'s.
Modified:
lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp
Modified: lldb/trunk/source/Plugins/Process/Utility/Dyn
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Looks good to me.
http://reviews.llvm.org/D11947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: jmolenda
Date: Wed Aug 19 22:05:09 2015
New Revision: 245536
URL: http://llvm.org/viewvc/llvm-project?rev=245536&view=rev
Log:
When the target definition is unparseable, print an error message
to the user. e.g. specified via the
plugin.process.gdb-remote.target-definition-file
setting.
Author: jmolenda
Date: Wed Aug 19 23:29:46 2015
New Revision: 245537
URL: http://llvm.org/viewvc/llvm-project?rev=245537&view=rev
Log:
If the filename specified by plugin.process.gdb-remote.target-definition-file,
doesn't exist, see if it needs tilde expansion before we ignore it completely.
Modi
Author: jmolenda
Date: Thu Aug 20 19:13:37 2015
New Revision: 245645
URL: http://llvm.org/viewvc/llvm-project?rev=245645&view=rev
Log:
The llvm Triple for an armv6m now comes back as llvm::Triple::thumb.
This was breaking disassembly for arm machines that we force to be
thumb mode all the time bec
Author: jmolenda
Date: Tue Aug 25 23:07:30 2015
New Revision: 246004
URL: http://llvm.org/viewvc/llvm-project?rev=246004&view=rev
Log:
In SendContinuePacketAndWaitForResponse there is a special bit of
code that looks for a second stop-reply packet in response to an
interrupt (control-c). This is
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Looks good, thanks, I wasn't sure about whether this API would be available on
older releases.
Repository:
rL LLVM
http://reviews.llvm.org/D12396
___
Author: jmolenda
Date: Tue Sep 1 00:17:01 2015
New Revision: 246530
URL: http://llvm.org/viewvc/llvm-project?rev=246530&view=rev
Log:
A few small comment fixups with terminology "gcc" -> "eh_frame", "gdb" ->
"stabs".
Just noticed these while reading through some code.
Modified:
lldb/trunk/s
iewvc/llvm-project?rev=246649&view=rev but please check that
> it don't break the original functionality you tried to implement.
>
> Thanks,
> Tamas
>
> On Fri, Aug 21, 2015 at 1:14 AM Jason Molenda via lldb-commits
> wrote:
> Author: jmolenda
> Date: Thu Au
Author: jmolenda
Date: Thu Sep 3 22:40:29 2015
New Revision: 246834
URL: http://llvm.org/viewvc/llvm-project?rev=246834&view=rev
Log:
Change the (internal to this file only) enum names from gcc_ to
ehframe_ & from gdb_ to stabs_ for clarity.
Also document the fact that i386 eh_frame on Darwin ha
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
I'm fine with this change. On x86, where the CALL instruction pushes the
return address on the stack, you can't have two stack frames with the CFA. If
we have a loop, I don't thi
Author: jmolenda
Date: Tue Sep 8 22:24:52 2015
New Revision: 247120
URL: http://llvm.org/viewvc/llvm-project?rev=247120&view=rev
Log:
A change I'm open to reverting if there is disagreement:
When lldb receives a gdb-remote protocol packet that has
nonprintable characters, it will print the packet
Author: jmolenda
Date: Tue Sep 8 22:36:24 2015
New Revision: 247121
URL: http://llvm.org/viewvc/llvm-project?rev=247121&view=rev
Log:
When lldb gets the register definitions from the response of a
qXfer:features:read:target.xml packet, or via the
plugin.process.gdb-remote.target-definition-file s
jasonmolenda added a comment.
Thanks Tamas. I'll figure out what's happening there before I commit.
http://reviews.llvm.org/D12791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda added a comment.
Thanks Tamas. I have access to a linux machine, I had a little trouble getting
TOT set up correctly yesterday but I'll get that figured out today and fix
whatever the issue is.
http://reviews.llvm.org/D12791
___
lldb
jasonmolenda added a comment.
Ah, those failures were due to
Index: gdbremote_testcase.py
- gdbremote_testcase.py (revision 247726)
+++ gdbremote_testcase.py (working copy)
@@ -548,7 +548,7 @@
"encoding",
"format",
"set",
- "gcc",
+"ehframe",
jasonmolenda closed this revision.
jasonmolenda added a comment.
Landed in r247741.
http://reviews.llvm.org/D12791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jmolenda
Date: Tue Sep 15 18:49:57 2015
New Revision: 247751
URL: http://llvm.org/viewvc/llvm-project?rev=247751&view=rev
Log:
A partner to the cleanup in r247741, change the variables names in
debugserver to match. "gcc" is now "ehframe" and "gdb" is now
"debugserver". Because this is d
jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.
Maybe I'm an outlier here -- but I don't think we should show assembly code,
unless specifically requested by the user, when we can't find a source file
(but we have source-level debug information).
lldb used to behave
jasonmolenda added a comment.
I chatted with Jim and Greg about this today. We have a
"`stop-disassembly-display`" setting right now. It can be one of three values:
never: never show assembly
no-source: show assembly when we have no debug information
always: always show assembly
"no-source" i
Author: jmolenda
Date: Tue Sep 22 18:25:44 2015
New Revision: 248343
URL: http://llvm.org/viewvc/llvm-project?rev=248343&view=rev
Log:
A small fixup needed for debugserver to work natively
on iOS devices; fallout from Vince's cleanups made
in r237218 back in May. iOS native lldbs will call
StartD
jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.
NB: Greg is out for the next nine days, Enrico for the next five days.
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
Author: jmolenda
Date: Mon Sep 28 18:02:00 2015
New Revision: 248755
URL: http://llvm.org/viewvc/llvm-project?rev=248755&view=rev
Log:
Remove one of the three spaces after a period in one of the breakpoint
set help messages.
Modified:
lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/96983
ObjectFileMachO::SetLoadAddress sets the address of each segment in a binary in
a Target, but it ignores segments that are not loaded in the virtual address
space. It was marking segments that were purely
jasonmolenda wrote:
I was about to add a macosx/ API test to compile a program with only BSS data
in the DATA segment, and I noticed I'd written
`TestBSSOnlyDataSectionSliding.py` last year when I opted sections named "DATA"
out of this "don't set a load address for BSS-only segments" behavior
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/96983
>From 6bd566504355e8d50b9c922df9ebce18e07a726f Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 27 Jun 2024 15:34:48 -0700
Subject: [PATCH 1/2] [lldb] [ObjectFileMachO] BSS segments are loadable
segm
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/96260
>From 9b541e6a035635e26c6a24eca022de8552fa4c17 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 20 Jun 2024 17:53:17 -0700
Subject: [PATCH 1/4] [lldb] Change lldb's breakpoint handling behavior
lldb
jasonmolenda wrote:
Hi @AlexK0 I restructured this PR to track everything with a single piece of
state in the Thread object, and redid all three Process plugins. I'm feeling a
lot better about my changes to ProcessWindows now. I haven't tested the
aarch64 ubuntu yet, I will do that tomorrow
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/96260
>From 9b541e6a035635e26c6a24eca022de8552fa4c17 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 20 Jun 2024 17:53:17 -0700
Subject: [PATCH 1/5] [lldb] Change lldb's breakpoint handling behavior
lldb
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/96983
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/96887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
This look good. I like distinguishing between "is not a known binary type" and
"does not contain an architecture supported on this platform (but is a binary
file that we recognize)".
https://github.com/llvm/llvm-project/pull/97490
__
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/97687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/98055
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/96260
>From 9b541e6a035635e26c6a24eca022de8552fa4c17 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 20 Jun 2024 17:53:17 -0700
Subject: [PATCH 1/6] [lldb] Change lldb's breakpoint handling behavior
lldb
jasonmolenda wrote:
Thanks again for all the help @AlexK0 I pushed an update that should compile
correctly with my update. It's great to hear that the testsuite looks clean --
that's the part that worried me the most about these changes.
I finished an aarch64 Ubuntu testsuite run and it is cl
https://github.com/jasonmolenda approved this pull request.
LGTM. We'll skip any fileset entries that we can't read the filename of.
https://github.com/llvm/llvm-project/pull/98388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
Author: Jason Molenda
Date: 2024-07-11T16:51:28-07:00
New Revision: 1988c27e5f4dbcf42c9a80f44bdee7ccd208a0ac
URL:
https://github.com/llvm/llvm-project/commit/1988c27e5f4dbcf42c9a80f44bdee7ccd208a0ac
DIFF:
https://github.com/llvm/llvm-project/commit/1988c27e5f4dbcf42c9a80f44bdee7ccd208a0ac.diff
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/98566
In RegisterContextUnwind::SavedLocationForRegister we have special logic for
retrieving the Return Address register when it has the caller's return address
in it. An example would be the lr register on AArc
@@ -46,6 +46,7 @@ static constexpr FormatInfo g_format_infos[] = {
{eFormatHex, 'x', "hex"},
{eFormatHexUppercase, 'X', "uppercase hex"},
{eFormatFloat, 'f', "float"},
+{eFormatFloat128, '\0', "float128"},
jasonmolenda wrote:
I'm not familiar w
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/98369
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> Testing this is in theory possible, tricky bit is guaranteeing a frameless
> function. There is the naked attribute but it's not portable
> https://godbolt.org/z/s9117Gr7a. Or you could write the function in an
> assembly file, or define and call it inside an inline asse
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/98566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-07-14T10:59:46-07:00
New Revision: 3478573773d02e574524fd45c14631de5b7d10a9
URL:
https://github.com/llvm/llvm-project/commit/3478573773d02e574524fd45c14631de5b7d10a9
DIFF:
https://github.com/llvm/llvm-project/commit/3478573773d02e574524fd45c14631de5b7d10a9.diff
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/98845
When doing firmware/kernel debugging, it is frequent that binaries and debug
info need to be retrieved / downloaded, and the lack of progress reports made
for a poor experience, with lldb seemingly hung whi
jasonmolenda wrote:
The one thing I was uncertain of is when I load kexts -- I have a known number
of kexts that I will be attempting to load -- and I wasn't sure if I should log
them individually as they happen (what I did), or if I should initialize a
progress category with the number of kex
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/2] [lldb] progressive progress reporting for darwin
kernel
jasonmolenda wrote:
Ah no, I misunderstood. The Increment method of Progress is intended for use
where you have one progress status display that takes multiple steps to
complete. It's a separate mechanism from "finding dSYM for file x" etc. I
can't use an Increment style progress reporting
@@ -757,11 +758,32 @@ bool
DynamicLoaderDarwinKernel::KextImageInfo::LoadImageUsingMemoryModule(
const ModuleList &target_images = target.GetImages();
m_module_sp = target_images.FindModule(m_uuid);
+StreamString prog_str;
+// 'mach_kernel' is a fake name we m
@@ -757,11 +758,32 @@ bool
DynamicLoaderDarwinKernel::KextImageInfo::LoadImageUsingMemoryModule(
const ModuleList &target_images = target.GetImages();
m_module_sp = target_images.FindModule(m_uuid);
+StreamString prog_str;
+// 'mach_kernel' is a fake name we m
@@ -757,11 +758,32 @@ bool
DynamicLoaderDarwinKernel::KextImageInfo::LoadImageUsingMemoryModule(
const ModuleList &target_images = target.GetImages();
m_module_sp = target_images.FindModule(m_uuid);
+StreamString prog_str;
+// 'mach_kernel' is a fake name we m
@@ -195,20 +196,40 @@ ModuleSP DynamicLoader::LoadBinaryWithUUIDAndAddress(
Target &target = process->GetTarget();
Status error;
+ StreamString prog_str;
+ if (!name.empty()) {
+prog_str << name.str() << " ";
+ }
+ if (uuid.IsValid())
+prog_str << uuid.GetAsStr
@@ -195,20 +196,40 @@ ModuleSP DynamicLoader::LoadBinaryWithUUIDAndAddress(
Target &target = process->GetTarget();
Status error;
+ StreamString prog_str;
+ if (!name.empty()) {
+prog_str << name.str() << " ";
+ }
+ if (uuid.IsValid())
+prog_str << uuid.GetAsStr
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/3] [lldb] progressive progress reporting for darwin
kernel
jasonmolenda wrote:
Thanks for the helpful feedback @clayborg pushed an update.
https://github.com/llvm/llvm-project/pull/98845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/4] [lldb] progressive progress reporting for darwin
kernel
https://github.com/jasonmolenda approved this pull request.
Agreed, this fix is correct, thanks for the PR. The register numbering in the
UnwindPlan can be any eRegisterKind, but it does need to be self consistent,
and this was not. Do you have permissions to merge this PR? I can do that for
jasonmolenda wrote:
I don't think this change is correct, or I don't understand what it is trying
to do.
When we're connected to a stub that can allocate memory in the target, none of
this code is executed. So lldb-server/debugserver will not hit this.
We send `qMemoryRegionInfo` packets to
@@ -2545,6 +2546,11 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
&file_spec,
ModuleSP module_sp(new Module(file_spec, ArchSpec()));
if (module_sp) {
Status error;
+std::unique_ptr progress_up;
+if (!GetCoreFile())
jasonmolenda wrote
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/5] [lldb] progressive progress reporting for darwin
kernel
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/6] [lldb] progressive progress reporting for darwin
kernel
@@ -2545,6 +2546,11 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
&file_spec,
ModuleSP module_sp(new Module(file_spec, ArchSpec()));
if (module_sp) {
Status error;
+std::unique_ptr progress_up;
+if (!GetCoreFile())
jasonmolenda wrote
@@ -633,171 +613,142 @@ StopInfoSP
StopInfoMachException::CreateStopReasonWithMachException(
}
break;
+ // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code]
+ //
+ // Instruction step:
+ // [6, 1, 0]
+ // Intel KDP [6, 3, ??]
+ // armv7 [6, 0x102, ] Sa
@@ -633,171 +613,142 @@ StopInfoSP
StopInfoMachException::CreateStopReasonWithMachException(
}
break;
+ // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code]
+ //
+ // Instruction step:
+ // [6, 1, 0]
+ // Intel KDP [6, 3, ??]
+ // armv7 [6, 0x102, ] Sa
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/7] [lldb] progressive progress reporting for darwin
kernel
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/8] [lldb] progressive progress reporting for darwin
kernel
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/98845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
To make sure I'm clear: I don't have a problem with the basic idea of the
change, although we could comment what is going on more clearly, and I'm
curious about that qMemoryRegionInfo packet. But it looks like you're
connecting to a device which can't allocate memory throu
@@ -229,6 +229,17 @@ bool ScriptedThread::CalculateStopInfo() {
LLVM_PRETTY_FUNCTION, "Failed to get scripted thread stop info.",
error,
LLDBLog::Thread);
+ // If we're at a BreakpointSite, mark that we stopped there and
jasonmolenda wrote:
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/96260
>From 9b541e6a035635e26c6a24eca022de8552fa4c17 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 20 Jun 2024 17:53:17 -0700
Subject: [PATCH 1/7] [lldb] Change lldb's breakpoint handling behavior
lldb
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/96260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,58 @@
+//===--- DirectToIndirectFCR.h - RISC-V specific pass
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
jasonmolenda wrote:
I'd describe this patch as handling the case where a remote stub cannot jit
memory and has a qMemoryRegion info packet which does not specify permissions.
The patch you reference makes jitted code expressions work, but I think
IRMemoryMap::FindSpec only needs to find space
jasonmolenda wrote:
A quick look at the RISCV ISA and it says that the JAL instruction is pc
relative and can jump +/- 1MB. JALR is also pc-relative but it gets the upper
20 bits from a general purpose register and it includes 12 low bits in its
instruction encoding. I know almost nothing ab
jasonmolenda wrote:
As for getting to the jitted code, of course lldb sets the pc directly so that
initial switch from user code to jitted code region is fine. But getting from
the jitted wrapper function to the user functions we need to call would require
JALR instructions?
https://github.c
jasonmolenda wrote:
I think we should change these checks to look for an explicitly inaccessible
memory region, like
```
if (region_info.GetReadable() != MemoryRegionInfo::OptionalBool::eNo &&
region_info.GetWritable() != MemoryRegionInfo::OptionalBool::eNo &&
re
@@ -0,0 +1,58 @@
+//===--- DirectToIndirectFCR.h - RISC-V specific pass
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,58 @@
+//===--- DirectToIndirectFCR.h - RISC-V specific pass
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
501 - 600 of 1925 matches
Mail list logo
