jasonmolenda added a comment.
Thanks Ravi, I see the problem here and I agree that lldb should use eh_frame
to unwind from this function - that's the only way this is going to work. I'm
surprised that there is accurate eh_frame instructions for this function, it's
great to see it.
I'm wonderi
jasonmolenda added a comment.
Regarding the part of the patch where eh_frame is used unconditionally on Linux
systems, I'm hesitant to make a change like that (beyond the notes I mentioned
earlier about how I'd do it in FuncUnwinders instead of down in
RegisterContextLLDB). Modern gcc's put ou
Author: jmolenda
Date: Mon Jun 20 22:39:39 2016
New Revision: 273236
URL: http://llvm.org/viewvc/llvm-project?rev=273236&view=rev
Log:
Change the "debugserver-mini" target (a version of debugserver
which doesn't like against all the extra UI frameworks on ios)
so it now generates a binary called "
Author: jmolenda
Date: Wed Jun 22 20:18:16 2016
New Revision: 273524
URL: http://llvm.org/viewvc/llvm-project?rev=273524&view=rev
Log:
Do some minor renames of "Mac OS X" to "macOS".
There's uses of "macosx" that will be more tricky to
change, like in triples (e.g. "x86_64-apple-macosx10.11") -
f
Author: jmolenda
Date: Wed Jun 22 23:24:16 2016
New Revision: 273531
URL: http://llvm.org/viewvc/llvm-project?rev=273531&view=rev
Log:
Revert r273524, it may have been the cause of a linux testbot failure
for TestNamespaceLookup.py; didn't see anything obviously wrong so I'll
need to look at this
Author: jmolenda
Date: Mon Jun 27 17:48:05 2016
New Revision: 273954
URL: http://llvm.org/viewvc/llvm-project?rev=273954&view=rev
Log:
Change PlatformDarwinKernel::GetSharedModule to be a little more
explicit in how it adds the kernel binary, to guard against the
case where a kernel corefile might
Author: jmolenda
Date: Wed Jul 6 18:06:19 2016
New Revision: 274700
URL: http://llvm.org/viewvc/llvm-project?rev=274700&view=rev
Log:
Enhance FuncUnwinders::GetUnwindPlanAtNonCallSite to detect when we
may be in a function that is non-ABI conformant, and the eh_frame
instructions correctly descri
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Ravitheja and I had some discussions over email about a possible alternate
approach to this issue - I've committed that approach as r274700 after testing
help from Ravi. This patc
Author: jmolenda
Date: Wed Jul 6 20:09:23 2016
New Revision: 274718
URL: http://llvm.org/viewvc/llvm-project?rev=274718&view=rev
Log:
Add support to debugserver for some new ways to interact with dyld
to find the solibs loaded in a process. Support two new ways of
sending the jGetLoadedDynamicLi
Author: jmolenda
Date: Wed Jul 6 22:12:01 2016
New Revision: 274725
URL: http://llvm.org/viewvc/llvm-project?rev=274725&view=rev
Log:
debugserver will now report the minimum version load command
os name and version # from the mach-o binary as it scans the
header/load commands from memory and send
Author: jmolenda
Date: Mon Jul 11 22:25:22 2016
New Revision: 275151
URL: http://llvm.org/viewvc/llvm-project?rev=275151&view=rev
Log:
Add some safety checks to Platform::GetRemoteSharedModule so if it
is passed a ModuleSpec with a UUID, it won't accept a file it finds
with a matching FileSpec & A
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
This is fine - is there a binary using this? I'd love to see the assembly code
and a dump of the eh_frame CFI.
I googled around and didn't find much about DW_CFA_GNU_args_size but
Author: jmolenda
Date: Sun Jul 17 14:57:49 2016
New Revision: 275729
URL: http://llvm.org/viewvc/llvm-project?rev=275729&view=rev
Log:
Add missing break stmt to DW_CFA_GNU_args_size case.
Modified:
lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp
Modified: lldb/trunk/source/Symbol/DWARFCallFr
Author: jmolenda
Date: Sun Jul 17 15:01:54 2016
New Revision: 275731
URL: http://llvm.org/viewvc/llvm-project?rev=275731&view=rev
Log:
Initialize the "is_loaded" local in LoadModuleAtAddress in
case Process::GetFileLoadAddress fails to set it to a real
value. (fixing "conditional use of garbage v
Author: jmolenda
Date: Mon Jul 18 21:37:07 2016
New Revision: 275944
URL: http://llvm.org/viewvc/llvm-project?rev=275944&view=rev
Log:
Ignore clang-module-cache directories that may be created
in the testsuite directory while it runs.
Modified:
lldb/trunk/.gitignore
Modified: lldb/trunk/.git
Author: jmolenda
Date: Tue Jul 19 22:49:02 2016
New Revision: 276079
URL: http://llvm.org/viewvc/llvm-project?rev=276079&view=rev
Log:
Add a default-value bool flag pretty_print to the StructuredData Dump methods.
They will dump pretty-print (indentation, extra whitepsace) by default.
I'll make
Author: jmolenda
Date: Thu Jul 21 03:30:55 2016
New Revision: 276254
URL: http://llvm.org/viewvc/llvm-project?rev=276254&view=rev
Log:
Add a new DynamicLoader plugin that uses SPI that are in development
for the fall (northern hemisphere) 2016 Darwin platforms to learn
about loaded images, instead
Author: jmolenda
Date: Thu Jul 21 17:50:01 2016
New Revision: 276351
URL: http://llvm.org/viewvc/llvm-project?rev=276351&view=rev
Log:
Stop printing double { characters on Dictionary StructuredData objects
when Dumping, thanks to Devin to catching the edit mistake I made in
r276079.
Modified:
Author: jmolenda
Date: Thu Jul 21 19:17:55 2016
New Revision: 276369
URL: http://llvm.org/viewvc/llvm-project?rev=276369&view=rev
Log:
Add support to get the shared cache information from the new
debugserver jGetSharedCacheInfo packet instead of reading
the dyld internal data structures directly.
Author: jmolenda
Date: Fri Jul 22 17:26:26 2016
New Revision: 276485
URL: http://llvm.org/viewvc/llvm-project?rev=276485&view=rev
Log:
Remove some tab characters that snuck in to my mnost recent edits.
Modified:
lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
l
Author: jmolenda
Date: Mon Jul 25 22:10:15 2016
New Revision: 276721
URL: http://llvm.org/viewvc/llvm-project?rev=276721&view=rev
Log:
DynamicLoaderDarwinKernel will look in four addresses for the kernel
load address on 64-bit devices; it only needs to look in three.
Modified:
lldb/trunk/
Author: jmolenda
Date: Tue Jul 26 01:33:07 2016
New Revision: 276729
URL: http://llvm.org/viewvc/llvm-project?rev=276729&view=rev
Log:
Add support for an additional dictionary in the per-arch plists
that may be embedded in the Contents/Resources subdir of a dSYM
bundle. These allow for the specif
Author: jmolenda
Date: Wed Jul 27 23:18:44 2016
New Revision: 276954
URL: http://llvm.org/viewvc/llvm-project?rev=276954&view=rev
Log:
Add some logging to the kernel dynamicloader plugin when we fail to read
a kext binary from memory.
Modified:
lldb/trunk/source/Plugins/DynamicLoader/Darwi
Author: jmolenda
Date: Thu Jul 28 17:43:10 2016
New Revision: 277065
URL: http://llvm.org/viewvc/llvm-project?rev=277065&view=rev
Log:
Small refinement on the memory segment support in core files that
Greg added in r272276 -- when working with a non-user-process mach-o
core file, force the permiss
Author: jmolenda
Date: Thu Jul 28 19:18:39 2016
New Revision: 277088
URL: http://llvm.org/viewvc/llvm-project?rev=277088&view=rev
Log:
Move the code which knows how to get information about the shared
cache from ObjectFileMachO (very wrong place) to the DynamicLoader
plugins (better place). Not m
Author: jmolenda
Date: Fri Jul 29 01:24:03 2016
New Revision: 277123
URL: http://llvm.org/viewvc/llvm-project?rev=277123&view=rev
Log:
PlatformDarwinKernel maintains a list of kexts and kernels
that it finds on the local computer in "well known" locations
when we start up the darwin-kernel platfor
Author: jmolenda
Date: Thu Aug 4 19:44:34 2016
New Revision: 277789
URL: http://llvm.org/viewvc/llvm-project?rev=277789&view=rev
Log:
Change the indexing done for kernel/kext directories to be recursive.
Also re-write how most of the directory indexing is done - as it has
grown over the years, i
Author: jmolenda
Date: Tue Aug 16 22:56:04 2016
New Revision: 278901
URL: http://llvm.org/viewvc/llvm-project?rev=278901&view=rev
Log:
Fix the RangeMapVector::FindEntryThatContainsOrFollows method to
back up the iterator, as long as it still contains the address.
std::lower_bound will point us to
Author: jmolenda
Date: Wed Aug 24 00:25:32 2016
New Revision: 279611
URL: http://llvm.org/viewvc/llvm-project?rev=279611&view=rev
Log:
Add api logging for SBDebugger::SetCurrentPlatformSDKRoot.
Modified:
lldb/trunk/source/API/SBDebugger.cpp
Modified: lldb/trunk/source/API/SBDebugger.cpp
UR
Author: jmolenda
Date: Wed Aug 24 18:46:48 2016
New Revision: 279688
URL: http://llvm.org/viewvc/llvm-project?rev=279688&view=rev
Log:
Rewrite the GetFileInSDK methods in PlatformRemoteiOS,
PlatformRemoteAppleWatch, PlatformRemoteAppleTV and remove the
GetFileInSDKRoot method from those classes.
Author: jmolenda
Date: Wed Aug 24 21:33:09 2016
New Revision: 279704
URL: http://llvm.org/viewvc/llvm-project?rev=279704&view=rev
Log:
If the user has specified target.memory-module-load-level 'minimal'
and we couldn't find a dyld binary on the debug system, override
that setting and read dyld out
Author: jmolenda
Date: Mon Aug 29 19:58:23 2016
New Revision: 280039
URL: http://llvm.org/viewvc/llvm-project?rev=280039&view=rev
Log:
Update debugserver project to pull in StdStringExtractor.cpp instead of the new
llvm-using StringExtractor.cpp in the xcode project file settings.
Modified:
l
Author: jmolenda
Date: Wed Sep 7 18:08:36 2016
New Revision: 280879
URL: http://llvm.org/viewvc/llvm-project?rev=280879&view=rev
Log:
Remove CxaDemangle.cpp / .h from xcode project file.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
Author: jmolenda
Date: Wed Sep 7 21:26:58 2016
New Revision: 280902
URL: http://llvm.org/viewvc/llvm-project?rev=280902&view=rev
Log:
Force the initialization of the m_type ivar in
Function::GetStartLineSourceInfo before we try to
return the start line information about a function;
this function
Author: jmolenda
Date: Wed Sep 7 21:29:40 2016
New Revision: 280903
URL: http://llvm.org/viewvc/llvm-project?rev=280903&view=rev
Log:
I had a problem with one SDK where dispatch_release was actually a
macro, so writing ::dispatch_release did not work as expected.
Remove the global anon namespace
Author: jmolenda
Date: Thu Sep 8 00:12:41 2016
New Revision: 280906
URL: http://llvm.org/viewvc/llvm-project?rev=280906&view=rev
Log:
I'm experimenting with changing how the mixed source & assembly
mode in lldb works. I've been discussing this with Jim Ingham,
Greg Clayton, and Kate Stone for th
Author: jmolenda
Date: Mon Sep 12 21:45:45 2016
New Revision: 281291
URL: http://llvm.org/viewvc/llvm-project?rev=281291&view=rev
Log:
Reduce the number of simultaneous debug sessions to 10 and remove
the expectedFlakeyDarwin annotation.
I've been running this test in isolation on my macOS Sierra
Author: jmolenda
Date: Tue Sep 13 18:29:46 2016
New Revision: 281418
URL: http://llvm.org/viewvc/llvm-project?rev=281418&view=rev
Log:
TestQueues could error out because the one second sleep main.c was
using to enqueue all the jobs wasn't enough time on a slow/overloaded
system. Instead use a glo
I have to concur with Jim's point -- writing & maintaining the gdb testsuite
for years, which was based on commands & expected output like these lit tests,
was a huge drag on everyone's productivity as the debugger changed over time.
This style of test looks wonderfully easy to read & write & d
On Sep 14, 2016, at 5:13 PM, Zachary Turner wrote:
> I don't blame you for being scared of command tests. I don't support their
> use in the current LLDB test suite either, for exactly the same reasons you
> and Jason have expressed. But I do think it's possible to come up with
> something
It's great to make writing tests easier. We'd all love to have more tests.
If "writing tests easier" is "command line output scraping", that's only
hurting the project in the long term. I'm telling you this from years of
experience on a project where we did exactly this. It's great to have ex
If we want to add a testsuite runner which takes a source file, a place to put
a breakpoint, the name of a variable to examine, and it runs through those in
SB API, I'm all in favor. I don't know if that's going to add a lot of test
coverage to lldb, but I have no problem with such a thing.
My
> On Sep 15, 2016, at 8:02 AM, Zachary Turner wrote:
>
>
> It sounds like your goal is also "tests have to use the SB API and no other
> API", which if so I think that's counterproductive. More productive, IMO,
> would be being open to any alternative that addresses the concerns you have
>
I thought about this more overnight and I'm more convinced that lit and lldb-mi
make a great pair. lldb-mi is a programmatic text format that isn't subject to
the whims of command-line UI design over the years; well tests written in terms
of MI will be resilient and stable. lldb-mi MUCH more c
Author: jmolenda
Date: Wed Sep 28 23:01:43 2016
New Revision: 282683
URL: http://llvm.org/viewvc/llvm-project?rev=282683&view=rev
Log:
Add a unit test for an x86_64 assembly inspection of
a large stack frame with lots of spilled registers.
While writing the i386 version of this test, it looks
li
Good suggestions, thanks. I'll fix those when I commit the 32-bit version of
the same test.
J
> On Sep 28, 2016, at 9:28 PM, Zachary Turner wrote:
>
>
>
> On Wed, Sep 28, 2016 at 9:10 PM Jason Molenda via lldb-commits
> wrote:
>
> + EXPECT_TRUE(regloc.GetO
gt;
> Dimitar
>
>
> On Thu, Sep 29, 2016 at 5:30 AM, Jason Molenda via lldb-commits
> wrote:
> Good suggestions, thanks. I'll fix those when I commit the 32-bit version of
> the same test.
>
> J
>
> > On Sep 28, 2016, at 9:28 PM,
vm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake
>> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/20099
>>
>> Dimitar
>>
>>
>> On Thu, Sep 29, 2016 at 5:30 AM, Jason Molenda via lldb-commits
>> wrote:
>> Good suggest
Author: jmolenda
Date: Thu Sep 29 16:47:15 2016
New Revision: 282790
URL: http://llvm.org/viewvc/llvm-project?rev=282790&view=rev
Log:
Add a quick note about how to build lldb with debug info using
cmake/ninja on linux/bsd systems.
Modified:
lldb/trunk/www/build.html
Modified: lldb/trunk/www
Author: jmolenda
Date: Thu Sep 29 18:57:33 2016
New Revision: 282811
URL: http://llvm.org/viewvc/llvm-project?rev=282811&view=rev
Log:
Switch to using TEST_EQ, TEST_FALSE where appropriate.
Modified:
lldb/trunk/unittests/UnwindAssembly/x86/Testx86AssemblyInspectionEngine.cpp
Modified:
lldb/
Author: jmolenda
Date: Thu Sep 29 19:41:15 2016
New Revision: 282825
URL: http://llvm.org/viewvc/llvm-project?rev=282825&view=rev
Log:
Add unit tests for simple frameless i386 and x86_64 function
instruction inspection to UnwindPlans.
Modified:
lldb/trunk/unittests/UnwindAssembly/x86/Testx86A
be run
> as a result.
>
> Session logs for test failures/errors/unexpected successes will go into
> directory '2016-09-29-15_09_05'
> Command invoked: ./dotest.py -C gcc-4.8 -A i386 --executable
> /home/jmolenda/build/bin/lldb testcases/python_api/sbdata
&g
Author: jmolenda
Date: Fri Sep 30 19:19:26 2016
New Revision: 282991
URL: http://llvm.org/viewvc/llvm-project?rev=282991&view=rev
Log:
Add support for some extended push instructions in i386/x86_64 like
'push 0x20(%esp)' which clang can generate when emitting
-fomit-frame-pointer code for 32-bit.
Author: jmolenda
Date: Fri Sep 30 23:50:25 2016
New Revision: 283010
URL: http://llvm.org/viewvc/llvm-project?rev=283010&view=rev
Log:
Add unit tests for specific instruction patterns that the x86
assembly inspection class is designed to detect. This is only about
half of the instructions that it
Author: jmolenda
Date: Tue Oct 4 00:10:06 2016
New Revision: 283186
URL: http://llvm.org/viewvc/llvm-project?rev=283186&view=rev
Log:
Finish adding the individual instruction tests to the x86 unwinder
unittests. If I have time, I'd like to see if I can write some
tests of the eh_frame augmentati
Author: jmolenda
Date: Tue Oct 4 21:29:13 2016
New Revision: 283295
URL: http://llvm.org/viewvc/llvm-project?rev=283295&view=rev
Log:
Change Platform::GetRemoteSharedModule so if it's given a ModuleSpec
which specifies a file path and UUID but not an architecture, open
the file at that path and t
Author: jmolenda
Date: Fri Dec 11 19:32:09 2015
New Revision: 255417
URL: http://llvm.org/viewvc/llvm-project?rev=255417&view=rev
Log:
When supplying memory to expedite the unwinds in the T packet,
include two stack frames worth of unwind information instead of
just one -- the unwinder is trying t
Author: jmolenda
Date: Fri Dec 11 21:06:10 2015
New Revision: 255421
URL: http://llvm.org/viewvc/llvm-project?rev=255421&view=rev
Log:
Fix the L1 cache search in MemoryCache::Read to use the
stl upper_bound method instead of lower_bound - we were
failing to find some cached data in the L1 cache r
jasonmolenda removed rL LLVM as the repository for this revision.
jasonmolenda updated this revision to Diff 42630.
jasonmolenda added a comment.
Updated patch attached which addresses Jim's feedback.
1. Updated LineEntry.h description of new GetSameLineContiguousAddressRange
method to describe
jasonmolenda closed this revision.
jasonmolenda added a comment.
Sendinginclude/lldb/Symbol/LineEntry.h
Sendinginclude/lldb/Target/Thread.h
Sendingsource/API/SBThread.cpp
Sendingsource/Commands/CommandObjectThread.cpp
Sendingsource/Symbol/LineEntry.cpp
Sendi
Author: jmolenda
Date: Mon Dec 14 18:40:30 2015
New Revision: 255590
URL: http://llvm.org/viewvc/llvm-project?rev=255590&view=rev
Log:
When constructing an address range to "step" or "next" through,
find the largest address range (possibly combining multiple
LineEntry's for this line number) that
Author: jmolenda
Date: Mon Dec 14 19:26:25 2015
New Revision: 255597
URL: http://llvm.org/viewvc/llvm-project?rev=255597&view=rev
Log:
Add NetBSDSignals.cpp to the xcode project file.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
Author: jmolenda
Date: Tue Dec 15 17:47:44 2015
New Revision: 255711
URL: http://llvm.org/viewvc/llvm-project?rev=255711&view=rev
Log:
Add a new "thread-pcs" key-value pair to the T packet response from
debugserver. thread-pcs has a comma separated list of base 16
addresses - the current pc value
Author: jmolenda
Date: Thu Dec 17 18:45:35 2015
New Revision: 255942
URL: http://llvm.org/viewvc/llvm-project?rev=255942&view=rev
Log:
The lldb side changes to go along with r255711 where a new
"thread-pcs" key is added to the T (questionmark) packet in
gdb-remote protocol so that lldb doesn't nee
jasonmolenda created this revision.
jasonmolenda added a reviewer: jingham.
jasonmolenda added a subscriber: lldb-commits.
jasonmolenda set the repository for this revision to rL LLVM.
Herald added a subscriber: aemerson.
When lldb is instruction stepping (or fast-stepping / instruction stepping)
jasonmolenda added a comment.
Thanks for the comments. As for calling Clear() on the instruction list
manually, I was aping the dtor on ThreadPlanStepRange which reads,
// FIXME: The DisassemblerLLVMC has a reference cycle and won't go away if it
has any active instructions.
// I'll fix th
jasonmolenda updated this revision to Diff 44189.
jasonmolenda added a comment.
Updated to address Jim's first round of comments.
1. fix typeo in comment
2. update change argument name from "private_step_out" to
"continue_to_next_branch"
3. Change continue_to_next_branch argument to have a def
jasonmolenda closed this revision.
jasonmolenda added a comment.
Landed in r257117.
Sendinginclude/lldb/Target/Process.h
Sendinginclude/lldb/Target/Thread.h
Sendinginclude/lldb/Target/ThreadPlanStepOut.h
Sendingsource/Target/Process.cpp
Sendingsource/Target
Author: jmolenda
Date: Thu Jan 7 18:06:03 2016
New Revision: 257117
URL: http://llvm.org/viewvc/llvm-project?rev=257117&view=rev
Log:
Performance improvement: Change lldb so that it puts a breakpoint
on the first branch instruction after a function return (or the end
of a source line), instead of
Author: jmolenda
Date: Thu Jan 7 18:20:48 2016
New Revision: 257121
URL: http://llvm.org/viewvc/llvm-project?rev=257121&view=rev
Log:
Change the key name for the libdispatch queue serial number from
"qserial" to "qserialnum" because "qserial" looks a lot like the
queue type (either 'serial' or 'c
6_64-ubuntu-14.04-cmake/builds/10091
>
> I am able to reproduce this on my machine. Let me know if you need any
> help with anything.
>
> On Thu, Jan 7, 2016 at 4:06 PM, Jason Molenda via lldb-commits
> wrote:
>> Author: jmolenda
>> Date: Thu Jan 7 18:06:03 2016
>
Author: jmolenda
Date: Thu Jan 7 20:26:03 2016
New Revision: 257138
URL: http://llvm.org/viewvc/llvm-project?rev=257138&view=rev
Log:
Revert r257117 "Performance improvement: Change lldb so that it
puts a breakpoint" it is causing a regression in the TestStepNoDebug
test case on ubuntu 14.04 with
in - having the same binary that was failing was a big help.
> On Jan 7, 2016, at 6:16 PM, Siva Chandra wrote:
>
> This broke TestStepNoDebug, atleast on Linux when inferior is compiled
> with GCC:
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10091
&
Author: jmolenda
Date: Fri Jan 8 15:13:26 2016
New Revision: 257209
URL: http://llvm.org/viewvc/llvm-project?rev=257209&view=rev
Log:
Add support for the LEAVE x86 instruction to AssemblyParse_x86.
Modified:
lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp
Modified: lldb/
Author: jmolenda
Date: Fri Jan 8 15:40:11 2016
New Revision: 257210
URL: http://llvm.org/viewvc/llvm-project?rev=257210&view=rev
Log:
Re-apply r257117 (reverted in r257138 temporarily),
with the one change that ThreadPlanStepOut::ThreadPlanStepOut
will now only advance the return address breakpoi
Author: jmolenda
Date: Fri Jan 8 17:16:03 2016
New Revision: 257229
URL: http://llvm.org/viewvc/llvm-project?rev=257229&view=rev
Log:
In the questionmark packet ("T"), print the "threads:" and "thread-pcs:"
keys before we print the libdispatch queues keys (qname, qkind, qserialnum)
to make it eas
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Hi Ravi, sorry for taking so long to get back to you on this. It looks like a
reasonable change - let's give it a try. Sometimes with the unwinder, it can
be hard to foresee prob
Author: jmolenda
Date: Tue Jan 12 01:09:16 2016
New Revision: 257453
URL: http://llvm.org/viewvc/llvm-project?rev=257453&view=rev
Log:
Changes to lldb and debugserver to reduce extraneous memory reads
at each public stop to improve performance a bit. Most of the
information lldb needed was alrea
Author: jmolenda
Date: Tue Jan 12 22:08:10 2016
New Revision: 257569
URL: http://llvm.org/viewvc/llvm-project?rev=257569&view=rev
Log:
Add a small refinement to the qSymbol:: support in lldb.
This is a packet which allows the remote gdb stub to ask for the address
of a symbol in the process. lldb
Author: jmolenda
Date: Tue Jan 19 23:17:13 2016
New Revision: 258289
URL: http://llvm.org/viewvc/llvm-project?rev=258289&view=rev
Log:
Some 32-bit arm corefiles on darwin may have their general purpose
register set indicated by ARM_THREAD_STATE32 (value 9) instead of
the old ARM_THREAD_STATE (valu
Author: jmolenda
Date: Wed Jan 20 22:38:05 2016
New Revision: 258387
URL: http://llvm.org/viewvc/llvm-project?rev=258387&view=rev
Log:
When ObjectFileMachO reads a Mach-O file for a 32-bit arm cpu,
set the triple's "vendor" field to Apple.
We don't want to assume a vendor of Apple for all Mach-
Author: jmolenda
Date: Thu Feb 4 17:45:17 2016
New Revision: 259850
URL: http://llvm.org/viewvc/llvm-project?rev=259850&view=rev
Log:
Add a little logging to ProcessMachCore so it is easier to tell when a user
process dyld
or mach kernel binary are found, and if there are multiples of them found
Author: jmolenda
Date: Thu Feb 4 19:38:56 2016
New Revision: 259865
URL: http://llvm.org/viewvc/llvm-project?rev=259865&view=rev
Log:
Add two more addresses to check for the address of the kernel in debug mode;
also add some logging about where lldb is lookin for a kernel as it connects.
Modif
Author: jmolenda
Date: Fri Feb 5 22:55:26 2016
New Revision: 259983
URL: http://llvm.org/viewvc/llvm-project?rev=259983&view=rev
Log:
ProcessMachCore scans through the core file pages looking for a
user process dyld binary and/or a mach kernel binary image. By
default, it prefers the kernel if i
Hi Zachary, related to this bug, I was looking into clang diagnostics and there
is one that would have helped us catch this, -Wimplicit-fallthrough. It would
have issued a warning for CommandObjectThread.cpp (when built with clang, of
course) but it won't generate a warning for
case 0:
case 1:
Author: jmolenda
Date: Fri Feb 12 22:15:02 2016
New Revision: 260803
URL: http://llvm.org/viewvc/llvm-project?rev=260803&view=rev
Log:
Additional fix to my change in r259983 to handle the
case where a core file has a kernel binary and a user
process dyld in the same one. Without this, we were
alw
Author: jmolenda
Date: Mon Feb 15 22:14:33 2016
New Revision: 260930
URL: http://llvm.org/viewvc/llvm-project?rev=260930&view=rev
Log:
Add -Wimplicit-fallthrough command line option to clang in
the xcode project file to catch switch statements that have a
case that falls through unintentionally.
Author: jmolenda
Date: Mon Feb 15 22:20:56 2016
New Revision: 260932
URL: http://llvm.org/viewvc/llvm-project?rev=260932&view=rev
Log:
Fix buildbot failure because I got an include path wrong.
Modified:
lldb/trunk/source/Commands/CommandObjectMemory.cpp
Modified: lldb/trunk/source/Commands/C
Author: jmolenda
Date: Thu Feb 18 18:05:17 2016
New Revision: 261280
URL: http://llvm.org/viewvc/llvm-project?rev=261280&view=rev
Log:
This patch stops lldb from loading a .lldbinit file from the current
working directory by default -- a typical security problem that we
need to be more conservativ
Jim just headed home - if you don't mind, please revert the commit. He'll look
into it tomorrow morning.
J
> On Feb 25, 2016, at 6:51 PM, Chaoren Lin via lldb-commits
> wrote:
>
> Hi Jim,
>
> This broke a lot of our tests on Linux. E.g., "p foo" doesn't work.
> http://lab.llvm.org:8011/bui
jasonmolenda created this revision.
jasonmolenda added reviewers: tberghammer, omjavaid.
jasonmolenda added a subscriber: lldb-commits.
jasonmolenda set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.
I'm getting lldb to build for ios again and had build
Author: jmolenda
Date: Mon Feb 29 23:34:05 2016
New Revision: 262300
URL: http://llvm.org/viewvc/llvm-project?rev=262300&view=rev
Log:
Update the on-device arm specific code to match the API changes
that happened in other parts of this file so it builds cleanly
for arm again.
Modified:
lldb/t
jasonmolenda added a comment.
Good point. Let me play with the xcode project file (which I was using to do
the build) tomorrow; your solution may be the correct one, we might have some
files being built unnecessarily.
Repository:
rL LLVM
http://reviews.llvm.org/D17750
__
jasonmolenda abandoned this revision.
jasonmolenda added a comment.
Yes, taking the source/Plugins/Process/Linux directory out of the xcodeproject
file altogether makes this build on ios, I'll go with that approach.
Repository:
rL LLVM
http://reviews.llvm.org/D17750
__
Author: jmolenda
Date: Wed Mar 2 17:39:59 2016
New Revision: 262543
URL: http://llvm.org/viewvc/llvm-project?rev=262543&view=rev
Log:
Add SymbolFilePDB to xcode project file to keep it
up to date after 4262528.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xc
Author: jmolenda
Date: Wed Mar 2 18:21:32 2016
New Revision: 262566
URL: http://llvm.org/viewvc/llvm-project?rev=262566&view=rev
Log:
Don't build source/Plugins/Process/Linux in the Xcode project file.
These files won't build for ios etc arm builds of lldb and aren't
used for macosx native lldb's
Author: jmolenda
Date: Mon Mar 7 02:04:49 2016
New Revision: 262816
URL: http://llvm.org/viewvc/llvm-project?rev=262816&view=rev
Log:
Move SBLanguageRuntime.cpp from the lldb-core group to the LLDB
group to fix a build time issue.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modifi
Author: jmolenda
Date: Mon Mar 7 21:24:13 2016
New Revision: 262904
URL: http://llvm.org/viewvc/llvm-project?rev=262904&view=rev
Log:
Unbreak linux build broken by r262901
Modified:
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Modified: lldb/trunk/source/Interpreter/CommandInterpret
Author: jmolenda
Date: Mon Mar 14 23:36:11 2016
New Revision: 263529
URL: http://llvm.org/viewvc/llvm-project?rev=263529&view=rev
Log:
Bump the lldb version # in the xcode project files from
350.99.0 to 360.99.0.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/resources/LLD
Author: jmolenda
Date: Thu Mar 24 17:27:52 2016
New Revision: 264353
URL: http://llvm.org/viewvc/llvm-project?rev=264353&view=rev
Log:
Update the INFOPLIST_FILE setting in the xcode project file
so that the lldb command line binary's version #'s are updated
correctly.
Modified:
lldb/trunk/l
401 - 500 of 1819 matches
Mail list logo
