Author: jmolenda
Date: Fri Oct 6 15:43:42 2017
New Revision: 315123
URL: http://llvm.org/viewvc/llvm-project?rev=315123&view=rev
Log:
Specify the input & output results of the "Prepare Swig Bindings"
shell script phase to aid build systems.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxpr
Author: jmolenda
Date: Fri Oct 6 17:13:10 2017
New Revision: 315135
URL: http://llvm.org/viewvc/llvm-project?rev=315135&view=rev
Log:
Remove the input file specification from the
"Prepare Swig Bindings" shell script phase; it
wasn't the actual input file and could lead
to incorrect dependency ana
Author: jmolenda
Date: Mon Oct 16 20:03:44 2017
New Revision: 315966
URL: http://llvm.org/viewvc/llvm-project?rev=315966&view=rev
Log:
Committing this for Larry D'Anna:
This patch adds support for passing an arbitrary python stream
(anything inheriting from IOBase) to SetOutputFileHandle or
SetEr
Author: jmolenda
Date: Mon Oct 16 20:13:39 2017
New Revision: 315967
URL: http://llvm.org/viewvc/llvm-project?rev=315967&view=rev
Log:
Reverting r315966 - it caused a build failure on an ubuntu x android bot.
Modified:
lldb/trunk/include/lldb/API/SBDebugger.h
lldb/trunk/include/lldb/Core
Can anyone more familiar with the android SDK help out? Larry's patch in
https://reviews.llvm.org/D38829 aadds this code to File.cpp:
+File::File(void *cookie,
+ int (*readfn)(void *, char *, int),
+ int (*writefn)(void *, const char *, int),
+ int (*closefn)(void *
> On Oct 26, 2017, at 10:24 AM, Davide Italiano via lldb-commits
> wrote:
>
> On Thu, Oct 26, 2017 at 10:04 AM, Stephane Sezer via lldb-commits
> wrote:
>> Author: sas
>> Date: Thu Oct 26 10:04:20 2017
>> New Revision: 316673
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=316673&view=rev
> On Oct 26, 2017, at 3:12 PM, Davide Italiano wrote:
>
> On Thu, Oct 26, 2017 at 3:04 PM, Jason Molenda wrote:
>>
>>
>>> On Oct 26, 2017, at 10:24 AM, Davide Italiano via lldb-commits
>>> wrote:
>>>
>>> On Thu, Oct 26, 2017 at 10:04 AM, Stephane Sezer via lldb-commits
>>> wrote:
Au
> On Oct 26, 2017, at 3:21 PM, Jason Molenda wrote:
>
>
>
>> On Oct 26, 2017, at 3:12 PM, Davide Italiano wrote:
>>
>> On Thu, Oct 26, 2017 at 3:04 PM, Jason Molenda wrote:
>>>
>>>
On Oct 26, 2017, at 10:24 AM, Davide Italiano via lldb-commits
wrote:
On Thu, Oct 26
Author: jmolenda
Date: Thu Oct 26 19:21:55 2017
New Revision: 316727
URL: http://llvm.org/viewvc/llvm-project?rev=316727&view=rev
Log:
Add Arm Architecture plugin to the xcode project file.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxpro
haven't had a chance to look at the patch yet, but just to comment on one part
from Zach:
> On Oct 27, 2017, at 2:06 PM, Zachary Turner via Phabricator via lldb-commits
> wrote:
>
>
>
> Comment at: source/Target/Platform.cpp:986-991
> +if (normalized_triple.getVendorName(
Author: jmolenda
Date: Tue Oct 31 18:38:42 2017
New Revision: 317067
URL: http://llvm.org/viewvc/llvm-project?rev=317067&view=rev
Log:
Remove Sean Callanan from the CODE_OWNERS, he won't have time
to participate in lldb going forward. Jim Ingham is adopting
the areas he was responsible for.
Modi
Author: jmolenda
Date: Wed Nov 1 14:55:35 2017
New Revision: 317129
URL: http://llvm.org/viewvc/llvm-project?rev=317129&view=rev
Log:
add LibCxxTuple.cpp, LibCxxQueue.cpp to xcode project file.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.p
Author: jmolenda
Date: Wed Nov 1 19:02:56 2017
New Revision: 317180
URL: http://llvm.org/viewvc/llvm-project?rev=317180&view=rev
Log:
Commit Lawrence D'Anna's patch to change
SetOututFileHandle to work with IOBase.
I did make one change after checking with Larry --
I renamed SBDebugger::Flush to
Author: jmolenda
Date: Wed Nov 1 19:33:59 2017
New Revision: 317181
URL: http://llvm.org/viewvc/llvm-project?rev=317181&view=rev
Log:
A roll back that commit, I didn't see that Lawrence had filed
a separate phabracator with the revised change. This was his
first atttempt which broke on the b
Author: jmolenda
Date: Wed Nov 1 19:43:27 2017
New Revision: 317182
URL: http://llvm.org/viewvc/llvm-project?rev=317182&view=rev
Log:
Commit Lawrence D'Anna's patch to change
SetOututFileHandle to work with IOBase.
I did make one change after checking with Larry --
I renamed SBDebugger::Flush to
Author: jmolenda
Date: Wed Nov 1 20:17:07 2017
New Revision: 317183
URL: http://llvm.org/viewvc/llvm-project?rev=317183&view=rev
Log:
Revert r317182 for https://reviews.llvm.org/D39128
we're still failing on android. I'll ask Larry to
ask Pavel for any tips he might be able to give.
Modified:
Author: jmolenda
Date: Wed Jan 9 16:57:54 2019
New Revision: 350786
URL: http://llvm.org/viewvc/llvm-project?rev=350786&view=rev
Log:
A little cleanup / commenting on locating kernel binaries while I
was working on something else.
DynamicLoaderDarwinKernel::SearchForKernelNearPC should have had
a
Author: jmolenda
Date: Fri Jan 11 19:17:39 2019
New Revision: 350990
URL: http://llvm.org/viewvc/llvm-project?rev=350990&view=rev
Log:
Add SymbolFileBreakpad.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/
Author: jmolenda
Date: Thu Jan 17 14:26:25 2019
New Revision: 351490
URL: http://llvm.org/viewvc/llvm-project?rev=351490&view=rev
Log:
Don't run TestBreakpointThumbCodesection.py on darwin systems;
we don't use a thumb code section.
Don't run Test128BitsInteger.py on armv7k; it's not a supported
Author: jmolenda
Date: Thu Jan 24 19:01:48 2019
New Revision: 352158
URL: http://llvm.org/viewvc/llvm-project?rev=352158&view=rev
Log:
Remove a warning in DynamicLoaderDarwin::UpdateImageLoadAddress
when the binary loaded in memory has a section that we cannot find
in the on-disk version. I added
Author: jmolenda
Date: Tue Feb 5 20:08:09 2019
New Revision: 353269
URL: http://llvm.org/viewvc/llvm-project?rev=353269&view=rev
Log:
Add a warning to GDBRemoteRegisterContext (if packet logging enabled)
if the size of the g packet response was smaller than expected and is
going to be ignored.
Author: jmolenda
Date: Fri Feb 8 15:36:25 2019
New Revision: 353581
URL: http://llvm.org/viewvc/llvm-project?rev=353581&view=rev
Log:
Tiny fix spotted by static analyzer; GetPath() returns a std::string,
we get a pointer to the c-string rep and then the temporary object
is destructed and we still
Author: jmolenda
Date: Fri Feb 15 14:39:30 2019
New Revision: 354181
URL: http://llvm.org/viewvc/llvm-project?rev=354181&view=rev
Log:
Add some unconditional logging on the failure points when attaching
to a process so we'll always get messages in the console logs.
Also make the "is frontboard
Author: jmolenda
Date: Mon Feb 18 14:10:23 2019
New Revision: 354287
URL: http://llvm.org/viewvc/llvm-project?rev=354287&view=rev
Log:
Clean up an unused variable warning when building this for
mac native.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm
Modified: lldb/tru
Author: jmolenda
Date: Mon Feb 18 14:13:34 2019
New Revision: 354288
URL: http://llvm.org/viewvc/llvm-project?rev=354288&view=rev
Log:
Ah, misunderstood Jonas' feedback - fix this so we'll
do the right thing when both API are available. We
want to try both of them if the first one fails.
Modifie
Author: jmolenda
Date: Mon Feb 18 14:18:11 2019
New Revision: 354289
URL: http://llvm.org/viewvc/llvm-project?rev=354289&view=rev
Log:
One more fix while I'm looking at this - remove the
unused IsSBProcess method, and have IsFBSProcess
return false if we don't have API that we can use to
make tha
Author: jmolenda
Date: Wed Feb 27 17:26:01 2019
New Revision: 355063
URL: http://llvm.org/viewvc/llvm-project?rev=355063&view=rev
Log:
Move Symbols.cpp files.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/
Author: jmolenda
Date: Thu Feb 28 15:37:28 2019
New Revision: 355155
URL: http://llvm.org/viewvc/llvm-project?rev=355155&view=rev
Log:
Symbols.cpp in unittest moved too.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.
Author: jmolenda
Date: Thu Feb 28 19:24:59 2019
New Revision: 355169
URL: http://llvm.org/viewvc/llvm-project?rev=355169&view=rev
Log:
Increase timeout in Symbols::DownloadObjectAndSymbolFile
from 30 seconds to 120 seconds. We've seen cases where
this symbol lookup can exceed 30 seconds for peop
Author: jmolenda
Date: Thu Feb 28 19:34:51 2019
New Revision: 355170
URL: http://llvm.org/viewvc/llvm-project?rev=355170&view=rev
Log:
Update com.apple.diagnosticd.diagnostic entitlement
name to the newer com.apple.private.logging.diagnostic.
Modified:
lldb/trunk/tools/debugserver/source/d
Author: jmolenda
Date: Tue Mar 5 11:43:56 2019
New Revision: 355435
URL: http://llvm.org/viewvc/llvm-project?rev=355435&view=rev
Log:
Add logging to SBCompileUnit::GetNumLineEntries.
Modified:
lldb/trunk/source/API/SBCompileUnit.cpp
Modified: lldb/trunk/source/API/SBCompileUnit.cpp
URL:
ht
Author: jmolenda
Date: Tue Mar 5 14:17:47 2019
New Revision: 355449
URL: http://llvm.org/viewvc/llvm-project?rev=355449&view=rev
Log:
Revert logging addition to SBCompileUnit::GetNumLineEntries,
causing lldb-mi testsuite failures?
Modified:
lldb/trunk/source/API/SBCompileUnit.cpp
Modified
Yeah, I realized that as I re-read the diff after reverting. :) I was doing
all my work & testing with the api log enabled.
> On Mar 5, 2019, at 2:21 PM, Davide Italiano wrote:
>
> You should check whether log is enabled, I think.
>
> On Tue, Mar 5, 2019 at 2:16 PM Jas
Author: jmolenda
Date: Tue Mar 5 18:32:45 2019
New Revision: 355473
URL: http://llvm.org/viewvc/llvm-project?rev=355473&view=rev
Log:
Re-commit logging for SBCompileUnit::GetNumLineEntries.
Modified:
lldb/trunk/source/API/SBCompileUnit.cpp
Modified: lldb/trunk/source/API/SBCompileUnit.cpp
U
Author: jmolenda
Date: Tue Mar 5 18:45:27 2019
New Revision: 355476
URL: http://llvm.org/viewvc/llvm-project?rev=355476&view=rev
Log:
Change the scanning algorithm in
DynamicLoaderDarwinKernel::SearchForKernelNearPC.
Currently when lldb might be doing a kernel debug session, it scans through
mem
Author: jmolenda
Date: Wed Mar 6 15:47:52 2019
New Revision: 355565
URL: http://llvm.org/viewvc/llvm-project?rev=355565&view=rev
Log:
Remove the warning in
DynamicLoaderDarwinKernel::KextImageInfo::LoadImageUsingMemoryModule
which would list every kext that failed to load when doing kernel
debugg
Author: jmolenda
Date: Wed Mar 6 19:16:45 2019
New Revision: 355578
URL: http://llvm.org/viewvc/llvm-project?rev=355578&view=rev
Log:
When disassembling Aarch64 target and vendor Apple, set the cpu to
"apple-latest" which llvm uses to indicate the newest supported ISA.
Add a unit test; I'm only t
Author: jmolenda
Date: Thu Mar 7 20:18:21 2019
New Revision: 355661
URL: http://llvm.org/viewvc/llvm-project?rev=355661&view=rev
Log:
Add ASAN llvm build directory variants to
get_llvm_bin_dirs().
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py
Modified: lldb/trunk/packages/Py
Author: jmolenda
Date: Fri Mar 8 16:04:24 2019
New Revision: 355761
URL: http://llvm.org/viewvc/llvm-project?rev=355761&view=rev
Log:
Add parens to force the order of operations in an expression trying
to do "databuffer + offset" so that we don't overflow the uint64_t's
we're using for addresses
Author: jmolenda
Date: Tue Mar 12 12:42:34 2019
New Revision: 355958
URL: http://llvm.org/viewvc/llvm-project?rev=355958&view=rev
Log:
Rework how lldb warngs about kexts that failed to load in a
darwin kernel debug session.
Originally, the kext name & uuid were emitted in the middle of the
kext-
Author: jmolenda
Date: Wed Mar 13 11:24:42 2019
New Revision: 356073
URL: http://llvm.org/viewvc/llvm-project?rev=356073&view=rev
Log:
Update.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm-project/lld
Author: jmolenda
Date: Wed Mar 13 16:34:20 2019
New Revision: 356108
URL: http://llvm.org/viewvc/llvm-project?rev=356108&view=rev
Log:
Reorder the operations in
DynamicLoaderDarwinKernel::KextImageInfo::LoadImageUsingMemoryModule a
bit so that we only read the binaries out of memory once we've
det
Author: jmolenda
Date: Mon Mar 18 14:39:54 2019
New Revision: 356416
URL: http://llvm.org/viewvc/llvm-project?rev=356416&view=rev
Log:
A target definition file that may work for
Aarch32 Cortex-M target processor debugging.
Added:
lldb/trunk/examples/python/armv7_cortex_m_target_defintion.
Author: jmolenda
Date: Wed Mar 20 15:57:33 2019
New Revision: 356625
URL: http://llvm.org/viewvc/llvm-project?rev=356625&view=rev
Log:
Update DWARF files.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm
Author: jmolenda
Date: Wed Mar 20 15:59:16 2019
New Revision: 356626
URL: http://llvm.org/viewvc/llvm-project?rev=356626&view=rev
Log:
Change the logging on ptrace(PT_KILL) in MachProcess::Kill to log
if LOG_PROCESS is enabled or if there was an error making that call.
Modified:
lldb/trunk
Author: jmolenda
Date: Tue Apr 2 18:16:54 2019
New Revision: 357553
URL: http://llvm.org/viewvc/llvm-project?rev=357553&view=rev
Log:
Avoid macro redefinition error if HAVE_LIBCOMPRESSION
is already defined.
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient
Author: jmolenda
Date: Mon Apr 8 16:03:02 2019
New Revision: 357955
URL: http://llvm.org/viewvc/llvm-project?rev=357955&view=rev
Log:
Rename Target::GetSharedModule to Target::GetOrCreateModule.
Add a flag to control whether the ModulesDidLoad notification is
called when a module is added. If t
Author: jmolenda
Date: Mon Apr 22 15:42:29 2019
New Revision: 358929
URL: http://llvm.org/viewvc/llvm-project?rev=358929&view=rev
Log:
Fix a bug in my change to ModulesDidLoad in r357955.
In the process of hoisting the LoadScriptingResourceForModule
out of Target::ModuleAdded and into Target::Modu
Author: jmolenda
Date: Mon Apr 22 18:02:51 2019
New Revision: 358938
URL: http://llvm.org/viewvc/llvm-project?rev=358938&view=rev
Log:
Add a small check to PlatformDarwin::LoadScriptingResourceForModule
which reads the python files in a dSYM bundle, to check that the
SymbolFile is actually a dSYM
Author: jmolenda
Date: Mon Apr 22 18:13:27 2019
New Revision: 358939
URL: http://llvm.org/viewvc/llvm-project?rev=358939&view=rev
Log:
One small tweak to LocateExecutableScriptingResources - I
was still stat'ing the possibly-dSYM FileSpec before I
(more cheaply) checked the filepath for telltale d
Author: jmolenda
Date: Wed Oct 5 17:37:01 2016
New Revision: 283404
URL: http://llvm.org/viewvc/llvm-project?rev=283404&view=rev
Log:
Add i386/x86_64 tests of the eh_frame augmentation code in the x86
insturction profiling. Add a test that verifies that we reject a
32-bit only instruction in 64-
Author: jmolenda
Date: Mon Oct 10 21:24:00 2016
New Revision: 283847
URL: http://llvm.org/viewvc/llvm-project?rev=283847&view=rev
Log:
Add a first unit test for the arm64 instruction profiled unwind
plan generator.
Fix a small bug in EmulateInstructionARM64::GetFramePointerRegister
which was retu
Author: jmolenda
Date: Mon Oct 10 22:44:48 2016
New Revision: 283849
URL: http://llvm.org/viewvc/llvm-project?rev=283849&view=rev
Log:
Add a second, more complicated, arm64 example program to
the arm64 assembly unwind tests.
Modified:
lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm6
Hi Tamas, I'm writing some unit tests for the unwind source generators - x86
last week, arm64 this week, and I noticed with this prologue:
JavaScriptCore`JSC::B3::reduceDoubleToFloat:
0x192b45c0c <+0>: 0x6db923e9 stpd9, d8, [sp, #-0x70]!
0x192b45c10 <+4>: 0xa9016ffc stpx28,
Author: jmolenda
Date: Tue Oct 11 21:46:22 2016
New Revision: 283966
URL: http://llvm.org/viewvc/llvm-project?rev=283966&view=rev
Log:
Add a simple frameless function test case to the arm64 unwind unit tests
with return statements in the body of the function.
Modified:
lldb/trunk/unittests/Un
Author: jmolenda
Date: Tue Oct 11 22:53:01 2016
New Revision: 283969
URL: http://llvm.org/viewvc/llvm-project?rev=283969&view=rev
Log:
Add an arm64 unit test where the function saves x20 in the
prologue, then loads & stores x20 on the stack from a different
location in the middle of the function,
Hi Tamas, sorry for that last email being a mess, I was doing something else
while writing it and only saw how unclear it was after I sent it. You
understood everything I was trying to say.
I looked at the AAPCS64 again. It says v8-v15 are callee saved, but says,
"Additionally, only the botto
Yeah, it's incorrectly grabbing the stack pointer reg number (31) from the Rn
bits and using that as the register # being saved, instead of the Rt and Rt2
register numbers, and saying that v31 is being pushed twice. It's an easy bug
in EmulateInstructionARM64::EmulateLDPSTP but fixing that just
But if I attach to an arm64 core file, where lldb is using it's own register
definitions, then lldb has no idea what s0 is.
My concern about defining these subset registers in RegisterInfos_arm64.h is
that the offsets are in a target-endian register context buffer. My example
below was littl
Author: jmolenda
Date: Wed Oct 19 18:38:38 2016
New Revision: 284666
URL: http://llvm.org/viewvc/llvm-project?rev=284666&view=rev
Log:
Add lldb register definitions for w0-w28, s0-s31, and d0-d31 to
RegisterInfos_arm64.h. These register definitions include the
offset into the register context, wh
Author: jmolenda
Date: Thu Oct 20 21:32:08 2016
New Revision: 284799
URL: http://llvm.org/viewvc/llvm-project?rev=284799&view=rev
Log:
Guard GetEscapedHostname against a nullptr hostname.
This can happen if you debug an iOS corefile on
a mac, where PlatformPOSIX::GetHostname ends up
not providing
Author: jmolenda
Date: Fri Oct 21 18:45:07 2016
New Revision: 284900
URL: http://llvm.org/viewvc/llvm-project?rev=284900&view=rev
Log:
Add some additional logging to
DynamicLoaderDarwinKernel::CheckForKernelImageAtAddress to debug
corefiles that may not be correctly formed.
Modified:
lld
jasonmolenda added a comment.
Hi Tamas, sorry for not replying earlier, something urgent came up that I
needed to look at.
Thanks for the review. I agree with using your existing arm64 register enums
in lldb-arm64-register-enums.h. I'd like to remove the enums in
RegisterInfos_arm64.h instea
Author: jmolenda
Date: Tue Oct 25 23:48:41 2016
New Revision: 285172
URL: http://llvm.org/viewvc/llvm-project?rev=285172&view=rev
Log:
Enable the use of the new dyld SPI on the current
generation macosx/ios/tvos/watchos.
Modified:
lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoa
jasonmolenda updated this revision to Diff 75977.
jasonmolenda added a comment.
I believe this rewrite of the original patch addresses Tamas' feedback (thanks
Tamas!) I dropped a lot of the changes in the original; I switch
EmulateInstructionARM64 from using DWARF register numbering to use LLDB
Author: jmolenda
Date: Thu Oct 27 18:52:46 2016
New Revision: 285369
URL: http://llvm.org/viewvc/llvm-project?rev=285369&view=rev
Log:
Check that we got back an object from MakeFunctionCaller
before we call through it.
Modified:
lldb/trunk/source/Plugins/SystemRuntime/MacOSX/AppleGetItem
Author: jmolenda
Date: Mon Oct 31 20:26:54 2016
New Revision: 285662
URL: http://llvm.org/viewvc/llvm-project?rev=285662&view=rev
Log:
Fix a bug where the EmulateInstructionARM64 handling of STP/LDP instructions
for floating point registers was not recording them correctly. I needed to
change the
jasonmolenda closed this revision.
jasonmolenda added a comment.
Committed in r285662.
Repository:
rL LLVM
https://reviews.llvm.org/D25864
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
> On Oct 31, 2016, at 9:35 AM, Tamas Berghammer wrote:
>
> tberghammer accepted this revision.
> tberghammer added a comment.
> This revision is now accepted and ready to land.
>
> The patch generally looks good to me. I added a few high level thought about
> register context but they are clea
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Yes it was, thanks for catching that! Please commit.
Repository:
rL LLVM
https://reviews.llvm.org/D26260
___
lldb-commits mailing
Is anyone else seeing a hang in
GDBRemoteCommunicationClientTest.TestPacketSpeedJSON when running the unit
tests? It was a new test added in r285602, it always hangs for me on my
system, a macOS 10.12.something machine. Attaching to it with lldb, it's
waiting to get a packet down in
thread #
jasonmolenda created this revision.
jasonmolenda added reviewers: labath, tberghammer.
jasonmolenda added a subscriber: lldb-commits.
jasonmolenda set the repository for this revision to rL LLVM.
This is a minor change and maybe more of a personal preference, but
UnwindAssemblyInstEmulation marks
jasonmolenda added a comment.
Ah, interesting point, I didn't think of that. However, this touches on
another thing I've been thinking about as I look at the assembly inspection
unwind plan generators. In the x86 unwind inspector, I've hardcoded the
SysV-x86_64 ABI and the unwind plan generat
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Thanks Vedant, we always build armv7/arm64/x86 llvm targets with the xcode
style lldb/llvm builds so I hadn't seen this problem. Please commit.
https://reviews.llvm.org/D26338
Author: jmolenda
Date: Tue Nov 8 21:42:12 2016
New Revision: 286335
URL: http://llvm.org/viewvc/llvm-project?rev=286335&view=rev
Log:
When deciding whether to use the source remapping dictionary from
a dSYM per-uuid plist, only use it when the DBGVersion key has a
value of 2 or greater.
Mo
Author: jmolenda
Date: Mon Nov 14 19:41:27 2016
New Revision: 286926
URL: http://llvm.org/viewvc/llvm-project?rev=286926&view=rev
Log:
Change the kernel searching code to not go through the
memory cache subsystem so we're reading only the 4 bytes
needed to check for the magic word at the start of
Author: jmolenda
Date: Wed Nov 30 17:00:52 2016
New Revision: 288284
URL: http://llvm.org/viewvc/llvm-project?rev=288284&view=rev
Log:
Add another address to look for the kernel load addr in
DynamicLoaderDarwinKernel::SearchForKernelWithDebugHints
on 32-bit devices.
Modified:
lldb/trunk/s
Author: jmolenda
Date: Wed Dec 7 20:02:45 2016
New Revision: 289016
URL: http://llvm.org/viewvc/llvm-project?rev=289016&view=rev
Log:
Set the address size based on the target's arch instead
of using the address of the all_image_infos struct.
Modified:
lldb/trunk/source/Plugins/DynamicLoad
Author: jmolenda
Date: Wed Dec 7 23:12:45 2016
New Revision: 289023
URL: http://llvm.org/viewvc/llvm-project?rev=289023&view=rev
Log:
Increase timeout for Frontboard app launch request from 9 to 20 seconds
to match other timeouts.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/MachProc
Author: jmolenda
Date: Thu Dec 8 00:27:29 2016
New Revision: 289026
URL: http://llvm.org/viewvc/llvm-project?rev=289026&view=rev
Log:
When we interrupt a process, it was possible or the thread names
to not be set by Process::WillPublicStop() so the driver won't get
access to them. The fix is str
Author: jmolenda
Date: Thu Dec 8 17:34:56 2016
New Revision: 289155
URL: http://llvm.org/viewvc/llvm-project?rev=289155&view=rev
Log:
Clean up the new TestInterruptThreadNames test a bit.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py
Mo
Author: jmolenda
Date: Mon Dec 12 23:54:17 2016
New Revision: 289518
URL: http://llvm.org/viewvc/llvm-project?rev=289518&view=rev
Log:
Touch-up the markup of the DarwinLog.md documentation.
Modified:
lldb/trunk/docs/structured_data/DarwinLog.md
Modified: lldb/trunk/docs/structured_data/Darwi
Author: jmolenda
Date: Mon Dec 12 23:59:24 2016
New Revision: 289520
URL: http://llvm.org/viewvc/llvm-project?rev=289520&view=rev
Log:
Small tweaks to the markup in StructuredDataPlugins.
Modified:
lldb/trunk/docs/structured_data/StructuredDataPlugins.md
Modified: lldb/trunk/docs/structured_
Author: jmolenda
Date: Thu Dec 15 20:48:39 2016
New Revision: 289913
URL: http://llvm.org/viewvc/llvm-project?rev=289913&view=rev
Log:
Fix a bug when using a StructuredData darwin-log plugin
where we would insert a breakpoint into a system library
but never remove it, so the second time we ran the
Author: jmolenda
Date: Mon Dec 19 22:54:04 2016
New Revision: 290163
URL: http://llvm.org/viewvc/llvm-project?rev=290163&view=rev
Log:
Change the timeout in CallBoardSystemServiceOpenApplication to
30 seconds to match the old springboard timeout; the launcher
should time out before that and we wi
Author: jmolenda
Date: Tue Jan 3 18:01:25 2017
New Revision: 290917
URL: http://llvm.org/viewvc/llvm-project?rev=290917&view=rev
Log:
Remove SymbolFilePDBTests.cpp from the list of tests to include in the
lldb-gtest binary that xcode builds for -scheme lldb-gtest; these tests
won't run on macosx
Author: jmolenda
Date: Wed Jan 18 18:20:29 2017
New Revision: 292454
URL: http://llvm.org/viewvc/llvm-project?rev=292454&view=rev
Log:
Fix a problem with the new dyld interface code -- when a new process
starts up, we need to clear the target's image list and only add
the binaries into the target
Author: jmolenda
Date: Fri Jan 20 19:17:36 2017
New Revision: 292696
URL: http://llvm.org/viewvc/llvm-project?rev=292696&view=rev
Log:
Add a catch-all line for detecting dyld in the inferior process
shlibs so we don't miss dyld.
Modified:
lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/
Author: jmolenda
Date: Mon Jan 23 22:16:03 2017
New Revision: 292880
URL: http://llvm.org/viewvc/llvm-project?rev=292880&view=rev
Log:
weak-link debugserver against the LoggingSupport framework;
systems without this framework will not get a link error.
Modified:
lldb/trunk/tools/debugserve
Author: jmolenda
Date: Mon Jan 23 22:43:40 2017
New Revision: 292882
URL: http://llvm.org/viewvc/llvm-project?rev=292882&view=rev
Log:
Enable compression capability in debugserver for all of ios/watchos/tvos
environments.
Modified:
lldb/trunk/tools/debugserver/source/RNBRemote.cpp
Modifie
Author: jmolenda
Date: Mon Jan 23 23:06:14 2017
New Revision: 292884
URL: http://llvm.org/viewvc/llvm-project?rev=292884&view=rev
Log:
Prefer lzfse if it is an available compression method (this was
defaulting to zlib previously).
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRe
Author: jmolenda
Date: Tue Jan 24 00:09:06 2017
New Revision: 292890
URL: http://llvm.org/viewvc/llvm-project?rev=292890&view=rev
Log:
Fix the last commit; compression was being enabled on mac native
which led to
ERROR: test_auxv_chunked_reads_work_debugserver
(tools/lldb-server/TestGdbRemoteAux
Author: jmolenda
Date: Tue Jan 24 19:41:48 2017
New Revision: 293002
URL: http://llvm.org/viewvc/llvm-project?rev=293002&view=rev
Log:
Jim unintentionally had the gdb-format specifiers falling through
after r276132 so that 'x/4b' would print out a series of 4 8-byte
quantities. Fix that, add a te
Author: jmolenda
Date: Wed Jan 25 20:13:43 2017
New Revision: 293135
URL: http://llvm.org/viewvc/llvm-project?rev=293135&view=rev
Log:
Instead of weak-linking against LoggingSupport framework (which
requires that this private framework be available - and it is not
available earlier than macOS 10.1
Author: jmolenda
Date: Wed Jan 25 20:27:35 2017
New Revision: 293140
URL: http://llvm.org/viewvc/llvm-project?rev=293140&view=rev
Log:
Add Foundation to the debugserver-mini dependencies;
debugserver-mini can use Foundation.
Modified:
lldb/trunk/tools/debugserver/debugserver.xcodeproj/projec
Author: jmolenda
Date: Fri Jan 27 20:54:10 2017
New Revision: 293366
URL: http://llvm.org/viewvc/llvm-project?rev=293366&view=rev
Log:
One of the changes Jim made in r286288 (cleaning up the stop print
header line, backtrace output) was to remove the current pc value
from frames where we have sour
Author: jmolenda
Date: Tue Jan 31 22:23:15 2017
New Revision: 293742
URL: http://llvm.org/viewvc/llvm-project?rev=293742&view=rev
Log:
When I added the use of the new compression framework (present in
Mac OS X 10.11, El Capitan, released c. Oct 2015) I conditionalized
the use of the framework on "
You need some break;s.
-const char *lldb_private::GetVoteAsCString(Vote vote) {
- switch (vote) {
- case eVoteNo:
-return "no";
- case eVoteNoOpinion:
-return "no opinion";
- case eVoteYes:
-return "yes";
- }
- return "invalid";
-}
+template <> struct format_provider {
+ stat
Author: jmolenda
Date: Wed Feb 1 16:41:38 2017
New Revision: 293831
URL: http://llvm.org/viewvc/llvm-project?rev=293831&view=rev
Log:
Update xcodeproj to track ConvertEnum.cpp et al being removed.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/projec
Author: jmolenda
Date: Wed Feb 1 21:02:51 2017
New Revision: 293858
URL: http://llvm.org/viewvc/llvm-project?rev=293858&view=rev
Log:
Add logging to SBThread::GetInfoItemByPathAsString to
print the path being requested.
Change the GetInfoItemByPathAsString docuemtnation in
the .i file to use do
201 - 300 of 1925 matches
Mail list logo
