jasonmolenda wrote:
Ah, I misunderstood what the nature of the failure was. I tried running the
shell test, and it's failing for different reasons. I almost never touch shell
tests, I find them really hard to debug so I'm not sure what the problem is.
If I run it by hand,
```
(lldb) settin
jasonmolenda wrote:
maybe the shell test is building without debug info, I am surprised to see
assembly there. If I build it like that and run it by hand,
```
(lldb) settings set platform.plugin.darwin.ignored-exceptions
EXC_BAD_INSTRUCTION
(lldb) b sigill_handler
Breakpoint 1: where = a.out`
Author: Jason Molenda
Date: 2021-12-09T22:53:01-08:00
New Revision: 223e8ca02616dd9353da230d95589954927025c9
URL:
https://github.com/llvm/llvm-project/commit/223e8ca02616dd9353da230d95589954927025c9
DIFF:
https://github.com/llvm/llvm-project/commit/223e8ca02616dd9353da230d95589954927025c9.diff
Author: Jason Molenda
Date: 2021-12-10T01:04:07-08:00
New Revision: efdac16b382b86358dba60f3a759c64a0fc446fc
URL:
https://github.com/llvm/llvm-project/commit/efdac16b382b86358dba60f3a759c64a0fc446fc
DIFF:
https://github.com/llvm/llvm-project/commit/efdac16b382b86358dba60f3a759c64a0fc446fc.diff
Author: Jason Molenda
Date: 2021-12-13T13:21:56-08:00
New Revision: f2120328e81879bf14d2a5c381749a11577fa304
URL:
https://github.com/llvm/llvm-project/commit/f2120328e81879bf14d2a5c381749a11577fa304
DIFF:
https://github.com/llvm/llvm-project/commit/f2120328e81879bf14d2a5c381749a11577fa304.diff
Author: Jason Molenda
Date: 2021-12-22T00:02:27-08:00
New Revision: 682532ca575b8b6c4d3e2104a7526743ff9446a9
URL:
https://github.com/llvm/llvm-project/commit/682532ca575b8b6c4d3e2104a7526743ff9446a9
DIFF:
https://github.com/llvm/llvm-project/commit/682532ca575b8b6c4d3e2104a7526743ff9446a9.diff
Author: Jason Molenda
Date: 2021-12-23T15:20:50-08:00
New Revision: 8a26ba6a02f1319ddaca017bbda81c2b82fb4050
URL:
https://github.com/llvm/llvm-project/commit/8a26ba6a02f1319ddaca017bbda81c2b82fb4050
DIFF:
https://github.com/llvm/llvm-project/commit/8a26ba6a02f1319ddaca017bbda81c2b82fb4050.diff
Author: Jason Molenda
Date: 2022-02-04T23:53:27-08:00
New Revision: a37c38176a5a1f797e6bc2b8771be017394e8e32
URL:
https://github.com/llvm/llvm-project/commit/a37c38176a5a1f797e6bc2b8771be017394e8e32
DIFF:
https://github.com/llvm/llvm-project/commit/a37c38176a5a1f797e6bc2b8771be017394e8e32.diff
Author: Jason Molenda
Date: 2022-02-07T23:51:46-08:00
New Revision: 9b1cb0e171a35bf9034663566bb3400f668769b0
URL:
https://github.com/llvm/llvm-project/commit/9b1cb0e171a35bf9034663566bb3400f668769b0
DIFF:
https://github.com/llvm/llvm-project/commit/9b1cb0e171a35bf9034663566bb3400f668769b0.diff
Author: Jason Molenda
Date: 2022-02-14T11:12:58-08:00
New Revision: 4a394367c124172dff26ef5042ecd6fa666a6e07
URL:
https://github.com/llvm/llvm-project/commit/4a394367c124172dff26ef5042ecd6fa666a6e07
DIFF:
https://github.com/llvm/llvm-project/commit/4a394367c124172dff26ef5042ecd6fa666a6e07.diff
Author: Jason Molenda
Date: 2022-02-25T00:55:54-08:00
New Revision: cd2ba23efb3e282d86cf7a94952f0bf61677fa7f
URL:
https://github.com/llvm/llvm-project/commit/cd2ba23efb3e282d86cf7a94952f0bf61677fa7f
DIFF:
https://github.com/llvm/llvm-project/commit/cd2ba23efb3e282d86cf7a94952f0bf61677fa7f.diff
Author: Jason Molenda
Date: 2022-03-02T11:17:48-08:00
New Revision: daba82362228b4aa460c26079c028ebf832066fd
URL:
https://github.com/llvm/llvm-project/commit/daba82362228b4aa460c26079c028ebf832066fd
DIFF:
https://github.com/llvm/llvm-project/commit/daba82362228b4aa460c26079c028ebf832066fd.diff
Author: Jason Molenda
Date: 2022-07-08T15:13:49-07:00
New Revision: 77a38f6839980bfac61babb40d83772c51427011
URL:
https://github.com/llvm/llvm-project/commit/77a38f6839980bfac61babb40d83772c51427011
DIFF:
https://github.com/llvm/llvm-project/commit/77a38f6839980bfac61babb40d83772c51427011.diff
Author: Jason Molenda
Date: 2022-07-14T00:56:14-07:00
New Revision: ac49e9021919d2a356dd10b39888f168736a43b0
URL:
https://github.com/llvm/llvm-project/commit/ac49e9021919d2a356dd10b39888f168736a43b0
DIFF:
https://github.com/llvm/llvm-project/commit/ac49e9021919d2a356dd10b39888f168736a43b0.diff
Author: Jason Molenda
Date: 2022-07-19T01:40:40-07:00
New Revision: 2149455cdc6f5b0d418a715fb3a8a0e4ecccb3aa
URL:
https://github.com/llvm/llvm-project/commit/2149455cdc6f5b0d418a715fb3a8a0e4ecccb3aa
DIFF:
https://github.com/llvm/llvm-project/commit/2149455cdc6f5b0d418a715fb3a8a0e4ecccb3aa.diff
Author: Jason Molenda
Date: 2022-08-02T13:49:30-07:00
New Revision: d8879fba8825b9799166ba0ea552d4027bfb8ad1
URL:
https://github.com/llvm/llvm-project/commit/d8879fba8825b9799166ba0ea552d4027bfb8ad1
DIFF:
https://github.com/llvm/llvm-project/commit/d8879fba8825b9799166ba0ea552d4027bfb8ad1.diff
Author: Jason Molenda
Date: 2022-08-02T13:53:34-07:00
New Revision: 803386da2ff80f0a5e75d2baee6dfa79d9d8d26f
URL:
https://github.com/llvm/llvm-project/commit/803386da2ff80f0a5e75d2baee6dfa79d9d8d26f
DIFF:
https://github.com/llvm/llvm-project/commit/803386da2ff80f0a5e75d2baee6dfa79d9d8d26f.diff
Author: Jason Molenda
Date: 2022-08-02T14:14:16-07:00
New Revision: 96d12187b3d28f63d29802a7af49dfe53cc306f3
URL:
https://github.com/llvm/llvm-project/commit/96d12187b3d28f63d29802a7af49dfe53cc306f3
DIFF:
https://github.com/llvm/llvm-project/commit/96d12187b3d28f63d29802a7af49dfe53cc306f3.diff
Author: Jason Molenda
Date: 2022-08-02T14:24:11-07:00
New Revision: 318454a8e5fce57a92573f42e39f148adcedc5d4
URL:
https://github.com/llvm/llvm-project/commit/318454a8e5fce57a92573f42e39f148adcedc5d4
DIFF:
https://github.com/llvm/llvm-project/commit/318454a8e5fce57a92573f42e39f148adcedc5d4.diff
Author: Jason Molenda
Date: 2022-08-02T16:28:10-07:00
New Revision: 63725ebc182d7955c569be94b845b93d14374def
URL:
https://github.com/llvm/llvm-project/commit/63725ebc182d7955c569be94b845b93d14374def
DIFF:
https://github.com/llvm/llvm-project/commit/63725ebc182d7955c569be94b845b93d14374def.diff
https://github.com/jasonmolenda approved this pull request.
LGTM. debugserver never expects libdyld's API (to iterate over the binary
images in a process) to return the same binary multiple times, and lldb won't
handle that well if we pass that behavior along. Eliminating the incorrect
dupli
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/78379
In https://reviews.llvm.org/D151292 I added the ability to track address masks
separately for high and low memory addresses, a capability of AArch64. I did
my testing with manual address mask settings (via
jasonmolenda wrote:
To test this one, I need to move this old patch
https://reviews.llvm.org/D155905 over to a github PR and land it; it will add
SBProcess methods to set, get, and test the address mask settings the same way
that we get them from a gdb-remote stub or a corefile. That patch is
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/78389
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1180,7 +1180,7 @@ bool
GDBRemoteCommunicationClient::GetDefaultThreadId(lldb::tid_t &tid) {
static void ParseOSType(llvm::StringRef value, std::string &os_name,
std::string &environment) {
if (value.equals("iossimulator") || value.equals("tvossimu
https://github.com/jasonmolenda approved this pull request.
lgtm.
https://github.com/llvm/llvm-project/pull/78389
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/78379
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1048,74 +1048,103 @@ DynamicLoaderDarwin::GetThreadLocalData(const
lldb::ModuleSP module_sp,
std::lock_guard guard(m_mutex);
+ lldb_private::Address tls_addr;
+ if (!module_sp->ResolveFileAddress(tls_file_addr, tls_addr))
+return LLDB_INVALID_ADDRESS;
+
+ Target
@@ -1048,74 +1048,103 @@ DynamicLoaderDarwin::GetThreadLocalData(const
lldb::ModuleSP module_sp,
std::lock_guard guard(m_mutex);
+ lldb_private::Address tls_addr;
+ if (!module_sp->ResolveFileAddress(tls_file_addr, tls_addr))
+return LLDB_INVALID_ADDRESS;
+
+ Target
https://github.com/jasonmolenda approved this pull request.
https://github.com/llvm/llvm-project/pull/77988
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -836,36 +834,18 @@ Status PlatformDarwinKernel::GetSharedModuleKernel(
module_sp.reset(new Module(kern_spec));
if (module_sp && module_sp->GetObjectFile() &&
module_sp->MatchesModuleSpec(kern_spec)) {
-// module_sp is an actual kernel binary we
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/78652
>From 0936638373f9ae720de0ca9f50d3e5436897254b Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 18 Jan 2024 16:25:01 -0800
Subject: [PATCH 1/2] Clean up PlatformDarwinKernel::GetSharedModule, docuemnt
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/78652
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-01-19T17:03:19-08:00
New Revision: bd3838ff6b4310fb8ff68649ef87e5e962bab1fd
URL:
https://github.com/llvm/llvm-project/commit/bd3838ff6b4310fb8ff68649ef87e5e962bab1fd
DIFF:
https://github.com/llvm/llvm-project/commit/bd3838ff6b4310fb8ff68649ef87e5e962bab1fd.diff
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/79385
In `[lldb] [mostly NFC] Large WP foundation: WatchpointResources (#68845)` I
added a new template StopPointSiteList to combine WatchpointResourceList and
BreakpointSiteList. But I didn't remove the now-unu
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/79385
>From 229ea2a0311c7c0ecd8554016d3827f8c8ae6c5f Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 24 Jan 2024 14:45:41 -0800
Subject: [PATCH 1/2] [lldb] [NFC] Remove unused WatchpointResourceList class
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/79388
None
>From 229ea2a0311c7c0ecd8554016d3827f8c8ae6c5f Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 24 Jan 2024 14:45:41 -0800
Subject: [PATCH 1/2] [lldb] [NFC] Remove unused WatchpointResourceList
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/79388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/79389
I originally thought to try to guesstimate the hardware watchpoint index number
that a Resource was associated with, but gdb remote serial protocol doesn't
give us the hardware register index used so it was
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/79385
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/79389
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/79517
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
@mordante I'm seeing failures on the macOS bots (and on my desktop) with
TestDataFormatterLibcxxChrono.py, the test
self.expect(
"frame variable ss_neg_date_time",
substrs=[
"ss_neg_date_time = date/time=-32767-01-01T00:00:00Z
Author: Jason Molenda
Date: 2024-01-25T16:30:14-08:00
New Revision: ba45ad160e3f329aeb02c19eaf18af27fa423d85
URL:
https://github.com/llvm/llvm-project/commit/ba45ad160e3f329aeb02c19eaf18af27fa423d85
DIFF:
https://github.com/llvm/llvm-project/commit/ba45ad160e3f329aeb02c19eaf18af27fa423d85.diff
jasonmolenda wrote:
I commented out the two tests that are failing on macOS temporarily so you'd
have a chance to look at this. If you don't have access to macOS (I assume
this is working on Linux or whatever), @Michael137 or I can look into it.
Thanks.
```
commit ba45ad160e3f329aeb02c19e
Author: Jason Molenda
Date: 2024-01-29T10:43:33-08:00
New Revision: 61384850c5950b8c5ee0abd75982f5cad8f98536
URL:
https://github.com/llvm/llvm-project/commit/61384850c5950b8c5ee0abd75982f5cad8f98536
DIFF:
https://github.com/llvm/llvm-project/commit/61384850c5950b8c5ee0abd75982f5cad8f98536.diff
Author: Jason Molenda
Date: 2024-01-29T11:01:08-08:00
New Revision: 547c395b279a93357082ac06cf3e8fe37ebfc3fe
URL:
https://github.com/llvm/llvm-project/commit/547c395b279a93357082ac06cf3e8fe37ebfc3fe
DIFF:
https://github.com/llvm/llvm-project/commit/547c395b279a93357082ac06cf3e8fe37ebfc3fe.diff
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/79962
This patch is the next piece of work in my Large Watchpoint proposal,
https://discourse.llvm.org/t/rfc-large-watchpoint-support-in-lldb/72116
This patch breaks a user's watchpoint into one or more Watchpoin
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/79962
>From 24cf5649fee074e9f6c72c7f768999ce4253b268 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 30 Jan 2024 00:16:30 -0800
Subject: [PATCH 1/2] [lldb] Add support for large watchpoints in lldb
This p
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/79962
>From 24cf5649fee074e9f6c72c7f768999ce4253b268 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 30 Jan 2024 00:16:30 -0800
Subject: [PATCH 1/3] [lldb] Add support for large watchpoints in lldb
This p
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/79962
>From 24cf5649fee074e9f6c72c7f768999ce4253b268 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 30 Jan 2024 00:16:30 -0800
Subject: [PATCH 1/4] [lldb] Add support for large watchpoints in lldb
This p
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/79962
>From 24cf5649fee074e9f6c72c7f768999ce4253b268 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 30 Jan 2024 00:16:30 -0800
Subject: [PATCH 1/5] [lldb] Add support for large watchpoints in lldb
This p
@@ -0,0 +1,146 @@
+//===-- WatchpointAlgorithms.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/79962
>From 24cf5649fee074e9f6c72c7f768999ce4253b268 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 30 Jan 2024 00:16:30 -0800
Subject: [PATCH 1/6] [lldb] Add support for large watchpoints in lldb
This p
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/79962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-01-31T10:02:22-08:00
New Revision: dad50fefa24e717927a4d3315ae70fe507d624e0
URL:
https://github.com/llvm/llvm-project/commit/dad50fefa24e717927a4d3315ae70fe507d624e0
DIFF:
https://github.com/llvm/llvm-project/commit/dad50fefa24e717927a4d3315ae70fe507d624e0.diff
Author: Jason Molenda
Date: 2024-01-31T10:39:59-08:00
New Revision: cf2533e75ec4360da460bb577e0a4e64f2d8997f
URL:
https://github.com/llvm/llvm-project/commit/cf2533e75ec4360da460bb577e0a4e64f2d8997f
DIFF:
https://github.com/llvm/llvm-project/commit/cf2533e75ec4360da460bb577e0a4e64f2d8997f.diff
Author: Jason Molenda
Date: 2024-01-31T11:09:59-08:00
New Revision: d6e1ae248e85295704e199a67405ea2a4c7e98b2
URL:
https://github.com/llvm/llvm-project/commit/d6e1ae248e85295704e199a67405ea2a4c7e98b2
DIFF:
https://github.com/llvm/llvm-project/commit/d6e1ae248e85295704e199a67405ea2a4c7e98b2.diff
Author: Jason Molenda
Date: 2024-01-31T11:23:23-08:00
New Revision: fa42589fe31924b6176d7a92691c2f760b04ffd8
URL:
https://github.com/llvm/llvm-project/commit/fa42589fe31924b6176d7a92691c2f760b04ffd8
DIFF:
https://github.com/llvm/llvm-project/commit/fa42589fe31924b6176d7a92691c2f760b04ffd8.diff
Author: Jason Molenda
Date: 2024-01-31T11:45:08-08:00
New Revision: c84f2bac93f38c903bae2e92fc7749d93c2e1112
URL:
https://github.com/llvm/llvm-project/commit/c84f2bac93f38c903bae2e92fc7749d93c2e1112
DIFF:
https://github.com/llvm/llvm-project/commit/c84f2bac93f38c903bae2e92fc7749d93c2e1112.diff
Author: Jason Molenda
Date: 2024-01-31T12:22:07-08:00
New Revision: 9d41fba91cc0a1c0cbad1de9fd5a1f78dd540b1c
URL:
https://github.com/llvm/llvm-project/commit/9d41fba91cc0a1c0cbad1de9fd5a1f78dd540b1c
DIFF:
https://github.com/llvm/llvm-project/commit/9d41fba91cc0a1c0cbad1de9fd5a1f78dd540b1c.diff
Author: Jason Molenda
Date: 2024-01-31T12:22:20-08:00
New Revision: e95250cda09331779d483e910ab3cfe5d655567c
URL:
https://github.com/llvm/llvm-project/commit/e95250cda09331779d483e910ab3cfe5d655567c
DIFF:
https://github.com/llvm/llvm-project/commit/e95250cda09331779d483e910ab3cfe5d655567c.diff
Author: Jason Molenda
Date: 2024-01-31T12:22:14-08:00
New Revision: 19f429a4bda124c655829f84bb9c1f76c86a547c
URL:
https://github.com/llvm/llvm-project/commit/19f429a4bda124c655829f84bb9c1f76c86a547c
DIFF:
https://github.com/llvm/llvm-project/commit/19f429a4bda124c655829f84bb9c1f76c86a547c.diff
Author: Jason Molenda
Date: 2024-01-31T12:22:27-08:00
New Revision: 46643e07d4c1caae3b8fa77be3a4073300785d91
URL:
https://github.com/llvm/llvm-project/commit/46643e07d4c1caae3b8fa77be3a4073300785d91
DIFF:
https://github.com/llvm/llvm-project/commit/46643e07d4c1caae3b8fa77be3a4073300785d91.diff
Author: Jason Molenda
Date: 2024-01-31T12:22:38-08:00
New Revision: cc4af03a839293ff908b52bb3a79b6ed562fe198
URL:
https://github.com/llvm/llvm-project/commit/cc4af03a839293ff908b52bb3a79b6ed562fe198
DIFF:
https://github.com/llvm/llvm-project/commit/cc4af03a839293ff908b52bb3a79b6ed562fe198.diff
Author: Jason Molenda
Date: 2024-01-31T12:22:43-08:00
New Revision: d347c564299eeb8ad1fcb58c06914473d6a789d8
URL:
https://github.com/llvm/llvm-project/commit/d347c564299eeb8ad1fcb58c06914473d6a789d8
DIFF:
https://github.com/llvm/llvm-project/commit/d347c564299eeb8ad1fcb58c06914473d6a789d8.diff
jasonmolenda wrote:
Merged this PR and found two unexpected (and one expected that I forgot to skip
a test on) CI bot failures. I've collected enough logs to debug them locally I
think, I reverted this patch from main until I have fixes and I will reland.
https://github.com/llvm/llvm-project/
Author: Jason Molenda
Date: 2024-01-31T21:03:38-08:00
New Revision: 147d7a64f8493e78669581097a3ff06c985aa3a1
URL:
https://github.com/llvm/llvm-project/commit/147d7a64f8493e78669581097a3ff06c985aa3a1
DIFF:
https://github.com/llvm/llvm-project/commit/147d7a64f8493e78669581097a3ff06c985aa3a1.diff
Author: Jason Molenda
Date: 2024-01-31T21:38:07-08:00
New Revision: 3b76b86491d13ced848f2ed6f411754f54befaba
URL:
https://github.com/llvm/llvm-project/commit/3b76b86491d13ced848f2ed6f411754f54befaba
DIFF:
https://github.com/llvm/llvm-project/commit/3b76b86491d13ced848f2ed6f411754f54befaba.diff
Author: Jason Molenda
Date: 2024-01-31T22:06:23-08:00
New Revision: fdd98e506d77514d8cbd5099e8fc98130244f6ff
URL:
https://github.com/llvm/llvm-project/commit/fdd98e506d77514d8cbd5099e8fc98130244f6ff
DIFF:
https://github.com/llvm/llvm-project/commit/fdd98e506d77514d8cbd5099e8fc98130244f6ff.diff
Author: Jason Molenda
Date: 2024-01-31T22:58:38-08:00
New Revision: 021a2b4ba254eb9e06fece5c18e5596cbb4896e6
URL:
https://github.com/llvm/llvm-project/commit/021a2b4ba254eb9e06fece5c18e5596cbb4896e6
DIFF:
https://github.com/llvm/llvm-project/commit/021a2b4ba254eb9e06fece5c18e5596cbb4896e6.diff
Author: Jason Molenda
Date: 2024-01-31T23:18:18-08:00
New Revision: 54f324f377a92a64fcc5c1d401da9b07bf50a2f1
URL:
https://github.com/llvm/llvm-project/commit/54f324f377a92a64fcc5c1d401da9b07bf50a2f1
DIFF:
https://github.com/llvm/llvm-project/commit/54f324f377a92a64fcc5c1d401da9b07bf50a2f1.diff
Author: Jason Molenda
Date: 2024-01-31T23:58:06-08:00
New Revision: 90e68086d8fdbfb32dfc7e7e3498f44365274ce8
URL:
https://github.com/llvm/llvm-project/commit/90e68086d8fdbfb32dfc7e7e3498f44365274ce8
DIFF:
https://github.com/llvm/llvm-project/commit/90e68086d8fdbfb32dfc7e7e3498f44365274ce8.diff
Author: Jason Molenda
Date: 2024-01-31T23:58:06-08:00
New Revision: eaa3d5e26665ca85d488e9194b9fbe304db6fa21
URL:
https://github.com/llvm/llvm-project/commit/eaa3d5e26665ca85d488e9194b9fbe304db6fa21
DIFF:
https://github.com/llvm/llvm-project/commit/eaa3d5e26665ca85d488e9194b9fbe304db6fa21.diff
jasonmolenda wrote:
Thanks for the great feedback @DavidSpickett sorry I merged it before you had a
chance to look. These are good points, I'll land a cleanup patch in a bit to
address them.
https://github.com/llvm/llvm-project/pull/79962
___
lldb-c
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/80376
debugserver on arm64 devices can manage both Byte Address Select watchpoints
(1-8 bytes) and MASK watchpoints (8 bytes-2 gigabytes). This adds a
SupportedWatchpointTypes key to the QSupported response from
jasonmolenda wrote:
The QSupported packet from debugserver also has a "compression minimum size"
field it adds (see the change to RNBRemote.cpp) and the QEnableCompression
packet accepts that field as well. I must have had a reason for adding this
when I added compression to the protocol, but
jasonmolenda wrote:
> I didn't have time to review before merge, just looking at this now.
>
> > see what the Windows CI thinks.
>
> I assume you mean the buildbots (lldb isn't built in the pre-commit CI), but
> I think given:
> https://github.com/llvm/llvm-zorg/blob/590f0a62919ad313758362d18
@@ -0,0 +1,109 @@
+//===-- WatchpointAlgorithms.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,109 @@
+//===-- WatchpointAlgorithms.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/80376
>From 70a518030f2b23ca130a8d0ea667729d7985795c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 1 Feb 2024 17:46:03 -0800
Subject: [PATCH 1/2] [lldb] Add QSupported key to report watchpoint types
sup
Author: Jason Molenda
Date: 2024-02-01T19:17:44-08:00
New Revision: 7dd790db8b77c4a833c06632e903dc4f13877a64
URL:
https://github.com/llvm/llvm-project/commit/7dd790db8b77c4a833c06632e903dc4f13877a64
DIFF:
https://github.com/llvm/llvm-project/commit/7dd790db8b77c4a833c06632e903dc4f13877a64.diff
@@ -38,7 +38,44 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -38,7 +38,44 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -403,6 +403,22 @@ void GDBRemoteCommunicationClient::GetRemoteQSupported() {
x.split(compressions, ',');
if (!compressions.empty())
MaybeEnableCompression(compressions);
+ } else if (x.consume_front("SupportedWatchpointTypes=")) {
+llvm
@@ -38,7 +38,44 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
@@ -38,7 +38,44 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
jasonmolenda wrote:
> Just to record that I thought about it, I agree with not trying to make the
> names architecture neutral.
>
> For example one might say that because range watchpoints on mips and aarch64
> have overlapping functionality (no pun intended) that we could report that we
> ha
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/80376
>From 70a518030f2b23ca130a8d0ea667729d7985795c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 1 Feb 2024 17:46:03 -0800
Subject: [PATCH 1/3] [lldb] Add QSupported key to report watchpoint types
sup
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/80376
>From 70a518030f2b23ca130a8d0ea667729d7985795c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 1 Feb 2024 17:46:03 -0800
Subject: [PATCH 1/4] [lldb] Add QSupported key to report watchpoint types
sup
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/80376
>From 70a518030f2b23ca130a8d0ea667729d7985795c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 1 Feb 2024 17:46:03 -0800
Subject: [PATCH 1/5] [lldb] Add QSupported key to report watchpoint types
sup
jasonmolenda wrote:
@bulbazord in the most recent commit I moved this internal-only enum from
lldb-enumerations.h to lldb-private-enumerations.h, but I need to use the
constexpr templatey thing that LLDB_MARK_AS_BITMASK_ENUM() defines for the enum
so I can use bit-wise | & operations without c
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/80376
>From 70a518030f2b23ca130a8d0ea667729d7985795c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 1 Feb 2024 17:46:03 -0800
Subject: [PATCH 1/6] [lldb] Add QSupported key to report watchpoint types
sup
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/80376
>From 70a518030f2b23ca130a8d0ea667729d7985795c Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 1 Feb 2024 17:46:03 -0800
Subject: [PATCH 1/7] [lldb] Add QSupported key to report watchpoint types
sup
@@ -38,7 +38,43 @@ read packet: +
read packet: $OK#9a
send packet: +
+//--
+// "QSupported"
+//
+// BRIEF
+// Query the GDB remote server for features it supports
+//
+// PRIORITY TO IMPLEMENT
+// Optional.
jasonmolenda wrote:
Thanks for the feedback Alex & David, I think this one might be good enough now.
https://github.com/llvm/llvm-project/pull/80376
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
jasonmolenda wrote:
Agreed, if I change this to
```
diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp
b/lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp
index d0bdbe1fd4d..b37544f6dd3 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp
+++ b/lldb/source/Plugins/Languag
@@ -398,6 +398,13 @@ class LLDB_API SBProcess {
/// valid.
lldb::SBProcessInfo GetProcessInfo();
+ /// Return target dump file during postmortem debugging.
+ /// An empty file will be returned for live debugging.
+ ///
+ /// \return
+ /// The target dump file spec
@@ -1244,6 +1244,17 @@ lldb::SBProcessInfo SBProcess::GetProcessInfo() {
return sb_proc_info;
}
+lldb::SBFileSpec SBProcess::GetCoreFile() {
+ LLDB_INSTRUMENT_VA(this);
+
+ ProcessSP process_sp(GetSP());
+ FileSpec core_file;
+ if (process_sp) {
+core_file = process_
jasonmolenda wrote:
This seems like a useful addition to me, I've had some users of corefiles who
have asked for an SBProcess::IsCore() type of method. (and others asking for
ways to access metadata from the corefile itself via the Process, although I've
never thought about how to do that, ma
1001 - 1100 of 1821 matches
Mail list logo
