[Lldb-commits] [PATCH] D96243: [lldb] DWZ 17/17: Fix symlinked /usr/lib/debug/.build-id/**.debug files

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96243/new/ https://reviews.llvm.org/D96243 ___

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 09/17: Include main unit DWARFUnit * inside DWARFDIEs

jankratochvil abandoned this revision. jankratochvil added a comment. I will be no longer involved with this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96236/new/ https://reviews.llvm.org/D96236 ___

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 09/17: Pass main DWARFUnit * along DWARFDIEs

jankratochvil updated this revision to Diff 374770. jankratochvil retitled this revision from "[lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs" to "[lldb] DWZ 09/17: Pass main DWARFUnit * along DWARFDIEs". Herald added a subscriber: mgorny. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

jankratochvil added a comment. Asking LLDB community whether to continue with this patchset upstreaming: Its advantage is sure compatibility with DWZ being used by {RHEL,CentOS}-{7,8}. The next version of {RHEL,CentOS} will use it as well. By my quick check Debian 12=Bookworm=testing is not usin

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64* with no hw watchpoints

jankratochvil planned changes to this revision. jankratochvil marked an inline comment as done. jankratochvil added a comment. In D102140#2768660 , @DavidSpickett wrote: > Is there any command we can run to directly get the number of h/w watchpoints? No

[Lldb-commits] [PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil updated this revision to Diff 347315. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 Files: clang/lib/AST/ASTImporter.

[Lldb-commits] [PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3684 + return ToAttrOrErr.takeError(); +#if 0 +RecordType *FromRT = It is still not working. The testcase either PASSes despite this `#if 0` or it FAILs even if it is `#if 1`

[Lldb-commits] [PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil updated this revision to Diff 347475. jankratochvil added a comment. Update of the testcase but it still does not reproduce the LLDB problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236

[Lldb-commits] [PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil added a comment. cat >1.cpp < struct DWrapper {}; typedef DWrapper DW; struct B { DW spd; } b; struct E { B &b_ref = b; static DW f() { return {}; } } e; EOH $ (set -ex;./bin/clang -c -o 1.o 1.cpp -Wall -g;./bin/lldb -b ./1.o -o 'p E' -o 'p e') (lldb) p

[Lldb-commits] [PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil updated this revision to Diff 347478. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp lldb/source/Plugins/Typ

[Lldb-commits] [PATCH] D103390: [lldb] Remove SBCommandReturnObject::ref

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. I agree it should not be permitted to return the internal object from SB API. And if it still compiles after moving to `private:` then why not. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:62 +// FIXME: Move it to ReservedBit4? +HANDLE_DI_FLAG((1 << 30), IsZeroSize) This would need to be handled better if approved. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil updated this revision to Diff 350361. jankratochvil added a comment. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, sstefan1, martong, hiraditya. Herald added a reviewer: shafik. Herald added a reviewer: jdoerfert. Herald added a reviewer: shafik. Herald added proje

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil added a comment. [Dwarf-Discuss] How to map [[no_unique_address]] into DWARF: http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2021-June/004825.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101237/new/ https://revi

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil updated this revision to Diff 350900. jankratochvil edited the summary of this revision. jankratochvil added a comment. This patch now requires: D101236 , D103910 and D103966 .

[Lldb-commits] [PATCH] D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py

jankratochvil created this revision. jankratochvil added reviewers: teemperor, dblaikie, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. This is a part of D101237 to fix LLDB

[Lldb-commits] [PATCH] D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py

jankratochvil abandoned this revision. jankratochvil added a comment. So I think you can check-in your patch. I would just copy-paste it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104283/new/ https://reviews.llvm.org/D104283 __

[Lldb-commits] [PATCH] D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py

jankratochvil added a comment. In D104283#2818693 , @teemperor wrote: > (Technically that would hide the deleter if the user specifies a > default-deleter that just happens to be compatible, but that seems like an > obscure corner case so this seems "go

[Lldb-commits] [PATCH] D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py

jankratochvil added a comment. In D104283#2818897 , @teemperor wrote: > - We should hide the deleter if it's stateless (default_delete or a > user-specified deleter that is empty) as the less verbose output is more > useful for command line users. My p

[Lldb-commits] [PATCH] D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfffb97509511: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite… (authored by jankratochvil). Changed prior to commit: https://re

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added a comment. In D104856#2838515 , @teemperor wrote: > (Nit: this is from the Linux manpage but this code is only compiled on > Darwin). Why do you think so? I haven't tried to build it on OSX but according to GIT the last use of this

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added a comment. In D104856#2838571 , @teemperor wrote: > The file is part of `debugserver` which is Darwin exclusive and is also only > compiled/used when you're on Darwin. It's also kind of its own thing: it > isn't using LLVM libraries

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added inline comments. Comment at: lldb/tools/debugserver/source/RNBSocket.cpp:44 } else if (strcmp(hostname, "*") == 0) { addr = htonl(INADDR_ANY); return true; Here it should use `AI_PASSIVE` instead. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added a comment. On OSX with `-DLLDB_USE_SYSTEM_DEBUGSERVER=OFF` I have built: -rwxr-xr-x 1 macbook staff 689200 Jun 24 19:10 bin/debugserver It uses `lldb/tools/debugserver/source/RNBSocket.cpp` (if I mess up the source file it does not build). The build does not need this `Reso

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil created this revision. jankratochvil added reviewers: teemperor, mib. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. While on regular Linux system (Fedora 34 GA, not updated): * thread #1, name = '1',

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil updated this revision to Diff 355327. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105133/new/ https://reviews.llvm.org/D105133 Files: lldb/source/Target/AssertFrameRecognizer.cpp Index: lldb/source/Target/AssertFrameRecognizer.cp

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil added inline comments. Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:115 +regex += it->GetStringRef(); + } + // Strip the trailing @VER symbol version. There would be nice `llvm::join`. But it wants `Elem.size()` while `ConstString

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil updated this revision to Diff 355333. jankratochvil added a comment. This revision is now accepted and ready to land. Unfortunately `AddRecognizer` requires both or none `module` and `symbols` as regexes. And we cannot make `module` a regex as `GetFileSpec().FileEquals` would not w

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe825c244b606: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64 (authored by jankratochvil). Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D105133: [lldb] Fix Recognizer/assert.test with glibc-2.33.9000-31.fc35.x86_64

jankratochvil added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105133/new/ https://reviews.llvm.org/D105133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

jankratochvil created this revision. jankratochvil added reviewers: teemperor, nealsid, labath. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. [[ https://lists.llvm.org/pipermail/lldb-dev/2021-July/016961.html | [lldb-

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

jankratochvil updated this revision to Diff 357799. jankratochvil edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105779/new/ https://reviews.llvm.org/D105779 Files: lldb/source/Core/IOHandlerCursesGUI.cpp lldb

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

jankratochvil updated this revision to Diff 358047. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105779/new/ https://reviews.llvm.org/D105779 Files: lldb/source/Core/IOHandlerCursesGUI.cpp lldb/tools/driver/Driver.cpp Index: lldb/tools/driver

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/tools/driver/Driver.cpp:871 int main(int argc, char const *argv[]) { + ::setlocale(LC_ALL, ""); + ::setlocale(LC_CTYPE, ""); teemperor wrote: > Can you make t

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rG72748488addd: [lldb] Fix editline unicode on Linux (authored by jankratochvil). Repository: rG LLV

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

jankratochvil created this revision. jankratochvil added reviewers: Eric, dblaikie. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, emaste. jankratochvil requested review of this revision. Herald added a subscriber: MaskRay. D100299

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

jankratochvil updated this revision to Diff 359458. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106194/new/ https://reviews.llvm.org/D106194 Files: lldb/test/Shell/ObjectFile/ELF/split-lazy-load.test lldb/test/Shell/ObjectFile/ELF/split-optimi

[Lldb-commits] [PATCH] D106466: [llvm+lldb] 2/2: Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil created this revision. jankratochvil added reviewers: dblaikie, labath, clayborg. jankratochvil added projects: LLDB, LLVM. Herald added subscribers: JDevlieghere, hiraditya. jankratochvil requested review of this revision. Fix D98289 so that it work

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. Is it really just a microoptimization or can you measure any improvement? That `ManualDWARFIndex::Index` will be called is expected. But there should be `m_units_to_avoid` covering all the units so it will quickly return without indexing anything: if (units_to_

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. In D106355#2896117 , @kimanh wrote: > In our case we have some third-party libraries that were not built by us, and > therefore they don't have any name index. Our main focus, is however, not to > debug those third party l

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

jankratochvil added a comment. @Eric yes, it would be better to merge it with your D100299 . In D106194#2894795 , @Eric wrote: > Instead of echoing into .c files, can we write the tests as .c files? It > seems to be a

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

jankratochvil abandoned this revision. jankratochvil added a comment. It has been merged to D100299 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106194/new/ https://reviews.llvm.org/D106194

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. In D106355#2903655 , @kimanh wrote: > Ah, to make sure that I understand it correctly: using `gdb-add-index` would > help `ManualDWARFIndex` to generate a `.debug_names`? No. One could write hypothetical `lldb-add-index` t

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. Approved after removing the curly brackets. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:136 continue; if (entr

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e9853e0e9ff: [DWARF5] Only fallback to manual index if no entry was found (authored by kimanh, committed by jankratochvil). Repository: rG LLVM G

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. You can also consider coding `lldb-add-index` for better performance as that is too much for my available time. In D106355#2909462 , @kimanh wrote: > Otherwise, could you help me to land this change (since I do not have >

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

jankratochvil added a comment. It broke some Linux buildbots and it also broke testsuite on my Fedora machine: `functionalities/gdb_remote_client/TestTargetXMLArch.py` - lldb-x86_64-fedora: https://lab.llvm.org/staging/#/builders/16/builds/8988 - lldb-aarch64-ubuntu: https://lab.llvm.org/buildbot

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7b8ba103a84: [lldb] [DWARF-5] Be lazier about loading .dwo files (authored by Eric, committed by jankratochvil). Herald added a project: LLDB. Heral

[Lldb-commits] [PATCH] D107153: [nfc] [osx] [lldb] Simplify code using GetDebugMapSymfile()

jankratochvil created this revision. jankratochvil added reviewers: clayborg, Eric, dblaikie. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. In D100299 I was not sure what can happen

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

jankratochvil added a comment. In D100299#2916203 , @omjavaid wrote: > This fails on 32 bit Arm > https://lab.llvm.org/buildbot/#/builders/17/builds/9595 I have reverted it as it takes some time to build on arm32 to investigate it. Repository: rG LL

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

jankratochvil added a comment. In D100299#2917250 , @Eric wrote: > Would it make sense to turn the split-optimized test back into an x86 only > test, or just leave it out of the change as it's not actually testing a code > path that this changed? The q

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

jankratochvil added a comment. In D100299#2917467 , @Eric wrote: > Is arm hardware necessary to test this, In this case it is not as it does not require linking. Usually I find easier to run it natively than to setup all the cross-compilation libraries

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

jankratochvil added a comment. In D100299#2917768 , @stella.stamenova wrote: > This also fails on the Windows lldb bot: Sorry I did not check (probably it sends messages to Author and not Commiter). Added there: // -gsplit-dwarf is supported only on

[Lldb-commits] [PATCH] D107161: [lldb] Fix lookup of .debug_loclists with split-dwarf

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. LGTM with some those adjustments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:450 +if (!contribution) + return; +offset += contr

[Lldb-commits] [PATCH] D107300: Use filename instead of index in test

This revision was automatically updated to reflect the committed changes. Closed by commit rGea9706626ce3: [test] [lldb] Use filename instead of index in test (authored by Eric, committed by jankratochvil). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LL

[Lldb-commits] [PATCH] D107165: Support moving support files instead of copy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG437e37dd5539: [nfc] [lldb] Support moving support files instead of copy (authored by Eric, committed by jankratochvil). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D107485: [nfc] [lldb] Prevent needless copies of DataExtractor

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, teemperor. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. This patch was created accidentally but I find it useful when I already wr

[Lldb-commits] [PATCH] D106466: 3/3: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil marked an inline comment as done. jankratochvil added a comment. In D106466#2922549 , @ikudrin wrote: > As far as I understand it, you need a specially constructed > `llvm::DWARFDebugRnglistTable` object so that > `DWARFUnit::FindRnglistFr

[Lldb-commits] [PATCH] D106466: 3/3: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 364190. jankratochvil marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106466/new/ https://reviews.llvm.org/D106466 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cp

[Lldb-commits] [PATCH] D107485: [nfc] [lldb] Prevent needless copies of DataExtractor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14f443030c1a: [nfc] [lldb] Prevent needless copies of DataExtractor (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

jankratochvil created this revision. jankratochvil added reviewers: kimanh, labath, clayborg. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, arphaman. jankratochvil requested review of this revision. As this issue is a bit difficult to debug it is better to make it sa

[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/find-variable-file.cpp:34 +// RUN: %clang -c -o %t-2.o --target=x86_64-pc-linux -gdwarf-5 -gsplit-dwarf -

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

jankratochvil updated this revision to Diff 364861. jankratochvil added a comment. In D107659#2931836 , @clayborg wrote: > Can we not just grab the skeleton unit when/if needed instead of asserting in > many places? I agree it could be unified for API s

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

jankratochvil added a comment. Thanks for checking it but ... In D107659#2931836 , @clayborg wrote: > Can we not just grab the skeleton unit when/if needed instead of asserting in > many places? ... I am not sure @clayborg likes the assertions. Repos

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3932b9a0b0b: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using . (authored by jankratochvil). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:519 +contribution->Length); +return DWARFDataExtractor(); + } Here could be an error message. Comment at: l

[Lldb-commits] [PATCH] D107470: 2/3: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil updated this revision to Diff 366017. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107470/new/ https://reviews.llvm.org/D107470 Files: lldb/unittests/SymbolFile/DWARF/DWARFUnitTest.cpp llvm/include/llvm/DebugInfo/DWARF/DWARFListTa

[Lldb-commits] [PATCH] D107470: 2/3: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: llvm/unittests/DebugInfo/DWARF/DWARFListTableTest.cpp:128 + EXPECT_EQ(Table.getAddrSize(), 8U); + Extractor.setAddressSize(Table.getAddrSize()); + Expected List = Table.findList(Ex

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil updated this revision to Diff 366446. jankratochvil marked an inline comment as done. jankratochvil retitled this revision from "2/3: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor" to "[llvm+lldb] Remove dead-code in DWARFListTableHeader:

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil updated this revision to Diff 366448. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107470/new/ https://reviews.llvm.org/D107470 Files: lldb/unittests/SymbolFile/DWARF/DWARFUnitTest.cpp llvm/include/llvm/DebugInfo/DWARF/DWARFListTa

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFListTable.h:289-291 if (Header.length()) Data = DWARFDataExtractor(Data, getHeaderOffset() + Header.length()); + Data.setAddressSize(ge

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 366449. jankratochvil retitled this revision from "3/3: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)" to "[llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GC

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added a comment. In D106466#2939551 , @ikudrin wrote: > In D106466#2926185 , @jankratochvil > wrote: > >> One needs to set at least `AddrSize` and `OffsetEntryCount` as callers do >> use it. > > Co

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 366676. jankratochvil edited the summary of this revision. jankratochvil added a comment. @dblaikie do you think it is OK for check-in now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106466/new/ https:

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil marked 3 inline comments as done. jankratochvil added a comment. In D107470#2946689 , @ikudrin wrote: > `DWARFDebugInfo.TestRnglistsAddressSize`, > `DWARFListTableHeader.AddressSize64Offset`, and > `DWARFListTableHeader.AddressSize32Offset

[Lldb-commits] [PATCH] D107470: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil updated this revision to Diff 366684. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107470/new/ https://reviews.llvm.org/D107470 Files: lldb/unittests/SymbolFile/DWARF/DWARFUnitTest.cpp llvm/include/llvm/DebugInfo/DWARF/DWARFListTa

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added a comment. In D106466#2947710 , @dblaikie wrote: > I assume there's already test coverage for rnglistx in debug_info.dwo/split > unit? (because in that case there's no rnglists_base, but rnglistx is usable) I admit I did not check it

[Lldb-commits] [PATCH] D106466: [llvm+lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe21a21a977b4: [lldb] Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base… (authored by jankratochvil). Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

jankratochvil accepted this revision. jankratochvil added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:556 + " (ranges list base: 0x%" PRIx64 "): %s", + offset, m_ranges_base, to

[Lldb-commits] [PATCH] D107470: 2/4: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil created this revision. jankratochvil added reviewers: ikudrin, dblaikie, labath, clayborg. jankratochvil added projects: LLDB, LLVM. Herald added subscribers: JDevlieghere, hiraditya. jankratochvil requested review of this revision. @ikudrin has correctly noticed

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

jankratochvil added a comment. The new test is failing on all Linux buildbots such as: lldb-x86_64-fedora = https://lab.llvm.org/staging/#/builders/16 lldb-x86_64-debian = https://lab.llvm.org/buildbot/#/builders/68 https://lab.llvm.org/buildbot/#/builders?tags=lldb Repository: rG LLVM Github

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

jankratochvil added a comment. It broke Fedora 34 x86_64 buildbot (using gcc) lldb-x86_64-fedora = https://lab.llvm.org/staging/#/builders/16 https://lab.llvm.org/staging/#/builders/16/builds/10450 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1075

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer

jankratochvil created this revision. jankratochvil added reviewers: mib, JDevlieghere, labath. jankratochvil added a project: LLDB. Herald added a subscriber: aprantl. D73303 was failing on Fedora Linux and so it was disa

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer

jankratochvil marked 2 inline comments as done. jankratochvil added a comment. In D74252#1864879 , @mib wrote: > Originally, when I implemented the patch and tested it on linux, the symbol > on the abort frame was (__GI___assert_fail) on my machine. May

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf1046c716b3: [lldb] Fix+re-enable Assert StackFrame Recognizer on Linux (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D74252?vs=243266&id=243274#toc Repository: rG L

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer

jankratochvil added a comment. I have reverted this change as it fixed the testsuite but real world usage was broken: (lldb) run assert.test.tmp.out: /home/jkratoch/redhat/llvm-monorepo/lldb/test/Shell/Recognizer/Inputs/assert.c:7: int main(): Assertion `a == 42' failed. Process 12062 st

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil updated this revision to Diff 243353. jankratochvil retitled this revision from "Fix+re-enable Assert StackFrame Recognizer" to "Fix+re-enable Assert StackFrame Recognizer on Linux". jankratochvil edited the summary of this revision. Herald added a subscriber: jfb. Repository: rG

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil added a comment. In D74252#1865493 , @mib wrote: > We'd like to avoid registering recognizers multiple times for the same > purpose ... OK, then it could be changed to a regex. Is it fine afterwards? Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil added a comment. In D74252#1865500 , @mib wrote: > Knowing that this will be called every time a thread stops, it would be > better if we could avoid processing a regex every time we try to recognise a > frame. Or `StackFrameRecognizerMan

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil updated this revision to Diff 243358. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74252/new/ https://reviews.llvm.org/D74252 Files: lldb/include/lldb/Target/StackFrameRecognizer.h lldb/source/Commands/CommandObjectFrame.cpp ll

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil added a comment. In D74252#1865504 , @mib wrote: > but let's leave symbol as is and add a `ConstString alternate_symbol` FYI this had a purpose. Any code touching `symbol` should be rechecked if it should not handle also `alternate_symbol`

[Lldb-commits] [PATCH] D74295: [lldb] [testsuite] TestGdbRemoteLibrariesSvr4Support: Fix symlinked builddir

jankratochvil created this revision. jankratochvil added reviewers: aadsm, labath. jankratochvil added a project: LLDB. jankratochvil added a comment. That testcase has been created by D62502 . When I have symlinked builddir on Fedora 31 x86_64 I get: FAIL: te

[Lldb-commits] [PATCH] D74295: [lldb] [testsuite] TestGdbRemoteLibrariesSvr4Support: Fix symlinked builddir

jankratochvil added a comment. That testcase has been created by D62502 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74295/new/ https://reviews.llvm.org/D74295 ___ l

[Lldb-commits] [PATCH] D74295: [lldb] [testsuite] TestGdbRemoteLibrariesSvr4Support: Fix symlinked builddir

This revision was automatically updated to reflect the committed changes. Closed by commit rG420a51806850: [lldb] [testsuite] TestGdbRemoteLibrariesSvr4Support: Fix symlinked builddir (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D74296: [lldb] [doc] Sample commands prefix from > to $

jankratochvil created this revision. jankratochvil added a reviewer: JDevlieghere. jankratochvil added a project: LLDB. Remove all beginning `> ` from the sample commands as my accidental copy-paste (multiple times...) will discard `./bin/llvm-lit` which is difficult to rebuild (I have to `rm -r

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

jankratochvil added a comment. In D73206#1859944 , @labath wrote: > From a high-level, this approach looks like it could be viable. However, you > have taken this a lot further than I would have expected. What I was > expecting to see would be that a bun

[Lldb-commits] [PATCH] D74296: [lldb] [doc] Sample commands prefix from > to $

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e0fee77bc8: [lldb] [doc] Change sample commands prefix from > to $ (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74296/new/ h

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a39f1b966a8: [lldb] Fix+re-enable Assert StackFrame Recognizer on Linux (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74252/new

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil added a comment. In D74252#1866476 , @mib wrote: > Has the latest version of this patch landed yet or does it need some extra > work ? I was giving some time to other reviewers but it is checked-in now. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

jankratochvil added a subscriber: davide. jankratochvil added a comment. @davide Sorry for the revert rG6b2979c12300b90a1e69791d43ee9cff14f4265e - I will find some way to test stuff on OSX, I already made too many OSX breakage

<    1   2   3   4   5   6   7   8   9   >