https://github.com/HemangGadhavi converted_to_draft
https://github.com/llvm/llvm-project/pull/126484
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi closed
https://github.com/llvm/llvm-project/pull/126484
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/134354
>From e7b3d8d95477f96b4c1b1a2bbec5cce49f4c15cd Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Fri, 4 Apr 2025 00:59:17 -0500
Subject: [PATCH 1/3] [lldb][AIX] get host info for AIX
---
lldb/source/Hos
@@ -141,6 +141,7 @@ else()
add_host_subdirectory(aix
aix/Host.cpp
aix/HostInfoAIX.cpp
+ linux/Support.cpp
HemangGadhavi wrote:
@labath This is a great suggestion. Thanks for suggestion.
we will create the new PR for the same and create the
HemangGadhavi wrote:
> We have a tests for this function in `unittests/Host/linux/HostTest.cpp` and
> it looks like at least some of it should apply to other systems as well. We
> could move it to the "posix" folder so that it applies to your code as well.
> Depending on the size of linux-spec
@@ -40,8 +40,9 @@ TEST_F(HostTest, GetProcessInfo) {
triple.getEnvironment() == llvm::Triple::EnvironmentType::Android));
ProcessInstanceInfo Info;
+#ifndef _AIX
HemangGadhavi wrote:
This process is basically for swapper/scheduling work. And yes its
@@ -40,8 +40,9 @@ TEST_F(HostTest, GetProcessInfo) {
triple.getEnvironment() == llvm::Triple::EnvironmentType::Android));
ProcessInstanceInfo Info;
+#ifndef _AIX
HemangGadhavi wrote:
Make sense.
Thanks for the suggestion let me make the changes.
h
@@ -40,8 +40,9 @@ TEST_F(HostTest, GetProcessInfo) {
triple.getEnvironment() == llvm::Triple::EnvironmentType::Android));
ProcessInstanceInfo Info;
+#ifndef _AIX
HemangGadhavi wrote:
Yes process zero exist on AIX. That is the reason disabled for AIX
@@ -7,21 +7,24 @@
//===--===//
#include "lldb/Host/linux/Support.h"
+#include "lldb/Host/posix/Support.h"
#include "llvm/Support/Threading.h"
#include "gtest/gtest.h"
using namespace lldb_private;
TES
@@ -7,17 +7,135 @@
//===--===//
#include "lldb/Host/Host.h"
+#include "lldb/Host/posix/Support.h"
+#include "lldb/Utility/LLDBLog.h"
+#include "lldb/Utility/Log.h"
+#include "lldb/Utility/ProcessInfo.h"
#inc
HemangGadhavi wrote:
@labath Addressed all your comments, Please have a look once and give your
comments if any.
https://github.com/llvm/llvm-project/pull/134354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/134354
>From e7b3d8d95477f96b4c1b1a2bbec5cce49f4c15cd Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Fri, 4 Apr 2025 00:59:17 -0500
Subject: [PATCH 1/5] [lldb][AIX] get host info for AIX
---
lldb/source/Hos
@@ -7,17 +7,139 @@
//===--===//
#include "lldb/Host/Host.h"
+#include "lldb/Host/posix/Support.h"
+#include "lldb/Utility/LLDBLog.h"
+#include "lldb/Utility/Log.h"
+#include "lldb/Utility/ProcessInfo.h"
#inc
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/134354
>From e7b3d8d95477f96b4c1b1a2bbec5cce49f4c15cd Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Fri, 4 Apr 2025 00:59:17 -0500
Subject: [PATCH 1/6] [lldb][AIX] get host info for AIX
---
lldb/source/Hos
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/134354
>From e7b3d8d95477f96b4c1b1a2bbec5cce49f4c15cd Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Fri, 4 Apr 2025 00:59:17 -0500
Subject: [PATCH 1/6] [lldb][AIX] get host info for AIX
---
lldb/source/Hos
HemangGadhavi wrote:
> Could you please disable/revert if the fix is not easy?
@felipepiovezan Done through the commit ID
cf7301aeb808a13fe882a4b0bf7f1bfe4051c301 by labath
https://github.com/llvm/llvm-project/pull/134354
___
lldb-commits mailing li
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/134354
>From e7b3d8d95477f96b4c1b1a2bbec5cce49f4c15cd Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Fri, 4 Apr 2025 00:59:17 -0500
Subject: [PATCH 1/4] [lldb][AIX] get host info for AIX
---
lldb/source/Hos
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/134354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -141,6 +141,7 @@ else()
add_host_subdirectory(aix
aix/Host.cpp
aix/HostInfoAIX.cpp
+ linux/Support.cpp
HemangGadhavi wrote:
Hey @labath
Made the changes as per the discussion, I have added the common
`posix/Support.cpp` for unix-like
HemangGadhavi wrote:
> > > We have a tests for this function in `unittests/Host/linux/HostTest.cpp`
> > > and it looks like at least some of it should apply to other systems as
> > > well. We could move it to the "posix" folder so that it applies to your
> > > code as well. Depending on the si
@@ -7,21 +7,24 @@
//===--===//
#include "lldb/Host/linux/Support.h"
+#include "lldb/Host/posix/Support.h"
#include "llvm/Support/Threading.h"
#include "gtest/gtest.h"
using namespace lldb_private;
TES
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/134354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/134354
>From e7b3d8d95477f96b4c1b1a2bbec5cce49f4c15cd Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Fri, 4 Apr 2025 00:59:17 -0500
Subject: [PATCH 1/4] [lldb][AIX] get host info for AIX
---
lldb/source/Hos
https://github.com/HemangGadhavi created
https://github.com/llvm/llvm-project/pull/138687
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issues/
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/138687
>From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Tue, 6 May 2025 07:59:45 -0500
Subject: [PATCH] [lldb][AIX] get host info for AIX (cont..)
---
lldb/sourc
https://github.com/HemangGadhavi created
https://github.com/llvm/llvm-project/pull/134354
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issues/
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/102601
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/102601
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/138687
>From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Tue, 6 May 2025 07:59:45 -0500
Subject: [PATCH 1/2] [lldb][AIX] get host info for AIX (cont..)
---
lldb/s
@@ -18,5 +20,18 @@ void HostInfoAIX::Terminate() { HostInfoBase::Terminate(); }
FileSpec HostInfoAIX::GetProgramFileSpec() {
static FileSpec g_program_filespec;
+ struct psinfo psinfoData;
+ auto BufferOrError = getProcFile(getpid(), "psinfo");
+ if (BufferOrError) {
+
@@ -133,7 +142,45 @@ static bool GetProcessAndStatInfo(::pid_t pid,
uint32_t Host::FindProcessesImpl(const ProcessInstanceInfoMatch &match_info,
ProcessInstanceInfoList &process_infos) {
- return 0;
+ static const char procdir[] = "/proc/";
+
@@ -133,7 +142,45 @@ static bool GetProcessAndStatInfo(::pid_t pid,
uint32_t Host::FindProcessesImpl(const ProcessInstanceInfoMatch &match_info,
ProcessInstanceInfoList &process_infos) {
- return 0;
+ static const char procdir[] = "/proc/";
+
HemangGadhavi wrote:
> Could you also make unit tests for these two functions:
>
> * call GetProgramFileSpec and make sure the result is reasonable (exists?)
> * create a Process and make sure FindProcesses finds it (you can use
> [this](https://github.com/llvm/llvm-project/blob/52f568dbbb61ffe
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/138687
>From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Tue, 6 May 2025 07:59:45 -0500
Subject: [PATCH 1/3] [lldb][AIX] get host info for AIX (cont..)
---
lldb/s
@@ -90,6 +92,30 @@ TEST(Host, LaunchProcessSetsArgv0) {
ASSERT_THAT(exit_status.get_future().get(), 0);
}
+TEST(Host, FindProcesses) {
+ SubsystemRAII subsystems;
+
+ if (test_arg != 0)
+exit(0);
HemangGadhavi wrote:
Done
https://github.com/llvm/llvm
@@ -90,6 +92,30 @@ TEST(Host, LaunchProcessSetsArgv0) {
ASSERT_THAT(exit_status.get_future().get(), 0);
}
+TEST(Host, FindProcesses) {
+ SubsystemRAII subsystems;
+
+ if (test_arg != 0)
+exit(0);
+
+ ProcessLaunchInfo info;
+ ProcessInstanceInfoList processes;
+ Pro
@@ -90,6 +92,30 @@ TEST(Host, LaunchProcessSetsArgv0) {
ASSERT_THAT(exit_status.get_future().get(), 0);
}
+TEST(Host, FindProcesses) {
+ SubsystemRAII subsystems;
+
+ if (test_arg != 0)
+exit(0);
+
+ ProcessLaunchInfo info;
+ ProcessInstanceInfoList processes;
+ Pro
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/138687
>From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Tue, 6 May 2025 07:59:45 -0500
Subject: [PATCH 1/2] [lldb][AIX] get host info for AIX (cont..)
---
lldb/s
@@ -54,6 +54,12 @@ TEST_F(HostInfoTest, GetHostname) {
EXPECT_TRUE(HostInfo::GetHostname(s));
}
+TEST_F(HostInfoTest, GetProgramFileSpec) {
+ // Test GetProgramFileSpec()
HemangGadhavi wrote:
Done
https://github.com/llvm/llvm-project/pull/138687
_
@@ -54,6 +54,12 @@ TEST_F(HostInfoTest, GetHostname) {
EXPECT_TRUE(HostInfo::GetHostname(s));
}
+TEST_F(HostInfoTest, GetProgramFileSpec) {
+ // Test GetProgramFileSpec()
+ FileSpec filespec = HostInfo::GetProgramFileSpec();
+ EXPECT_FALSE(filespec.GetFilename().IsEmpty()
@@ -90,6 +90,31 @@ TEST(Host, LaunchProcessSetsArgv0) {
ASSERT_THAT(exit_status.get_future().get(), 0);
}
+TEST(Host, FindProcesses) {
+ SubsystemRAII subsystems;
+
+ if (test_arg != 0)
+exit(0);
+
+ ProcessLaunchInfo info;
+ ProcessInstanceInfoList processes;
+ Pro
HemangGadhavi wrote:
> The failure is in lldb_private::HostInfoBase::GetArchitecture. To fix this,
> you need to `Initialize()` the HostInfo class.
Thank you @labath. Thanks for the guidance, it worked.
Could you please review and give your comments.
https://github.com/llvm/llvm-project/pull/
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/138687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/138687
>From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Tue, 6 May 2025 07:59:45 -0500
Subject: [PATCH 1/2] [lldb][AIX] get host info for AIX (cont..)
---
lldb/s
HemangGadhavi wrote:
> > I don't know if this is the source of the problem, but one thing I noticed
> > is that you're missing some sort of synchronization to make sure the child
> > process doesn't exit before you're able to observe it. A slightly lame but
> > probably sufficient method to do
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/138687
>From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Tue, 6 May 2025 07:59:45 -0500
Subject: [PATCH 1/3] [lldb][AIX] get host info for AIX (cont..)
---
lldb/s
https://github.com/HemangGadhavi created
https://github.com/llvm/llvm-project/pull/142586
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issues/1
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/142586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/142586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
HemangGadhavi wrote:
> The failure is unrelated, ignore it.
Thanks @DavidSpickett
https://github.com/llvm/llvm-project/pull/142586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi created
https://github.com/llvm/llvm-project/pull/144645
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issues/1
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/144645
>From 5b842ed6c8721f314f677602a3b0ae81c4b39f27 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Tue, 17 Jun 2025 02:50:45 -0500
Subject: [PATCH 1/2] [lldb][AIX] Added base file for AIX Register Context
@@ -0,0 +1,74 @@
+//===-- NativeRegisterContextAIX.h *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
@@ -0,0 +1,74 @@
+//===-- NativeRegisterContextAIX.h *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
@@ -0,0 +1,66 @@
+//===-- NativeRegisterContextAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
@@ -0,0 +1,74 @@
+//===-- NativeRegisterContextAIX.h *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
@@ -0,0 +1,54 @@
+//===-- NativeRegisterContextAIX.cpp ===//
HemangGadhavi wrote:
Done Thanks.
https://github.com/llvm/llvm-project/pull/144645
___
lldb-commits mailing list
lldb-com
@@ -0,0 +1,62 @@
+//===-- NativeRegisterContextAIX.h *- C++ -*-===//
HemangGadhavi wrote:
Done Thanks.
https://github.com/llvm/llvm-project/pull/144645
___
lldb-commits mailing list
lldb-com
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/144645
>From 5b842ed6c8721f314f677602a3b0ae81c4b39f27 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Tue, 17 Jun 2025 02:50:45 -0500
Subject: [PATCH 1/2] [lldb][AIX] Added base file for AIX Register Context
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/144645
>From 5b842ed6c8721f314f677602a3b0ae81c4b39f27 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Tue, 17 Jun 2025 02:50:45 -0500
Subject: [PATCH 1/2] [lldb][AIX] Added base file for AIX Register Context
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/145645
>From a85d648ce62b69b870dda306dbdc2d412ed89d33 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Wed, 25 Jun 2025 02:06:05 -0400
Subject: [PATCH] [lldb][DWARF64] Enable support for DWARF64 format handling
HemangGadhavi wrote:
@labath @DavidSpickett
With this PR I have enable the support of `DWARF64` format, I made the use of
the existing llvm framework to get the header size and also adjusting the form
value according to the format (i.e. `DW_FORM_ref_addr` suppose to 4bytes for
`DWARF32` and 8
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/145645
>From 547716f930b16cd66b5aa6ce3a59aaf6167ece01 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Wed, 25 Jun 2025 02:06:05 -0400
Subject: [PATCH] [lldb][DWARF64] Enable support for DWARF64 format handling
https://github.com/HemangGadhavi created
https://github.com/llvm/llvm-project/pull/145645
This PR introduces support for the DWARF64 format, enabling handling of 64-bit
DWARF sections as defined by the DWARF specification. The update includes
adjustments to header parsing and modification of f
@@ -165,26 +172,27 @@ static FormSize g_form_sizes[] = {
{1, 1}, // 0x0b DW_FORM_data1
{1, 1}, // 0x0c DW_FORM_flag
{0, 0}, // 0x0d DW_FORM_sdata
-{1, 4}, // 0x0e DW_FORM_strp
+{0, 0}, // 0x0e DW_FORM_strp (4 bytes for DWARF32, 8 bytes for DWARF64)
{0,
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/145645
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
HemangGadhavi wrote:
> Also wondering about testing this. What tools can produce DWARF64?
>
@DavidSpickett answer to your question, we can produce `DWARF64` by enabling
-`gdwarf64` clang compilation flag. But that could be different for different
compiler
> Run `check-lldb` with DWARF64 ena
@@ -1073,20 +1073,7 @@ const lldb_private::DWARFDataExtractor
&DWARFUnit::GetData() const {
: m_dwarf.GetDWARFContext().getOrLoadDebugInfoData();
}
-uint32_t DWARFUnit::GetHeaderByteSize() const {
- switch (m_header.getUnitType()) {
- case llvm::dwarf::DW_UT_co
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/142586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
HemangGadhavi wrote:
> Thanks @HemangGadhavi , just add a link to the ibm doc for reference.
Thanks @DhruvSrivastavaX updated in description.
https://github.com/llvm/llvm-project/pull/142586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -290,6 +290,45 @@ else()
endif()
endif()
+# Stage all headers in the include directory in the build dir.
+file(GLOB public_headers ${LLDB_SOURCE_DIR}/include/lldb/API/*.h)
+set(lldb_header_staging_dir ${CMAKE_BINARY_DIR}/include/lldb)
+file(GLOB root_public_headers ${LLDB
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/141116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/141116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/141116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi created
https://github.com/llvm/llvm-project/pull/142356
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issues/
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/142356
>From 9e62239b168e132c40fd238ac3dfa303628d2477 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Mon, 2 Jun 2025 04:54:15 -0500
Subject: [PATCH] [lldb][aix] Added support for DW_ranges section
---
lldb/
https://github.com/HemangGadhavi created
https://github.com/llvm/llvm-project/pull/147054
This PR is updating the string table offset (DW_AT_str_offsets_base which is
introduces in `DWARF5`) based on the DWARF format, as per the DWARF
specification, For the 32-bit DWARF format, each offset is
HemangGadhavi wrote:
@labath @DavidSpickett
Related to PR https://github.com/llvm/llvm-project/issues/135208
Please have review once. DW_AT_str_offsets_base was missing to handle for
DWARF64.
https://github.com/llvm/llvm-project/pull/147054
___
ll
HemangGadhavi wrote:
@DhruvSrivastavaX FYI
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
HemangGadhavi wrote:
> This is the relevant part of the standard, correct?
Yes exactly that's what I am referring too.
> I see also "7.4 32-Bit and 64-Bit DWARF Formats", is there anything else in
> there we need to handle?
I see there is one form `DW_FORM_strp_sup` which is not at all added
HemangGadhavi wrote:
> I suggest you look in lldb's source for any uses of the DWARF32 symbol, I bet
> we've done this elsewhere too.
Yes I already found it and its in my list to fix, there are few places where
`DWARF32` parsing but I was planing to do in separate PR. or you want me to do
it
HemangGadhavi wrote:
Hi @labath @DavidSpickett
I have addressed your comments, and added separate test case to test
DW_AT_str_offsets_base for DWARF5 & 64 format.
Please review once and give your inputs.
https://github.com/llvm/llvm-project/pull/147054
@@ -1077,7 +1077,8 @@ uint32_t DWARFUnit::GetHeaderByteSize() const { return
m_header.getSize(); }
std::optional
DWARFUnit::GetStringOffsetSectionItem(uint32_t index) const {
- lldb::offset_t offset = GetStrOffsetsBase() + index * 4;
+ lldb::offset_t offset =
+ GetStrO
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/147054
>From 4ae4d0ab6ba44317e00dced8f247341ec9930c2c Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Fri, 4 Jul 2025 09:28:30 -0400
Subject: [PATCH 1/2] [lldb] Updated the String table offset based on the DWA
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/147054
>From 4ae4d0ab6ba44317e00dced8f247341ec9930c2c Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Fri, 4 Jul 2025 09:28:30 -0400
Subject: [PATCH 1/3] [lldb] Updated the String table offset based on the DWA
@@ -84,3 +84,100 @@ TEST(DWARF64UnitTest, DWARF64DebugInfoAndCU) {
ASSERT_TRUE(declaration.IsValid());
ASSERT_EQ(declaration.Tag(), DW_TAG_subprogram);
}
+
+TEST(DWARF64UnitTest, DWARF5StrTable) {
+ const char *yamldata = R"(
+--- !ELF
+FileHeader:
+ Class: ELFCLASS64
+
@@ -416,12 +416,8 @@ void DWARFFormValue::Dump(Stream &s) const {
case DW_FORM_ref_addr: {
assert(m_unit); // Unit must be valid for DW_FORM_ref_addr objects or we
// will get this wrong
-if (m_unit->GetVersion() <= 2)
- DumpAddress(s.AsRawOst
@@ -420,8 +420,7 @@ void DWARFFormValue::Dump(Stream &s) const {
DumpAddress(s.AsRawOstream(), uvalue, sizeof(uint64_t) * 2);
else
DumpAddress(s.AsRawOstream(), uvalue,
HemangGadhavi wrote:
No need to check for the <= 2 DWARF version now, Becau
HemangGadhavi wrote:
> @HemangGadhavi (can't add you to reviewers for whatever reason)
May be I do not have maintainer access yet ..?? Not sure.
https://github.com/llvm/llvm-project/pull/146686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -416,12 +416,8 @@ void DWARFFormValue::Dump(Stream &s) const {
case DW_FORM_ref_addr: {
assert(m_unit); // Unit must be valid for DW_FORM_ref_addr objects or we
// will get this wrong
-if (m_unit->GetVersion() <= 2)
- DumpAddress(s.AsRawOst
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/146686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/145645
>From a85d648ce62b69b870dda306dbdc2d412ed89d33 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Wed, 25 Jun 2025 02:06:05 -0400
Subject: [PATCH 1/3] [lldb][DWARF64] Enable support for DWARF64 format
han
@@ -0,0 +1,96 @@
+//===--
DWARF64UnitTest.cpp=---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -119,10 +121,7 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor
&data,
break;
case DW_FORM_ref_addr:
assert(m_unit);
- if (m_unit->GetVersion() <= 2)
-ref_addr_size = m_unit->GetAddressByteSize();
- else
-ref_addr_size
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/145645
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -119,10 +121,7 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor
&data,
break;
case DW_FORM_ref_addr:
assert(m_unit);
- if (m_unit->GetVersion() <= 2)
-ref_addr_size = m_unit->GetAddressByteSize();
- else
-ref_addr_size
https://github.com/HemangGadhavi edited
https://github.com/llvm/llvm-project/pull/145645
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/145645
>From a85d648ce62b69b870dda306dbdc2d412ed89d33 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Wed, 25 Jun 2025 02:06:05 -0400
Subject: [PATCH 1/3] [lldb][DWARF64] Enable support for DWARF64 format
han
@@ -288,7 +284,9 @@ bool DWARFFormValue::SkipValue(dw_form_t form,
case DW_FORM_sec_offset:
case DW_FORM_strp:
case DW_FORM_line_strp:
- *offset_ptr += 4;
+ assert(unit); // Unit must be valid
HemangGadhavi wrote:
Thanks @Michael137
Done
1 - 100 of 115 matches
Mail list logo
