[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

hans added a comment. In D79219#2153585 , @phosek wrote: > In D79219#2152747 , @labath wrote: > >> I wouldn't mind separate (internal) cache variable, though I am somewhat >> surprised by this problem. A (non-cache

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

hans added inline comments. Comment at: llvm/cmake/config-ix.cmake:178 -if (LLVM_ENABLE_ZLIB STREQUAL "FORCE_ON" AND NOT HAVE_LIBZ) - message(FATAL_ERROR "Failed to configure zlib") Could this check be put back? E.g. for now it seems building with -DLLVM_USE_

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

hans added a comment. In D64881#1596920 , @labath wrote: > I think setting > -DPYTHON_EXECUTABLE=C:\Users\hwennborg\AppData\Local\Programs\Python\Python36-32\python.exe > (or something) should be enough to get cmake to select python3 for the > interpret

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

hans added a comment. In D64881#1590204 , @amccarth wrote: > An aside ... > > I'm still trying to get back to a buildable state the earlier changes, like > the one that tries to enforce version consistency between the libs and the > interpreter. I'm cur

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

hans added a comment. > - Added assert in `emitDebugInfoForUDTs` to ensure no lowering can occur > during UDT emission, as suggested by @rnk It seems we hit the assert in Chromium. Here's a reproducer: https://bugs.chromium.org/p/chromium/issues/detail?id=1083877#c3 (I'll try to create a short

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

hans added a comment. In D79447#2041250 , @hans wrote: > > - Added assert in `emitDebugInfoForUDTs` to ensure no lowering can occur > > during UDT emission, as suggested by @rnk > > It seems we hit the assert in Chromium. Here's a reproducer: > https://b

[Lldb-commits] [PATCH] D74084: [LLDB] Fix compilation with GCC 5

hans added a comment. In D74084#1861269 , @mstorsjo wrote: > @hans - this could be applied on 10.x (it seems to apply cleanly), to fix > PR44791. Thanks! Cherry-picked as 22633f85bb7d317ff97c86b6ae7817b678777d93

<    1   2