[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/8] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

https://github.com/eronnen deleted https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

@@ -0,0 +1,115 @@ +//===-- ProtocolUtils.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] persistent assembly breakpoints (PR #148061)

https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/148061 >From c9fc191e93381b90b67d72799bab1b9ea19b8c42 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 17 May 2025 23:49:10 +0200 Subject: [PATCH 01/19] [lldb-dap] Support persistent assembly breakpoints --- lldb

[Lldb-commits] [lldb] [lldb-dap] persistent assembly breakpoints (PR #148061)

https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/148061 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] persistent assembly breakpoints (PR #148061)

@@ -737,6 +738,11 @@ class LLDB_API SBTarget { lldb::SBBreakpoint BreakpointCreateBySBAddress(SBAddress &address); + lldb::SBBreakpoint + BreakpointCreateByFileAddress(const SBFileSpec &file_spec, addr_t file_addr, +addr_t offset = 0, +

[Lldb-commits] [lldb] [lldb-dap] persistent assembly breakpoints (PR #148061)

eronnen wrote: @jimingham I don't know if the `instructions_offset` parameter can be useful for other use cases, but in order to resolve assembly breakpoints in future sessions under the given protocol constraints I don't see another way . In the Debug Adapter Protocol the only persistent da

[Lldb-commits] [lldb] [lldb-dap] persistent assembly breakpoints (PR #148061)

eronnen wrote: > From the issue, we can have persistent assembly source breakpoint if it is > set from the disassembly view. > > We only create sourceReference and virtual disassembly file if there is no > source file for that frame. > > we can store the necessary information in the adapter d

[Lldb-commits] [lldb] [lldb-dap] persistent assembly breakpoints (PR #148061)

eronnen wrote: @jimingham I updated the PR to use the suggested `BreakpointCreateByName` instead of the address resolver, add `m_offset_is_insn_count` and check the disassemble result for errors when resolving with `m_offset_is_insn_count == true` https://github.com/llvm/llvm-project/pull/148

<    1   2   3   4