[Lldb-commits] [lldb] r325856 - remove FreeBSD xfail from lit TestCallStdStringFunction

2018-02-22 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Feb 22 18:50:07 2018 New Revision: 325856 URL: http://llvm.org/viewvc/llvm-project?rev=325856&view=rev Log: remove FreeBSD xfail from lit TestCallStdStringFunction This test is consistently reporting unexpected pass for me, and the expectedFailure decorator was removed fr

[Lldb-commits] [lldb] r326134 - Mark test_*int*_t_dwarf as failing on FreeBSD

2018-02-26 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Feb 26 14:12:24 2018 New Revision: 326134 URL: http://llvm.org/viewvc/llvm-project?rev=326134&view=rev Log: Mark test_*int*_t_dwarf as failing on FreeBSD Further investigation required; tests will be enabled on the buildbot worker soon. Marking failing tests for now in or

[Lldb-commits] [lldb] r326139 - Revert r326134 due to broken buildbot

2018-02-26 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Feb 26 14:36:41 2018 New Revision: 326139 URL: http://llvm.org/viewvc/llvm-project?rev=326139&view=rev Log: Revert r326134 due to broken buildbot Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/enum_types/TestCPP11EnumTypes.py Modified: lldb/trunk/pack

[Lldb-commits] [lldb] r326166 - Mark test_*int*_t_dwarf as failing on FreeBSD

2018-02-26 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Feb 26 18:54:17 2018 New Revision: 326166 URL: http://llvm.org/viewvc/llvm-project?rev=326166&view=rev Log: Mark test_*int*_t_dwarf as failing on FreeBSD Further investigation required; tests will be enabled on the buildbot worker soon. Marking failing tests for now in or

[Lldb-commits] [lldb] r330500 - FreeBSD: propagate error to user if memory access fails

2018-04-21 Thread Ed Maste via lldb-commits
Author: emaste Date: Sat Apr 21 04:23:56 2018 New Revision: 330500 URL: http://llvm.org/viewvc/llvm-project?rev=330500&view=rev Log: FreeBSD: propagate error to user if memory access fails Previously, an attempt to read an unreadable address reported zeros. Now, if DoReadMemory or DoWriteMemory e

[Lldb-commits] [lldb] r330504 - Temporarily skip Go TestExpressions on FreeBSD as it hangs

2018-04-21 Thread Ed Maste via lldb-commits
Author: emaste Date: Sat Apr 21 06:59:07 2018 New Revision: 330504 URL: http://llvm.org/viewvc/llvm-project?rev=330504&view=rev Log: Temporarily skip Go TestExpressions on FreeBSD as it hangs llvm.org/pr37194 Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/go/expressions/TestExpres

Re: [Lldb-commits] [lldb] r299200 - [LLDB][MIPS] Core Dump Support.

2017-04-04 Thread Ed Maste via lldb-commits
On 31 March 2017 at 07:14, Nitesh Jain via lldb-commits wrote: > Author: nitesh.jain > Date: Fri Mar 31 06:14:02 2017 > New Revision: 299200 > > URL: http://llvm.org/viewvc/llvm-project?rev=299200&view=rev > Log: > [LLDB][MIPS] Core Dump Support. The FreeBSD build is broken as of this commit: htt

[Lldb-commits] [lldb] r299781 - Correct environ parsing on FreeBSD

2017-04-07 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri Apr 7 11:40:25 2017 New Revision: 299781 URL: http://llvm.org/viewvc/llvm-project?rev=299781&view=rev Log: Correct environ parsing on FreeBSD Sync Host:GetEnvironment with Linux and Kamil Rytarowski's forthcoming NetBSD change in review D31784. Modified: lldb/trunk/

[Lldb-commits] [lldb] r301067 - ThreadSanitizer plugin: match for loop variable with expected type

2017-04-21 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri Apr 21 20:38:54 2017 New Revision: 301067 URL: http://llvm.org/viewvc/llvm-project?rev=301067&view=rev Log: ThreadSanitizer plugin: match for loop variable with expected type Removes Clang warning ThreadSanitizerRuntime.cpp:591:21: warning: comparison of integers of diffe

[Lldb-commits] [lldb] r301100 - Simplify FreeBSD Host.cpp with early returns

2017-04-22 Thread Ed Maste via lldb-commits
Author: emaste Date: Sat Apr 22 21:28:28 2017 New Revision: 301100 URL: http://llvm.org/viewvc/llvm-project?rev=301100&view=rev Log: Simplify FreeBSD Host.cpp with early returns Based on NetBSD's Host.cpp. Also tidy up comments to match NetBSD. Modified: lldb/trunk/source/Host/freebsd/Host.c

[Lldb-commits] [lldb] r303965 - FreeBSD ProcessMonitor: map TRAP_CAP to a trace trap

2017-05-25 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu May 25 22:15:46 2017 New Revision: 303965 URL: http://llvm.org/viewvc/llvm-project?rev=303965&view=rev Log: FreeBSD ProcessMonitor: map TRAP_CAP to a trace trap In the absense of a more specific handler for TRAP_CAP (generated by ENOTCAPABLE or ECAPMODE while in capabilit

[Lldb-commits] [lldb] r310591 - Report inferior signals as signals, not exceptions, on FreeBSD

2017-08-10 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Aug 10 06:47:17 2017 New Revision: 310591 URL: http://llvm.org/viewvc/llvm-project?rev=310591&view=rev Log: Report inferior signals as signals, not exceptions, on FreeBSD This is the FreeBSD equivalent of r238549. This serves 2 purposes: * LLDB should handle inferior pr

[Lldb-commits] [lldb] r310624 - remove FreeBSD xfail decorator from TestExitDuringBreak

2017-08-10 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Aug 10 09:48:36 2017 New Revision: 310624 URL: http://llvm.org/viewvc/llvm-project?rev=310624&view=rev Log: remove FreeBSD xfail decorator from TestExitDuringBreak This test passes for me on FreeBSD 10 and 12(-CURRENT). llvm.org/pr18190 Modified: lldb/trunk/package

[Lldb-commits] Details of radar rdar://problem/24599697

2017-08-10 Thread Ed Maste via lldb-commits
On 20 June 2016 at 19:01, Sean Callanan via lldb-commits wrote: > Author: spyffe > Date: Mon Jun 20 18:01:11 2016 > New Revision: 273211 > > URL: http://llvm.org/viewvc/llvm-project?rev=273211&view=rev > Log: > Test that lldb calls the right 'printf' even when a 'printf' method exists. > ... > + >

[Lldb-commits] [lldb] r310626 - remove FreeBSD xfail decorator from TestCallStdStringFunction

2017-08-10 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Aug 10 10:01:51 2017 New Revision: 310626 URL: http://llvm.org/viewvc/llvm-project?rev=310626&view=rev Log: remove FreeBSD xfail decorator from TestCallStdStringFunction This test is consistently reporting unexpected pass for me on FreeBSD 10 and 12. It was failing on the

[Lldb-commits] [lldb] r310644 - remove FreeBSD xfail decorator from TestCppNsImport

2017-08-10 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Aug 10 11:26:52 2017 New Revision: 310644 URL: http://llvm.org/viewvc/llvm-project?rev=310644&view=rev Log: remove FreeBSD xfail decorator from TestCppNsImport The Linux xfail decorator was removed in r272326 with the claim that the test "runs reliably on the linux x86 bu

[Lldb-commits] [lldb] r311002 - Make i386-*-freebsd expression work on JIT path

2017-08-16 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Aug 16 05:55:02 2017 New Revision: 311002 URL: http://llvm.org/viewvc/llvm-project?rev=311002&view=rev Log: Make i386-*-freebsd expression work on JIT path * Enable i386 ABI creation for freebsd * Added an extra argument in ABISysV_i386::PrepareTrivialCall for mmap sysc

[Lldb-commits] [lldb] r311003 - convert hard tabs to spaces in PlatformOpenBSD.cpp

2017-08-16 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Aug 16 06:10:07 2017 New Revision: 311003 URL: http://llvm.org/viewvc/llvm-project?rev=311003&view=rev Log: convert hard tabs to spaces in PlatformOpenBSD.cpp Another case of this was responsible for the whitespace conflict in D34776. Modified: lldb/trunk/source/Plug

[Lldb-commits] [lldb] r312430 - FreeBSD: attach to pid from different cwd

2017-09-02 Thread Ed Maste via lldb-commits
Author: emaste Date: Sat Sep 2 18:41:31 2017 New Revision: 312430 URL: http://llvm.org/viewvc/llvm-project?rev=312430&view=rev Log: FreeBSD: attach to pid from different cwd attach by pid worked when running from the directory from which the target was launched, but failed from a different direc

[Lldb-commits] [lldb] r312431 - Add test case for attach-by-pid from different cwd

2017-09-02 Thread Ed Maste via lldb-commits
Author: emaste Date: Sat Sep 2 18:44:35 2017 New Revision: 312431 URL: http://llvm.org/viewvc/llvm-project?rev=312431&view=rev Log: Add test case for attach-by-pid from different cwd This was failing on FreeBSD prior to r312430. Patch by Vignesh Balu. Differential Revision: https://reviews.llv

Re: [Lldb-commits] [lldb] r313210 - Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

2017-09-16 Thread Ed Maste via lldb-commits
On 13 September 2017 at 18:57, Adrian McCarthy via lldb-commits wrote: > Author: amccarth > Date: Wed Sep 13 15:57:11 2017 > New Revision: 313210 > > URL: http://llvm.org/viewvc/llvm-project?rev=313210&view=rev > Log: > Fix for bug 34532 - A few rough corners related to post-mortem debugging > (c

Re: [Lldb-commits] [lldb] r313655 - Re-land r313210 - Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

2017-09-20 Thread Ed Maste via lldb-commits
On 19 September 2017 at 14:07, Adrian McCarthy via lldb-commits wrote: > Author: amccarth > Date: Tue Sep 19 11:07:33 2017 > New Revision: 313655 > > URL: http://llvm.org/viewvc/llvm-project?rev=313655&view=rev > Log: > Re-land r313210 - Fix for bug 34532 - A few rough corners related to > post-m

[Lldb-commits] [lldb] r314672 - Improve FreeBSD kernel debugging

2017-10-02 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Oct 2 07:35:07 2017 New Revision: 314672 URL: http://llvm.org/viewvc/llvm-project?rev=314672&view=rev Log: Improve FreeBSD kernel debugging FreeBSD kernel modules are actually relocatable (.o) ELF files and this previously caused some issues for LLDB. This change address

Re: [Lldb-commits] [lldb] r314458 - [Expression parser] Setting to enable use of ExternalASTMerger

2017-10-02 Thread Ed Maste via lldb-commits
On 28 September 2017 at 22:20, Sean Callanan via lldb-commits wrote: > Author: spyffe > Date: Thu Sep 28 13:20:25 2017 > New Revision: 314458 > > URL: http://llvm.org/viewvc/llvm-project?rev=314458&view=rev > Log: > [Expression parser] Setting to enable use of ExternalASTMerger > ... > + lldb

Re: [Lldb-commits] [lldb] r316728 - Default to using in-tree clang for building test executables

2017-10-28 Thread Ed Maste via lldb-commits
On 26 October 2017 at 22:24, Pavel Labath via lldb-commits wrote: > Author: labath > Date: Thu Oct 26 19:24:04 2017 > New Revision: 316728 > > URL: http://llvm.org/viewvc/llvm-project?rev=316728&view=rev > Log: > Default to using in-tree clang for building test executables The FreeBSD buildbot is

[Lldb-commits] [lldb] r283472 - Match printf field width arg and type

2016-10-06 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Oct 6 12:55:22 2016 New Revision: 283472 URL: http://llvm.org/viewvc/llvm-project?rev=283472&view=rev Log: Match printf field width arg and type A '*' as a field width or precision specifies that the field width or precision is supplied by an int argument. Modified:

Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Ed Maste via lldb-commits
On 6 October 2016 at 16:42, Zachary Turner wrote: > I'm not sure actually. I only noticed this because I was in IRC and I saw > the message go by about the failure. > > Ed (already CC'ed) maintains the FreeBSD builder, so he might have an answer > for you. I'm not sure why it's not on the build.

[Lldb-commits] [PATCH] D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

2016-10-07 Thread Ed Maste via lldb-commits
emaste accepted this revision. emaste added a reviewer: emaste. emaste added a comment. This revision is now accepted and ready to land. Not tested, but looks reasonable to me. I think we should avoid `siginfo_t` altogether here in order to support cross-debugging, but that's for a different cha

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

2016-10-20 Thread Ed Maste via lldb-commits
emaste added a comment. In https://reviews.llvm.org/D25756#574258, @labath wrote: > No, I'm saying someone *should*. :P > > Ed looked into that at some point but, I don't think get got too far with it. > Adding @emaste, who should probably review this. Yes, it needs to be done. Maybe now that

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

2016-10-20 Thread Ed Maste via lldb-commits
emaste added a comment. On a quick look this seems OK. I'll try to test/review in detail. Comment at: source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:925 + + // eRegisterKindDWARF -> RegsiterValue + std::unordered_map m_register_values; typo here Reposito

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

2016-10-21 Thread Ed Maste via lldb-commits
emaste added a subscriber: krytarowski. emaste added a comment. On a quick look this seems OK. I'll try to test/review in detail. In https://reviews.llvm.org/D25756#576642, @dmikulin wrote: > Thanks Pavel! I'll start working on it. Do you know when lldb-server Linux > changes were committed? I

Re: [Lldb-commits] LLGS for Free/NetBSD (was: Re: [PATCH] D25756: FreeBSD ARM support for software single step.)

2016-10-24 Thread Ed Maste via lldb-commits
On 24 October 2016 at 06:26, Pavel Labath wrote: > > It's not my place to tell you how to work, but I'd recommend a > different approach to this. If you base your work on the current > FreeBSD in-process plugin, then when you get around to actually > implementing remote support, you will find that

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-04 Thread Ed Maste via lldb-commits
emaste added a comment. We need to make sure this does not regress FreeBSD core handling -- I will test as soon as I can, and add FXSAVE parsing for FreeBSD. I'll use fpr_sse.cpp to generate FreeBSD core files as well (although note that we get ~2.5MB cores with default configuration, so tweaki

[Lldb-commits] [PATCH] D26315: make-core.sh: add FreeBSD support

2016-11-04 Thread Ed Maste via lldb-commits
emaste created this revision. emaste added a reviewer: labath. emaste added a subscriber: lldb-commits. https://reviews.llvm.org/D26315 Files: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/make-core.sh Index: packages/Python/lldbsuite/test/functionalities/postmortem/l

[Lldb-commits] [PATCH] D26315: make-core.sh: add FreeBSD support

2016-11-04 Thread Ed Maste via lldb-commits
emaste added a comment. Output on FreeBSD, with the patch: % sh make-core.sh main.c + file=main.c + [ -z main.c ] + [ FreeBSD '=' Linux ] + ulimit -c 1000 + ulimit -c + real_limit=1000 + [ 1000 -lt 100 ] + cc -nostdlib -static -g main.c -o a.out + cat Executable file is in a

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-04 Thread Ed Maste via lldb-commits
emaste added a comment. Good point. https://reviews.llvm.org/D26315 has the change to add FreeBSD support to make-core.sh -- just avoiding /bin/bash, and the core file handler check. I think we should be able to rename this directory to elf-core, and rename the individual cores to e.g. linux-i

[Lldb-commits] [PATCH] D26315: make-core.sh: add FreeBSD support

2016-11-05 Thread Ed Maste via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286035: make-core.sh: add FreeBSD support (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D26315?vs=76951&id=76968#toc Repository: rL LLVM https://reviews.llvm.org/D26315 Fi

[Lldb-commits] [lldb] r286035 - make-core.sh: add FreeBSD support

2016-11-05 Thread Ed Maste via lldb-commits
Author: emaste Date: Sat Nov 5 09:45:13 2016 New Revision: 286035 URL: http://llvm.org/viewvc/llvm-project?rev=286035&view=rev Log: make-core.sh: add FreeBSD support Differential Revision: https://reviews.llvm.org/D26315 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

2016-11-14 Thread Ed Maste via lldb-commits
emaste added a comment. I applied this change on top of my WIP https://reviews.llvm.org/D26617 (which adds a FreeBSD core test). LLDB builds and my new test passes, so no objections from me. Once it's in I'll see about porting the new SSE test to FreeBSD too. https://reviews.llvm.org/D26300

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

2016-11-15 Thread Ed Maste via lldb-commits
emaste added a comment. > Ed, what do you think about this one? Is there anyone with a FreeBSD arm64 > setup that could verify this? We have an arm64 reference machine in the FreeBSD cluster and I will test after I return from travel later this week, although perhaps @andrew can try it before

[Lldb-commits] [lldb] r287609 - Turn on LLDB_EDITLINE_USE_WCHAR on FreeBSD

2016-11-21 Thread Ed Maste via lldb-commits
Author: emaste Date: Mon Nov 21 20:25:41 2016 New Revision: 287609 URL: http://llvm.org/viewvc/llvm-project?rev=287609&view=rev Log: Turn on LLDB_EDITLINE_USE_WCHAR on FreeBSD Modified: lldb/trunk/include/lldb/Host/Editline.h Modified: lldb/trunk/include/lldb/Host/Editline.h URL: http://llv

Re: [Lldb-commits] [lldb] r287597 - Add the new Args / entry-access API.

2016-11-21 Thread Ed Maste via lldb-commits
On 21 November 2016 at 18:18, Zachary Turner via lldb-commits wrote: > Author: zturner > Date: Mon Nov 21 17:18:07 2016 > New Revision: 287597 > > URL: http://llvm.org/viewvc/llvm-project?rev=287597&view=rev > Log: > Add the new Args / entry-access API. FreeBSD buildbot is now failing with: http:

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

2016-11-24 Thread Ed Maste via lldb-commits
emaste added a comment. The tests are not in great shape on FreeBSD/arm64 today, but look roughly equivalent with and without this patch. At https://reviews.llvm.org/rL287887: === Test Result Summary === Test Methods: 1148 Reruns: 16

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

2016-11-24 Thread Ed Maste via lldb-commits
emaste added a comment. In https://reviews.llvm.org/D25947#597160, @labath wrote: > Ed, if I may suggest, while you are playing with the arm machine, could you > grab us a core file or two? It'd be great to be able to do a basic sanity > check on these things without physical access. I used m

[Lldb-commits] [lldb] r292937 - FreeBSD ARM support for software single step

2017-01-24 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Jan 24 08:34:49 2017 New Revision: 292937 URL: http://llvm.org/viewvc/llvm-project?rev=292937&view=rev Log: FreeBSD ARM support for software single step Implementation of software single step for FreeBSD on ARM. The code is largely based on the Linux implementation of the

[Lldb-commits] [lldb] r294340 - Synchronize PlatformFreeBSD with Linux

2017-02-07 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Feb 7 13:29:10 2017 New Revision: 294340 URL: http://llvm.org/viewvc/llvm-project?rev=294340&view=rev Log: Synchronize PlatformFreeBSD with Linux Inspired by r294145 for NetBSD, this reduces diffs between the FreeBSD and Linux/NetBSD Platform implementations. Further dif

Re: [Lldb-commits] [PATCH] D13312: Fix Windows build due to missing path.

2015-09-30 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. emaste added a comment. > I'm not sure why it didn't break other platforms. It did - perhaps it worked only on OS X due to xcode path differences? It was fixed by http://reviews.llvm.org/rL248956. http://reviews.llvm.org/D13312 ___

Re: [Lldb-commits] [PATCH] D13028: Merge dsym and dwarf test cases

2015-10-01 Thread Ed Maste via lldb-commits
emaste added a comment. > I'm leaving shortly to travel to EuroBSDCon so probably will not be able to > test before Wednesday, but I can investigate and update decorators as > appropriate afterwards. A follow up - the tests look good on FreeBSD after this change. On my branch with a few updat

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

2015-10-02 Thread Ed Maste via lldb-commits
emaste added inline comments. Comment at: source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp:1 @@ +1,2 @@ +//===-- PlatformNetBSD.cpp -*- C++ -*-===// +// krytarowski wrote: > labath wrote: > > krytarowski wrote: > > > labath wro

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

2015-10-02 Thread Ed Maste via lldb-commits
On 1 October 2015 at 23:09, Kamil Rytarowski via lldb-commits wrote: > > Yes, please! Better incomplete support in the source trees then once > almost complete but rotting in a local patch... I agree - I think it's better to get basic support in as soon as possible and we can refactor as appropri

[Lldb-commits] [lldb] r249561 - Add expectedFailureFreeBSD for Go runtime test

2015-10-07 Thread Ed Maste via lldb-commits
Author: emaste Date: Wed Oct 7 11:21:43 2015 New Revision: 249561 URL: http://llvm.org/viewvc/llvm-project?rev=249561&view=rev Log: Add expectedFailureFreeBSD for Go runtime test AssertionError: False is not True : No thread stopped at our breakpoint. llvm.org/pr24895 Modified: lldb/trunk/

Re: [Lldb-commits] [PATCH] D13334: Preliminary NetBSD support

2015-10-12 Thread Ed Maste via lldb-commits
emaste added a comment. OK by me. I'd also like to see less duplication, but have no objection to this as it is now. Repository: rL LLVM http://reviews.llvm.org/D13334 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.o

Re: [Lldb-commits] [lldb] r250306 - Fix Python initialization for Python 3.

2015-10-14 Thread Ed Maste via lldb-commits
On 14 October 2015 at 13:51, Zachary Turner via lldb-commits wrote: > Author: zturner > Date: Wed Oct 14 12:51:29 2015 > New Revision: 250306 > > URL: http://llvm.org/viewvc/llvm-project?rev=250306&view=rev > Log: > Fix Python initialization for Python 3. This introduced a new warning for me: ..

[Lldb-commits] [lldb] r251088 - Add arm64 FreeBSD ProcessMonitor register context

2015-10-22 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Oct 22 20:10:42 2015 New Revision: 251088 URL: http://llvm.org/viewvc/llvm-project?rev=251088&view=rev Log: Add arm64 FreeBSD ProcessMonitor register context Modified: lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp Modified: lldb/trunk/source/Plugins/Pro

Re: [Lldb-commits] [lldb] r251537 - Make core files not crash when you load a core file into LLDB with just "lldb -c core".

2015-10-28 Thread Ed Maste via lldb-commits
On 28 October 2015 at 18:04, Greg Clayton via lldb-commits wrote: > +// LLDB_NT_OWNER_CORE and LLDB_NT_OWNER_LINUX note contants > +#define NT_PRSTATUS 1 > +#define NT_PRFPREG 2 > +#define NT_PRPSINFO 3 > +#define NT_TASKSTRUCT 4 > +#define NT_AUXV

Re: [Lldb-commits] [PATCH] D14182: Centos 5 compile fixes for lldb

2015-10-30 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. emaste added a comment. For future diffs please include additional context (e.g. git diff -U9) Repository: rL LLVM http://reviews.llvm.org/D14182 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

Re: [Lldb-commits] [PATCH] D14042: Add more NetBSD platform glue for lldb

2015-11-06 Thread Ed Maste via lldb-commits
emaste accepted this revision. emaste added a comment. Fine by me. I'm not sure how we ended up with the Python-with-semicolons in scripts/buildSwigWrapperClasses.py (prior to this change) though. Repository: rL LLVM http://reviews.llvm.org/D14042

[Lldb-commits] [lldb] r253601 - Plug-in PlatformNetBSD initializer and terminator

2015-11-19 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Nov 19 15:30:22 2015 New Revision: 253601 URL: http://llvm.org/viewvc/llvm-project?rev=253601&view=rev Log: Plug-in PlatformNetBSD initializer and terminator Patch by Kamil Rytarowski Differential Revision: http://reviews.llvm.org/D14530 Modified: lldb/trunk/source

Re: [Lldb-commits] [PATCH] D14530: Plug-in PlatformNetBSD initializer and terminator

2015-11-19 Thread Ed Maste via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253601: Plug-in PlatformNetBSD initializer and terminator (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D14530?vs=39788&id=40700#toc Repository: rL LLVM http://reviews.llvm.

[Lldb-commits] [lldb] r253699 - Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD

2015-11-20 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri Nov 20 13:32:58 2015 New Revision: 253699 URL: http://llvm.org/viewvc/llvm-project?rev=253699&view=rev Log: Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD Patch by Kamil Rytarowski Differential Revision: http://reviews.llvm.org/D14876 Modified:

Re: [Lldb-commits] [PATCH] D14876: Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD

2015-11-20 Thread Ed Maste via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253699: Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D14876?vs=40796&id=40808#toc Repository: rL LLVM h

[Lldb-commits] [lldb] r253998 - Add expectedFailureFreeBSD decorators for new Python fd leak

2015-11-24 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Nov 24 12:05:56 2015 New Revision: 253998 URL: http://llvm.org/viewvc/llvm-project?rev=253998&view=rev Log: Add expectedFailureFreeBSD decorators for new Python fd leak llvm.org/pr25624 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/avoids-fd-le

[Lldb-commits] [lldb] r254000 - Remove expectedFailureFreeBSD from passing ThreadExitTestCase::test_with_dwarf

2015-11-24 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Nov 24 12:22:37 2015 New Revision: 254000 URL: http://llvm.org/viewvc/llvm-project?rev=254000&view=rev Log: Remove expectedFailureFreeBSD from passing ThreadExitTestCase::test_with_dwarf This passes on my FreeBSD stable/10 desktop and my new FreeBSD 11-current buildbot (w

[Lldb-commits] [lldb] r254001 - Remove expectedFailureFreeBSD decorator from now-passing tests

2015-11-24 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Nov 24 12:30:19 2015 New Revision: 254001 URL: http://llvm.org/viewvc/llvm-project?rev=254001&view=rev Log: Remove expectedFailureFreeBSD decorator from now-passing tests These pass on my FreeBSD stable/10 desktop and my (not-yet-connected) FreeBSD 11-CURRENT buildbot ll

[Lldb-commits] [lldb] r254002 - Add expectedFlakeyFreeBSD to TestBatchMode failing on buildbot

2015-11-24 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Nov 24 12:34:17 2015 New Revision: 254002 URL: http://llvm.org/viewvc/llvm-project?rev=254002&view=rev Log: Add expectedFlakeyFreeBSD to TestBatchMode failing on buildbot This test was already expectedFlakeyLinux for occasional failures on the Linux buildbot. It seems the

[Lldb-commits] [lldb] r254006 - Temporarily add expectedFailureFreeBSD to tests that fail to detect Clang on FreeBSD

2015-11-24 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Nov 24 12:59:51 2015 New Revision: 254006 URL: http://llvm.org/viewvc/llvm-project?rev=254006&view=rev Log: Temporarily add expectedFailureFreeBSD to tests that fail to detect Clang on FreeBSD On FreeBSD we may get Clang via CC=cc or CC=/usr/bin/cc. llvm.org/pr25626 Mo

Re: [Lldb-commits] [lldb] r254006 - Temporarily add expectedFailureFreeBSD to tests that fail to detect Clang on FreeBSD

2015-11-24 Thread Ed Maste via lldb-commits
On 24 November 2015 at 13:59, Ed Maste via lldb-commits wrote: > Author: emaste > Date: Tue Nov 24 12:59:51 2015 > New Revision: 254006 > > URL: http://llvm.org/viewvc/llvm-project?rev=254006&view=rev > Log: > Temporarily add expectedFailureFreeBSD to tests that fail to d

Re: [Lldb-commits] [PATCH] D15263: Add NetBSD in platform specific logging of the specified category in RegisterCommandsTestCase()

2015-12-06 Thread Ed Maste via lldb-commits
emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. We could probably replace these freebsd/linux/netbsd cases with a routine that strips trailing digits. Repository: rL LLVM http://reviews.llvm.org/D15263 ___

Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

2015-12-06 Thread Ed Maste via lldb-commits
emaste added inline comments. Comment at: packages/Python/lldbsuite/test/lldbtest.py:832-834 @@ -828,2 +831,5 @@ +def expectedFlakeyNetBSD(bugnumber=None, compilers=None): +return expectedFlakeyOS(['netbsd'], bugnumber, compilers) + def expectedFlakeyLinux(bugnumber=None, c

[Lldb-commits] [lldb] r255049 - Remove default case in switch which covers all enumeration values

2015-12-08 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Dec 8 14:50:35 2015 New Revision: 255049 URL: http://llvm.org/viewvc/llvm-project?rev=255049&view=rev Log: Remove default case in switch which covers all enumeration values This also conveniently eliminates another warning from the unintentional use of a trigraph: warni

Re: [Lldb-commits] [PATCH] D15374: Add NetBSD support in the buildDriver and buildLibrary routines

2015-12-09 Thread Ed Maste via lldb-commits
emaste requested changes to this revision. This revision now requires changes to proceed. Comment at: packages/Python/lldbsuite/test/lldbtest.py:2100 @@ -2099,3 +2099,3 @@ } -elif sys.platform.startswith('freebsd') or sys.platform.startswith("linux") or o

Re: [Lldb-commits] [PATCH] D20106: Generalize child process monitoring functions

2016-05-10 Thread Ed Maste via lldb-commits
emaste added a comment. Nice. For test building FreeBSD, snapshot VM images are available at ftp://ftp.freebsd.org/pub/FreeBSD/snapshots/VM-IMAGES/11.0-CURRENT/amd64/Latest/ and I have some instructions for building lldb on FreeBSD at https://wiki.freebsd.org/lldb. http://reviews.llvm.org/D2

Re: [Lldb-commits] [lldb] r269025 - Fix race in TestExitDuringStep and unify pseudo_barrier handling

2016-05-10 Thread Ed Maste via lldb-commits
On 10 May 2016 at 03:54, Pavel Labath via lldb-commits wrote: > Author: labath > Date: Tue May 10 02:54:25 2016 > New Revision: 269025 > > URL: http://llvm.org/viewvc/llvm-project?rev=269025&view=rev > Log: > Fix race in TestExitDuringStep and unify pseudo_barrier handling After this change TestT

Re: [Lldb-commits] [lldb] r269025 - Fix race in TestExitDuringStep and unify pseudo_barrier handling

2016-05-11 Thread Ed Maste via lldb-commits
On 11 May 2016 at 10:10, Pavel Labath wrote: > Hi, > > so I think this is our old "compiler generates unpredictable number of > source locations for a line" friend again, which got triggered by a > random code reshuffle. Assuming the test still passes for you after > that, can you prepare a change

Re: [Lldb-commits] [PATCH] D20188: Turn on LLDB_EDITLINE_USE_WCHAR on NetBSD

2016-05-11 Thread Ed Maste via lldb-commits
emaste added inline comments. Comment at: include/lldb/Host/Editline.h:33 @@ -31,3 +32,3 @@ // components needed to handle wide characters ( , codecvt_utf8, libedit built with '--enable-widec' ) -// are not consistenly available on non-OSX platforms. The wchar_t versions of li

Re: [Lldb-commits] [PATCH] D20188: Turn on LLDB_EDITLINE_USE_WCHAR on NetBSD

2016-05-12 Thread Ed Maste via lldb-commits
emaste accepted this revision. emaste added a comment. Thanks. (The reason I mentioned it is that I'll add __FreeBSD__ shortly.) http://reviews.llvm.org/D20188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [Lldb-commits] [lldb] r269025 - Fix race in TestExitDuringStep and unify pseudo_barrier handling

2016-05-12 Thread Ed Maste via lldb-commits
On 11 May 2016 at 11:39, Pavel Labath wrote: > > Working around it this way is quite ugly. Let's try something else. > Would getting rid of the do{}while loop in the macro fix the problem? > I added it to make the macro a bit more safe, but I don't think it's > really necessary... Indeed, the tes

[Lldb-commits] [lldb] r269421 - Remove unused variable

2016-05-13 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri May 13 09:49:38 2016 New Revision: 269421 URL: http://llvm.org/viewvc/llvm-project?rev=269421&view=rev Log: Remove unused variable Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified: lldb/trunk/source/Plugins/ExpressionPars

Re: [Lldb-commits] [lldb] r269377 - Fix some long standing issues that caused tests to be flaky.

2016-05-13 Thread Ed Maste via lldb-commits
On 12 May 2016 at 18:58, Greg Clayton via lldb-commits wrote: > Author: gclayton > Date: Thu May 12 17:58:52 2016 > New Revision: 269377 > > URL: http://llvm.org/viewvc/llvm-project?rev=269377&view=rev > Log: > Fix some long standing issues that caused tests to be flaky. On FreeBSD lldb now hits

[Lldb-commits] [lldb] r269434 - Disable HostThread::Cancel assertion on FreeBSD

2016-05-13 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri May 13 12:01:59 2016 New Revision: 269434 URL: http://llvm.org/viewvc/llvm-project?rev=269434&view=rev Log: Disable HostThread::Cancel assertion on FreeBSD It is still used by ProcessMonitor::StopMonitoringChildProcess and ProcessMonitor::StopOpThread. Modified: lldb

Re: [Lldb-commits] [lldb] r269377 - Fix some long standing issues that caused tests to be flaky.

2016-05-13 Thread Ed Maste via lldb-commits
On 13 May 2016 at 11:23, Ed Maste wrote: > On 12 May 2016 at 18:58, Greg Clayton via lldb-commits > wrote: >> Author: gclayton >> Date: Thu May 12 17:58:52 2016 >> New Revision: 269377 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=269377&view=rev >> Log: >> Fix some long standing issues that

Re: [Lldb-commits] [PATCH] D20274: Add preliminary bits for Plugins/Process/NetBSD

2016-05-16 Thread Ed Maste via lldb-commits
emaste added a comment. In http://reviews.llvm.org/D20274#431058, @clayborg wrote: > What linux and macosx do is even when debugging locally we run through > lldb-server (a GDB remote protocol server). And this is the way we plan to go on FreeBSD as well and will drop the in-process debugging

Re: [Lldb-commits] [lldb] r270488 - We have many radars showing that stepping through C++ code can result in slow steps.

2016-05-24 Thread Ed Maste via lldb-commits
On 23 May 2016 at 16:37, Greg Clayton via lldb-commits wrote: > Author: gclayton > Date: Mon May 23 15:37:24 2016 > New Revision: 270488 > > URL: http://llvm.org/viewvc/llvm-project?rev=270488&view=rev > Log: > We have many radars showing that stepping through C++ code can result in slow > steps.

Re: [Lldb-commits] [lldb] r270488 - We have many radars showing that stepping through C++ code can result in slow steps.

2016-05-24 Thread Ed Maste via lldb-commits
On 24 May 2016 at 15:18, Pavel Labath wrote: > r270570 fixed it for me. Indeed, thank you. ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r270603 - xfail TestRedefinitionsInline with older Clang

2016-05-24 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue May 24 14:51:11 2016 New Revision: 270603 URL: http://llvm.org/viewvc/llvm-project?rev=270603&view=rev Log: xfail TestRedefinitionsInline with older Clang This fails on FreeBSD 10 with the system compiler, Clang 3.4.1. llvm.org/pr27845 Modified: lldb/trunk/packages

Re: [Lldb-commits] [PATCH] D20671: [cmake] Add a big warning about a libstdc++ issue

2016-05-26 Thread Ed Maste via lldb-commits
emaste added a comment. FreeBSD 10.0 and later uses libc++. FreeBSD 9 has a very old libstdc++ and a very old gcc and can't build Clang 3.5 or later with the system compiler anyway. So this isn't a problem for FreeBSD. I don't know cmake well enough to approve the change but the idea definitely

Re: [Lldb-commits] [lldb] r270891 - Make sure that we succeed in starting a definition before we complete it and emit an error if we fail to start the definition.

2016-05-31 Thread Ed Maste via lldb-commits
On 26 May 2016 at 15:24, Greg Clayton via lldb-commits wrote: > Author: gclayton > Date: Thu May 26 14:24:02 2016 > New Revision: 270891 > > URL: http://llvm.org/viewvc/llvm-project?rev=270891&view=rev > Log: > Make sure that we succeed in starting a definition before we complete it and > emit an

Re: [Lldb-commits] [lldb] r270891 - Make sure that we succeed in starting a definition before we complete it and emit an error if we fail to start the definition.

2016-05-31 Thread Ed Maste via lldb-commits
On 31 May 2016 at 16:24, Ed Maste wrote: > > ../tools/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1762:61: > warning: data argument not used by format string [-Wformat-extra-args] > type_name_cstr); >

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-18 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. Comment at: docs/Proposals/GitHub.rst:8-9 @@ +7,4 @@ + +This is a proposal to move our current revision control system from Subversion +to GitHub. Below are the financial and technical arguments as to why we need +such a move and how will people

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-19 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. emaste added a comment. I'm testing on FreeBSD now https://reviews.llvm.org/D20436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-19 Thread Ed Maste via lldb-commits
emaste added a comment. With this patch, test results on FreeBSD are consistent. https://reviews.llvm.org/D20436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r275983 - Typo corrections identified by codespell

2016-07-19 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Jul 19 10:28:02 2016 New Revision: 275983 URL: http://llvm.org/viewvc/llvm-project?rev=275983&view=rev Log: Typo corrections identified by codespell Submitted by giffu...@yahoo.com; I fixed a couple of nearby errors and incorrect changes in the patch. llvm.org/pr27634 M

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-25 Thread Ed Maste via lldb-commits
emaste added a comment. Is this ready to be committed? https://reviews.llvm.org/D20436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22950: Centralize all calls to select() into a single class so we always call select properly

2016-08-02 Thread Ed Maste via lldb-commits
emaste added a comment. > This is a particular problem on OS X because we support debugging with the > debug info in .o files, so for a complex project we could be opening lots of > those files. If you don't do that, then it's more like number of shared > libraries a normal program will open. T

[Lldb-commits] [lldb] r278625 - elf-core: set powerpc vector byte order correctly

2016-08-14 Thread Ed Maste via lldb-commits
Author: emaste Date: Sun Aug 14 06:30:11 2016 New Revision: 278625 URL: http://llvm.org/viewvc/llvm-project?rev=278625&view=rev Log: elf-core: set powerpc vector byte order correctly It was being set to the fp reg set's byte order due to an apparent copy-and-pasteo.

Re: [Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

2016-08-29 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. emaste added a comment. - in the future can you please upload with context (e.g. git diff -U) - I think the OS names in utilsOsType.py are kept sorted and the actual enum values are not part of an ABI https://reviews.llvm.org/D23977

[Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

2016-09-06 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Sep 6 16:25:31 2016 New Revision: 280755 URL: http://llvm.org/viewvc/llvm-project?rev=280755&view=rev Log: Reorder FreeBSD Host.cpp #includes to fix build Modified: lldb/trunk/source/Host/freebsd/Host.cpp Modified: lldb/trunk/source/Host/freebsd/Host.cpp URL: http:

Re: [Lldb-commits] [PATCH] D24293: Use llvm's demangler

2016-09-07 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. emaste added a comment. Which library contains `llvm::itaniumDemangle`? https://reviews.llvm.org/D24293 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] r280931 - Fix unused variable and integer sign warnings from r280906

2016-09-08 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Sep 8 08:11:31 2016 New Revision: 280931 URL: http://llvm.org/viewvc/llvm-project?rev=280931&view=rev Log: Fix unused variable and integer sign warnings from r280906 Modified: lldb/trunk/source/Core/Disassembler.cpp Modified: lldb/trunk/source/Core/Disassembler.cpp

[Lldb-commits] [lldb] r280933 - Fix -Wcovered-switch-default warning in AppleObjCRuntimeV2.cpp

2016-09-08 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Sep 8 08:17:42 2016 New Revision: 280933 URL: http://llvm.org/viewvc/llvm-project?rev=280933&view=rev Log: Fix -Wcovered-switch-default warning in AppleObjCRuntimeV2.cpp The switch coveres all possible values. If a new one is added in the future the compiler will start w

  1   2   3   >