This revision was automatically updated to reflect the committed changes.
Closed by commit rL282529: Adding a RegisterContextMinidump_x86_64 converter
(authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D24919?vs=72688&id=72689#toc
Repository:
rL LLVM
https://reviews
Hi,
Is the work that you are currently doing the reason why the lldb build on
i386 is failing?
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/20099
Dimitar
On Thu, Sep 29, 2016 at 5:30 AM, Jason Molenda vi
This is the first build that failed right after your CL:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/20083
On Thu, Sep 29, 2016 at 1:35 PM, Dimitar Vlahovski
wrote:
> Hi,
>
> Is the work that you are currently doing the reason why the lldb build on
> i386 is failing?
Author: dvlahovski
Date: Fri Sep 30 09:36:17 2016
New Revision: 282862
URL: http://llvm.org/viewvc/llvm-project?rev=282862&view=rev
Log:
Fixing windows build breakage caused by rL282822
The breakage was because of the moving of the UTF functions to the llvm
namespace
Modified:
lldb/trunk/sou
Author: dvlahovski
Date: Fri Sep 30 10:41:33 2016
New Revision: 282866
URL: http://llvm.org/viewvc/llvm-project?rev=282866&view=rev
Log:
Again fixing windows build breakage like in rL282862
Modified:
lldb/trunk/source/Host/windows/Windows.cpp
Modified: lldb/trunk/source/Host/windows/Windows.
Hi,
Are these build breakages somehow connected to this commit?
http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/8703
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-
14.04-android/builds/9655
Thanks,
Dimitar
On Fri, Sep 30, 2016 at 11:07 PM, Jim Ingham via lldb-commits <
lldb-
dvlahovski created this revision.
dvlahovski added reviewers: labath, zturner.
dvlahovski added subscribers: lldb-commits, amccarth.
Herald added subscribers: modocache, mgorny, beanz.
This plugin resembles the already existing Windows-only Minidump plugin.
The WinMinidumpPlugin uses the Windows A
dvlahovski added a comment.
So, there will be changes to the way I handle the case where there is no
ExceptionStream - I will probably create a StopReason = None. But I have to
investigate if in that case lldb still hangs because it's trying to resume a
process (that does not exists). I will as
dvlahovski added inline comments.
> labath wrote in ProcessMinidump.cpp:67
> It already is return true.
>
> Is that correct?
What I meant here is: is there functionality that needs to be added here.
In the WinMinidump plugin, this method is only returning true (as mine) and has
a TODO saying t
dvlahovski added a comment.
In https://reviews.llvm.org/D25196#559368, @amccarth wrote:
> I was hoping that, with your new mini dump parser, you'd be able to eliminate
> the need for the Windows-specific minidump process plugin.
>
> When I wrote the Windows mini dump plugin, I tried to isolate t
dvlahovski added inline comments.
> labath wrote in TestMiniDumpNew.py:19
> You can replace these with `NO_DEBUG_INFO_TESTCASE = True` at class level.
But, should `test_deeper_stack_in_mini_dump` and
`test_local_variables_in_mini_dump` not have this decorator ?
https://reviews.llvm.org/D25196
dvlahovski marked 5 inline comments as done.
dvlahovski added inline comments.
> labath wrote in TestMiniDumpNew.py:19
> They are not building any code, so the would behave the same way anyway. You
> would be just running the test 2--3 times for nothing.
Aah I understand now. Ok thanks :)
http
dvlahovski updated this revision to Diff 73504.
dvlahovski marked 7 inline comments as done.
dvlahovski added a comment.
Updated the CL with regard to Pavel's comments
https://reviews.llvm.org/D25196
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/Makefile
pa
dvlahovski updated this revision to Diff 73516.
dvlahovski marked 5 inline comments as done.
dvlahovski added a comment.
Second iteration over CL - regarded Pavel's comments and encapsulated m_data_sp
more in MinidumpParser
https://reviews.llvm.org/D25196
Files:
packages/Python/lldbsuite/te
dvlahovski updated this revision to Diff 73526.
dvlahovski marked 6 inline comments as done.
dvlahovski added a comment.
Changes after Zachary's comments
https://reviews.llvm.org/D25196
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/Makefile
packages/Python/
dvlahovski marked an inline comment as done.
dvlahovski added inline comments.
> zturner wrote in MinidumpParser.cpp:81-82
> Change this line to `return GetData().slice(iter->second.rva,
> iter->second.data_size);`
Nice! :)
> zturner wrote in MinidumpParser.h:35-36
> If the comment is long en
dvlahovski updated this revision to Diff 73541.
dvlahovski marked 2 inline comments as done.
dvlahovski added a comment.
Added a sanity check for loc_descr
https://reviews.llvm.org/D25196
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/Makefile
packages/Pytho
Author: dvlahovski
Date: Tue Oct 4 16:02:13 2016
New Revision: 283259
URL: http://llvm.org/viewvc/llvm-project?rev=283259&view=rev
Log:
Adding a new Minidump post-mortem debugging plugin
Summary:
This plugin resembles the already existing Windows-only Minidump plugin.
The WinMinidumpPlugin uses
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283259: Adding a new Minidump post-mortem debugging plugin
(authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D25196?vs=73541&id=73551#toc
Repository:
rL LLVM
https://review
Author: dvlahovski
Date: Tue Oct 4 16:55:47 2016
New Revision: 283263
URL: http://llvm.org/viewvc/llvm-project?rev=283263&view=rev
Log:
xfailing tests for Minidump plugin
the tests are failing on the buildbot because there is an extra frame
(maybe) on the call stack.
Will investigate tomorrow.
Thanks :)
On Wed, Oct 5, 2016 at 1:07 AM, Jim Ingham via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: jingham
> Date: Tue Oct 4 19:07:01 2016
> New Revision: 283276
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283276&view=rev
> Log:
> Add the new minidump files to the Xcode p
101 - 121 of 121 matches
Mail list logo
