[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione updated this revision to Diff 495899. kastiglione added a comment. replace raise with assertTrue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/ https://reviews.llvm.org/D141425 Files: lldb/source/Commands/CommandObjectDWIM

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

This revision was automatically updated to reflect the committed changes. Closed by commit rGd160873c03ae: [lldb] Add --gdb-format flag to dwim-print (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/ https://review

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix logic for repeat commands, so that regex commands (specificially `bt`) ar

[Lldb-commits] [PATCH] D143690: [lldb] Add the ability to provide a message to a progress event update

kastiglione accepted this revision. kastiglione added a comment. nice Comment at: lldb/include/lldb/Core/DebuggerEvents.h:48-49 + } + const std::string &GetTitle() const { return m_title; } + const std::string &GetUpdate() const { return m_update; } bool IsDebuggerSpecifi

[Lldb-commits] [PATCH] D143690: [lldb] Add the ability to provide a message to a progress event update

kastiglione added a comment. details is good, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143690/new/ https://reviews.llvm.org/D143690 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [PATCH] D144042: [lldb] Rename SetResultIsInternal to SetSuppressPersistentResult (NFC)

kastiglione created this revision. kastiglione added reviewers: jingham, Michael137, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Rename `SetResultIsInternal` and `GetResultIsInternal

[Lldb-commits] [PATCH] D144044: [lldb] Suppress persistent result when running po

kastiglione created this revision. kastiglione added reviewers: jingham, Michael137, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Remove the persistent result variable after executing

[Lldb-commits] [PATCH] D144044: [lldb] Suppress persistent result when running po

kastiglione added a comment. I'll update with a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144044/new/ https://reviews.llvm.org/D144044 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D144044: [lldb] Suppress persistent result when running po

kastiglione updated this revision to Diff 497453. kastiglione added a comment. Respect verbosity level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144044/new/ https://reviews.llvm.org/D144044 Files: lldb/source/Commands/CommandObjectExpression

[Lldb-commits] [PATCH] D144044: [lldb] Suppress persistent result when running po

kastiglione updated this revision to Diff 497466. kastiglione added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144044/new/ https://reviews.llvm.org/D144044 Files: lldb/source/Commands/CommandObjectExpression.cpp lldb/te

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione created this revision. kastiglione added reviewers: jingham, Michael137, augusto2112, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adopt `expression`'s options in `dwim-print`

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione updated this revision to Diff 497720. kastiglione added a comment. Some `expression` flags force the use of expression evaluation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144114/new/ https://reviews.llvm.org/D144114 Files: lldb

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione updated this revision to Diff 497723. kastiglione added a comment. Use `expression`'s "description verbosity" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144114/new/ https://reviews.llvm.org/D144114 Files: lldb/source/Commands/Comm

[Lldb-commits] [PATCH] D144138: [lldb] Remove pydoc import during script interpreter init

kastiglione created this revision. kastiglione added reviewers: jasonmolenda, mib, jingham, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The Python script interpreter imports `pydoc` duri

[Lldb-commits] [PATCH] D144138: [lldb] Remove pydoc import during script interpreter init

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1ddfa6d8a72: [lldb] Remove pydoc import during script interpreter init (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144138/new/

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione updated this revision to Diff 498054. kastiglione added a comment. Use only a subset of expression flags. Specifically, don't expose `--debug`/`-g` or `--top-level`/`-p`. These, unlike the other `expression` flags, the semantics of these flags would seem to force `expression` evaluati

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:68 // First, try `expr` as the name of a frame variable. - if (StackFrame *frame = m_exe_ctx.GetFramePtr()) { -auto valobj_sp = frame->FindVariable(ConstString(expr)); -if (

[Lldb-commits] [PATCH] D144230: [lldb] Make use of persistent result variables configurable

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Context: The `expression` command uses artificial variables to store

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione updated this revision to Diff 498241. kastiglione added a comment. Add and adopt new variation of OptionGroupOptions::Append Pass OptionGroupValueObjectDisplay to GetEvalateExpressionOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione updated this revision to Diff 498245. kastiglione added a comment. - Fix bug in new OptionGroupOptions::Append - Fix typo in GetEvaluateExpressionOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144114/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D144042: [lldb] Rename SetResultIsInternal to SetSuppressPersistentResult (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3215c810617: [lldb] Rename SetResultIsInternal to SetSuppressPersistentResult (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D144044: [lldb] Suppress persistent result when running po

This revision was automatically updated to reflect the committed changes. Closed by commit rG3328ee550c86: [lldb] Suppress persistent result when running po (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144044/new/ https:/

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/

kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:225 if (valobj_sp) +SyntheticChildrenFrontEnd(*valobj_sp); Update(); Michael137 wrote: > Michael137 wrote: > > Michael137 wrote: > > > this won't initiali

[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/

kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/NSSet.cpp:673-675 if (valobj_sp) +SyntheticChildrenFrontEnd(*valobj_sp); Update(); by the way, these changes are missing `{}` around the `if` body. Repository: rG LLV

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione updated this revision to Diff 498387. kastiglione added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144230/new/ https://reviews.llvm.org/D144230 Files: lldb/source/Commands/CommandObjectDWIMPrint.cpp lldb/sou

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectExpression.cpp:149 + case 'C': { +// 'C' for "caching", since both 'P' and 'p' for persist are taken. Both 'R' aprantl wrote: > Do we expect people to actually use this flag

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione updated this revision to Diff 498390. kastiglione added a comment. fix Makefile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144230/new/ https://reviews.llvm.org/D144230 Files: lldb/source/Commands/CommandObjectDWIMPrint.cpp lldb/

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione updated this revision to Diff 498394. kastiglione added a comment. Remove short option -C, leaving only --persistent-result Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144230/new/ https://reviews.llvm.org/D144230 Files: lldb/source

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:389 "not supported by the interpreter (defaults to true).">; + def persistent_result : Option<"persistent-result", "\\x01">, Groups<[1,2]>, +Arg<"Boolean">, aprantl wrote: >

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:119 } + +llvm::ArrayRef jingham wrote: > jingham wrote: > > There's a version of Append that lets you exclude and remap option sets. > > This seems like a finer-grai

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione updated this revision to Diff 498462. kastiglione added a comment. Improve handling of `po` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144230/new/ https://reviews.llvm.org/D144230 Files: lldb/source/Commands/CommandObjectDWIMPrint

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

kastiglione updated this revision to Diff 498536. kastiglione added a comment. Fix composition of --persistent-result and -O/-v Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144230/new/ https://reviews.llvm.org/D144230 Files: lldb/source/Command

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

This revision was automatically updated to reflect the committed changes. Closed by commit rG920b46e108b2: [lldb] Add expression command options in dwim-print (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144114/new/ https

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63c77bf71d80: [lldb] Make persisting result variables configurable (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D145124: [lldb] Add variable completion to dwim-print

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Enable completion of variables for `dwim-print` command. Repository: rG L

[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, jingham, labath, werat. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-comm

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

kastiglione added a comment. Given that json numbers are read into double, should the addresses be stored as strings to avoid any issues with address integer values that can't be represented as double (>=2**53)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D145348: [lldb] Test 'v' support for direct ivar access (NFC)

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add basic tests for `frame variable`'s ability to direct access field

[Lldb-commits] [PATCH] D145348: [lldb] Test 'v' support for direct ivar access (NFC)

kastiglione updated this revision to Diff 502716. kastiglione added a comment. Split into separate cpp/this and objc/self tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145348/new/ https://reviews.llvm.org/D145348 Files: lldb/test/API/comma

[Lldb-commits] [PATCH] D145348: [lldb] Test 'v' support for direct ivar access (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03e5c46e15b4: [lldb] Test 'v' support for direct ivar access (NFC)

[Lldb-commits] [PATCH] D145124: [lldb] Add variable completion to dwim-print

This revision was automatically updated to reflect the committed changes. Closed by commit rG8794712e8877: [lldb] Add variable completion to dwim-print (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145124/new/ https://revi

[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

kastiglione added a comment. > So, one could say that (right now) this patch is NFC for end-users, because > `dwim-print` supports all use-cases that the old `p` alias supported? Correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145189/new/

[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

This revision was automatically updated to reflect the committed changes. Closed by commit rGa00801d94b02: [lldb] Redefine p alias to dwim-print command (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145189/new/ https://rev

[Lldb-commits] [PATCH] D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this

kastiglione created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. kastiglione updated this revision to Diff 502753. kastiglione added a comment. kastiglione edited the summary of this revision. kastiglione added reviewers: aprantl, Michael137, jingham. kastiglion

[Lldb-commits] [PATCH] D145437: [lldb-vscode] Use `expression` command for completion

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Change lldb-vscode to use the `expression` command for generating completions

[Lldb-commits] [PATCH] D145437: [lldb-vscode] Use `expression` command for completion

kastiglione updated this revision to Diff 503105. kastiglione added a comment. Fix adjacent code and make the tests pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145437/new/ https://reviews.llvm.org/D145437 Files: lldb/tools/lldb-vscode/lld

[Lldb-commits] [PATCH] D145437: [lldb-vscode] Use `expression` command for completion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe221dab07815: [lldb-vscode] Use `expression` command for completion (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this

kastiglione added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9818 +if (ClangASTMetadata *metadata = GetMetadata(fun_decl)) + return metadata->GetObjectPtrLanguage(); + } aprantl wrote: > Couple of questions for

[Lldb-commits] [PATCH] D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this

kastiglione added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9818 +if (ClangASTMetadata *metadata = GetMetadata(fun_decl)) + return metadata->GetObjectPtrLanguage(); + } kastiglione wrote: > aprantl wrote: > >

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

kastiglione updated this revision to Diff 503142. kastiglione added a comment. Introduce new allow_repeat_command parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143695/new/ https://reviews.llvm.org/D143695 Files: lldb/include/lldb/Inter

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

kastiglione added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2005 // stored "repeat command" which we should give a chance to produce it's // repeat command, even though we don't add repeat commands to the history. +Args command_args

[Lldb-commits] [PATCH] D145529: [lldb] Change default value of dwim-print-verbosity setting

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Reduce the default value of `dwim-print-verbosity` to `eDWIMPrintVerbosityNon

[Lldb-commits] [PATCH] D145529: [lldb] Change default value of dwim-print-verbosity setting

kastiglione added a comment. > This doesn't affect any tests? nope Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145529/new/ https://reviews.llvm.org/D145529 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D145529: [lldb] Change default value of dwim-print-verbosity setting

kastiglione added a comment. Clarification: `TestDWIMPrint.py` uses and tests with this setting, but it explicitly sets the value to "full". The default value doesn't affect tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145529/new/ https://

[Lldb-commits] [PATCH] D145529: [lldb] Change default value of dwim-print-verbosity setting

This revision was automatically updated to reflect the committed changes. Closed by commit rG632c396499eb: [lldb] Change default value of dwim-print-verbosity setting (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145529/new

[Lldb-commits] [PATCH] D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c599b1e9b7e: [lldb] Let 'v' command directly access ivars of _any_ self/this (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145276

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

kastiglione added a comment. > But `allow_repeat_command` is a misleading name for that. It makes is sound > like if I don't pass that flag I won't get a repeat command. > `force_repeat_command` would be a better name I agree. I did have some loose thoughts matching this, when writing it, yet

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

kastiglione updated this revision to Diff 503462. kastiglione added a comment. Rename variable to force_repeat_command and add comment block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143695/new/ https://reviews.llvm.org/D143695 Files: lldb/i

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Change `dwim-print` to now disable persistent results by default, unl

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

kastiglione updated this revision to Diff 503515. kastiglione added a comment. Cleanup TestDWIMPrint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145609/new/ https://reviews.llvm.org/D145609 Files: lldb/source/Commands/CommandObjectDWIMPrint.cp

[Lldb-commits] [PATCH] D145612: [lldb] Only replace valobj with persisted one if not null in DWIMPrint

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thank you Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:92-94 +auto persisted_valobj = valobj_sp->Persist(); +if (persisted_valobj) +

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

kastiglione added a comment. thanks for the feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143695/new/ https://reviews.llvm.org/D143695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D143695: [lldb] Make repeat commands work for regex commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e0ee1b395fa: [lldb] Make repeat commands work for regex commands (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143695/new/ https

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bad4ae679df: [lldb] Change dwim-print to default to disabled persistent results (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145

[Lldb-commits] [PATCH] D146230: [lldb][test] Replace use of p with expression in Shell tests (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, mib. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In Shell tests, replace use of the `p` alias with the `expr

[Lldb-commits] [PATCH] D146230: [lldb][test] Replace use of p with expression in Shell tests (NFC)

kastiglione added a comment. > I probably would've gone with `expr` I had it as `expr` at first and changed it to `expression`, since that's what I had done in D141539 . I'm down to change it to `expr`, I think it's probably fine too. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D146230: [lldb][test] Replace use of p with expression in Shell tests (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd875838e8b45: [lldb][test] Replace use of p with expression in Shell tests (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146

[Lldb-commits] [PATCH] D146320: [lldb] Test direct ivar access in objc++ (NFC)

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add an Objective-C++ specific test for direct ivar access. This adds to the

[Lldb-commits] [PATCH] D146320: [lldb] Test direct ivar access in objc++ (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG75fdf7fd1516: [lldb] Test direct ivar access in objc++ (NFC) (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D146320?vs=506157&id=507033#toc Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D146548: [lldb] Refactor deduction of the instance variable's name (NFC)

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Move responsibility of providing the instance variable name (`this`, `self`)

[Lldb-commits] [PATCH] D146548: [lldb] Refactor deduction of the instance variable's name (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGc327f9925428: [lldb] Refactor deduction of the instance variable's name (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146548

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

kastiglione added a comment. > Also `--persistent-result on` can't be passed to print, it only works for me > if I run specifically `dwim-print`. Is that intended? The intension is that for users who want persistent results enabled can do so by customizing their `p` or `print` alias, like so:

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

kastiglione added a comment. > Oh, so in the cases where `dwim-print` delegates to frame variable you can't > then refer to that result in another `dwim-print` command/other place where > you'd like to reference a previously printed value? If the variable is in scope, you can use the variable.

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:669 + r'(0x[0-9a-fA-F]{4,}) +' # addr (4 chars or more) + r'((.*)(?:(?: +\+ +)([0-9]+))|[^\s]+)' # symbol + offset

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:669 + r'(0x[0-9a-fA-F]{4,}) +' # addr (4 chars or more) + r'((.*)(?:(?: +\+ +)([0-9]+))|[^\s]+)' # symbol + offset

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham, jgorbe. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When printing a value, allow the root value's name to be elid

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

kastiglione added a comment. @jgorbe thank you for letting me know! It's not intended that the names of child values are not printed. I have a fix ready for review here D146783 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

kastiglione updated this revision to Diff 508173. kastiglione added a comment. Rename ShowName to ShouldShowName Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146783/new/ https://reviews.llvm.org/D146783 Files: lldb/include/lldb/DataFormatters/D

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

kastiglione added inline comments. Comment at: lldb/source/DataFormatters/ValueObjectPrinter.cpp:278 - if (!m_options.m_hide_name) { + if (ShowName()) { if (m_options.m_flat_output) jgorbe wrote: > This method name reads like a command, rather than a pre

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

This revision was automatically updated to reflect the committed changes. Closed by commit rG23349d83a98f: [lldb] Add ability to hide the root name of a value (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146783/new/ https

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

kastiglione added a comment. @jgorbe thanks for reporting. I have a fix for the missing space, I will look into the cause of the double space and fix that as well. I'll do this today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146783/new/ https

[Lldb-commits] [PATCH] D147006: [lldb] Fix value printing for a specific case

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham, jgorbe. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixes printing of spaces in cases where the following are tru

[Lldb-commits] [PATCH] D147006: [lldb] Fix value printing for a specific case

This revision was automatically updated to reflect the committed changes. Closed by commit rG51dd8a20c1c3: [lldb] Fix value printing for a specific case (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147006/new/ https://rev

[Lldb-commits] [PATCH] D147246: [lldb] Replace sprintf with snprintf (NFC)

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On macOS, `sprintf` is deprecated, using `snprintf` is recommended inste

[Lldb-commits] [PATCH] D147246: [lldb] Replace sprintf with snprintf (NFC)

kastiglione added a comment. That may be better, I don't really know. I would prefer to merge this as is (and leave a printf->formatv migration for another time). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147246/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Following the work done by @jdevlieghere in D143690

[Lldb-commits] [PATCH] D147249: [lldb] Replace deprecated CFPropertyListWriteToStream (NFC)

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Replace `CFPropertyListWriteToStream` with its recommended replacement,

[Lldb-commits] [PATCH] D147249: [lldb] Replace deprecated CFPropertyListWriteToStream (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG80b476a902a8: [lldb] Replace deprecated CFPropertyListWriteToStream (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147249/new

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

kastiglione added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:228 void StoringDiagnosticConsumer::SetCurrentModuleProgress( -llvm::StringRef module_name) { - // Ensure the ordering of: - // 1. Completing the existin

[Lldb-commits] [PATCH] D147246: [lldb] Replace sprintf with snprintf (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd03d98b71d03: [lldb] Replace sprintf with snprintf (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147246/new/ https://review

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

kastiglione added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:228 void StoringDiagnosticConsumer::SetCurrentModuleProgress( -llvm::StringRef module_name) { - // Ensure the ordering of: - // 1. Completing the existin

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

kastiglione updated this revision to Diff 509790. kastiglione added a comment. Use std::string argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147248/new/ https://reviews.llvm.org/D147248 Files: lldb/source/Plugins/ExpressionParser/Clang/

[Lldb-commits] [PATCH] D147248: [lldb] Use one Progress event per root module build

This revision was automatically updated to reflect the committed changes. Closed by commit rG7edff3c1b298: [lldb] Use one Progress event per root module build (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147248/new/ https

[Lldb-commits] [PATCH] D147362: [lldb] Add Clang module import logging

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Log Clang module imports to lldb's `expr` channel. This is minor add-on to D

[Lldb-commits] [PATCH] D147362: [lldb] Add Clang module import logging

kastiglione updated this revision to Diff 510234. kastiglione added a comment. Add -Rmodule-import flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147362/new/ https://reviews.llvm.org/D147362 Files: lldb/source/Plugins/ExpressionParser/Clang/

[Lldb-commits] [PATCH] D147385: [lldb] Add fixits for "frame variable"

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham, JDevlieghere, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `frame variable` command can handle mi

[Lldb-commits] [PATCH] D147385: [lldb] Add fixits for "frame variable"

kastiglione updated this revision to Diff 510280. kastiglione added a comment. Change --apply-fixits take an argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147385/new/ https://reviews.llvm.org/D147385 Files: lldb/include/lldb/Interpreter

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:669 + r'(0x[0-9a-fA-F]{4,}) +' # addr (4 chars or more) + r'((.*)(?:(?: +\+ +)([0-9]+))|[^\s]+)' # symbol + offset

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a `StringRef` conversion function to `ConstString`.

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

This revision was automatically updated to reflect the committed changes. Closed by commit rGce7a54a27c09: [lldb] Add `operator StringRef` to ConstString (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148175/new/ https://re

<    1   2   3   4   5   6   7   8   >