DanielCChen wrote:
The changes look good to me. I will wait a day to see if other reviewers have
any more comments before approving it.
https://github.com/llvm/llvm-project/pull/73254
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://l
DanielCChen wrote:
Sorry about the noise. All the reverts are in a private branch on my fork repo.
I didn't know it would broadcast to all the people who worked on the reverted
commits. My apologies.
https://github.com/llvm/llvm-project/pull/67599
__
DanielCChen wrote:
I think it is still my fault because it is indeed a PR branch that I did revert
even though it is on my forked repo. I guess GitHub is doing the right thing to
notify everyone affected as the PR could be potentially merged onto upstream
branch by accident if it is approved.
https://github.com/DanielCChen closed
https://github.com/llvm/llvm-project/pull/131200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DanielCChen edited
https://github.com/llvm/llvm-project/pull/131200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
DanielCChen wrote:
I will revert this commit first.
https://github.com/llvm/llvm-project/pull/131200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 95377273d069e76023edf7ecc2df473e4e2f4aaa Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 01/10] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DI
@@ -109,7 +109,7 @@ if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE)
extend_path(default_install_path "${COMPILER_RT_INSTALL_PATH}" lib)
set(COMPILER_RT_INSTALL_LIBRARY_DIR "${default_install_path}" CACHE PATH
"Path where built compiler-rt libraries should be instal
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
DanielCChen wrote:
> > > Wouldn't it be more maintainable to just force the value to OFF for AIX
> > > where the `option()` is defined?
> >
> >
> > Unfortunately, the cmake command line option
> > `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON` overrides the `option()` in the
> > cmake file.
>
>
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/6] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/5] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/2] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON
o
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/3] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/4] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/9] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
DanielCChen wrote:
@arichardson I found the way to override the cache file. Thanks for the
suggestion!
https://github.com/llvm/llvm-project/pull/131200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/8] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
@@ -1187,16 +1187,19 @@ endif()
# Build with _XOPEN_SOURCE on AIX, as stray macros in _ALL_SOURCE mode tend to
# break things. In this case we need to enable the large-file API as well.
if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
- add_compile_definitions(_XOPEN_S
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 1283ba24387e01aafcfc99e5db3f16c91deb5ac0 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 1/7] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=
https://github.com/DanielCChen created
https://github.com/llvm/llvm-project/pull/131200
We don't plan to support it on AIX.
This change will make it as if it is set to OFF.
>From 37eb6964a176dd566b3600c0fb15a1d426551729 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23
DanielCChen wrote:
> Wouldn't it be more maintainable to just force the value to OFF for AIX where
> the `option()` is defined?
Unfortunately, the cmake command line option `-D
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON` overrides the `option()` in the cmake
file.
https://github.com/llvm/llvm-pro
DanielCChen wrote:
I will check all those failures and push an update soon.
https://github.com/llvm/llvm-project/pull/131200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 55653ee989d41d4caf5ba5396bb2406dcc443945 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 01/10] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DI
27 matches
Mail list logo
