[Lldb-commits] [lldb] r268520 - Fix a SIGSEGV caused by dereferencing a pointer without a null check

2016-05-04 Thread Bryan Chan via lldb-commits
Author: bryanpkc Date: Wed May 4 12:24:31 2016 New Revision: 268520 URL: http://llvm.org/viewvc/llvm-project?rev=268520&view=rev Log: Fix a SIGSEGV caused by dereferencing a pointer without a null check Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp Modified: lldb

[Lldb-commits] [PATCH] D20355: Avoid an assertion failure when a bit field is extracted from a value of the same size.

2016-05-18 Thread Bryan Chan via lldb-commits
bryanpkc created this revision. bryanpkc added a reviewer: uweigand. bryanpkc added a subscriber: lldb-commits. One of the cases handled by ValueObjectChild::UpdateValue() uses the entire width of the parent's scalar value as the size of the child, and extracts the child by calling Scalar::Extra

Re: [Lldb-commits] [PATCH] D20355: Avoid an assertion failure when a bit field is extracted from a value of the same size.

2016-05-18 Thread Bryan Chan via lldb-commits
bryanpkc updated this revision to Diff 57695. bryanpkc added a comment. Added a unit test in ScalarTest.cpp that catches this particular error. http://reviews.llvm.org/D20355 Files: source/Core/Scalar.cpp unittests/Core/ScalarTest.cpp Index: unittests/Core/ScalarTest.cpp ==

Re: [Lldb-commits] [PATCH] D20355: Avoid an assertion failure when a bit field is extracted from a value of the same size.

2016-05-19 Thread Bryan Chan via lldb-commits
bryanpkc added a comment. In http://reviews.llvm.org/D20355#434117, @labath wrote: > Do you have commit access? Yes I do. Thanks for your review! Comment at: unittests/Core/ScalarTest.cpp:90 @@ +89,3 @@ +ASSERT_TRUE(s_scalar.ExtractBitfield(0, 0)); +ASSERT_EQ(0, memcm

[Lldb-commits] [lldb] r270062 - Avoid an assertion failure when a bit field is extracted from a value of the same size.

2016-05-19 Thread Bryan Chan via lldb-commits
Author: bryanpkc Date: Thu May 19 08:51:20 2016 New Revision: 270062 URL: http://llvm.org/viewvc/llvm-project?rev=270062&view=rev Log: Avoid an assertion failure when a bit field is extracted from a value of the same size. Summary: One of the cases handled by ValueObjectChild::UpdateValue() uses