[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

andcarminati added inline comments. Comment at: lldb/tools/driver/Driver.cpp:673-674 +static void sigtstp_handler(int signo) { if (g_driver != nullptr) g_driver->GetDebugger().SaveInputTerminalState(); JDevlieghere wrote: > labath wrote: > > JDevliegher

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

andcarminati added inline comments. Comment at: lldb/tools/driver/Driver.cpp:673-674 +static void sigtstp_handler(int signo) { if (g_driver != nullptr) g_driver->GetDebugger().SaveInputTerminalState(); labath wrote: > JDevlieghere wrote: > > andcarminat

[Lldb-commits] [PATCH] D120578: [lldb] Implement ObjectFile::GetCStrFromSection

andcarminati added inline comments. Comment at: lldb/source/Symbol/ObjectFile.cpp:559 + lldb::offset_t section_offset) const { + offset_t offset = section->GetOffset() + section_offset; + return m_data.GetCStr(&offset); Wouldn't it