[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s stella.stamenova wrote: > One thing to consider here is that any extra

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s stella.stamenova wrote: > apolyakov wrote: > > stella.stamenova wrote:

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/target-list.test:18 +target list +# CHECK: ~"Current targets:\n* target #0: {{.*}}a.exe{{.*}}\n" + aprantl wrote: > Does lldb-mi echo the comment lines? If yes, you need to be

[Lldb-commits] [PATCH] D51594: [ARC] Make char unsigned by default

apolyakov created this revision. apolyakov added a reviewer: tatyana-krasnukha. This patch specifies 'char' default sign on ARC. Repository: rLLDB LLDB https://reviews.llvm.org/D51594 Files: source/Utility/ArchSpec.cpp Index: source/Utility/ArchSpec.cpp ==

[Lldb-commits] [PATCH] D51594: [ARC] Make char unsigned by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL341667: [ARC] Make char unsigned by default (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51594?vs=163710&id=164419#

[Lldb-commits] [PATCH] D52101: [lldb-mi] Correct regex in the symbol-list-lines test

apolyakov created this revision. apolyakov added reviewers: tatyana-krasnukha, aprantl, clayborg. Herald added a subscriber: ki.stfu. The test failed in case of compiling a test suite with gcc (checked versions are 5.2.0 and 7.3.0) because it adds one more line entry comparing to clang. It doesn't

[Lldb-commits] [PATCH] D52101: [lldb-mi] Correct regex in the symbol-list-lines test

apolyakov added a comment. I've created this revision to be sure that you don't think that this approach is some kind of hack. Repository: rLLDB LLDB https://reviews.llvm.org/D52101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

[Lldb-commits] [PATCH] D52101: [lldb-mi] Correct regex in the symbol-list-lines test

This revision was automatically updated to reflect the committed changes. Closed by commit rL342329: [lldb-mi] Correct regex in the symbol-list-lines test (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52101?vs

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

apolyakov added a comment. In https://reviews.llvm.org/D48802#1234892, @tatyana-krasnukha wrote: > symbol-list-lines.test fails on Linux too, input is compiled with gcc. Thanks for noting this. Fixed in r342329 (https://reviews.llvm.org/D52101). Repository: rL LLVM https://reviews.llvm.org

[Lldb-commits] [PATCH] D52139: [lldb-mi] Improve lldb-mi LIT tests

apolyakov created this revision. apolyakov added reviewers: tatyana-krasnukha, aprantl. Herald added subscribers: abidh, ki.stfu. The test suite might hang on some platforms if an lldb-mi test fails. Adding of -gdb-exit command to a test prevents it from hanging and hence increase test suite relia

[Lldb-commits] [PATCH] D52139: [lldb-mi] Improve lldb-mi LIT tests

apolyakov added a comment. It seems reasonable, I'll look at this. Repository: rLLDB LLDB https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov updated this revision to Diff 166290. apolyakov retitled this revision from "[lldb-mi] Improve lldb-mi LIT tests" to "[lldb-mi] Fix hanging of target-select-so-path.test". apolyakov edited the summary of this revision. apolyakov added a comment. I found out that the reason of hanging of

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. Can you provide some logs? For example, you might be able to run this test (llvm-lit -a -vv .../target-select-so-path.test) and kill lldb-mi and filecheck processes if they hang. Also, information about which processes hang would be useful too (lldb-mi or filecheck or

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov updated this revision to Diff 166337. apolyakov edited the summary of this revision. apolyakov added a comment. Thanks to @tatyana-krasnukha for the idea about a timer. Added a timer to target-select-so-path test. https://reviews.llvm.org/D52139 Files: lit/tools/lldb-mi/target/inpu

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. In https://reviews.llvm.org/D52139#1240835, @apolyakov wrote: > Can you provide some logs? For example, you might be able to run this test > (llvm-lit -a -vv .../target-select-so-path.test) and kill lldb-mi and > filecheck processes if they hang. Also, information abo

[Lldb-commits] [PATCH] D46588: [WIP][LLDB-MI] Add possibility to set breakpoints without selecting a target.

polyakov.alex created this revision. polyakov.alex added reviewers: aprantl, clayborg. polyakov.alex added a project: LLDB. Herald added subscribers: llvm-commits, ki.stfu. It's not a final version of the patch, testcase will be added. Repository: rL LLVM https://reviews.llvm.org/D46588 File

[Lldb-commits] [PATCH] D46588: [WIP][LLDB-MI] Add possibility to set breakpoints without selecting a target.

polyakov.alex added inline comments. Comment at: tools/lldb-mi/MICmdCmdBreak.cpp:166 + + if (sbTarget == rSessionInfo.GetDebugger().GetDummyTarget()) +m_bBrkPtIsPending = true; I want to discuss is it a good way to use 'pending' breakpoint's here? Reposito

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

polyakov.alex updated this revision to Diff 145909. polyakov.alex retitled this revision from "[WIP][LLDB-MI] Add possibility to set breakpoints without selecting a target." to "[LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.". polyakov.alex edited the summary of th

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

apolyakov created this revision. apolyakov added reviewers: jingham, aprantl, labath. Herald added a project: LLDB. This commit shows how LLDB python plug-in could look like. Such an approach allows users to use LLDB for OS kernel debugging, for doing that they only need to implement two interfa

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

apolyakov marked an inline comment as done. apolyakov added a comment. In D60968#1474470 , @clayborg wrote: > Not sure what functionality this really adds? It seems to just wrap the OS > plug-in python class in a different way? You are right, for now th

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

apolyakov abandoned this revision. apolyakov added a comment. Abandoned since for now, it will require a lot of changes to the codebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60968/new/ https://reviews.llvm.org/D60968 ___

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov abandoned this revision. apolyakov added a comment. Herald added a subscriber: JDevlieghere. Abandoned since the patch is outdated too much. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50525/new/ https://reviews.llvm.org/D50525 __

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

apolyakov added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60968/new/ https://reviews.llvm.org/D60968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

<    1   2   3